Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/4814#issuecomment-76367447
I agree. LGTM pending tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/4813#issuecomment-76367261
OK, this is basically an addendum to SPARK-6018 and should follow it.
Throwing the exception from a raw `Thread` won't log it by itself, and it seems
the intent was to log
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4814#issuecomment-76367001
[Test build #28063 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28063/consoleFull)
for PR 4814 at commit
[`17d9386`](https://githu
GitHub user zsxwing opened a pull request:
https://github.com/apache/spark/pull/4814
[SPARK-6059][Yarn] Add volatile to ApplicationMaster's reporterThread and
allocator
`ApplicationMaster.reporterThread` and `ApplicationMaster.allocator` are
accessed in multiple threads, so they sh
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/4804#discussion_r25496541
--- Diff:
core/src/test/java/org/apache/spark/util/collection/TestTimSort.java ---
@@ -0,0 +1,111 @@
+package org.apache.spark.util.collection;
+
+
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2765#issuecomment-76363323
[Test build #28062 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28062/consoleFull)
for PR 2765 at commit
[`6620143`](https://githu
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/4362#issuecomment-76363290
Mind closing this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fe
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4055#issuecomment-76362137
[Test build #28061 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28061/consoleFull)
for PR 4055 at commit
[`9025cf1`](https://githu
Github user lianhuiwang commented on the pull request:
https://github.com/apache/spark/pull/4813#issuecomment-76362065
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enable
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4813#issuecomment-76361433
[Test build #28060 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28060/consoleFull)
for PR 4813 at commit
[`806c932`](https://githu
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/1292#issuecomment-76360812
@nchammas @kellrott Sorry that I haven't got a time to review this PR. The
main issue is that this PR is not small. Though there are no break changes, the
added code is ve
GitHub user zsxwing opened a pull request:
https://github.com/apache/spark/pull/4813
[SPARK-6058][Yarn] Log the user class exception in ApplicationMaster
Because ApplicationMaster doesn't set SparkUncaughtExceptionHandler, the
exception in the user class won't be logged. This PR add
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4810#issuecomment-76360577
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28055/consoleFull)
for PR 4810 at commit
[`f748114`](https://github.com/a
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4810#issuecomment-76360586
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4811#issuecomment-76360565
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4811#issuecomment-76360555
[Test build #28056 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28056/consoleFull)
for PR 4811 at commit
[`282ec8d`](https://gith
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4525#issuecomment-76359067
[Test build #28059 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28059/consoleFull)
for PR 4525 at commit
[`9244bb6`](https://githu
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4812#issuecomment-76358496
[Test build #28058 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28058/consoleFull)
for PR 4812 at commit
[`3d6934c`](https://githu
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4809#issuecomment-76358458
[Test build #28054 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28054/consoleFull)
for PR 4809 at commit
[`6c2909a`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4809#issuecomment-76358463
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28
Github user chenghao-intel commented on the pull request:
https://github.com/apache/spark/pull/3249#issuecomment-76358262
@ravipesala I've created another PR for `[NOT]EXISTS`, I believe the `IN`
can be transformed into `EXISTS` and the implementation can be much more
simple, can you
GitHub user chenghao-intel opened a pull request:
https://github.com/apache/spark/pull/4812
[SPARK-4226] [SQL] Add Exists support for where clause
Rewrite the `[NOT] EXISTS` clause as `left semi join`. Still we need to add
the `[NOT] IN` support.
You can merge this pull request int
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4525#issuecomment-76357565
[Test build #28057 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28057/consoleFull)
for PR 4525 at commit
[`8475136`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4525#issuecomment-76357567
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4525#issuecomment-76357398
[Test build #28057 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28057/consoleFull)
for PR 4525 at commit
[`8475136`](https://githu
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4808#issuecomment-76355323
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4808#issuecomment-76355317
[Test build #28053 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28053/consoleFull)
for PR 4808 at commit
[`d9ae973`](https://gith
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4807#issuecomment-76354546
[Test build #28052 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28052/consoleFull)
for PR 4807 at commit
[`e895f38`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4807#issuecomment-76354552
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28
401 - 429 of 429 matches
Mail list logo
