[GitHub] spark pull request: [SPARK-6080] [PySpark] correct LogisticRegress...

2015-03-01 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/4831#discussion_r25582380 --- Diff: python/pyspark/mllib/classification.py --- @@ -207,7 +207,7 @@ def train(cls, data, iterations=100, initialWeights=None, regParam=0.01, regType

[GitHub] spark pull request: [SPARK-3586][streaming]Support nested director...

2015-03-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2765#issuecomment-76671073 [Test build #28161 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28161/consoleFull) for PR 2765 at commit [`2068255`](https://githu

[GitHub] spark pull request: SPARK-5628 [EC2] Backport: Add version option ...

2015-03-01 Thread srowen
Github user srowen closed the pull request at: https://github.com/apache/spark/pull/4833 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-6077] update listener for the existing ...

2015-03-01 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/4828#discussion_r25582261 --- Diff: streaming/src/main/scala/org/apache/spark/streaming/ui/StreamingTab.scala --- @@ -29,19 +29,29 @@ import StreamingTab._ */ private[spark]

[GitHub] spark pull request: [SPARK-6077] update listener for the existing ...

2015-03-01 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/4828#discussion_r25582237 --- Diff: streaming/src/main/scala/org/apache/spark/streaming/ui/StreamingPage.scala --- @@ -20,20 +20,26 @@ package org.apache.spark.streaming.ui import

[GitHub] spark pull request: [SPARK-6066] Make event log format easier to p...

2015-03-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4821#issuecomment-76669704 [Test build #28158 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28158/consoleFull) for PR 4821 at commit [`59abee9`](https://gith

[GitHub] spark pull request: [SPARK-5016] Distribute Gaussian Initializatio...

2015-03-01 Thread MechCoder
Github user MechCoder commented on the pull request: https://github.com/apache/spark/pull/4654#issuecomment-76669702 Hi, Sorry for taking so much time to get back to this. I want to generate some random data to write this script using breeze. But I unable to understand how the random

[GitHub] spark pull request: [SPARK-6066] Make event log format easier to p...

2015-03-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4821#issuecomment-76669712 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28

[GitHub] spark pull request: [SPARK-6066] Make event log format easier to p...

2015-03-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4821#issuecomment-76668874 [Test build #28157 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28157/consoleFull) for PR 4821 at commit [`40e1ff6`](https://gith

[GitHub] spark pull request: [SPARK-6066] Make event log format easier to p...

2015-03-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4821#issuecomment-76668879 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28

[GitHub] spark pull request: [SPARK-6040][SQL] Fix the percent bug in table...

2015-03-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4789#issuecomment-76667055 [Test build #28160 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28160/consoleFull) for PR 4789 at commit [`2453ebe`](https://githu

[GitHub] spark pull request: [SPARK-6040][SQL] Fix the percent bug in table...

2015-03-01 Thread watermen
Github user watermen commented on a diff in the pull request: https://github.com/apache/spark/pull/4789#discussion_r25581012 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveQl.scala --- @@ -850,7 +851,14 @@ https://cwiki.apache.org/confluence/display/Hive/Enhanced+A

[GitHub] spark pull request: [SPARK-6066] Make event log format easier to p...

2015-03-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4821#issuecomment-7392 [Test build #28159 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28159/consoleFull) for PR 4821 at commit [`7d6aa61`](https://githu

[GitHub] spark pull request: [SPARK-5205][Streaming]:Inconsistent behaviour...

2015-03-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4135#issuecomment-76665998 [Test build #28156 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28156/consoleFull) for PR 4135 at commit [`047931c`](https://gith

[GitHub] spark pull request: [SPARK-5205][Streaming]:Inconsistent behaviour...

2015-03-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4135#issuecomment-7004 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28

[GitHub] spark pull request: Refactored Dataframe join comment to use corre...

2015-03-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4847#issuecomment-76665628 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pro

[GitHub] spark pull request: Refactored Dataframe join comment to use corre...

2015-03-01 Thread peerside
GitHub user peerside opened a pull request: https://github.com/apache/spark/pull/4847 Refactored Dataframe join comment to use correct parameter ordering The API signatire for join requires the JoinType to be the third parameter. The code examples provided for join show JoinType bei

[GitHub] spark pull request: [SPARK-6066] Make event log format easier to p...

2015-03-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4821#issuecomment-76663956 [Test build #28158 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28158/consoleFull) for PR 4821 at commit [`59abee9`](https://githu

[GitHub] spark pull request: [SPARK-6066] Make event log format easier to p...

2015-03-01 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/4821#issuecomment-76663334 As of the latest commit I have removed the Spark version and the metadata. Please have a look. --- If your project is set up for it, you can reply to this email and h

[GitHub] spark pull request: [SPARK-6066] Make event log format easier to p...

2015-03-01 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/4821#discussion_r25579983 --- Diff: core/src/main/scala/org/apache/spark/scheduler/ReplayListenerBus.scala --- @@ -39,10 +39,9 @@ private[spark] class ReplayListenerBus extends Spa

[GitHub] spark pull request: [SPARK-6066] Make event log format easier to p...

2015-03-01 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/4821#discussion_r25579955 --- Diff: core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala --- @@ -322,28 +322,22 @@ private[history] class FsHistoryProvider(conf

[GitHub] spark pull request: [SPARK-6066] Make event log format easier to p...

2015-03-01 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/4821#discussion_r25579899 --- Diff: core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala --- @@ -322,28 +322,22 @@ private[history] class FsHistoryProvider(conf

[GitHub] spark pull request: [SPARK-5205][Streaming]:Inconsistent behaviour...

2015-03-01 Thread uncleGen
Github user uncleGen commented on the pull request: https://github.com/apache/spark/pull/4135#issuecomment-76663454 @JoshRosen Could you please take a look again, thank you! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] spark pull request: [SPARK-6066] Make event log format easier to p...

2015-03-01 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/4821#discussion_r25579888 --- Diff: core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala --- @@ -322,28 +322,22 @@ private[history] class FsHistoryProvider(conf

[GitHub] spark pull request: [SPARK-6088] Correct how tasks that get remote...

2015-03-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4839#issuecomment-76663135 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28

[GitHub] spark pull request: [SPARK-6066] Make event log format easier to p...

2015-03-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4821#issuecomment-76663276 [Test build #28157 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28157/consoleFull) for PR 4821 at commit [`40e1ff6`](https://githu

[GitHub] spark pull request: [SPARK-6088] Correct how tasks that get remote...

2015-03-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4839#issuecomment-76663130 [Test build #28155 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28155/consoleFull) for PR 4839 at commit [`3ab012c`](https://gith

[GitHub] spark pull request: [SPARK-6040][SQL] Fix the percent bug in table...

2015-03-01 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/4789#discussion_r25579743 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveQuerySuite.scala --- @@ -465,10 +465,14 @@ class HiveQuerySuite extends HiveCompariso

[GitHub] spark pull request: [SPARK-6040][SQL] Fix the percent bug in table...

2015-03-01 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/4789#discussion_r25579694 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveQl.scala --- @@ -850,7 +851,14 @@ https://cwiki.apache.org/confluence/display/Hive/Enhanced+Aggr

[GitHub] spark pull request: [SPARK-6066] Make event log format easier to p...

2015-03-01 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/4821#discussion_r25579333 --- Diff: core/src/main/scala/org/apache/spark/deploy/ApplicationDescription.scala --- @@ -23,7 +23,9 @@ private[spark] class ApplicationDescription(

[GitHub] spark pull request: [SPARK-6088] Correct how tasks that get remote...

2015-03-01 Thread shivaram
Github user shivaram commented on the pull request: https://github.com/apache/spark/pull/4839#issuecomment-76660748 No it was based on the old code. Didn't get a chance to run this on the cluster yet. --- If your project is set up for it, you can reply to this email and have your rep

[GitHub] spark pull request: [SPARK-5205][Streaming]:Inconsistent behaviour...

2015-03-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4135#issuecomment-76660466 [Test build #28156 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28156/consoleFull) for PR 4135 at commit [`047931c`](https://githu

[GitHub] spark pull request: [SPARK-5205][Streaming]:Inconsistent behaviour...

2015-03-01 Thread uncleGen
GitHub user uncleGen reopened a pull request: https://github.com/apache/spark/pull/4135 [SPARK-5205][Streaming]:Inconsistent behaviour between Streaming job and others, when click kill link in WebUI The "kill" link is used to kill a stage in job. It works in any kinds of Spark job

[GitHub] spark pull request: [SPARK-6077] update listener for the existing ...

2015-03-01 Thread zhichao-li
Github user zhichao-li commented on a diff in the pull request: https://github.com/apache/spark/pull/4828#discussion_r25578794 --- Diff: streaming/src/main/scala/org/apache/spark/streaming/ui/StreamingTab.scala --- @@ -29,19 +29,30 @@ import StreamingTab._ */ private[spa

[GitHub] spark pull request: [SPARK-6050] [yarn] Add config option to do la...

2015-03-01 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/4818#issuecomment-76659139 @vanzin okay so maybe set this to true then? I don't have any opinion, but would love to get this in as it's one of the only release blockers. --- If your project is se

[GitHub] spark pull request: [SPARK-6088] Correct how tasks that get remote...

2015-03-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4839#issuecomment-76658178 [Test build #28155 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28155/consoleFull) for PR 4839 at commit [`3ab012c`](https://githu

[GitHub] spark pull request: [SPARK-6088] Correct how tasks that get remote...

2015-03-01 Thread kayousterhout
Github user kayousterhout commented on the pull request: https://github.com/apache/spark/pull/4839#issuecomment-76657966 @shivaram Fixed this, and @srowen thanks for pointing out the issue with the GET_RESULT status!! Shivaram, did you run this patch on your cluster? Or was your comm

[GitHub] spark pull request: [SPARK-6103][Graphx]remove unused class to imp...

2015-03-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4846#issuecomment-76657370 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28

[GitHub] spark pull request: [SPARK-6103][Graphx]remove unused class to imp...

2015-03-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4846#issuecomment-76657364 [Test build #28154 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28154/consoleFull) for PR 4846 at commit [`31aed64`](https://gith

[GitHub] spark pull request: [SPARK-5950][SQL]Insert array into a metastore...

2015-03-01 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/4826#issuecomment-76655461 A typo in the PR description: > However, the nullability of `ArrayType(IntegerType, containsNull = true)` is compatible with that of `ArrayType(IntegerType, con

[GitHub] spark pull request: [SPARK-6040][SQL] Fix the percent bug in table...

2015-03-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4789#issuecomment-76655322 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28

[GitHub] spark pull request: [SPARK-6040][SQL] Fix the percent bug in table...

2015-03-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4789#issuecomment-76655313 [Test build #28153 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28153/consoleFull) for PR 4789 at commit [`01abcce`](https://gith

[GitHub] spark pull request: [SPARK-5205][Streaming]:Inconsistent behaviour...

2015-03-01 Thread uncleGen
Github user uncleGen closed the pull request at: https://github.com/apache/spark/pull/4135 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is en

[GitHub] spark pull request: [HOTFIX] Rename the identifier of driver from ...

2015-03-01 Thread tsingfu
Github user tsingfu commented on the pull request: https://github.com/apache/spark/pull/4245#issuecomment-76655144 @sarutak I found #4209 has not solved the problem invalid metric name with "" which introduced from #3812. and I have a question: Is there difference between setting

[GitHub] spark pull request: [SPARK-6066] Make event log format easier to p...

2015-03-01 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/4821#discussion_r25577300 --- Diff: core/src/main/scala/org/apache/spark/deploy/ApplicationDescription.scala --- @@ -23,7 +23,9 @@ private[spark] class ApplicationDescription(

[GitHub] spark pull request: [SPARK-6066] Make event log format easier to p...

2015-03-01 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/4821#discussion_r25577271 --- Diff: core/src/main/scala/org/apache/spark/scheduler/EventLoggingListener.scala --- @@ -217,57 +223,67 @@ private[spark] object EventLoggingListener ex

[GitHub] spark pull request: [SPARK-6048] SparkConf should not translate de...

2015-03-01 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/4799#discussion_r25577265 --- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala --- @@ -92,6 +92,16 @@ private[spark] class Executor( private val executorActo

[GitHub] spark pull request: [SPARK-4226] [SQL] Add Exists support for wher...

2015-03-01 Thread chenghao-intel
Github user chenghao-intel commented on the pull request: https://github.com/apache/spark/pull/4812#issuecomment-76652801 @marmbrus, any comment on this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project doe

[GitHub] spark pull request: [SPARK-6103][Graphx]remove unused class to imp...

2015-03-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4846#issuecomment-76652588 [Test build #28154 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28154/consoleFull) for PR 4846 at commit [`31aed64`](https://githu

[GitHub] spark pull request: [SPARK-6103][Graphx]remove unused class to imp...

2015-03-01 Thread lianhuiwang
GitHub user lianhuiwang opened a pull request: https://github.com/apache/spark/pull/4846 [SPARK-6103][Graphx]remove unused class to import in EdgeRDDImpl Class TaskContext is unused in EdgeRDDImpl, so we need to remove it from import list. You can merge this pull request into a Git

[GitHub] spark pull request: [SPARK-6040][SQL] Fix the percent bug in table...

2015-03-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4789#issuecomment-76650894 [Test build #28153 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28153/consoleFull) for PR 4789 at commit [`01abcce`](https://githu

[GitHub] spark pull request: [SPARK-6040][SQL] Fix the percent bug in table...

2015-03-01 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/4789#issuecomment-76650849 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enable

[GitHub] spark pull request: [SPARK-5205][Streaming]:Inconsistent behaviour...

2015-03-01 Thread uncleGen
Github user uncleGen commented on the pull request: https://github.com/apache/spark/pull/4135#issuecomment-76650327 @JoshRosen Could you please take a look again, thank you. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] spark pull request: [SPARK-4777][CORE] Some block memory after unr...

2015-03-01 Thread suyanNone
Github user suyanNone commented on the pull request: https://github.com/apache/spark/pull/3629#issuecomment-76649122 ping @andrewor14 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fea

[GitHub] spark pull request: [SPARK-5712] [SQL] fix comment with semicolon ...

2015-03-01 Thread adrian-wang
Github user adrian-wang commented on the pull request: https://github.com/apache/spark/pull/4500#issuecomment-76648856 cc @rxin @marmbrus @liancheng --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-5741][SQL] Support the path contains co...

2015-03-01 Thread watermen
Github user watermen commented on the pull request: https://github.com/apache/spark/pull/4532#issuecomment-76648469 @marmbrus @rxin Can it be merged? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does n

[GitHub] spark pull request: [SPARK-5741][SQL] Support the path contains co...

2015-03-01 Thread watermen
Github user watermen commented on the pull request: https://github.com/apache/spark/pull/4532#issuecomment-76648238 @marmbrus @Cheng Lian Can it be merged? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project d

[GitHub] spark pull request: [SPARK-6040][SQL] Fix the percent bug in table...

2015-03-01 Thread chenghao-intel
Github user chenghao-intel commented on the pull request: https://github.com/apache/spark/pull/4789#issuecomment-76648220 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have th

[GitHub] spark pull request: [SPARK-6040][SQL] Fix the percent bug in table...

2015-03-01 Thread watermen
Github user watermen commented on the pull request: https://github.com/apache/spark/pull/4789#issuecomment-76648025 @yhuai Can you trigger the test for me? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project d

[GitHub] spark pull request: [SPARK-1987] EdgePartitionBuilder: More memory...

2015-03-01 Thread larryxiao
Github user larryxiao commented on the pull request: https://github.com/apache/spark/pull/2446#issuecomment-76647871 @nchammas The QA test result is not available now, I'll run the test again tomorrow. --- If your project is set up for it, you can reply to this email and have you

[GitHub] spark pull request: SPARK-3357 [CORE] Internal log messages should...

2015-03-01 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/4838#discussion_r25574579 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala --- @@ -1074,7 +1074,7 @@ private[spark] class BlockManager( * Remove all b

[GitHub] spark pull request: [SPARK-6066] Make event log format easier to p...

2015-03-01 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/4821#issuecomment-76641955 I took a pass on this with some feedback. Overall, it would be good to really minimize the scope of the changes since this is so late in the game. There is some clean-up

[GitHub] spark pull request: [SPARK-4011] tighten the visibility of the mem...

2015-03-01 Thread CodingCat
Github user CodingCat commented on the pull request: https://github.com/apache/spark/pull/4844#issuecomment-76641808 Thanks, @srowen and @JoshRosen , So, shall we propogate this change to other classes in the deploy package, in this PR or a different PR? e.g.

[GitHub] spark pull request: [SPARK-6066] Make event log format easier to p...

2015-03-01 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/4821#discussion_r25574126 --- Diff: core/src/main/scala/org/apache/spark/scheduler/SparkListener.scala --- @@ -99,6 +99,12 @@ case class SparkListenerExecutorRemoved(time: Long, exec

[GitHub] spark pull request: [SPARK-6083] [MLLib] [DOC] Make Python API exa...

2015-03-01 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/4834#issuecomment-76641038 Merged into master and branch-1.3. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-6083] [MLLib] [DOC] Make Python API exa...

2015-03-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/4834 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-6053][MLLIB] support save/load in PySpa...

2015-03-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/4811 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-6053][MLLIB] support save/load in PySpa...

2015-03-01 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/4811#issuecomment-76640956 Merged into master and branch-1.3. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-6066] Make event log format easier to p...

2015-03-01 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/4821#discussion_r25573931 --- Diff: core/src/main/scala/org/apache/spark/deploy/ApplicationDescription.scala --- @@ -23,7 +23,9 @@ private[spark] class ApplicationDescription(

[GitHub] spark pull request: [SPARK-6066] Make event log format easier to p...

2015-03-01 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/4821#discussion_r25573801 --- Diff: core/src/main/scala/org/apache/spark/scheduler/EventLoggingListener.scala --- @@ -217,57 +223,67 @@ private[spark] object EventLoggingListener exte

[GitHub] spark pull request: [SPARK-6066] Make event log format easier to p...

2015-03-01 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/4821#discussion_r25573776 --- Diff: core/src/main/scala/org/apache/spark/scheduler/EventLoggingListener.scala --- @@ -217,57 +223,67 @@ private[spark] object EventLoggingListener exte

[GitHub] spark pull request: [SPARK-4011] tighten the visibility of the mem...

2015-03-01 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/4844#issuecomment-76639732 I'm in favor of this change. Even if this class is private within the deploy package, keeping everything at the minimum visibility is a good programming practice and m

[GitHub] spark pull request: [SPARK-6048] SparkConf should not translate de...

2015-03-01 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/4799#discussion_r25573606 --- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala --- @@ -92,6 +92,16 @@ private[spark] class Executor( private val executorActor

[GitHub] spark pull request: [SPARK-1987] EdgePartitionBuilder: More memory...

2015-03-01 Thread nchammas
Github user nchammas commented on the pull request: https://github.com/apache/spark/pull/2446#issuecomment-76636221 @ankurdave @larryxiao This PR has gone stale. Do we want to update it, or close and revisit it later? --- If your project is set up for it, you can reply to thi

[GitHub] spark pull request: Add a function that can build an EdgePartition...

2015-03-01 Thread nchammas
Github user nchammas commented on the pull request: https://github.com/apache/spark/pull/792#issuecomment-76636143 This PR has gone stale. Through the discussion here, it seems like we want this change, contingent on some updates. @ankurdave @lianhuiwang Do we want to update t

[GitHub] spark pull request: SPARK-5628 [EC2] Backport: Add version option ...

2015-03-01 Thread nchammas
Github user nchammas commented on the pull request: https://github.com/apache/spark/pull/4833#issuecomment-76635980 @srowen Did something go wrong with the merge script? This PR is still open. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request: [SPARK-6053][MLLIB] support save/load in PySpa...

2015-03-01 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/4811#issuecomment-76629958 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark pull request: [SPARK-6053][MLLIB] support save/load in PySpa...

2015-03-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4811#issuecomment-76627491 [Test build #28151 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28151/consoleFull) for PR 4811 at commit [`f135dac`](https://gith

[GitHub] spark pull request: [SPARK-6083] [MLLib] [DOC] Make Python API exa...

2015-03-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4834#issuecomment-76627473 [Test build #28152 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28152/consoleFull) for PR 4834 at commit [`1cdd7b5`](https://gith

[GitHub] spark pull request: [SPARK-6053][MLLIB] support save/load in PySpa...

2015-03-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4811#issuecomment-76627492 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28

[GitHub] spark pull request: [SPARK-6083] [MLLib] [DOC] Make Python API exa...

2015-03-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4834#issuecomment-76627476 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28

[GitHub] spark pull request: [SPARK-6080] [PySpark] correct LogisticRegress...

2015-03-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4831#issuecomment-76627211 [Test build #28150 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28150/consoleFull) for PR 4831 at commit [`12db65a`](https://gith

[GitHub] spark pull request: [SPARK-5771][UI] Display the actual cores requ...

2015-03-01 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/4841#issuecomment-76627198 Hm, then `actualCoresRequested` is not a good name, since it is not the number requested. But then how is this different from `coresGranted`? there seem to be only two val

[GitHub] spark pull request: [SPARK-6080] [PySpark] correct LogisticRegress...

2015-03-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4831#issuecomment-76627216 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28

[GitHub] spark pull request: [SPARK-5771][UI] Display the actual cores requ...

2015-03-01 Thread jerryshao
Github user jerryshao commented on the pull request: https://github.com/apache/spark/pull/4841#issuecomment-76626978 `requestedCores` is the core number set by user or as a default value `Int.MaxValue`, which can be larger than actual cores gotten, `actualCoresRequested` is the actual

[GitHub] spark pull request: [Streaming][Minor]Fix some error docs in strea...

2015-03-01 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/4837#discussion_r25570563 --- Diff: examples/src/main/python/streaming/kafka_wordcount.py --- @@ -23,7 +23,7 @@ http://kafka.apache.org/documentation.html#quickstart

[GitHub] spark pull request: SPARK-2372 [MLLIB] Grouped Optimization/Learni...

2015-03-01 Thread kellrott
Github user kellrott closed the pull request at: https://github.com/apache/spark/pull/1292 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is en

[GitHub] spark pull request: [SPARK-6088] Correct how tasks that get remote...

2015-03-01 Thread shivaram
Github user shivaram commented on the pull request: https://github.com/apache/spark/pull/4839#issuecomment-76626501 I'm not familiar enough with the UI code, but one more problem I have noticed is that when the task is in the getting results stage, the UI shows the time as execution

[GitHub] spark pull request: [SPARK-6053][MLLIB] support save/load in PySpa...

2015-03-01 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/4811#discussion_r25570059 --- Diff: python/pyspark/mllib/util.py --- @@ -168,6 +168,64 @@ def loadLabeledPoints(sc, path, minPartitions=None): return callMLlibFunc("loadLabe

[GitHub] spark pull request: [SPARK-5775] BugFix: GenericRow cannot be cast...

2015-03-01 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/4697#issuecomment-76623990 Since it has been fixed in master and branch-1.3, it will be great if we can have the same changes with aa39460d4bb4c41084d350ccb1c5a56cd61239b7 for branch-1.2. --- If yo

[GitHub] spark pull request: [SPARK-6083] [MLLib] [DOC] Make Python API exa...

2015-03-01 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/4834#issuecomment-76623656 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled an

[GitHub] spark pull request: [SPARK-6083] [MLLib] [DOC] Make Python API exa...

2015-03-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4834#issuecomment-76623530 [Test build #28152 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28152/consoleFull) for PR 4834 at commit [`1cdd7b5`](https://githu

[GitHub] spark pull request: [SPARK-6083] [MLLib] [DOC] Make Python API exa...

2015-03-01 Thread MechCoder
Github user MechCoder commented on the pull request: https://github.com/apache/spark/pull/4834#issuecomment-76623459 @mengxr fixed ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featu

[GitHub] spark pull request: [SPARK-6080] [PySpark] correct LogisticRegress...

2015-03-01 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/4831#discussion_r25569852 --- Diff: python/pyspark/mllib/classification.py --- @@ -207,7 +207,7 @@ def train(cls, data, iterations=100, initialWeights=None, regParam=0.01, regType

[GitHub] spark pull request: [SPARK-5991][MLLIB] support save/load in PySpa...

2015-03-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4811#issuecomment-76623310 [Test build #28151 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28151/consoleFull) for PR 4811 at commit [`f135dac`](https://githu

[GitHub] spark pull request: [SPARK-6080] [PySpark] correct LogisticRegress...

2015-03-01 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4831#issuecomment-76623304 [Test build #28150 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28150/consoleFull) for PR 4831 at commit [`12db65a`](https://githu

[GitHub] spark pull request: [SPARK-6080] [PySpark] correct LogisticRegress...

2015-03-01 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/4831#issuecomment-76623265 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabl

[GitHub] spark pull request: [SPARK-6080] [PySpark] correct LogisticRegress...

2015-03-01 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/4831#issuecomment-76623257 add to whitelist --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-6083] [MLLib] [DOC] Make Python API exa...

2015-03-01 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/4834#discussion_r25569772 --- Diff: docs/mllib-naive-bayes.md --- @@ -115,22 +115,31 @@ used for evaluation and prediction. Note that the Python API does not yet support model

[GitHub] spark pull request: [SPARK-6083] [MLLib] [DOC] Make Python API exa...

2015-03-01 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/4834#discussion_r25569774 --- Diff: docs/mllib-naive-bayes.md --- @@ -115,22 +115,31 @@ used for evaluation and prediction. Note that the Python API does not yet support model

  1   2   >