[GitHub] spark pull request: [SPARK-6097][MLLIB] Support tree model save/lo...

2015-03-02 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/4854#discussion_r25637981 --- Diff: docs/mllib-decision-tree.md --- @@ -317,6 +315,10 @@ testErr = labelsAndPredictions.filter(lambda (v, p): v != p).count() / float(tes

[GitHub] spark pull request: [SPARK-6040][SQL] Fix the percent bug in table...

2015-03-02 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/4789#discussion_r25639164 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveQuerySuite.scala --- @@ -467,6 +467,7 @@ class HiveQuerySuite extends

[GitHub] spark pull request: [SPARK-6118] making package name of deploy.wor...

2015-03-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4856#issuecomment-76828944 [Test build #28188 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28188/consoleFull) for PR 4856 at commit

[GitHub] spark pull request: [SPARK-6066] Make event log format easier to p...

2015-03-02 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/4821#discussion_r25641491 --- Diff: core/src/test/scala/org/apache/spark/deploy/history/FsHistoryProviderSuite.scala --- @@ -89,16 +105,18 @@ class FsHistoryProviderSuite extends

[GitHub] spark pull request: [wip][SPARK-1391][SPARK-3151] 2g partition lim...

2015-03-02 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/4857#discussion_r25642017 --- Diff: core/src/main/scala/org/apache/spark/network/netty/NettyBlockTransferService.scala --- @@ -106,40 +109,54 @@ class NettyBlockTransferService(conf:

[GitHub] spark pull request: [SPARK-6077] update listener for the existing ...

2015-03-02 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/4828#issuecomment-76834346 @tdas do you think we should add a Selenium test for this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: [wip][SPARK-1391][SPARK-3151] 2g partition lim...

2015-03-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4857#issuecomment-76839123 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-6118] making package name of deploy.wor...

2015-03-02 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/4856#issuecomment-76839939 LGTM. I'll wait until tomorrow morning to merge just in case there are other comments. --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark pull request: [wip][SPARK-1391][SPARK-3151] 2g partition lim...

2015-03-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4857#issuecomment-76839949 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [wip][SPARK-1391][SPARK-3151] 2g partition lim...

2015-03-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4857#issuecomment-76841496 [Test build #28192 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28192/consoleFull) for PR 4857 at commit

[GitHub] spark pull request: [SPARK-5950][SQL]Insert array into a metastore...

2015-03-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4826#issuecomment-76841684 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: SPARK-5390 [DOCS] Encourage users to post on S...

2015-03-02 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/4843#discussion_r25646670 --- Diff: docs/index.md --- @@ -115,6 +115,8 @@ options for deployment: * [Spark Homepage](http://spark.apache.org) * [Spark

[GitHub] spark pull request: [SPARK-6066] Make event log format easier to p...

2015-03-02 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/4821#discussion_r25647732 --- Diff: core/src/test/scala/org/apache/spark/deploy/history/FsHistoryProviderSuite.scala --- @@ -89,16 +105,18 @@ class FsHistoryProviderSuite extends

[GitHub] spark pull request: [SPARK-6066] Make event log format easier to p...

2015-03-02 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/4821#discussion_r25647694 --- Diff: core/src/test/scala/org/apache/spark/deploy/history/FsHistoryProviderSuite.scala --- @@ -89,16 +105,18 @@ class FsHistoryProviderSuite extends

[GitHub] spark pull request: [SPARK-6066] Make event log format easier to p...

2015-03-02 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/4821#issuecomment-76848440 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark pull request: [SPARK-4011] tighten the visibility of the mem...

2015-03-02 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/4844#issuecomment-76849828 Oh my, I didn't realize this would expand to change 50 files. In many cases you're removing visibility restrictions. I understand that the class-level visibility still

[GitHub] spark pull request: [SPARK-5522] Accelerate the Histroty Server st...

2015-03-02 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/4525#discussion_r25649771 --- Diff: core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala --- @@ -189,48 +201,69 @@ private[history] class

[GitHub] spark pull request: [Minor] Fix doc typo for describing primitiveT...

2015-03-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/4762 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [Minor] Fix doc typo for describing primitiveT...

2015-03-02 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/4762#issuecomment-76824082 Merged to master and 1.3 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-6077] update listener for the existing ...

2015-03-02 Thread tdas
Github user tdas commented on the pull request: https://github.com/apache/spark/pull/4828#issuecomment-76836876 Will that be stable? Not flaky? In the past we had simple web ui tests that uses Scala's Source class to fetch a URL to see whether a tab has been loaded or unloaded.

[GitHub] spark pull request: [SPARK-6048] SparkConf should not translate de...

2015-03-02 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/4799#discussion_r25643250 --- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala --- @@ -324,14 +330,13 @@ private[spark] class Executor( val classUri =

[GitHub] spark pull request: [SPARK-6050] [yarn] Relax matching of vcore co...

2015-03-02 Thread tgravescs
Github user tgravescs commented on the pull request: https://github.com/apache/spark/pull/4818#issuecomment-76842747 this looks good to me. +1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-6114][SQL] Avoid metastore conversions ...

2015-03-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4855#issuecomment-76821852 [Test build #28184 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28184/consoleFull) for PR 4855 at commit

[GitHub] spark pull request: [SPARK-6097][MLLIB] Support tree model save/lo...

2015-03-02 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/4854#discussion_r25638795 --- Diff: python/pyspark/mllib/tests.py --- @@ -19,7 +19,9 @@ Fuller unit tests for Python MLlib. +import os import sys

[GitHub] spark pull request: SPARK-5390 [DOCS] Encourage users to post on S...

2015-03-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/4843 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: Refactored Dataframe join comment to use corre...

2015-03-02 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/4847#issuecomment-76823596 Thanks! Merged to master and 1.3 with a small change for java. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark pull request: [SPARK-5950][SQL]Insert array into a metastore...

2015-03-02 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/4826#discussion_r25639687 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/types/DataTypeSuite.scala --- @@ -115,4 +115,84 @@ class DataTypeSuite extends FunSuite {

[GitHub] spark pull request: [SPARK-6097][MLLIB] Support tree model save/lo...

2015-03-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4854#issuecomment-76838144 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-6097][MLLIB] Support tree model save/lo...

2015-03-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4854#issuecomment-76838133 [Test build #28185 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28185/consoleFull) for PR 4854 at commit

[GitHub] spark pull request: [wip][SPARK-1391][SPARK-3151] 2g partition lim...

2015-03-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4857#issuecomment-76837934 [Test build #28190 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28190/consoleFull) for PR 4857 at commit

[GitHub] spark pull request: [SPARK-4011] tighten the visibility of the mem...

2015-03-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4844#issuecomment-76840849 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-6077] update listener for the existing ...

2015-03-02 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/4828#issuecomment-76840648 Poorly-written Selenium tests can be flaky if they don't account for things like asynchrony (e.g. when testing Javascript interactions), but I don't think that will be

[GitHub] spark pull request: [wip][SPARK-1391][SPARK-3151] 2g partition lim...

2015-03-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4857#issuecomment-76843225 [Test build #28194 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28194/consoleFull) for PR 4857 at commit

[GitHub] spark pull request: [SPARK-6050] [yarn] Relax matching of vcore co...

2015-03-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/4818 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: SPARK-3357 [CORE] Internal log messages should...

2015-03-02 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/4838#discussion_r25647202 --- Diff: core/src/main/scala/org/apache/spark/storage/MemoryStore.scala --- @@ -184,7 +184,7 @@ private[spark] class MemoryStore(blockManager:

[GitHub] spark pull request: [SPARK-6066] Make event log format easier to p...

2015-03-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4821#issuecomment-76846594 [Test build #28198 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28198/consoleFull) for PR 4821 at commit

[GitHub] spark pull request: [SPARK-6066] Make event log format easier to p...

2015-03-02 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/4821#discussion_r25647830 --- Diff: core/src/test/scala/org/apache/spark/deploy/history/FsHistoryProviderSuite.scala --- @@ -89,16 +105,18 @@ class FsHistoryProviderSuite extends

[GitHub] spark pull request: [SPARK-1655][MLLIB] WIP Add option for distrib...

2015-03-02 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/2491#issuecomment-76848066 @staple is this still an active PR? just trying to figure out if it's stale and can be closed. --- If your project is set up for it, you can reply to this email and have

[GitHub] spark pull request: [SPARK-6097][MLLIB] Support tree model save/lo...

2015-03-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4854#issuecomment-76822795 [Test build #28185 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28185/consoleFull) for PR 4854 at commit

[GitHub] spark pull request: [SPARK-4011] tighten the visibility of the mem...

2015-03-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4844#issuecomment-76822798 [Test build #28186 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28186/consoleFull) for PR 4844 at commit

[GitHub] spark pull request: [SPARK-6040][SQL] Fix the percent bug in table...

2015-03-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/4789 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-6029] Stop excluding fastutil package

2015-03-02 Thread jkleckner
Github user jkleckner commented on the pull request: https://github.com/apache/spark/pull/4780#issuecomment-76831730 I wonder if we're hitting some bugs with the serializer's classloader not seeing the right classloaders. Some issues like that are fixed in 1.3.0. It may still be

[GitHub] spark pull request: [SPARK-6066] Make event log format easier to p...

2015-03-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4821#issuecomment-76831455 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [wip][SPARK-1391][SPARK-3151] 2g partition lim...

2015-03-02 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/4857#discussion_r25641946 --- Diff: core/src/main/scala/org/apache/spark/network/netty/NettyBlockRpcServer.scala --- @@ -63,11 +83,83 @@ class NettyBlockRpcServer( //

[GitHub] spark pull request: [wip][SPARK-1391][SPARK-3151] 2g partition lim...

2015-03-02 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/4857#discussion_r25642290 --- Diff: core/src/main/scala/org/apache/spark/network/nio/NioBlockTransferService.scala --- @@ -143,7 +143,7 @@ final class NioBlockTransferService(conf:

[GitHub] spark pull request: [SPARK-6048] SparkConf should not translate de...

2015-03-02 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/4799#issuecomment-76836507 LGTM, left just minor comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [wip][SPARK-1391][SPARK-3151] 2g partition lim...

2015-03-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4857#issuecomment-76838816 [Test build #28191 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28191/consoleFull) for PR 4857 at commit

[GitHub] spark pull request: SPARK-3357 [CORE] Internal log messages should...

2015-03-02 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/4838#discussion_r25646752 --- Diff: core/src/main/scala/org/apache/spark/storage/MemoryStore.scala --- @@ -184,7 +184,7 @@ private[spark] class MemoryStore(blockManager:

[GitHub] spark pull request: [SPARK-5950][SQL]Insert array into a metastore...

2015-03-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4826#issuecomment-76847366 [Test build #28199 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28199/consoleFull) for PR 4826 at commit

[GitHub] spark pull request: [SPARK-5950][SQL]Insert array into a metastore...

2015-03-02 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/4826#discussion_r25639644 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/types/dataTypes.scala --- @@ -198,6 +198,43 @@ object DataType { case (left, right) =

[GitHub] spark pull request: [SPARK-4011] tighten the visibility of the mem...

2015-03-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4844#issuecomment-76833095 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [wip][SPARK-1391][SPARK-3151] 2g partition lim...

2015-03-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4857#issuecomment-76833223 [Test build #28189 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28189/consoleFull) for PR 4857 at commit

[GitHub] spark pull request: [wip][SPARK-1391][SPARK-3151] 2g partition lim...

2015-03-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4857#issuecomment-76833028 [Test build #28189 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28189/consoleFull) for PR 4857 at commit

[GitHub] spark pull request: [SPARK-4011] tighten the visibility of the mem...

2015-03-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4844#issuecomment-76840838 [Test build #28186 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28186/consoleFull) for PR 4844 at commit

[GitHub] spark pull request: [SPARK-6118] making package name of deploy.wor...

2015-03-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4856#issuecomment-76842877 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-6118] making package name of deploy.wor...

2015-03-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4856#issuecomment-76842862 [Test build #28188 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28188/consoleFull) for PR 4856 at commit

[GitHub] spark pull request: SPARK-5390 [DOCS] Encourage users to post on S...

2015-03-02 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/4843#discussion_r25646936 --- Diff: docs/index.md --- @@ -115,6 +115,8 @@ options for deployment: * [Spark Homepage](http://spark.apache.org) * [Spark

[GitHub] spark pull request: [SPARK-6097][MLLIB] Support tree model save/lo...

2015-03-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4854#issuecomment-76846592 [Test build #28196 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28196/consoleFull) for PR 4854 at commit

[GitHub] spark pull request: [SPARK-6121][SQL][MLLIB] simpleString for UDT

2015-03-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4858#issuecomment-76846620 [Test build #28197 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28197/consoleFull) for PR 4858 at commit

[GitHub] spark pull request: [SPARK-6048] SparkConf should not translate de...

2015-03-02 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/4799#discussion_r25649473 --- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala --- @@ -324,14 +330,13 @@ private[spark] class Executor( val classUri =

[GitHub] spark pull request: [SPARK-6066] Make event log format easier to p...

2015-03-02 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/4821#discussion_r25649521 --- Diff: core/src/main/scala/org/apache/spark/util/JsonProtocol.scala --- @@ -574,6 +583,11 @@ private[spark] object JsonProtocol {

[GitHub] spark pull request: [SPARK-5522] Accelerate the Histroty Server st...

2015-03-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/4525 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: Refactored Dataframe join comment to use corre...

2015-03-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/4847 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-5950][SQL]Insert array into a metastore...

2015-03-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4826#issuecomment-76827466 [Test build #28187 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28187/consoleFull) for PR 4826 at commit

[GitHub] spark pull request: [SPARK-6066] Make event log format easier to p...

2015-03-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4821#issuecomment-76831439 [Test build #28182 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28182/consoleFull) for PR 4821 at commit

[GitHub] spark pull request: [wip][SPARK-1391][SPARK-3151] 2g partition lim...

2015-03-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4857#issuecomment-76833228 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-6048] SparkConf should not translate de...

2015-03-02 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/4799#discussion_r25643128 --- Diff: core/src/main/scala/org/apache/spark/SparkConf.scala --- @@ -343,6 +343,13 @@ class SparkConf(loadDefaults: Boolean) extends Cloneable with Logging

[GitHub] spark pull request: [SPARK-5494][SQL] SparkSqlSerializer Ignores K...

2015-03-02 Thread mccheah
Github user mccheah commented on the pull request: https://github.com/apache/spark/pull/4693#issuecomment-76840419 Talked with @pwoody offline and he's working on a test case, but I'll summarize what I think will break. If you use an SQL Context wrapping a Spark Context where you set

[GitHub] spark pull request: [SPARK-5494][SQL] SparkSqlSerializer Ignores K...

2015-03-02 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/4693#issuecomment-76842442 @mccheah we [set the serializer in SQL on a per-shuffle

[GitHub] spark pull request: [SPARK-5950][SQL]Insert array into a metastore...

2015-03-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4826#issuecomment-76842454 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-5950][SQL]Insert array into a metastore...

2015-03-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4826#issuecomment-76842451 [Test build #28193 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28193/consoleFull) for PR 4826 at commit

[GitHub] spark pull request: [SPARK-6121][SQL][MLLIB] simpleString for UDT

2015-03-02 Thread mengxr
GitHub user mengxr opened a pull request: https://github.com/apache/spark/pull/4858 [SPARK-6121][SQL][MLLIB] simpleString for UDT `df.dtypes` shows `null` for UDTs. This PR uses `udt` by default and `VectorUDT` overwrites it with `vector`. @jkbradley @davies You can merge

[GitHub] spark pull request: [SPARK-6066] Make event log format easier to p...

2015-03-02 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/4821#discussion_r25648384 --- Diff: core/src/main/scala/org/apache/spark/util/JsonProtocol.scala --- @@ -574,6 +583,11 @@ private[spark] object JsonProtocol {

[GitHub] spark pull request: [SPARK-6066] Make event log format easier to p...

2015-03-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4821#issuecomment-76850938 [Test build #28201 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28201/consoleFull) for PR 4821 at commit

[GitHub] spark pull request: [SPARK-5522] Accelerate the Histroty Server st...

2015-03-02 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/4525#issuecomment-76850970 Ok I'm merging this in master thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-6097][MLLIB] Support tree model save/lo...

2015-03-02 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/4854#issuecomment-76824296 LGTM other than that typo. I'm trying to compile test now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: [SPARK-5950][SQL]Insert array into a metastore...

2015-03-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4826#issuecomment-76842310 [Test build #28193 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28193/consoleFull) for PR 4826 at commit

[GitHub] spark pull request: Tighten up field/method visibility in Executor...

2015-03-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4850#issuecomment-76845031 [Test build #28195 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28195/consoleFull) for PR 4850 at commit

[GitHub] spark pull request: [SPARK-6114][SQL] Avoid metastore conversions ...

2015-03-02 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/4855#issuecomment-76845758 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark pull request: [SPARK-6121][SQL][MLLIB] simpleString for UDT

2015-03-02 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/4858#issuecomment-76848785 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark pull request: [wip][SPARK-1391][SPARK-3151] 2g partition lim...

2015-03-02 Thread squito
GitHub user squito opened a pull request: https://github.com/apache/spark/pull/4857 [wip][SPARK-1391][SPARK-3151] 2g partition limit https://issues.apache.org/jira/browse/SPARK-1391 This is still really rough, I'm looking for some feedback on overall design, its not ready

[GitHub] spark pull request: [SPARK-4011] tighten the visibility of the mem...

2015-03-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4844#issuecomment-76833078 [Test build #28181 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28181/consoleFull) for PR 4844 at commit

[GitHub] spark pull request: [wip][SPARK-1391][SPARK-3151] 2g partition lim...

2015-03-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4857#issuecomment-76839944 [Test build #28191 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28191/consoleFull) for PR 4857 at commit

[GitHub] spark pull request: [wip][SPARK-1391][SPARK-3151] 2g partition lim...

2015-03-02 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/4857#discussion_r25644794 --- Diff: core/src/test/scala/org/apache/spark/network/netty/NettyBlockTransferSuite.scala --- @@ -0,0 +1,154 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: SPARK-5390 [DOCS] Encourage users to post on S...

2015-03-02 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/4843#discussion_r25646565 --- Diff: docs/index.md --- @@ -115,6 +115,8 @@ options for deployment: * [Spark Homepage](http://spark.apache.org) * [Spark

[GitHub] spark pull request: [SPARK-4011] tighten the visibility of the mem...

2015-03-02 Thread CodingCat
Github user CodingCat commented on the pull request: https://github.com/apache/spark/pull/4844#issuecomment-76847322 Hi, @srowen and @JoshRosen I made further changes. Basically, I got 2 kinds of strategies to tighten the accessibility 1. modify individual

[GitHub] spark pull request: [SPARK-6066] Make event log format easier to p...

2015-03-02 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/4821#discussion_r25648636 --- Diff: core/src/main/scala/org/apache/spark/util/JsonProtocol.scala --- @@ -574,6 +583,11 @@ private[spark] object JsonProtocol {

[GitHub] spark pull request: [SPARK-4924] Add a library for launching Spark...

2015-03-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3916#issuecomment-76849555 [Test build #28200 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28200/consoleFull) for PR 3916 at commit

[GitHub] spark pull request: [SPARK-6048] SparkConf should not translate de...

2015-03-02 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/4799#discussion_r25649108 --- Diff: core/src/main/scala/org/apache/spark/SparkConf.scala --- @@ -343,6 +343,13 @@ class SparkConf(loadDefaults: Boolean) extends Cloneable with

[GitHub] spark pull request: [SPARK-6118] making package name of deploy.wor...

2015-03-02 Thread CodingCat
GitHub user CodingCat opened a pull request: https://github.com/apache/spark/pull/4856 [SPARK-6118] making package name of deploy.worker.CommandUtils and deploy.CommandUtilsSuite consistent https://issues.apache.org/jira/browse/SPARK-6118 I found that the object

[GitHub] spark pull request: [SPARK-6077] update listener for the existing ...

2015-03-02 Thread tdas
Github user tdas commented on the pull request: https://github.com/apache/spark/pull/4828#issuecomment-76829945 Hey this is a decent fix, but I think this is not the right one. With this fix, the new ssc will be reflected in the new streaming tab, however it will be still visible

[GitHub] spark pull request: [wip][SPARK-1391][SPARK-3151] 2g partition lim...

2015-03-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4857#issuecomment-76839119 [Test build #28190 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28190/consoleFull) for PR 4857 at commit

[GitHub] spark pull request: [SPARK-6114][SQL] Avoid metastore conversions ...

2015-03-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4855#issuecomment-76839492 [Test build #28184 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28184/consoleFull) for PR 4855 at commit

[GitHub] spark pull request: [wip][SPARK-1391][SPARK-3151] 2g partition lim...

2015-03-02 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/4857#discussion_r25644640 --- Diff: network/common/src/main/java/org/apache/spark/network/buffer/NioManagedBuffer.java --- @@ -41,13 +41,13 @@ public long size() { }

[GitHub] spark pull request: [SPARK-6114][SQL] Avoid metastore conversions ...

2015-03-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4855#issuecomment-76839508 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-5950][SQL]Insert array into a metastore...

2015-03-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4826#issuecomment-76841671 [Test build #28187 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28187/consoleFull) for PR 4826 at commit

[GitHub] spark pull request: [SPARK-5641] [EC2] Allow spark_ec2.py to copy ...

2015-03-02 Thread florianverhein
Github user florianverhein commented on the pull request: https://github.com/apache/spark/pull/4583#issuecomment-76851833 Hi @shivaram, have you had a chance to look at this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: [SPARK-6124] Support jdbc connection propertie...

2015-03-02 Thread vlyubin
GitHub user vlyubin opened a pull request: https://github.com/apache/spark/pull/4859 [SPARK-6124] Support jdbc connection properties in OPTIONS part of the query One more thing if this PR is considered to be OK - it might make sense to add extra .jdbc() API's that take Properties

[GitHub] spark pull request: SPARK-4705:[ For Cluster mode ] Pull request f...

2015-03-02 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/4845#discussion_r25652368 --- Diff: core/src/main/scala/org/apache/spark/deploy/history/HistoryPage.scala --- @@ -113,6 +129,36 @@ private[spark] class HistoryPage(parent:

[GitHub] spark pull request: SPARK-4705:[ For Cluster mode ] Pull request f...

2015-03-02 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/4845#discussion_r25652327 --- Diff: core/src/main/scala/org/apache/spark/deploy/history/HistoryPage.scala --- @@ -34,18 +37,31 @@ private[spark] class HistoryPage(parent:

  1   2   3   4   5   >