[GitHub] spark pull request: [SPARK-6107][CORE] Display inprogress applicat...

2015-03-02 Thread liyezhang556520
GitHub user liyezhang556520 opened a pull request: https://github.com/apache/spark/pull/4848 [SPARK-6107][CORE] Display inprogress application information for event log history for standalone mode when application is finished running abnormally (Ctrl + c for example), the history e

[GitHub] spark pull request: [SPARK-6107][CORE] Display inprogress applicat...

2015-03-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4848#issuecomment-76671530 [Test build #28162 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28162/consoleFull) for PR 4848 at commit [`563634e`](https://githu

[GitHub] spark pull request: [SPARK-6107][CORE] Display inprogress applicat...

2015-03-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4848#issuecomment-76671608 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28

[GitHub] spark pull request: [SPARK-6107][CORE] Display inprogress applicat...

2015-03-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4848#issuecomment-76671607 [Test build #28162 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28162/consoleFull) for PR 4848 at commit [`563634e`](https://gith

[GitHub] spark pull request: [SPARK-6107][CORE] Display inprogress applicat...

2015-03-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4848#issuecomment-76671972 [Test build #28163 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28163/consoleFull) for PR 4848 at commit [`0aece64`](https://githu

[GitHub] spark pull request: [SPARK-6107][CORE] Display inprogress applicat...

2015-03-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4848#issuecomment-76672041 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28

[GitHub] spark pull request: [SPARK-6107][CORE] Display inprogress applicat...

2015-03-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4848#issuecomment-76672040 [Test build #28163 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28163/consoleFull) for PR 4848 at commit [`0aece64`](https://gith

[GitHub] spark pull request: [SPARK-6048] SparkConf should not translate de...

2015-03-02 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/4799#discussion_r25582753 --- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala --- @@ -92,6 +92,16 @@ private[spark] class Executor( private val executorActor

[GitHub] spark pull request: [SPARK-6105] enhance spark-ganglia to support ...

2015-03-02 Thread tsingfu
GitHub user tsingfu opened a pull request: https://github.com/apache/spark/pull/4849 [SPARK-6105] enhance spark-ganglia to support redundant gmond addresses ... This *PR* is for preventing spark-GangliaSink from single point of failure in unicast mode configuration. For det

[GitHub] spark pull request: [SPARK-6105] enhance spark-ganglia to support ...

2015-03-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4849#issuecomment-76672374 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pro

[GitHub] spark pull request: [SPARK-6103][Graphx]remove unused class to imp...

2015-03-02 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/4846#issuecomment-76672355 I don't mean to pick on this, but it's an example: this is a trivial, nonfunctional change. Opening a JIRA, opening a PR, emailing the list twice, asking for review, getti

[GitHub] spark pull request: [SPARK-6107][CORE] Display inprogress applicat...

2015-03-02 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/4848#discussion_r25583191 --- Diff: core/src/main/scala/org/apache/spark/deploy/master/Master.scala --- @@ -736,30 +736,31 @@ private[spark] class Master( val appName = app.des

[GitHub] spark pull request: [SPARK-6066] Make event log format easier to p...

2015-03-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4821#issuecomment-76673346 [Test build #28159 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28159/consoleFull) for PR 4821 at commit [`7d6aa61`](https://gith

[GitHub] spark pull request: [SPARK-6066] Make event log format easier to p...

2015-03-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4821#issuecomment-76673355 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28

[GitHub] spark pull request: [SPARK-6107][CORE] Display inprogress applicat...

2015-03-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4848#issuecomment-76673390 [Test build #28164 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28164/consoleFull) for PR 4848 at commit [`a63a95f`](https://githu

[GitHub] spark pull request: [SPARK-6107][CORE] Display inprogress applicat...

2015-03-02 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/4848#discussion_r25583270 --- Diff: core/src/main/scala/org/apache/spark/deploy/master/Master.scala --- @@ -736,30 +736,31 @@ private[spark] class Master( val appName = app.des

[GitHub] spark pull request: [SPARK-6040][SQL] Fix the percent bug in table...

2015-03-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4789#issuecomment-76673798 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28

[GitHub] spark pull request: [SPARK-6040][SQL] Fix the percent bug in table...

2015-03-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4789#issuecomment-76673791 [Test build #28160 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28160/consoleFull) for PR 4789 at commit [`2453ebe`](https://gith

[GitHub] spark pull request: [SPARK-6077] update listener for the existing ...

2015-03-02 Thread zhichao-li
Github user zhichao-li commented on a diff in the pull request: https://github.com/apache/spark/pull/4828#discussion_r25583362 --- Diff: streaming/src/main/scala/org/apache/spark/streaming/ui/StreamingPage.scala --- @@ -20,20 +20,26 @@ package org.apache.spark.streaming.ui imp

[GitHub] spark pull request: [SPARK-6077] update listener for the existing ...

2015-03-02 Thread zhichao-li
Github user zhichao-li commented on a diff in the pull request: https://github.com/apache/spark/pull/4828#discussion_r25583379 --- Diff: streaming/src/main/scala/org/apache/spark/streaming/ui/StreamingTab.scala --- @@ -29,19 +29,29 @@ import StreamingTab._ */ private[spa

[GitHub] spark pull request: [SPARK-6077] update listener for the existing ...

2015-03-02 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/4828#issuecomment-76673885 This looks OK to me. I'd like to give @tdas at least a day to look at it. --- If your project is set up for it, you can reply to this email and have your reply appear on G

[GitHub] spark pull request: [SPARK-6107][CORE] Display inprogress applicat...

2015-03-02 Thread liyezhang556520
Github user liyezhang556520 commented on a diff in the pull request: https://github.com/apache/spark/pull/4848#discussion_r25583468 --- Diff: core/src/main/scala/org/apache/spark/deploy/master/Master.scala --- @@ -736,30 +736,31 @@ private[spark] class Master( val appName

[GitHub] spark pull request: [SPARK-6107][CORE] Display inprogress applicat...

2015-03-02 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/4848#discussion_r25583625 --- Diff: core/src/main/scala/org/apache/spark/deploy/master/Master.scala --- @@ -736,30 +736,31 @@ private[spark] class Master( val appName = app.des

[GitHub] spark pull request: [SPARK-6107][CORE] Display inprogress applicat...

2015-03-02 Thread liyezhang556520
Github user liyezhang556520 commented on a diff in the pull request: https://github.com/apache/spark/pull/4848#discussion_r25583715 --- Diff: core/src/main/scala/org/apache/spark/deploy/master/Master.scala --- @@ -736,30 +736,31 @@ private[spark] class Master( val appName

[GitHub] spark pull request: [SPARK-6107][CORE] Display inprogress applicat...

2015-03-02 Thread liyezhang556520
Github user liyezhang556520 commented on a diff in the pull request: https://github.com/apache/spark/pull/4848#discussion_r25583892 --- Diff: core/src/main/scala/org/apache/spark/deploy/master/Master.scala --- @@ -736,30 +736,31 @@ private[spark] class Master( val appName

[GitHub] spark pull request: Refactored Dataframe join comment to use corre...

2015-03-02 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/4847#issuecomment-76675615 LGTM since it's definitely the last arg that specifies the join type, as you can see there, but will give @rxin a day to look --- If your project is set up for it, you ca

[GitHub] spark pull request: [SPARK-6107][CORE] Display inprogress applicat...

2015-03-02 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/4848#discussion_r25584033 --- Diff: core/src/main/scala/org/apache/spark/deploy/master/Master.scala --- @@ -736,30 +736,31 @@ private[spark] class Master( val appName = app.des

[GitHub] spark pull request: [Streaming][Minor]Fix some error docs in strea...

2015-03-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/4837 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: SPARK-3357 [CORE] Internal log messages should...

2015-03-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/4838 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-6107][CORE] Display inprogress applicat...

2015-03-02 Thread liyezhang556520
Github user liyezhang556520 commented on a diff in the pull request: https://github.com/apache/spark/pull/4848#discussion_r25584310 --- Diff: core/src/main/scala/org/apache/spark/deploy/master/Master.scala --- @@ -736,30 +736,31 @@ private[spark] class Master( val appName

[GitHub] spark pull request: [SPARK-3586][streaming]Support nested director...

2015-03-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2765#issuecomment-76676933 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28

[GitHub] spark pull request: [SPARK-3586][streaming]Support nested director...

2015-03-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2765#issuecomment-76676922 [Test build #28161 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28161/consoleFull) for PR 2765 at commit [`2068255`](https://gith

[GitHub] spark pull request: [SPARK-6107][CORE] Display inprogress applicat...

2015-03-02 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/4848#discussion_r25584486 --- Diff: core/src/main/scala/org/apache/spark/deploy/master/Master.scala --- @@ -736,30 +736,31 @@ private[spark] class Master( val appName = app.des

[GitHub] spark pull request: [SPARK-4011] tighten the visibility of the mem...

2015-03-02 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/4844#issuecomment-76677414 I imagine there are lots of fields that could and even should be `private`. The question is where to draw the line, since I don't think we want to hit the whole code base

[GitHub] spark pull request: [SPARK-6107][CORE] Display inprogress applicat...

2015-03-02 Thread liyezhang556520
Github user liyezhang556520 commented on a diff in the pull request: https://github.com/apache/spark/pull/4848#discussion_r25584791 --- Diff: core/src/main/scala/org/apache/spark/deploy/master/Master.scala --- @@ -736,30 +736,31 @@ private[spark] class Master( val appName

[GitHub] spark pull request: Refactored Dataframe join comment to use corre...

2015-03-02 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/4847#discussion_r25584861 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrame.scala --- @@ -337,11 +337,11 @@ class DataFrame protected[sql]( * {{{ * // Scal

[GitHub] spark pull request: [SPARK-6103][Graphx]remove unused class to imp...

2015-03-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/4846 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: SPARK-4705:[ For Cluster mode ] Pull request f...

2015-03-02 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/4845#discussion_r25585467 --- Diff: core/src/main/scala/org/apache/spark/deploy/history/ApplicationHistoryProvider.scala --- @@ -26,7 +26,8 @@ private[spark] case class ApplicationHist

[GitHub] spark pull request: SPARK-4705:[ For Cluster mode ] Pull request f...

2015-03-02 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/4845#issuecomment-76680020 (Title should start with something like `SPARK-4705 [YARN] ...`) This seems like a big change for a fairly narrow problem, which is that retrying the driver in cluster

[GitHub] spark pull request: SPARK-4705:Creating different log directories ...

2015-03-02 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/4311#issuecomment-76680225 Mind closing this PR? at the least, this is not opened vs `master` anyway. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request: [SPARK-5775] BugFix: GenericRow cannot be cast...

2015-03-02 Thread anselmevignon
Github user anselmevignon commented on the pull request: https://github.com/apache/spark/pull/4697#issuecomment-76680120 Hi @ayoub-benali, Sorry for the delay, I was OOO during the end of the week. I will be correcting the style and getting rid of the dynamic type chec

[GitHub] spark pull request: [CORE][minor] enhance the `toArray` method in ...

2015-03-02 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/4825#discussion_r25585834 --- Diff: core/src/main/scala/org/apache/spark/util/collection/SizeTrackingVector.scala --- @@ -41,6 +41,6 @@ private[spark] class SizeTrackingVector[T: Class

[GitHub] spark pull request: [SPARK-4989][CORE] backport for branch-1.0(-jd...

2015-03-02 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/3971#issuecomment-76680887 Heh, are we back-porting to 1.0.x anyway at this point? I think it has some known problems with tests. If not, we could just close all this out. But I'm interested in opin

[GitHub] spark pull request: SPARK-4705:[ For Cluster mode ] Pull request f...

2015-03-02 Thread twinkle-sachdeva
Github user twinkle-sachdeva commented on the pull request: https://github.com/apache/spark/pull/4845#issuecomment-76680974 Hi @srowen , Please have a look at discussion/comments in Jira https://issues.apache.org/jira/browse/SPARK-4705, avoiding creating directory, UI related

[GitHub] spark pull request: [SPARK-6076][Block Manager] Fix a potential OO...

2015-03-02 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/4827#issuecomment-76681216 CC @andrewor14 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark pull request: [SPARK-6029] Stop excluding fastutil package

2015-03-02 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/4780#issuecomment-76681725 So, I would close this PR in the sense that this isn't the fix. I would leave SPARK-6029 open though until there's a resolution to the issue one way or the other.

[GitHub] spark pull request: [SPARK-6107][CORE] Display inprogress applicat...

2015-03-02 Thread liyezhang556520
Github user liyezhang556520 commented on the pull request: https://github.com/apache/spark/pull/4848#issuecomment-76681892 Hi @srowen , I updated the code, can you have a look. Please correct me if I still misunderstand your idea. --- If your project is set up for it, you can reply t

[GitHub] spark pull request: SPARK-4705:Creating different log directories ...

2015-03-02 Thread twinkle-sachdeva
Github user twinkle-sachdeva closed the pull request at: https://github.com/apache/spark/pull/4311 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featu

[GitHub] spark pull request: [Minor] Fix doc typo for describing primitiveT...

2015-03-02 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/4762#issuecomment-76681887 CC @marmbrus --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature ena

[GitHub] spark pull request: [SPARK-6107][CORE] Display inprogress applicat...

2015-03-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4848#issuecomment-76682232 [Test build #28165 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28165/consoleFull) for PR 4848 at commit [`4a244f0`](https://githu

[GitHub] spark pull request: [SPARK-6107][CORE] Display inprogress applicat...

2015-03-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4848#issuecomment-76683339 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28

[GitHub] spark pull request: [SPARK-6107][CORE] Display inprogress applicat...

2015-03-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4848#issuecomment-76683329 [Test build #28164 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28164/consoleFull) for PR 4848 at commit [`a63a95f`](https://gith

[GitHub] spark pull request: [SPARK-5775] BugFix: GenericRow cannot be cast...

2015-03-02 Thread anselmevignon
Github user anselmevignon commented on a diff in the pull request: https://github.com/apache/spark/pull/4697#discussion_r25587002 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/parquet/parquetSuites.scala --- @@ -263,6 +356,22 @@ abstract class ParquetTest extends QueryTest

[GitHub] spark pull request: Tighten up field/method visibility in Executor...

2015-03-02 Thread rxin
GitHub user rxin opened a pull request: https://github.com/apache/spark/pull/4850 Tighten up field/method visibility in Executor and made some code more clear to read. I was reading Executor just now and found that some latest changes introduced some weird code path with too much m

[GitHub] spark pull request: Tighten up field/method visibility in Executor...

2015-03-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4850#issuecomment-76686719 [Test build #28166 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28166/consoleFull) for PR 4850 at commit [`a5e8ffd`](https://githu

[GitHub] spark pull request: [SPARK-5950][SQL]Insert array into a metastore...

2015-03-02 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/4826#discussion_r25588519 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/types/dataTypes.scala --- @@ -198,6 +198,57 @@ object DataType { case (left, right) =>

[GitHub] spark pull request: [SPARK-5950][SQL]Insert array into a metastore...

2015-03-02 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/4826#discussion_r25588553 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/types/dataTypes.scala --- @@ -198,6 +198,57 @@ object DataType { case (left, right) =>

[GitHub] spark pull request: [SPARK-5950][SQL]Insert array into a metastore...

2015-03-02 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/4826#discussion_r25588714 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/types/dataTypes.scala --- @@ -198,6 +198,57 @@ object DataType { case (left, right) =>

[GitHub] spark pull request: [SPARK-5950][SQL]Insert array into a metastore...

2015-03-02 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/4826#discussion_r25588958 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/types/DataTypeSuite.scala --- @@ -115,4 +115,84 @@ class DataTypeSuite extends FunSuite {

[GitHub] spark pull request: [SPARK-6107][CORE] Display inprogress applicat...

2015-03-02 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/4848#discussion_r25589942 --- Diff: core/src/main/scala/org/apache/spark/deploy/master/Master.scala --- @@ -736,30 +736,34 @@ private[spark] class Master( val appName = app.des

[GitHub] spark pull request: [SPARK-6107][CORE] Display inprogress applicat...

2015-03-02 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/4848#discussion_r25590100 --- Diff: core/src/main/scala/org/apache/spark/deploy/master/Master.scala --- @@ -736,30 +736,34 @@ private[spark] class Master( val appName = app.des

[GitHub] spark pull request: [SPARK-6107][CORE] Display inprogress applicat...

2015-03-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4848#issuecomment-76692173 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28

[GitHub] spark pull request: [SPARK-6107][CORE] Display inprogress applicat...

2015-03-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4848#issuecomment-76692165 [Test build #28165 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28165/consoleFull) for PR 4848 at commit [`4a244f0`](https://gith

[GitHub] spark pull request: [SPARK-6107][CORE] Display inprogress applicat...

2015-03-02 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/4848#issuecomment-76692330 CC @viirya --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabl

[GitHub] spark pull request: [SPARK-5843] Allowing map-side combine to be s...

2015-03-02 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/4634#issuecomment-76695972 So, it seems like there's an argument here that `combineByKey` doesn't add much over `aggregateByKey`. I agree, although it is slightly more general, letting you make an i

[GitHub] spark pull request: [SPARK-6107][CORE] Display inprogress applicat...

2015-03-02 Thread liyezhang556520
Github user liyezhang556520 commented on a diff in the pull request: https://github.com/apache/spark/pull/4848#discussion_r25591973 --- Diff: core/src/main/scala/org/apache/spark/deploy/master/Master.scala --- @@ -736,30 +736,34 @@ private[spark] class Master( val appName

[GitHub] spark pull request: Tighten up field/method visibility in Executor...

2015-03-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4850#issuecomment-76697011 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28

[GitHub] spark pull request: Tighten up field/method visibility in Executor...

2015-03-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4850#issuecomment-76697002 [Test build #28166 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28166/consoleFull) for PR 4850 at commit [`a5e8ffd`](https://gith

[GitHub] spark pull request: [SPARK-6107][CORE] Display inprogress applicat...

2015-03-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4848#issuecomment-76699397 [Test build #28167 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28167/consoleFull) for PR 4848 at commit [`cee03d4`](https://githu

[GitHub] spark pull request: [SPARK-6107][CORE] Display inprogress applicat...

2015-03-02 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/4848#discussion_r25593062 --- Diff: core/src/main/scala/org/apache/spark/deploy/master/Master.scala --- @@ -736,30 +736,34 @@ private[spark] class Master( val appName = app.des

[GitHub] spark pull request: [SPARK-5950][SQL]Insert array into a metastore...

2015-03-02 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/4826#discussion_r25593111 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/parquet/ParquetRelation.scala --- @@ -172,9 +173,14 @@ private[sql] object ParquetRelation {

[GitHub] spark pull request: [SPARK-5563][mllib] online lda initial checkin

2015-03-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4419#issuecomment-76700029 [Test build #28168 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28168/consoleFull) for PR 4419 at commit [`581c623`](https://githu

[GitHub] spark pull request: [SPARK-5563][mllib] online lda initial checkin

2015-03-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4419#issuecomment-76700169 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28

[GitHub] spark pull request: [SPARK-5563][mllib] online lda initial checkin

2015-03-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4419#issuecomment-76700153 [Test build #28168 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28168/consoleFull) for PR 4419 at commit [`581c623`](https://gith

[GitHub] spark pull request: [SPARK-5950][SQL]Insert array into a metastore...

2015-03-02 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/4826#discussion_r25593397 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/parquet/ParquetRelation.scala --- @@ -172,9 +173,14 @@ private[sql] object ParquetRelation {

[GitHub] spark pull request: [SPARK-6107][CORE] Display inprogress applicat...

2015-03-02 Thread liyezhang556520
Github user liyezhang556520 commented on a diff in the pull request: https://github.com/apache/spark/pull/4848#discussion_r25593705 --- Diff: core/src/main/scala/org/apache/spark/deploy/master/Master.scala --- @@ -736,30 +736,34 @@ private[spark] class Master( val appName

[GitHub] spark pull request: [SPARK-5016] Distribute Gaussian Initializatio...

2015-03-02 Thread MechCoder
Github user MechCoder commented on the pull request: https://github.com/apache/spark/pull/4654#issuecomment-76701605 Hmm. I came up with this, but surely there should be a more elegant way of doing it. import scala.util.Random rng = Random rng.setSeed(0)

[GitHub] spark pull request: [SPARK-6107][CORE] Display inprogress applicat...

2015-03-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4848#issuecomment-76701818 [Test build #28169 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28169/consoleFull) for PR 4848 at commit [`cee8a46`](https://githu

[GitHub] spark pull request: [SPARK-3355][Core]: Allow running maven tests ...

2015-03-02 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/4734#issuecomment-76704162 I'll wait a bit more for @pwendell to comment but I think it's a nice step forward, doesn't break anything or complicate this much more, etc. --- If your project is set u

[GitHub] spark pull request: [SPARK-5794] [SQL] support env argus in add ja...

2015-03-02 Thread watermen
Github user watermen commented on the pull request: https://github.com/apache/spark/pull/4586#issuecomment-76704311 I also found this issue, I fetch your branch and when I run `select * from src join t1 on src.key =t1.a; ` in Mapjoin_addjar.q, it also throws `ERROR CliDriver: java

[GitHub] spark pull request: [SPARK-5830][Core]Don't create unnecessary dir...

2015-03-02 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/4620#issuecomment-76704448 Mind closing this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] spark pull request: [SPARK-5950][SQL]Insert array into a metastore...

2015-03-02 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/4826#discussion_r25595479 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/parquet/ParquetRelation.scala --- @@ -172,9 +173,14 @@ private[sql] object ParquetRelation {

[GitHub] spark pull request: [SPARK-6107][CORE] Display inprogress applicat...

2015-03-02 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/4848#discussion_r25595560 --- Diff: core/src/main/scala/org/apache/spark/deploy/master/Master.scala --- @@ -736,30 +736,31 @@ private[spark] class Master( val appName = app.des

[GitHub] spark pull request: [CORE][minor] enhance the `toArray` method in ...

2015-03-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4825#issuecomment-76706002 [Test build #28170 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28170/consoleFull) for PR 4825 at commit [`c933ee5`](https://githu

[GitHub] spark pull request: [SPARK-6107][CORE] Display inprogress applicat...

2015-03-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4848#issuecomment-76708667 [Test build #28169 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28169/consoleFull) for PR 4848 at commit [`cee8a46`](https://gith

[GitHub] spark pull request: [SPARK-6107][CORE] Display inprogress applicat...

2015-03-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4848#issuecomment-76708670 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28

[GitHub] spark pull request: [SPARK-6107][CORE] Display inprogress applicat...

2015-03-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4848#issuecomment-76708932 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28

[GitHub] spark pull request: [SPARK-6107][CORE] Display inprogress applicat...

2015-03-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4848#issuecomment-76708923 [Test build #28167 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28167/consoleFull) for PR 4848 at commit [`cee03d4`](https://gith

[GitHub] spark pull request: [SPARK-5494][SQL] SparkSqlSerializer Ignores K...

2015-03-02 Thread pwoody
Github user pwoody commented on the pull request: https://github.com/apache/spark/pull/4693#issuecomment-76708974 I believe the bug is due to inconsistency between KryoSerializer and SqlSerializer in the order of registration. I don't know if there is a way to manage multiple Serializ

[GitHub] spark pull request: [SPARK-5950][SQL]Insert array into a metastore...

2015-03-02 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/4826#discussion_r25597104 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/parquet/ParquetRelation.scala --- @@ -172,9 +173,14 @@ private[sql] object ParquetRelation {

[GitHub] spark pull request: [SPARK-5950][SQL]Insert array into a metastore...

2015-03-02 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/4826#discussion_r25597141 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/json/JSONRelation.scala --- @@ -131,7 +131,7 @@ private[sql] case class JSONRelation( ov

[GitHub] spark pull request: [SPARK-4011] tighten the visibility of the mem...

2015-03-02 Thread CodingCat
Github user CodingCat commented on the pull request: https://github.com/apache/spark/pull/4844#issuecomment-76709868 sure, thanks @srowen , I will try to address it today --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: [SPARK-4423] Improve foreach() documentation t...

2015-03-02 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/4696#discussion_r25597664 --- Diff: docs/programming-guide.md --- @@ -728,6 +728,69 @@ def doStuff(self, rdd): +### Understanding closures +One of the harder t

[GitHub] spark pull request: [SPARK-4423] Improve foreach() documentation t...

2015-03-02 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/4696#discussion_r25597775 --- Diff: docs/programming-guide.md --- @@ -728,6 +728,69 @@ def doStuff(self, rdd): +### Understanding closures +One of the harder t

[GitHub] spark pull request: [SPARK-4423] Improve foreach() documentation t...

2015-03-02 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/4696#discussion_r25598156 --- Diff: docs/programming-guide.md --- @@ -728,6 +728,69 @@ def doStuff(self, rdd): +### Understanding closures +One of the harder t

[GitHub] spark pull request: [SPARK-4423] Improve foreach() documentation t...

2015-03-02 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/4696#discussion_r25598261 --- Diff: docs/programming-guide.md --- @@ -728,6 +728,69 @@ def doStuff(self, rdd): +### Understanding closures +One of the harder t

[GitHub] spark pull request: [SPARK-4423] Improve foreach() documentation t...

2015-03-02 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/4696#discussion_r25598357 --- Diff: docs/programming-guide.md --- @@ -728,6 +728,69 @@ def doStuff(self, rdd): +### Understanding closures +One of the harder t

[GitHub] spark pull request: [SPARK-4423] Improve foreach() documentation t...

2015-03-02 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/4696#discussion_r25598471 --- Diff: docs/programming-guide.md --- @@ -728,6 +728,69 @@ def doStuff(self, rdd): +### Understanding closures +One of the harder t

[GitHub] spark pull request: [SPARK-4423] Improve foreach() documentation t...

2015-03-02 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/4696#discussion_r25598561 --- Diff: docs/programming-guide.md --- @@ -1005,7 +1068,8 @@ for details. foreach(func) - Run a function func on each element of the

[GitHub] spark pull request: [SPARK-5950][SQL]Insert array into a metastore...

2015-03-02 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/4826#issuecomment-76715599 @yhuai @marmbrus This PR basically makes both JSON and Parquet data sources always nullable. I agree that this makes most common cases more robust. Should we take a mor

  1   2   3   4   5   >