[GitHub] spark pull request: SPARK-6735:[YARN] Adding properties to disable...

2015-04-12 Thread sryza
Github user sryza commented on a diff in the pull request: https://github.com/apache/spark/pull/5449#discussion_r28217902 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocator.scala --- @@ -119,7 +131,27 @@ private[yarn] class YarnAllocator( def getN

[GitHub] spark pull request: [SPARK-6303][SQL] Remove unnecessary Average i...

2015-04-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4996#issuecomment-92237049 [Test build #30152 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30152/consoleFull) for PR 4996 at commit [`621c12f`](https://githu

[GitHub] spark pull request: [SPARK-6583][SQL] Support aggregated function ...

2015-04-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5290#issuecomment-92237025 [Test build #30151 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30151/consoleFull) for PR 5290 at commit [`36c8126`](https://githu

[GitHub] spark pull request: [SPARK-6583][SQL] Support aggregated function ...

2015-04-12 Thread watermen
Github user watermen commented on a diff in the pull request: https://github.com/apache/spark/pull/5290#discussion_r28217715 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -379,6 +381,33 @@ class Analyzer(catalog: Catalog,

[GitHub] spark pull request: [SPARK-6303][SQL] Add Average in canBeCodeGene...

2015-04-12 Thread viirya
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/4996#issuecomment-92235526 After doing more search, I just found that because `Average` is a `PartialAggregate`, we never get a `Average` node when reaching `HashAggregation` to prepare `GeneratedAg

[GitHub] spark pull request: [SPARK-6868][YARN] Fix broken container log li...

2015-04-12 Thread sryza
Github user sryza commented on the pull request: https://github.com/apache/spark/pull/5477#issuecomment-92235067 This LGTM as well --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-2926][Shuffle]Add MR style sort-merge s...

2015-04-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3438#issuecomment-92231763 [Test build #30143 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30143/consoleFull) for PR 3438 at commit [`d6c94da`](https://gith

[GitHub] spark pull request: [SPARK-5988][MLlib] add save/load for PowerIte...

2015-04-12 Thread yinxusen
Github user yinxusen commented on a diff in the pull request: https://github.com/apache/spark/pull/5450#discussion_r28217008 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/PowerIterationClustering.scala --- @@ -38,7 +43,63 @@ import org.apache.spark.util.random.X

[GitHub] spark pull request: [SPARK-2926][Shuffle]Add MR style sort-merge s...

2015-04-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3438#issuecomment-92231768 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/30

[GitHub] spark pull request: [SPARK-5972] [MLlib] Cache residuals and gradi...

2015-04-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5330#issuecomment-92231474 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/30

[GitHub] spark pull request: [SPARK-5972] [MLlib] Cache residuals and gradi...

2015-04-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5330#issuecomment-92231465 [Test build #30142 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30142/consoleFull) for PR 5330 at commit [`32d409d`](https://gith

[GitHub] spark pull request: [SPARK-6583][SQL] Support aggregated function ...

2015-04-12 Thread watermen
Github user watermen commented on a diff in the pull request: https://github.com/apache/spark/pull/5290#discussion_r28216699 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala --- @@ -36,6 +36,58 @@ class SQLQuerySuite extends QueryTest with BeforeAndAfterA

[GitHub] spark pull request: [SPARK-6583][SQL] Support aggregated function ...

2015-04-12 Thread watermen
Github user watermen commented on a diff in the pull request: https://github.com/apache/spark/pull/5290#discussion_r28216651 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -379,6 +381,33 @@ class Analyzer(catalog: Catalog,

[GitHub] spark pull request: [SPARK-5957][ML] better handling of parameters

2015-04-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5431#issuecomment-92230105 [Test build #30150 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30150/consoleFull) for PR 5431 at commit [`eec2264`](https://githu

[GitHub] spark pull request: [SPARK-5988][MLlib] add save/load for PowerIte...

2015-04-12 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/5450#discussion_r28216481 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/PowerIterationClustering.scala --- @@ -38,7 +43,63 @@ import org.apache.spark.util.random.XOR

[GitHub] spark pull request: [SPARK-5988][MLlib] add save/load for PowerIte...

2015-04-12 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/5450#discussion_r28216448 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/PowerIterationClustering.scala --- @@ -38,7 +43,63 @@ import org.apache.spark.util.random.XOR

[GitHub] spark pull request: [SPARK-6765] Enable scalastyle on test code.

2015-04-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5486#issuecomment-92228720 [Test build #30149 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30149/consoleFull) for PR 5486 at commit [`01683de`](https://githu

[GitHub] spark pull request: [SPARK-6765] Enable scalastyle on test code.

2015-04-12 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/5486#issuecomment-92228230 Jenkins, test this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-6765] Enable scalastyle on test code.

2015-04-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5486#issuecomment-92228246 [Test build #30148 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30148/consoleFull) for PR 5486 at commit [`01683de`](https://githu

[GitHub] spark pull request: [SPARK-6765] Enable scalastyle on test code.

2015-04-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5486#issuecomment-92227423 [Test build #30146 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30146/consoleFull) for PR 5486 at commit [`22014fc`](https://gith

[GitHub] spark pull request: [SPARK-6765] Enable scalastyle on test code.

2015-04-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5486#issuecomment-92227425 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/30

[GitHub] spark pull request: [SPARK-6765] Enable scalastyle on test code.

2015-04-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5486#issuecomment-92227327 [Test build #30146 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30146/consoleFull) for PR 5486 at commit [`22014fc`](https://githu

[GitHub] spark pull request: [SPARK-4961] [CORE] Put HadoopRDD.getPartition...

2015-04-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3794#issuecomment-92227329 [Test build #30147 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30147/consoleFull) for PR 3794 at commit [`d5c0e84`](https://githu

[GitHub] spark pull request: [SPARK-6765] Enable scalastyle on test code.

2015-04-12 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/5486#issuecomment-92226907 Jenkins, test this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-6765] Enable scalastyle on test code.

2015-04-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5486#issuecomment-92225897 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/30

[GitHub] spark pull request: [SPARK-6562][SQL] DataFrame.replace

2015-04-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/5282 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-6562][SQL] DataFrame.replace

2015-04-12 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/5282#issuecomment-92225485 I'm going to merge this now. The resolve thing needs a broader (df-wide) discussion. That should happen but outside of this change. --- If your project is set up for it, yo

[GitHub] spark pull request: [SPARK-6562][SQL] DataFrame.replace

2015-04-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5282#issuecomment-92225181 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/30

[GitHub] spark pull request: [SPARK-6562][SQL] DataFrame.replace

2015-04-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5282#issuecomment-92225177 [Test build #30141 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30141/consoleFull) for PR 5282 at commit [`4b72434`](https://gith

[GitHub] spark pull request: SPARK-6735:[YARN] Adding properties to disable...

2015-04-12 Thread twinkle-sachdeva
Github user twinkle-sachdeva commented on a diff in the pull request: https://github.com/apache/spark/pull/5449#discussion_r28215620 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocator.scala --- @@ -94,6 +98,14 @@ private[yarn] class YarnAllocator( // Ad

[GitHub] spark pull request: WIP: re-enable flaky test to catch failure in ...

2015-04-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5459#issuecomment-92224717 [Test build #30140 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30140/consoleFull) for PR 5459 at commit [`2ead85b`](https://gith

[GitHub] spark pull request: WIP: re-enable flaky test to catch failure in ...

2015-04-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5459#issuecomment-92224747 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/30

[GitHub] spark pull request: SPARK-6735:[YARN] Adding properties to disable...

2015-04-12 Thread twinkle-sachdeva
Github user twinkle-sachdeva commented on a diff in the pull request: https://github.com/apache/spark/pull/5449#discussion_r28215570 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocator.scala --- @@ -119,7 +131,27 @@ private[yarn] class YarnAllocator(

[GitHub] spark pull request: [SPARK-6871][SQL] WITH clause in CTE can not f...

2015-04-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5480#issuecomment-92223415 [Test build #30145 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30145/consoleFull) for PR 5480 at commit [`0edf568`](https://githu

[GitHub] spark pull request: SPARK-6735:[YARN] Adding properties to disable...

2015-04-12 Thread twinkle-sachdeva
Github user twinkle-sachdeva commented on a diff in the pull request: https://github.com/apache/spark/pull/5449#discussion_r28215509 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala --- @@ -59,6 +59,10 @@ private[spark] class ApplicationMaster(

[GitHub] spark pull request: [SPARK-5885][MLLIB] Add VectorAssembler as a f...

2015-04-12 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/5196#issuecomment-92220404 Merged into master. Will send a follow-up PR to handle attributes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub a

[GitHub] spark pull request: [SPARK-5885][MLLIB] Add VectorAssembler as a f...

2015-04-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/5196 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-5886][ML] Add StringIndexer as a featur...

2015-04-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/4735 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-5886][ML] Add StringIndexer as a featur...

2015-04-12 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/4735#issuecomment-92220115 Merged into master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

[GitHub] spark pull request: [SPARK-4081] [mllib] VectorIndexer

2015-04-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/3000 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-6765] Enable scalastyle on test code.

2015-04-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5486#issuecomment-92219187 [Test build #30139 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30139/consoleFull) for PR 5486 at commit [`5060e6b`](https://gith

[GitHub] spark pull request: [SPARK-6765] Enable scalastyle on test code.

2015-04-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5486#issuecomment-92219235 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/30

[GitHub] spark pull request: [SPARK-4081] [mllib] VectorIndexer

2015-04-12 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/3000#issuecomment-92219015 LGTM. Merged into master. Thanks, and sorry for the long delay! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as w

[GitHub] spark pull request: [SPARK-6122][Core] Upgrade tachyon-client vers...

2015-04-12 Thread aarondav
Github user aarondav commented on the pull request: https://github.com/apache/spark/pull/5354#issuecomment-92215817 The change LGTM but I'll leave it to @pwendell to OK the pom changes. I'm not sure if there's a better way to express basically "don't include any of this guy's transiti

[GitHub] spark pull request: [SPARK-5931][CORE] Use consistent naming for t...

2015-04-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5236#issuecomment-92215227 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/30

[GitHub] spark pull request: [SPARK-5931][CORE] Use consistent naming for t...

2015-04-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5236#issuecomment-92215221 [Test build #30138 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30138/consoleFull) for PR 5236 at commit [`bc04e05`](https://gith

[GitHub] spark pull request: [SPARK-6643][MLLIB] Implement StandardScalerMo...

2015-04-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/5310 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-6643][MLLIB] Implement StandardScalerMo...

2015-04-12 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/5310#issuecomment-92215175 Merged into master. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have t

[GitHub] spark pull request: [WIP][SQL][SPARK-6632]: Read schema from each ...

2015-04-12 Thread saucam
Github user saucam commented on a diff in the pull request: https://github.com/apache/spark/pull/5298#discussion_r28214791 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/parquet/ParquetTableSupport.scala --- @@ -98,12 +98,32 @@ private[parquet] class RowReadSupport extends

[GitHub] spark pull request: [SPARK-2926][Shuffle]Add MR style sort-merge s...

2015-04-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3438#issuecomment-92214906 [Test build #30143 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30143/consoleFull) for PR 3438 at commit [`d6c94da`](https://githu

[GitHub] spark pull request: [WIP][SQL][SPARK-6632]: Read schema from each ...

2015-04-12 Thread saucam
Github user saucam commented on a diff in the pull request: https://github.com/apache/spark/pull/5298#discussion_r28214717 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/parquet/ParquetTableSupport.scala --- @@ -98,12 +98,32 @@ private[parquet] class RowReadSupport extends

[GitHub] spark pull request: [SPARK-5972] [MLlib] Cache residuals and gradi...

2015-04-12 Thread MechCoder
Github user MechCoder commented on the pull request: https://github.com/apache/spark/pull/5330#issuecomment-92213809 @jkbradley I pushed an update to the same PR. I agree with the observation, that it would have a much higher impact on evaluateEachIteration, because during training, p

[GitHub] spark pull request: [SPARK-5972] [MLlib] Cache residuals and gradi...

2015-04-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5330#issuecomment-92213928 [Test build #30142 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30142/consoleFull) for PR 5330 at commit [`32d409d`](https://githu

[GitHub] spark pull request: [SPARK-6734] [SQL] Add UDTF.close support in G...

2015-04-12 Thread chenghao-intel
Github user chenghao-intel commented on a diff in the pull request: https://github.com/apache/spark/pull/5383#discussion_r28214577 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/Generate.scala --- @@ -75,9 +78,15 @@ case class Generate( outputRows

[GitHub] spark pull request: [SPARK-5972] [MLlib] Cache residuals and gradi...

2015-04-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5330#issuecomment-92211060 [Test build #30137 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30137/consoleFull) for PR 5330 at commit [`d542bb0`](https://gith

[GitHub] spark pull request: [SPARK-5972] [MLlib] Cache residuals and gradi...

2015-04-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5330#issuecomment-92211097 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/30

[GitHub] spark pull request: [SPARK-5972] [MLlib] Cache residuals and gradi...

2015-04-12 Thread MechCoder
Github user MechCoder commented on the pull request: https://github.com/apache/spark/pull/5330#issuecomment-92209807 Never mind, figured out, it should not take much effort, working on an update to this PR itself. --- If your project is set up for it, you can reply to this email and

[GitHub] spark pull request: [Spark-6839] BlockManger.dataDeserialize must ...

2015-04-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5463#issuecomment-92205153 [Test build #30136 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30136/consoleFull) for PR 5463 at commit [`e632315`](https://gith

[GitHub] spark pull request: [Spark-6839] BlockManger.dataDeserialize must ...

2015-04-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5463#issuecomment-92205170 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/30

[GitHub] spark pull request: [SQL] [Minor] Fix for SqlApp.scala

2015-04-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5485#issuecomment-92204896 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/30

[GitHub] spark pull request: [SQL] [Minor] Fix for SqlApp.scala

2015-04-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5485#issuecomment-92204894 [Test build #30135 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30135/consoleFull) for PR 5485 at commit [`6f731c2`](https://gith

[GitHub] spark pull request: [SPARK-6765] Fix test code style for core.

2015-04-12 Thread aarondav
Github user aarondav commented on a diff in the pull request: https://github.com/apache/spark/pull/5484#discussion_r28213874 --- Diff: core/src/test/scala/org/apache/spark/serializer/KryoSerializerSuite.scala --- @@ -106,7 +106,9 @@ class KryoSerializerSuite extends FunSuite with

[GitHub] spark pull request: WIP: re-enable flaky test to catch failure in ...

2015-04-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5459#issuecomment-92204156 [Test build #30140 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30140/consoleFull) for PR 5459 at commit [`2ead85b`](https://githu

[GitHub] spark pull request: [SPARK-6562][SQL] DataFrame.replace

2015-04-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5282#issuecomment-92204146 [Test build #30141 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30141/consoleFull) for PR 5282 at commit [`4b72434`](https://githu

[GitHub] spark pull request: WIP: re-enable flaky test to catch failure in ...

2015-04-12 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/5459#issuecomment-92201987 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have th

[GitHub] spark pull request: WIP: re-enable flaky test to catch failure in ...

2015-04-12 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/5459#issuecomment-92202025 It just doesn't fail when you wanted it to fail! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proj

[GitHub] spark pull request: [SPARK-5972] [MLlib] Cache residuals and gradi...

2015-04-12 Thread MechCoder
Github user MechCoder commented on the pull request: https://github.com/apache/spark/pull/5330#issuecomment-92198905 Thanks for the tests. I get the gist of what you mean. I'd be happy to merge this PR and work on this as a future JIRA. If I have any queries, I shall comment o

[GitHub] spark pull request: [SPARK-6765] Enable scalastyle on test code.

2015-04-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5486#issuecomment-92195623 [Test build #30139 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30139/consoleFull) for PR 5486 at commit [`5060e6b`](https://githu

[GitHub] spark pull request: [SPARK-6765] Enable scalastyle on test code.

2015-04-12 Thread rxin
GitHub user rxin opened a pull request: https://github.com/apache/spark/pull/5486 [SPARK-6765] Enable scalastyle on test code. Turn scalastyle on for all test code. Most of the violations have been resolved in my previous pull requests: Core: https://github.com/apache/spark

[GitHub] spark pull request: [SPARK-2973] [SQL] Avoid spark job for take on...

2015-04-12 Thread scwf
Github user scwf commented on the pull request: https://github.com/apache/spark/pull/5247#issuecomment-92191089 Hi @marmbrus, first i think this change is not doing query planning because 1 query planning is to convert a logical plan to spark plan (correct me if i misunderstan

[GitHub] spark pull request: [SPARK-5941] [SQL] Unit Test loads the table `...

2015-04-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4506#issuecomment-92189980 [Test build #30131 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30131/consoleFull) for PR 4506 at commit [`b463f8a`](https://gith

[GitHub] spark pull request: [SPARK-5941] [SQL] Unit Test loads the table `...

2015-04-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4506#issuecomment-9219 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/30

[GitHub] spark pull request: [SPARK-5972] [MLlib] Cache residuals and gradi...

2015-04-12 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/5330#issuecomment-92189854 That is it, but I ran some timing tests locally and found essentially no difference between the two implementations, like you reported. I think the issue is the overhe

[GitHub] spark pull request: [SPARK-6765] Fix test code style for core.

2015-04-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/5484 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-6765] Fix test code style for core.

2015-04-12 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/5484#issuecomment-92189397 Merging in master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-6765] Fix test code style for core.

2015-04-12 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/5484#discussion_r28213119 --- Diff: core/src/test/scala/org/apache/spark/serializer/KryoSerializerSuite.scala --- @@ -106,7 +106,9 @@ class KryoSerializerSuite extends FunSuite with Shar

[GitHub] spark pull request: [SPARK-6765] Fix test code style for core.

2015-04-12 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/5484#discussion_r28213105 --- Diff: core/src/test/scala/org/apache/spark/deploy/rest/StandaloneRestSubmitSuite.scala --- @@ -508,7 +508,7 @@ private class DummyMaster( exception

[GitHub] spark pull request: [SPARK-6198][SQL] Support "select current_data...

2015-04-12 Thread DoingDone9
Github user DoingDone9 commented on the pull request: https://github.com/apache/spark/pull/4995#issuecomment-92189086 Could you tell me how you got this exception? I test with three nodes , and it works again. Thank you @marmbrus --- If your project is set up for it, you can reply t

[GitHub] spark pull request: [SPARK-5941] [SQL] Unit Test loads the table `...

2015-04-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4506#issuecomment-92188010 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/30

[GitHub] spark pull request: [SPARK-5941] [SQL] Unit Test loads the table `...

2015-04-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4506#issuecomment-92187993 [Test build #30133 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30133/consoleFull) for PR 4506 at commit [`0be05f7`](https://gith

[GitHub] spark pull request: [SPARK-5941] [SQL] Unit Test loads the table `...

2015-04-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4506#issuecomment-92187601 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/30

[GitHub] spark pull request: [SPARK-5941] [SQL] Unit Test loads the table `...

2015-04-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4506#issuecomment-92187592 [Test build #30132 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30132/consoleFull) for PR 4506 at commit [`dd0b3f6`](https://gith

[GitHub] spark pull request: [SPARK-6870][Yarn] Catch InterruptedException ...

2015-04-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5479#issuecomment-92187267 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/30

[GitHub] spark pull request: [SPARK-6870][Yarn] Catch InterruptedException ...

2015-04-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5479#issuecomment-92187233 [Test build #30129 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30129/consoleFull) for PR 5479 at commit [`f775f93`](https://gith

[GitHub] spark pull request: [Spark-6839] BlockManger.dataDeserialize must ...

2015-04-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5463#issuecomment-92186450 [Test build #30134 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30134/consoleFull) for PR 5463 at commit [`15106ab`](https://gith

[GitHub] spark pull request: [Spark-6839] BlockManger.dataDeserialize must ...

2015-04-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5463#issuecomment-92186454 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/30

[GitHub] spark pull request: [SPARK-5931][CORE] Use consistent naming for t...

2015-04-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5236#issuecomment-92186301 [Test build #30138 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30138/consoleFull) for PR 5236 at commit [`bc04e05`](https://githu

[GitHub] spark pull request: [SPARK-5931][CORE] Use consistent naming for t...

2015-04-12 Thread ilganeli
Github user ilganeli commented on the pull request: https://github.com/apache/spark/pull/5236#issuecomment-92185204 All changes pulled in - I think all parties should be happy now :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark pull request: [SPARK-5972] [MLlib] Cache residuals and gradi...

2015-04-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5330#issuecomment-92184844 [Test build #30137 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30137/consoleFull) for PR 5330 at commit [`d542bb0`](https://githu

[GitHub] spark pull request: [SPARK-5972] [MLlib] Cache residuals and gradi...

2015-04-12 Thread MechCoder
Github user MechCoder commented on the pull request: https://github.com/apache/spark/pull/5330#issuecomment-92184482 @jkbradley fixed! hopefully that should be it :P --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-5931][CORE] Use consistent naming for t...

2015-04-12 Thread ilganeli
Github user ilganeli commented on a diff in the pull request: https://github.com/apache/spark/pull/5236#discussion_r28212679 --- Diff: network/common/src/main/java/org/apache/spark/network/util/TransportConf.java --- @@ -37,8 +37,11 @@ public boolean preferDirectBufs() {

[GitHub] spark pull request: [Spark-6839] BlockManger.dataDeserialize must ...

2015-04-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5463#issuecomment-92183786 [Test build #30136 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30136/consoleFull) for PR 5463 at commit [`e632315`](https://githu

[GitHub] spark pull request: [SPARK-5931][CORE] Use consistent naming for t...

2015-04-12 Thread ilganeli
Github user ilganeli commented on a diff in the pull request: https://github.com/apache/spark/pull/5236#discussion_r28212643 --- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala --- @@ -1011,6 +1014,30 @@ private[spark] object Utils extends Logging { }

[GitHub] spark pull request: [SPARK-6352] [SQL] Add DirectParquetOutputComm...

2015-04-12 Thread ypcat
Github user ypcat commented on the pull request: https://github.com/apache/spark/pull/5042#issuecomment-92183165 @liancheng this DirectParquetOutputCommitter is based on DirectOutputCommitter in this [thread](https://mail-archives.apache.org/mod_mbox/spark-user/201502.mbox/%3ccangvg8q

[GitHub] spark pull request: [SPARK-5931][CORE] Use consistent naming for t...

2015-04-12 Thread ilganeli
Github user ilganeli commented on a diff in the pull request: https://github.com/apache/spark/pull/5236#discussion_r28212639 --- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala --- @@ -611,9 +613,10 @@ private[spark] object Utils extends Logging { }

[GitHub] spark pull request: [SPARK-5931][CORE] Use consistent naming for t...

2015-04-12 Thread ilganeli
Github user ilganeli commented on a diff in the pull request: https://github.com/apache/spark/pull/5236#discussion_r28212581 --- Diff: core/src/main/scala/org/apache/spark/HeartbeatReceiver.scala --- @@ -62,14 +62,17 @@ private[spark] class HeartbeatReceiver(sc: SparkContext)

[GitHub] spark pull request: [SPARK-5931][CORE] Use consistent naming for t...

2015-04-12 Thread ilganeli
Github user ilganeli commented on a diff in the pull request: https://github.com/apache/spark/pull/5236#discussion_r28212575 --- Diff: core/src/main/scala/org/apache/spark/HeartbeatReceiver.scala --- @@ -62,14 +62,17 @@ private[spark] class HeartbeatReceiver(sc: SparkContext)

[GitHub] spark pull request: [SPARK-6734] [SQL] Add UDTF.close support in G...

2015-04-12 Thread chenghao-intel
Github user chenghao-intel commented on a diff in the pull request: https://github.com/apache/spark/pull/5383#discussion_r28212494 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/Generate.scala --- @@ -75,9 +78,15 @@ case class Generate( outputRows

[GitHub] spark pull request: [Spark-6839] BlockManger.dataDeserialize must ...

2015-04-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5463#issuecomment-92179758 [Test build #30130 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30130/consoleFull) for PR 5463 at commit [`29a22a9`](https://gith

[GitHub] spark pull request: [Spark-6839] BlockManger.dataDeserialize must ...

2015-04-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5463#issuecomment-92179785 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/30

  1   2   3   >