[GitHub] spark pull request: [SPARK-3382][MLLIB] GradientDescent convergenc...

2015-06-13 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3636#issuecomment-111793235 [Test build #34873 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34873/console) for PR 3636 at commit [`8313ba2`](https://github.

[GitHub] spark pull request: [SPARK-3382][MLLIB] GradientDescent convergenc...

2015-06-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3636#issuecomment-111793290 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-8056][SQL] Design an easier way to cons...

2015-06-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6686#issuecomment-111791373 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-8056][SQL] Design an easier way to cons...

2015-06-13 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6686#issuecomment-111791362 [Test build #34872 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34872/console) for PR 6686 at commit [`6aeb740`](https://github.

[GitHub] spark pull request: [SPARK-8218][SQL] Add binary log math function

2015-06-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6725#issuecomment-111790522 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-8218][SQL] Add binary log math function

2015-06-13 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6725#issuecomment-111790437 **[Test build #34867 timed out](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34867/console)** for PR 6725 at commit [`6089d11`](https://github

[GitHub] spark pull request: [SPARK-8350] [R] Log R unit test output to "un...

2015-06-13 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6807#issuecomment-111788118 [Test build #34876 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34876/consoleFull) for PR 6807 at commit [`407c46c`](https://gith

[GitHub] spark pull request: [SPARK-8350] [R] Log R unit test output to "un...

2015-06-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6807#issuecomment-111788093 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-8350] [R] Log R unit test output to "un...

2015-06-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6807#issuecomment-111788095 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-8350] [R] Log R unit test output to "un...

2015-06-13 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/6807#issuecomment-111788053 Looks like R is a little different from other modules because there's no `src/main/resources`. I added `target` in front of the path. Let's see if this works. --- I

[GitHub] spark pull request: [SPARK-8070] [SQL] [PYSPARK] avoid spark jobs ...

2015-06-13 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6606#issuecomment-111787404 [Test build #34875 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34875/consoleFull) for PR 6606 at commit [`a5928bf`](https://gith

[GitHub] spark pull request: [SPARK-8070] [SQL] [PYSPARK] avoid spark jobs ...

2015-06-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6606#issuecomment-111787387 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-8070] [SQL] [PYSPARK] avoid spark jobs ...

2015-06-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6606#issuecomment-111787391 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-8307] [SQL] improve timestamp from parq...

2015-06-13 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6759#issuecomment-111787259 [Test build #913 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/913/consoleFull) for PR 6759 at commit [`2f2e48c`](https://githu

[GitHub] spark pull request: [SPARK-8307] [SQL] improve timestamp from parq...

2015-06-13 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6759#issuecomment-111787249 [Test build #911 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/911/consoleFull) for PR 6759 at commit [`2f2e48c`](https://githu

[GitHub] spark pull request: [SPARK-8307] [SQL] improve timestamp from parq...

2015-06-13 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6759#issuecomment-111787252 [Test build #912 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/912/consoleFull) for PR 6759 at commit [`2f2e48c`](https://githu

[GitHub] spark pull request: [SPARK-7184] [SQL] enable codegen by default

2015-06-13 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/6726#issuecomment-111787217 @marmbrus @rxin I think this is ready to review, thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. I

[GitHub] spark pull request: [SPARK-8301][SQL] Improve UTF8String substring...

2015-06-13 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/6804#discussion_r32376753 --- Diff: unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java --- @@ -131,24 +131,31 @@ public boolean contains(final UTF8String substring) {

[GitHub] spark pull request: [SPARK-8301][SQL] Improve UTF8String substring...

2015-06-13 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/6804#discussion_r32376747 --- Diff: unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java --- @@ -131,24 +131,31 @@ public boolean contains(final UTF8String substring) {

[GitHub] spark pull request: [SPARK-8301][SQL] Improve UTF8String substring...

2015-06-13 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/6804#discussion_r32376728 --- Diff: unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java --- @@ -131,24 +131,31 @@ public boolean contains(final UTF8String substring) {

[GitHub] spark pull request: [SPARK-8301][SQL] Improve UTF8String substring...

2015-06-13 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/6804#issuecomment-111786937 @tarekauel Thanks for working on this, could you have some micro benchmark to show the performance difference? It's good to see the improvements by numbers. --- If your

[GitHub] spark pull request: [SPARK-7017][Build][Project Infra]: Refactor d...

2015-06-13 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5694#issuecomment-111785726 [Test build #34874 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34874/consoleFull) for PR 5694 at commit [`ec1ae78`](https://gith

[GitHub] spark pull request: [SPARK-7017][Build][Project Infra]: Refactor d...

2015-06-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5694#issuecomment-111785407 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-7017][Build][Project Infra]: Refactor d...

2015-06-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5694#issuecomment-111785410 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-3382][MLLIB] GradientDescent convergenc...

2015-06-13 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3636#issuecomment-111785182 [Test build #34873 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34873/consoleFull) for PR 3636 at commit [`8313ba2`](https://gith

[GitHub] spark pull request: [SPARK-3382][MLLIB] GradientDescent convergenc...

2015-06-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3636#issuecomment-111785099 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-3382][MLLIB] GradientDescent convergenc...

2015-06-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3636#issuecomment-111785105 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-3382][MLLIB] GradientDescent convergenc...

2015-06-13 Thread Lewuathe
Github user Lewuathe commented on the pull request: https://github.com/apache/spark/pull/3636#issuecomment-111785029 @jkbradley Sorry for late fixing. Can you check it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If y

[GitHub] spark pull request: [SPARK-8342][SQL] Fix Decimal setOrNull

2015-06-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/6797 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SQL] SPARK-6489: Optimize lateral view with e...

2015-06-13 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/5358#discussion_r32376607 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/PruningSuite.scala --- @@ -87,6 +87,27 @@ class PruningSuite extends HiveComparisonTes

[GitHub] spark pull request: [SPARK-8342][SQL] Fix Decimal setOrNull

2015-06-13 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6797#issuecomment-111784944 [Test build #34868 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34868/console) for PR 6797 at commit [`8a447b1`](https://github.

[GitHub] spark pull request: [SPARK-8342][SQL] Fix Decimal setOrNull

2015-06-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6797#issuecomment-111784952 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SQL] SPARK-6489: Optimize lateral view with e...

2015-06-13 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/5358#discussion_r32376603 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/Generate.scala --- @@ -56,7 +56,8 @@ case class Generate( val boundGenerator = BindRe

[GitHub] spark pull request: [SQL] SPARK-6489: Optimize lateral view with e...

2015-06-13 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/5358#discussion_r32376596 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/FilterPushdownSuite.scala --- @@ -502,7 +502,11 @@ class FilterPushdownSuite e

[GitHub] spark pull request: [SQL] SPARK-6489: Optimize lateral view with e...

2015-06-13 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/5358#discussion_r32376589 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -171,6 +172,10 @@ object ColumnPruning extends Rule[Log

[GitHub] spark pull request: [SPARK-8056][SQL] Design an easier way to cons...

2015-06-13 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6686#issuecomment-111784090 [Test build #34872 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34872/consoleFull) for PR 6686 at commit [`6aeb740`](https://gith

[GitHub] spark pull request: [SPARK-8056][SQL] Design an easier way to cons...

2015-06-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6686#issuecomment-111784043 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-8056][SQL] Design an easier way to cons...

2015-06-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6686#issuecomment-111784039 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-8358][SQL] Wait for child resolution wh...

2015-06-13 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6811#issuecomment-111783799 [Test build #34871 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34871/console) for PR 6811 at commit [`7cbb530`](https://github.

[GitHub] spark pull request: [SPARK-8358][SQL] Wait for child resolution wh...

2015-06-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6811#issuecomment-111783800 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-8358][SQL] Wait for child resolution wh...

2015-06-13 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6811#issuecomment-111783750 [Test build #34871 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34871/consoleFull) for PR 6811 at commit [`7cbb530`](https://gith

[GitHub] spark pull request: [SPARK-8358][SQL] Wait for child resolution wh...

2015-06-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6811#issuecomment-111783725 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-8358][SQL] Wait for child resolution wh...

2015-06-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6811#issuecomment-111783722 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-8358][SQL] Wait for child resolution wh...

2015-06-13 Thread marmbrus
GitHub user marmbrus opened a pull request: https://github.com/apache/spark/pull/6811 [SPARK-8358][SQL] Wait for child resolution when resolving generators You can merge this pull request into a Git repository by running: $ git pull https://github.com/marmbrus/spark aliasExplo

[GitHub] spark pull request: [SPARK-8218][SQL] Add binary log math function

2015-06-13 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/6725#discussion_r32376385 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/math.scala --- @@ -255,3 +255,18 @@ case class Pow(left: Expression, right: Expr

[GitHub] spark pull request: [SPARK-8056][SQL] Design an easier way to cons...

2015-06-13 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6686#issuecomment-111783685 [Test build #34870 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34870/consoleFull) for PR 6686 at commit [`689e54d`](https://gith

[GitHub] spark pull request: [SPARK-8056][SQL] Design an easier way to cons...

2015-06-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6686#issuecomment-111783629 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-8056][SQL] Design an easier way to cons...

2015-06-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6686#issuecomment-111783631 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-8218][SQL] Add binary log math function

2015-06-13 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6725#issuecomment-111783111 **[Test build #34862 timed out](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34862/console)** for PR 6725 at commit [`db7dc38`](https://github

[GitHub] spark pull request: [SPARK-8218][SQL] Add binary log math function

2015-06-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6725#issuecomment-111783117 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-8218][SQL] Add binary log math function

2015-06-13 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/6725#discussion_r32376356 --- Diff: python/pyspark/sql/functions.py --- @@ -143,7 +143,8 @@ def _(): 'atan2': 'Returns the angle theta from the conversion of rectangular coordina

[GitHub] spark pull request: [SPARK-8056][SQL] Design an easier way to cons...

2015-06-13 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/6686#discussion_r32376351 --- Diff: python/pyspark/sql/types.py --- @@ -367,9 +378,54 @@ def __init__(self, fields): >>> struct1 == struct2 False """

[GitHub] spark pull request: SPARK-8153 Add configuration for disabling par...

2015-06-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6696#issuecomment-111782720 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: SPARK-8153 Add configuration for disabling par...

2015-06-13 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6696#issuecomment-111782715 [Test build #34864 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34864/console) for PR 6696 at commit [`f9616b9`](https://github.

[GitHub] spark pull request: [SPARK-7184] [SQL] enable codegen by default

2015-06-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6726#issuecomment-111782666 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-7184] [SQL] enable codegen by default

2015-06-13 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6726#issuecomment-111782665 [Test build #34865 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34865/console) for PR 6726 at commit [`73750ea`](https://github.

[GitHub] spark pull request: [SPARK-8218][SQL] Add binary log math function

2015-06-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6725#issuecomment-111780568 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-8218][SQL] Add binary log math function

2015-06-13 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6725#issuecomment-111780478 [Test build #34863 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34863/console) for PR 6725 at commit [`bc89597`](https://github.

[GitHub] spark pull request: [SPARK-8056][SQL] Design an easier way to cons...

2015-06-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6686#issuecomment-111780254 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-8056][SQL] Design an easier way to cons...

2015-06-13 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6686#issuecomment-111780252 [Test build #34869 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34869/console) for PR 6686 at commit [`f497e9e`](https://github.

[GitHub] spark pull request: [Spark-8343] [Streaming] [Docs] Improve Spark ...

2015-06-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/6801 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-8056][SQL] Design an easier way to cons...

2015-06-13 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6686#issuecomment-111780199 [Test build #34869 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34869/consoleFull) for PR 6686 at commit [`f497e9e`](https://gith

[GitHub] spark pull request: [SPARK-8056][SQL] Design an easier way to cons...

2015-06-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6686#issuecomment-111780178 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-8056][SQL] Design an easier way to cons...

2015-06-13 Thread ilganeli
Github user ilganeli commented on a diff in the pull request: https://github.com/apache/spark/pull/6686#discussion_r32376192 --- Diff: python/pyspark/sql/types.py --- @@ -367,9 +378,54 @@ def __init__(self, fields): >>> struct1 == struct2 False

[GitHub] spark pull request: [SPARK-8056][SQL] Design an easier way to cons...

2015-06-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6686#issuecomment-111780174 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [Spark-8343] [Streaming] [Docs] Improve Spark ...

2015-06-13 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/6801#issuecomment-111780185 Thanks. I'm merging this in master & branch-1.4. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pro

[GitHub] spark pull request: [SPARK-8056][SQL] Design an easier way to cons...

2015-06-13 Thread ilganeli
Github user ilganeli commented on a diff in the pull request: https://github.com/apache/spark/pull/6686#discussion_r32376189 --- Diff: python/pyspark/sql/types.py --- @@ -349,13 +349,24 @@ def fromJson(cls, json): json["metadata"]) +cl

[GitHub] spark pull request: [SPARK-7186] [SQL] Decouple internal Row from ...

2015-06-13 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/6792#issuecomment-111779858 Another nit: ``` [warn] /home/michael/spark/sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/ScalaReflectionSuite.scala:24: imported `InternalRow'

[GitHub] spark pull request: [SPARK-8342][SQL] Fix Decimal setOrNull

2015-06-13 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6797#issuecomment-111778945 [Test build #34868 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34868/consoleFull) for PR 6797 at commit [`8a447b1`](https://gith

[GitHub] spark pull request: [SPARK-8342][SQL] Fix Decimal setOrNull

2015-06-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6797#issuecomment-111778601 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-8218][SQL] Add binary log math function

2015-06-13 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6725#issuecomment-111778145 [Test build #34867 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34867/consoleFull) for PR 6725 at commit [`6089d11`](https://gith

[GitHub] spark pull request: [SPARK-8218][SQL] Add binary log math function

2015-06-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6725#issuecomment-111777972 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-8218][SQL] Add binary log math function

2015-06-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6725#issuecomment-111777968 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-8056][SQL] Design an easier way to cons...

2015-06-13 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/6686#discussion_r32376023 --- Diff: python/pyspark/sql/types.py --- @@ -349,13 +349,24 @@ def fromJson(cls, json): json["metadata"]) +class

[GitHub] spark pull request: [SPARK-8056][SQL] Design an easier way to cons...

2015-06-13 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/6686#issuecomment-111777949 BTW you might want to remove the "WIP" tag in the pull request title now. --- If your project is set up for it, you can reply to this email and have your reply appear on Gi

[GitHub] spark pull request: [SPARK-8056][SQL] Design an easier way to cons...

2015-06-13 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/6686#discussion_r32376017 --- Diff: python/pyspark/sql/types.py --- @@ -367,9 +378,54 @@ def __init__(self, fields): >>> struct1 == struct2 False """

[GitHub] spark pull request: [SPARK-8301][SQL] Improve UTF8String substring...

2015-06-13 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/6804#issuecomment-111777894 cc @davies for review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] spark pull request: [SPARK-8218][SQL] Add binary log math function

2015-06-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6725#issuecomment-111777875 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-8218][SQL] Add binary log math function

2015-06-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6725#issuecomment-111777873 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-8357] [SQL] Memory leakage on unsafe ag...

2015-06-13 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/6810#issuecomment-111777483 I guess there's not a super easy way to add a regression test for this since it's kind of hard to just instantiate the operator and run it with some empty input. ---

[GitHub] spark pull request: [SPARK-8357] [SQL] Memory leakage on unsafe ag...

2015-06-13 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/6810#discussion_r32375944 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/GeneratedAggregate.scala --- @@ -270,7 +270,9 @@ case class GeneratedAggregate(

[GitHub] spark pull request: [SPARK-8354] [SQL] Fix off-by-factor-of-8 erro...

2015-06-13 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6809#issuecomment-111776515 [Test build #34861 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34861/console) for PR 6809 at commit [`6520339`](https://github.

[GitHub] spark pull request: [SPARK-8354] [SQL] Fix off-by-factor-of-8 erro...

2015-06-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6809#issuecomment-111776518 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-8218][SQL] Add binary log math function

2015-06-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6725#issuecomment-111776341 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-8218][SQL] Add binary log math function

2015-06-13 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6725#issuecomment-111776334 [Test build #34860 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34860/console) for PR 6725 at commit [`0634ef7`](https://github.

[GitHub] spark pull request: [SPARK-8357] [SQL] Memory leakage on unsafe ag...

2015-06-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6810#issuecomment-111776267 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pr

[GitHub] spark pull request: [SPARK-8357] [SQL] Memory leakage on unsafe ag...

2015-06-13 Thread navis
GitHub user navis opened a pull request: https://github.com/apache/spark/pull/6810 [SPARK-8357] [SQL] Memory leakage on unsafe aggregation path with empty input Currently, unsafe-based hash is released on 'next' call but if input is empty, it would not be called ever. You can mer

[GitHub] spark pull request: SPARK-8153 Add configuration for disabling par...

2015-06-13 Thread navis
Github user navis commented on the pull request: https://github.com/apache/spark/pull/6696#issuecomment-111774230 @JoshRosen ok, sure. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] spark pull request: [SPARK-7184] [SQL] enable codegen by default

2015-06-13 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6726#issuecomment-111774126 [Test build #34865 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34865/consoleFull) for PR 6726 at commit [`73750ea`](https://gith

[GitHub] spark pull request: [SPARK-7184] [SQL] enable codegen by default

2015-06-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6726#issuecomment-111773878 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-7184] [SQL] enable codegen by default

2015-06-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6726#issuecomment-111773882 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: SPARK-8153 Add configuration for disabling par...

2015-06-13 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/6696#issuecomment-111772763 @navis, good catch on finding the memory leak in the unsafe aggregation path. I think that maybe we should extract that bugfix into its own PR so that it's easier to

[GitHub] spark pull request: SPARK-8153 Add configuration for disabling par...

2015-06-13 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6696#issuecomment-111772546 [Test build #34864 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34864/consoleFull) for PR 6696 at commit [`f9616b9`](https://gith

[GitHub] spark pull request: [SPARK-2315] Implement drop, dropRight and dro...

2015-06-13 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/1839#discussion_r32375677 --- Diff: core/src/main/scala/org/apache/spark/rdd/DropRDDFunctions.scala --- @@ -0,0 +1,172 @@ +/* + * Licensed to the Apache Software Foundation (

[GitHub] spark pull request: SPARK-8153 Add configuration for disabling par...

2015-06-13 Thread navis
Github user navis commented on the pull request: https://github.com/apache/spark/pull/6696#issuecomment-111772515 The memory leakage caused the test fail was a existing bug in master branch. Currently, unsafe-based hash is released on 'next' call but if input is empty, it would not be

[GitHub] spark pull request: SPARK-8153 Add configuration for disabling par...

2015-06-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6696#issuecomment-111772463 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: SPARK-8153 Add configuration for disabling par...

2015-06-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6696#issuecomment-111772460 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-8218][SQL] Add binary log math function

2015-06-13 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/6725#discussion_r32375635 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala --- @@ -1084,6 +1084,22 @@ object functions { def log(columnName: String): Column =

[GitHub] spark pull request: [SPARK-8218][SQL] Add binary log math function

2015-06-13 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/6725#discussion_r32375632 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/math.scala --- @@ -90,18 +90,26 @@ abstract class UnaryMathExpression(f: Double

[GitHub] spark pull request: [SPARK-8218][SQL] Add binary log math function

2015-06-13 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6725#issuecomment-111771425 [Test build #34863 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34863/consoleFull) for PR 6725 at commit [`bc89597`](https://gith

  1   2   3   4   5   >