Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7035#issuecomment-118256514
[Test build #36476 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36476/console)
for PR 7035 at commit
[`3e9f5ae`](https://github.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7192#issuecomment-118256360
[Test build #36485 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36485/console)
for PR 7192 at commit
[`738e81d`](https://github.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7192#issuecomment-118256377
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user sarutak commented on a diff in the pull request:
https://github.com/apache/spark/pull/7207#discussion_r33843582
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/UDFSuite.scala ---
@@ -82,6 +83,48 @@ class UDFSuite extends QueryTest {
assert(ctx.sql("SELECT
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7176#issuecomment-118254752
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7203#issuecomment-118254748
[Test build #36486 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36486/consoleFull)
for PR 7203 at commit
[`2d0ed15`](https://gith
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7176#issuecomment-118254700
[Test build #36474 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36474/console)
for PR 7176 at commit
[`f71634d`](https://github.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7203#issuecomment-118253650
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/7203#issuecomment-118254038
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7203#issuecomment-118253745
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/7168#issuecomment-118253071
cc @mengxr
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabl
Github user piaozhexiu commented on a diff in the pull request:
https://github.com/apache/spark/pull/7203#discussion_r33843363
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/ScalaUDF.scala
---
@@ -24,13 +24,18 @@ import org.apache.spark.sql.types.D
Github user piaozhexiu commented on a diff in the pull request:
https://github.com/apache/spark/pull/7203#discussion_r33843354
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/UDFRegistration.scala ---
@@ -87,6 +87,7 @@ class UDFRegistration private[sql] (sqlContext:
SQLCont
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7099#issuecomment-118251941
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7207#issuecomment-118251827
[Test build #36484 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36484/console)
for PR 7207 at commit
[`1a3c5ff`](https://github.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7099#issuecomment-118251812
[Test build #36480 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36480/console)
for PR 7099 at commit
[`072e948`](https://github.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7207#issuecomment-118251829
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user zhichao-li commented on a diff in the pull request:
https://github.com/apache/spark/pull/7035#discussion_r33843222
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/math.scala
---
@@ -521,6 +521,55 @@ case class ShiftRight(left: Expression
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7207#issuecomment-118251660
[Test build #36484 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36484/consoleFull)
for PR 7207 at commit
[`1a3c5ff`](https://gith
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/6795#discussion_r33843163
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/SignificantSelector.scala
---
@@ -0,0 +1,127 @@
+/*
+ * Licensed to the Apache Sof
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7192#issuecomment-118251491
[Test build #36485 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36485/consoleFull)
for PR 7192 at commit
[`738e81d`](https://gith
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/6795#discussion_r33843068
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/feature/SignificantSelectorTest.scala
---
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the Apache
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/6795#discussion_r33843067
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/feature/SignificantSelectorTest.scala
---
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the Apache
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7207#issuecomment-118251389
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7192#issuecomment-118251388
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7207#issuecomment-118251369
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7192#issuecomment-118251370
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6985#issuecomment-118251165
[Test build #36483 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36483/consoleFull)
for PR 6985 at commit
[`6a20b64`](https://gith
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/6985#issuecomment-118251254
lgtm
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/7176#discussion_r33842967
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/RandomDataGeneratorSuite.scala
---
@@ -0,0 +1,99 @@
+/*
+ * Licensed to the Apache Software F
Github user sarutak commented on the pull request:
https://github.com/apache/spark/pull/7207#issuecomment-118250753
ok to test.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
en
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6985#issuecomment-118250558
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6985#issuecomment-118250508
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/7176#issuecomment-118250140
LGTM except for minor styling issues.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project d
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/7196#discussion_r33842849
--- Diff:
launcher/src/test/java/org/apache/spark/launcher/SparkSubmitCommandBuilderSuite.java
---
@@ -194,7 +194,7 @@ private void testCmdBuilder(boolean isD
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/7176#discussion_r33842768
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/RandomDataGeneratorSuite.scala
---
@@ -0,0 +1,99 @@
+/*
+ * Licensed to the Apache Softw
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/6795#discussion_r33842684
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/SignificantSelector.scala
---
@@ -0,0 +1,127 @@
+/*
+ * Licensed to the Apache Sof
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7192#issuecomment-118249799
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7192#issuecomment-118249788
[Test build #36481 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36481/console)
for PR 7192 at commit
[`ec3fb10`](https://github.
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/7192#issuecomment-118249489
hi @andrewor14 , I rethink about it, closure cleaner maybe expensive, but
if we can avoid the `$out` reference and then avoid serialization of it, is it
a kind of spee
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/6985#discussion_r33842559
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeFunctions.scala
---
@@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apa
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/6985#discussion_r33842558
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeFunctions.scala
---
@@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apa
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/6985#discussion_r33842525
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DatetimeExpressionsSuite.scala ---
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apache Software Founda
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7192#issuecomment-118248666
[Test build #36482 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36482/consoleFull)
for PR 7192 at commit
[`2fd6f40`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7192#issuecomment-118248598
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7192#issuecomment-118248592
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/7207#issuecomment-118248560
Jenkins, ok to test.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fea
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/7207#issuecomment-118248348
Thanks - looks pretty good for the first patch!
There are just some minor style issues.
---
If your project is set up for it, you can reply to this email and hav
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/7207#discussion_r33842386
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/UDFSuite.scala ---
@@ -82,6 +83,48 @@ class UDFSuite extends QueryTest {
assert(ctx.sql("SELECT st
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/7207#discussion_r33842367
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/UDFSuite.scala ---
@@ -82,6 +83,48 @@ class UDFSuite extends QueryTest {
assert(ctx.sql("SELECT st
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/7207#discussion_r33842348
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/UDFSuite.scala ---
@@ -82,6 +83,48 @@ class UDFSuite extends QueryTest {
assert(ctx.sql("SELECT st
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/7203#issuecomment-118247852
Looks good. Just two nitpicks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not hav
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/7203#discussion_r33842250
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/ScalaUDF.scala
---
@@ -24,13 +24,18 @@ import org.apache.spark.sql.types.DataTyp
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/7203#discussion_r3384
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/UDFRegistration.scala ---
@@ -87,6 +87,7 @@ class UDFRegistration private[sql] (sqlContext:
SQLContext) e
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7192#issuecomment-118247030
[Test build #36481 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36481/consoleFull)
for PR 7192 at commit
[`ec3fb10`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7192#issuecomment-118246922
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7207#issuecomment-118246915
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7192#issuecomment-118246916
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7099#issuecomment-118246828
[Test build #36480 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36480/consoleFull)
for PR 7099 at commit
[`072e948`](https://gith
GitHub user spirom opened a pull request:
https://github.com/apache/spark/pull/7207
[SPARK-8810] [SQL] Added several UDF unit tests for Spark SQL
One test for each of the GROUP BY, WHERE and HAVING clauses, and one that
combines all three with an additional UDF in the SELECT.
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/7197#issuecomment-118246365
This looks pretty good to me overall; I left a few small optimization
related comments.
---
If your project is set up for it, you can reply to this email and have you
Github user tarekauel commented on a diff in the pull request:
https://github.com/apache/spark/pull/7035#discussion_r33841943
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/math.scala
---
@@ -521,6 +521,55 @@ case class ShiftRight(left: Expression,
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7099#issuecomment-118246123
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7099#issuecomment-118246087
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/7197#discussion_r33841830
--- Diff:
unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java ---
@@ -201,7 +234,7 @@ public int compare(final UTF8String other) {
@Ov
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/7197#discussion_r33841774
--- Diff:
unsafe/src/test/java/org/apache/spark/unsafe/types/UTF8StringSuite.java ---
@@ -25,21 +25,30 @@
public class UTF8StringSuite {
p
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7203#issuecomment-118244963
[Test build #36479 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36479/consoleFull)
for PR 7203 at commit
[`dce1efd`](https://gith
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/7197#discussion_r33841742
--- Diff:
unsafe/src/test/java/org/apache/spark/unsafe/types/UTF8StringSuite.java ---
@@ -25,21 +25,30 @@
public class UTF8StringSuite {
p
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/7197#discussion_r33841711
--- Diff:
unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java ---
@@ -45,33 +46,29 @@
6, 6, 6, 6};
public static UTF8St
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/7197#discussion_r33841678
--- Diff:
unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java ---
@@ -106,92 +105,126 @@ public int length() {
* @param until the pos
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7203#issuecomment-118244289
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7203#issuecomment-118244168
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/7197#discussion_r33841668
--- Diff:
unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java ---
@@ -106,92 +105,126 @@ public int length() {
* @param until the pos
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7206#issuecomment-118243561
[Test build #36477 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36477/consoleFull)
for PR 7206 at commit
[`3d99c33`](https://gith
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6985#issuecomment-118243500
[Test build #36478 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36478/consoleFull)
for PR 6985 at commit
[`27c9f95`](https://gith
Github user piaozhexiu commented on a diff in the pull request:
https://github.com/apache/spark/pull/7203#discussion_r33841596
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/UDFRegistration.scala ---
@@ -126,7 +126,8 @@ class UDFRegistration private[sql] (sqlContext:
SQLCo
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/7197#discussion_r33841582
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/UnsafeRow.java
---
@@ -263,17 +263,17 @@ public Object get(int i) {
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6985#issuecomment-118242472
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7206#issuecomment-118242425
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7206#issuecomment-118242471
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user rxin opened a pull request:
https://github.com/apache/spark/pull/7206
[SPARK-8809][SQL] Remove ConvertNaNs analyzer rule.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rxin/spark convertnans
Alternatively you can r
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6985#issuecomment-118242437
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/7197#discussion_r33841512
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/UnsafeRow.java
---
@@ -263,17 +263,17 @@ public Object get(int i) {
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/7198#issuecomment-118241572
It would also be fine to conclude that this is not an issue as long as it
only happens for contrived BigDecimal values which can't actually appear in
practice.
---
I
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/7194#issuecomment-118241214
One stubtlety: there can be multiple float / double bitpatterns that are
NaN, so clustered sorting based on the bitpatterns is not always sufficient to
properly implem
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/6938#discussion_r33841411
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/math.scala
---
@@ -526,3 +529,171 @@ case class Logarithm(left: Expression, righ
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/7176#issuecomment-118240852
Alright, I've backed out the ScalaCheck usage and have replied to the
review comments above.
---
If your project is set up for it, you can reply to this email and hav
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/7176#discussion_r33841373
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/RandomDataGenerator.scala ---
@@ -0,0 +1,154 @@
+/*
+ * Licensed to the Apache Software F
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/7176#discussion_r33841371
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/RandomDataGenerator.scala ---
@@ -0,0 +1,154 @@
+/*
+ * Licensed to the Apache Software F
Github user tarekauel commented on a diff in the pull request:
https://github.com/apache/spark/pull/7178#discussion_r33841320
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/math.scala
---
@@ -351,6 +351,104 @@ case class Pow(left: Expression, right
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/6938#discussion_r33841264
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/math.scala
---
@@ -526,3 +529,171 @@ case class Logarithm(left: Expression,
Github user catap commented on a diff in the pull request:
https://github.com/apache/spark/pull/6795#discussion_r33841249
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/SignificantSelector.scala
---
@@ -0,0 +1,127 @@
+/*
+ * Licensed to the Apache Software F
Github user catap commented on a diff in the pull request:
https://github.com/apache/spark/pull/6795#discussion_r33841180
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/SignificantSelector.scala
---
@@ -0,0 +1,127 @@
+/*
+ * Licensed to the Apache Software F
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7035#issuecomment-118239379
[Test build #36476 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36476/consoleFull)
for PR 7035 at commit
[`3e9f5ae`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7035#issuecomment-118238647
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7099#issuecomment-118238737
[Test build #36475 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36475/console)
for PR 7099 at commit
[`509ae36`](https://github.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7035#issuecomment-118238687
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7099#issuecomment-118238745
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7099#issuecomment-118238286
[Test build #36475 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36475/consoleFull)
for PR 7099 at commit
[`509ae36`](https://gith
Github user feynmanliang commented on the pull request:
https://github.com/apache/spark/pull/7166#issuecomment-118238218
I did some [perf
testing](https://gist.github.com/feynmanliang/70d79c23dffc828939ec) and it
shows that distributing the Gaussians does yield a significant improveme
1 - 100 of 1149 matches
Mail list logo
