[GitHub] spark pull request: [SPARK-9316] [SPARKR] Add support for filterin...

2015-08-24 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8394#issuecomment-134471928 [Test build #41517 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41517/consoleFull) for PR 8394 at commit

[GitHub] spark pull request: [SPARK-10195] [SQL] Data sources Filter should...

2015-08-24 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/8403#issuecomment-134471917 Like the `buildScan` in data source, we shoud not expose internal types outside spark sql, but we also need to provide the ability to build efficient data source by

[GitHub] spark pull request: [SPARK-10177] [SQL] fix reading Timestamp in p...

2015-08-24 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/8400#issuecomment-134474246 I feel like Impala and Hive did Julian day conversion in the wrong way at first, but left it as is and made the wrong conversion logic the de facto standard way? I

[GitHub] spark pull request: [SPARK-10048][SPARKR] Support arbitrary nested...

2015-08-24 Thread sun-rui
Github user sun-rui commented on a diff in the pull request: https://github.com/apache/spark/pull/8276#discussion_r37832961 --- Diff: R/pkg/inst/tests/test_Serde.R --- @@ -0,0 +1,67 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +#

[GitHub] spark pull request: [SPARK-10048][SPARKR] Support arbitrary nested...

2015-08-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8276#issuecomment-134476227 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10048][SPARKR] Support arbitrary nested...

2015-08-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8276#issuecomment-134476212 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-9786][Streaming][Kafka] fix backpressur...

2015-08-24 Thread koeninger
GitHub user koeninger opened a pull request: https://github.com/apache/spark/pull/8413 [SPARK-9786][Streaming][Kafka] fix backpressure so it works with defa… …ult maxRatePerPartition setting of 0 You can merge this pull request into a Git repository by running: $ git pull

[GitHub] spark pull request: [SPARK-9818][SQL][WIP]Revert SPARK-6136 to ena...

2015-08-24 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/8101#issuecomment-134487700 Jenkins, test this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-9786][Streaming][Kafka] fix backpressur...

2015-08-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8413#issuecomment-134487728 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-9786][Streaming][Kafka] fix backpressur...

2015-08-24 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8413#issuecomment-134487529 [Test build #41519 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41519/console) for PR 8413 at commit

[GitHub] spark pull request: [SPARK-9786][Streaming][Kafka] fix backpressur...

2015-08-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8413#issuecomment-134487729 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-10081][Core ] Skip re-computing getMiss...

2015-08-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8269#issuecomment-134487148 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-10210] [STREAMING] Filter out non-exist...

2015-08-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8405#issuecomment-134453206 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10137][Streaming]Avoid to restart recei...

2015-08-24 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8340#issuecomment-134453003 [Test build #41502 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41502/console) for PR 8340 at commit

[GitHub] spark pull request: [SPARK-10137][Streaming]Avoid to restart recei...

2015-08-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8340#issuecomment-134453475 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-9730][SQL] Add Full Outer Join support ...

2015-08-24 Thread viirya
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/8383#issuecomment-134454856 retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-9730][SQL] Add Full Outer Join support ...

2015-08-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8383#issuecomment-134455273 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-9730][SQL] Add Full Outer Join support ...

2015-08-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8383#issuecomment-134455290 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10081][Core ] Skip re-computing getMiss...

2015-08-24 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8269#issuecomment-134458607 [Test build #41509 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41509/consoleFull) for PR 8269 at commit

[GitHub] spark pull request: [SPARK-10177] [SQL] fix reading Timestamp in p...

2015-08-24 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/8400#discussion_r37828250 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala --- @@ -37,7 +37,8 @@ object DateTimeUtils { type

[GitHub] spark pull request: [SPARK-10177] [SQL] fix reading Timestamp in p...

2015-08-24 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/8400#discussion_r37828693 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/DateTimeUtilsSuite.scala --- @@ -49,13 +49,18 @@ class DateTimeUtilsSuite extends

[GitHub] spark pull request: [SPARK-10215][SQL][WIP]Div of Decimal returns ...

2015-08-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8409#issuecomment-134462234 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10215][SQL][WIP]Div of Decimal returns ...

2015-08-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8409#issuecomment-13446 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-8167] Make tasks that fail from YARN pr...

2015-08-24 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8007#issuecomment-134462628 [Test build #41511 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41511/consoleFull) for PR 8007 at commit

[GitHub] spark pull request: [SPARK-10215][SQL][WIP]Div of Decimal returns ...

2015-08-24 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8409#issuecomment-134463070 [Test build #41512 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41512/consoleFull) for PR 8409 at commit

[GitHub] spark pull request: [Minor] [Doc] Fix LDA user guide issue

2015-08-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8410#issuecomment-134463005 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [Minor] [Doc] Fix LDA user guide issue

2015-08-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8410#issuecomment-134465275 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [Minor] [Doc] Fix LDA user guide issue

2015-08-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8410#issuecomment-134465272 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [Minor] [Doc] Fix LDA user guide issue

2015-08-24 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8410#issuecomment-134465234 [Test build #41513 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41513/console) for PR 8410 at commit

[GitHub] spark pull request: [SPARK-8552] [THRIFTSERVER] Using incorrect da...

2015-08-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7118#issuecomment-134468448 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-8552] [THRIFTSERVER] Using incorrect da...

2015-08-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7118#issuecomment-134468449 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-8552] [THRIFTSERVER] Using incorrect da...

2015-08-24 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7118#issuecomment-134468382 [Test build #41506 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41506/console) for PR 7118 at commit

[GitHub] spark pull request: [SPARK-10215][SQL][WIP]Div of Decimal returns ...

2015-08-24 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/8409#issuecomment-134472818 what is the datatype of `a`? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-10121] [SQL] Thrift server always use t...

2015-08-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/8368 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-9730][SQL] Add Full Outer Join support ...

2015-08-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8383#issuecomment-134474567 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-9730][SQL] Add Full Outer Join support ...

2015-08-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8383#issuecomment-134474564 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-9730][SQL] Add Full Outer Join support ...

2015-08-24 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8383#issuecomment-134474531 [Test build #41508 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41508/console) for PR 8383 at commit

[GitHub] spark pull request: [SPARK-9316] [SPARKR] Add support for filterin...

2015-08-24 Thread shivaram
Github user shivaram commented on a diff in the pull request: https://github.com/apache/spark/pull/8394#discussion_r37832844 --- Diff: R/pkg/R/DataFrame.R --- @@ -945,6 +947,19 @@ setMethod([, signature(x = DataFrame, i = missing), select(x, j) })

[GitHub] spark pull request: [SPARK-9316] [SPARKR] Add support for filterin...

2015-08-24 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8394#issuecomment-134474719 [Test build #41517 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41517/console) for PR 8394 at commit

[GitHub] spark pull request: [SPARK-10215][SQL][WIP]Div of Decimal returns ...

2015-08-24 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/8409#issuecomment-134474724 ok the type of `a` is `Decimal(38, 18)`. The plan of `df.selectExpr(b * a / b)` is ``` scala df.selectExpr(b * a / b).explain(true) == Parsed Logical Plan ==

[GitHub] spark pull request: [SPARK-9316] [SPARKR] Add support for filterin...

2015-08-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8394#issuecomment-134474762 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-10215][SQL][WIP]Div of Decimal returns ...

2015-08-24 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/8409#issuecomment-134479514 `promote_precision(cast(cast(b#3 as decimal(38,18)) as decimal(38,18)))` looks weird. The precision and scale will be calculated based on `e1 / e2 p1 - s1 +

[GitHub] spark pull request: [SPARK-10215][SQL][WIP]Div of Decimal returns ...

2015-08-24 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/8409#issuecomment-134488372 @yhuai For Add/Sub/Multiply, we should not lose precision (we can't reduce the scale of result, prefer overflow), but for division, we can't keep all the precision under

[GitHub] spark pull request: [SQL][MINOR][Doc] Clarify docs for inferring D...

2015-08-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8406#issuecomment-134455903 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-9730][SQL] Add Full Outer Join support ...

2015-08-24 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8383#issuecomment-134455946 [Test build #41508 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41508/consoleFull) for PR 8383 at commit

[GitHub] spark pull request: [SPARK-9316] [SPARKR] Add support for filterin...

2015-08-24 Thread sun-rui
Github user sun-rui commented on the pull request: https://github.com/apache/spark/pull/8394#issuecomment-134455987 LGTM. some minor comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-9284] [tests] Allow all tests to run wi...

2015-08-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7629#issuecomment-134462736 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-8167] Make tasks that fail from YARN pr...

2015-08-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8007#issuecomment-134462837 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-9284] [tests] Allow all tests to run wi...

2015-08-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7629#issuecomment-134462733 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-9284] [tests] Allow all tests to run wi...

2015-08-24 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7629#issuecomment-134462689 **[Test build #41492 timed out](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41492/console)** for PR 7629 at commit

[GitHub] spark pull request: [Minor] [Doc] Fix LDA user guide issue

2015-08-24 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8410#issuecomment-134463821 [Test build #41513 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41513/consoleFull) for PR 8410 at commit

[GitHub] spark pull request: [SPARK-8167] Make tasks that fail from YARN pr...

2015-08-24 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8007#issuecomment-134464638 [Test build #41514 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41514/consoleFull) for PR 8007 at commit

[GitHub] spark pull request: [SPARK-10177] [SQL] fix reading Timestamp in p...

2015-08-24 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/8400#issuecomment-134467934 Can you explain what they are overlapped means? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-8167] Make tasks that fail from YARN pr...

2015-08-24 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8007#issuecomment-134470198 [Test build #41516 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41516/consoleFull) for PR 8007 at commit

[GitHub] spark pull request: [SPARK-10180] [SQL] JDBCRDD does not process E...

2015-08-24 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/8391#discussion_r37831947 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala --- @@ -275,6 +275,7 @@ private[sql] class JDBCRDD(

[GitHub] spark pull request: [SPARK-9316] [SPARKR] Add support for filterin...

2015-08-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8394#issuecomment-134471696 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-9786][Streaming][Kafka] fix backpressur...

2015-08-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8413#issuecomment-134476773 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-9786][Streaming][Kafka] fix backpressur...

2015-08-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8413#issuecomment-134476762 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10215][SQL][WIP]Div of Decimal returns ...

2015-08-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8409#issuecomment-134479243 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-7685][ML] Apply weights to different sa...

2015-08-24 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7884#issuecomment-134488496 [Test build #41510 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41510/console) for PR 7884 at commit

[GitHub] spark pull request: [SPARK-7685][ML] Apply weights to different sa...

2015-08-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7884#issuecomment-134488582 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-7685][ML] Apply weights to different sa...

2015-08-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7884#issuecomment-134488583 Test PASSed. Refer to this link for build results (access rights to CI server needed):

<    3   4   5   6   7   8