Github user tdas commented on the pull request:
https://github.com/apache/spark/pull/8477#issuecomment-135536394
@harishreedharan @vanzin Could you guys take a look at this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/8484#discussion_r38137716
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateUnsafeProjection.scala
---
@@ -286,21 +264,29 @@ object Genera
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/8483
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/8469#issuecomment-135523908
It works. I will update doc.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/8464#discussion_r38132954
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/local/ProjectNodeSuite.scala
---
@@ -0,0 +1,42 @@
+/*
+* Licensed to the Apache Sof
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/8464#discussion_r38132786
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/local/ProjectNodeSuite.scala
---
@@ -0,0 +1,42 @@
+/*
+* Licensed to the Apache Sof
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/8441
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/8441#issuecomment-135519881
Thanks guys! Merged to master and 1.5
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project d
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/8464#discussion_r38129712
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/local/LimitNode.scala ---
@@ -0,0 +1,45 @@
+/*
+* Licensed to the Apache Software Fo
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/8464#discussion_r38129780
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/local/LimitNode.scala ---
@@ -0,0 +1,45 @@
+/*
+* Licensed to the Apache Software Fo
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8484#issuecomment-135514282
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/8464#discussion_r38129008
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/local/LimitNode.scala ---
@@ -0,0 +1,45 @@
+/*
+* Licensed to the Apache Software Founda
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8441#issuecomment-135514140
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8484#issuecomment-135514096
[Test build #41700 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41700/console)
for PR 8484 at commit
[`451971c`](https://github.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8441#issuecomment-135514142
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8484#issuecomment-135514287
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8441#issuecomment-135513991
[Test build #41704 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41704/console)
for PR 8441 at commit
[`f3fdf62`](https://github.
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/8464#discussion_r38128741
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/local/LimitNode.scala ---
@@ -0,0 +1,45 @@
+/*
+* Licensed to the Apache Software Fo
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8249#issuecomment-135513716
[Test build #41693 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41693/console)
for PR 8249 at commit
[`6dd471f`](https://github.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8249#issuecomment-135513807
Build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does n
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8249#issuecomment-135513810
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/8464#discussion_r38128387
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/local/LimitNode.scala ---
@@ -0,0 +1,45 @@
+/*
+* Licensed to the Apache Software Fo
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/8464#discussion_r38128313
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/local/LocalNodeTest.scala
---
@@ -0,0 +1,189 @@
+/*
+* Licensed to the Apache Softw
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/8464#discussion_r38127948
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/local/UnionNode.scala ---
@@ -0,0 +1,75 @@
+/*
+* Licensed to the Apache Software Fo
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/8464#discussion_r38127111
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/local/LimitNode.scala ---
@@ -0,0 +1,45 @@
+/*
+* Licensed to the Apache Software Fo
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8441#issuecomment-135509928
[Test build #41704 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41704/consoleFull)
for PR 8441 at commit
[`f3fdf62`](https://gith
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/8464#discussion_r38126926
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/local/LimitNode.scala ---
@@ -0,0 +1,45 @@
+/*
+* Licensed to the Apache Software Fo
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/8464#discussion_r38126845
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/local/LimitNode.scala ---
@@ -0,0 +1,45 @@
+/*
+* Licensed to the Apache Software Fo
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/8464#discussion_r38126899
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/local/LimitNode.scala ---
@@ -0,0 +1,45 @@
+/*
+* Licensed to the Apache Software Fo
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/8464#discussion_r38126751
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/local/LocalNodeTest.scala
---
@@ -0,0 +1,189 @@
+/*
+* Licensed to the Apache Softw
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/8441#issuecomment-135508637
thanks LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8441#issuecomment-135508384
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/8441#discussion_r38126088
--- Diff: docs/sql-programming-guide.md ---
@@ -1696,12 +1711,16 @@ version specified by users. An isolated classloader
is used here to avoid depend
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8441#issuecomment-135508406
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/8395
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/8395#issuecomment-135507172
(PS not sure why it doesn't seem to show up, but the tests passed again
after the last commit:
https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1685/
Github user sabhyankar commented on the pull request:
https://github.com/apache/spark/pull/8248#issuecomment-135506704
@mengxr I am going to update PRs #8248 #8247 #8243 #8241 and #8249 after PR
#8241 is merged to trunk. This is needed because we want to use the common
trait (Broadcas
Github user paberline commented on the pull request:
https://github.com/apache/spark/pull/8384#issuecomment-135506108
JIRA: https://issues.apache.org/jira/browse/SPARK-8510
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user paberline-rms commented on the pull request:
https://github.com/apache/spark/pull/8384#issuecomment-135505761
JIRA: https://issues.apache.org/jira/browse/SPARK-8510
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as we
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/8451
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/7884#issuecomment-135503606
I know Xiangrui is using `RDD[(Double, 1.0, Vector)]` in isotonic
regression, so I don't mind as well as long as everyone is on the same page.
---
If your project is set
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8436#issuecomment-135502190
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8436#issuecomment-135502194
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8436#issuecomment-135502050
[Test build #41702 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41702/console)
for PR 8436 at commit
[`074583e`](https://github.
Github user feynmanliang commented on the pull request:
https://github.com/apache/spark/pull/7884#issuecomment-135501418
LGTM, I slightly prefer the `RDD[(Double, 1.0, Vector)]` approach but it's
your call
---
If your project is set up for it, you can reply to this email and have you
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/7884#discussion_r38122528
--- Diff: project/MimaExcludes.scala ---
@@ -60,6 +60,10 @@ object MimaExcludes {
"org.apache.spark.ml.regression.LeastSquaresCostFun.t
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/7884#discussion_r38122369
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -218,31 +217,59 @@ class LogisticRegression(override v
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8451#issuecomment-135498471
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8451#issuecomment-135498467
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8451#issuecomment-135498118
[Test build #41701 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41701/console)
for PR 8451 at commit
[`0695e51`](https://github.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8398#issuecomment-135497162
[Test build #41703 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41703/consoleFull)
for PR 8398 at commit
[`b1d49b3`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8486#issuecomment-135496815
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8486#issuecomment-135496445
[Test build #41690 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41690/console)
for PR 8486 at commit
[`16ae7e2`](https://github.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8486#issuecomment-135496813
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8398#issuecomment-135495581
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8398#issuecomment-135495613
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8337#issuecomment-135495182
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8337#issuecomment-135495177
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8337#issuecomment-135495054
[Test build #41689 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41689/console)
for PR 8337 at commit
[`573a37c`](https://github.
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/8398#issuecomment-135495019
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this f
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8398#issuecomment-135493649
[Test build #41699 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41699/console)
for PR 8398 at commit
[`b1d49b3`](https://github.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8398#issuecomment-135493701
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8398#issuecomment-135493699
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8436#issuecomment-135492754
[Test build #41702 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41702/consoleFull)
for PR 8436 at commit
[`074583e`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8436#issuecomment-135491108
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8436#issuecomment-135491197
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/8377#discussion_r38117742
--- Diff: docs/ml-guide.md ---
@@ -868,6 +868,132 @@ jsc.stop();
+## Example: Model Selection via Train Validation Split
+In add
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/8377#discussion_r38117713
--- Diff: docs/ml-guide.md ---
@@ -868,6 +868,132 @@ jsc.stop();
+## Example: Model Selection via Train Validation Split
+In add
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/8377#discussion_r38117652
--- Diff: docs/ml-guide.md ---
@@ -868,6 +868,132 @@ jsc.stop();
+## Example: Model Selection via Train Validation Split
+In add
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/8377#discussion_r38117589
--- Diff: docs/ml-guide.md ---
@@ -868,6 +868,132 @@ jsc.stop();
+## Example: Model Selection via Train Validation Split
+In add
Github user koertkuipers commented on the pull request:
https://github.com/apache/spark/pull/8416#issuecomment-135488186
I am not sure Union is a good idea at all, since i would have to union
DataFrames for hundreds of partitions and the Union logical operator only takes
left and righ
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8451#issuecomment-135487780
[Test build #41701 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41701/consoleFull)
for PR 8451 at commit
[`0695e51`](https://gith
Github user semad closed the pull request at:
https://github.com/apache/spark/pull/8488
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabl
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8241#issuecomment-135482010
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8451#issuecomment-135487130
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8451#issuecomment-135487161
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user semad opened a pull request:
https://github.com/apache/spark/pull/8488
Test pr
Pull Req 1
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/semad/spark test_pr
Alternatively you can review and apply these changes as the
Github user feynmanliang commented on the pull request:
https://github.com/apache/spark/pull/8451#issuecomment-135486169
Whoops forgot to push the last commit, the Strings and default list size
should be there now
---
If your project is set up for it, you can reply to this email and
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/8487#discussion_r38115481
--- Diff: docs/ml-features.md ---
@@ -211,6 +211,87 @@ for feature in result.select("result").take(3):
+## CountVectorizer
+
+As a
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/8487#discussion_r38115523
--- Diff: docs/ml-features.md ---
@@ -211,6 +211,87 @@ for feature in result.select("result").take(3):
+## CountVectorizer
+
+As a
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8248#issuecomment-135481460
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8243#issuecomment-135480921
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8248#issuecomment-135481244
[Test build #41694 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41694/console)
for PR 8248 at commit
[`98fa159`](https://github.
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/8487#discussion_r38115498
--- Diff: docs/ml-features.md ---
@@ -211,6 +211,87 @@ for feature in result.select("result").take(3):
+## CountVectorizer
+
+As a
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/8471#discussion_r38116507
--- Diff: sql/hive/pom.xml ---
@@ -36,6 +36,12 @@
+
+
+ org.scala-lang
+ scala-library
+ 2.10.3
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/8485#discussion_r38116027
--- Diff: python/pyspark/ml/feature.py ---
@@ -167,6 +167,65 @@ def getSplits(self):
@inherit_doc
+class DCT(JavaTransformer, HasInputCol,
Github user koertkuipers commented on the pull request:
https://github.com/apache/spark/pull/8416#issuecomment-135486744
Can you point me to the jira where that decision was made?
Hadoop globbing only covers a small subset of all use cases. For example
for timeseries analysis
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8243#issuecomment-135480564
[Test build #41696 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41696/console)
for PR 8243 at commit
[`2245df6`](https://github.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8462#issuecomment-135481589
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/8487#discussion_r38115518
--- Diff: docs/ml-features.md ---
@@ -211,6 +211,87 @@ for feature in result.select("result").take(3):
+## CountVectorizer
+
+As a
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/8487#discussion_r38115508
--- Diff: docs/ml-features.md ---
@@ -211,6 +211,87 @@ for feature in result.select("result").take(3):
+## CountVectorizer
+
+As a
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8488#issuecomment-135486060
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/8485#issuecomment-135485931
LGTM except minor inline comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does no
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/8485#discussion_r38116030
--- Diff: python/pyspark/ml/feature.py ---
@@ -167,6 +167,65 @@ def getSplits(self):
@inherit_doc
+class DCT(JavaTransformer, HasInputCol,
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/8487#discussion_r38115521
--- Diff: docs/ml-features.md ---
@@ -211,6 +211,87 @@ for feature in result.select("result").take(3):
+## CountVectorizer
+
+As a
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/8487#discussion_r38115529
--- Diff: docs/ml-features.md ---
@@ -211,6 +211,87 @@ for feature in result.select("result").take(3):
+## CountVectorizer
+
+As a
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/8487#discussion_r38115483
--- Diff: docs/ml-features.md ---
@@ -211,6 +211,87 @@ for feature in result.select("result").take(3):
+## CountVectorizer
+
+As a
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/8487#discussion_r38115492
--- Diff: docs/ml-features.md ---
@@ -211,6 +211,87 @@ for feature in result.select("result").take(3):
+## CountVectorizer
+
+As a
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/8487#discussion_r38115487
--- Diff: docs/ml-features.md ---
@@ -211,6 +211,87 @@ for feature in result.select("result").take(3):
+## CountVectorizer
+
+As a
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/8487#discussion_r38115476
--- Diff: docs/ml-features.md ---
@@ -211,6 +211,87 @@ for feature in result.select("result").take(3):
+## CountVectorizer
+
+As a
301 - 400 of 604 matches
Mail list logo