[GitHub] spark pull request: [SPARK-11184] [MLLIB] Declare most of .mllib c...

2015-10-26 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/9169#issuecomment-151396799 Thanks! On `@Experimental`, I assume it simply means that it is intended for end users (i.e. not a `@DeveloperApi`) but may be removed or changed at any time (without eve

[GitHub] spark pull request: [SPARK-2629][STREAMING] Basic implementation o...

2015-10-26 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/9256#discussion_r43089007 --- Diff: streaming/src/main/scala/org/apache/spark/streaming/TrackStateSpec.scala --- @@ -0,0 +1,111 @@ +/* + * Licensed to the Apache Software Fou

[GitHub] spark pull request: [SPARK-11297] Add new code tags

2015-10-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/9265 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SAPRK-8546] Add PMML export for Naive Bayes

2015-10-26 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/9057#issuecomment-151396091 @yinxusen Could you update the PR title? `SAPRK` is a typo. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] spark pull request: [SPARK-11297] Add new code tags

2015-10-26 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/9265#issuecomment-151396021 LGTM. Merged into master. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-2960][Deploy] Support executing Spark f...

2015-10-26 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/8669#discussion_r43088776 --- Diff: bin/beeline --- @@ -23,8 +23,10 @@ # Enter posix mode for bash set -o posix -# Figure out where Spark is installed -FWDIR="

[GitHub] spark pull request: [SPARK-2629][STREAMING] Basic implementation o...

2015-10-26 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/9256#discussion_r43088697 --- Diff: streaming/src/main/scala/org/apache/spark/streaming/State.scala --- @@ -0,0 +1,138 @@ +/* + * Licensed to the Apache Software Foundation (

[GitHub] spark pull request: [SPARK-2960][Deploy] Support executing Spark f...

2015-10-26 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/8669#discussion_r43088465 --- Diff: bin/beeline --- @@ -23,8 +23,10 @@ # Enter posix mode for bash set -o posix -# Figure out where Spark is installed -FWDIR="$(c

[GitHub] spark pull request: [SPARK-2629][STREAMING] Basic implementation o...

2015-10-26 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/9256#discussion_r43088193 --- Diff: streaming/src/main/scala/org/apache/spark/streaming/State.scala --- @@ -0,0 +1,138 @@ +/* + * Licensed to the Apache Software Foundation (

[GitHub] spark pull request: [SPARK-2960][Deploy] Support executing Spark f...

2015-10-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8669#issuecomment-151393309 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44

[GitHub] spark pull request: [SPARK-2960][Deploy] Support executing Spark f...

2015-10-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8669#issuecomment-151393307 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-2960][Deploy] Support executing Spark f...

2015-10-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8669#issuecomment-151393236 **[Test build #44400 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44400/consoleFull)** for PR 8669 at commit [`c796397`](https://git

[GitHub] spark pull request: [SPARK-10484][SQL] Optimize the cartesian join...

2015-10-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8652#issuecomment-151391381 **[Test build #44410 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44410/consoleFull)** for PR 8652 at commit [`7fda511`](https://gith

[GitHub] spark pull request: [SPARK-10484][SQL] Optimize the cartesian join...

2015-10-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8652#issuecomment-151389719 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-10484][SQL] Optimize the cartesian join...

2015-10-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8652#issuecomment-151389533 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-11334] numRunningTasks can't be less th...

2015-10-26 Thread jerryshao
Github user jerryshao commented on the pull request: https://github.com/apache/spark/pull/9288#issuecomment-151385860 IMHO, would it be better to fix this unexpected ordering of events, from my understanding, `SparkListenerTaskEnd` should be triggered before `SparkListenerStageComplet

[GitHub] spark pull request: [SPARK-11225]Prevent generate empty file

2015-10-26 Thread viper-kun
Github user viper-kun commented on the pull request: https://github.com/apache/spark/pull/9191#issuecomment-151385025 @JoshRosen Is it ok? If it doesn't work, I will close this pr. --- If your project is set up for it, you can reply to this email and have your reply appear o

[GitHub] spark pull request: [SPARK-11340][SPARKR] Support setting driver p...

2015-10-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9290#issuecomment-151383876 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-11340][SPARKR] Support setting driver p...

2015-10-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9290#issuecomment-151383877 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44

[GitHub] spark pull request: [SPARK-11340][SPARKR] Support setting driver p...

2015-10-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9290#issuecomment-151383814 **[Test build #44409 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44409/consoleFull)** for PR 9290 at commit [`5ecc9e0`](https://git

[GitHub] spark pull request: [SPARK-11340][SPARKR] Support setting driver p...

2015-10-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9290#issuecomment-151382025 **[Test build #44409 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44409/consoleFull)** for PR 9290 at commit [`5ecc9e0`](https://gith

[GitHub] spark pull request: [SPARK-11210][SPARKR] Add window functions int...

2015-10-26 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/spark/pull/9196#issuecomment-151381136 looks good! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featu

[GitHub] spark pull request: [SPARK-11340][SPARKR] Support setting driver p...

2015-10-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9290#issuecomment-151381066 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-11340][SPARKR] Support setting driver p...

2015-10-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9290#issuecomment-151381067 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44

[GitHub] spark pull request: [SPARK-11340][SPARKR] Support setting driver p...

2015-10-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9290#issuecomment-151380796 **[Test build #44405 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44405/consoleFull)** for PR 9290 at commit [`d3f8d28`](https://git

[GitHub] spark pull request: [SPARK-11340][SPARKR] Support setting driver p...

2015-10-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9290#issuecomment-151379993 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-11340][SPARKR] Support setting driver p...

2015-10-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9290#issuecomment-151380063 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-11210][SPARKR] Add window functions int...

2015-10-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9196#issuecomment-151379732 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-11210][SPARKR] Add window functions int...

2015-10-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9196#issuecomment-151379733 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44

[GitHub] spark pull request: [SPARK-11210][SPARKR] Add window functions int...

2015-10-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9196#issuecomment-151379670 **[Test build #44404 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44404/consoleFull)** for PR 9196 at commit [`2e84e2d`](https://git

[GitHub] spark pull request: [SPARK-9319][SPARKR] Add support for setting c...

2015-10-26 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/spark/pull/9218#issuecomment-151379530 @sun-rui That's a great point, `coltypes()` as its signature is defined, would only return a list of simple types. But how would one create a DataFrame with compl

[GitHub] spark pull request: [SPARK-11297] Add new code tags

2015-10-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9265#issuecomment-151379573 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-11297] Add new code tags

2015-10-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9265#issuecomment-151379574 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44

[GitHub] spark pull request: [SPARK-11297] Add new code tags

2015-10-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9265#issuecomment-151379513 **[Test build #44406 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44406/consoleFull)** for PR 9265 at commit [`7352bc4`](https://git

[GitHub] spark pull request: [SPARK-11341][SQL] Given non-zero ordinal toRo...

2015-10-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9292#issuecomment-151379305 **[Test build #44407 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44407/consoleFull)** for PR 9292 at commit [`0506fa7`](https://gith

[GitHub] spark pull request: [SPARK-11340][SPARKR] Support setting driver p...

2015-10-26 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/spark/pull/9290#issuecomment-151378899 I checked, the user could also set SPARK_DRIVER_MEMORY before running `sparkR.init()` https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/

[GitHub] spark pull request: [SPARK-11334] numRunningTasks can't be less th...

2015-10-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9288#issuecomment-151378713 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44

[GitHub] spark pull request: [SPARK-2960][Deploy] Support executing Spark f...

2015-10-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8669#issuecomment-151378760 **[Test build #44408 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44408/consoleFull)** for PR 8669 at commit [`41511b4`](https://gith

[GitHub] spark pull request: [SPARK-11334] numRunningTasks can't be less th...

2015-10-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9288#issuecomment-151378709 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-11334] numRunningTasks can't be less th...

2015-10-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9288#issuecomment-151378473 **[Test build #44397 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44397/consoleFull)** for PR 9288 at commit [`e32e684`](https://git

[GitHub] spark pull request: [SPARK-11341][SQL] Given non-zero ordinal toRo...

2015-10-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9292#issuecomment-151378248 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-11341][SQL] Given non-zero ordinal toRo...

2015-10-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9292#issuecomment-151378260 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-2960][Deploy] Support executing Spark f...

2015-10-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8669#issuecomment-151378254 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-11340][SPARKR] Support setting driver p...

2015-10-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9290#issuecomment-151378199 **[Test build #44405 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44405/consoleFull)** for PR 9290 at commit [`d3f8d28`](https://gith

[GitHub] spark pull request: [SPARK-2960][Deploy] Support executing Spark f...

2015-10-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8669#issuecomment-151378261 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-11338][WebUI] Prepend app links on Hist...

2015-10-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9291#issuecomment-151378251 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pr

[GitHub] spark pull request: [SPARK-11341][SQL] Given non-zero ordinal toRo...

2015-10-26 Thread viirya
GitHub user viirya opened a pull request: https://github.com/apache/spark/pull/9292 [SPARK-11341][SQL] Given non-zero ordinal toRow in the encoders of primitive types will cause problem JIRA: https://issues.apache.org/jira/browse/SPARK-11341 The toRow in LongEncoder, IntEnc

[GitHub] spark pull request: [SPARK-11341][SQL] Given non-zero ordinal toRo...

2015-10-26 Thread viirya
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/9292#issuecomment-151378144 ping @marmbrus --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-11297] Add new code tags

2015-10-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9265#issuecomment-151378091 **[Test build #44406 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44406/consoleFull)** for PR 9265 at commit [`7352bc4`](https://gith

[GitHub] spark pull request: [SPARK-2960][Deploy] Support executing Spark f...

2015-10-26 Thread jerryshao
Github user jerryshao commented on the pull request: https://github.com/apache/spark/pull/8669#issuecomment-151377956 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-11338][WebUI] Prepend app links on Hist...

2015-10-26 Thread ckadner
GitHub user ckadner opened a pull request: https://github.com/apache/spark/pull/9291 [SPARK-11338][WebUI] Prepend app links on HistoryPage with uiRoot path - `HistoryPage.scala` ...prepending all page links with the web proxy (`uiRoot`) path - `HistoryServerSuite.scala` ...addin

[GitHub] spark pull request: [SPARK-11210][SPARKR] Add window functions int...

2015-10-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9196#issuecomment-151377883 **[Test build #44404 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44404/consoleFull)** for PR 9196 at commit [`2e84e2d`](https://gith

[GitHub] spark pull request: [SPARK-8029][core][wip] first successful shuff...

2015-10-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9214#issuecomment-151377803 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44

[GitHub] spark pull request: [SPARK-8029][core][wip] first successful shuff...

2015-10-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9214#issuecomment-151377802 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-8029][core][wip] first successful shuff...

2015-10-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9214#issuecomment-151377734 **[Test build #44399 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44399/consoleFull)** for PR 9214 at commit [`4b7c71a`](https://git

[GitHub] spark pull request: [SPARK-11297] Add new code tags

2015-10-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9265#issuecomment-151377428 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-11340][SPARKR] Support setting driver p...

2015-10-26 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/spark/pull/9290#issuecomment-151377437 Manual testing with: ``` library(SparkR, lib.loc='/opt/spark-1.6.0-bin-hadoop2.6/R/lib') sc <- sparkR.init(master = "local[*]", sparkEnvir = list(spa

[GitHub] spark pull request: [SPARK-11340][SPARKR] Support setting driver p...

2015-10-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9290#issuecomment-151377429 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-11340][SPARKR] Support setting driver p...

2015-10-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9290#issuecomment-151377420 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-11297] Add new code tags

2015-10-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9265#issuecomment-151377421 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-11340][SPARKR] Support setting driver p...

2015-10-26 Thread felixcheung
GitHub user felixcheung opened a pull request: https://github.com/apache/spark/pull/9290 [SPARK-11340][SPARKR] Support setting driver properties when starting Spark from R programmatically or from RStudio Mapping spark.driver.memory from sparkEnvir to spark-submit commandline argum

[GitHub] spark pull request: [SPARK-11210][SPARKR] Add window functions int...

2015-10-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9196#issuecomment-151377012 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-11210][SPARKR] Add window functions int...

2015-10-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9196#issuecomment-151377023 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-11210][SPARKR][WIP] Add window function...

2015-10-26 Thread sun-rui
Github user sun-rui commented on the pull request: https://github.com/apache/spark/pull/9196#issuecomment-151376631 Rebased to master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

[GitHub] spark pull request: [SPARK-11297] Add new code tags

2015-10-26 Thread yinxusen
Github user yinxusen commented on the pull request: https://github.com/apache/spark/pull/9265#issuecomment-151376585 @mengxr The simplest way to change the view is adding a css font constrain: ```css div .highlight pre { font-size: 12px; } ``` It cont

[GitHub] spark pull request: [SPARK-10654][MLlib] Add columnSimilarities to...

2015-10-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/8792 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-10654][MLlib] Add columnSimilarities to...

2015-10-26 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/8792#issuecomment-151376315 LGTM. Merged into master. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10286][ML][PySpark][Docs] Add @since an...

2015-10-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9275#issuecomment-151376263 **[Test build #44403 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44403/consoleFull)** for PR 9275 at commit [`ccdc82e`](https://git

[GitHub] spark pull request: [SPARK-10286][ML][PySpark][Docs] Add @since an...

2015-10-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9275#issuecomment-151376285 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44

[GitHub] spark pull request: [SPARK-10286][ML][PySpark][Docs] Add @since an...

2015-10-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9275#issuecomment-151376284 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-10263] [ML] Add @Since annotation to ml...

2015-10-26 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/8935#issuecomment-151376098 @hiross Sorry for my slow response! Please check the public API instead of line changes. The former is more accurate. The PR has merge conflicts with the master branch. C

[GitHub] spark pull request: [SPARK-10263] [ML] Add @Since annotation to ml...

2015-10-26 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/8935#discussion_r43084418 --- Diff: mllib/src/main/scala/org/apache/spark/ml/Pipeline.scala --- @@ -82,8 +82,11 @@ abstract class PipelineStage extends Params with Logging { * an

[GitHub] spark pull request: [SPARK-10263] [ML] Add @Since annotation to ml...

2015-10-26 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/8935#discussion_r43084419 --- Diff: mllib/src/main/scala/org/apache/spark/ml/Pipeline.scala --- @@ -82,8 +82,11 @@ abstract class PipelineStage extends Params with Logging { * an

[GitHub] spark pull request: [SPARK-10263] [ML] Add @Since annotation to ml...

2015-10-26 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/8935#discussion_r43084417 --- Diff: mllib/src/main/scala/org/apache/spark/ml/Pipeline.scala --- @@ -82,8 +82,11 @@ abstract class PipelineStage extends Params with Logging { * an

[GitHub] spark pull request: [SPARK-8542][MLlib]PMML export for Decision Tr...

2015-10-26 Thread yinxusen
Github user yinxusen commented on the pull request: https://github.com/apache/spark/pull/7842#issuecomment-151375671 @mengxr Sure I'll reivew it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[GitHub] spark pull request: [SAPRK-8546] Add PMML export for Naive Bayes

2015-10-26 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/9057#discussion_r43084336 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/classification/NaiveBayes.scala --- @@ -19,6 +19,8 @@ package org.apache.spark.mllib.classification

[GitHub] spark pull request: [SPARK-10286][ML][PySpark][Docs] Add @since an...

2015-10-26 Thread lidinghao
Github user lidinghao commented on the pull request: https://github.com/apache/spark/pull/9275#issuecomment-151375697 @mengxr Ok, I will add the versionadded --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SAPRK-8546] Add PMML export for Naive Bayes

2015-10-26 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/9057#discussion_r43084342 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/pmml/export/NaiveBayesPMMLModelExport.scala --- @@ -0,0 +1,93 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [SAPRK-8546] Add PMML export for Naive Bayes

2015-10-26 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/9057#issuecomment-151375621 @JasmineGeorge Could you make a pass? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-8542][MLlib]PMML export for Decision Tr...

2015-10-26 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/7842#issuecomment-151375567 @JasmineGeorge Sorry for late response! We are running out of code review bandwidth. How about you and @yinxusen helping review each other's PR? His PR is at https://gith

[GitHub] spark pull request: [SPARK-11209][SPARKR] Add window functions int...

2015-10-26 Thread sun-rui
Github user sun-rui commented on the pull request: https://github.com/apache/spark/pull/9193#issuecomment-151375443 @shivaram, for your suggestion that "we should a make a list of functions that we mask and are incompatible", I submitted https://issues.apache.org/jira/browse/SPARK-113

[GitHub] spark pull request: [SPARK-11184] [MLLIB] Declare most of .mllib c...

2015-10-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/9169 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-11184] [MLLIB] Declare most of .mllib c...

2015-10-26 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/9169#issuecomment-151375298 Merged into master. Thanks! We can keep the discussion running:) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: [SPARK-11184] [MLLIB] Declare most of .mllib c...

2015-10-26 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/9169#issuecomment-151374915 This looks good to me. Btw, we haven't yet discussed the exact semantic of `@Experimental`. I think we haven't made any break changes on `@Experimental` APIs without depr

[GitHub] spark pull request: [SPARK-10286][ML][PySpark][Docs] Add @since an...

2015-10-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9275#issuecomment-151374525 **[Test build #44403 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44403/consoleFull)** for PR 9275 at commit [`ccdc82e`](https://gith

[GitHub] spark pull request: SPARK-11295 Add packages to JUnit output for P...

2015-10-26 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/9263#discussion_r43083874 --- Diff: python/pyspark/mllib/tests.py --- @@ -76,7 +76,8 @@ pass ser = PickleSerializer() -sc = SparkContext('local[4]', "MLlib tests"

[GitHub] spark pull request: [SPARK-10286][ML][PySpark][Docs] Add @since an...

2015-10-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9275#issuecomment-151372540 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-10286][ML][PySpark][Docs] Add @since an...

2015-10-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9275#issuecomment-151372561 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-10286][ML][PySpark][Docs] Add @since an...

2015-10-26 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/9275#issuecomment-151372367 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enab

[GitHub] spark pull request: [SPARK-10286][ML][PySpark][Docs] Add @since an...

2015-10-26 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/9275#issuecomment-151372364 @lidinghao Thanks for working on this! For classes, could you also add `versionadded`? You can find an example here: https://github.com/apache/spark/blob/f85aa06464a10f5d

[GitHub] spark pull request: [SPARK-10024] [pyspark] Python API RF and GBT ...

2015-10-26 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/9233#issuecomment-151372045 @vectorijk Could you add the since versions back? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-10271][Pyspark][MLLib] Added @since tag...

2015-10-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/8627 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-10271][Pyspark][MLLib] Added @since tag...

2015-10-26 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/8627#issuecomment-151371862 Merged into master. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-11322][PySpark] Keep full stack trace i...

2015-10-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9283#issuecomment-151371826 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-11322][PySpark] Keep full stack trace i...

2015-10-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9283#issuecomment-151371829 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44

[GitHub] spark pull request: [SPARK-11322][PySpark] Keep full stack trace i...

2015-10-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9283#issuecomment-151371791 **[Test build #44402 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44402/consoleFull)** for PR 9283 at commit [`8f69480`](https://git

[GitHub] spark pull request: [SPARK-11284] [ML] ALS produces float predicti...

2015-10-26 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/9252#issuecomment-151371779 @dahlem If you plan to make a new pull request, could you close this PR manually? We don't have direct access to close Spark PRs. Thanks! --- If your project is set up f

[GitHub] spark pull request: [SPARK-11289][DOC] Substitute code examples in...

2015-10-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/9266 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-10562][SQL] support mixed case partitio...

2015-10-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/9226 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-11277] [SQL] sort_array throws exceptio...

2015-10-26 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/9247#issuecomment-151370701 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

  1   2   3   4   5   6   7   >