[GitHub] spark pull request: [SPARK-11863][SQL][WIP] Unable to resolve orde...

2015-11-23 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/9844#issuecomment-159188818 retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-11863][SQL][WIP] Unable to resolve orde...

2015-11-23 Thread dilipbiswal
Github user dilipbiswal commented on the pull request: https://github.com/apache/spark/pull/9844#issuecomment-159188789 @cloud-fan can you please help trigger a retest ? Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as w

[GitHub] spark pull request: [SPARK-11140] [core] Transfer files using netw...

2015-11-23 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/9530#issuecomment-159187716 The following two tests have failed for the past three builds in the Hadoop 2.4 Maven Jenkins job: - org.apache.spark.deploy.yarn.YarnClusterSuite.run Spark in

[GitHub] spark pull request: [SPARK-11863][SQL][WIP] Unable to resolve orde...

2015-11-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9844#issuecomment-159187034 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4

[GitHub] spark pull request: [SPARK-11863][SQL][WIP] Unable to resolve orde...

2015-11-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9844#issuecomment-159186937 **[Test build #46588 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46588/consoleFull)** for PR 9844 at commit [`cbf14ff`](https://gith

[GitHub] spark pull request: [SPARK-11863][SQL][WIP] Unable to resolve orde...

2015-11-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9844#issuecomment-159187032 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: SPARK-5106 - Add refresh checkbox on the UI

2015-11-23 Thread jbonofre
Github user jbonofre commented on the pull request: https://github.com/apache/spark/pull/9860#issuecomment-159183472 I can add a text field to let users configure the refresh interval if you want. --- If your project is set up for it, you can reply to this email and have your reply a

[GitHub] spark pull request: SPARK-5106 - Add refresh checkbox on the UI

2015-11-23 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/9860#issuecomment-159182921 I worry that this opens a can of UI / UX worms for very little net benefit to users. For instance, a common complaint with the Jenkins auto-refresh is that the delay i

[GitHub] spark pull request: [SPARK-11897][SQL] Add @scala.annotations.vara...

2015-11-23 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/9918#discussion_r45703494 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala --- @@ -689,6 +689,7 @@ object functions extends LegacyFunctions { * @group no

[GitHub] spark pull request: [SPARK-11942][SQL] fix encoder life cycle for ...

2015-11-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9928#issuecomment-159182159 **[Test build #46586 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46586/consoleFull)** for PR 9928 at commit [`c1022fc`](https://gith

[GitHub] spark pull request: [SPARK-11856][SQL] add type cast if the real t...

2015-11-23 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/9840#issuecomment-159181742 It's blocked by https://github.com/apache/spark/pull/9928 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as wel

[GitHub] spark pull request: [SPARK-11942][SQL] fix encoder life cycle for ...

2015-11-23 Thread cloud-fan
GitHub user cloud-fan opened a pull request: https://github.com/apache/spark/pull/9928 [SPARK-11942][SQL] fix encoder life cycle for CoGroup we should pass in resolved encodera to logical `CoGroup` and bind them in physical `CoGroup` You can merge this pull request into a Git repos

[GitHub] spark pull request: [SPARK-11863][SQL][WIP] Unable to resolve orde...

2015-11-23 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/9844#discussion_r45702258 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -661,7 +666,9 @@ class Analyzer( val eval

[GitHub] spark pull request: SPARK-5106 - Add refresh checkbox on the UI

2015-11-23 Thread jbonofre
Github user jbonofre commented on the pull request: https://github.com/apache/spark/pull/9860#issuecomment-159172833 Rebase and back on the checkbox (instead of the button). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] spark pull request: SPARK-5106 - Add refresh checkbox on the UI

2015-11-23 Thread jbonofre
Github user jbonofre commented on the pull request: https://github.com/apache/spark/pull/9860#issuecomment-159172624 So, what do we do about this ? First, let me go back to the checkbox (probably better IMHO in term of UI). @JoshRosen I agree that using pushed async update (usin

[GitHub] spark pull request: [SPARK-11847] [ML] Model export/import for spa...

2015-11-23 Thread hhbyyh
Github user hhbyyh commented on the pull request: https://github.com/apache/spark/pull/9894#issuecomment-159171948 @jkbradley removed. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-11863][SQL][WIP] Unable to resolve orde...

2015-11-23 Thread dilipbiswal
Github user dilipbiswal commented on a diff in the pull request: https://github.com/apache/spark/pull/9844#discussion_r45701500 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -661,7 +666,9 @@ class Analyzer( val ev

[GitHub] spark pull request: [SPARK-11934] [SQL] Adding joinType into joinW...

2015-11-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9921#issuecomment-159171315 **[Test build #46585 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46585/consoleFull)** for PR 9921 at commit [`980b153`](https://gith

[GitHub] spark pull request: [SPARK-11934] [SQL] Adding joinType into joinW...

2015-11-23 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/9921#discussion_r45701047 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala --- @@ -412,7 +418,7 @@ class DatasetSuite extends QueryTest with SharedSQLConte

[GitHub] spark pull request: [WIP] [SPARK-11847] [ML] Model export/import f...

2015-11-23 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/9894#issuecomment-159170379 LGTM. @hhbyyh Thanks for the updates! Is there anything left to do? If not, can you please remove the "WIP" label? I can then merge it. --- If your project is set

[GitHub] spark pull request: [SPARK-10707] [SQL] Fix nullability computatio...

2015-11-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/9308 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-11521] [ML] [DOC] Document that Logisti...

2015-11-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9927#issuecomment-159168803 **[Test build #46584 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46584/consoleFull)** for PR 9927 at commit [`c0b8d27`](https://gith

[GitHub] spark pull request: [SPARK-11934] [SQL] Adding joinType into joinW...

2015-11-23 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/9921#discussion_r45700482 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala --- @@ -412,7 +418,7 @@ class DatasetSuite extends QueryTest with SharedSQLContex

[GitHub] spark pull request: [SPARK-10707] [SQL] Fix nullability computatio...

2015-11-23 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/9308#issuecomment-159167719 I'm going to merge this. The style thing is good to have, but probably doesn't worth another roundtrip. --- If your project is set up for it, you can reply to this email

[GitHub] spark pull request: [SPARK-11863][SQL][WIP] Unable to resolve orde...

2015-11-23 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/9844#discussion_r45700402 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -661,7 +666,9 @@ class Analyzer( val eval

[GitHub] spark pull request: [SPARK-11903] Remove --skip-java-test

2015-11-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/9924 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-11933][SQL] Rename mapGroup -> mapGroup...

2015-11-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/9919 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-11903] Remove --skip-java-test

2015-11-23 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/9924#issuecomment-159165834 I've merged this. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have thi

[GitHub] spark pull request: [SPARK-11863][SQL][WIP] Unable to resolve orde...

2015-11-23 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/9844#discussion_r45700102 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -610,9 +610,9 @@ class Analyzer( */ objec

[GitHub] spark pull request: [WIP] [SPARK-11847] [ML] Model export/import f...

2015-11-23 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/9894#issuecomment-159164089 > Do you mean a LDAModel.load(path) which can load both local and distributed LDAModel? We can create a jira. Yes, that's what I had in mind. That way, most u

[GitHub] spark pull request: [SPARK-11933][SQL] Rename mapGroup -> mapGroup...

2015-11-23 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/9919#issuecomment-159164011 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark pull request: [SPARK-11934] [SQL] Adding joinType into joinW...

2015-11-23 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/9921#discussion_r45699959 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala --- @@ -412,7 +418,7 @@ class DatasetSuite extends QueryTest with SharedSQLConte

[GitHub] spark pull request: [SPARK-11521] [ML] [DOC] Document that Logisti...

2015-11-23 Thread jkbradley
GitHub user jkbradley opened a pull request: https://github.com/apache/spark/pull/9927 [SPARK-11521] [ML] [DOC] Document that Logistic, Linear Regression summaries ignore weight col Doc for 1.6 that the summaries mostly ignore the weight column. To be corrected for 1.7

[GitHub] spark pull request: [SPARK-11856][SQL] add type cast if the real t...

2015-11-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9840#issuecomment-159163316 **[Test build #46583 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46583/consoleFull)** for PR 9840 at commit [`7c56223`](https://gith

[GitHub] spark pull request: [SPARK-11934] [SQL] Adding joinType into joinW...

2015-11-23 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/9921#discussion_r45699792 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala --- @@ -412,7 +418,7 @@ class DatasetSuite extends QueryTest with SharedSQLContex

[GitHub] spark pull request: [SPARK-10707] [SQL] Fix nullability computatio...

2015-11-23 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/9308#issuecomment-159159471 LGTM except a minor code style comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-10707] [SQL] Fix nullability computatio...

2015-11-23 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/9308#discussion_r45699604 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala --- @@ -1997,4 +1997,35 @@ class SQLQuerySuite extends QueryTest with SharedSQLC

[GitHub] spark pull request: [SPARK-11933][SQL] Rename mapGroup -> mapGroup...

2015-11-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9919#issuecomment-159158329 **[Test build #2099 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2099/consoleFull)** for PR 9919 at commit [`27aee92`](https://gi

[GitHub] spark pull request: SPARK-5106 - Add refresh checkbox on the UI

2015-11-23 Thread jbonofre
Github user jbonofre commented on the pull request: https://github.com/apache/spark/pull/9860#issuecomment-159157786 I "mimic" what we have on Jenkins for instance. I understand your points guys. I just thought it's a convenient feature for users ;) --- If your project is set up for

[GitHub] spark pull request: [SPARK-11805] free the array in UnsafeExternal...

2015-11-23 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/9793#discussion_r45699105 --- Diff: core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeExternalSorter.java --- @@ -489,10 +495,6 @@ public void loadNext() throws

[GitHub] spark pull request: [SPARK-11805] free the array in UnsafeExternal...

2015-11-23 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/9793#discussion_r45698964 --- Diff: core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeExternalSorter.java --- @@ -489,10 +495,6 @@ public void loadNext() throws

[GitHub] spark pull request: [SPARK-11805] free the array in UnsafeExternal...

2015-11-23 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/9793#discussion_r45698452 --- Diff: core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeExternalSorter.java --- @@ -489,10 +495,6 @@ public void loadNext() throws IOE

[GitHub] spark pull request: [SPARK-11866] [network] [core] Make sure timed...

2015-11-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9917#issuecomment-159151618 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-11866] [network] [core] Make sure timed...

2015-11-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9917#issuecomment-159151619 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4

[GitHub] spark pull request: [SPARK-11866] [network] [core] Make sure timed...

2015-11-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9917#issuecomment-159151566 **[Test build #46582 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46582/consoleFull)** for PR 9917 at commit [`b00f4f0`](https://git

[GitHub] spark pull request: [SPARK-9104][SPARK-9105][SPARK-9106][SPARK-910...

2015-11-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7753#issuecomment-159150999 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4

[GitHub] spark pull request: [SPARK-9104][SPARK-9105][SPARK-9106][SPARK-910...

2015-11-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7753#issuecomment-159150997 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-9104][SPARK-9105][SPARK-9106][SPARK-910...

2015-11-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7753#issuecomment-159150934 **[Test build #46576 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46576/consoleFull)** for PR 7753 at commit [`b438077`](https://git

[GitHub] spark pull request: [SPARK-7041] Avoid writing empty files in Bypa...

2015-11-23 Thread JoshRosen
Github user JoshRosen closed the pull request at: https://github.com/apache/spark/pull/5622 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e

[GitHub] spark pull request: [SPARK-7041] Avoid writing empty files in Bypa...

2015-11-23 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/5622#issuecomment-159149102 If anything, this seemed to make thing slower. Closing for now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark pull request: [SPARK-11903] Remove --skip-java-test

2015-11-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9924#issuecomment-159147862 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4

[GitHub] spark pull request: [SPARK-11903] Remove --skip-java-test

2015-11-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9924#issuecomment-159147861 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-11903] Remove --skip-java-test

2015-11-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9924#issuecomment-159147801 **[Test build #46579 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46579/consoleFull)** for PR 9924 at commit [`edf44c1`](https://git

[GitHub] spark pull request: [SPARK-11926][SQL] unify GetStructField and Ge...

2015-11-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9909#issuecomment-159145911 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4

[GitHub] spark pull request: [SPARK-11926][SQL] unify GetStructField and Ge...

2015-11-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9909#issuecomment-159145910 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-11926][SQL] unify GetStructField and Ge...

2015-11-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9909#issuecomment-159145840 **[Test build #46577 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46577/consoleFull)** for PR 9909 at commit [`9d12eb1`](https://git

[GitHub] spark pull request: [SPARK-7041] Avoid writing empty files in Bypa...

2015-11-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5622#issuecomment-159145523 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-7041] Avoid writing empty files in Bypa...

2015-11-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5622#issuecomment-159145524 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4

[GitHub] spark pull request: [SPARK-7041] Avoid writing empty files in Bypa...

2015-11-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5622#issuecomment-159145470 **[Test build #46571 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46571/consoleFull)** for PR 5622 at commit [`5fdfcda`](https://git

[GitHub] spark pull request: [SPARK-11778][SQL]:add regression test

2015-11-23 Thread huaxingao
Github user huaxingao commented on the pull request: https://github.com/apache/spark/pull/9890#issuecomment-159143868 I couldn't figure out why the tests failed, but it doesn't seem to me that my new test suite caused the failure. Is it OK to have a retest? Thanks a lot!! ---

[GitHub] spark pull request: Updated sql programming guide to include jdbc ...

2015-11-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/9377 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: Updated sql programming guide to include jdbc ...

2015-11-23 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/9377#issuecomment-159143174 Thanks - going to merge this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-3533][Core] Add saveAsTextFileByKey() m...

2015-11-23 Thread saurfang
Github user saurfang commented on the pull request: https://github.com/apache/spark/pull/8375#issuecomment-159143064 I myself definitely want to get this merged. That being said, this will require a spark committer to drive the process. If you feel strongly about this feature, voice y

[GitHub] spark pull request: [WIP] [SPARK-11847] [ML] Model export/import f...

2015-11-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9894#issuecomment-159142590 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4

[GitHub] spark pull request: [WIP] [SPARK-11847] [ML] Model export/import f...

2015-11-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9894#issuecomment-159142586 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-11926][SQL] unify GetStructField and Ge...

2015-11-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9909#issuecomment-159142541 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4

[GitHub] spark pull request: [SPARK-11926][SQL] unify GetStructField and Ge...

2015-11-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9909#issuecomment-159142538 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [WIP] [SPARK-11847] [ML] Model export/import f...

2015-11-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9894#issuecomment-159142495 **[Test build #46581 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46581/consoleFull)** for PR 9894 at commit [`44c8193`](https://git

[GitHub] spark pull request: [SPARK-11926][SQL] unify GetStructField and Ge...

2015-11-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9909#issuecomment-159142441 **[Test build #46572 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46572/consoleFull)** for PR 9909 at commit [`19907cf`](https://git

[GitHub] spark pull request: [SPARK-11897][SQL] Add @scala.annotations.vara...

2015-11-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9918#issuecomment-159141995 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4

[GitHub] spark pull request: [SPARK-11897][SQL] Add @scala.annotations.vara...

2015-11-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9918#issuecomment-159141994 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-7499][SPARKR][WIP] Investigate how to s...

2015-11-23 Thread sun-rui
Github user sun-rui commented on the pull request: https://github.com/apache/spark/pull/9835#issuecomment-159141992 I realize that this takes more effort than I expected as we'd better support specifying columns without $ for all DataFrame methods that take any argument of "Column" ty

[GitHub] spark pull request: [SPARK-11897][SQL] Add @scala.annotations.vara...

2015-11-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9918#issuecomment-159141891 **[Test build #46575 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46575/consoleFull)** for PR 9918 at commit [`1519b65`](https://git

[GitHub] spark pull request: [SPARK-6157][CORE] Unrolling with MEMORY_AND_D...

2015-11-23 Thread suyanNone
Github user suyanNone commented on the pull request: https://github.com/apache/spark/pull/4887#issuecomment-159140817 @andrewor14 I have the impression that cogroup will hold tow RDD's iterator, If the first iterator is `MEMORY_ONLY`, and unroll failed, so the iterator is based

[GitHub] spark pull request: [SPARK-11933][SQL] Rename mapGroup -> mapGroup...

2015-11-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9919#issuecomment-159140321 **[Test build #2099 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2099/consoleFull)** for PR 9919 at commit [`27aee92`](https://git

[GitHub] spark pull request: [SPARK-11805] free the array in UnsafeExternal...

2015-11-23 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/9793#discussion_r45693587 --- Diff: core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeExternalSorter.java --- @@ -489,10 +495,6 @@ public void loadNext() throws

[GitHub] spark pull request: [SPARK-11439][ML] Optimization of creating spa...

2015-11-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9756#issuecomment-159139870 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4

[GitHub] spark pull request: [SPARK-11439][ML] Optimization of creating spa...

2015-11-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9756#issuecomment-159139868 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-11439][ML] Optimization of creating spa...

2015-11-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9756#issuecomment-159139789 **[Test build #46578 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46578/consoleFull)** for PR 9756 at commit [`aa8fef1`](https://git

[GitHub] spark pull request: [SPARK-11866] [network] [core] Make sure timed...

2015-11-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9917#issuecomment-159139381 **[Test build #46582 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46582/consoleFull)** for PR 9917 at commit [`b00f4f0`](https://gith

[GitHub] spark pull request: [SPARK-11863][SQL][WIP] Unable to resolve orde...

2015-11-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9844#issuecomment-159139215 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4

[GitHub] spark pull request: [SPARK-11863][SQL][WIP] Unable to resolve orde...

2015-11-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9844#issuecomment-159139182 **[Test build #46580 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46580/consoleFull)** for PR 9844 at commit [`d319524`](https://git

[GitHub] spark pull request: [SPARK-11863][SQL][WIP] Unable to resolve orde...

2015-11-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9844#issuecomment-159139214 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-11933][SQL] Rename mapGroup -> mapGroup...

2015-11-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9919#issuecomment-159138907 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-10558][Core] Fix wrong executor state i...

2015-11-23 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/8714#discussion_r45693106 --- Diff: core/src/main/scala/org/apache/spark/deploy/master/Master.scala --- @@ -702,8 +712,6 @@ private[deploy] class Master( worker.addExecutor(

[GitHub] spark pull request: [SPARK-11933][SQL] Rename mapGroup -> mapGroup...

2015-11-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9919#issuecomment-159138911 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4

[GitHub] spark pull request: [SPARK-11933][SQL] Rename mapGroup -> mapGroup...

2015-11-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9919#issuecomment-159138835 **[Test build #46560 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46560/consoleFull)** for PR 9919 at commit [`27aee92`](https://git

[GitHub] spark pull request: [SPARK-11866] [network] [core] Make sure timed...

2015-11-23 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/9917#issuecomment-159137841 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

[GitHub] spark pull request: [SPARK-10558][Core] Fix wrong executor state i...

2015-11-23 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/8714#issuecomment-159137863 @jerryshao this change looks pretty good. I think I have a good understanding of the problem. The behavior before this patch was: 1. Master launches an execut

[GitHub] spark pull request: [WIP] [SPARK-11847] [ML] Model export/import f...

2015-11-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9894#issuecomment-159137662 **[Test build #46581 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46581/consoleFull)** for PR 9894 at commit [`44c8193`](https://gith

[GitHub] spark pull request: [SPARK-10558][Core] Fix wrong executor state i...

2015-11-23 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/8714#discussion_r45692382 --- Diff: core/src/main/scala/org/apache/spark/deploy/master/Master.scala --- @@ -702,8 +712,6 @@ private[deploy] class Master( worker.addExecutor

[GitHub] spark pull request: [SPARK-10558][Core] Fix wrong executor state i...

2015-11-23 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/8714#discussion_r45692237 --- Diff: core/src/main/scala/org/apache/spark/deploy/client/AppClient.scala --- @@ -178,9 +178,6 @@ private[spark] class AppClient( val fullI

[GitHub] spark pull request: [WIP] [SPARK-11847] [ML] Model export/import f...

2015-11-23 Thread hhbyyh
Github user hhbyyh commented on the pull request: https://github.com/apache/spark/pull/9894#issuecomment-159136664 @jkbradley Thanks for review. Do you mean a LDAModel.load(path) which can load both local and distributed LDAModel? We can create a jira. --- If your project is

[GitHub] spark pull request: [SPARK-11863][SQL][WIP] Unable to resolve orde...

2015-11-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9844#issuecomment-159136027 **[Test build #46580 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46580/consoleFull)** for PR 9844 at commit [`d319524`](https://gith

[GitHub] spark pull request: [SPARK-10558][Core] Fix wrong executor state i...

2015-11-23 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/8714#discussion_r45691730 --- Diff: core/src/main/scala/org/apache/spark/deploy/master/Master.scala --- @@ -702,8 +712,6 @@ private[deploy] class Master( worker.addExecutor(

[GitHub] spark pull request: [SPARK-11863][SQL][WIP] Unable to resolve orde...

2015-11-23 Thread dilipbiswal
Github user dilipbiswal commented on a diff in the pull request: https://github.com/apache/spark/pull/9844#discussion_r45691681 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -661,7 +666,9 @@ class Analyzer( val ev

[GitHub] spark pull request: [SPARK-10558][Core] Fix wrong executor state i...

2015-11-23 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/8714#discussion_r45691536 --- Diff: core/src/main/scala/org/apache/spark/deploy/master/Master.scala --- @@ -702,8 +712,6 @@ private[deploy] class Master( worker.addExecutor

[GitHub] spark pull request: [SPARK-11856][SQL] add type cast if the real t...

2015-11-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9840#issuecomment-159134875 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4

[GitHub] spark pull request: [SPARK-11856][SQL] add type cast if the real t...

2015-11-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9840#issuecomment-159134874 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-11903] Remove --skip-java-test

2015-11-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9924#issuecomment-159134861 **[Test build #46579 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46579/consoleFull)** for PR 9924 at commit [`edf44c1`](https://gith

  1   2   3   4   5   6   >