[GitHub] spark pull request: [SPARK-12288] [SQL] Support UnsafeRow in Coale...

2015-12-14 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/10285#issuecomment-164592993 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-11827] [SQL] Adding java.math.BigIntege...

2015-12-14 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/10125#issuecomment-164599822 ok to test @yhuai --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-10797] RDD's coalesce should not write ...

2015-12-14 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/8979#issuecomment-164599666 @ehnalis have you done some benchmarking on how much time this actually saves us? --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark pull request: [SPARK-12288] [SQL] Support UnsafeRow in Coale...

2015-12-14 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/10285#discussion_r47580612 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/RowFormatConvertersSuite.scala --- @@ -58,6 +58,48 @@ class RowFormatConvertersSuite

[GitHub] spark pull request: [SPARK-12009][Yarn]Avoid to re-allocating yarn...

2015-12-14 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/9992#issuecomment-164603661 This looks fine, but just so I understand, why is this problem specific to YARN? --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark pull request: [SPARK-12009][Yarn]Avoid to re-allocating yarn...

2015-12-14 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/9992#issuecomment-164603686 @suyanNone can you rebase to master? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-11735] [SQL] Add a check in the constru...

2015-12-14 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/9702#issuecomment-164604869 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-10248] [core] track exceptions in dagsc...

2015-12-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8466#issuecomment-164604904 **[Test build #47684 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47684/consoleFull)** for PR 8466 at commit

[GitHub] spark pull request: [SPARK-8641][SQL] Native Spark Window function...

2015-12-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9819#issuecomment-164604963 **[Test build #47685 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47685/consoleFull)** for PR 9819 at commit

[GitHub] spark pull request: [SPARK-12218] [SQL] Fixed the Parquet's filter...

2015-12-14 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/10278#issuecomment-164604885 @liancheng can you look at this? Seems pretty serious if we are returning wrong answers. /cc @yhuai --- If your project is set up for it, you can reply to

[GitHub] spark pull request: [SPARK-4117] [YARN] Spark on Yarn handle AM be...

2015-12-14 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/10129#discussion_r47576092 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala --- @@ -372,7 +372,14 @@ private[spark] class ApplicationMaster(

[GitHub] spark pull request: [SPARK-4117] [YARN] Spark on Yarn handle AM be...

2015-12-14 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/10129#discussion_r47576032 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala --- @@ -372,7 +372,14 @@ private[spark] class ApplicationMaster(

[GitHub] spark pull request: [SPARK-4117] [YARN] Spark on Yarn handle AM be...

2015-12-14 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/10129#discussion_r47576063 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala --- @@ -372,7 +372,14 @@ private[spark] class ApplicationMaster(

[GitHub] spark pull request: [RFC] Add type-safe config keys to SparkConf.

2015-12-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10205#issuecomment-164593946 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-4117] [YARN] Spark on Yarn handle AM be...

2015-12-14 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/10129#discussion_r47576221 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala --- @@ -372,7 +372,14 @@ private[spark] class ApplicationMaster(

[GitHub] spark pull request: [RFC] Add type-safe config keys to SparkConf.

2015-12-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10205#issuecomment-164593804 **[Test build #47679 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47679/consoleFull)** for PR 10205 at commit

[GitHub] spark pull request: [RFC] Add type-safe config keys to SparkConf.

2015-12-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10205#issuecomment-164593948 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-11962] Added getAsOpt functions to Row ...

2015-12-14 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/10247#discussion_r47579246 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/Row.scala --- @@ -316,6 +317,21 @@ trait Row extends Serializable { } /**

[GitHub] spark pull request: [SPARK-12220][Core]Make Utils.fetchFile suppor...

2015-12-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10208#issuecomment-164601032 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12327] Disable commented code lintr tem...

2015-12-14 Thread shivaram
Github user shivaram commented on the pull request: https://github.com/apache/spark/pull/10300#issuecomment-164601039 Merging this in master and branch-1.6 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-12220][Core]Make Utils.fetchFile suppor...

2015-12-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10208#issuecomment-164601031 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11962] Added getAsOpt functions to Row ...

2015-12-14 Thread aa8y
Github user aa8y commented on a diff in the pull request: https://github.com/apache/spark/pull/10247#discussion_r47579991 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/Row.scala --- @@ -325,6 +341,14 @@ trait Row extends Serializable { def getAs[T](i: Int): T =

[GitHub] spark pull request: [SPARK-12220][Core]Make Utils.fetchFile suppor...

2015-12-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10208#issuecomment-164600933 **[Test build #47683 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47683/consoleFull)** for PR 10208 at commit

[GitHub] spark pull request: [SPARK-10911] Executors should System.exit on ...

2015-12-14 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/9946#issuecomment-164602831 I agree with @srowen. Just ending the executor can pose regressions in behavior that are difficult to debug. If the concern is that executor processes are undying,

[GitHub] spark pull request: [SPARK-12329][SQL]Fix code in ClientWrapper wh...

2015-12-14 Thread ashwinshankar77
GitHub user ashwinshankar77 opened a pull request: https://github.com/apache/spark/pull/10302 [SPARK-12329][SQL]Fix code in ClientWrapper which prints to stdout instead of stderr When I run "$spark-sql -f ", I see that few "SET key value" messages get printed on stdout instead of

[GitHub] spark pull request: [SPARK-12271][SQL] Improve error message when ...

2015-12-14 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/10260#discussion_r47584025 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/encoders/ExpressionEncoder.scala --- @@ -251,6 +251,25 @@ case class

[GitHub] spark pull request: [SPARK-12323][SQL] Makes BoundReference respec...

2015-12-14 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/10296#issuecomment-164609840 For nested fields, how about improving the `GetStructField`? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark pull request: [SPARK-12329][SQL]Fix code in ClientWrapper wh...

2015-12-14 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/10302#issuecomment-164612409 Why should they to go stderr? They are the results of a command you ran, not some side message. --- If your project is set up for it, you can reply to this email

[GitHub] spark pull request: [SPARK-5682][Core] Add encrypted shuffle in sp...

2015-12-14 Thread winningsix
Github user winningsix commented on the pull request: https://github.com/apache/spark/pull/8880#issuecomment-164617083 @vanzin, I have updated the patch addressing your comments. The following changes are included: * Mock the ```SparkEnv``` instead of instantiating a

[GitHub] spark pull request: [SPARK-11735] [SQL] Add a check in the constru...

2015-12-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9702#issuecomment-164625136 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11735] [SQL] Add a check in the constru...

2015-12-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9702#issuecomment-164625138 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12288] [SQL] Support UnsafeRow in Coale...

2015-12-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10285#issuecomment-164628471 **[Test build #47698 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47698/consoleFull)** for PR 10285 at commit

[GitHub] spark pull request: [SPARK-12288] [SQL] Support UnsafeRow in Coale...

2015-12-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10285#issuecomment-164628549 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12288] [SQL] Support UnsafeRow in Coale...

2015-12-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10285#issuecomment-164628551 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-11515][ML] QuantileDiscretizer should t...

2015-12-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9535#issuecomment-164627088 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-10149] [CORE] [WIP] Locality Level is a...

2015-12-14 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/8533#issuecomment-164628668 @wulei-bj-cn I'm not sure if I understand how your patch fixes the problem. What format does `HadoopRDD` expect? I looked at its `getPreferredLocations` method and

[GitHub] spark pull request: [SPARK-12130] Replace shuffleManagerClass with...

2015-12-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10131#issuecomment-164631404 **[Test build #47710 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47710/consoleFull)** for PR 10131 at commit

[GitHub] spark pull request: [SPARK-12318][SPARKR] Save mode in SparkR shou...

2015-12-14 Thread zjffdu
Github user zjffdu commented on the pull request: https://github.com/apache/spark/pull/10290#issuecomment-164631324 Make sense, will do. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-12327] Disable commented code lintr tem...

2015-12-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10300#issuecomment-164600530 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12327] Disable commented code lintr tem...

2015-12-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10300#issuecomment-164600528 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11962] Added getAsOpt functions to Row ...

2015-12-14 Thread aa8y
Github user aa8y commented on the pull request: https://github.com/apache/spark/pull/10247#issuecomment-164600717 @marmbrus I agree. I wasn't a fan of `getAsOpt` but couldn't think of a better name then. I've updated them all to `getOption`. So does this look better now? --- If

[GitHub] spark pull request: [SPARK-11962] Added getAsOpt functions to Row ...

2015-12-14 Thread aa8y
Github user aa8y commented on the pull request: https://github.com/apache/spark/pull/10247#issuecomment-164604835 Isn't the whole point of `Option` to not throw exceptions? Actually it's to not return `null`s I guess. But throwing an exception would defeat the purpose of returning an

[GitHub] spark pull request: [SPARK-12231][SQL]create a combineFilters' pro...

2015-12-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10299#issuecomment-164604715 **[Test build #47690 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47690/consoleFull)** for PR 10299 at commit

[GitHub] spark pull request: [SPARK-12328][Core]Add connectionEstablished c...

2015-12-14 Thread zsxwing
GitHub user zsxwing opened a pull request: https://github.com/apache/spark/pull/10301 [SPARK-12328][Core]Add connectionEstablished callback to RpcHandler to monitor the new connections Added `connectionEstablished` to `RpcHandler` so that `NettyRpcHandler` doesn't need `clients`

[GitHub] spark pull request: [SPARK-11962] Added getAsOpt functions to Row ...

2015-12-14 Thread aa8y
Github user aa8y commented on the pull request: https://github.com/apache/spark/pull/10247#issuecomment-164605606 What would you propose as a solution instead? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12164] [SQL] Decode the encoded values ...

2015-12-14 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/10215#issuecomment-164605837 Can you add tests too? Probably in `DataFrameSuite`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] spark pull request: [SPARK-12164] [SQL] Decode the encoded values ...

2015-12-14 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/10215#discussion_r47582589 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/Queryable.scala --- @@ -42,4 +43,67 @@ private[sql] trait Queryable { def

[GitHub] spark pull request: [WIP] [SPARK-11327] [MESOS] Dispatcher does no...

2015-12-14 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/9752#issuecomment-164606612 @jayv have you had the chance to work on this patch? If not, shall one of us take it over? --- If your project is set up for it, you can reply to this email and

[GitHub] spark pull request: [SPARK-11515][ML] QuantileDiscretizer should t...

2015-12-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9535#issuecomment-164606455 **[Test build #47692 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47692/consoleFull)** for PR 9535 at commit

[GitHub] spark pull request: [SPARK-12320][SQL] throw exception if the numb...

2015-12-14 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/10293#discussion_r47583120 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/AttributeMap.scala --- @@ -26,13 +26,6 @@ object AttributeMap { def

[GitHub] spark pull request: [SPARK-12274][SQL] WrapOption should not have ...

2015-12-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/10263 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-10158] [PySpark] [MLlib] ALS better err...

2015-12-14 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/9361#issuecomment-164608133 retest this please. This looks like an OK change. Any comments @mengxr @jkbradley? --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark pull request: [SPARK-9057] [STREAMING] Twitter example joini...

2015-12-14 Thread Agent007
Github user Agent007 commented on the pull request: https://github.com/apache/spark/pull/8431#issuecomment-164608934 @srowen Any idea why this didn't merge cleanly? I didn't see anything wrong from the Jenkins output. And, I just tried a local merge to my local copy of master and saw

[GitHub] spark pull request: [SPARK-12231][SQL]create a combineFilters' pro...

2015-12-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10299#issuecomment-164608983 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12288] [SQL] Support UnsafeRow in Coale...

2015-12-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10285#issuecomment-164608995 **[Test build #47687 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47687/consoleFull)** for PR 10285 at commit

[GitHub] spark pull request: [SPARK-12231][SQL]create a combineFilters' pro...

2015-12-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10299#issuecomment-164608828 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12231][SQL]create a combineFilters' pro...

2015-12-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10299#issuecomment-164608982 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12231][SQL]create a combineFilters' pro...

2015-12-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10299#issuecomment-164608928 **[Test build #47691 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47691/consoleFull)** for PR 10299 at commit

[GitHub] spark pull request: [SPARK-12231][SQL]create a combineFilters' pro...

2015-12-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10299#issuecomment-164608826 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12164] [SQL] Decode the encoded values ...

2015-12-14 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/10215#issuecomment-164610895 Sure, will do. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-12164] [SQL] Decode the encoded values ...

2015-12-14 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/10215#discussion_r47585295 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/Queryable.scala --- @@ -42,4 +43,67 @@ private[sql] trait Queryable { def

[GitHub] spark pull request: [SPARK-12288] [SQL] Support UnsafeRow in Coale...

2015-12-14 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/10285#discussion_r47585423 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/RowFormatConvertersSuite.scala --- @@ -58,6 +58,48 @@ class RowFormatConvertersSuite

[GitHub] spark pull request: [SPARK-12164] [SQL] Decode the encoded values ...

2015-12-14 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/10215#discussion_r47586646 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -225,7 +225,41 @@ class Dataset[T] private[sql]( * * @since

[GitHub] spark pull request: [SPARK-5682][Core] Add encrypted shuffle in sp...

2015-12-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8880#issuecomment-164613467 **[Test build #47702 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47702/consoleFull)** for PR 8880 at commit

[GitHub] spark pull request: [SPARK-5210] Support group event log when app ...

2015-12-14 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/9246#issuecomment-164613295 @XuTingjun I think this is something good to fix. I've noticed that uncompressed event logs can amount up to 15GB for a 5 minute application. However, I think a lot

[GitHub] spark pull request: [SPARK-5210] Support group event log when app ...

2015-12-14 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/9246#issuecomment-164613472 By the way, since this patch has been opened many months ago it's now mostly stale. If you plan to work on this, would you mind closing this patch and re-opening one

[GitHub] spark pull request: [SPARK-12204][SPARKR] Implement drop method fo...

2015-12-14 Thread sun-rui
Github user sun-rui commented on the pull request: https://github.com/apache/spark/pull/10201#issuecomment-164613571 @felixcheung, refine the wording: ``` Prior to 1.4, DataFrame.withColumn() supports adding a column only. The column will always be added as a new column with

[GitHub] spark pull request: [SPARK-11408][SQL] display scientific notation...

2015-12-14 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/9376#issuecomment-164613643 @marmbrus @yhuai --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-5682][Core] Add encrypted shuffle in sp...

2015-12-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8880#issuecomment-164617376 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-11354] [Web UI] Expose custom log4j fil...

2015-12-14 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/9321#issuecomment-164617399 @yongjiaw I believe the changes here actually have security implications. Previously the viewers could only read `stderr` and `stdout` files on the executor

[GitHub] spark pull request: [SPARK-10291] [PySpark] statsByKey method for ...

2015-12-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8539#issuecomment-164617335 **[Test build #47706 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47706/consoleFull)** for PR 8539 at commit

[GitHub] spark pull request: [SPARK-11354] [Web UI] Expose custom log4j fil...

2015-12-14 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/9321#issuecomment-164617416 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-5682][Core] Add encrypted shuffle in sp...

2015-12-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8880#issuecomment-164617375 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12164] [SQL] Display the binary/encoded...

2015-12-14 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/10165#issuecomment-164626233 Sure, will do it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-12329][SQL]Fix code in ClientWrapper wh...

2015-12-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10302#issuecomment-164626414 **[Test build #47700 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47700/consoleFull)** for PR 10302 at commit

[GitHub] spark pull request: [SPARK-12329][SQL]Fix code in ClientWrapper wh...

2015-12-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10302#issuecomment-164626528 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-11515][ML] QuantileDiscretizer should t...

2015-12-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9535#issuecomment-164626729 **[Test build #47692 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47692/consoleFull)** for PR 9535 at commit

[GitHub] spark pull request: [SPARK-11515][ML] QuantileDiscretizer should t...

2015-12-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9535#issuecomment-164627091 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12269][Streaming][Kinesis] Update aws-j...

2015-12-14 Thread holdenk
Github user holdenk commented on a diff in the pull request: https://github.com/apache/spark/pull/10256#discussion_r47591545 --- Diff: pom.xml --- @@ -169,7 +169,7 @@ ${scala.version} org.scala-lang 1.9.13 -2.4.4 +2.5.3 --- End diff --

[GitHub] spark pull request: [SPARK-12288] [SQL] Support UnsafeRow in Coale...

2015-12-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10285#issuecomment-164594077 **[Test build #47687 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47687/consoleFull)** for PR 10285 at commit

[GitHub] spark pull request: [SPARK-12327] Disable commented code lintr tem...

2015-12-14 Thread shivaram
GitHub user shivaram opened a pull request: https://github.com/apache/spark/pull/10300 [SPARK-12327] Disable commented code lintr temporarily cc @yhuai @felixcheung @shaneknapp You can merge this pull request into a Git repository by running: $ git pull

[GitHub] spark pull request: [SPARK-11962] Added getAsOpt functions to Row ...

2015-12-14 Thread aa8y
Github user aa8y commented on the pull request: https://github.com/apache/spark/pull/10247#issuecomment-164594278 @jodersky: I incorporated your recommendations and also updated my branch with the current master. Can you or one of the admins please ask Jenkins to test this build.

[GitHub] spark pull request: [SPARK-11962] Added getAsOpt functions to Row ...

2015-12-14 Thread jodersky
Github user jodersky commented on the pull request: https://github.com/apache/spark/pull/10247#issuecomment-164596063 Great! Unfortunately I can't help with the tests though. Check out this

[GitHub] spark pull request: [SPARK-12321][SQL] JSON format for logical/phy...

2015-12-14 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/10295#discussion_r47577408 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/QueryPlan.scala --- @@ -170,4 +174,27 @@ abstract class QueryPlan[PlanType <:

[GitHub] spark pull request: SPARK-11406: Patch for a utf-8 decode issue th...

2015-12-14 Thread boneill42
Github user boneill42 commented on the pull request: https://github.com/apache/spark/pull/9360#issuecomment-164599070 Yep, closed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-11827] [SQL] Adding java.math.BigIntege...

2015-12-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10125#issuecomment-164600862 **[Test build #47689 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47689/consoleFull)** for PR 10125 at commit

[GitHub] spark pull request: [SPARK-12143]When cloumn type is binary, chang...

2015-12-14 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/10139#issuecomment-164600765 @yhuai --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-7727] [SQL] Avoid inner classes in Rule...

2015-12-14 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/10174#discussion_r47581375 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/DefaultOptimizerExtendableSuite.scala --- @@ -0,0 +1,45 @@ +/* + * Licensed to

[GitHub] spark pull request: [SPARK-12231][SQL]create a combineFilters' pro...

2015-12-14 Thread kevinyu98
Github user kevinyu98 commented on the pull request: https://github.com/apache/spark/pull/10299#issuecomment-164603371 Hello Michael: I fixed the scala style issue, can you help re-run the test? Thanks. --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark pull request: [SPARK-7727] [SQL] Avoid inner classes in Rule...

2015-12-14 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/10174#discussion_r47581335 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/DefaultOptimizerExtendableSuite.scala --- @@ -0,0 +1,45 @@ +/* + * Licensed to

[GitHub] spark pull request: [SPARK-10157] [ec2] Add ability to specify s3 ...

2015-12-14 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/8359#issuecomment-164605603 @mdagost we can't close this PR on our side. Can you click the `Close` button on your side? Thanks. --- If your project is set up for it, you can reply to this

[GitHub] spark pull request: [SPARK-11962] Added getAsOpt functions to Row ...

2015-12-14 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/10247#issuecomment-164605446 I think the point of `Option` is typesafe null handling, not hiding structural problems with your code (i.e. using the wrong type for a column). If this fails then

[GitHub] spark pull request: [SPARK-11460][Core] Increase locality level wh...

2015-12-14 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/9433#issuecomment-164607503 @kayousterhout --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-5682][Core] Add encrypted shuffle in sp...

2015-12-14 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/8880#discussion_r47583585 --- Diff: yarn/src/test/scala/org/apache/spark/deploy/yarn/YarnShuffleEncryptionSuite.scala --- @@ -0,0 +1,289 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [SPARK-7874][MESOS] Don’t allocate more than...

2015-12-14 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/9027#issuecomment-164607585 @dragos can you fix the style here? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-12318][SPARKR] Save mode in SparkR shou...

2015-12-14 Thread zjffdu
Github user zjffdu commented on a diff in the pull request: https://github.com/apache/spark/pull/10290#discussion_r47583609 --- Diff: R/pkg/R/DataFrame.R --- @@ -1903,7 +1903,7 @@ setMethod("except", #' } --- End diff -- @felixcheung Is it necessary to do that ?

[GitHub] spark pull request: [SPARK-12324][MLLIB][DOC] Fixes the sidebar in...

2015-12-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10297#issuecomment-164607406 **[Test build #2215 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2215/consoleFull)** for PR 10297 at commit

[GitHub] spark pull request: [SPARK-10157] [ec2] Add ability to specify s3 ...

2015-12-14 Thread mdagost
Github user mdagost closed the pull request at: https://github.com/apache/spark/pull/8359 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-9516][UI] Improvement of Thread Dump Pa...

2015-12-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7910#issuecomment-164612316 **[Test build #47699 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47699/consoleFull)** for PR 7910 at commit

[GitHub] spark pull request: [SPARK-12288] [SQL] Support UnsafeRow in Coale...

2015-12-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10285#issuecomment-164612191 **[Test build #47698 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47698/consoleFull)** for PR 10285 at commit

  1   2   3   4   5   6   7   >