[GitHub] spark pull request: [SPARK-12224][SPARKR] R support for JDBC sourc...

2015-12-27 Thread sun-rui
Github user sun-rui commented on a diff in the pull request: https://github.com/apache/spark/pull/10480#discussion_r48466540 --- Diff: R/pkg/R/DataFrame.R --- @@ -2272,3 +2260,40 @@ setMethod("with", newEnv <- assignNewEnv(data)

[GitHub] spark pull request: [SPARK-12224][SPARKR] R support for JDBC sourc...

2015-12-27 Thread sun-rui
Github user sun-rui commented on a diff in the pull request: https://github.com/apache/spark/pull/10480#discussion_r48466513 --- Diff: core/src/main/scala/org/apache/spark/api/r/SerDe.scala --- @@ -355,6 +355,13 @@ private[spark] object SerDe { writeInt(dos,

[GitHub] spark pull request: [SPARK-12224][SPARKR] R support for JDBC sourc...

2015-12-27 Thread sun-rui
Github user sun-rui commented on a diff in the pull request: https://github.com/apache/spark/pull/10480#discussion_r48466526 --- Diff: R/pkg/R/generics.R --- @@ -537,6 +537,12 @@ setGeneric("write.df", function(df, path, ...) { standardGeneric("write.df") }) #' @export

[GitHub] spark pull request: [SPARK-12530][Build] Fix build break at Spark-...

2015-12-27 Thread hvanhovell
Github user hvanhovell commented on the pull request: https://github.com/apache/spark/pull/10488#issuecomment-167506758 More people are having this problem. Lets use raw strings then. --- If your project is set up for it, you can reply to this email and have your reply appear on

<    1   2