[GitHub] spark pull request: [SPARK-12536] [SQL] Added "Empty Seq" in Expla...

2015-12-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10494#issuecomment-167515530 **[Test build #48361 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48361/consoleFull)** for PR 10494 at commit

[GitHub] spark pull request: [SPARK-12353][Streaming][PySpark] Fix countByV...

2015-12-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/10350 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: we should have training and test sets

2015-12-28 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/10434#issuecomment-167540865 OK, either way. I was suggesting that it's fine to make this example consistent with the others, even if test/train isn't the point of this example. if you do proceed,

[GitHub] spark pull request: [SPARK-12353][Streaming][PySpark] Fix countByV...

2015-12-28 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/10350#issuecomment-167540772 Merged to master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-8641][SPARK-12455][SQL] Native Spark Wi...

2015-12-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10402#issuecomment-167542344 **[Test build #48363 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48363/consoleFull)** for PR 10402 at commit

[GitHub] spark pull request: [SPARK-8641][SPARK-12455][SQL] Native Spark Wi...

2015-12-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10402#issuecomment-167542409 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-8641][SPARK-12455][SQL] Native Spark Wi...

2015-12-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10402#issuecomment-167542410 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12530][Build] Fix build break at Spark-...

2015-12-28 Thread vectorijk
Github user vectorijk commented on a diff in the pull request: https://github.com/apache/spark/pull/10488#discussion_r48475242 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/misc.scala --- @@ -57,9 +57,10 @@ case class Md5(child: Expression)

[GitHub] spark pull request: [SPARK-2750][WEB UI] Add https support to the ...

2015-12-28 Thread WangTaoTheTonic
Github user WangTaoTheTonic commented on the pull request: https://github.com/apache/spark/pull/10238#issuecomment-167507929 Sorry for late. Think you need update codes to the newest and see if the test cases fine. Then we do some review and function tests. --- If your project

[GitHub] spark pull request: [SPARK-12536][SQL]Added "Empty Seq" in Explain...

2015-12-28 Thread gatorsmile
GitHub user gatorsmile opened a pull request: https://github.com/apache/spark/pull/10494 [SPARK-12536][SQL]Added "Empty Seq" in Explain Outputs For Empty LocalRelation and LocalTableScan The filter `Filter (False)` generates an empty `LocalRelation` in `SimplifyFilters`. In the

[GitHub] spark pull request: [SPARK-12515][SQL][DOC] minor doc update for r...

2015-12-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/10465 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-12424][ML] The implementation of ParamM...

2015-12-28 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/10381#discussion_r48472333 --- Diff: mllib/src/test/scala/org/apache/spark/ml/param/ParamsSuite.scala --- @@ -349,6 +352,41 @@ class ParamsSuite extends SparkFunSuite { val t3

[GitHub] spark pull request: [SPARK-12530][Build] Fix build break at Spark-...

2015-12-28 Thread hvanhovell
Github user hvanhovell commented on the pull request: https://github.com/apache/spark/pull/10488#issuecomment-167540178 @yhuai can you take a look at this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [Spark-12260][wip][Streaming]Graceful Shutdown...

2015-12-28 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/10252#issuecomment-167541007 Before reviewing this further, let's return to the JIRA. I do not see that this implements something that you a) can't do with updateStateByKey or trackStateByKey, or

[GitHub] spark pull request: [SPARK-12424][ML] The implementation of ParamM...

2015-12-28 Thread sarutak
Github user sarutak commented on a diff in the pull request: https://github.com/apache/spark/pull/10381#discussion_r48473237 --- Diff: mllib/src/test/scala/org/apache/spark/ml/param/ParamsSuite.scala --- @@ -349,6 +352,41 @@ class ParamsSuite extends SparkFunSuite { val

[GitHub] spark pull request: [SPARK-12224][SPARKR] R support for JDBC sourc...

2015-12-28 Thread sun-rui
Github user sun-rui commented on a diff in the pull request: https://github.com/apache/spark/pull/10480#discussion_r48467198 --- Diff: R/pkg/R/DataFrame.R --- @@ -2272,3 +2260,40 @@ setMethod("with", newEnv <- assignNewEnv(data)

[GitHub] spark pull request: Add more exceptions to Guava relocation

2015-12-28 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/10442#discussion_r48467535 --- Diff: pom.xml --- @@ -99,14 +99,14 @@ sql/hive unsafe assembly -external/twitter -external/flume -

[GitHub] spark pull request: [SPARK-12515][SQL][DOC] minor doc update for r...

2015-12-28 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/10465#issuecomment-167538830 Merged to master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-12224][SPARKR] R support for JDBC sourc...

2015-12-28 Thread sun-rui
Github user sun-rui commented on a diff in the pull request: https://github.com/apache/spark/pull/10480#discussion_r48472220 --- Diff: R/pkg/R/SQLContext.R --- @@ -556,3 +556,61 @@ createExternalTable <- function(sqlContext, tableName, path = NULL, source = NUL sdf <-

[GitHub] spark pull request: [SPARK-12424][ML] The implementation of ParamM...

2015-12-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10381#issuecomment-167544609 **[Test build #48364 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48364/consoleFull)** for PR 10381 at commit

[GitHub] spark pull request: [SPARK-12537] [SQL] Add option to accept quoti...

2015-12-28 Thread Cazen
Github user Cazen closed the pull request at: https://github.com/apache/spark/pull/10496 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-12439][SQL] Fix toCatalystArray and Map...

2015-12-28 Thread viirya
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/10391#issuecomment-167585649 @cloud-fan Can you also review the updates? Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: [SPARK-3369] [CORE] [STREAMING] Java mapPartit...

2015-12-28 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/10413#issuecomment-167564115 @rxin I wanted to sound you out on this one -- do you feel strongly against it or are the reasons above a little persuasive? --- If your project is set up for it, you

[GitHub] spark pull request: [SPARK-12537] [SQL] Add option to accept quoti...

2015-12-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10496#issuecomment-167566226 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12537] [SQL] Add option to accept quoti...

2015-12-28 Thread Cazen
GitHub user Cazen opened a pull request: https://github.com/apache/spark/pull/10497 [SPARK-12537] [SQL] Add option to accept quoting of all character backslash quoting mechanism We can provides the option to choose JSON parser can be enabled to accept quoting of all character or

[GitHub] spark pull request: [SPARK-12537] [SQL] Add option to accept quoti...

2015-12-28 Thread Cazen
Github user Cazen commented on the pull request: https://github.com/apache/spark/pull/10497#issuecomment-167585156 recreate pull request(10496->10497) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-12445][SQL] Fix NullPointerException wh...

2015-12-28 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/10401#discussion_r48483901 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala --- @@ -407,10 +407,13 @@ object ScalaReflection extends

[GitHub] spark pull request: [SPARK-12445][SQL] Fix NullPointerException wh...

2015-12-28 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/10401#discussion_r48483879 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala --- @@ -407,10 +407,13 @@ object ScalaReflection extends

[GitHub] spark pull request: [SPARK-12537][SQL] Add option to accept quotin...

2015-12-28 Thread Cazen
GitHub user Cazen opened a pull request: https://github.com/apache/spark/pull/10495 [SPARK-12537][SQL] Add option to accept quoting of all character backslash quoting mechanism We can provides the option to choose JSON parser can be enabled to accept quoting of all character or

[GitHub] spark pull request: [SPARK-12537][SQL] Add option to accept quotin...

2015-12-28 Thread Cazen
Github user Cazen closed the pull request at: https://github.com/apache/spark/pull/10495 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-12537] [SQL] Add option to accept quoti...

2015-12-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10497#issuecomment-167573953 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12530][Build] Fix build break at Spark-...

2015-12-28 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/10488#discussion_r48479722 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/misc.scala --- @@ -57,9 +57,10 @@ case class Md5(child: Expression)

[GitHub] spark pull request: [SPARK-12445][SQL] Fix NullPointerException wh...

2015-12-28 Thread viirya
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/10401#issuecomment-167578551 ping @marmbrus @davies @cloud-fan Can you see if this patch is ok to merge? Thanks. --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark pull request: [SPARK-12539][SQL][WIP] support writing bucket...

2015-12-28 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/10498#issuecomment-167581087 cc @yhuai @nongli --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-12445][SQL] Fix NullPointerException wh...

2015-12-28 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/10401#discussion_r48482886 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala --- @@ -407,10 +407,13 @@ object ScalaReflection extends

[GitHub] spark pull request: [SPARK-12537] [SQL] Add option to accept quoti...

2015-12-28 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/10497#issuecomment-167585890 In general you do not need to open a new pull request. But before you make a PR, best to finish the questions on the JIRA. I'm not yet clear why this is regularly

[GitHub] spark pull request: [SPARK-12481] [CORE] [STREAMING] [SQL] Remove ...

2015-12-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10446#issuecomment-167566796 **[Test build #48366 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48366/consoleFull)** for PR 10446 at commit

[GitHub] spark pull request: [SPARK-12437][SQL] Encapsulate the table and c...

2015-12-28 Thread pjfanning
Github user pjfanning commented on a diff in the pull request: https://github.com/apache/spark/pull/10403#discussion_r48481306 --- Diff: docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/MySQLIntegrationSuite.scala --- @@ -150,4 +150,91 @@ class

[GitHub] spark pull request: [SPARK-12289][SQL] Support UnsafeRow in TakeOr...

2015-12-28 Thread viirya
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/10330#issuecomment-167578659 ping @marmbrus @yhuai Please help see if this patch is ok for you. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request: [SPARK-12537] [SQL] Add option to accept quoti...

2015-12-28 Thread Cazen
GitHub user Cazen opened a pull request: https://github.com/apache/spark/pull/10496 [SPARK-12537] [SQL] Add option to accept quoting of all character backslash quoting mechanism We can provides the option to choose JSON parser can be enabled to accept quoting of all character or

[GitHub] spark pull request: [SPARK-3369] [CORE] [STREAMING] Java mapPartit...

2015-12-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10413#issuecomment-167565889 **[Test build #48365 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48365/consoleFull)** for PR 10413 at commit

[GitHub] spark pull request: [SPARK-12537] [SQL] Add option to accept quoti...

2015-12-28 Thread Cazen
Github user Cazen commented on the pull request: https://github.com/apache/spark/pull/10496#issuecomment-167571045 For example, if JSON file that includes not listed by JSON backslash quoting specification, it returns corrupt_record JSON File {"name": "Cazen Lee", "price":

[GitHub] spark pull request: [SPARK-12539][SQL][WIP] support writing bucket...

2015-12-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10498#issuecomment-167582335 **[Test build #48367 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48367/consoleFull)** for PR 10498 at commit

[GitHub] spark pull request: [SPARK-12480][SQL] add Hash expression that ca...

2015-12-28 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/10435#issuecomment-167583523 need some help about the R test, I can't see the expected result through the error log... --- If your project is set up for it, you can reply to this email and have

[GitHub] spark pull request: [SPARK-12445][SQL] Fix NullPointerException wh...

2015-12-28 Thread viirya
Github user viirya closed the pull request at: https://github.com/apache/spark/pull/10401 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-12537][SQL] Add option to accept quotin...

2015-12-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10495#issuecomment-167564428 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12539][SQL][WIP] support writing bucket...

2015-12-28 Thread cloud-fan
GitHub user cloud-fan opened a pull request: https://github.com/apache/spark/pull/10498 [SPARK-12539][SQL][WIP] support writing bucketed table Done: * add bucket info in write path * support writing bucketed `HadoopFsRelation` TODO: * figure out a way

[GitHub] spark pull request: [SPARK-12480][SQL] add Hash expression that ca...

2015-12-28 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/10435#discussion_r48482588 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/misc.scala --- @@ -176,3 +178,221 @@ case class Crc32(child: Expression)

[GitHub] spark pull request: [SPARK-12481] [CORE] [STREAMING] [SQL] Remove ...

2015-12-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10446#issuecomment-167590960 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12481] [CORE] [STREAMING] [SQL] Remove ...

2015-12-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10446#issuecomment-167590880 **[Test build #48366 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48366/consoleFull)** for PR 10446 at commit

[GitHub] spark pull request: [SPARK-12481] [CORE] [STREAMING] [SQL] Remove ...

2015-12-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10446#issuecomment-167590962 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [Spark-10625] [SQL] Spark SQL JDBC read/write ...

2015-12-28 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/8785#discussion_r48492460 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/jdbc/UnserializableDriverHelper.scala --- @@ -0,0 +1,53 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [SPARK-12539][SQL][WIP] support writing bucket...

2015-12-28 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/10498#issuecomment-167614005 This one also includes https://github.com/apache/spark/pull/10435, right? --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request: [SPARK-8641][SPARK-12455][SQL] Native Spark Wi...

2015-12-28 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/10402#discussion_r48495547 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala --- @@ -327,9 +327,9 @@ abstract class

[GitHub] spark pull request: [SPARK-8641][SPARK-12455][SQL] Native Spark Wi...

2015-12-28 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/10402#discussion_r48495956 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala --- @@ -327,9 +327,9 @@ abstract class

[GitHub] spark pull request: [SPARK-12539][SQL][WIP] support writing bucket...

2015-12-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10498#issuecomment-167596712 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12218] Fixes ORC conjunction predicate ...

2015-12-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/10377 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-3369] [CORE] [STREAMING] Java mapPartit...

2015-12-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10413#issuecomment-167591723 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-3369] [CORE] [STREAMING] Java mapPartit...

2015-12-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10413#issuecomment-167591612 **[Test build #48365 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48365/consoleFull)** for PR 10413 at commit

[GitHub] spark pull request: [Spark-10625] [SQL] Spark SQL JDBC read/write ...

2015-12-28 Thread tribbloid
Github user tribbloid commented on a diff in the pull request: https://github.com/apache/spark/pull/8785#discussion_r48489063 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/jdbc/UnserializableDriverHelper.scala --- @@ -0,0 +1,53 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [SPARK-3369] [CORE] [STREAMING] Java mapPartit...

2015-12-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10413#issuecomment-167591724 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12218] Fixes ORC conjunction predicate ...

2015-12-28 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/10377#issuecomment-167601702 LGTM. Merging to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-12504][SQL] Masking credentials in the ...

2015-12-28 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/10452#issuecomment-167605425 Yes --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark pull request: [SPARK-12289][SQL] Support UnsafeRow in TakeOr...

2015-12-28 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/10330#discussion_r48494801 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/RowFormatConvertersSuite.scala --- @@ -38,7 +38,7 @@ class RowFormatConvertersSuite extends

[GitHub] spark pull request: [SPARK-12530][Build] Fix build break at Spark-...

2015-12-28 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/10488#discussion_r48495327 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/misc.scala --- @@ -57,9 +57,10 @@ case class Md5(child: Expression) extends

[GitHub] spark pull request: [SPARK-12539][SQL][WIP] support writing bucket...

2015-12-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10498#issuecomment-167596617 **[Test build #48367 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48367/consoleFull)** for PR 10498 at commit

[GitHub] spark pull request: [SPARK-12539][SQL][WIP] support writing bucket...

2015-12-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10498#issuecomment-167596714 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12480][SQL] add Hash expression that ca...

2015-12-28 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/10435#issuecomment-167614804 I see ``` 1. Failure (at test_sparkSQL.R#1160): group by, agg functions -- 30 not equal to collect(max(gd))[1, 2] 30 - 19 == 11

[GitHub] spark pull request: [SPARK-12441] [SQL] Fixing missingInput in Gen...

2015-12-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/10393 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-12340][SQL]fix Int overflow in the Spar...

2015-12-28 Thread sarutak
Github user sarutak commented on the pull request: https://github.com/apache/spark/pull/10487#issuecomment-167653173 @QiangCai LGTM but could you add test cases? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [DOC] Adjust coverage for partitionBy()

2015-12-28 Thread ted-yu
GitHub user ted-yu opened a pull request: https://github.com/apache/spark/pull/10499 [DOC] Adjust coverage for partitionBy() This is the related thread: http://search-hadoop.com/m/q3RTtO3ReeJ1iF02=Re+partitioning+json+data+in+spark Michael suggested fixing the doc.

[GitHub] spark pull request: [SPARK-12441] [SQL] Fixing missingInput in Gen...

2015-12-28 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/10393#issuecomment-167651518 Thanks, merging to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-7995][SPARK-6280][Core]Remove AkkaRpcEn...

2015-12-28 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/10459#discussion_r48505634 --- Diff: core/src/test/scala/org/apache/spark/util/AkkaUtilsSuite.scala --- @@ -61,9 +55,14 @@ class AkkaUtilsSuite extends SparkFunSuite with

[GitHub] spark pull request: [SPARK-12415] Do not use closure serializer to...

2015-12-28 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/10368#discussion_r48507496 --- Diff: core/src/main/scala/org/apache/spark/serializer/KryoSerializer.scala --- @@ -109,6 +111,9 @@ class KryoSerializer(conf: SparkConf)

[GitHub] spark pull request: [SPARK-12522] [SQL] [MINOR] Add the missing do...

2015-12-28 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/10471#discussion_r48507936 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/commands.scala --- @@ -102,6 +102,7 @@ case class SetCommand(kv: Option[(String,

[GitHub] spark pull request: [SPARK-12415] Do not use closure serializer to...

2015-12-28 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/10368#discussion_r48508806 --- Diff: core/src/main/scala/org/apache/spark/serializer/KryoSerializer.scala --- @@ -109,6 +111,9 @@ class KryoSerializer(conf: SparkConf)

[GitHub] spark pull request: [DOC] Adjust coverage for partitionBy()

2015-12-28 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/10499#discussion_r48508973 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala --- @@ -119,7 +119,7 @@ final class DataFrameWriter private[sql](df:

[GitHub] spark pull request: [DOC] Adjust coverage for partitionBy()

2015-12-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10499#issuecomment-167670012 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [DOC] Adjust coverage for partitionBy()

2015-12-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10499#issuecomment-167670013 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [DOC] Adjust coverage for partitionBy()

2015-12-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10499#issuecomment-167669938 **[Test build #48373 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48373/consoleFull)** for PR 10499 at commit

[GitHub] spark pull request: [SPARK-12489][Core][SQL][MLib]Fix minor issues...

2015-12-28 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/10440#issuecomment-167672081 Maybe @yhuai or @liancheng should take a quick look at the SQL changes. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request: [SPARK-12525] Fix fatal compiler warnings in K...

2015-12-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10479#issuecomment-167673716 **[Test build #48376 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48376/consoleFull)** for PR 10479 at commit

[GitHub] spark pull request: [SPARK-12415] Do not use closure serializer to...

2015-12-28 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/10368#discussion_r48511217 --- Diff: core/src/main/scala/org/apache/spark/serializer/KryoSerializer.scala --- @@ -109,6 +111,9 @@ class KryoSerializer(conf: SparkConf)

[GitHub] spark pull request: [SPARK-12525] Fix fatal compiler warnings in K...

2015-12-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10479#issuecomment-167673765 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12525] Fix fatal compiler warnings in K...

2015-12-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10479#issuecomment-167673766 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12525] Fix fatal compiler warnings in K...

2015-12-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/10479 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-12415] Do not use closure serializer to...

2015-12-28 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/10368#issuecomment-167673871 As @zsxwing pointed out, the existing unit tests are not sufficient because they didn't catch the fact that `ShuffleReadMetrics` et al must also be registered. This

[GitHub] spark pull request: [SPARK-12489][Core][SQL][MLib]Fix minor issues...

2015-12-28 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/10440#issuecomment-167675193 sql changes look good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-12489][Core][SQL][MLib]Fix minor issues...

2015-12-28 Thread zsxwing
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/10440#issuecomment-167675496 Thanks. Merging to master and 1.6 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-12490] Don't use Javascript for web UI'...

2015-12-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10441#issuecomment-167675687 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12490] Don't use Javascript for web UI'...

2015-12-28 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/10441#issuecomment-167675703 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-12490] Don't use Javascript for web UI'...

2015-12-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10441#issuecomment-167675690 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12441] [SQL] Fixing missingInput in Gen...

2015-12-28 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/10393#issuecomment-167675761 Thank you! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-12490] Don't use Javascript for web UI'...

2015-12-28 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/10441#discussion_r48511839 --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/StagePage.scala --- @@ -1232,24 +1243,16 @@ private[ui] class TaskPagedTable( override

[GitHub] spark pull request: [SPARK-12489][Core][SQL][MLib]Fix minor issues...

2015-12-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/10440 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-12231][SQL] Fix dropna when working wit...

2015-12-28 Thread viirya
Github user viirya closed the pull request at: https://github.com/apache/spark/pull/10251 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-7889] [CORE] HistoryServer to refresh c...

2015-12-28 Thread squito
Github user squito commented on the pull request: https://github.com/apache/spark/pull/6935#issuecomment-167676684 hi @steveloughran , I think maybe some commits didn't get pushed? I noticed a few places where things didn't seem to quite line up to your comments. (also there is a

[GitHub] spark pull request: [SPARK-12486] Worker should kill the executors...

2015-12-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10438#issuecomment-167676871 **[Test build #48374 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48374/consoleFull)** for PR 10438 at commit

[GitHub] spark pull request: [SPARK-12486] Worker should kill the executors...

2015-12-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10438#issuecomment-167676897 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12486] Worker should kill the executors...

2015-12-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10438#issuecomment-167676895 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

<    1   2   3   4   5   >