Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/10583#discussion_r48934317
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLConf.scala ---
@@ -451,6 +452,19 @@ private[spark] object SQLConf {
doc = "When true,
Github user felixcheung commented on the pull request:
https://github.com/apache/spark/pull/10597#issuecomment-169260865
looks good. no conflict with base/stats
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user hvanhovell commented on the pull request:
https://github.com/apache/spark/pull/10605#issuecomment-169149338
@davies this is pretty awesome! I have taken long look at the window code
and it looks solid. I am less of an expert on the Memory management front, so
maybe
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/10599#issuecomment-169150003
@robbinspg oh that does not matter. It has been merged
(https://github.com/apache/spark/commit/5afa62b20090e763ba10d9939ec214a11466087b).
---
If your project is set up
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10154#issuecomment-169149738
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10154#issuecomment-169149741
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/9581#issuecomment-169151934
@holdenk I like this approach. Just made 1 pass.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/10594
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user davies opened a pull request:
https://github.com/apache/spark/pull/10606
[SPARK-12659] fix NPE in UnsafeExternalSorter (used by cartesian product)
Cartesian product use UnsafeExternalSorter without comparator to do
spilling, it will NPE if spilling happens.
cc
Github user sethah commented on the pull request:
https://github.com/apache/spark/pull/10607#issuecomment-169158056
cc @holdenk @jkbradley Could you review when you get a chance?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/10607#discussion_r48907182
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/DecisionTreeRegressor.scala
---
@@ -87,6 +87,14 @@ final class DecisionTreeRegressor
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/10607#discussion_r48907580
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tree/impl/GradientBoostedTrees.scala
---
@@ -0,0 +1,272 @@
+/*
+ * Licensed to the Apache
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10607#issuecomment-169160018
**[Test build #48795 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48795/consoleFull)**
for PR 10607 at commit
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/10328#discussion_r48907954
--- Diff: docs/ml-guide.md ---
@@ -951,4 +951,4 @@ model.transform(test)
{% endhighlight %}
-
\ No newline at end of file
+
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/10328#issuecomment-169160466
@BenFradet Thank you for pinging again! It looks fine except for that odd
diff line.
---
If your project is set up for it, you can reply to this email and have
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10154#issuecomment-169149440
**[Test build #48786 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48786/consoleFull)**
for PR 10154 at commit
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/10605#discussion_r48903674
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/Window.scala ---
@@ -661,29 +719,35 @@ private[execution] final class
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/9581#discussion_r48904472
--- Diff: python/pyspark/ml/param/__init__.py ---
@@ -247,7 +248,24 @@ def _set(self, **kwargs):
Sets user-supplied params.
"""
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/9581#discussion_r48904424
--- Diff: python/pyspark/ml/param/_shared_params_code_gen.py ---
@@ -105,44 +109,45 @@ def get$Name(self):
print("\n# DO NOT MODIFY THIS FILE! It
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/9581#discussion_r48904430
--- Diff: python/pyspark/ml/param/_shared_params_code_gen.py ---
@@ -105,44 +109,45 @@ def get$Name(self):
print("\n# DO NOT MODIFY THIS FILE! It
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/9581#discussion_r48904427
--- Diff: python/pyspark/ml/param/_shared_params_code_gen.py ---
@@ -105,44 +109,45 @@ def get$Name(self):
print("\n# DO NOT MODIFY THIS FILE! It
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/10594#issuecomment-169152922
Merging with master
Thank you!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/9667#issuecomment-169152558
Yes, that's the main issue, especially since these features are already in
spark.ml.
---
If your project is set up for it, you can reply to this email and have your
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/8960#issuecomment-169156603
Right, sorry, I was losing track of things. In that case, let's close this
issue and focus on improving the Breeze method. Thanks!
---
If your project is set up
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/9525#issuecomment-169157238
@rekhajoshm +1 for the suggestion from @mengxr Could you please update
this accordingly? Thanks! (Or please comment if you don't have time.)
@urvishparikh
Github user holdenk commented on the pull request:
https://github.com/apache/spark/pull/9581#issuecomment-169157759
@jkbradley thanks! I've made the suggested changes :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
GitHub user sethah opened a pull request:
https://github.com/apache/spark/pull/10607
[SPARK-12379][ML][MLLIB] Copy GBT implementation to spark.ml
Currently, GBTs in spark.ml wrap the implementation in spark.mllib. This is
preventing several improvements to GBTs in spark.ml, so we
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9581#issuecomment-169157980
**[Test build #48794 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48794/consoleFull)**
for PR 9581 at commit
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/10607#discussion_r48907328
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tree/impl/GradientBoostedTrees.scala
---
@@ -0,0 +1,272 @@
+/*
+ * Licensed to the Apache
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/9670#issuecomment-169159539
@BryanCutler Any updates on this? I haven't heard new ideas of the real
cause from others myself. I'd suggest closing the PR for now, until we can
figure out the
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10582#issuecomment-169107961
**[Test build #48774 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48774/consoleFull)**
for PR 10582 at commit
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/10598#discussion_r48887425
--- Diff: python/pyspark/mllib/classification.py ---
@@ -323,38 +330,45 @@ def train(cls, data, iterations=100,
initialWeights=None, regParam=0.01,
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/10582#issuecomment-169108769
Another mysterious failure with no failure (although this change should not
affect any test code - if it compiles, it's good). retest this please
---
If your project
Github user nongli commented on a diff in the pull request:
https://github.com/apache/spark/pull/10498#discussion_r4112
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala ---
@@ -130,6 +130,34 @@ final class DataFrameWriter private[sql](df:
Github user BryanCutler commented on the pull request:
https://github.com/apache/spark/pull/10598#issuecomment-169110387
thanks @vijaykiran! I marked a few things for correction and I think in
general we should extend the comments to the 100 character limit where
applicable.
---
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10582#issuecomment-169108178
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10582#issuecomment-169108174
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/10598#discussion_r48887470
--- Diff: python/pyspark/mllib/classification.py ---
@@ -323,38 +330,45 @@ def train(cls, data, iterations=100,
initialWeights=None, regParam=0.01,
Github user acflorea commented on the pull request:
https://github.com/apache/spark/pull/9699#issuecomment-169108392
@jkbradley Thank you for your comment! I understand, I will close the issue.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user acflorea closed the pull request at:
https://github.com/apache/spark/pull/9699
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user nongli commented on a diff in the pull request:
https://github.com/apache/spark/pull/10498#discussion_r48887994
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala ---
@@ -130,6 +130,34 @@ final class DataFrameWriter private[sql](df:
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/10598#discussion_r48886805
--- Diff: python/pyspark/mllib/classification.py ---
@@ -272,37 +274,42 @@ def train(cls, data, iterations=100, step=1.0,
miniBatchFraction=1.0,
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10578#issuecomment-169108099
**[Test build #48782 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48782/consoleFull)**
for PR 10578 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10154#issuecomment-169109402
**[Test build #48776 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48776/consoleFull)**
for PR 10154 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10154#issuecomment-169115892
**[Test build #48786 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48786/consoleFull)**
for PR 10154 at commit
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/10391#issuecomment-169124211
Thanks, merging to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user nongli commented on a diff in the pull request:
https://github.com/apache/spark/pull/10498#discussion_r48895396
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetRelation.scala
---
@@ -87,7 +91,8 @@ private[sql] class
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10606#issuecomment-169160794
**[Test build #48793 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48793/consoleFull)**
for PR 10606 at commit
GitHub user robbinspg opened a pull request:
https://github.com/apache/spark/pull/10599
[SPARK-12647][SQL] Fix
o.a.s.sqlexecution.ExchangeCoordinatorSuite.determining the number of reducers:
aggregate operator
change expected partition sizes
You can merge this pull request into a
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10599#issuecomment-168973152
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user jaceklaskowski commented on the pull request:
https://github.com/apache/spark/pull/10595#issuecomment-168975843
Merged the other branches and ran build locally. Please review and merge at
your convenience @srowen @rxin. Thanks!
---
If your project is set up for it, you
Github user jaceklaskowski commented on the pull request:
https://github.com/apache/spark/pull/10591#issuecomment-168976471
Merged to #10595
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10588#issuecomment-168977226
**[Test build #48758 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48758/consoleFull)**
for PR 10588 at commit
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/10554#issuecomment-168977430
@rxin OK I _almost_ did that. I realized that `JavaRDD.countByValue`
already does a `mapValues`. I left `countByKey` to act the same way, doing the
mapping. Other
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10601#issuecomment-168978654
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/10384#issuecomment-168979726
Merged to master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10570#issuecomment-168981740
**[Test build #48762 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48762/consoleFull)**
for PR 10570 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10598#issuecomment-168968321
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10577#issuecomment-168971536
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10577#issuecomment-168971537
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/10314#discussion_r48833641
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLConf.scala ---
@@ -100,6 +101,37 @@ private[spark] object SQLConf {
}
},
GitHub user vijaykiran opened a pull request:
https://github.com/apache/spark/pull/10600
[SPARK-12633][DOC] Update param descriptions
Updates the param descriptions to be consistent. See [SPARK-11219] for
more details.
You can merge this pull request into a Git repository by
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10600#issuecomment-168973957
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user jaceklaskowski closed the pull request at:
https://github.com/apache/spark/pull/10591
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/10595#issuecomment-168978428
Jenkins test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10554#issuecomment-168979486
**[Test build #48759 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48759/consoleFull)**
for PR 10554 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10210#issuecomment-168979507
**[Test build #48760 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48760/consoleFull)**
for PR 10210 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10592#issuecomment-168970536
**[Test build #2324 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2324/consoleFull)**
for PR 10592 at commit
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/10415#issuecomment-168970583
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10577#issuecomment-168971317
**[Test build #48756 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48756/consoleFull)**
for PR 10577 at commit
Github user radekg commented on the pull request:
https://github.com/apache/spark/pull/9608#issuecomment-168972745
@tnachen what would be the best place to publish such documentation?
Regarding `worth nothing` comment. The whole concept behind this pr is to allow
running spark master
Github user radekg commented on a diff in the pull request:
https://github.com/apache/spark/pull/9608#discussion_r48834671
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -854,7 +854,8 @@ private[spark] object Utils extends Logging {
* Get the local
Github user robbinspg commented on the pull request:
https://github.com/apache/spark/pull/10421#issuecomment-168973101
created https://issues.apache.org/jira/browse/SPARK-12647 and associated PR
---
If your project is set up for it, you can reply to this email and have your
reply
Github user jaceklaskowski commented on the pull request:
https://github.com/apache/spark/pull/10592#issuecomment-168976132
Merged to #10595.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user jaceklaskowski closed the pull request at:
https://github.com/apache/spark/pull/10592
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10527#issuecomment-168976826
Build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10527#issuecomment-168976829
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10527#issuecomment-168976748
**[Test build #48744 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48744/consoleFull)**
for PR 10527 at commit
GitHub user vijaykiran opened a pull request:
https://github.com/apache/spark/pull/10601
[SPARK-12634][DOC] Update param descriptions
Updates the `param` descriptions to be consistent. See [SPARK-11219] for
more details.
You can merge this pull request into a Git repository by
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10595#issuecomment-168979320
**[Test build #48761 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48761/consoleFull)**
for PR 10595 at commit
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/10384
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9608#issuecomment-168982029
**[Test build #48764 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48764/consoleFull)**
for PR 9608 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10541#issuecomment-169133557
**[Test build #48779 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48779/consoleFull)**
for PR 10541 at commit
Github user nongli commented on the pull request:
https://github.com/apache/spark/pull/10604#issuecomment-169133603
@cloud-fan I'm not sure I understand your question. We are guaranteed that
for a bucketed data set, each file in HDFS is for the same bucket. We need to
coalesce
Github user nongli commented on the pull request:
https://github.com/apache/spark/pull/10581#issuecomment-169134087
This doesn't really do much but just to make this component create-able
without the hadoop machinery.
---
If your project is set up for it, you can reply to this email
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10605#issuecomment-169134274
**[Test build #48790 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48790/consoleFull)**
for PR 10605 at commit
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/10579#issuecomment-169134219
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/10599#issuecomment-169134672
LGTM. Merging to branch 1.6.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10541#issuecomment-169133875
Build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user sureshthalamati commented on the pull request:
https://github.com/apache/spark/pull/10452#issuecomment-169136996
Retest this please.
Tests passed in my branch. Test Failure in the builds does not seem to be
related to my changes.
---
If your project is set up
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10594#issuecomment-169137124
**[Test build #2329 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2329/consoleFull)**
for PR 10594 at commit
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/10581#discussion_r48898645
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/SpecificParquetRecordReaderBase.java
---
@@ -125,20 +129,80 @@ public
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/10526#issuecomment-169139493
Ping again; should be quick to update then we can merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/10599#issuecomment-169139782
I have merged this. Can you close the PR? Thank you!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10573#issuecomment-169140591
**[Test build #48791 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48791/consoleFull)**
for PR 10573 at commit
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/10589#issuecomment-169140659
@nongli You don't need to repeat the title in the description of the PR (or
it get duplicated in commit message).
---
If your project is set up for it, you can reply
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10205#issuecomment-169141655
**[Test build #48783 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48783/consoleFull)**
for PR 10205 at commit
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/9807#issuecomment-169142908
Looks fine except for those small comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/10581#issuecomment-169143525
Merging this to unblock the following up PR (could be addressed there).
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/10605#discussion_r48900944
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/Window.scala ---
@@ -661,29 +719,35 @@ private[execution] final class
501 - 600 of 841 matches
Mail list logo
