[GitHub] spark pull request: [SPARK-12636][SQL] Update UnsafeRowParquetReco...

2016-01-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/10581 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-12511][PySpark][Streaming]Make sure Pyt...

2016-01-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/10514 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-11696] [ML, MLlib] Optimization: Extend...

2016-01-05 Thread avulanov
Github user avulanov commented on the pull request: https://github.com/apache/spark/pull/9667#issuecomment-169143891 @jkbradley Thanks for explanation! With regards to this particular PR, Do I understand correct, that you don't want to add a new feature to the soon-to-be-deprecated

[GitHub] spark pull request: [SPARK-12504][SQL] Masking credentials in the ...

2016-01-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10452#issuecomment-169145624 **[Test build #48792 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48792/consoleFull)** for PR 10452 at commit

[GitHub] spark pull request: [SPARK-12230][ML] WeightedLeastSquares.fit() s...

2016-01-05 Thread iyounus
Github user iyounus commented on a diff in the pull request: https://github.com/apache/spark/pull/10274#discussion_r48902276 --- Diff: mllib/src/main/scala/org/apache/spark/ml/optim/WeightedLeastSquares.scala --- @@ -86,6 +86,22 @@ private[ml] class WeightedLeastSquares(

[GitHub] spark pull request: [SPARK-11696] [ML, MLlib] Optimization: Extend...

2016-01-05 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/9667#issuecomment-169134436 There has been a lot of confusion about the spark.ml vs spark.mllib APIs, so we want to achieve feature parity in spark.ml. There are no set plans to deprecate

[GitHub] spark pull request: [SPARK-12617][PySpark]Clean up the leak socket...

2016-01-05 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/10579#issuecomment-169135214 Merged into master and 1.5, 1.6 branch --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-12560][SQL] SqlTestUtils.stripSparkFilt...

2016-01-05 Thread squito
Github user squito commented on the pull request: https://github.com/apache/spark/pull/10510#issuecomment-169135396 @davies that makes sense, I've updated the change to just add a `.copy()`, thanks for the suggestion. @HyukjinKwon I think I understand the point of

[GitHub] spark pull request: [SPARK-12617][PySpark]Clean up the leak socket...

2016-01-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/10579 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-12616] [SQL] Adding a New Logical Opera...

2016-01-05 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/10577#issuecomment-169135841 Understood it. Thank you! Will not introduce new APIs. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: [SPARK-12616] [SQL] Adding a New Logical Opera...

2016-01-05 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/10577#discussion_r48897039 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/planning/patterns.scala --- @@ -169,18 +169,3 @@ object ExtractFiltersAndInnerJoins

[GitHub] spark pull request: [SPARK-12616] [SQL] Adding a New Logical Opera...

2016-01-05 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/10577#discussion_r48897156 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/HiveTypeCoercion.scala --- @@ -212,22 +212,47 @@ object HiveTypeCoercion {

[GitHub] spark pull request: [SPARK-6724] [MLlib] Support model save/load f...

2016-01-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/9267 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-12636][SQL] Update UnsafeRowParquetReco...

2016-01-05 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/10581#issuecomment-169140437 LGTM, except one minor comment. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-12570] [ML] [Doc] DecisionTreeRegressor...

2016-01-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10594#issuecomment-169140841 **[Test build #2329 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2329/consoleFull)** for PR 10594 at commit

[GitHub] spark pull request: [SPARK-529] [core] [yarn] Add type-safe config...

2016-01-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10205#issuecomment-169141968 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-529] [core] [yarn] Add type-safe config...

2016-01-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10205#issuecomment-169141963 Build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-12511][PySpark][Streaming]Make sure Pyt...

2016-01-05 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/10514#issuecomment-169144547 Merged into master and 1.6 branch, could you create a JIRA to clean this once the bugs are fixed in py4j (and released)? --- If your project is set up for it, you can

[GitHub] spark pull request: [SPARK-12504][SQL] Masking credentials in the ...

2016-01-05 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/10452#issuecomment-169144753 test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-12629] [SparkR] Fixes for DataFrame sav...

2016-01-05 Thread NarineK
Github user NarineK commented on a diff in the pull request: https://github.com/apache/spark/pull/10580#discussion_r48901154 --- Diff: R/pkg/R/DataFrame.R --- @@ -2005,13 +2005,18 @@ setMethod("saveDF", #' saveAsTable(df, "myfile") #' } setMethod("saveAsTable", -

[GitHub] spark pull request: [SPARK-12295] [SQL] external spilling for wind...

2016-01-05 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/10605#discussion_r48901213 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/Window.scala --- @@ -498,7 +548,13 @@ private[execution] final class

[GitHub] spark pull request: [SPARK-12629] [SparkR] Fixes for DataFrame sav...

2016-01-05 Thread NarineK
Github user NarineK commented on a diff in the pull request: https://github.com/apache/spark/pull/10580#discussion_r48901251 --- Diff: R/pkg/R/generics.R --- @@ -521,7 +521,7 @@ setGeneric("sampleBy", function(x, col, fractions, seed) { standardGeneric("samp #' @rdname

[GitHub] spark pull request: [SPARK-12295] [SQL] external spilling for wind...

2016-01-05 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/10605#discussion_r48902027 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/Window.scala --- @@ -661,29 +719,35 @@ private[execution] final class

[GitHub] spark pull request: [SPARK-12511][PySpark][Streaming]Make sure Pyt...

2016-01-05 Thread zsxwing
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/10514#issuecomment-169147628 > Merged into master and 1.6 branch, could you create a JIRA to clean this once the bugs are fixed in py4j (and released)? Created sub tasks in

[GitHub] spark pull request: [SPARK-12511][PySpark][Streaming]Make sure Pyt...

2016-01-05 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/10514#issuecomment-169133324 LGTM, do we need to merge this into 1.6? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-12647][SQL] Fix o.a.s.sqlexecution.Exch...

2016-01-05 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/10599#issuecomment-169133899 cc @yhuai --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-12593][SQL][WIP] Converts resolved logi...

2016-01-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10541#issuecomment-169133877 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-3873] [sql] Import ordering fixes.

2016-01-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10573#issuecomment-169136312 **[Test build #48775 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48775/consoleFull)** for PR 10573 at commit

[GitHub] spark pull request: [SPARK-3873] [sql] Import ordering fixes.

2016-01-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10573#issuecomment-169136491 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-10906][MLlib] More efficient SparseMatr...

2016-01-05 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/8960#issuecomment-169136389 @rahulpalamuttam Yes, please, it'd be great to update this PR to be a test only (assuming it fails without the Breeze fix?). I'll test and comment on the Breeze PR.

[GitHub] spark pull request: [SPARK-3873] [sql] Import ordering fixes.

2016-01-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10573#issuecomment-169136495 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12570] [ML] [Doc] DecisionTreeRegressor...

2016-01-05 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/10594#issuecomment-169137240 LGTM pending tests (There's an indentation bug in the table, but it's fine for now.) --- If your project is set up for it, you can reply to this email and have

[GitHub] spark pull request: [SPARK-3873] [sql] Import ordering fixes.

2016-01-05 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/10573#issuecomment-169137225 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-10906][MLlib] More efficient SparseMatr...

2016-01-05 Thread rahulpalamuttam
Github user rahulpalamuttam commented on the pull request: https://github.com/apache/spark/pull/8960#issuecomment-169139021 Actually the test passes regardless of whether the fix is there or not. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: [SPARK-6724] [MLlib] Support model save/load f...

2016-01-05 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/9267#issuecomment-169139805 @yanboliang No problem; thanks for your updates! This LGTM Merging with master --- If your project is set up for it, you can reply to this email and have

[GitHub] spark pull request: [SPARK-9843][SQL] Make catalyst optimizer pass...

2016-01-05 Thread robert3005
Github user robert3005 commented on a diff in the pull request: https://github.com/apache/spark/pull/10210#discussion_r48899006 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkOptimizer.scala --- @@ -0,0 +1,30 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [SPARK-12511][PySpark][Streaming]Make sure Pyt...

2016-01-05 Thread zsxwing
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/10514#issuecomment-169141854 > do we need to merge this into 1.6? Yes since it affects all people using PySpark Streaming checkpoint. --- If your project is set up for it, you can reply

[GitHub] spark pull request: [SPARK-11815] [ML] [PySpark] PySpark DecisionT...

2016-01-05 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/9807#discussion_r48900277 --- Diff: python/pyspark/ml/regression.py --- @@ -396,7 +397,7 @@ class DecisionTreeRegressor(JavaEstimator, HasFeaturesCol, HasLabelCol, HasPredi

[GitHub] spark pull request: [SPARK-12640][SQL] Add simple benchmarking uti...

2016-01-05 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/10589#discussion_r48900041 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetReadBenchmark.scala --- @@ -0,0 +1,157 @@ +/* + *

[GitHub] spark pull request: [SPARK-11815] [ML] [PySpark] PySpark DecisionT...

2016-01-05 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/9807#discussion_r48900273 --- Diff: python/pyspark/ml/classification.py --- @@ -287,7 +287,7 @@ class DecisionTreeClassifier(JavaEstimator, HasFeaturesCol, HasLabelCol, HasPred

[GitHub] spark pull request: [SPARK-12041] [ML] [PySpark] Add columnSimilar...

2016-01-05 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/10158#issuecomment-169143652 LGTM I'll just run the tests once more before merging --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: [SPARK-11515][ML] QuantileDiscretizer should t...

2016-01-05 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/9535#issuecomment-169144391 @yu-iskw Apologies for the delay. We can get this merged now, once you can update it. Thank you! --- If your project is set up for it, you can reply to this email

[GitHub] spark pull request: [SPARK-12629] [SparkR] Fixes for DataFrame sav...

2016-01-05 Thread NarineK
Github user NarineK commented on a diff in the pull request: https://github.com/apache/spark/pull/10580#discussion_r48901574 --- Diff: R/pkg/R/DataFrame.R --- @@ -2005,13 +2005,18 @@ setMethod("saveDF", #' saveAsTable(df, "myfile") #' } setMethod("saveAsTable", -

[GitHub] spark pull request: [SPARK-12647][SQL] Fix o.a.s.sqlexecution.Exch...

2016-01-05 Thread robbinspg
Github user robbinspg closed the pull request at: https://github.com/apache/spark/pull/10599 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-12647][SQL] Fix o.a.s.sqlexecution.Exch...

2016-01-05 Thread robbinspg
Github user robbinspg commented on the pull request: https://github.com/apache/spark/pull/10599#issuecomment-169148536 I closed this as per request but it states "Closed with unmerged commits" --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: [SPARK-11315] [YARN] Add YARN extension servic...

2016-01-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8744#issuecomment-168991991 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12480][follow-up] use a single column v...

2016-01-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10588#issuecomment-168992234 **[Test build #48758 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48758/consoleFull)** for PR 10588 at commit

[GitHub] spark pull request: [SPARK-12480][follow-up] use a single column v...

2016-01-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10588#issuecomment-168992446 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12480][follow-up] use a single column v...

2016-01-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10588#issuecomment-168992449 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [STREAMING][DOCS][EXAMPLES] Minor fixes

2016-01-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10603#issuecomment-168992549 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12539][SQL] support writing bucketed ta...

2016-01-05 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/10498#discussion_r48842483 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala --- @@ -240,6 +241,25 @@ private[hive] class

[GitHub] spark pull request: [SPARK-12539][SQL] support writing bucketed ta...

2016-01-05 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/10498#discussion_r48842647 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala --- @@ -189,13 +220,47 @@ final class DataFrameWriter private[sql](df:

[GitHub] spark pull request: [SPARK-9843][SQL] Make catalyst optimizer pass...

2016-01-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10210#issuecomment-168995289 **[Test build #48760 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48760/consoleFull)** for PR 10210 at commit

[GitHub] spark pull request: [SPARK-12539][SQL] support writing bucketed ta...

2016-01-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10498#issuecomment-168995524 **[Test build #48770 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48770/consoleFull)** for PR 10498 at commit

[GitHub] spark pull request: [SPARK-9843][SQL] Make catalyst optimizer pass...

2016-01-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10210#issuecomment-168995484 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-9843][SQL] Make catalyst optimizer pass...

2016-01-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10210#issuecomment-168995486 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12604] [CORE] Java count(AprroxDistinct...

2016-01-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10554#issuecomment-168996713 **[Test build #48759 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48759/consoleFull)** for PR 10554 at commit

[GitHub] spark pull request: [SPARK-12604] [CORE] Java count(AprroxDistinct...

2016-01-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10554#issuecomment-168996918 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [STREAMING][MINOR] More contextual information...

2016-01-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10595#issuecomment-168997214 **[Test build #48761 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48761/consoleFull)** for PR 10595 at commit

[GitHub] spark pull request: [SPARK-12604] [CORE] Java count(AprroxDistinct...

2016-01-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10554#issuecomment-168996921 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [STREAMING][MINOR] More contextual information...

2016-01-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10595#issuecomment-168997399 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [STREAMING][MINOR] More contextual information...

2016-01-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10595#issuecomment-168997402 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [STREAMING][DOCS][EXAMPLES] Minor fixes

2016-01-05 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/10603#discussion_r48844388 --- Diff: docs/streaming-custom-receivers.md --- @@ -273,9 +273,9 @@ class CustomActor extends Actor with ActorHelper { And a new input stream can be

[GitHub] spark pull request: [SPARK-12340][SQL]fix Int overflow in the Spar...

2016-01-05 Thread QiangCai
Github user QiangCai commented on the pull request: https://github.com/apache/spark/pull/10562#issuecomment-168997795 @srowen I have rebased from master and resolved all conflicts. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark pull request: [SPARK-12340][SQL]fix Int overflow in the Spar...

2016-01-05 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/10562#discussion_r48844423 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala --- @@ -2028,6 +2028,7 @@ class SQLQuerySuite extends QueryTest with

[GitHub] spark pull request: [SPARK-7675][ML][PYSpark] sparkml params type ...

2016-01-05 Thread holdenk
Github user holdenk commented on the pull request: https://github.com/apache/spark/pull/9581#issuecomment-169181751 I've added a test using LogisitcRegression - I figured it would be better to use a real model so as to validate that it got picked up OK on the Java side too. --- If

[GitHub] spark pull request: SPARK-12637 Print stage info of finished stage...

2016-01-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10585#issuecomment-169181495 **[Test build #48803 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48803/consoleFull)** for PR 10585 at commit

[GitHub] spark pull request: [SPARK-12632][Python][Make Parameter Descripti...

2016-01-05 Thread BryanCutler
Github user BryanCutler commented on a diff in the pull request: https://github.com/apache/spark/pull/10602#discussion_r48916985 --- Diff: python/pyspark/mllib/fpm.py --- @@ -130,15 +133,22 @@ def train(cls, data, minSupport=0.1, maxPatternLength=10, maxLocalProjDBSize=320

[GitHub] spark pull request: [SPARK-12632][Python][Make Parameter Descripti...

2016-01-05 Thread BryanCutler
Github user BryanCutler commented on a diff in the pull request: https://github.com/apache/spark/pull/10602#discussion_r48917047 --- Diff: python/pyspark/mllib/fpm.py --- @@ -68,11 +68,14 @@ def train(cls, data, minSupport=0.3, numPartitions=-1): """

[GitHub] spark pull request: [SPARK-12631] [PYSPARK] [DOC] PySpark clusteri...

2016-01-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10610#issuecomment-169182466 **[Test build #48802 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48802/consoleFull)** for PR 10610 at commit

[GitHub] spark pull request: SPARK-12619 Combine small files in a hadoop di...

2016-01-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10572#issuecomment-169183501 **[Test build #48804 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48804/consoleFull)** for PR 10572 at commit

[GitHub] spark pull request: [SPARK-12632][Python][Make Parameter Descripti...

2016-01-05 Thread BryanCutler
Github user BryanCutler commented on a diff in the pull request: https://github.com/apache/spark/pull/10602#discussion_r48917244 --- Diff: python/pyspark/mllib/fpm.py --- @@ -130,15 +133,22 @@ def train(cls, data, minSupport=0.1, maxPatternLength=10, maxLocalProjDBSize=320

[GitHub] spark pull request: [SPARK-7675][ML][PYSpark] sparkml params type ...

2016-01-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9581#issuecomment-169183803 **[Test build #48805 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48805/consoleFull)** for PR 9581 at commit

[GitHub] spark pull request: [SPARK-7675][ML][PYSpark] sparkml params type ...

2016-01-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9581#issuecomment-169183941 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-7675][ML][PYSpark] sparkml params type ...

2016-01-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9581#issuecomment-169183939 **[Test build #48805 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48805/consoleFull)** for PR 9581 at commit

[GitHub] spark pull request: [SPARK-12632][Python][Make Parameter Descripti...

2016-01-05 Thread BryanCutler
Github user BryanCutler commented on a diff in the pull request: https://github.com/apache/spark/pull/10602#discussion_r48917505 --- Diff: python/pyspark/mllib/fpm.py --- @@ -68,11 +68,14 @@ def train(cls, data, minSupport=0.3, numPartitions=-1): """

[GitHub] spark pull request: [SPARK-7675][ML][PYSpark] sparkml params type ...

2016-01-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9581#issuecomment-169183944 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12663] [MLlib] More informative error m...

2016-01-05 Thread robert-dodier
GitHub user robert-dodier opened a pull request: https://github.com/apache/spark/pull/10611 [SPARK-12663] [MLlib] More informative error message in MLUtils.loadLibSVMFile This PR contains 1 commit which resolves [SPARK-12663](https://issues.apache.org/jira/browse/SPARK-12663).

[GitHub] spark pull request: [SPARK-12632][Python][Make Parameter Descripti...

2016-01-05 Thread BryanCutler
Github user BryanCutler commented on the pull request: https://github.com/apache/spark/pull/10602#issuecomment-16918 Thanks @somideshmukh! Could you please look the corrections from @vijaykiran and me, extend the descriptions to the 100 character limit, and add the parameter

[GitHub] spark pull request: [SPARK-12663] [MLlib] More informative error m...

2016-01-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10611#issuecomment-169185779 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12295] [SQL] external spilling for wind...

2016-01-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10605#issuecomment-169186092 **[Test build #48806 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48806/consoleFull)** for PR 10605 at commit

[GitHub] spark pull request: [SPARK-12593][SQL][WIP] Converts resolved logi...

2016-01-05 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/10541#issuecomment-169186628 Tests finally pass! (The last build failure was actually triggered by an older commit.) --- If your project is set up for it, you can reply to this email and have

[GitHub] spark pull request: [SPARK-12631] [PYSPARK] [DOC] PySpark clusteri...

2016-01-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10610#issuecomment-169187125 **[Test build #48802 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48802/consoleFull)** for PR 10610 at commit

[GitHub] spark pull request: [SPARK-12631] [PYSPARK] [DOC] PySpark clusteri...

2016-01-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10610#issuecomment-169187255 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12659] fix NPE in UnsafeExternalSorter ...

2016-01-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10606#issuecomment-169187512 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12631] [PYSPARK] [DOC] PySpark clusteri...

2016-01-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10610#issuecomment-169187257 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12659] fix NPE in UnsafeExternalSorter ...

2016-01-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10606#issuecomment-169187237 **[Test build #48793 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48793/consoleFull)** for PR 10606 at commit

[GitHub] spark pull request: [SPARK-12659] fix NPE in UnsafeExternalSorter ...

2016-01-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10606#issuecomment-169187517 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-7675][ML][PYSpark] sparkml params type ...

2016-01-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9581#issuecomment-169189182 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-7675][ML][PYSpark] sparkml params type ...

2016-01-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9581#issuecomment-169189178 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12567][SQL] Add aes_{encrypt,decrypt} U...

2016-01-05 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/10527#discussion_r48918992 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/misc.scala --- @@ -221,3 +224,147 @@ case class Murmur3Hash(children:

[GitHub] spark pull request: [SPARK-12567][SQL] Add aes_{encrypt,decrypt} U...

2016-01-05 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/10527#discussion_r48918891 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/misc.scala --- @@ -221,3 +224,147 @@ case class Murmur3Hash(children:

[GitHub] spark pull request: [SPARK-12663] [MLlib] More informative error m...

2016-01-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10611#issuecomment-169190431 **[Test build #2332 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2332/consoleFull)** for PR 10611 at commit

[GitHub] spark pull request: [SPARK-12567][SQL] Add aes_{encrypt,decrypt} U...

2016-01-05 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/10527#discussion_r48919100 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/misc.scala --- @@ -221,3 +224,147 @@ case class Murmur3Hash(children:

[GitHub] spark pull request: [SPARK-12663] [MLlib] More informative error m...

2016-01-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10611#issuecomment-169190664 **[Test build #2332 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2332/consoleFull)** for PR 10611 at commit

[GitHub] spark pull request: [SPARK-12573][SPARK-12574][SQL] Move SQL Parse...

2016-01-05 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/10583#discussion_r48919353 --- Diff: sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/parser/ParseUtils.java --- @@ -0,0 +1,163 @@ +/** + * Licensed to the Apache

[GitHub] spark pull request: [SPARK-11579] [ML] avoid creating new optimize...

2016-01-05 Thread hhbyyh
Github user hhbyyh commented on the pull request: https://github.com/apache/spark/pull/9614#issuecomment-169191098 OK. I'll close this. Thanks for helping review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12663] [MLlib] More informative error m...

2016-01-05 Thread thunterdb
Github user thunterdb commented on a diff in the pull request: https://github.com/apache/spark/pull/10611#discussion_r48919311 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/util/MLUtils.scala --- @@ -86,7 +86,7 @@ object MLUtils { val indicesLength =

[GitHub] spark pull request: [SPARK-12663] [MLlib] More informative error m...

2016-01-05 Thread thunterdb
Github user thunterdb commented on the pull request: https://github.com/apache/spark/pull/10611#issuecomment-169190994 @robert-dodier thanks for your PR. Can you please fix the style issue? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request: [SPARK-12340][SQL]fix Int overflow in the Spar...

2016-01-05 Thread QiangCai
Github user QiangCai commented on the pull request: https://github.com/apache/spark/pull/10562#issuecomment-169191091 I think I have resolved this problem. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

<    2   3   4   5   6   7   8   9   >