[GitHub] spark pull request: Improve CaseWhen codegen by removing got varia...

2016-01-12 Thread viirya
GitHub user viirya opened a pull request: https://github.com/apache/spark/pull/10737 Improve CaseWhen codegen by removing got variable with "if/else". JIRA: https://issues.apache.org/jira/browse/SPARK-12771 You can merge this pull request into a Git repository by running: $ git

[GitHub] spark pull request: [SPARK-12543] [SPARK-4226] [SQL] [WIP] Subquer...

2016-01-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10706#issuecomment-171206219 **[Test build #49302 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49302/consoleFull)** for PR 10706 at commit [`aa33df0`](https://g

[GitHub] spark pull request: [SPARK-12543] [SPARK-4226] [SQL] [WIP] Subquer...

2016-01-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10706#issuecomment-171206338 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-12543] [SPARK-4226] [SQL] [WIP] Subquer...

2016-01-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10706#issuecomment-171206336 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-12543] [SPARK-4226] [SQL] [WIP] Subquer...

2016-01-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10706#issuecomment-171205637 **[Test build #2374 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2374/consoleFull)** for PR 10706 at commit [`aa33df0`](https://

[GitHub] spark pull request: [SPARK-12543] [SPARK-4226] [SQL] [WIP] Subquer...

2016-01-12 Thread chenghao-intel
Github user chenghao-intel commented on a diff in the pull request: https://github.com/apache/spark/pull/10706#discussion_r49559144 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/joins/SemiJoinSuite.scala --- @@ -108,9 +109,26 @@ class SemiJoinSuite extends Spark

[GitHub] spark pull request: [SPARK-12543] [SPARK-4226] [SQL] [WIP] Subquer...

2016-01-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10706#issuecomment-171201579 **[Test build #49302 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49302/consoleFull)** for PR 10706 at commit [`aa33df0`](https://gi

[GitHub] spark pull request: [SPARK-12791][SQL] Simplify CaseWhen by breaki...

2016-01-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10734#issuecomment-171202444 **[Test build #49303 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49303/consoleFull)** for PR 10734 at commit [`a3a9103`](https://gi

[GitHub] spark pull request: [SPARK-12543] [SPARK-4226] [SQL] [WIP] Subquer...

2016-01-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10706#issuecomment-171201485 **[Test build #2374 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2374/consoleFull)** for PR 10706 at commit [`aa33df0`](https://g

[GitHub] spark pull request: [SPARK-12539][follow-up] always sort in partit...

2016-01-12 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/10638#issuecomment-171201370 We discussed this and decided this is a simple config change users can apply. Changing the behavior automatically for users in a point release is also bad. --- If your

[GitHub] spark pull request: [SPARK-12791][SQL] Simplify CaseWhen by breaki...

2016-01-12 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/10734#discussion_r49558156 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala --- @@ -1002,7 +1002,7 @@ object functions extends LegacyFunctions { * @since

[GitHub] spark pull request: [SPARK-12539][follow-up] always sort in partit...

2016-01-12 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/10638#issuecomment-171200917 Yes, cc @marmbrus --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fea

[GitHub] spark pull request: [SPARK-12539][follow-up] always sort in partit...

2016-01-12 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/10638#issuecomment-171200576 only backport it without bucket-write? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-12791][SQL] Simplify CaseWhen by breaki...

2016-01-12 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/10734#discussion_r49557974 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala --- @@ -183,32 +175,38 @@ case class CaseWhen(bran

[GitHub] spark pull request: [SPARK-12791][SQL] Simplify CaseWhen by breaki...

2016-01-12 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/10734#discussion_r49557801 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala --- @@ -183,32 +175,38 @@ case class CaseWhen

[GitHub] spark pull request: [SPARK-12791][SQL] Simplify CaseWhen by breaki...

2016-01-12 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/10734#discussion_r49557719 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala --- @@ -81,44 +81,39 @@ case class If(predicate: E

[GitHub] spark pull request: [SPARK-9297][SQL] Add covar_pop and covar_samp

2016-01-12 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/10029#discussion_r49557554 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Covariance.scala --- @@ -0,0 +1,205 @@ +/* + * Licensed to

[GitHub] spark pull request: [SPARK-12539][follow-up] always sort in partit...

2016-01-12 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/10638#issuecomment-171199355 @cloud-fan Should we create a patch for 1.6 branch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If yo

[GitHub] spark pull request: [SPARK-12791][SQL] Simplify CaseWhen by breaki...

2016-01-12 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/10734#discussion_r49557461 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala --- @@ -81,44 +81,39 @@ case class If(predica

[GitHub] spark pull request: [SPARK-9297][SQL] Add covar_pop and covar_samp

2016-01-12 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/10029#issuecomment-171198669 @viirya Yeah, we can merge this in first. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-9297][SQL] Add covar_pop and covar_samp

2016-01-12 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/10029#discussion_r49557393 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Covariance.scala --- @@ -0,0 +1,205 @@ +/* + * Licensed to

[GitHub] spark pull request: [SPARK-12705] [SQL] AnalysisException: Sorting...

2016-01-12 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/10678#discussion_r49557216 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -521,38 +522,81 @@ class Analyzer( */ o

[GitHub] spark pull request: [SPARK-12149] [Web UI] Executor UI improvement...

2016-01-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10154#issuecomment-171197657 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-12791][SQL] Simplify CaseWhen by breaki...

2016-01-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10734#issuecomment-171197638 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-12149] [Web UI] Executor UI improvement...

2016-01-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10154#issuecomment-171197660 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-12791][SQL] Simplify CaseWhen by breaki...

2016-01-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10734#issuecomment-171197636 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-12791][SQL] Simplify CaseWhen by breaki...

2016-01-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10734#issuecomment-171197610 **[Test build #49299 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49299/consoleFull)** for PR 10734 at commit [`8181c3a`](https://g

[GitHub] spark pull request: [SPARK-12149] [Web UI] Executor UI improvement...

2016-01-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10154#issuecomment-171197512 **[Test build #49291 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49291/consoleFull)** for PR 10154 at commit [`70ab748`](https://g

[GitHub] spark pull request: [SPARK-12791][SQL] Simplify CaseWhen by breaki...

2016-01-12 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/10734#discussion_r49556863 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala --- @@ -81,44 +81,39 @@ case class If(predicate: E

[GitHub] spark pull request: [SPARK-12791][SQL] Simplify CaseWhen by breaki...

2016-01-12 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/10734#discussion_r49556745 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala --- @@ -81,44 +81,39 @@ case class If(predica

[GitHub] spark pull request: [SPARK-12705] [SQL] AnalysisException: Sorting...

2016-01-12 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/10678#discussion_r49556790 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -521,38 +522,81 @@ class Analyzer( */ objec

[GitHub] spark pull request: [SPARK-12796] [SQL] Whole stage codegen

2016-01-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10735#issuecomment-171196008 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-12796] [SQL] Whole stage codegen

2016-01-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10735#issuecomment-171196003 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-12796] [SQL] Whole stage codegen

2016-01-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10735#issuecomment-171195995 **[Test build #49298 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49298/consoleFull)** for PR 10735 at commit [`f05524c`](https://g

[GitHub] spark pull request: [SPARK-12610][SQL][WIP] Add Anti join operator...

2016-01-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10563#issuecomment-171195484 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-12610][SQL][WIP] Add Anti join operator...

2016-01-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10563#issuecomment-171195482 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-12789]Support order by index

2016-01-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10731#issuecomment-171195513 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-12796] [SQL] Whole stage codegen

2016-01-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10735#issuecomment-171195494 **[Test build #49298 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49298/consoleFull)** for PR 10735 at commit [`f05524c`](https://gi

[GitHub] spark pull request: [SPARK-12789]Support order by index

2016-01-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10731#issuecomment-171195516 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-12789]Support order by index

2016-01-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10731#issuecomment-171195234 **[Test build #49292 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49292/consoleFull)** for PR 10731 at commit [`b72547b`](https://g

[GitHub] spark pull request: [SPARK-12692][BUILD]Enforce style checking abo...

2016-01-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10736#issuecomment-171195115 **[Test build #49301 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49301/consoleFull)** for PR 10736 at commit [`44b3698`](https://gi

[GitHub] spark pull request: [SPARK-12610][SQL][WIP] Add Anti join operator...

2016-01-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10563#issuecomment-171194947 **[Test build #49293 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49293/consoleFull)** for PR 10563 at commit [`2a29e56`](https://g

[GitHub] spark pull request: [SPARK-9297][SQL] Add covar_pop and covar_samp

2016-01-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10029#issuecomment-171193912 **[Test build #49300 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49300/consoleFull)** for PR 10029 at commit [`832db06`](https://gi

[GitHub] spark pull request: [SPARK-12705] [SQL] AnalysisException: Sorting...

2016-01-12 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/10678#discussion_r49556422 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -73,6 +74,7 @@ class Analyzer( ResolveGroup

[GitHub] spark pull request: [SPARK-12692][BUILD]Enforce style checking abo...

2016-01-12 Thread sarutak
GitHub user sarutak opened a pull request: https://github.com/apache/spark/pull/10736 [SPARK-12692][BUILD]Enforce style checking about white space before comma We have removed all of white spaces before comma from code so let's enforce style checking. You can merge this pull reques

[GitHub] spark pull request: [SPARK-9297][SQL] Add covar_pop and covar_samp

2016-01-12 Thread viirya
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/10029#issuecomment-171191441 @davies Understood. Since the time to come out a better codegen version for this is not sure, can we merge this first in? --- If your project is set up for it, you can

[GitHub] spark pull request: [SPARK-12791][SQL] Simplify CaseWhen by breaki...

2016-01-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10734#issuecomment-171191208 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-12791][SQL] Simplify CaseWhen by breaki...

2016-01-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10734#issuecomment-171191211 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-12705] [SQL] AnalysisException: Sorting...

2016-01-12 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/10678#discussion_r49556199 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -73,6 +74,7 @@ class Analyzer( ResolveGroupingA

[GitHub] spark pull request: [SPARK-12791][SQL] Simplify CaseWhen by breaki...

2016-01-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10734#issuecomment-171191106 **[Test build #49297 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49297/consoleFull)** for PR 10734 at commit [`02caff5`](https://g

[GitHub] spark pull request: [SPARK-12791][SQL] Simplify CaseWhen by breaki...

2016-01-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10734#issuecomment-171190598 **[Test build #49299 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49299/consoleFull)** for PR 10734 at commit [`8181c3a`](https://gi

[GitHub] spark pull request: [SPARK-12796] [SQL] Whole stage codegen

2016-01-12 Thread davies
GitHub user davies opened a pull request: https://github.com/apache/spark/pull/10735 [SPARK-12796] [SQL] Whole stage codegen This is the initial work for whole stage codegen, it support Projection/Filter/Range, we will continue work on this to support more physical operators.

[GitHub] spark pull request: [SPARK-12791][SQL] Simplify CaseWhen by breaki...

2016-01-12 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/10734#issuecomment-171189195 cc @cloud-fan --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-9297][SQL] Add covar_pop and covar_samp

2016-01-12 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/10029#discussion_r49555926 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Covariance.scala --- @@ -0,0 +1,205 @@ +/* + * Licensed to

[GitHub] spark pull request: [SPARK-9297][SQL] Add covar_pop and covar_samp

2016-01-12 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/10029#discussion_r49555900 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Covariance.scala --- @@ -0,0 +1,205 @@ +/* + * Licensed to

[GitHub] spark pull request: [SPARK-9297][SQL] Add covar_pop and covar_samp

2016-01-12 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/10029#discussion_r49555736 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Covariance.scala --- @@ -0,0 +1,205 @@ +/* + * Licensed to

[GitHub] spark pull request: [SPARK-9297][SQL] Add covar_pop and covar_samp

2016-01-12 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/10029#issuecomment-171184876 @viirya One question is that: we are moving to do more codegen staff (whole stage codegen), but the ImperativeAggregate can't support that, not sure will we do another c

[GitHub] spark pull request: [SPARK-12705] [SQL] AnalysisException: Sorting...

2016-01-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10678#issuecomment-171184333 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-12705] [SQL] AnalysisException: Sorting...

2016-01-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10678#issuecomment-171184337 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-12705] [SQL] AnalysisException: Sorting...

2016-01-12 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/10678#issuecomment-171183014 In this update, the code changes are trying to extend the existing support for the following scenario: ```sort by attributes that are not present in the SELECT claus

[GitHub] spark pull request: SPARK-12692][BUILD][SQL] Scala style: Fix the ...

2016-01-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/10732 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request: [SPARK-12791][SQL] Simplify CaseWhen by breaki...

2016-01-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10734#issuecomment-171182889 **[Test build #49297 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49297/consoleFull)** for PR 10734 at commit [`02caff5`](https://gi

[GitHub] spark pull request: SPARK-12692][BUILD][SQL] Scala style: Fix the ...

2016-01-12 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/10732#issuecomment-171182648 Thanks - I've merged this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have t

[GitHub] spark pull request: SPARK-12692][BUILD][SQL] Scala style: Fix the ...

2016-01-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10732#issuecomment-171182625 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: SPARK-12692][BUILD][SQL] Scala style: Fix the ...

2016-01-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10732#issuecomment-171182626 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: SPARK-12692][BUILD][SQL] Scala style: Fix the ...

2016-01-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10732#issuecomment-171182451 **[Test build #49290 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49290/consoleFull)** for PR 10732 at commit [`13ccbfa`](https://g

[GitHub] spark pull request: [SPARK-9297][SQL] Add covar_pop and covar_samp

2016-01-12 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/10029#discussion_r49555196 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Covariance.scala --- @@ -0,0 +1,205 @@ +/* + * Licensed to

[GitHub] spark pull request: [SPARK-9297][SQL] Add covar_pop and covar_samp

2016-01-12 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/10029#discussion_r49554701 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Covariance.scala --- @@ -0,0 +1,205 @@ +/* + * Licensed to

[GitHub] spark pull request: [SPARK-9297][SQL] Add covar_pop and covar_samp

2016-01-12 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/10029#discussion_r49554635 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Covariance.scala --- @@ -0,0 +1,205 @@ +/* + * Licensed to

[GitHub] spark pull request: [Spark-8426] [scheduler] enhance blacklist mec...

2016-01-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8760#issuecomment-171180163 **[Test build #49294 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49294/consoleFull)** for PR 8760 at commit [`25a7c6f`](https://gith

[GitHub] spark pull request: [SPARK-9297][SQL] Add covar_pop and covar_samp

2016-01-12 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/10029#discussion_r49554615 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Covariance.scala --- @@ -0,0 +1,205 @@ +/* + * Licensed to

[GitHub] spark pull request: [SPARK-12756][SQL] use hash expression in Exch...

2016-01-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10703#issuecomment-171179476 **[Test build #49295 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49295/consoleFull)** for PR 10703 at commit [`1c2d42b`](https://gi

[GitHub] spark pull request: [SPARK-9297][SQL] Add covar_pop and covar_samp

2016-01-12 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/10029#discussion_r49554363 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Covariance.scala --- @@ -0,0 +1,205 @@ +/* + * Licensed to

[GitHub] spark pull request: [SPARK-12558][SQL][WIP] AnalysisException when...

2016-01-12 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/10520#issuecomment-171177410 Great. Thank you! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featu

[GitHub] spark pull request: [SPARK-12558][SQL][WIP] AnalysisException when...

2016-01-12 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/10520#discussion_r49553700 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveUDFSuite.scala --- @@ -350,6 +350,13 @@ class HiveUDFSuite extends QueryTest with T

[GitHub] spark pull request: [SPARK-12558][SQL][WIP] AnalysisException when...

2016-01-12 Thread dilipbiswal
Github user dilipbiswal commented on the pull request: https://github.com/apache/spark/pull/10520#issuecomment-171177209 @yhuai I will make the change in a follow up PR re-using the same JIRA. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request: [SPARK-12558][SQL][WIP] AnalysisException when...

2016-01-12 Thread dilipbiswal
Github user dilipbiswal commented on the pull request: https://github.com/apache/spark/pull/10520#issuecomment-171177077 @yhuai Thank you very much !! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does n

[GitHub] spark pull request: [SPARK-12558][SQL][WIP] AnalysisException when...

2016-01-12 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/10520#discussion_r49553587 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveUDFSuite.scala --- @@ -350,6 +350,13 @@ class HiveUDFSuite extends QueryTest with T

[GitHub] spark pull request: [SPARK-12558][SQL][WIP] AnalysisException when...

2016-01-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/10520 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request: [SPARK-12558][SQL][WIP] AnalysisException when...

2016-01-12 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/10520#issuecomment-171176382 LGTM. Merging to master and branch 1.6. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project do

[GitHub] spark pull request: [SPARK-12558][SQL][WIP] AnalysisException when...

2016-01-12 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/10520#issuecomment-171176359 Actually, let me change the title while merging it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If you

[GitHub] spark pull request: [SPARK-12558][SQL][WIP] AnalysisException when...

2016-01-12 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/10520#issuecomment-171176251 Can you remove the `WIP` from the title? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-12756][SQL] use hash expression in Exch...

2016-01-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10703#issuecomment-171175930 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-12756][SQL] use hash expression in Exch...

2016-01-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10703#issuecomment-171175931 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-12756][SQL] use hash expression in Exch...

2016-01-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10703#issuecomment-171175832 **[Test build #49288 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49288/consoleFull)** for PR 10703 at commit [`005c1db`](https://g

[GitHub] spark pull request: [SPARK-12789]Support order by index

2016-01-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10731#issuecomment-171175160 **[Test build #49292 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49292/consoleFull)** for PR 10731 at commit [`b72547b`](https://gi

[GitHub] spark pull request: [SPARK-12610][SQL][WIP] Add Anti join operator...

2016-01-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10563#issuecomment-171172724 **[Test build #49293 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49293/consoleFull)** for PR 10563 at commit [`2a29e56`](https://gi

[GitHub] spark pull request: [SPARK-12149] [Web UI] Executor UI improvement...

2016-01-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10154#issuecomment-171169376 **[Test build #49291 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49291/consoleFull)** for PR 10154 at commit [`70ab748`](https://gi

[GitHub] spark pull request: [SPARK-12443][SQL] encoderFor should support D...

2016-01-12 Thread viirya
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/10399#issuecomment-171169128 ping @rxin @JoshRosen --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-9297][SQL] Add covar_pop and covar_samp

2016-01-12 Thread viirya
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/10029#issuecomment-171169101 ping @davies --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-12149] [Web UI] Executor UI improvement...

2016-01-12 Thread ajbozarth
Github user ajbozarth commented on the pull request: https://github.com/apache/spark/pull/10154#issuecomment-171168930 Here's a small screen shot of the change (note I changed GC threshold to 1% for this example) https://cloud.githubusercontent.com/assets/13952758/12285584/7e9217c6

[GitHub] spark pull request: [SPARK-12689][SQL] Migrate DDL parsing to the ...

2016-01-12 Thread viirya
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/10723#issuecomment-171168853 Because SQLContext still uses DDLParser, looks like I can't simply remove `describeTable` command from DDLParser. So I can't gradually migrate these three commands in th

[GitHub] spark pull request: [SPARK-12149] [Web UI] Executor UI improvement...

2016-01-12 Thread ajbozarth
Github user ajbozarth commented on the pull request: https://github.com/apache/spark/pull/10154#issuecomment-171168341 @tgravescs I've added GC Time (in parens) to the Task Time column and added a tool tip explaining the coloring and what GC Time is. I agree these are probably good ad

[GitHub] spark pull request: [SPARK-12616] [SQL] Making Logical Operator `U...

2016-01-12 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/10577#discussion_r49551543 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/HiveTypeCoercion.scala --- @@ -200,41 +200,60 @@ object HiveTypeCoercion {

[GitHub] spark pull request: [SPARK-12616] [SQL] Making Logical Operator `U...

2016-01-12 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/10577#discussion_r49551474 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala --- @@ -189,6 +189,15 @@ trait CheckAnalysis {

[GitHub] spark pull request: [SPARK-12616] [SQL] Making Logical Operator `U...

2016-01-12 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/10577#discussion_r49551487 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicOperators.scala --- @@ -123,6 +115,39 @@ case class Except(left: L

[GitHub] spark pull request: SPARK-12692][BUILD][SQL] Scala style: Fix the ...

2016-01-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10732#issuecomment-171165543 **[Test build #49290 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49290/consoleFull)** for PR 10732 at commit [`13ccbfa`](https://gi

[GitHub] spark pull request: [SPARK-12791][SQL] Simplify CaseWhen by breaki...

2016-01-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10734#issuecomment-171159670 **[Test build #49289 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49289/consoleFull)** for PR 10734 at commit [`829c3ad`](https://g

[GitHub] spark pull request: [SPARK-12791][SQL] Simplify CaseWhen by breaki...

2016-01-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10734#issuecomment-171159772 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-12791][SQL] Simplify CaseWhen by breaki...

2016-01-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10734#issuecomment-171159766 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

  1   2   3   4   5   6   >