[GitHub] spark pull request: [SPARK-12832][MESOS] mesos scheduler respect a...

2016-02-11 Thread atongen
Github user atongen commented on the pull request: https://github.com/apache/spark/pull/10949#issuecomment-182913955 Pushed changes to address scalastyle test failures. Also, in order to run multiple dispatchers on the same mesos cluster, you should set

[GitHub] spark pull request: [SPARK-13295] [ ML, MLlib ] AFTSurvivalRegress...

2016-02-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11179#issuecomment-183185609 **[Test build #51170 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51170/consoleFull)** for PR 11179 at commit

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

2016-02-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11051#issuecomment-183013147 **[Test build #51120 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51120/consoleFull)** for PR 11051 at commit

[GitHub] spark pull request: [SPARK-6166] Limit number of in flight outboun...

2016-02-11 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/10838#discussion_r52653425 --- Diff: docs/configuration.md --- @@ -392,6 +392,16 @@ Apart from these, the following properties are also available, and may be useful

[GitHub] spark pull request: [SPARK-12543] [SPARK-4226] [SQL] Subquery in e...

2016-02-11 Thread hvanhovell
Github user hvanhovell commented on the pull request: https://github.com/apache/spark/pull/10706#issuecomment-183033654 @davies sure, no problem. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-10521][SQL] Utilize Docker for test DB2...

2016-02-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9893#issuecomment-183033927 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-10521][SQL] Utilize Docker for test DB2...

2016-02-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9893#issuecomment-183033924 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

2016-02-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/11051 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

2016-02-11 Thread hvanhovell
Github user hvanhovell commented on the pull request: https://github.com/apache/spark/pull/11051#issuecomment-183012725 @shaneknapp thanks for your help! Any idea what caused this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

2016-02-11 Thread shaneknapp
Github user shaneknapp commented on the pull request: https://github.com/apache/spark/pull/11051#issuecomment-183017267 the GHPRB plugin is finicky, obtuse and opaque in it's operations. i have no idea why it decided to not trigger, and the logs don't show anything. sorry...

[GitHub] spark pull request: [SPARK-10521][SQL] Utilize Docker for test DB2...

2016-02-11 Thread shaneknapp
Github user shaneknapp commented on the pull request: https://github.com/apache/spark/pull/9893#issuecomment-183021435 jenkins, test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-12177] [STREAMING] Update KafkaDStreams...

2016-02-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10953#issuecomment-183021465 **[Test build #51125 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51125/consoleFull)** for PR 10953 at commit

[GitHub] spark pull request: [SPARK-13279] Remove unnecessary duplicate che...

2016-02-11 Thread kayousterhout
Github user kayousterhout commented on a diff in the pull request: https://github.com/apache/spark/pull/11167#discussion_r52653078 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala --- @@ -177,13 +177,15 @@ private[spark] class TaskSetManager(

[GitHub] spark pull request: [SPARK-10521][SQL] Utilize Docker for test DB2...

2016-02-11 Thread shaneknapp
Github user shaneknapp commented on the pull request: https://github.com/apache/spark/pull/9893#issuecomment-183034983 argh git timeout. jenkins, test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13279] Remove unnecessary duplicate che...

2016-02-11 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/11167#issuecomment-183010519 OK, but the JIRA describes a deadlock, or at least that's how it reads. @kayousterhout does that sound right? it sounds OK. --- If your project is set up for it,

[GitHub] spark pull request: [SPARK-12705] [SQL] push missing attributes fo...

2016-02-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11153#issuecomment-183013099 **[Test build #51124 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51124/consoleFull)** for PR 11153 at commit

[GitHub] spark pull request: [SPARK-12177] [STREAMING] Update KafkaDStreams...

2016-02-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10953#issuecomment-183032502 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12177] [STREAMING] Update KafkaDStreams...

2016-02-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10953#issuecomment-183032500 Build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-12177] [STREAMING] Update KafkaDStreams...

2016-02-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10953#issuecomment-183032489 **[Test build #51125 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51125/consoleFull)** for PR 10953 at commit

[GitHub] spark pull request: Added missing utility method

2016-02-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11173#issuecomment-183044967 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13279] Remove unnecessary duplicate che...

2016-02-11 Thread sitalkedia
Github user sitalkedia commented on the pull request: https://github.com/apache/spark/pull/11167#issuecomment-183011444 Sorry, I did not make it clear. Its not a deadlock, the lock is held for a very long time. --- If your project is set up for it, you can reply to this email and

[GitHub] spark pull request: [SPARK-12543] [SPARK-4226] [SQL] Subquery in e...

2016-02-11 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/10706#issuecomment-183013945 @hvanhovell Can you help to look at this one? I'd like to split this out as small PRs, hopefully we can merge part of them into 2.0. --- If your project is set up for

[GitHub] spark pull request: [SPARK-6166] Limit number of in flight outboun...

2016-02-11 Thread zsxwing
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/10838#issuecomment-183027600 @redsanket most of my comments are minor. Otherwise LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: [SPARK-5682][Core] Add encrypted shuffle in sp...

2016-02-11 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/8880#discussion_r52656379 --- Diff: core/src/test/scala/org/apache/spark/crypto/ShuffleEncryptionSuite.scala --- @@ -0,0 +1,107 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-13279] Remove unnecessary duplicate che...

2016-02-11 Thread sitalkedia
Github user sitalkedia commented on the pull request: https://github.com/apache/spark/pull/11167#issuecomment-183034458 Thanks @kayousterhout. I updated the comment accordingly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: [SPARK-5682][Core] Add encrypted shuffle in sp...

2016-02-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8880#issuecomment-183039809 **[Test build #51121 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51121/consoleFull)** for PR 8880 at commit

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

2016-02-11 Thread hvanhovell
Github user hvanhovell commented on the pull request: https://github.com/apache/spark/pull/11051#issuecomment-183047747 Merging to master. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-12630][Python][MLlib][DOC] Update param...

2016-02-11 Thread BryanCutler
Github user BryanCutler commented on a diff in the pull request: https://github.com/apache/spark/pull/10598#discussion_r52660909 --- Diff: python/pyspark/mllib/classification.py --- @@ -272,37 +275,42 @@ def train(cls, data, iterations=100, step=1.0, miniBatchFraction=1.0,

[GitHub] spark pull request: [SPARK-13279] Remove unnecessary duplicate che...

2016-02-11 Thread kayousterhout
Github user kayousterhout commented on the pull request: https://github.com/apache/spark/pull/11167#issuecomment-183022065 Thanks for fixing this! You're right that the change you linked to is broken; when I removed the readding parameter, I should have killed the if-statement. I

[GitHub] spark pull request: [SPARK-6166] Limit number of in flight outboun...

2016-02-11 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/10838#discussion_r52653512 --- Diff: core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala --- @@ -47,6 +47,7 @@ import org.apache.spark.util.Utils *

[GitHub] spark pull request: [SPARK-6166] Limit number of in flight outboun...

2016-02-11 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/10838#discussion_r52653442 --- Diff: core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala --- @@ -169,7 +176,10 @@ final class ShuffleBlockFetcherIterator(

[GitHub] spark pull request: [SPARK-5682][Core] Add encrypted shuffle in sp...

2016-02-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8880#issuecomment-183040354 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-5682][Core] Add encrypted shuffle in sp...

2016-02-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8880#issuecomment-183040357 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-10521][SQL] Utilize Docker for test DB2...

2016-02-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9893#issuecomment-183043137 **[Test build #51127 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51127/consoleFull)** for PR 9893 at commit

[GitHub] spark pull request: [SPARK-13277][SQL] ANTLR ignores other rule us...

2016-02-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/11168 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: Added missing utility method

2016-02-11 Thread hvanhovell
Github user hvanhovell commented on the pull request: https://github.com/apache/spark/pull/11173#issuecomment-183046223 @spektom the title is not really informative. Could you improve the title, and prepend it with the relevant JIRA ticket (please create one if you haven't done that

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

2016-02-11 Thread hvanhovell
Github user hvanhovell commented on the pull request: https://github.com/apache/spark/pull/11051#issuecomment-183047397 @shaneknapp Thanks for checking... The GHPRB just works in mysterious ways... --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: [SPARK-12705] [SQL] push missing attributes fo...

2016-02-11 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/11153#discussion_r52648798 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -572,98 +572,64 @@ class Analyzer( // Skip

[GitHub] spark pull request: [SPARK-11714][Mesos] Make Spark on Mesos honor...

2016-02-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11157#issuecomment-183012282 **[Test build #51123 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51123/consoleFull)** for PR 11157 at commit

[GitHub] spark pull request: [SPARK-13139][SQL][WIP] Create native DDL comm...

2016-02-11 Thread hvanhovell
Github user hvanhovell commented on the pull request: https://github.com/apache/spark/pull/11048#issuecomment-183012248 @viirya I have made an initial pass. This PR is large enough as it is, lets not more commands to it. --- If your project is set up for it, you can reply to this

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

2016-02-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11051#issuecomment-183013527 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

2016-02-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11051#issuecomment-183013525 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-5682][Core] Add encrypted shuffle in sp...

2016-02-11 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/8880#discussion_r52651983 --- Diff: core/src/main/scala/org/apache/spark/crypto/CryptoStreamUtils.scala --- @@ -0,0 +1,98 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request: [SPARK-6166] Limit number of in flight outboun...

2016-02-11 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/10838#discussion_r52654346 --- Diff: core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala --- @@ -153,9 +158,11 @@ final class ShuffleBlockFetcherIterator(

[GitHub] spark pull request: [SPARK-5682][Core] Add encrypted shuffle in sp...

2016-02-11 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/8880#discussion_r52656157 --- Diff: core/src/test/scala/org/apache/spark/crypto/ShuffleEncryptionSuite.scala --- @@ -0,0 +1,107 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: Added missing utility method

2016-02-11 Thread spektom
GitHub user spektom opened a pull request: https://github.com/apache/spark/pull/11173 Added missing utility method Without this method it's impossible to create Kafka direct stream without offsets but with custom message handler function. You can merge this pull request into a Git

[GitHub] spark pull request: [SPARK-13277][SQL] ANTLR ignores other rule us...

2016-02-11 Thread hvanhovell
Github user hvanhovell commented on the pull request: https://github.com/apache/spark/pull/11168#issuecomment-183044450 Merging to master. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-13149][SQL][FOLLOWUP]Make FileStreamSou...

2016-02-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11162#issuecomment-183044617 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13149][SQL][FOLLOWUP]Make FileStreamSou...

2016-02-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11162#issuecomment-183044614 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13149][SQL][FOLLOWUP]Make FileStreamSou...

2016-02-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11162#issuecomment-183044250 **[Test build #51122 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51122/consoleFull)** for PR 11162 at commit

[GitHub] spark pull request: [SPARK-12153][SPARK-7617][MLlib]add support of...

2016-02-11 Thread MLnick
Github user MLnick commented on a diff in the pull request: https://github.com/apache/spark/pull/10152#discussion_r52590418 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala --- @@ -76,6 +76,18 @@ class Word2Vec extends Serializable with Logging {

[GitHub] spark pull request: [SPARK-12915] [SQL] add SQL metrics for whole ...

2016-02-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11170#issuecomment-182824956 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11714][Mesos] Make Spark on Mesos honor...

2016-02-11 Thread skonto
Github user skonto commented on the pull request: https://github.com/apache/spark/pull/11157#issuecomment-182848295 Jenkins test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-13282][SQL] LogicalPlan toSql should ju...

2016-02-11 Thread rxin
GitHub user rxin opened a pull request: https://github.com/apache/spark/pull/11171 [SPARK-13282][SQL] LogicalPlan toSql should just return a String Rather than Option[String]. Previously we were using Option[String] and None to indicate the case when Spark fails to

[GitHub] spark pull request: [SPARK-13282][SQL] LogicalPlan toSql should ju...

2016-02-11 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/11171#issuecomment-182790954 cc @liancheng --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-12792][SPARKR] Refactor RRDD to support...

2016-02-11 Thread sun-rui
Github user sun-rui commented on the pull request: https://github.com/apache/spark/pull/10947#issuecomment-182836752 Jenkins, retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-12915] [SQL] add SQL metrics for whole ...

2016-02-11 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/11170#issuecomment-182791394 Can you document in the pull request description what gets added? For example, do we show cardinality for aggregations or joins? --- If your project is set up for it,

[GitHub] spark pull request: [Docs] Update cache()'s storage level to be co...

2016-02-11 Thread wjur
Github user wjur commented on the pull request: https://github.com/apache/spark/pull/11172#issuecomment-182810491 Please refer to https://github.com/wjur/spark/blob/wjur/caching_default_level/sql/core/src/main/scala/org/apache/spark/sql/execution/CacheManager.scala#L84 and to

[GitHub] spark pull request: [Docs] Update cache()'s storage level to be co...

2016-02-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11172#issuecomment-182810551 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13282][SQL] LogicalPlan toSql should ju...

2016-02-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11171#issuecomment-182821707 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13282][SQL] LogicalPlan toSql should ju...

2016-02-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11171#issuecomment-182821712 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12915] [SQL] add SQL metrics for whole ...

2016-02-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11170#issuecomment-182824798 **[Test build #51092 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51092/consoleFull)** for PR 11170 at commit

[GitHub] spark pull request: [SPARK-12915] [SQL] add SQL metrics for whole ...

2016-02-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11170#issuecomment-182824957 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12792][SPARKR] Refactor RRDD to support...

2016-02-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10947#issuecomment-182846322 **[Test build #51094 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51094/consoleFull)** for PR 10947 at commit

[GitHub] spark pull request: [SPARK-12567][SQL] Add aes_{encrypt,decrypt} U...

2016-02-11 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/10527#discussion_r52597144 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/misc.scala --- @@ -442,3 +444,88 @@ case class PrintToStderr(child:

[GitHub] spark pull request: [SPARK-12567][SQL] Add aes_{encrypt,decrypt} U...

2016-02-11 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/10527#issuecomment-182851144 LGTM except some minor comments, thanks for working on it! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: [SPARK-12567][SQL] Add aes_{encrypt,decrypt} U...

2016-02-11 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/10527#issuecomment-182851174 LGTM except some minor comments, thanks for working on it! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: [SPARK-12567][SQL] Add aes_{encrypt,decrypt} U...

2016-02-11 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/10527#discussion_r52597354 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/MiscFunctionsSuite.scala --- @@ -132,4 +132,47 @@ class

[GitHub] spark pull request: [SPARK-11714][Mesos] Make Spark on Mesos honor...

2016-02-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11157#issuecomment-182853227 **[Test build #51095 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51095/consoleFull)** for PR 11157 at commit

[GitHub] spark pull request: [Docs] Update cache()'s storage level to be co...

2016-02-11 Thread wjur
GitHub user wjur opened a pull request: https://github.com/apache/spark/pull/11172 [Docs] Update cache()'s storage level to be consistent with the code The docs say that the default storage level is MEMORY_ONLY, but in fact it is MEMORY_AND_DISK. This commit fixes the

[GitHub] spark pull request: [SPARK-12567][SQL] Add aes_{encrypt,decrypt} U...

2016-02-11 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/10527#discussion_r52596991 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/misc.scala --- @@ -442,3 +444,88 @@ case class PrintToStderr(child:

[GitHub] spark pull request: [STREAMING][TEST] Fix flaky streaming.FailureS...

2016-02-11 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/11166#discussion_r52604381 --- Diff: streaming/src/test/scala/org/apache/spark/streaming/FailureSuite.scala --- @@ -43,6 +43,9 @@ class FailureSuite extends SparkFunSuite with

[GitHub] spark pull request: [SPARK-13148] [YARN] zero-keytab Oozie applica...

2016-02-11 Thread tgravescs
Github user tgravescs commented on the pull request: https://github.com/apache/spark/pull/11033#issuecomment-182879301 Sorry I'm still not clear on what you are trying to accomplish with this. Why do we need to use the HADOOP_TOKEN_FILE_LOCATION? oozie (running with proxy

[GitHub] spark pull request: [SPARK-13265][ML] Refactoring of basic ML impo...

2016-02-11 Thread yu-iskw
Github user yu-iskw commented on the pull request: https://github.com/apache/spark/pull/11151#issuecomment-182865831 cc @mengxr --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-13277][SQL] ANTLR ignores other rule us...

2016-02-11 Thread hvanhovell
Github user hvanhovell commented on the pull request: https://github.com/apache/spark/pull/11168#issuecomment-182870348 @viirya thanks for working on this. Do you have an idea what functionality was disabled? --- If your project is set up for it, you can reply to this email and have

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

2016-02-11 Thread jayadevanmurali
Github user jayadevanmurali commented on the pull request: https://github.com/apache/spark/pull/11051#issuecomment-182884877 @hvanhovell I think, you may comment "ok to test" for triggering the build --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark pull request: [SPARK-12982][SQL] Add table name validation i...

2016-02-11 Thread hvanhovell
Github user hvanhovell commented on the pull request: https://github.com/apache/spark/pull/11051#issuecomment-182863542 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [WebUI][SPARK-7889] HistoryServer updates UI f...

2016-02-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8#issuecomment-182916241 **[Test build #51105 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51105/consoleFull)** for PR 8 at commit

[GitHub] spark pull request: [SPARK-12962] [SQL] [PySpark] PySpark support ...

2016-02-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10876#issuecomment-182917382 **[Test build #51104 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51104/consoleFull)** for PR 10876 at commit

[GitHub] spark pull request: [SPARK-12811] [ML] Estimator for Generalized L...

2016-02-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11136#issuecomment-182917919 **[Test build #51101 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51101/consoleFull)** for PR 11136 at commit

[GitHub] spark pull request: [SPARK-11714][Mesos] Make Spark on Mesos honor...

2016-02-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11157#issuecomment-182919085 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13139][SQL][WIP] Create native DDL comm...

2016-02-11 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/11048#discussion_r52620118 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/SparkQlSuite.scala --- @@ -0,0 +1,149 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-12832][MESOS] mesos scheduler respect a...

2016-02-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10949#issuecomment-182935192 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...

2016-02-11 Thread shaneknapp
Github user shaneknapp commented on the pull request: https://github.com/apache/spark/pull/11100#issuecomment-182936788 jenkins, test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-11714][Mesos] Make Spark on Mesos honor...

2016-02-11 Thread shaneknapp
Github user shaneknapp commented on the pull request: https://github.com/apache/spark/pull/11157#issuecomment-182936474 jenkins, test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-12811] [ML] Estimator for Generalized L...

2016-02-11 Thread shaneknapp
Github user shaneknapp commented on the pull request: https://github.com/apache/spark/pull/11136#issuecomment-182936359 jenkins, test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-11701][SPARK-13054] dynamic allocation ...

2016-02-11 Thread shaneknapp
Github user shaneknapp commented on the pull request: https://github.com/apache/spark/pull/10951#issuecomment-182936914 jenkins, test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-8171] [Web UI] Simulated infinite scrol...

2016-02-11 Thread ajbozarth
Github user ajbozarth commented on the pull request: https://github.com/apache/spark/pull/10910#issuecomment-182935831 @tgravescs thanks for all the help on those other PRs, mind taking a look at this one? --- If your project is set up for it, you can reply to this email and have

[GitHub] spark pull request: [SPARK-11701][SPARK-13054] dynamic allocation ...

2016-02-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10951#issuecomment-182935187 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...

2016-02-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11100#issuecomment-182935193 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [WebUI][SPARK-7889] HistoryServer updates UI f...

2016-02-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8#issuecomment-182935190 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-11714][Mesos] Make Spark on Mesos honor...

2016-02-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11157#issuecomment-182935194 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-11701][SPARK-13054] dynamic allocation ...

2016-02-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10951#issuecomment-182935195 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13139][SQL][WIP] Create native DDL comm...

2016-02-11 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/11048#discussion_r52622161 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkQl.scala --- @@ -62,6 +66,458 @@ private[sql] class SparkQl(conf: ParserConf =

[GitHub] spark pull request: [SPARK-11714][Mesos] Make Spark on Mesos honor...

2016-02-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11157#issuecomment-182935183 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-6166] Limit number of in flight outboun...

2016-02-11 Thread tgravescs
Github user tgravescs commented on the pull request: https://github.com/apache/spark/pull/10838#issuecomment-182940338 Jenkins, test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [WebUI][SPARK-7889] HistoryServer updates UI f...

2016-02-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8#issuecomment-182943275 **[Test build #51117 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51117/consoleFull)** for PR 8 at commit

[GitHub] spark pull request: [SPARK-6166] Limit number of in flight outboun...

2016-02-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10838#issuecomment-182943209 **[Test build #51118 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51118/consoleFull)** for PR 10838 at commit

[GitHub] spark pull request: [SPARK-13139][SQL][WIP] Create native DDL comm...

2016-02-11 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/11048#discussion_r52616927 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/commands.scala --- @@ -418,3 +419,312 @@ case class SetDatabaseCommand(databaseName:

[GitHub] spark pull request: [WebUI][SPARK-7889] HistoryServer updates UI f...

2016-02-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8#issuecomment-182918248 Test FAILed. Refer to this link for build results (access rights to CI server needed):

<    1   2   3   4   5   6   7   >