[GitHub] spark pull request: [SPARK-13279] Remove unnecessary duplicate che...

2016-02-11 Thread kayousterhout
Github user kayousterhout commented on the pull request: https://github.com/apache/spark/pull/11167#issuecomment-183083738 That would be great thanks!! Sorry for the trouble caused by my rushed merging! --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark pull request: [SPARK-12503][SPARK-12505] Limit pushdown in U...

2016-02-11 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/11121#issuecomment-183085926 I've updated this to disable the optimizer rule for now (it's still tested in the LimitPushdownSuite, though). --- If your project is set up for it, you can reply

[GitHub] spark pull request: [SPARK-13011] K-means wrapper in SparkR

2016-02-11 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/11124#discussion_r52681503 --- Diff: R/pkg/R/mllib.R --- @@ -126,3 +126,27 @@ setMethod("summary", signature(object = "PipelineModel"), return(list(coefficients =

[GitHub] spark pull request: [SPARK-13277][BUILD] Follow-up ANTLR warnings ...

2016-02-11 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/11174#discussion_r52681432 --- Diff: project/SparkBuild.scala --- @@ -434,8 +434,11 @@ object Catalyst { // Generate the parser. antlr.process --- End diff

[GitHub] spark pull request: [SPARK-13277][BUILD] Follow-up ANTLR warnings ...

2016-02-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11174#issuecomment-18309 **[Test build #51135 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51135/consoleFull)** for PR 11174 at commit

[GitHub] spark pull request: [SPARK-13011] K-means wrapper in SparkR

2016-02-11 Thread yinxusen
Github user yinxusen commented on the pull request: https://github.com/apache/spark/pull/11124#issuecomment-183092811 @mengxr I am on my way implementing `summary`. The summary of `stats:kmeans` contains "cluster" "centers" "totss""withinss" "tot.withinss"

[GitHub] spark pull request: [Spark-8426] [scheduler] enhance blacklist mec...

2016-02-11 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/8760#discussion_r52682469 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocator.scala --- @@ -21,6 +21,7 @@ import java.util.Collections import

[GitHub] spark pull request: SPARK-11741 Process doctests using TextTestRun...

2016-02-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9710#issuecomment-183093869 **[Test build #51137 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51137/consoleFull)** for PR 9710 at commit

[GitHub] spark pull request: [SPARK-12757][WIP] Use reference counting to p...

2016-02-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10705#issuecomment-183097131 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12757][WIP] Use reference counting to p...

2016-02-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10705#issuecomment-183097126 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13257] [Improvement] Refine naive Bayes...

2016-02-11 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/11125#discussion_r52684381 --- Diff: examples/src/main/python/mllib/naive_bayes_example.py --- @@ -50,8 +61,17 @@ def parseLine(line): # Make prediction and test accuracy.

[GitHub] spark pull request: [SPARK-13257] [Improvement] Refine naive Bayes...

2016-02-11 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/11125#discussion_r52684378 --- Diff: examples/src/main/python/mllib/naive_bayes_example.py --- @@ -50,8 +61,17 @@ def parseLine(line): # Make prediction and test accuracy.

[GitHub] spark pull request: [SPARK-13257] [Improvement] Refine naive Bayes...

2016-02-11 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/11125#discussion_r52684369 --- Diff: examples/src/main/python/mllib/naive_bayes_example.py --- @@ -38,8 +45,12 @@ def parseLine(line): sc =

[GitHub] spark pull request: [SPARK-13257] [Improvement] Refine naive Bayes...

2016-02-11 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/11125#discussion_r52684376 --- Diff: examples/src/main/python/mllib/naive_bayes_example.py --- @@ -50,8 +61,17 @@ def parseLine(line): # Make prediction and test accuracy.

[GitHub] spark pull request: [SPARK-13257] [Improvement] Refine naive Bayes...

2016-02-11 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/11125#discussion_r52684370 --- Diff: examples/src/main/python/mllib/naive_bayes_example.py --- @@ -50,8 +61,17 @@ def parseLine(line): # Make prediction and test accuracy.

[GitHub] spark pull request: [SPARK-13016] [Documentation] Replace example ...

2016-02-11 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/11132#issuecomment-183099445 @yinxusen Could you help review this PR? Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13017][Docs] Replace example code in ml...

2016-02-11 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/11142#issuecomment-183098771 @yinxusen Could you help review this PR? Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13015][Docs] Replace example code in ml...

2016-02-11 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/11128#issuecomment-183101195 cc @yinxusen --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-13018][Docs] Replace example code in ml...

2016-02-11 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/11126#issuecomment-183101335 cc @yinxusen --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-13017][Docs] Replace example code in ml...

2016-02-11 Thread yinxusen
Github user yinxusen commented on the pull request: https://github.com/apache/spark/pull/11142#issuecomment-183100479 @mengxr Don't worry, I'll review all of the replace code PRs. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark pull request: [SPARK-12915] [SQL] add SQL metrics of numOutp...

2016-02-11 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/11170#issuecomment-183105465 Sorry I'm still not getting the picture. Can you just paste a screenshot for the metrics? --- If your project is set up for it, you can reply to this email and have

[GitHub] spark pull request: [SPARK-13018][Docs] Replace example code in ml...

2016-02-11 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/11126#issuecomment-183105525 @keypointt @yinxusen Could you start from this PR first and then other longer ones? @keypointt is new to Spark development. Starting from small ones could avoid

[GitHub] spark pull request: [SPARK-13015][Docs] Replace example code in ml...

2016-02-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11128#issuecomment-183106640 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13019][Docs] Replace example code in ml...

2016-02-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11108#issuecomment-183108594 **[Test build #51145 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51145/consoleFull)** for PR 11108 at commit

[GitHub] spark pull request: [SPARK-13019][Docs] Replace example code in ml...

2016-02-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11108#issuecomment-183108603 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13019][Docs] Replace example code in ml...

2016-02-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11108#issuecomment-183108605 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13047][PYSPARK][ML] Pyspark Params.hasP...

2016-02-11 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/10962#discussion_r52686031 --- Diff: python/pyspark/ml/param/__init__.py --- @@ -156,9 +156,16 @@ def hasParam(self, paramName): """ Tests whether this

[GitHub] spark pull request: [SPARK-13016] [Documentation] Replace example ...

2016-02-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11132#issuecomment-183111355 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13016] [Documentation] Replace example ...

2016-02-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11132#issuecomment-183111348 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: SPARK-11741 Process doctests using TextTestRun...

2016-02-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9710#issuecomment-183112655 **[Test build #51137 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51137/consoleFull)** for PR 9710 at commit

[GitHub] spark pull request: [SPARK-13018][Docs] Replace example code in ml...

2016-02-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11126#issuecomment-183113635 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13018][Docs] Replace example code in ml...

2016-02-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11126#issuecomment-183113637 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13037][ML][PySpark] PySpark ml.recommen...

2016-02-11 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/11044#issuecomment-183114726 Merged into master. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [Minor] [ML] [PySpark] Cleanup test cases of c...

2016-02-11 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/10975#issuecomment-183116621 Not by design, we just don't have excellent test coverage ... LGTM. Merged into master. Thanks! --- If your project is set up for it, you can reply to this

[GitHub] spark pull request: [SPARK-13154][PYTHON] Add linting for pydocs

2016-02-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11109#issuecomment-183115763 **[Test build #51148 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51148/consoleFull)** for PR 11109 at commit

[GitHub] spark pull request: [SPARK-12757][WIP] Use reference counting to p...

2016-02-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10705#issuecomment-183058638 **[Test build #51128 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51128/consoleFull)** for PR 10705 at commit

[GitHub] spark pull request: [SPARK-13277][SQL] ANTLR ignores other rule us...

2016-02-11 Thread hvanhovell
Github user hvanhovell commented on the pull request: https://github.com/apache/spark/pull/11168#issuecomment-183066436 We could add a unit test for this specific case. But I am also looking for a way to treat these warnings as compile errors; which would be a lot better. --- If

[GitHub] spark pull request: [SPARK-6166] Limit number of in flight outboun...

2016-02-11 Thread zsxwing
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/10838#issuecomment-183072553 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-13154][PYTHON] Add linting for pydocs

2016-02-11 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/11109#issuecomment-183081880 @holdenk I made one pass. I think it is not necessary to verify the links because the PR author might not be responsible for dead links. Only minor comments other than

[GitHub] spark pull request: [SPARK-12757][WIP] Use reference counting to p...

2016-02-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10705#issuecomment-183084115 **[Test build #51132 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51132/consoleFull)** for PR 10705 at commit

[GitHub] spark pull request: [SPARK-13279] Remove unnecessary duplicate che...

2016-02-11 Thread sitalkedia
GitHub user sitalkedia opened a pull request: https://github.com/apache/spark/pull/11175 [SPARK-13279] Remove unnecessary duplicate check in addPendingTask fu… …nction You can merge this pull request into a Git repository by running: $ git pull

[GitHub] spark pull request: [SPARK-12630][Python][MLlib][DOC] Update param...

2016-02-11 Thread BryanCutler
Github user BryanCutler commented on a diff in the pull request: https://github.com/apache/spark/pull/10598#discussion_r52680824 --- Diff: python/pyspark/mllib/classification.py --- @@ -272,37 +275,42 @@ def train(cls, data, iterations=100, step=1.0, miniBatchFraction=1.0,

[GitHub] spark pull request: [SPARK-12705] [SQL] push missing attributes fo...

2016-02-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11153#issuecomment-183057571 **[Test build #51124 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51124/consoleFull)** for PR 11153 at commit

[GitHub] spark pull request: [SPARK-6166] Limit number of in flight outboun...

2016-02-11 Thread redsanket
Github user redsanket commented on the pull request: https://github.com/apache/spark/pull/10838#issuecomment-183063914 @zsxwing addressed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-6166] Limit number of in flight outboun...

2016-02-11 Thread zsxwing
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/10838#issuecomment-183065836 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-6166] Limit number of in flight outboun...

2016-02-11 Thread zsxwing
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/10838#issuecomment-183065989 LGTM. will merge this one once the tests pass. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13279] Remove unnecessary duplicate che...

2016-02-11 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/11167#issuecomment-183066743 I reverted this since it hasn't passed tests yet. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13279] Remove unnecessary duplicate che...

2016-02-11 Thread kayousterhout
Github user kayousterhout commented on the pull request: https://github.com/apache/spark/pull/11167#issuecomment-183066629 I just merged this but then realized Jenkins hadn't run yet... reverted the pushed version but will re-merge when Jenkins passes --- If your project is set up

[GitHub] spark pull request: [SPARK-6166] Limit number of in flight outboun...

2016-02-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10838#issuecomment-183079473 **[Test build #51130 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51130/consoleFull)** for PR 10838 at commit

[GitHub] spark pull request: [SPARK-13221] [SQL] Fixing GroupingSets when A...

2016-02-11 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/11100#discussion_r52675759 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -216,14 +216,36 @@ class Analyzer(

[GitHub] spark pull request: SPARK-12729 PhantomReferences to replace Final...

2016-02-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11140#issuecomment-183088846 **[Test build #51134 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51134/consoleFull)** for PR 11140 at commit

[GitHub] spark pull request: [SPARK-13145] [SQL] checkAnswer in SQL query s...

2016-02-11 Thread bomeng
Github user bomeng closed the pull request at: https://github.com/apache/spark/pull/11086 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-13145] [SQL] checkAnswer in SQL query s...

2016-02-11 Thread bomeng
Github user bomeng commented on the pull request: https://github.com/apache/spark/pull/11086#issuecomment-183090608 I did not notice that method and it should work fine for double type. My question is one absTol may not be enough for all the value types, for example, float and double

[GitHub] spark pull request: [SPARK-11714][Mesos] Make Spark on Mesos honor...

2016-02-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11157#issuecomment-183056161 **[Test build #51123 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51123/consoleFull)** for PR 11157 at commit

[GitHub] spark pull request: [SPARK-12705] [SQL] push missing attributes fo...

2016-02-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11153#issuecomment-183058007 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12705] [SQL] push missing attributes fo...

2016-02-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11153#issuecomment-183058010 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12757][WIP] Use reference counting to p...

2016-02-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10705#issuecomment-183058138 **[Test build #51128 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51128/consoleFull)** for PR 10705 at commit

[GitHub] spark pull request: [SPARK-13277][SQL] ANTLR ignores other rule us...

2016-02-11 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/11168#issuecomment-183061509 Can we add a unit test for this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-13279] Remove unnecessary duplicate che...

2016-02-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/11167 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-13277][SQL] ANTLR ignores other rule us...

2016-02-11 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/11168#issuecomment-183067115 Yup that's a great idea. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-10521][SQL] Utilize Docker for test DB2...

2016-02-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9893#issuecomment-183069508 **[Test build #51127 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51127/consoleFull)** for PR 9893 at commit

[GitHub] spark pull request: [SPARK-10521][SQL] Utilize Docker for test DB2...

2016-02-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9893#issuecomment-183069760 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-10521][SQL] Utilize Docker for test DB2...

2016-02-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9893#issuecomment-183069758 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-6166] Limit number of in flight outboun...

2016-02-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10838#issuecomment-183071483 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: SPARK-13277][BUILD] Follow-up ANTLR warnings a...

2016-02-11 Thread hvanhovell
GitHub user hvanhovell opened a pull request: https://github.com/apache/spark/pull/11174 SPARK-13277][BUILD] Follow-up ANTLR warnings are treated as build errors It is possible to create faulty but legal ANTLR grammars. ANTLR will produce warnings but also a valid compileable

[GitHub] spark pull request: [SPARK-13154][PYTHON] Add linting for pydocs

2016-02-11 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/11109#discussion_r52675406 --- Diff: dev/lint-python --- @@ -96,6 +98,32 @@ fi rm "$PEP8_REPORT_PATH" +# Check that the documentation builds acceptably, skip check

[GitHub] spark pull request: [SPARK-13154][PYTHON] Add linting for pydocs

2016-02-11 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/11109#discussion_r52675418 --- Diff: python/docs/Makefile --- @@ -2,7 +2,7 @@ # # You can set these variables from the command line. -SPHINXOPTS=

[GitHub] spark pull request: SPARK-13277][BUILD] Follow-up ANTLR warnings a...

2016-02-11 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/11174#issuecomment-18308 You can introduce a warning and see if the build fails as part of this pr. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request: [SPARK-13154][PYTHON] Add linting for pydocs

2016-02-11 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/11109#discussion_r52675400 --- Diff: dev/lint-python --- @@ -96,6 +98,32 @@ fi rm "$PEP8_REPORT_PATH" +# Check that the documentation builds acceptably, skip check

[GitHub] spark pull request: [SPARK-11714][Mesos] Make Spark on Mesos honor...

2016-02-11 Thread skonto
Github user skonto commented on the pull request: https://github.com/apache/spark/pull/11157#issuecomment-183087696 Need to fix the test. Multiple executors per slave need different handling. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request: [SPARK-13279] Remove unnecessary duplicate che...

2016-02-11 Thread kayousterhout
Github user kayousterhout commented on the pull request: https://github.com/apache/spark/pull/11175#issuecomment-183087801 Jenkins this is ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-13279] Remove unnecessary duplicate che...

2016-02-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11175#issuecomment-183087708 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13277][BUILD] Follow-up ANTLR warnings ...

2016-02-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11174#issuecomment-183088637 **[Test build #51133 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51133/consoleFull)** for PR 11174 at commit

[GitHub] spark pull request: [SPARK-13277][BUILD] Follow-up ANTLR warnings ...

2016-02-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11174#issuecomment-183088642 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13277][BUILD] Follow-up ANTLR warnings ...

2016-02-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11174#issuecomment-183088638 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [Spark-8426] [scheduler] enhance blacklist mec...

2016-02-11 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/8760#discussion_r52681082 --- Diff: core/src/main/scala/org/apache/spark/scheduler/BlacklistTracker.scala --- @@ -0,0 +1,253 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [Spark-8426] [scheduler] enhance blacklist mec...

2016-02-11 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/8760#discussion_r52681156 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala --- @@ -270,19 +260,11 @@ private[spark] class TaskSetManager(

[GitHub] spark pull request: [Spark-8426] [scheduler] enhance blacklist mec...

2016-02-11 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/8760#discussion_r52681359 --- Diff: core/src/test/scala/org/apache/spark/scheduler/BlacklistTrackerSuite.scala --- @@ -0,0 +1,226 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-13223] [ML] Add stratified sampling to ...

2016-02-11 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/11102#discussion_r52696689 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/StratifiedSampling.scala --- @@ -0,0 +1,129 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-13223] [ML] Add stratified sampling to ...

2016-02-11 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/11102#discussion_r52696695 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/StratifiedSampling.scala --- @@ -0,0 +1,129 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-13015][Docs] Replace example code in ml...

2016-02-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11128#issuecomment-183144534 **[Test build #51160 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51160/consoleFull)** for PR 11128 at commit

[GitHub] spark pull request: [SPARK-13223] [ML] Add stratified sampling to ...

2016-02-11 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/11102#discussion_r52696683 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/StratifiedSampling.scala --- @@ -0,0 +1,129 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-13223] [ML] Add stratified sampling to ...

2016-02-11 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/11102#discussion_r52696693 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/StratifiedSampling.scala --- @@ -0,0 +1,129 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-13223] [ML] Add stratified sampling to ...

2016-02-11 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/11102#discussion_r52696679 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/StratifiedSampling.scala --- @@ -0,0 +1,129 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-13223] [ML] Add stratified sampling to ...

2016-02-11 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/11102#discussion_r52696690 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/StratifiedSampling.scala --- @@ -0,0 +1,129 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-13223] [ML] Add stratified sampling to ...

2016-02-11 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/11102#discussion_r52696687 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/StratifiedSampling.scala --- @@ -0,0 +1,129 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-13015][Docs] Replace example code in ml...

2016-02-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11128#issuecomment-183144622 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13015][Docs] Replace example code in ml...

2016-02-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11128#issuecomment-183144619 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: SPARK-11741 Process doctests using TextTestRun...

2016-02-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9710#issuecomment-183145517 Build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: SPARK-11741 Process doctests using TextTestRun...

2016-02-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9710#issuecomment-183145388 **[Test build #51158 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51158/consoleFull)** for PR 9710 at commit

[GitHub] spark pull request: SPARK-11741 Process doctests using TextTestRun...

2016-02-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9710#issuecomment-183145521 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13257] [Improvement] Refine naive Bayes...

2016-02-11 Thread movelikeriver
Github user movelikeriver commented on a diff in the pull request: https://github.com/apache/spark/pull/11125#discussion_r52697401 --- Diff: examples/src/main/python/mllib/naive_bayes_example.py --- @@ -50,8 +61,17 @@ def parseLine(line): # Make prediction and test

[GitHub] spark pull request: [SPARK-13260][SQL] count(*) does not work with...

2016-02-11 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/11169#issuecomment-183146209 hm it seems like an important optimization that we wouldn't be able to do if we cannot skip parsing columns. --- If your project is set up for it, you can reply to this

[GitHub] spark pull request: [SPARK-13257] [Improvement] Refine naive Bayes...

2016-02-11 Thread movelikeriver
Github user movelikeriver commented on a diff in the pull request: https://github.com/apache/spark/pull/11125#discussion_r52697436 --- Diff: examples/src/main/python/mllib/naive_bayes_example.py --- @@ -50,8 +61,17 @@ def parseLine(line): # Make prediction and test

[GitHub] spark pull request: [SPARK-13257] [Improvement] Refine naive Bayes...

2016-02-11 Thread movelikeriver
Github user movelikeriver commented on a diff in the pull request: https://github.com/apache/spark/pull/11125#discussion_r52697460 --- Diff: examples/src/main/python/mllib/naive_bayes_example.py --- @@ -50,8 +61,17 @@ def parseLine(line): # Make prediction and test

[GitHub] spark pull request: [SPARK-13257] [Improvement] Refine naive Bayes...

2016-02-11 Thread movelikeriver
Github user movelikeriver commented on a diff in the pull request: https://github.com/apache/spark/pull/11125#discussion_r52697330 --- Diff: examples/src/main/python/mllib/naive_bayes_example.py --- @@ -38,8 +45,12 @@ def parseLine(line): sc =

[GitHub] spark pull request: [SPARK-13294] [PROJECT INFRA] Don't build full...

2016-02-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11178#issuecomment-183146095 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13277][BUILD] Follow-up ANTLR warnings ...

2016-02-11 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/11174#issuecomment-183146086 LGTM if it is creating the proper errors on Jenkins. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: [SPARK-13294] [PROJECT INFRA] Don't build full...

2016-02-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11178#issuecomment-183146096 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12915] [SQL] add SQL metrics of numOutp...

2016-02-11 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/11170#issuecomment-183147622 I'm going to merge this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

<    1   2   3   4   5   6   7   >