[GitHub] spark pull request: [SPARK-13711][Core]Don't call SparkUncaughtExc...

2016-03-07 Thread zsxwing
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/11566#issuecomment-193531052 @vanzin Sorry. I was looking a wrong place... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11011][SQL] Narrow type of UDT serializ...

2016-03-07 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11379#issuecomment-193531054 **[Test build #52600 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52600/consoleFull)** for PR 11379 at commit

[GitHub] spark pull request: [SPARK-12469][CORE][WIP/RFC] Consistent accumu...

2016-03-07 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11105#issuecomment-193530874 **[Test build #52601 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52601/consoleFull)** for PR 11105 at commit

[GitHub] spark pull request: Added histogram function

2016-03-07 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11569#issuecomment-193530569 **[Test build #52615 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52615/consoleFull)** for PR 11569 at commit

[GitHub] spark pull request: [SPARK-13689] [SQL] Move helper things in Cata...

2016-03-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11529#issuecomment-193530498 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13689] [SQL] Move helper things in Cata...

2016-03-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11529#issuecomment-193530494 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13253] [SQL]avoid checking nullability ...

2016-03-07 Thread frreiss
Github user frreiss commented on the pull request: https://github.com/apache/spark/pull/11184#issuecomment-193530307 This change adds a new attribute `prettyDataType` to about two dozen different classes. The new attribute is populated with code that is mostly copied and pasted from

[GitHub] spark pull request: [SPARK-13689] [SQL] Move helper things in Cata...

2016-03-07 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11529#issuecomment-193530111 **[Test build #52605 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52605/consoleFull)** for PR 11529 at commit

[GitHub] spark pull request: Added histogram function

2016-03-07 Thread olarayej
GitHub user olarayej opened a pull request: https://github.com/apache/spark/pull/11569 Added histogram function ## What changes were proposed in this pull request? Added method histogram() to compute the histogram of a Column **Usage:** # Create a DataFrame

[GitHub] spark pull request: [SPARK-13711][Core]Don't call SparkUncaughtExc...

2016-03-07 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/11566#issuecomment-193529928 Actually it seems it was @markhamstra and not me (in 17f3075bc). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark pull request: [SPARK-13253] [SQL]avoid checking nullability ...

2016-03-07 Thread frreiss
Github user frreiss commented on a diff in the pull request: https://github.com/apache/spark/pull/11184#discussion_r55299643 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/namedExpressions.scala --- @@ -87,7 +87,7 @@ trait NamedExpression extends

[GitHub] spark pull request: [SPARK-13727] [SQL] SparkConf.contains does no...

2016-03-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11568#issuecomment-193527447 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13727] [SQL] SparkConf.contains does no...

2016-03-07 Thread bomeng
GitHub user bomeng opened a pull request: https://github.com/apache/spark/pull/11568 [SPARK-13727] [SQL] SparkConf.contains does not consider deprecated keys ## What changes were proposed in this pull request? The contains() method does not return consistently with get() if the

[GitHub] spark pull request: [SPARK-13595] [BUILD] Move docker, extras modu...

2016-03-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11523#issuecomment-193527238 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13595] [BUILD] Move docker, extras modu...

2016-03-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11523#issuecomment-193527240 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13253] [SQL]avoid checking nullability ...

2016-03-07 Thread frreiss
Github user frreiss commented on a diff in the pull request: https://github.com/apache/spark/pull/11184#discussion_r55298650 --- Diff: python/pyspark/sql/functions.py --- @@ -250,17 +250,46 @@ def corr(col1, col2): """Returns a new :class:`Column` for the Pearson

[GitHub] spark pull request: [SPARK-13595] [BUILD] Move docker, extras modu...

2016-03-07 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11523#issuecomment-193527021 **[Test build #52599 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52599/consoleFull)** for PR 11523 at commit

[GitHub] spark pull request: [SPARK-13732] [SQL] Remove projectList from Wi...

2016-03-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11565#issuecomment-193526639 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13689] [SQL] Move helper things in Cata...

2016-03-07 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11529#issuecomment-193526622 **[Test build #2614 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2614/consoleFull)** for PR 11529 at commit

[GitHub] spark pull request: [SPARK-13732] [SQL] Remove projectList from Wi...

2016-03-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11565#issuecomment-193526633 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13732] [SQL] Remove projectList from Wi...

2016-03-07 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11565#issuecomment-193526313 **[Test build #52602 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52602/consoleFull)** for PR 11565 at commit

[GitHub] spark pull request: [SPARK-13689] [SQL] Move helper things in Cata...

2016-03-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11529#issuecomment-193525052 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13689] [SQL] Move helper things in Cata...

2016-03-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11529#issuecomment-193525047 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13689] [SQL] Move helper things in Cata...

2016-03-07 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11529#issuecomment-193524511 **[Test build #52603 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52603/consoleFull)** for PR 11529 at commit

[GitHub] spark pull request: [SPARK-13404] [SQL] Create variables for input...

2016-03-07 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/11274#issuecomment-193523843 @nongli I had updated the doc and commit message (PR description), once it pass the tests, I will merge this into master. --- If your project is set up for it, you can

[GitHub] spark pull request: [HOT-FIX][BUILD] Use the new location of `chec...

2016-03-07 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11567#issuecomment-193522841 Could you review this please? @srowen and @rxin . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: [SPARK-11171][SPARK-11237][SPARK-11241][ML] Tr...

2016-03-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9207#issuecomment-193522685 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [HOT-FIX][BUILD] Use the new location of `chec...

2016-03-07 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11567#issuecomment-193522667 Currently, Jenkins does not run `lint-java`. So this failure is not caught before. --- If your project is set up for it, you can reply to this email and

[GitHub] spark pull request: [SPARK-11171][SPARK-11237][SPARK-11241][ML] Tr...

2016-03-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9207#issuecomment-193522691 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-11171][SPARK-11237][SPARK-11241][ML] Tr...

2016-03-07 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9207#issuecomment-193522244 **[Test build #52608 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52608/consoleFull)** for PR 9207 at commit

[GitHub] spark pull request: [SPARK-10380] Confusing examples in pyspark SQ...

2016-03-07 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/11543#discussion_r55297346 --- Diff: python/pyspark/sql/dataframe.py --- @@ -974,6 +974,35 @@ def dropDuplicates(self, subset=None): jdf =

[GitHub] spark pull request: [SPARK-13713][SQL] Migrate parser from ANTLR3 ...

2016-03-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11557#issuecomment-193521618 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [HOT-FIX] Use the new location of `checkstyle-...

2016-03-07 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11567#issuecomment-193521532 **[Test build #52614 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52614/consoleFull)** for PR 11567 at commit

[GitHub] spark pull request: [SPARK-10380] Confusing examples in pyspark SQ...

2016-03-07 Thread GayathriMurali
Github user GayathriMurali commented on a diff in the pull request: https://github.com/apache/spark/pull/11543#discussion_r55297127 --- Diff: python/pyspark/sql/dataframe.py --- @@ -974,6 +974,35 @@ def dropDuplicates(self, subset=None): jdf =

[GitHub] spark pull request: [SPARK-13713][SQL] Migrate parser from ANTLR3 ...

2016-03-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11557#issuecomment-193521621 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [HOT-FIX] Use the new location of `checkstyle-...

2016-03-07 Thread dongjoon-hyun
GitHub user dongjoon-hyun opened a pull request: https://github.com/apache/spark/pull/11567 [HOT-FIX] Use the new location of `checkstyle-suppressions.xml` ## What changes were proposed in this pull request? This PR fixes `dev/lint-java` and `mvn checkstyle:check` failures

[GitHub] spark pull request: [SPARK-13706] [ML] Add Python Example for Trai...

2016-03-07 Thread jodersky
Github user jodersky commented on the pull request: https://github.com/apache/spark/pull/11547#issuecomment-193521102 Jenkins, test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-13713][SQL] Migrate parser from ANTLR3 ...

2016-03-07 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11557#issuecomment-193520951 **[Test build #52594 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52594/consoleFull)** for PR 11557 at commit

[GitHub] spark pull request: [SPARK-12721] [SQL] SQL Generation for Script ...

2016-03-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11503#issuecomment-193520688 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12721] [SQL] SQL Generation for Script ...

2016-03-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11503#issuecomment-193520694 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12721] [SQL] SQL Generation for Script ...

2016-03-07 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11503#issuecomment-193519839 **[Test build #52606 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52606/consoleFull)** for PR 11503 at commit

[GitHub] spark pull request: [SPARK-12719][SQL] SQL generation support for ...

2016-03-07 Thread dilipbiswal
Github user dilipbiswal commented on a diff in the pull request: https://github.com/apache/spark/pull/11563#discussion_r55296366 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/LogicalPlanToSQLSuite.scala --- @@ -445,4 +461,86 @@ class LogicalPlanToSQLSuite extends

[GitHub] spark pull request: [SPARK-13706] [ML] Add Python Example for Trai...

2016-03-07 Thread jodersky
Github user jodersky commented on the pull request: https://github.com/apache/spark/pull/11547#issuecomment-193517578 Looks good --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-13404] [SQL] Create variables for input...

2016-03-07 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/11274#discussion_r55296297 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegen.scala --- @@ -114,27 +117,67 @@ trait CodegenSupport extends SparkPlan {

[GitHub] spark pull request: [SPARK-13404] [SQL] Create variables for input...

2016-03-07 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/11274#discussion_r55296284 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegen.scala --- @@ -114,27 +117,67 @@ trait CodegenSupport extends SparkPlan {

[GitHub] spark pull request: [SPARK-13456][SQL] fix creating encoders for c...

2016-03-07 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/11410#discussion_r55296075 --- Diff: repl/scala-2.11/src/test/scala/org/apache/spark/repl/ReplSuite.scala --- @@ -254,6 +254,30 @@ class ReplSuite extends SparkFunSuite {

[GitHub] spark pull request: [SPARK-12458][SQL] Add ExpressionDescription t...

2016-03-07 Thread frreiss
Github user frreiss commented on a diff in the pull request: https://github.com/apache/spark/pull/10428#discussion_r55295539 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala --- @@ -109,7 +121,13 @@ case class

[GitHub] spark pull request: [SPARK-13713][SQL] Migrate parser from ANTLR3 ...

2016-03-07 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11557#issuecomment-193513755 **[Test build #52613 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52613/consoleFull)** for PR 11557 at commit

[GitHub] spark pull request: [SPARK-13404] [SQL] Create variables for input...

2016-03-07 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11274#issuecomment-193512076 **[Test build #52612 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52612/consoleFull)** for PR 11274 at commit

[GitHub] spark pull request: [SPARK-13671] [SQL] Use different physical pla...

2016-03-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11514#issuecomment-193511803 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13671] [SQL] Use different physical pla...

2016-03-07 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11514#issuecomment-193511757 **[Test build #52610 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52610/consoleFull)** for PR 11514 at commit

[GitHub] spark pull request: [SPARK-13671] [SQL] Use different physical pla...

2016-03-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11514#issuecomment-193511806 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13404] [SQL] Create variables for input...

2016-03-07 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/11274#discussion_r55294609 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/basicOperators.scala --- @@ -39,15 +39,26 @@ case class Project(projectList:

[GitHub] spark pull request: [SPARK-13665][SQL] Separate the concerns of Ha...

2016-03-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11509#issuecomment-193511261 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13665][SQL] Separate the concerns of Ha...

2016-03-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11509#issuecomment-193511260 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13665][SQL] Separate the concerns of Ha...

2016-03-07 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11509#issuecomment-193510810 **[Test build #52582 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52582/consoleFull)** for PR 11509 at commit

[GitHub] spark pull request: [SPARK-12458][SQL] Add ExpressionDescription t...

2016-03-07 Thread frreiss
Github user frreiss commented on a diff in the pull request: https://github.com/apache/spark/pull/10428#discussion_r55294135 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala --- @@ -109,7 +121,13 @@ case class

[GitHub] spark pull request: [SPARK-13692][CORE][SQL] Fix trivial Coverity/...

2016-03-07 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11530#issuecomment-193510043 Thank you, @zsxwing ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-13692][CORE][SQL] Fix trivial Coverity/...

2016-03-07 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11530#issuecomment-193509343 **[Test build #52611 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52611/consoleFull)** for PR 11530 at commit

[GitHub] spark pull request: [SPARK-12458][SQL] Add ExpressionDescription t...

2016-03-07 Thread frreiss
Github user frreiss commented on a diff in the pull request: https://github.com/apache/spark/pull/10428#discussion_r55293751 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala --- @@ -109,7 +121,13 @@ case class

[GitHub] spark pull request: [SPARK-12458][SQL] Add ExpressionDescription t...

2016-03-07 Thread frreiss
Github user frreiss commented on a diff in the pull request: https://github.com/apache/spark/pull/10428#discussion_r55293782 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala --- @@ -109,7 +121,13 @@ case class

[GitHub] spark pull request: [SPARK-13404] [SQL] Create variables for input...

2016-03-07 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/11274#discussion_r55293764 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoin.scala --- @@ -279,17 +277,21 @@ case class BroadcastHashJoin(

[GitHub] spark pull request: [SPARK-13692][CORE][SQL] Fix trivial Coverity/...

2016-03-07 Thread zsxwing
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/11530#issuecomment-193509236 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-10387][ML] Add code gen for gbt

2016-03-07 Thread frreiss
Github user frreiss commented on the pull request: https://github.com/apache/spark/pull/9524#issuecomment-193508431 LGTM as far as correctness goes. There's still quite a bit of pointer chasing going on in the generated code, though. --- If your project is set up for it, you can

[GitHub] spark pull request: [SPARK-10380] Confusing examples in pyspark SQ...

2016-03-07 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/11543#discussion_r55293326 --- Diff: python/pyspark/sql/dataframe.py --- @@ -974,6 +974,35 @@ def dropDuplicates(self, subset=None): jdf =

[GitHub] spark pull request: [SPARK-13404] [SQL] Create variables for input...

2016-03-07 Thread nongli
Github user nongli commented on the pull request: https://github.com/apache/spark/pull/11274#issuecomment-193508198 Patch looks good. Just a few documentation suggestions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] spark pull request: [SPARK-13404] [SQL] Create variables for input...

2016-03-07 Thread nongli
Github user nongli commented on a diff in the pull request: https://github.com/apache/spark/pull/11274#discussion_r55293072 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoin.scala --- @@ -279,17 +277,21 @@ case class BroadcastHashJoin(

[GitHub] spark pull request: [SPARK-10387][ML] Add code gen for gbt

2016-03-07 Thread frreiss
Github user frreiss commented on a diff in the pull request: https://github.com/apache/spark/pull/9524#discussion_r55292999 --- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/codeGenerator.scala --- @@ -0,0 +1,156 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request: [SPARK-13711][Core]Don't call SparkUncaughtExc...

2016-03-07 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11566#issuecomment-193506012 **[Test build #52609 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52609/consoleFull)** for PR 11566 at commit

[GitHub] spark pull request: [SPARK-13711][Core]Don't call SparkUncaughtExc...

2016-03-07 Thread zsxwing
GitHub user zsxwing opened a pull request: https://github.com/apache/spark/pull/11566 [SPARK-13711][Core]Don't call SparkUncaughtExceptionHandler in AppClient as it's in driver ## What changes were proposed in this pull request? AppClient runs in the driver side. It should

[GitHub] spark pull request: [SPARK-13404] [SQL] Create variables for input...

2016-03-07 Thread nongli
Github user nongli commented on a diff in the pull request: https://github.com/apache/spark/pull/11274#discussion_r55292723 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegen.scala --- @@ -114,27 +117,67 @@ trait CodegenSupport extends SparkPlan {

[GitHub] spark pull request: [SPARK-13671] [SQL] Use different physical pla...

2016-03-07 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11514#issuecomment-193506060 **[Test build #52610 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52610/consoleFull)** for PR 11514 at commit

[GitHub] spark pull request: [SPARK-13711][Core]Don't call SparkUncaughtExc...

2016-03-07 Thread zsxwing
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/11566#issuecomment-193505687 cc @vanzin as you added `Utils.tryOrExit` here --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12719][SQL] SQL generation support for ...

2016-03-07 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/11563#issuecomment-193505236 Why do we need two separate cases here? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-12719][SQL] SQL generation support for ...

2016-03-07 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/11563#discussion_r55292434 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/LogicalPlanToSQLSuite.scala --- @@ -445,4 +461,86 @@ class LogicalPlanToSQLSuite extends

[GitHub] spark pull request: [SPARK-13404] [SQL] Create variables for input...

2016-03-07 Thread nongli
Github user nongli commented on a diff in the pull request: https://github.com/apache/spark/pull/11274#discussion_r55292388 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegen.scala --- @@ -114,27 +117,67 @@ trait CodegenSupport extends SparkPlan {

[GitHub] spark pull request: [SPARK-13404] [SQL] Create variables for input...

2016-03-07 Thread nongli
Github user nongli commented on a diff in the pull request: https://github.com/apache/spark/pull/11274#discussion_r55292326 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegen.scala --- @@ -114,27 +117,67 @@ trait CodegenSupport extends SparkPlan {

[GitHub] spark pull request: [SPARK-11171][SPARK-11237][SPARK-11241][ML] Tr...

2016-03-07 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9207#issuecomment-193503735 **[Test build #52608 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52608/consoleFull)** for PR 9207 at commit

[GitHub] spark pull request: [SPARK-13648] Add Hive Cli to classes for isol...

2016-03-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/11495 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-13648] Add Hive Cli to classes for isol...

2016-03-07 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/11495#issuecomment-193501590 Thanks, merging to master and 1.6. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-13665][SQL] Separate the concerns of Ha...

2016-03-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/11509 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-13717][Core] Let RandomSampler can samp...

2016-03-07 Thread viirya
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/11559#issuecomment-193498472 Yea, thanks! I will do it next time. As you said, so I will implement `RandomSampler` interface without iterator for wholestage codegen of `Sampler`. --- If your

[GitHub] spark pull request: [SPARK-13665][SQL] Separate the concerns of Ha...

2016-03-07 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/11509#issuecomment-193498704 Going to merge this in master. We should rename HiveFileCatalog to MetastoreFileCatalog. cc @andrewor14 --- If your project is set up for it, you

[GitHub] spark pull request: [SPARK-13717][Core] Let RandomSampler can samp...

2016-03-07 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/11559#issuecomment-193497602 BTW next time it'd be great if you can provide the important context for this pull request directly in the description. Thanks. --- If your project is set up for it,

[GitHub] spark pull request: [SPARK-13717][Core] Let RandomSampler can samp...

2016-03-07 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/11559#issuecomment-193497465 It seems like we shouldn't use iterators for whole stage codegen. The point is to get rid of iterators. Shouldn't we just have a filter there? --- If your project is

[GitHub] spark pull request: [SPARK-13593][SQL] improve the `toDF()` method...

2016-03-07 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/11444#discussion_r55290303 --- Diff: python/pyspark/sql/context.py --- @@ -50,18 +50,60 @@ def _monkey_patch_RDD(sqlContext): def toDF(self, schema=None, sampleRatio=None):

[GitHub] spark pull request: [SPARK-13717][Core] Let RandomSampler can samp...

2016-03-07 Thread viirya
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/11559#issuecomment-193497090 I will close this now if you really think this is not necessary to better Java compatibility. However, I will go to implement `RandomSampler` interface without iterator

[GitHub] spark pull request: [SPARK-13717][Core] Let RandomSampler can samp...

2016-03-07 Thread viirya
Github user viirya closed the pull request at: https://github.com/apache/spark/pull/11559 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-13404] [SQL] Create variables for input...

2016-03-07 Thread nongli
Github user nongli commented on the pull request: https://github.com/apache/spark/pull/11274#issuecomment-193496493 @davies can you update the gist with the new output? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: [SPARK-13717][Core] Let RandomSampler can samp...

2016-03-07 Thread viirya
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/11559#issuecomment-193496075 @holdenk @rxin I added the Java iterator support due to the wholestage codegen version of `Sample` in #11517. I was using Scala iterator but as `RandomSampler`

[GitHub] spark pull request: [SPARK-13695] Don't cache MEMORY_AND_DISK bloc...

2016-03-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11533#issuecomment-193494746 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13695] Don't cache MEMORY_AND_DISK bloc...

2016-03-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11533#issuecomment-193494753 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-10387][ML] Add code gen for gbt

2016-03-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9524#issuecomment-193492763 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13695] Don't cache MEMORY_AND_DISK bloc...

2016-03-07 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11533#issuecomment-193494312 **[Test build #52592 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52592/consoleFull)** for PR 11533 at commit

[GitHub] spark pull request: [SPARK-13665][SQL] Separate the concerns of Ha...

2016-03-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11509#issuecomment-193493845 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13665][SQL] Separate the concerns of Ha...

2016-03-07 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11509#issuecomment-193493406 **[Test build #52590 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52590/consoleFull)** for PR 11509 at commit

[GitHub] spark pull request: [SPARK-13665][SQL] Separate the concerns of Ha...

2016-03-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11509#issuecomment-193493854 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-10387][ML] Add code gen for gbt

2016-03-07 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9524#issuecomment-193492329 **[Test build #52589 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52589/consoleFull)** for PR 9524 at commit

[GitHub] spark pull request: [SPARK-13692][CORE][SQL] Fix trivial Coverity/...

2016-03-07 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11530#issuecomment-193492670 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-10387][ML] Add code gen for gbt

2016-03-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9524#issuecomment-193492767 Test PASSed. Refer to this link for build results (access rights to CI server needed):

<    1   2   3   4   5   6   7   8   >