[GitHub] spark pull request: [SPARK-10907][SPARK-6157][WIP] Remove pendingU...

2016-03-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11613#issuecomment-195524921 **[Test build #52941 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52941/consoleFull)** for PR 11613 at commit [`ebb25f9`](https://gi

[GitHub] spark pull request: [SPARK-13207] [SQL] Make partitioning discover...

2016-03-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11088#issuecomment-195522607 **[Test build #52940 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52940/consoleFull)** for PR 11088 at commit [`2460716`](https://gi

[GitHub] spark pull request: [SPARK-13830] prefer block manager than direct...

2016-03-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11659#issuecomment-195522563 **[Test build #52938 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52938/consoleFull)** for PR 11659 at commit [`e982656`](https://gi

[GitHub] spark pull request: [SPARK-XXXX][SQL] Add a strategy for planning ...

2016-03-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11646#issuecomment-195522580 **[Test build #52939 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52939/consoleFull)** for PR 11646 at commit [`65596df`](https://gi

[GitHub] spark pull request: [SPARK-13207] [SQL] Make partitioning discover...

2016-03-11 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/11088#issuecomment-195522100 test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featur

[GitHub] spark pull request: [SPARK-13830] prefer block manager than direct...

2016-03-11 Thread davies
GitHub user davies opened a pull request: https://github.com/apache/spark/pull/11659 [SPARK-13830] prefer block manager than direct result for large result ## What changes were proposed in this pull request? The current RPC can't handle large blocks very well, it's very slow

[GitHub] spark pull request: [SPARK-13830] prefer block manager than direct...

2016-03-11 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/11659#issuecomment-195522189 cc @zsxwing @andrewor14 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have th

[GitHub] spark pull request: [SPARK-13776][WebUI]Limit the max number of ac...

2016-03-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11615#issuecomment-195521449 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-13776][WebUI]Limit the max number of ac...

2016-03-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11615#issuecomment-195521428 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-13207] [SQL] Make partitioning discover...

2016-03-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11088#issuecomment-195521241 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-13207] [SQL] Make partitioning discover...

2016-03-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11088#issuecomment-195521237 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-13776][WebUI]Limit the max number of ac...

2016-03-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11615#issuecomment-195521097 **[Test build #52931 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52931/consoleFull)** for PR 11615 at commit [`8422f6e`](https://g

[GitHub] spark pull request: [SPARK-13207] [SQL] Make partitioning discover...

2016-03-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11088#issuecomment-195521193 **[Test build #52936 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52936/consoleFull)** for PR 11088 at commit [`2460716`](https://g

[GitHub] spark pull request: [SPARK-13207] [SQL] Make partitioning discover...

2016-03-11 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/11088#issuecomment-195520664 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled a

[GitHub] spark pull request: [SPARK-13139][SQL] Parse Hive DDL commands our...

2016-03-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11573#issuecomment-195520611 **[Test build #52937 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52937/consoleFull)** for PR 11573 at commit [`bd91b0f`](https://gi

[GitHub] spark pull request: [SPARK-13207] [SQL] Make partitioning discover...

2016-03-11 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/11088#issuecomment-195519349 Updated. The previous PR did not handle the cases of listing files through spark jobs. I also fixed that part and added the test. --- If your project is set up for it, y

[GitHub] spark pull request: [SPARK-13207] [SQL] Make partitioning discover...

2016-03-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11088#issuecomment-195519288 **[Test build #52936 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52936/consoleFull)** for PR 11088 at commit [`2460716`](https://gi

[GitHub] spark pull request: [SPARK-10907][SPARK-6157][WIP] Remove pendingU...

2016-03-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11613#issuecomment-195517234 **[Test build #52935 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52935/consoleFull)** for PR 11613 at commit [`858aea2`](https://gi

[GitHub] spark pull request: [SPARK-13396] Stop using our internal deprecat...

2016-03-11 Thread GayathriMurali
Github user GayathriMurali commented on a diff in the pull request: https://github.com/apache/spark/pull/11544#discussion_r55875321 --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/JobProgressListener.scala --- @@ -374,28 +374,30 @@ class JobProgressListener(conf: SparkConf)

[GitHub] spark pull request: [SPARK-12583][Mesos] Mesos shuffle service: Do...

2016-03-11 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/11272#issuecomment-195506145 What's the status on this patch? Have we at least tested it manually? At the very least we should merge it into 2.0. --- If your project is set up for it, you can r

[GitHub] spark pull request: [SPARK-13807] De-duplicate `Python*Helper` ins...

2016-03-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/11641 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request: [SPARK-13396] Stop using our internal deprecat...

2016-03-11 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/11544#issuecomment-195505678 Looks great. Just some minor comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-13807] De-duplicate `Python*Helper` ins...

2016-03-11 Thread zsxwing
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/11641#issuecomment-195505420 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark pull request: [SPARK-13807] De-duplicate `Python*Helper` ins...

2016-03-11 Thread zsxwing
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/11641#issuecomment-195505453 Merging to master. Thanks @JoshRosen --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project do

[GitHub] spark pull request: [SPARK-13396] Stop using our internal deprecat...

2016-03-11 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/11544#discussion_r55874631 --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/JobProgressListener.scala --- @@ -374,28 +374,30 @@ class JobProgressListener(conf: SparkConf) exte

[GitHub] spark pull request: [SPARK-13396] Stop using our internal deprecat...

2016-03-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11544#issuecomment-195505249 **[Test build #52934 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52934/consoleFull)** for PR 11544 at commit [`228e078`](https://gi

[GitHub] spark pull request: [SPARK-13396] Stop using our internal deprecat...

2016-03-11 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/11544#discussion_r55874351 --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/JobProgressListener.scala --- @@ -374,28 +374,30 @@ class JobProgressListener(conf: SparkConf) exte

[GitHub] spark pull request: [STREAMING][MINOR] Fix a duplicate "be" in com...

2016-03-11 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/11650#issuecomment-195501910 Thanks the PR is already here I've merged it. @lw-lin in the future please batch more fixes like this. Thanks. --- If your project is set up for it, you can repl

[GitHub] spark pull request: [SPARK-13396] Stop using our internal deprecat...

2016-03-11 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/11544#issuecomment-195504342 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-13396] Stop using our internal deprecat...

2016-03-11 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/11544#discussion_r55874268 --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/JobProgressListener.scala --- @@ -374,28 +374,30 @@ class JobProgressListener(conf: SparkConf) exte

[GitHub] spark pull request: [SPARK-13328][Core]: Poor read performance for...

2016-03-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/11241 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request: [SPARK-13328][Core]: Poor read performance for...

2016-03-11 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/11241#issuecomment-195503487 Note to self: remember to close the issue once JIRA is back up --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark pull request: [SPARK-13604][Core]Sync worker's state after r...

2016-03-11 Thread tedyu
Github user tedyu commented on a diff in the pull request: https://github.com/apache/spark/pull/11455#discussion_r55873954 --- Diff: core/src/main/scala/org/apache/spark/deploy/master/Master.scala --- @@ -368,6 +368,30 @@ private[deploy] class Master( if (canCompleteReco

[GitHub] spark pull request: [SPARK-13328][Core]: Poor read performance for...

2016-03-11 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/11241#issuecomment-195503369 Merging into master, thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-XXXX][SQL] Add a strategy for planning ...

2016-03-11 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/11646#discussion_r55873402 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/sources/interfaces.scala --- @@ -454,19 +454,51 @@ trait FileFormat { requiredColumns: Arr

[GitHub] spark pull request: [SPARK-XXXX][SQL] Add a strategy for planning ...

2016-03-11 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/11646#discussion_r55873151 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileScanRDD.scala --- @@ -0,0 +1,56 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [SPARK-7425] [ML] spark.ml Predictor should su...

2016-03-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10355#issuecomment-195500352 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-7425] [ML] spark.ml Predictor should su...

2016-03-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10355#issuecomment-195500349 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-7425] [ML] spark.ml Predictor should su...

2016-03-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10355#issuecomment-195499950 **[Test build #52932 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52932/consoleFull)** for PR 10355 at commit [`45582de`](https://g

[GitHub] spark pull request: [SPARK-13789] Infer additional constraints fro...

2016-03-11 Thread sameeragarwal
Github user sameeragarwal commented on the pull request: https://github.com/apache/spark/pull/11618#issuecomment-195497597 sounds good, thank you. In my branch, I try to address (2) by not adding new conditions if the child node(s) already have the given constraint. For (3), please no

[GitHub] spark pull request: [SPARK-13658][SQL] BooleanSimplification rule ...

2016-03-11 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/11647#discussion_r55872639 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Canonicalize.scala --- @@ -36,15 +36,16 @@ import org.apache.spark.sql.cata

[GitHub] spark pull request: [SPARK-13776][WebUI]Limit the max number of ac...

2016-03-11 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/11615#discussion_r55872166 --- Diff: core/src/main/scala/org/apache/spark/ui/JettyUtils.scala --- @@ -270,9 +270,25 @@ private[spark] object JettyUtils extends Logging {

[GitHub] spark pull request: [SPARK-13776][WebUI]Limit the max number of ac...

2016-03-11 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/11615#discussion_r55871640 --- Diff: core/src/main/scala/org/apache/spark/ui/JettyUtils.scala --- @@ -270,9 +270,25 @@ private[spark] object JettyUtils extends Logging {

[GitHub] spark pull request: [SPARK-12719][SQL] [WIP] SQL generation suppor...

2016-03-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11596#issuecomment-195496237 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-12719][SQL] [WIP] SQL generation suppor...

2016-03-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11596#issuecomment-195496238 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-12719][SQL] [WIP] SQL generation suppor...

2016-03-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11596#issuecomment-195495907 **[Test build #52930 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52930/consoleFull)** for PR 11596 at commit [`bea871f`](https://g

[GitHub] spark pull request: [SPARK-13776][WebUI]Limit the max number of ac...

2016-03-11 Thread jaceklaskowski
Github user jaceklaskowski commented on a diff in the pull request: https://github.com/apache/spark/pull/11615#discussion_r55869059 --- Diff: core/src/main/scala/org/apache/spark/ui/JettyUtils.scala --- @@ -270,9 +270,25 @@ private[spark] object JettyUtils extends Logging {

[GitHub] spark pull request: [SPARK-13776][WebUI]Limit the max number of ac...

2016-03-11 Thread jaceklaskowski
Github user jaceklaskowski commented on a diff in the pull request: https://github.com/apache/spark/pull/11615#discussion_r55868740 --- Diff: core/src/main/scala/org/apache/spark/ui/JettyUtils.scala --- @@ -270,9 +270,25 @@ private[spark] object JettyUtils extends Logging {

[GitHub] spark pull request: [SPARK-13568] [ML] Create feature transformer ...

2016-03-11 Thread hhbyyh
Github user hhbyyh commented on a diff in the pull request: https://github.com/apache/spark/pull/11601#discussion_r55868373 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Imputer.scala --- @@ -0,0 +1,290 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] spark pull request: [SPARK-13780][sql] Add missing dependency to b...

2016-03-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/11640 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request: [SPARK-13207] [SQL] Make partitioning discover...

2016-03-11 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/11088#issuecomment-195489718 sure --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled an

[GitHub] spark pull request: [SPARK-13780][sql] Add missing dependency to b...

2016-03-11 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/11640#issuecomment-195488673 Merging to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fea

[GitHub] spark pull request: [SPARK-13576] Don't create assembly for exampl...

2016-03-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11452#issuecomment-195488826 **[Test build #52933 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52933/consoleFull)** for PR 11452 at commit [`fda639b`](https://gi

[GitHub] spark pull request: [SPARK-13604][Core]Sync worker's state after r...

2016-03-11 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/11455#discussion_r55867638 --- Diff: core/src/main/scala/org/apache/spark/deploy/master/Master.scala --- @@ -368,6 +368,30 @@ private[deploy] class Master( if (canComplet

[GitHub] spark pull request: [SPARK-13139][SQL] Parse Hive DDL commands our...

2016-03-11 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/11573#discussion_r55867164 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/bucket.scala --- @@ -24,12 +27,15 @@ package org.apache.spark.sql.execution.datas

[GitHub] spark pull request: [SPARK-7425] [ML] spark.ml Predictor should su...

2016-03-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10355#issuecomment-195485937 **[Test build #52932 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52932/consoleFull)** for PR 10355 at commit [`45582de`](https://gi

[GitHub] spark pull request: [SPARK-13207] [SQL] Make partitioning discover...

2016-03-11 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/11088#issuecomment-195483801 LGTM, could you rebase this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-13604][Core]Sync worker's state after r...

2016-03-11 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/11455#discussion_r55863392 --- Diff: core/src/main/scala/org/apache/spark/deploy/master/Master.scala --- @@ -368,6 +368,30 @@ private[deploy] class Master( if (canCompleteRe

[GitHub] spark pull request: [SPARK-13776][WebUI]Add spark.ui.threads to se...

2016-03-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11615#issuecomment-195477414 **[Test build #52931 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52931/consoleFull)** for PR 11615 at commit [`8422f6e`](https://gi

[GitHub] spark pull request: SPARK-13827[SQL] Can't add subquery to an oper...

2016-03-11 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/11658#issuecomment-195476480 You are so fast! Will do the review tonight or tomorrow. I have another test case for this issue. Maybe you can take it. This is Project -- Subquery -- Filter -- Agg

[GitHub] spark pull request: [SPARK-13776][WebUI]Add spark.ui.threads to se...

2016-03-11 Thread zsxwing
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/11615#issuecomment-195476295 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] spark pull request: [SPARK-XXXX][SQL] Add a strategy for planning ...

2016-03-11 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/11646#discussion_r55862748 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileScanRDD.scala --- @@ -0,0 +1,56 @@ +/* + * Licensed to the Apache So

[GitHub] spark pull request: [SPARK-7425] [ML] spark.ml Predictor should su...

2016-03-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10355#issuecomment-195473838 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-7425] [ML] spark.ml Predictor should su...

2016-03-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10355#issuecomment-195473729 **[Test build #52929 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52929/consoleFull)** for PR 10355 at commit [`2230292`](https://g

[GitHub] spark pull request: [SPARK-7425] [ML] spark.ml Predictor should su...

2016-03-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10355#issuecomment-195473833 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-13789] Infer additional constraints fro...

2016-03-11 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/11618#issuecomment-195472409 A couple of issues I hit when I try to do it. 1. The first issue is the one I submitted earlier regarding the `IsNotNull` of compound expressions. 2. T

[GitHub] spark pull request: [SPARK-13789] Infer additional constraints fro...

2016-03-11 Thread sameeragarwal
Github user sameeragarwal commented on the pull request: https://github.com/apache/spark/pull/11618#issuecomment-195466611 Shouldn't the existing rule for `PushPredicateThroughJoin` automatically take care of predicate pushdown? By the way, please feel free to take over my branch if y

[GitHub] spark pull request: [SPARK-12719][SQL] [WIP] SQL generation suppor...

2016-03-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11596#issuecomment-195466246 **[Test build #52930 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52930/consoleFull)** for PR 11596 at commit [`bea871f`](https://gi

[GitHub] spark pull request: [SPARK-7425] [ML] spark.ml Predictor should su...

2016-03-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10355#issuecomment-195463826 **[Test build #52929 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52929/consoleFull)** for PR 10355 at commit [`2230292`](https://gi

[GitHub] spark pull request: [SPARK-12719][SQL] [WIP] SQL generation suppor...

2016-03-11 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/11596#issuecomment-195463951 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-13811] [SQL] No Push-Down of Constraint...

2016-03-11 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/11649#issuecomment-195463505 @sameeragarwal True, we can add it back when needing it. Let me directly filter it out in `constructIsNotNullConstraints` --- If your project is set up for it, you

[GitHub] spark pull request: [SPARK-13789] Infer additional constraints fro...

2016-03-11 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/11618#issuecomment-195462388 @sameeragarwal Yeah, it sounds like you already started working on it. True, I also did a similar thing, but we need to add extra handling for predicate pu

[GitHub] spark pull request: [SPARK-13604][Core]Sync worker's state after r...

2016-03-11 Thread tedyu
Github user tedyu commented on a diff in the pull request: https://github.com/apache/spark/pull/11455#discussion_r55858792 --- Diff: core/src/main/scala/org/apache/spark/deploy/master/Master.scala --- @@ -368,6 +368,30 @@ private[deploy] class Master( if (canCompleteReco

[GitHub] spark pull request: [SPARK-7425] [ML] spark.ml Predictor should su...

2016-03-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10355#issuecomment-195455108 **[Test build #52928 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52928/consoleFull)** for PR 10355 at commit [`2575fb7`](https://gi

[GitHub] spark pull request: [SPARK-7425] [ML] spark.ml Predictor should su...

2016-03-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10355#issuecomment-195455908 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-7425] [ML] spark.ml Predictor should su...

2016-03-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10355#issuecomment-195455913 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-7425] [ML] spark.ml Predictor should su...

2016-03-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10355#issuecomment-195455900 **[Test build #52928 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52928/consoleFull)** for PR 10355 at commit [`2575fb7`](https://g

[GitHub] spark pull request: SPARK-13827[SQL] Can't add subquery to an oper...

2016-03-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11658#issuecomment-195452965 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: SPARK-13827[SQL] Can't add subquery to an oper...

2016-03-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11658#issuecomment-195452256 **[Test build #52926 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52926/consoleFull)** for PR 11658 at commit [`198b406`](https://g

[GitHub] spark pull request: [SPARK-13810] [CORE] Add Port Configuration Su...

2016-03-11 Thread squito
Github user squito commented on the pull request: https://github.com/apache/spark/pull/11644#issuecomment-195451612 bjorn and I chatted about this a bit more offline, I understand why its a bit complicated for the non-UI port a bit more, but also feel this simple change is good enough

[GitHub] spark pull request: [SPARK-13267] [Web UI] document the ?param arg...

2016-03-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11152#issuecomment-195440805 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-13267] [Web UI] document the ?param arg...

2016-03-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11152#issuecomment-195440802 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-13267] [Web UI] document the ?param arg...

2016-03-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11152#issuecomment-195440652 **[Test build #52927 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52927/consoleFull)** for PR 11152 at commit [`2895a4f`](https://g

[GitHub] spark pull request: [SPARK-13267] [Web UI] document the ?param arg...

2016-03-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11152#issuecomment-195436124 **[Test build #52927 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52927/consoleFull)** for PR 11152 at commit [`2895a4f`](https://gi

[GitHub] spark pull request: [SPARK-12719][SQL] [WIP] SQL generation suppor...

2016-03-11 Thread dilipbiswal
Github user dilipbiswal commented on the pull request: https://github.com/apache/spark/pull/11596#issuecomment-195435909 @cloud-fan Can you please help trigger a retest ? This does not seem related to my changes. --- If your project is set up for it, you can reply to this email and h

[GitHub] spark pull request: [SPARK-13267] [Web UI] document the ?param arg...

2016-03-11 Thread steveloughran
Github user steveloughran commented on the pull request: https://github.com/apache/spark/pull/11152#issuecomment-195435446 Fixed up the endpoints, added some more detail on app-id vs app-attempt, using base-app-id for the log retrieval. Also mentioned that after job/stage GC, there ar

[GitHub] spark pull request: [SPARK-13267] [Web UI] document the ?param arg...

2016-03-11 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/11152#discussion_r55850527 --- Diff: docs/monitoring.md --- @@ -273,8 +309,8 @@ for a running application, at `http://localhost:4040/api/v1`. Download the event logs for all at

[GitHub] spark pull request: [SPARK-13432][SQL] add the source file name an...

2016-03-11 Thread sarutak
Github user sarutak commented on the pull request: https://github.com/apache/spark/pull/11301#issuecomment-195431480 I'll leave the rest of feedback comments tomorrow or the day after tomorrow. --- If your project is set up for it, you can reply to this email and have your reply appea

[GitHub] spark pull request: [SPARK-13810] [CORE] Add Port Configuration Su...

2016-03-11 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/11644#discussion_r55849588 --- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala --- @@ -2014,8 +2014,10 @@ private[spark] object Utils extends Logging { } catch {

[GitHub] spark pull request: [SPARK-13810] [CORE] Add Port Configuration Su...

2016-03-11 Thread squito
Github user squito commented on the pull request: https://github.com/apache/spark/pull/11644#issuecomment-195429708 I can't see the earlier version of this diff, but I dont' understand why you'd need to introduce a `SparkEnv`. I see that currently, when a `WebUI` is created, you no l

[GitHub] spark pull request: [SPARK-10775][UI]add search keywords in histor...

2016-03-11 Thread sarutak
Github user sarutak commented on the pull request: https://github.com/apache/spark/pull/8885#issuecomment-195428838 @lianhuiwang #10648 has already merged and I think it includes features proposed in this PR. So, do you mind closing this PR? --- If your project is set up for it, you

[GitHub] spark pull request: [SPARK-12224][SPARKR] R support for JDBC sourc...

2016-03-11 Thread shivaram
Github user shivaram commented on the pull request: https://github.com/apache/spark/pull/10480#issuecomment-195425756 Sorry for the delay @felixcheung -- I'll get back on this today --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark pull request: [SPARK-13823] [CORE] [STREAMING] [SQL] Always ...

2016-03-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11657#issuecomment-195407370 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-13823] [CORE] [STREAMING] [SQL] Always ...

2016-03-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11657#issuecomment-195407372 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-13823] [CORE] [STREAMING] [SQL] Always ...

2016-03-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11657#issuecomment-195406759 **[Test build #52925 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52925/consoleFull)** for PR 11657 at commit [`8e2865e`](https://g

[GitHub] spark pull request: [SPARK-13823] [CORE] [STREAMING] [SQL] Always ...

2016-03-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11657#issuecomment-195397133 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-13823] [CORE] [STREAMING] [SQL] Always ...

2016-03-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11657#issuecomment-195397138 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-13823] [CORE] [STREAMING] [SQL] Always ...

2016-03-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11657#issuecomment-195396694 **[Test build #52924 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52924/consoleFull)** for PR 11657 at commit [`1deecd8`](https://g

[GitHub] spark pull request: SPARK-13827[SQL] Can't add subquery to an oper...

2016-03-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11658#issuecomment-195396390 **[Test build #52926 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52926/consoleFull)** for PR 11658 at commit [`198b406`](https://gi

[GitHub] spark pull request: SPARK-13827[SQL] Can't add subquery to an oper...

2016-03-11 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/11658#issuecomment-195396204 cc @liancheng @gatorsmile @yhuai --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project doe

<    1   2   3   4   5   6   7   >