[GitHub] spark pull request: [SPARK-14100][ML] Merging Estimator and Model:...

2016-03-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11983#issuecomment-202002406 **[Test build #2699 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2699/consoleFull)** for PR 11983 at commit [`df6a3da`](https://

[GitHub] spark pull request: [SPARK-14100][ML] Merging Estimator and Model:...

2016-03-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11983#issuecomment-202002397 **[Test build #54280 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54280/consoleFull)** for PR 11983 at commit [`df6a3da`](https://g

[GitHub] spark pull request: [SPARK-14100][ML] Merging Estimator and Model:...

2016-03-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11983#issuecomment-202002399 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14100][ML] Merging Estimator and Model:...

2016-03-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11983#issuecomment-202002398 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14100][ML] Merging Estimator and Model:...

2016-03-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11983#issuecomment-202002051 **[Test build #2699 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2699/consoleFull)** for PR 11983 at commit [`df6a3da`](https://g

[GitHub] spark pull request: [SPARK-13742][Core] Add non-iterator interface...

2016-03-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11578#issuecomment-202002019 **[Test build #54278 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54278/consoleFull)** for PR 11578 at commit [`ef1be44`](https://gi

[GitHub] spark pull request: [SPARK-14100][ML] Merging Estimator and Model:...

2016-03-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11983#issuecomment-202002015 **[Test build #54280 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54280/consoleFull)** for PR 11983 at commit [`df6a3da`](https://gi

[GitHub] spark pull request: [SPARK-13844][SQL] Generate better code for fi...

2016-03-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11684#issuecomment-202002017 **[Test build #54281 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54281/consoleFull)** for PR 11684 at commit [`2eda22f`](https://gi

[GitHub] spark pull request: [Spark-14138][SQL] Fix generated SpecificColum...

2016-03-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11984#issuecomment-202002007 **[Test build #54277 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54277/consoleFull)** for PR 11984 at commit [`60f6719`](https://gi

[GitHub] spark pull request: [Spark-14138][SQL] Fix generated SpecificColum...

2016-03-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11984#issuecomment-202002010 **[Test build #54279 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54279/consoleFull)** for PR 11984 at commit [`60f6719`](https://gi

[GitHub] spark pull request: [SPARK-14181] TrainValidationSplit should have...

2016-03-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11985#issuecomment-202002009 **[Test build #54282 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54282/consoleFull)** for PR 11985 at commit [`16e967e`](https://gi

[GitHub] spark pull request: [SPARK-14181] TrainValidationSplit should have...

2016-03-26 Thread yinxusen
Github user yinxusen commented on the pull request: https://github.com/apache/spark/pull/11985#issuecomment-202000719 test it please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featu

[GitHub] spark pull request: [SPARK-14071][PySpark][ML]Change MLWritable.wr...

2016-03-26 Thread yanboliang
Github user yanboliang commented on the pull request: https://github.com/apache/spark/pull/11945#issuecomment-202000712 @jkbradley @wangmiao1981 From another perspective, this annotation should not get inherited to classes which are added in later Spark versions. So I think it's bette

[GitHub] spark pull request: [SPARK-14181] TrainValidationSplit should have...

2016-03-26 Thread yinxusen
GitHub user yinxusen opened a pull request: https://github.com/apache/spark/pull/11985 [SPARK-14181] TrainValidationSplit should have HasSeed https://issues.apache.org/jira/browse/SPARK-14181 TrainValidationSplit should have HasSeed for the random split of RDD. I also chang

[GitHub] spark pull request: [Spark-14138][SQL] Fix generated SpecificColum...

2016-03-26 Thread kiszk
Github user kiszk commented on the pull request: https://github.com/apache/spark/pull/11984#issuecomment-201993844 Jenkins, retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-14052] [SQL] build a BytesToBytesMap di...

2016-03-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11870#issuecomment-201992876 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14052] [SQL] build a BytesToBytesMap di...

2016-03-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11870#issuecomment-201992875 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14052] [SQL] build a BytesToBytesMap di...

2016-03-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11870#issuecomment-201992845 **[Test build #54273 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54273/consoleFull)** for PR 11870 at commit [`11b2364`](https://g

[GitHub] spark pull request: [Spark-14138][SQL] Fix generated SpecificColum...

2016-03-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11984#issuecomment-201991966 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [Spark-14138][SQL] Fix generated SpecificColum...

2016-03-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11984#issuecomment-201991965 **[Test build #54276 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54276/consoleFull)** for PR 11984 at commit [`e56406e`](https://g

[GitHub] spark pull request: [Spark-14138][SQL] Fix generated SpecificColum...

2016-03-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11984#issuecomment-201991969 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [Spark-14138][SQL] Fix generated SpecificColum...

2016-03-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11984#issuecomment-201991876 **[Test build #54276 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54276/consoleFull)** for PR 11984 at commit [`e56406e`](https://gi

[GitHub] spark pull request: [SPARK-13844][SQL] Generate better code for fi...

2016-03-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11684#issuecomment-201991658 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-13844][SQL] Generate better code for fi...

2016-03-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11684#issuecomment-201991655 **[Test build #54275 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54275/consoleFull)** for PR 11684 at commit [`9fd7773`](https://g

[GitHub] spark pull request: [SPARK-13844][SQL] Generate better code for fi...

2016-03-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11684#issuecomment-201991657 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-13844][SQL] Generate better code for fi...

2016-03-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11684#issuecomment-201991629 **[Test build #54275 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54275/consoleFull)** for PR 11684 at commit [`9fd7773`](https://gi

[GitHub] spark pull request: [SPARK-14156][SQL] Use executedPlan in HiveCom...

2016-03-26 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/11957#discussion_r57523346 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveComparisonTest.scala --- @@ -480,7 +480,7 @@ abstract class HiveComparisonTest

[GitHub] spark pull request: [SPARK-14156][SQL] Use executedPlan in HiveCom...

2016-03-26 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/11957#discussion_r57523270 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveComparisonTest.scala --- @@ -480,7 +480,7 @@ abstract class HiveComparisonTest

[GitHub] spark pull request: [Spark-14138][SQL] Fix generated SpecificColum...

2016-03-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11984#issuecomment-201989670 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [Spark-14138][SQL] Fix generated SpecificColum...

2016-03-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11984#issuecomment-201989658 **[Test build #54274 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54274/consoleFull)** for PR 11984 at commit [`fea2a52`](https://g

[GitHub] spark pull request: [Spark-14138][SQL] Fix generated SpecificColum...

2016-03-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11984#issuecomment-201989665 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [Spark-14138][SQL] Fix generated SpecificColum...

2016-03-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11984#issuecomment-201988732 **[Test build #54274 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54274/consoleFull)** for PR 11984 at commit [`fea2a52`](https://gi

[GitHub] spark pull request: [Spark-14138][SQL] Fix generated SpecificColum...

2016-03-26 Thread kiszk
GitHub user kiszk opened a pull request: https://github.com/apache/spark/pull/11984 [Spark-14138][SQL] Fix generated SpecificColumnarIterator code can exceed JVM size limit for cached DataFrames ## What changes were proposed in this pull request? This PR reduces Java byte c

[GitHub] spark pull request: [SPARK-13992][WIP] Add support for off-heap ca...

2016-03-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11805#issuecomment-201984448 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-13992][WIP] Add support for off-heap ca...

2016-03-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11805#issuecomment-201984454 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-13992][WIP] Add support for off-heap ca...

2016-03-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11805#issuecomment-201984028 **[Test build #54272 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54272/consoleFull)** for PR 11805 at commit [`df8be62`](https://g

[GitHub] spark pull request: [SPARK-14156][SQL] Use executedPlan in HiveCom...

2016-03-26 Thread viirya
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/11957#issuecomment-201982155 @yhuai I added it to PR description. Please let me know if it is clear now. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request: [SPARK-14156][SQL] Use executedPlan in HiveCom...

2016-03-26 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/11957#issuecomment-201981360 Can you attach an example showing the message before and the message after the change? Thanks! --- If your project is set up for it, you can reply to this email and have

[GitHub] spark pull request: [SPARK-14052] [SQL] build a BytesToBytesMap di...

2016-03-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11870#issuecomment-201980413 **[Test build #54273 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54273/consoleFull)** for PR 11870 at commit [`11b2364`](https://gi

[GitHub] spark pull request: [SPARK-14156][SQL] Use executedPlan in HiveCom...

2016-03-26 Thread viirya
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/11957#issuecomment-201979883 cc @yhuai @liancheng --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-14177] [SQL] Native Parsing for DDL Com...

2016-03-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/11977 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request: [SPARK-14177] [SQL] Native Parsing for DDL Com...

2016-03-26 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/11977#issuecomment-201979696 I have fixed the conflict. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have t

[GitHub] spark pull request: [SPARK-14157][SQL] Parse Drop Function DDL com...

2016-03-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/11959 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request: [SPARK-14177] [SQL] Native Parsing for DDL Com...

2016-03-26 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/11977#issuecomment-201979613 Merging to master. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have t

[GitHub] spark pull request: [SPARK-14157][SQL] Parse Drop Function DDL com...

2016-03-26 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/11959#issuecomment-201979487 LGTM. Merging to master. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-13289][MLLIB] Fix infinite distances be...

2016-03-26 Thread flyjy
Github user flyjy commented on the pull request: https://github.com/apache/spark/pull/11812#issuecomment-201971518 @MLnick This bug has been fixed without changing existing interfaces. Have tested it with your test script with Lee corpus from Gensim. I am not sure whether you

[GitHub] spark pull request: [SPARK-14157][SQL] Parse Drop Function DDL com...

2016-03-26 Thread viirya
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/11959#issuecomment-201971431 ping @yhuai --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark pull request: [SPARK-13992][WIP] Add support for off-heap ca...

2016-03-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11805#issuecomment-201971414 **[Test build #54272 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54272/consoleFull)** for PR 11805 at commit [`df8be62`](https://gi

[GitHub] spark pull request: [SPARK-14157][SQL] Parse Drop Function DDL com...

2016-03-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11959#issuecomment-201970947 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14157][SQL] Parse Drop Function DDL com...

2016-03-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11959#issuecomment-201970946 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14100][ML] Merging Estimator and Model:...

2016-03-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11983#issuecomment-201970903 **[Test build #54271 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54271/consoleFull)** for PR 11983 at commit [`bf14a24`](https://g

[GitHub] spark pull request: [SPARK-14100][ML] Merging Estimator and Model:...

2016-03-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11983#issuecomment-201970906 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14100][ML] Merging Estimator and Model:...

2016-03-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11983#issuecomment-201970905 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14157][SQL] Parse Drop Function DDL com...

2016-03-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11959#issuecomment-201970895 **[Test build #54268 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54268/consoleFull)** for PR 11959 at commit [`db23480`](https://g

[GitHub] spark pull request: [SPARK-14100][ML] Merging Estimator and Model:...

2016-03-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11983#issuecomment-201968589 **[Test build #54271 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54271/consoleFull)** for PR 11983 at commit [`bf14a24`](https://gi

[GitHub] spark pull request: [SPARK-14100][ML] Merging Estimator and Model:...

2016-03-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11983#issuecomment-201967263 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14100][ML] Merging Estimator and Model:...

2016-03-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11983#issuecomment-201967255 **[Test build #54270 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54270/consoleFull)** for PR 11983 at commit [`aa4b408`](https://g

[GitHub] spark pull request: [SPARK-14100][ML] Merging Estimator and Model:...

2016-03-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11983#issuecomment-201967262 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14100][ML] Merging Estimator and Model:...

2016-03-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11983#issuecomment-201966705 **[Test build #54270 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54270/consoleFull)** for PR 11983 at commit [`aa4b408`](https://gi

[GitHub] spark pull request: [SPARK-14070] [SQL] Use ORC data source for SQ...

2016-03-26 Thread tejasapatil
Github user tejasapatil commented on the pull request: https://github.com/apache/spark/pull/11891#issuecomment-201966523 @liancheng : I have made all requested changes as per review and also rebased. Can you please take a look ? --- If your project is set up for it, you can reply to

[GitHub] spark pull request: [SPARK-14100][ML] Merging Estimator and Model:...

2016-03-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11983#issuecomment-201964442 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14100][ML] Merging Estimator and Model:...

2016-03-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11983#issuecomment-201964443 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14100][ML] Merging Estimator and Model:...

2016-03-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11983#issuecomment-201964439 **[Test build #54269 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54269/consoleFull)** for PR 11983 at commit [`bc06166`](https://g

[GitHub] spark pull request: [SPARK-14100][ML] Merging Estimator and Model:...

2016-03-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11983#issuecomment-201964119 **[Test build #54269 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54269/consoleFull)** for PR 11983 at commit [`bc06166`](https://gi

[GitHub] spark pull request: [SPARK-14100][ML] Merging Estimator and Model:...

2016-03-26 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/11983#issuecomment-201963929 CC: @mengxr Here's the prototype --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-14100][ML] Merging Estimator and Model:...

2016-03-26 Thread jkbradley
GitHub user jkbradley opened a pull request: https://github.com/apache/spark/pull/11983 [SPARK-14100][ML] Merging Estimator and Model: prototype for StringIndexer ## What changes were proposed in this pull request? This is a *prototype*. It will be used to decide whether or

[GitHub] spark pull request: [SPARK-14169][Core]Add UninterruptibleThread

2016-03-26 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/11971#discussion_r57521413 --- Diff: core/src/main/scala/org/apache/spark/util/UninterruptibleThread.scala --- @@ -0,0 +1,106 @@ +/* + * Licensed to the Apache Software Foundati

[GitHub] spark pull request: [SPARK-14169][Core]Add UninterruptibleThread

2016-03-26 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/11971#issuecomment-201960142 Yes, my suggestion would make the whole thread uninterruptible. But from the only use case, it seems that would be ok - there are no calls I see that can be interrupted

[GitHub] spark pull request: [SPARK-14070] [SQL] Use ORC data source for SQ...

2016-03-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11891#issuecomment-201959124 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14070] [SQL] Use ORC data source for SQ...

2016-03-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11891#issuecomment-201959127 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14070] [SQL] Use ORC data source for SQ...

2016-03-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11891#issuecomment-201958767 **[Test build #54267 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54267/consoleFull)** for PR 11891 at commit [`3c25e7e`](https://g

[GitHub] spark pull request: [SPARK-14163][CORE] SumEvaluator and countAppr...

2016-03-26 Thread mtustin-handy
Github user mtustin-handy commented on a diff in the pull request: https://github.com/apache/spark/pull/11982#discussion_r57521152 --- Diff: core/src/main/scala/org/apache/spark/partial/SumEvaluator.scala --- @@ -56,9 +56,12 @@ private[spark] class SumEvaluator(totalOutputs: Int,

[GitHub] spark pull request: [SPARK-14163][CORE] SumEvaluator and countAppr...

2016-03-26 Thread yongtang
Github user yongtang commented on a diff in the pull request: https://github.com/apache/spark/pull/11981#discussion_r57521139 --- Diff: core/src/main/scala/org/apache/spark/partial/SumEvaluator.scala --- @@ -42,6 +42,14 @@ private[spark] class SumEvaluator(totalOutputs: Int, confi

[GitHub] spark pull request: [SPARK-14163][CORE] SumEvaluator and countAppr...

2016-03-26 Thread yongtang
Github user yongtang commented on a diff in the pull request: https://github.com/apache/spark/pull/11981#discussion_r57521128 --- Diff: core/src/main/scala/org/apache/spark/partial/SumEvaluator.scala --- @@ -42,6 +42,14 @@ private[spark] class SumEvaluator(totalOutputs: Int, confi

[GitHub] spark pull request: [SPARK-14157][SQL] Parse Drop Function DDL com...

2016-03-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11959#issuecomment-201952198 **[Test build #54268 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54268/consoleFull)** for PR 11959 at commit [`db23480`](https://gi

[GitHub] spark pull request: [SPARK-14163][CORE] SumEvaluator and countAppr...

2016-03-26 Thread mtustin-handy
Github user mtustin-handy commented on a diff in the pull request: https://github.com/apache/spark/pull/11982#discussion_r57521048 --- Diff: core/src/main/scala/org/apache/spark/partial/SumEvaluator.scala --- @@ -56,9 +56,12 @@ private[spark] class SumEvaluator(totalOutputs: Int,

[GitHub] spark pull request: [SPARK-14163][CORE] SumEvaluator and countAppr...

2016-03-26 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/11982#discussion_r57521027 --- Diff: core/src/main/scala/org/apache/spark/partial/SumEvaluator.scala --- @@ -56,9 +56,12 @@ private[spark] class SumEvaluator(totalOutputs: Int, confide

[GitHub] spark pull request: [SPARK-14163][CORE] SumEvaluator and countAppr...

2016-03-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11982#issuecomment-201951571 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your p

[GitHub] spark pull request: [SPARK-14163][CORE] SumEvaluator and countAppr...

2016-03-26 Thread marcintustin
Github user marcintustin commented on the pull request: https://github.com/apache/spark/pull/11981#issuecomment-201951574 FYI I have a more parsimonious change here: #11982 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] spark pull request: [SPARK-14163][CORE] SumEvaluator and countAppr...

2016-03-26 Thread mtustin-handy
GitHub user mtustin-handy opened a pull request: https://github.com/apache/spark/pull/11982 [SPARK-14163][CORE] SumEvaluator and countApprox cannot reliably handle RDDs of size 1 ## What changes were proposed in this pull request? This special cases 0 and 1 counts to avoid

[GitHub] spark pull request: [SPARK-14163][CORE] SumEvaluator and countAppr...

2016-03-26 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/11981#discussion_r57520944 --- Diff: core/src/main/scala/org/apache/spark/partial/SumEvaluator.scala --- @@ -42,6 +42,14 @@ private[spark] class SumEvaluator(totalOutputs: Int, confide

[GitHub] spark pull request: [SPARK-14163][CORE] SumEvaluator and countAppr...

2016-03-26 Thread marcintustin
Github user marcintustin commented on a diff in the pull request: https://github.com/apache/spark/pull/11981#discussion_r57520937 --- Diff: core/src/main/scala/org/apache/spark/partial/SumEvaluator.scala --- @@ -42,6 +42,14 @@ private[spark] class SumEvaluator(totalOutputs: Int, c

[GitHub] spark pull request: [SPARK-14163][CORE] SumEvaluator and countAppr...

2016-03-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11981#issuecomment-201949785 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your p

[GitHub] spark pull request: [SPARK-14177] [SQL] Native Parsing for DDL Com...

2016-03-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11977#issuecomment-201949680 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14177] [SQL] Native Parsing for DDL Com...

2016-03-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11977#issuecomment-201949678 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14163][CORE] SumEvaluator and countAppr...

2016-03-26 Thread yongtang
GitHub user yongtang opened a pull request: https://github.com/apache/spark/pull/11981 [SPARK-14163][CORE] SumEvaluator and countApprox cannot reliably handle RDDs of size 1. ## What changes were proposed in this pull request? This fix fixes issues in SPARK-14163 where SumE

[GitHub] spark pull request: [SPARK-14177] [SQL] Native Parsing for DDL Com...

2016-03-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11977#issuecomment-201949626 **[Test build #54266 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54266/consoleFull)** for PR 11977 at commit [`6517f1f`](https://g

[GitHub] spark pull request: [SPARK-14116][SQL] Implements buildReader() fo...

2016-03-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/11936 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request: [SPARK-14116][SQL] Implements buildReader() fo...

2016-03-26 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/11936#issuecomment-201948284 Thanks. I am merging this to master. @liancheng @cloud-fan Let's address https://github.com/apache/spark/pull/11936/files#r57520723 in either of your PR for oth

[GitHub] spark pull request: [SPARK-14116][SQL] Implements buildReader() fo...

2016-03-26 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/11936#discussion_r57520723 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileSourceStrategy.scala --- @@ -56,9 +55,10 @@ import org.apache.spark.sql.types

[GitHub] spark pull request: [SPARK-14071][PySpark][ML]Change MLWritable.wr...

2016-03-26 Thread wangmiao1981
Github user wangmiao1981 commented on the pull request: https://github.com/apache/spark/pull/11945#issuecomment-201947768 @jkbradley I am not sure whether the property tag will change the appearance of the members in the doc. I can do a quick check by roll-back the change to check whe

[GitHub] spark pull request: [SPARK-14070] [SQL] Use ORC data source for SQ...

2016-03-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11891#issuecomment-201945963 **[Test build #54267 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54267/consoleFull)** for PR 11891 at commit [`3c25e7e`](https://gi

[GitHub] spark pull request: [SPARK-14070] [SQL] Use ORC data source for SQ...

2016-03-26 Thread tejasapatil
Github user tejasapatil commented on the pull request: https://github.com/apache/spark/pull/11891#issuecomment-201945359 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featur

[GitHub] spark pull request: SPARK-14139 Dataset loses nullability in opera...

2016-03-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11980#issuecomment-201943853 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: SPARK-14139 Dataset loses nullability in opera...

2016-03-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11980#issuecomment-201943850 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: SPARK-14139 Dataset loses nullability in opera...

2016-03-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11980#issuecomment-201943320 **[Test build #54265 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54265/consoleFull)** for PR 11980 at commit [`3e32b6a`](https://g

[GitHub] spark pull request: [SPARK-14013][SQL] Proper temp function suppor...

2016-03-26 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/11972#issuecomment-201941448 Overall looks good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] spark pull request: [SPARK-14013][SQL] Proper temp function suppor...

2016-03-26 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/11972#discussion_r57520314 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/hiveUDFs.scala --- @@ -141,6 +141,16 @@ private[hive] class HiveFunctionRegistry( }

[GitHub] spark pull request: [SPARK-14013][SQL] Proper temp function suppor...

2016-03-26 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/11972#discussion_r57520291 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala --- @@ -476,33 +497,29 @@ class SessionCatalog(externalCatalo

[GitHub] spark pull request: [SPARK-14177] [SQL] Native Parsing for DDL Com...

2016-03-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11977#issuecomment-201936414 **[Test build #54266 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54266/consoleFull)** for PR 11977 at commit [`6517f1f`](https://gi

  1   2   >