[GitHub] spark pull request: [SPARK-13981][SQL] Defer evaluating variables ...

2016-03-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11792#issuecomment-202624401 **[Test build #2706 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2706/consoleFull)** for PR 11792 at commit

[GitHub] spark pull request: [SPARK-14169][Core]Add UninterruptibleThread

2016-03-28 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/11971#issuecomment-202624330 LGTM, merging to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-529] [sql] Modify SQLConf to use new co...

2016-03-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11570#issuecomment-202624172 **[Test build #54379 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54379/consoleFull)** for PR 11570 at commit

[GitHub] spark pull request: [SPARK-14217][SQL] Fix bug if parquet data has...

2016-03-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12017#issuecomment-202624157 **[Test build #54378 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54378/consoleFull)** for PR 12017 at commit

[GitHub] spark pull request: [SPARK-14013][SQL] Proper temp function suppor...

2016-03-28 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/11972#issuecomment-202624063 OK thanks, I'm merging this to unblock progress on other issues. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request: [SPARK-14214][SQL] Update state to provide get...

2016-03-28 Thread zsxwing
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/12013#issuecomment-202624013 LGTM except one nit --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-14206][SQL] buildReader() implementatio...

2016-03-28 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/12002#discussion_r57651085 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/orc/OrcRelation.scala --- @@ -145,15 +146,15 @@ private[sql] class DefaultSource

[GitHub] spark pull request: [SPARK-14155][SQL] Hide UserDefinedType interf...

2016-03-28 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/11955#issuecomment-202624040 Merging in master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-13923][SPARK-14014][SQL] Session catalo...

2016-03-28 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/12006#issuecomment-202623706 Thanks merging into master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-14217][SQL] Fix bug if parquet data has...

2016-03-28 Thread nongli
GitHub user nongli opened a pull request: https://github.com/apache/spark/pull/12017 [SPARK-14217][SQL] Fix bug if parquet data has columns that use dictionary encoding for some of the data ## What changes were proposed in this pull request? Currently, this causes batches

[GitHub] spark pull request: [SPARK-14206][SQL] buildReader() implementatio...

2016-03-28 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/12002#discussion_r57650888 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/sources/interfaces.scala --- @@ -385,9 +385,9 @@ abstract class OutputWriter { * *

[GitHub] spark pull request: [SPARK-529] [sql] Modify SQLConf to use new co...

2016-03-28 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/11570#issuecomment-202623532 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-14180][Core]Fix a deadlock in CoarseGra...

2016-03-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12012#issuecomment-202623370 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14180][Core]Fix a deadlock in CoarseGra...

2016-03-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12012#issuecomment-202623368 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14180][Core]Fix a deadlock in CoarseGra...

2016-03-28 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/12012#issuecomment-202623429 LGTM merging into master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-14134] [core] [test-maven] Change the p...

2016-03-28 Thread vanzin
Github user vanzin closed the pull request at: https://github.com/apache/spark/pull/11941 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-14013][SQL] Proper temp function suppor...

2016-03-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11972#issuecomment-202623274 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14134] [core] [test-maven] Change the p...

2016-03-28 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/11941#issuecomment-202623315 I'm gonna close this for now since #11796 is passing without this patch... no idea how. --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark pull request: [SPARK-13579][build][test-maven] Stop building...

2016-03-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11796#issuecomment-202623175 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14086][SQL] Add DDL commands to ANTLR4 ...

2016-03-28 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/12011#issuecomment-202623176 Merging into master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-13579][build][test-maven] Stop building...

2016-03-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11796#issuecomment-202623179 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14013][SQL] Proper temp function suppor...

2016-03-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11972#issuecomment-202623270 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14180][Core]Fix a deadlock in CoarseGra...

2016-03-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12012#issuecomment-202623146 **[Test build #54357 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54357/consoleFull)** for PR 12012 at commit

[GitHub] spark pull request: [SPARK-14013][SQL] Proper temp function suppor...

2016-03-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11972#issuecomment-202623018 **[Test build #54362 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54362/consoleFull)** for PR 11972 at commit

[GitHub] spark pull request: [SPARK-13579][build][test-maven] Stop building...

2016-03-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11796#issuecomment-202622829 **[Test build #54358 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54358/consoleFull)** for PR 11796 at commit

[GitHub] spark pull request: [SPARK-14086][SQL] Add DDL commands to ANTLR4 ...

2016-03-28 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/12011#issuecomment-202622765 LGTM pretty straightforward --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [DO_NOT_MERGE]Try to reproduce StateStoreRDDSu...

2016-03-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12005#issuecomment-202621204 **[Test build #54377 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54377/consoleFull)** for PR 12005 at commit

[GitHub] spark pull request: [SPARK-14214][SQL] Update state to provide get...

2016-03-28 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/12013#discussion_r57649905 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/HDFSBackedStateStoreProvider.scala --- @@ -94,15 +94,14 @@ private[state]

[GitHub] spark pull request: [SPARK-14086][SQL] Add DDL commands to ANTLR4 ...

2016-03-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12011#issuecomment-202620050 **[Test build #2704 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2704/consoleFull)** for PR 12011 at commit

[GitHub] spark pull request: [SPARK-14214][SQL] Update state to provide get...

2016-03-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12013#issuecomment-202619872 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14214][SQL] Update state to provide get...

2016-03-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12013#issuecomment-202619869 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14214][SQL] Update state to provide get...

2016-03-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12013#issuecomment-202619573 **[Test build #54361 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54361/consoleFull)** for PR 12013 at commit

[GitHub] spark pull request: SPARK-14113. Consider marking JobConf closure-...

2016-03-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11978#issuecomment-202619019 **[Test build #54375 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54375/consoleFull)** for PR 11978 at commit

[GitHub] spark pull request: [SPARK-14176][SQL]Add DataFrameWriter.trigger ...

2016-03-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11976#issuecomment-202618988 **[Test build #54376 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54376/consoleFull)** for PR 11976 at commit

[GitHub] spark pull request: SPARK-14113. Consider marking JobConf closure-...

2016-03-28 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/11978#issuecomment-202617742 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-14215] [SQL] [PYSPARK] Support chained ...

2016-03-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12014#issuecomment-202617628 **[Test build #2705 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2705/consoleFull)** for PR 12014 at commit

[GitHub] spark pull request: [SPARK-14184][SQL] Support native execution of...

2016-03-28 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/11991#discussion_r57648372 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkQl.scala --- @@ -369,13 +369,33 @@ private[sql] class SparkQl(conf: ParserConf =

[GitHub] spark pull request: [SPARK-13713] [SQL] [test-maven] Add Antlr4 ma...

2016-03-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12010#issuecomment-202617177 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13713] [SQL] [test-maven] Add Antlr4 ma...

2016-03-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12010#issuecomment-202617173 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14214][SQL] Update state to provide get...

2016-03-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12013#issuecomment-202617101 **[Test build #2703 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2703/consoleFull)** for PR 12013 at commit

[GitHub] spark pull request: [SPARK-13713] [SQL] [test-maven] Add Antlr4 ma...

2016-03-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12010#issuecomment-202616883 **[Test build #54356 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54356/consoleFull)** for PR 12010 at commit

[GitHub] spark pull request: [SPARK-13992][WIP] Add support for off-heap ca...

2016-03-28 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/11805#issuecomment-202616817 Discovered a potentially major problem: if we bail out of a getOrElseUpdate call and don't end up caching a block and then do not fully consume or dispose of the

[GitHub] spark pull request: [SPARK-14163][CORE] SumEvaluator and countAppr...

2016-03-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12016#issuecomment-202616434 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14163][CORE] SumEvaluator and countAppr...

2016-03-28 Thread mtustin-handy
GitHub user mtustin-handy opened a pull request: https://github.com/apache/spark/pull/12016 [SPARK-14163][CORE] SumEvaluator and countApprox cannot reliably handle RDDs of size 1 ## What changes were proposed in this pull request? This special cases 0 and 1 counts to avoid

[GitHub] spark pull request: [SPARK-14180][Core]Fix a deadlock in CoarseGra...

2016-03-28 Thread zsxwing
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/12012#issuecomment-202614420 > Can you write a regression test? This bug wasn't caught by existing tests. I tried. But it's really hard to write such test. E.g., even if this dead lock

[GitHub] spark pull request: [SPARK-11730][ML] Add feature importances for ...

2016-03-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11961#issuecomment-202613948 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14180][Core]Fix a deadlock in CoarseGra...

2016-03-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12012#issuecomment-202613879 **[Test build #54374 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54374/consoleFull)** for PR 12012 at commit

[GitHub] spark pull request: [SPARK-11730][ML] Add feature importances for ...

2016-03-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11961#issuecomment-202613953 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14180][Core]Fix a deadlock in CoarseGra...

2016-03-28 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/12012#discussion_r57646611 --- Diff: core/src/main/scala/org/apache/spark/executor/CoarseGrainedExecutorBackend.scala --- @@ -113,9 +113,9 @@ private[spark] class

[GitHub] spark pull request: [SPARK-14184][SQL] Support native execution of...

2016-03-28 Thread dilipbiswal
Github user dilipbiswal commented on a diff in the pull request: https://github.com/apache/spark/pull/11991#discussion_r57646589 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkQl.scala --- @@ -369,13 +369,33 @@ private[sql] class SparkQl(conf: ParserConf =

[GitHub] spark pull request: [SPARK-11730][ML] Add feature importances for ...

2016-03-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11961#issuecomment-202613345 **[Test build #54368 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54368/consoleFull)** for PR 11961 at commit

[GitHub] spark pull request: [SPARK-14163][CORE] SumEvaluator and countAppr...

2016-03-28 Thread mtustin-handy
Github user mtustin-handy closed the pull request at: https://github.com/apache/spark/pull/11982 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark pull request: [SPARK-14163][CORE] SumEvaluator and countAppr...

2016-03-28 Thread mtustin-handy
Github user mtustin-handy commented on the pull request: https://github.com/apache/spark/pull/11982#issuecomment-202611779 @rxin @srowen Looks like github is not showing the correct diff any more. I'm going to close this, reopen and tag you. --- If your project is set up for it, you

[GitHub] spark pull request: [DO_NOT_MERGE]Try to reproduce StateStoreRDDSu...

2016-03-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12005#issuecomment-202611123 **[Test build #54337 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54337/consoleFull)** for PR 12005 at commit

[GitHub] spark pull request: [DO_NOT_MERGE]Try to reproduce StateStoreRDDSu...

2016-03-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12005#issuecomment-202611143 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14184][SQL] Support native execution of...

2016-03-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11991#issuecomment-202611071 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14184][SQL] Support native execution of...

2016-03-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11991#issuecomment-202611076 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [DO_NOT_MERGE]Try to reproduce StateStoreRDDSu...

2016-03-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12005#issuecomment-202611140 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11893] Model export/import for spark.ml...

2016-03-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/9971 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-14184][SQL] Support native execution of...

2016-03-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11991#issuecomment-202611059 **[Test build #54373 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54373/consoleFull)** for PR 11991 at commit

[GitHub] spark pull request: [SPARK-14086][SQL] Add DDL commands to ANTLR4 ...

2016-03-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12011#issuecomment-202610478 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14086][SQL] Add DDL commands to ANTLR4 ...

2016-03-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12011#issuecomment-202610482 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14119][SPARK-14120][SPARK-14122][SQL] T...

2016-03-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11948#issuecomment-202605688 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14086][SQL] Add DDL commands to ANTLR4 ...

2016-03-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12011#issuecomment-202609279 **[Test build #54359 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54359/consoleFull)** for PR 12011 at commit

[GitHub] spark pull request: [SPARK-14155][SQL] Hide UserDefinedType interf...

2016-03-28 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/11955#issuecomment-202609629 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-14184][SQL] Support native execution of...

2016-03-28 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/11991#issuecomment-202605622 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-11893] Model export/import for spark.ml...

2016-03-28 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/9971#issuecomment-202608988 LGTM Merging with master Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14184][SQL] Support native execution of...

2016-03-28 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/11991#discussion_r57644828 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkQl.scala --- @@ -369,13 +369,33 @@ private[sql] class SparkQl(conf: ParserConf =

[GitHub] spark pull request: [SPARK-14184][SQL] Support native execution of...

2016-03-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11991#issuecomment-202607728 **[Test build #54373 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54373/consoleFull)** for PR 11991 at commit

[GitHub] spark pull request: [SPARK-14184][SQL] Support native execution of...

2016-03-28 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/11991#issuecomment-202605966 FYI this blocks on #12009. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-14052] [SQL] build a BytesToBytesMap di...

2016-03-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11870#issuecomment-202605115 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14119][SPARK-14120][SPARK-14122][SQL] T...

2016-03-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11948#issuecomment-202605684 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14119][SPARK-14120][SPARK-14122][SQL] T...

2016-03-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11948#issuecomment-202605002 **[Test build #54350 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54350/consoleFull)** for PR 11948 at commit

[GitHub] spark pull request: [SPARK-14052] [SQL] build a BytesToBytesMap di...

2016-03-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11870#issuecomment-202604607 **[Test build #54351 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54351/consoleFull)** for PR 11870 at commit

[GitHub] spark pull request: [SPARK-14052] [SQL] build a BytesToBytesMap di...

2016-03-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11870#issuecomment-202605114 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-7425] [ML] spark.ml Predictor should su...

2016-03-28 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/10355#issuecomment-202603261 This looks to be in very good shape. My main comment is about unit test time: the tests take a significant amount of time. Wherever it is easy to do, could you set

[GitHub] spark pull request: [SPARK-13241] [Web UI] Added long values for d...

2016-03-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11326#issuecomment-202603096 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13241] [Web UI] Added long values for d...

2016-03-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11326#issuecomment-202603097 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14160] Time Windowing functions for Dat...

2016-03-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12008#issuecomment-202602915 **[Test build #54372 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54372/consoleFull)** for PR 12008 at commit

[GitHub] spark pull request: [SPARK-13241] [Web UI] Added long values for d...

2016-03-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11326#issuecomment-202602824 **[Test build #54353 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54353/consoleFull)** for PR 11326 at commit

[GitHub] spark pull request: [SPARK-7425] [ML] spark.ml Predictor should su...

2016-03-28 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/10355#discussion_r57643358 --- Diff: mllib/src/test/scala/org/apache/spark/ml/util/MLTestingUtils.scala --- @@ -17,14 +17,116 @@ package org.apache.spark.ml.util

[GitHub] spark pull request: [SPARK-7425] [ML] spark.ml Predictor should su...

2016-03-28 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/10355#discussion_r57643353 --- Diff: mllib/src/main/scala/org/apache/spark/ml/util/SchemaUtils.scala --- @@ -61,6 +61,20 @@ private[spark] object SchemaUtils { }

[GitHub] spark pull request: [SPARK-14160] Time Windowing functions for Dat...

2016-03-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12008#issuecomment-202602213 **[Test build #54371 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54371/consoleFull)** for PR 12008 at commit

[GitHub] spark pull request: [SPARK-14160] Time Windowing functions for Dat...

2016-03-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12008#issuecomment-202602220 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14160] Time Windowing functions for Dat...

2016-03-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12008#issuecomment-202602224 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14160] Time Windowing functions for Dat...

2016-03-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12008#issuecomment-202601899 **[Test build #54371 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54371/consoleFull)** for PR 12008 at commit

[GitHub] spark pull request: [SPARK-14215] [SQL] [PYSPARK] Support chained ...

2016-03-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12014#issuecomment-202601667 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14215] [SQL] [PYSPARK] Support chained ...

2016-03-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12014#issuecomment-202601669 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14182] [SQL] Parse DDL Command: Alter V...

2016-03-28 Thread hvanhovell
Github user hvanhovell commented on the pull request: https://github.com/apache/spark/pull/11987#issuecomment-202601642 @gatorsmile this looks pretty solid. Could you take a look at https://github.com/apache/spark/pull/12011 and rebase against that? Let me know if you need some

[GitHub] spark pull request: [SPARK-14215] [SQL] [PYSPARK] Support chained ...

2016-03-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12014#issuecomment-202601623 **[Test build #54365 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54365/consoleFull)** for PR 12014 at commit

[GitHub] spark pull request: [SPARK-14124] [SQL] Implement Database-related...

2016-03-28 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/12009#issuecomment-202601202 Looks great. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-14182] [SQL] Parse DDL Command: Alter V...

2016-03-28 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/11987#discussion_r57642753 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLCommandSuite.scala --- @@ -389,21 +415,61 @@ class DDLCommandSuite extends

[GitHub] spark pull request: [SPARK-14182] [SQL] Parse DDL Command: Alter V...

2016-03-28 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/11987#discussion_r57642548 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala --- @@ -106,17 +105,20 @@ case class DropFunction( isTemp:

[GitHub] spark pull request: [SPARK-14124] [SQL] Implement Database-related...

2016-03-28 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/12009#discussion_r57642492 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala --- @@ -318,6 +320,138 @@ case class DescribeCommand( }

[GitHub] spark pull request: [SPARK-14182] [SQL] Parse DDL Command: Alter V...

2016-03-28 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/11987#discussion_r57642374 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkQl.scala --- @@ -249,8 +249,9 @@ private[sql] class SparkQl(conf: ParserConf =

[GitHub] spark pull request: [SPARK-14124] [SQL] Implement Database-related...

2016-03-28 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/12009#discussion_r57642335 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala --- @@ -104,6 +104,13 @@ class

[GitHub] spark pull request: [SPARK-14124] [SQL] Implement Database-related...

2016-03-28 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/12009#discussion_r57642224 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala --- @@ -104,6 +104,13 @@ class

[GitHub] spark pull request: [SPARK-14086][SQL] Add DDL commands to ANTLR4 ...

2016-03-28 Thread hvanhovell
Github user hvanhovell closed the pull request at: https://github.com/apache/spark/pull/11905 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark pull request: [SPARK-14160] Time Windowing functions for Dat...

2016-03-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12008#issuecomment-202598872 **[Test build #54370 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54370/consoleFull)** for PR 12008 at commit

[GitHub] spark pull request: [SPARK-14160] Time Windowing functions for Dat...

2016-03-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12008#issuecomment-202598875 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

<    1   2   3   4   5   6   7   8   9   10   >