[GitHub] spark pull request: [SPARK-14160] Time Windowing functions for Dat...

2016-03-28 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/12008#discussion_r57617336 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/TimeWindow.scala --- @@ -0,0 +1,111 @@ +/* + * Licensed to the

[GitHub] spark pull request: [SPARK-14170] [infra] Simplify the PR template...

2016-03-28 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/11973#issuecomment-202536302 As I said, just read the contributing.md file in, for each line that is not heading, remove the line from the pr description. --- If your project is set up for it, you

[GitHub] spark pull request: [SPARK-14160] Time Windowing functions for Dat...

2016-03-28 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/12008#discussion_r57617310 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/TimeWindow.scala --- @@ -0,0 +1,111 @@ +/* + * Licensed to the

[GitHub] spark pull request: [SPARK-14160] Time Windowing functions for Dat...

2016-03-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12008#issuecomment-202535639 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14160] Time Windowing functions for Dat...

2016-03-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12008#issuecomment-202535636 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14160] Time Windowing functions for Dat...

2016-03-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12008#issuecomment-202535622 **[Test build #54344 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54344/consoleFull)** for PR 12008 at commit

[GitHub] spark pull request: [SPARK-14205][SQL] remove trait Queryable

2016-03-28 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/12001#issuecomment-202535163 ``` [error] /home/jenkins/workspace/SparkPullRequestBuilder/sql/core/src/test/scala/org/apache/spark/sql/QueryTest.scala:31: object Queryable is not a member of

[GitHub] spark pull request: [SPARK-14160] Time Windowing functions for Dat...

2016-03-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12008#issuecomment-202534895 **[Test build #54344 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54344/consoleFull)** for PR 12008 at commit

[GitHub] spark pull request: [SPARK-14050][ML] Add multiple languages suppo...

2016-03-28 Thread burakkose
Github user burakkose commented on the pull request: https://github.com/apache/spark/pull/11871#issuecomment-202534323 Jenkins retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-14013][SQL] Proper temp function suppor...

2016-03-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11972#issuecomment-202531601 **[Test build #54341 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54341/consoleFull)** for PR 11972 at commit

[GitHub] spark pull request: [SPARK-14160] Time Windowing functions for Dat...

2016-03-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12008#issuecomment-202533309 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14160] Time Windowing functions for Dat...

2016-03-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12008#issuecomment-202533304 **[Test build #54343 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54343/consoleFull)** for PR 12008 at commit

[GitHub] spark pull request: [SPARK-14160] Time Windowing functions for Dat...

2016-03-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12008#issuecomment-202533314 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14160] Time Windowing functions for Dat...

2016-03-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12008#issuecomment-202533134 **[Test build #54343 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54343/consoleFull)** for PR 12008 at commit

[GitHub] spark pull request: [SPARK-14160] Time Windowing functions for Dat...

2016-03-28 Thread brkyvz
GitHub user brkyvz opened a pull request: https://github.com/apache/spark/pull/12008 [SPARK-14160] Time Windowing functions for DataSets ## What changes were proposed in this pull request? This PR adds the function `window` as a column expression. `window` can be

[GitHub] spark pull request: [SPARK-14176][SQL]Add DataFrameWriter.trigger ...

2016-03-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11976#issuecomment-202532927 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14176][SQL]Add DataFrameWriter.trigger ...

2016-03-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11976#issuecomment-202532926 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14176][SQL]Add DataFrameWriter.trigger ...

2016-03-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11976#issuecomment-202532343 **[Test build #54329 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54329/consoleFull)** for PR 11976 at commit

[GitHub] spark pull request: [SPARK-14119][SPARK-14120][SPARK-14122][SQL] T...

2016-03-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11948#issuecomment-202527512 **[Test build #54338 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54338/consoleFull)** for PR 11948 at commit

[GitHub] spark pull request: [SPARK-14210][SQL] Add a metric for time spent...

2016-03-28 Thread nongli
GitHub user nongli opened a pull request: https://github.com/apache/spark/pull/12007 [SPARK-14210][SQL] Add a metric for time spent in scans. ## What changes were proposed in this pull request? This adds a metric to parquet scans that measures the time in just the scan

[GitHub] spark pull request: [SPARK-14210][SQL] Add a metric for time spent...

2016-03-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12007#issuecomment-202531559 **[Test build #54340 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54340/consoleFull)** for PR 12007 at commit

[GitHub] spark pull request: [SPARK-13981][SQL] Defer evaluating variables ...

2016-03-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11792#issuecomment-202531604 **[Test build #54342 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54342/consoleFull)** for PR 11792 at commit

[GitHub] spark pull request: [SPARK-12299][CORE][WIP] Remove history servin...

2016-03-28 Thread steveloughran
Github user steveloughran commented on the pull request: https://github.com/apache/spark/pull/10991#issuecomment-202530245 There's a more fundamental issue which the history server has too: log replay is too expensive for long-lived applications. replay time is O(jobs)+O(stages),

[GitHub] spark pull request: [SPARK-14210][SQL] Add a metric for time spent...

2016-03-28 Thread nongli
Github user nongli commented on the pull request: https://github.com/apache/spark/pull/12007#issuecomment-202529228 Here's a screenshot of what this looks like. ![screen shot 2016-03-28 at 11 56 33

[GitHub] spark pull request: [SPARK-13923][SPARK-14014][SQL] Session catalo...

2016-03-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12006#issuecomment-202529068 **[Test build #54339 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54339/consoleFull)** for PR 12006 at commit

[GitHub] spark pull request: [SPARK-14013][SQL] Proper temp function suppor...

2016-03-28 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/11972#discussion_r57614602 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala --- @@ -476,33 +497,29 @@ class

[GitHub] spark pull request: [SPARK-7481][build][WIP] Add Hadoop 2.6+ profi...

2016-03-28 Thread steveloughran
Github user steveloughran commented on a diff in the pull request: https://github.com/apache/spark/pull/12004#discussion_r57614456 --- Diff: cloud/pom.xml --- @@ -0,0 +1,141 @@ + + +http://maven.apache.org/POM/4.0.0;

[GitHub] spark pull request: [SPARK-13923][SPARK-14014][SQL] Session catalo...

2016-03-28 Thread andrewor14
GitHub user andrewor14 opened a pull request: https://github.com/apache/spark/pull/12006 [SPARK-13923][SPARK-14014][SQL] Session catalog follow-ups ## What changes were proposed in this pull request? This patch addresses the remaining comments left in #11750 and #11918

[GitHub] spark pull request: [SPARK-14119][SPARK-14120][SPARK-14122][SQL] T...

2016-03-28 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/11948#issuecomment-202526659 OK, @yhuai PTAL --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-7481][build][WIP] Add Hadoop 2.6+ profi...

2016-03-28 Thread nchammas
Github user nchammas commented on a diff in the pull request: https://github.com/apache/spark/pull/12004#discussion_r57613179 --- Diff: cloud/pom.xml --- @@ -0,0 +1,141 @@ + + +http://maven.apache.org/POM/4.0.0; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;

[GitHub] spark pull request: [SPARK-14206][SQL] buildReader() implementatio...

2016-03-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12002#issuecomment-202525548 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14206][SQL] buildReader() implementatio...

2016-03-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12002#issuecomment-202525551 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-11730][ML] Add feature importances for ...

2016-03-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11961#issuecomment-202525379 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11730][ML] Add feature importances for ...

2016-03-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11961#issuecomment-202525383 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14206][SQL] buildReader() implementatio...

2016-03-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12002#issuecomment-202525074 **[Test build #54326 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54326/consoleFull)** for PR 12002 at commit

[GitHub] spark pull request: [SPARK-11730][ML] Add feature importances for ...

2016-03-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11961#issuecomment-202525173 **[Test build #54334 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54334/consoleFull)** for PR 11961 at commit

[GitHub] spark pull request: [SPARK-11893] Model export/import for spark.ml...

2016-03-28 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/9971#issuecomment-202524310 @yinxusen Thanks for the update. It looks good, but there was one missed item + a few more I found. I'm going to send a PR to update this PR. --- If your project

[GitHub] spark pull request: [SPARK-14205][SQL] remove trait Queryable

2016-03-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12001#issuecomment-202523636 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14205][SQL] remove trait Queryable

2016-03-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12001#issuecomment-202523631 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14205][SQL] remove trait Queryable

2016-03-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12001#issuecomment-202523512 **[Test build #54331 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54331/consoleFull)** for PR 12001 at commit

[GitHub] spark pull request: [DO_NOT_MERGE]Try to reproduce StateStoreRDDSu...

2016-03-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12005#issuecomment-202519885 **[Test build #54337 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54337/consoleFull)** for PR 12005 at commit

[GitHub] spark pull request: [DO_NOT_MERGE]Try to reproduce StateStoreRDDSu...

2016-03-28 Thread zsxwing
GitHub user zsxwing opened a pull request: https://github.com/apache/spark/pull/12005 [DO_NOT_MERGE]Try to reproduce StateStoreRDDSuite failure ## What changes were proposed in this pull request? (Please fill in changes proposed in this fix) ## How was this

[GitHub] spark pull request: [SPARK-14102][CORE] Block `reset` command in S...

2016-03-28 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/11920#issuecomment-202518284 Thank you, @srowen ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-13579][build][test-maven] Stop building...

2016-03-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11796#issuecomment-202517998 **[Test build #54336 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54336/consoleFull)** for PR 11796 at commit

[GitHub] spark pull request: [SPARK-7481][build][WIP] Add Hadoop 2.6+ profi...

2016-03-28 Thread steveloughran
Github user steveloughran commented on the pull request: https://github.com/apache/spark/pull/12004#issuecomment-202517351 Note that as this patch is is playing with the maven build and the hadoop-2.6 and hadoop-2.7 profiles, the SparkQA builds aren't going to pick up on much here.

[GitHub] spark pull request: [SPARK-13579][build][test-maven] Stop building...

2016-03-28 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/11796#issuecomment-202517146 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-14169][Core]Add UninterruptibleThread

2016-03-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11971#issuecomment-202516301 **[Test build #54335 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54335/consoleFull)** for PR 11971 at commit

[GitHub] spark pull request: SPARK-14113. Consider marking JobConf closure-...

2016-03-28 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/11978#issuecomment-202515698 Looks good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: SPARK-14113. Consider marking JobConf closure-...

2016-03-28 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/11978#discussion_r57609134 --- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala --- @@ -979,6 +979,7 @@ class SparkContext(config: SparkConf) extends Logging with

[GitHub] spark pull request: SPARK-14113. Consider marking JobConf closure-...

2016-03-28 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/11978#discussion_r57608918 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/orc/OrcRelation.scala --- @@ -317,12 +317,11 @@ private[orc] case class OrcTableScan(

[GitHub] spark pull request: SPARK-14113. Consider marking JobConf closure-...

2016-03-28 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/11978#discussion_r57608860 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/orc/OrcRelation.scala --- @@ -317,12 +317,11 @@ private[orc] case class OrcTableScan(

[GitHub] spark pull request: [SPARK-9312] [ML] Added max confidence factor ...

2016-03-28 Thread viktortnk
Github user viktortnk commented on the pull request: https://github.com/apache/spark/pull/7652#issuecomment-202514092 @jkbradley @badriub Any updates on this issue? From diff I see that `rawPrediction` has `Double` type. Should it return an Array of values from each binary

[GitHub] spark pull request: [SPARK-13579][build][test-maven] Stop building...

2016-03-28 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/11796#issuecomment-202513741 Hmm that's not the test I was expecting to fail. And the error looks very suspicious, as if there's something wrong with that test. Will take a look. retest this pleas

[GitHub] spark pull request: [SPARK-13579][build][test-maven] Stop building...

2016-03-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11796#issuecomment-202512059 **[Test build #54328 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54328/consoleFull)** for PR 11796 at commit

[GitHub] spark pull request: [SPARK-13579][build][test-maven] Stop building...

2016-03-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11796#issuecomment-202512080 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13579][build][test-maven] Stop building...

2016-03-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11796#issuecomment-202512086 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14052] [SQL] build a BytesToBytesMap di...

2016-03-28 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/11870#issuecomment-202511033 @sameeragarwal PING --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-11730][ML] Add feature importances for ...

2016-03-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11961#issuecomment-202510375 **[Test build #54334 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54334/consoleFull)** for PR 11961 at commit

[GitHub] spark pull request: [SPARK-11730][ML] Add feature importances for ...

2016-03-28 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/11961#discussion_r57606190 --- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/impl/GradientBoostedTrees.scala --- @@ -274,4 +276,24 @@ private[ml] object GradientBoostedTrees

[GitHub] spark pull request: [SPARK-14201][SQL] handle empty file for new d...

2016-03-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11999#issuecomment-202509973 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14201][SQL] handle empty file for new d...

2016-03-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11999#issuecomment-202509972 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14201][SQL] handle empty file for new d...

2016-03-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11999#issuecomment-202509442 **[Test build #54324 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54324/consoleFull)** for PR 11999 at commit

[GitHub] spark pull request: [SPARK-13981][SQL] Defer evaluating variables ...

2016-03-28 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/11792#discussion_r57605732 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/basicOperators.scala --- @@ -110,39 +114,81 @@ case class Filter(condition: Expression,

[GitHub] spark pull request: [SPARK-13981][SQL] Defer evaluating variables ...

2016-03-28 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/11792#issuecomment-202509546 LGTM, just two minor comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-11730][ML] Add feature importances for ...

2016-03-28 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/11961#discussion_r57605613 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/GBTClassifier.scala --- @@ -240,6 +240,17 @@ final class GBTClassificationModel

[GitHub] spark pull request: [SPARK-11730][ML] Add feature importances for ...

2016-03-28 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/11961#discussion_r57605639 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/RandomForestClassifier.scala --- @@ -222,16 +222,10 @@ final class

[GitHub] spark pull request: [SPARK-14201][SQL] handle empty file for new d...

2016-03-28 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/11999#discussion_r57605486 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/sources/interfaces.scala --- @@ -549,15 +549,18 @@ class HDFSFileCatalog( refresh()

[GitHub] spark pull request: [SPARK-7481][build][WIP] Add Hadoop 2.6+ profi...

2016-03-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12004#issuecomment-202508415 **[Test build #54333 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54333/consoleFull)** for PR 12004 at commit

[GitHub] spark pull request: [SPARK-7481][build][WIP] Add Hadoop 2.6+ profi...

2016-03-28 Thread steveloughran
GitHub user steveloughran opened a pull request: https://github.com/apache/spark/pull/12004 [SPARK-7481][build][WIP] Add Hadoop 2.6+ profile to pull in object store FS accesors ## What changes were proposed in this pull request? [SPARK-7481] Add Hadoop 2.6+ profile to pull

[GitHub] spark pull request: [SPARK-13981][SQL] Defer evaluating variables ...

2016-03-28 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/11792#discussion_r57605200 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/basicOperators.scala --- @@ -110,39 +114,81 @@ case class Filter(condition: Expression,

[GitHub] spark pull request: [SPARK-13902][SCHEDULER] Make DAGScheduler.get...

2016-03-28 Thread markhamstra
Github user markhamstra commented on a diff in the pull request: https://github.com/apache/spark/pull/11720#discussion_r57605206 --- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala --- @@ -286,6 +286,7 @@ class DAGScheduler( case None =>

[GitHub] spark pull request: [SPARK-14191][SQL] Fix Expand operator constra...

2016-03-28 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/11995#discussion_r57605112 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicOperators.scala --- @@ -518,8 +543,8 @@ private[sql] object Expand

[GitHub] spark pull request: [SPARK-14158][SQL] implement buildReader for j...

2016-03-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11960#issuecomment-202505765 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14158][SQL] implement buildReader for j...

2016-03-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11960#issuecomment-202505761 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13622][YARN] Issue creating level db fo...

2016-03-28 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/11475#issuecomment-202505573 @ashangit sorry for the delay, just one minor comment otherwise looks good. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request: [SPARK-13622][YARN] Issue creating level db fo...

2016-03-28 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/11475#discussion_r57604294 --- Diff: common/network-yarn/src/main/java/org/apache/spark/network/yarn/YarnShuffleService.java --- @@ -191,12 +192,12 @@ public void

[GitHub] spark pull request: [SPARK-14158][SQL] implement buildReader for j...

2016-03-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11960#issuecomment-202504866 **[Test build #54323 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54323/consoleFull)** for PR 11960 at commit

[GitHub] spark pull request: [SPARK-14134] [core] [test-maven] Change the p...

2016-03-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11941#issuecomment-202503698 **[Test build #54332 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54332/consoleFull)** for PR 11941 at commit

[GitHub] spark pull request: [SPARK-14169][Core]Add UninterruptibleThread

2016-03-28 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/11971#discussion_r57603613 --- Diff: core/src/main/scala/org/apache/spark/util/UninterruptibleThread.scala --- @@ -0,0 +1,106 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-14156][SQL] Use executedPlan in HiveCom...

2016-03-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/11957 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-14201][SQL] handle empty file for new d...

2016-03-28 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/11999#discussion_r57603199 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/sources/interfaces.scala --- @@ -549,15 +549,18 @@ class HDFSFileCatalog( refresh()

[GitHub] spark pull request: [SPARK-14169][Core]Add UninterruptibleThread

2016-03-28 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/11971#discussion_r57603003 --- Diff: core/src/main/scala/org/apache/spark/util/UninterruptibleThread.scala --- @@ -0,0 +1,106 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-14156][SQL] Use executedPlan in HiveCom...

2016-03-28 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/11957#issuecomment-202502268 Thanks. Merging to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-14143] Options for parsing NaNs, Infini...

2016-03-28 Thread falaki
Github user falaki commented on the pull request: https://github.com/apache/spark/pull/11947#issuecomment-202502231 ping @HyukjinKwon and @rxin --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-14158][SQL] implement buildReader for j...

2016-03-28 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/11960#discussion_r57602697 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/TestJsonData.scala --- @@ -32,7 +32,7 @@ private[json] trait TestJsonData {

[GitHub] spark pull request: [SPARK-14169][Core]Add UninterruptibleThread

2016-03-28 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/11971#discussion_r57602452 --- Diff: core/src/main/scala/org/apache/spark/util/UninterruptibleThread.scala --- @@ -0,0 +1,106 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-13844][SQL] Generate better code for fi...

2016-03-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/11684 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-14206][SQL] buildReader() implementatio...

2016-03-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12002#issuecomment-202500628 **[Test build #54330 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54330/consoleFull)** for PR 12002 at commit

[GitHub] spark pull request: [SPARK-14158][SQL] implement buildReader for j...

2016-03-28 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/11960#discussion_r57602134 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/TestJsonData.scala --- @@ -32,7 +32,7 @@ private[json] trait

[GitHub] spark pull request: [SPARK-14205][SQL] remove trait Queryable

2016-03-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12001#issuecomment-202500633 **[Test build #54331 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54331/consoleFull)** for PR 12001 at commit

[GitHub] spark pull request: [SPARK-14206][SQL] buildReader() implementatio...

2016-03-28 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/12002#discussion_r57601851 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetRelation.scala --- @@ -291,6 +291,7 @@ private[sql] class

[GitHub] spark pull request: [SPARK-14201][SQL] handle empty file for new d...

2016-03-28 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/11999#discussion_r57601790 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/sources/interfaces.scala --- @@ -549,15 +549,18 @@ class HDFSFileCatalog( refresh()

[GitHub] spark pull request: [SPARK-13844][SQL] Generate better code for fi...

2016-03-28 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/11684#issuecomment-202500100 LGTM, merging into master, thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-14169][Core]Add UninterruptibleThread

2016-03-28 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/11971#discussion_r57601601 --- Diff: core/src/main/scala/org/apache/spark/util/UninterruptibleThread.scala --- @@ -0,0 +1,106 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-14158][SQL] implement buildReader for j...

2016-03-28 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/11960#discussion_r57601454 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/TestJsonData.scala --- @@ -32,7 +32,7 @@ private[json] trait TestJsonData {

[GitHub] spark pull request: [SPARK-14201][SQL] handle empty file for new d...

2016-03-28 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/11999#discussion_r57600051 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/sources/interfaces.scala --- @@ -549,15 +549,18 @@ class HDFSFileCatalog( refresh()

[GitHub] spark pull request: [SPARK-14201][SQL] handle empty file for new d...

2016-03-28 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/11999#discussion_r57601423 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/sources/interfaces.scala --- @@ -549,15 +549,18 @@ class HDFSFileCatalog( refresh()

[GitHub] spark pull request: [SPARK-13579][build][test-maven] Stop building...

2016-03-28 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/11796#issuecomment-202496292 (just want to test how this behaves without the shading fix) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: [SPARK-14208][SQL] Renames spark.sql.parquet.f...

2016-03-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12003#issuecomment-202499123 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14176][SQL]Add DataFrameWriter.trigger ...

2016-03-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11976#issuecomment-202499223 **[Test build #54329 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54329/consoleFull)** for PR 11976 at commit

<    2   3   4   5   6   7   8   9   10   >