[GitHub] spark pull request: [SPARK-14231][SQL] JSON data source infers flo...

2016-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12030#issuecomment-204879901 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14231][SQL] JSON data source infers flo...

2016-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12030#issuecomment-204879902 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14231][SQL] JSON data source infers flo...

2016-04-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12030#issuecomment-204879875 **[Test build #54791 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54791/consoleFull)** for PR 12030 at commit

[GitHub] spark pull request: [SPARK-14349] [SQL] [WIP] Issue Error Messages...

2016-04-02 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/12134#issuecomment-204879643 cc @yhuai @hvanhovell Code is ready for review. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: [SPARK-14231][SQL] JSON data source infers flo...

2016-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12030#issuecomment-204879546 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14231][SQL] JSON data source infers flo...

2016-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12030#issuecomment-204879545 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14231][SQL] JSON data source infers flo...

2016-04-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12030#issuecomment-204879516 **[Test build #54790 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54790/consoleFull)** for PR 12030 at commit

[GitHub] spark pull request: [SPARK-14349] [SQL] [WIP] Issue Error Messages...

2016-04-02 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/12134#issuecomment-204876183 The same issue was found for create table: ```SQL CREATE EXTERNAL TABLE parquet_tab2(c1 INT, c2 STRING) TBLPROPERTIES('prop1Key '= "prop1Val", '

[GitHub] spark pull request: [SPARK-14349] [SQL] [WIP] Issue Error Messages...

2016-04-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12134#issuecomment-204867976 **[Test build #54792 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54792/consoleFull)** for PR 12134 at commit

[GitHub] spark pull request: [SPARK-14231][SQL] JSON data source infers flo...

2016-04-02 Thread HyukjinKwon
Github user HyukjinKwon commented on the pull request: https://github.com/apache/spark/pull/12030#issuecomment-204864387 @davies Actually, I am not sure if I understood the last comment correctly. Would you check the tests please? I added some tests for both merged types and

[GitHub] spark pull request: [SPARK-14231][SQL] JSON data source infers flo...

2016-04-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12030#issuecomment-204864352 **[Test build #54791 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54791/consoleFull)** for PR 12030 at commit

[GitHub] spark pull request: [CORE][SPARK-14178]DAGScheduler should get map...

2016-04-02 Thread witgo
Github user witgo closed the pull request at: https://github.com/apache/spark/pull/11986 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-14231][SQL] JSON data source infers flo...

2016-04-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12030#issuecomment-204864215 **[Test build #54790 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54790/consoleFull)** for PR 12030 at commit

[GitHub] spark pull request: [SPARK-14349] [SQL] [WIP] Issue Error Messages...

2016-04-02 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/12134#issuecomment-204861588 In SQL Context, the plan is wrong if we use CREATE VIEW AS SELECT. We need to ```scala sql("CREATE VIEW testView AS SELECT * FROM jt").explain(true)

[GitHub] spark pull request: [SPARK-14348][SQL] Support native execution of...

2016-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12133#issuecomment-204860955 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14348][SQL] Support native execution of...

2016-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12133#issuecomment-204860953 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14348][SQL] Support native execution of...

2016-04-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12133#issuecomment-204860912 **[Test build #54789 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54789/consoleFull)** for PR 12133 at commit

[GitHub] spark pull request: [SPARK-13996][SQL] Add more not null attribute...

2016-04-02 Thread viirya
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/11810#issuecomment-204857581 Thanks for reviewing this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-13996][SQL] Add more not null attribute...

2016-04-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/11810 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-13996][SQL] Add more not null attribute...

2016-04-02 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/11810#issuecomment-204857532 Merging this into master, thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-13996][SQL] Add more not null attribute...

2016-04-02 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/11810#issuecomment-204857528 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark pull request: [SPARK-14163][CORE] SumEvaluator and countAppr...

2016-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12016#issuecomment-204856873 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14163][CORE] SumEvaluator and countAppr...

2016-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12016#issuecomment-204856875 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14163][CORE] SumEvaluator and countAppr...

2016-04-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12016#issuecomment-204856731 **[Test build #54788 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54788/consoleFull)** for PR 12016 at commit

[GitHub] spark pull request: [SPARK-14338][SQL] Improve `SimplifyConditiona...

2016-04-02 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/12122#issuecomment-204855092 @dongjoon-hyun Can you take a look at the scala 2.10 build? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: [SPARK-14056] Appends s3 specific configuratio...

2016-04-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/11876 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-14056] Appends s3 specific configuratio...

2016-04-02 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/11876#issuecomment-204852979 Merged to master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-14349] [SQL] [WIP] Issue Error Messages...

2016-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12134#issuecomment-204848403 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14349] [SQL] [WIP] Issue Error Messages...

2016-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12134#issuecomment-204848402 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14349] [SQL] [WIP] Issue Error Messages...

2016-04-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12134#issuecomment-204848365 **[Test build #54787 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54787/consoleFull)** for PR 12134 at commit

[GitHub] spark pull request: [SPARK-14348][SQL] Support native execution of...

2016-04-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12133#issuecomment-204847481 **[Test build #54789 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54789/consoleFull)** for PR 12133 at commit

[GitHub] spark pull request: [SPARK-14231][SQL] JSON data source infers flo...

2016-04-02 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/12030#discussion_r58302753 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/TestJsonData.scala --- @@ -214,6 +214,11 @@ private[json] trait

[GitHub] spark pull request: [SPARK-14231][SQL] JSON data source infers flo...

2016-04-02 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/12030#discussion_r58302741 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala --- @@ -773,6 +773,45 @@ class JsonSuite extends QueryTest

[GitHub] spark pull request: [SPARK-14056] Appends s3 specific configuratio...

2016-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11876#issuecomment-204847005 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14056] Appends s3 specific configuratio...

2016-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11876#issuecomment-204847006 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14056] Appends s3 specific configuratio...

2016-04-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11876#issuecomment-204846967 **[Test build #54784 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54784/consoleFull)** for PR 11876 at commit

[GitHub] spark pull request: [SPARK-14123] [WIP] [SQL] Handle CreateFunctio...

2016-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12117#issuecomment-204846056 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14123] [WIP] [SQL] Handle CreateFunctio...

2016-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12117#issuecomment-204846060 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14123] [WIP] [SQL] Handle CreateFunctio...

2016-04-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12117#issuecomment-204845983 **[Test build #54785 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54785/consoleFull)** for PR 12117 at commit

[GitHub] spark pull request: [SPARK-13996][SQL] Add more not null attribute...

2016-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11810#issuecomment-204845229 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13996][SQL] Add more not null attribute...

2016-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11810#issuecomment-204845226 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13996][SQL] Add more not null attribute...

2016-04-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11810#issuecomment-204844841 **[Test build #54786 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54786/consoleFull)** for PR 11810 at commit

[GitHub] spark pull request: [SPARK-14231][SQL] JSON data source infers flo...

2016-04-02 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/12030#discussion_r58302585 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/InferSchema.scala --- @@ -135,11 +135,25 @@ private[sql] object

[GitHub] spark pull request: [SPARK-14341] [SQL] Throw exception on unsuppo...

2016-04-02 Thread bomeng
Github user bomeng commented on a diff in the pull request: https://github.com/apache/spark/pull/12125#discussion_r58302569 --- Diff: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 --- @@ -759,6 +761,7 @@ SNAPSHOT: 'SNAPSHOT'; READ: 'READ';

[GitHub] spark pull request: [SPARK-12981][SQL] Fix Python UDF extraction f...

2016-04-02 Thread xguo27
Github user xguo27 closed the pull request at: https://github.com/apache/spark/pull/10935 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-12981][SQL] Fix Python UDF extraction f...

2016-04-02 Thread xguo27
Github user xguo27 commented on the pull request: https://github.com/apache/spark/pull/10935#issuecomment-204840629 Sure @davies . I will close this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-14342][Core][Docs][Tests] Remove stragg...

2016-04-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/12129 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-14342][Core][Docs][Tests] Remove stragg...

2016-04-02 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/12129#issuecomment-204839111 Thanks - merging in master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [MINOR][DOCS] Use multi-line JavaDoc comments ...

2016-04-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/12130 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [MINOR][DOCS] Use multi-line JavaDoc comments ...

2016-04-02 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/12130#issuecomment-204838383 BTW in the future for changes this size we should create a JIRA ticket. Can you look into whether it is possible to create a scalastyle rule for this so we don't

[GitHub] spark pull request: [SPARK-14338][SQL] Improve `SimplifyConditiona...

2016-04-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/12122 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [MINOR][DOCS] Use multi-line JavaDoc comments ...

2016-04-02 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/12130#issuecomment-204838369 Thanks - merging in master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-14338][SQL] Improve `SimplifyConditiona...

2016-04-02 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/12122#issuecomment-204838315 Thanks - merging in master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-14285][SQL] Implement common type-safe ...

2016-04-02 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/12077#discussion_r58302439 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/typedaggregators.scala --- @@ -0,0 +1,69 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [SPARK-14163][CORE] SumEvaluator and countAppr...

2016-04-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12016#issuecomment-204832859 **[Test build #54788 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54788/consoleFull)** for PR 12016 at commit

[GitHub] spark pull request: [SPARK-14050][ML] Add multiple languages suppo...

2016-04-02 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/11871#discussion_r58302144 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/StopWordsRemover.scala --- @@ -123,21 +71,26 @@ class StopWordsRemover(override val uid: String)

[GitHub] spark pull request: [SPARK-14163][CORE] SumEvaluator and countAppr...

2016-04-02 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/12016#issuecomment-204832447 Looks good, thank you. Let's give it one more spin --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: [SPARK-14163][CORE] SumEvaluator and countAppr...

2016-04-02 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/12016#issuecomment-204832448 Jenkins retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-14349] [SQL] [WIP] Issue Error Messages...

2016-04-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12134#issuecomment-204832449 **[Test build #54787 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54787/consoleFull)** for PR 12134 at commit

[GitHub] spark pull request: [SPARK-14349] [SQL] [WIP] Issue Error Messages...

2016-04-02 Thread gatorsmile
GitHub user gatorsmile opened a pull request: https://github.com/apache/spark/pull/12134 [SPARK-14349] [SQL] [WIP] Issue Error Messages for Unsupported Operators/DML/DDL in SQL Context. What changes were proposed in this pull request? Currently, the weird error

[GitHub] spark pull request: [SPARK-14163][CORE] SumEvaluator and countAppr...

2016-04-02 Thread mtustin-handy
Github user mtustin-handy commented on a diff in the pull request: https://github.com/apache/spark/pull/12016#discussion_r58302077 --- Diff: core/src/main/scala/org/apache/spark/partial/BoundedDouble.scala --- @@ -21,5 +21,23 @@ package org.apache.spark.partial * A Double

[GitHub] spark pull request: [SPARK-13996][SQL] Add more not null attribute...

2016-04-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11810#issuecomment-204827883 **[Test build #54786 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54786/consoleFull)** for PR 11810 at commit

[GitHub] spark pull request: [SPARK-13996][SQL] Add more not null attribute...

2016-04-02 Thread viirya
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/11810#issuecomment-204827703 retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-14123] [WIP] [SQL] Handle CreateFunctio...

2016-04-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12117#issuecomment-204827237 **[Test build #54785 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54785/consoleFull)** for PR 12117 at commit

[GitHub] spark pull request: [SPARK-14123] [WIP] [SQL] Handle CreateFunctio...

2016-04-02 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/12117#discussion_r58301786 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala --- @@ -428,53 +432,86 @@ class SessionCatalog( */

[GitHub] spark pull request: [SPARK-14123] [WIP] [SQL] Handle CreateFunctio...

2016-04-02 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/12117#discussion_r58301788 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala --- @@ -491,40 +528,31 @@ class SessionCatalog( }

[GitHub] spark pull request: [SPARK-14123] [WIP] [SQL] Handle CreateFunctio...

2016-04-02 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/12117#discussion_r58301771 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveSessionCatalog.scala --- @@ -112,4 +124,121 @@ class HiveSessionCatalog(

[GitHub] spark pull request: [SPARK-14123] [WIP] [SQL] Handle CreateFunctio...

2016-04-02 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/12117#discussion_r58301749 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala --- @@ -211,10 +241,11 @@ class SQLQuerySuite extends QueryTest

[GitHub] spark pull request: [SPARK-14163][CORE] SumEvaluator and countAppr...

2016-04-02 Thread mtustin-handy
Github user mtustin-handy commented on a diff in the pull request: https://github.com/apache/spark/pull/12016#discussion_r58301694 --- Diff: core/src/main/scala/org/apache/spark/partial/BoundedDouble.scala --- @@ -21,5 +21,23 @@ package org.apache.spark.partial * A Double

[GitHub] spark pull request: [SPARK-14050][ML] Add multiple languages suppo...

2016-04-02 Thread burakkose
Github user burakkose commented on a diff in the pull request: https://github.com/apache/spark/pull/11871#discussion_r58301673 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/StopWordsRemover.scala --- @@ -123,21 +71,26 @@ class StopWordsRemover(override val uid:

[GitHub] spark pull request: [SPARK-14163][CORE] SumEvaluator and countAppr...

2016-04-02 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/12016#discussion_r58301669 --- Diff: core/src/main/scala/org/apache/spark/partial/BoundedDouble.scala --- @@ -21,5 +21,23 @@ package org.apache.spark.partial * A Double value

[GitHub] spark pull request: [SPARK-14056] Appends s3 specific configuratio...

2016-04-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11876#issuecomment-204819781 **[Test build #54784 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54784/consoleFull)** for PR 11876 at commit

[GitHub] spark pull request: [SPARK-14050][ML] Add multiple languages suppo...

2016-04-02 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/11871#discussion_r58301587 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/StopWordsRemover.scala --- @@ -123,21 +71,26 @@ class StopWordsRemover(override val uid: String)

[GitHub] spark pull request: [SPARK-14123] [WIP] [SQL] Handle CreateFunctio...

2016-04-02 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/12117#discussion_r58301583 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala --- @@ -453,28 +464,80 @@ class SessionCatalog( * If

[GitHub] spark pull request: [SPARK-14056] Appends s3 specific configuratio...

2016-04-02 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/11876#issuecomment-204819086 Jenkins retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-14050][ML] Add multiple languages suppo...

2016-04-02 Thread burakkose
Github user burakkose commented on a diff in the pull request: https://github.com/apache/spark/pull/11871#discussion_r58301543 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/StopWordsRemover.scala --- @@ -123,21 +71,26 @@ class StopWordsRemover(override val uid:

[GitHub] spark pull request: [SPARK-14056] Appends s3 specific configuratio...

2016-04-02 Thread sitalkedia
Github user sitalkedia commented on the pull request: https://github.com/apache/spark/pull/11876#issuecomment-204817972 @srowen - Thanks for taking a look, updated the diff to fix the test case. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: [SPARK-14056] Appends s3 specific configuratio...

2016-04-02 Thread sitalkedia
Github user sitalkedia commented on a diff in the pull request: https://github.com/apache/spark/pull/11876#discussion_r58301462 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkHadoopUtil.scala --- @@ -74,13 +74,12 @@ class SparkHadoopUtil extends Logging { }

[GitHub] spark pull request: [SPARK-14050][ML] Add multiple languages suppo...

2016-04-02 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/11871#discussion_r58301366 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/StopWordsRemover.scala --- @@ -123,21 +71,26 @@ class StopWordsRemover(override val uid: String)

[GitHub] spark pull request: [MINOR][DOCS] Use multi-line JavaDoc comments ...

2016-04-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12130#issuecomment-204814623 **[Test build #2734 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2734/consoleFull)** for PR 12130 at commit

[GitHub] spark pull request: [SPARK-14163][CORE] SumEvaluator and countAppr...

2016-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12016#issuecomment-204813542 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14123] [WIP] [SQL] Handle CreateFunctio...

2016-04-02 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/12117#discussion_r58301126 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala --- @@ -133,6 +133,30 @@ object UnresolvedAttribute { }

[GitHub] spark pull request: [SPARK-14163][CORE] SumEvaluator and countAppr...

2016-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12016#issuecomment-204813543 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14123] [WIP] [SQL] Handle CreateFunctio...

2016-04-02 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/12117#discussion_r58301096 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala --- @@ -67,9 +70,14 @@ class SimpleFunctionRegistry

[GitHub] spark pull request: [SPARK-14163][CORE] SumEvaluator and countAppr...

2016-04-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12016#issuecomment-204813484 **[Test build #54782 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54782/consoleFull)** for PR 12016 at commit

[GitHub] spark pull request: [SPARK-14123] [WIP] [SQL] Handle CreateFunctio...

2016-04-02 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/12117#discussion_r58301098 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala --- @@ -334,17 +342,18 @@ object FunctionRegistry {

[GitHub] spark pull request: [SPARK-14348][SQL] Support native execution of...

2016-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12133#issuecomment-204813187 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14348][SQL] Support native execution of...

2016-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12133#issuecomment-204813188 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14348][SQL] Support native execution of...

2016-04-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12133#issuecomment-204812704 **[Test build #54783 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54783/consoleFull)** for PR 12133 at commit

[GitHub] spark pull request: [SPARK-14129][SQL] Alter table DDL commands

2016-04-02 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/12121#discussion_r58301016 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala --- @@ -195,67 +195,133 @@ case class DropFunction( isTemp:

[GitHub] spark pull request: [SPARK-14050][ML] Add multiple languages suppo...

2016-04-02 Thread burakkose
Github user burakkose commented on a diff in the pull request: https://github.com/apache/spark/pull/11871#discussion_r58300978 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/StopWordsRemover.scala --- @@ -123,21 +71,26 @@ class StopWordsRemover(override val uid:

[GitHub] spark pull request: [SPARK-14129][SQL] Alter table DDL commands

2016-04-02 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/12121#discussion_r58300971 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala --- @@ -195,67 +195,133 @@ case class DropFunction( isTemp:

[GitHub] spark pull request: [SPARK-14129][SQL] Alter table DDL commands

2016-04-02 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/12121#discussion_r58300930 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala --- @@ -159,6 +193,187 @@ class DDLSuite extends QueryTest with

[GitHub] spark pull request: [SPARK-14129][SQL] Alter table DDL commands

2016-04-02 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/12121#discussion_r58300927 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala --- @@ -159,6 +193,187 @@ class DDLSuite extends QueryTest with

[GitHub] spark pull request: [SPARK-14129][SQL] Alter table DDL commands

2016-04-02 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/12121#discussion_r58300876 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala --- @@ -159,6 +193,187 @@ class DDLSuite extends QueryTest with

[GitHub] spark pull request: [SPARK-14129][SQL] Alter table DDL commands

2016-04-02 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/12121#discussion_r58300859 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala --- @@ -159,6 +193,187 @@ class DDLSuite extends QueryTest with

[GitHub] spark pull request: [SPARK-14129][SQL] Alter table DDL commands

2016-04-02 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/12121#discussion_r58300866 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala --- @@ -159,6 +193,187 @@ class DDLSuite extends QueryTest with

[GitHub] spark pull request: [SPARK-14129][SQL] Alter table DDL commands

2016-04-02 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/12121#discussion_r58300797 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala --- @@ -159,6 +193,187 @@ class DDLSuite extends QueryTest with

[GitHub] spark pull request: [SPARK-14335][SQL] Describe function command r...

2016-04-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12128#issuecomment-204809902 **[Test build #2735 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2735/consoleFull)** for PR 12128 at commit

[GitHub] spark pull request: [SPARK-14285][SQL] Implement common type-safe ...

2016-04-02 Thread tedyu
Github user tedyu commented on a diff in the pull request: https://github.com/apache/spark/pull/12077#discussion_r58300711 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/typedaggregators.scala --- @@ -0,0 +1,69 @@ +/* + * Licensed to the Apache

  1   2   3   >