[GitHub] spark pull request: [SPARK-10387][ML] Add code gen for gbt

2016-04-05 Thread holdenk
Github user holdenk commented on the pull request: https://github.com/apache/spark/pull/9524#issuecomment-206050383 One open question, thats come from keeping up with master, for the reviewers (I guess @dbtsai once he has some spare cycles) is if code generator should live under tree

[GitHub] spark pull request: [SPARK-14416][Core]Add thread-safe comments fo...

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12188#issuecomment-206049857 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14416][Core]Add thread-safe comments fo...

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12188#issuecomment-206049856 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14416][Core]Add thread-safe comments fo...

2016-04-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12188#issuecomment-206049830 **[Test build #55063 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55063/consoleFull)** for PR 12188 at commit

[GitHub] spark pull request: [SPARK-14418] [PYSPARK] fix unpersist of Broad...

2016-04-05 Thread holdenk
Github user holdenk commented on the pull request: https://github.com/apache/spark/pull/12189#issuecomment-206049732 Minor point: would it make sense to also update the PyDoc for unpersist to match the scaladoc while we are fixing its behavior anyways? --- If your project is set up

[GitHub] spark pull request: [SPARK-14224] [SPARK-14223] [SPARK-14310] [SQL...

2016-04-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12047#issuecomment-206048632 **[Test build #55065 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55065/consoleFull)** for PR 12047 at commit

[GitHub] spark pull request: [SPARK-14119] [SQL] Improve HashedRelation for...

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12190#issuecomment-206047077 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14119] [SQL] Improve HashedRelation for...

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12190#issuecomment-206047081 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14119] [SQL] Improve HashedRelation for...

2016-04-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12190#issuecomment-206047062 **[Test build #55062 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55062/consoleFull)** for PR 12190 at commit

[GitHub] spark pull request: [SPARK-14119] [SQL] Improve HashedRelation for...

2016-04-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12190#issuecomment-206046488 **[Test build #55062 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55062/consoleFull)** for PR 12190 at commit

[GitHub] spark pull request: [SPARK-14416][Core]Add thread-safe comments fo...

2016-04-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12188#issuecomment-206046462 **[Test build #55063 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55063/consoleFull)** for PR 12188 at commit

[GitHub] spark pull request: [SPARK-12469][CORE][WIP/RFC] Consistent accumu...

2016-04-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11105#issuecomment-206046532 **[Test build #55064 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55064/consoleFull)** for PR 11105 at commit

[GitHub] spark pull request: [SPARK-13211] [STREAMING] StreamingContext thr...

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12174#issuecomment-206045392 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13211] [STREAMING] StreamingContext thr...

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12174#issuecomment-206045390 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14353] Dataset Time Window `window` API...

2016-04-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/12141 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-13211] [STREAMING] StreamingContext thr...

2016-04-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12174#issuecomment-206045304 **[Test build #55045 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55045/consoleFull)** for PR 12174 at commit

[GitHub] spark pull request: [SPARK-14288][SQL] Memory Sink for streaming

2016-04-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12119#issuecomment-206045152 **[Test build #55061 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55061/consoleFull)** for PR 12119 at commit

[GitHub] spark pull request: [SPARK-13929] Use Scala reflection for UDTs

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12149#issuecomment-206044980 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13929] Use Scala reflection for UDTs

2016-04-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12149#issuecomment-206044946 **[Test build #55052 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55052/consoleFull)** for PR 12149 at commit

[GitHub] spark pull request: [SPARK-13929] Use Scala reflection for UDTs

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12149#issuecomment-206044982 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14353] Dataset Time Window `window` API...

2016-04-05 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/12141#issuecomment-206044794 LGTM, merging into master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-14119] [SQL] Improve HashedRelation for...

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12190#issuecomment-206044561 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14119] [SQL] Improve HashedRelation for...

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12190#issuecomment-206044562 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14119] [SQL] Improve HashedRelation for...

2016-04-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12190#issuecomment-206044559 **[Test build #55060 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55060/consoleFull)** for PR 12190 at commit

[GitHub] spark pull request: [SPARK-14119] [SQL] Improve HashedRelation for...

2016-04-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12190#issuecomment-206044309 **[Test build #55060 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55060/consoleFull)** for PR 12190 at commit

[GitHub] spark pull request: [SPARK-14288][SQL] Memory Sink for streaming

2016-04-05 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/12119#discussion_r58635507 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala --- @@ -275,23 +279,64 @@ final class DataFrameWriter private[sql](df:

[GitHub] spark pull request: [SPARK-12555][SQL] Result should not be corrup...

2016-04-05 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/11623#discussion_r58635476 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DatasetAggregatorSuite.scala --- @@ -176,4 +186,13 @@ class DatasetAggregatorSuite extends

[GitHub] spark pull request: [SPARK-14119] [SQL] Improve HashedRelation for...

2016-04-05 Thread davies
GitHub user davies opened a pull request: https://github.com/apache/spark/pull/12190 [SPARK-14119] [SQL] Improve HashedRelation for key fit within Long ## What changes were proposed in this pull request? Currently, we use java HashMap for HashedRelation if the key could fit

[GitHub] spark pull request: [SPARK-14418] [PYSPARK] fix unpersist of Broad...

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12189#issuecomment-206043600 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14418] [PYSPARK] fix unpersist of Broad...

2016-04-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12189#issuecomment-206043462 **[Test build #55053 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55053/consoleFull)** for PR 12189 at commit

[GitHub] spark pull request: [SPARK-14418] [PYSPARK] fix unpersist of Broad...

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12189#issuecomment-206043594 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-529] [core] [yarn] Add type-safe config...

2016-04-05 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/10205#issuecomment-206043222 > Also, because of that method, the return value of getConf(CHECKPOINT_LOCATION) would be String and not Option[String], which is probably why intellij is

[GitHub] spark pull request: [SPARK-14288][SQL] Memory Sink for streaming

2016-04-05 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/12119#discussion_r58635261 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala --- @@ -275,23 +279,64 @@ final class DataFrameWriter private[sql](df:

[GitHub] spark pull request: [SPARK-14416][Core]Add thread-safe comments fo...

2016-04-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12188#issuecomment-206043088 **[Test build #55059 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55059/consoleFull)** for PR 12188 at commit

[GitHub] spark pull request: [SPARK-6429] Implement hashCode and equals tog...

2016-04-05 Thread joan38
Github user joan38 commented on a diff in the pull request: https://github.com/apache/spark/pull/12157#discussion_r58634718 --- Diff: core/src/main/scala/org/apache/spark/rdd/HadoopRDD.scala --- @@ -53,14 +53,22 @@ import org.apache.spark.util.{NextIterator,

[GitHub] spark pull request: [SPARK-14288][SQL] Memory Sink for streaming

2016-04-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12119#issuecomment-206041708 **[Test build #55057 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55057/consoleFull)** for PR 12119 at commit

[GitHub] spark pull request: [SPARK-14288][SQL] Memory Sink for streaming

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12119#issuecomment-206041715 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14416][Core]Add thread-safe comments fo...

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12188#issuecomment-206041665 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14288][SQL] Memory Sink for streaming

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12119#issuecomment-206041712 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14416][Core]Add thread-safe comments fo...

2016-04-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12188#issuecomment-206041655 **[Test build #55056 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55056/consoleFull)** for PR 12188 at commit

[GitHub] spark pull request: [SPARK-14416][Core]Add thread-safe comments fo...

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12188#issuecomment-206041662 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14288][SQL] Memory Sink for streaming

2016-04-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12119#issuecomment-206041439 **[Test build #55057 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55057/consoleFull)** for PR 12119 at commit

[GitHub] spark pull request: [SPARK-6717][ML] Clear shuffle files after che...

2016-04-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11919#issuecomment-206041431 **[Test build #55058 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55058/consoleFull)** for PR 11919 at commit

[GitHub] spark pull request: [SPARK-14416][Core]Add thread-safe comments fo...

2016-04-05 Thread zsxwing
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/12188#issuecomment-206041318 > super may not be used on value minRegisteredRatio Scala doesn't allow to override a val and call super. --- If your project is set up for it, you can reply

[GitHub] spark pull request: [SPARK-529] [core] [yarn] Add type-safe config...

2016-04-05 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/10205#issuecomment-206041420 `CHECKPOINT_LOCATION` was a weird one; because it didn't have a default value before my changes, and this was the best way I found to map it. There's a new

[GitHub] spark pull request: [SPARK-14288][SQL] Memory Sink for streaming

2016-04-05 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/12119#discussion_r58634150 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala --- @@ -275,23 +279,64 @@ final class DataFrameWriter private[sql](df:

[GitHub] spark pull request: [SPARK-13786][ML][Pyspark] Add save/load for p...

2016-04-05 Thread yinxusen
Github user yinxusen commented on a diff in the pull request: https://github.com/apache/spark/pull/12020#discussion_r58634140 --- Diff: python/pyspark/ml/tuning.py --- @@ -112,15 +198,24 @@ class CrossValidator(Estimator, HasSeed): >>> cvModel = cv.fit(dataset)

[GitHub] spark pull request: [SPARK-14362] [SPARK-14406] [SQL] [WIP] DDL Na...

2016-04-05 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/12146#discussion_r58634134 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/commands.scala --- @@ -47,18 +48,40 @@ case class AnalyzeTable(tableName: String)

[GitHub] spark pull request: [SPARK-14362] [SPARK-14406] [SQL] [WIP] DDL Na...

2016-04-05 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/12146#discussion_r58634059 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/commands.scala --- @@ -47,18 +48,40 @@ case class AnalyzeTable(tableName: String)

[GitHub] spark pull request: [SPARK-14394][SQL] Generate AggregateHashMap c...

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12161#issuecomment-206040363 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14394][SQL] Generate AggregateHashMap c...

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12161#issuecomment-206040360 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14394][SQL] Generate AggregateHashMap c...

2016-04-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12161#issuecomment-206040332 **[Test build #55042 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55042/consoleFull)** for PR 12161 at commit

[GitHub] spark pull request: [SPARK-14416][Core]Add thread-safe comments fo...

2016-04-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12188#issuecomment-206040248 **[Test build #55056 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55056/consoleFull)** for PR 12188 at commit

[GitHub] spark pull request: [SPARK-529] [core] [yarn] Add type-safe config...

2016-04-05 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/10205#issuecomment-206039890 In particular the implicit wrapping of `OptionalConfigEntry[T]` to be a `ConfigEntry[Option[T]]` coupled with the unwrapping done via overloading of `getConf` took me

[GitHub] spark pull request: [SPARK-14416][Core]Add thread-safe comments fo...

2016-04-05 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/12188#issuecomment-206039892 retest this please, it should be fixed by now... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: [SPARK-12555][SQL] Result should not be corrup...

2016-04-05 Thread lresende
Github user lresende commented on a diff in the pull request: https://github.com/apache/spark/pull/11623#discussion_r58633691 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DatasetAggregatorSuite.scala --- @@ -176,4 +186,13 @@ class DatasetAggregatorSuite extends QueryTest

[GitHub] spark pull request: [SPARK-13430][PySpark][ML] Python API for trai...

2016-04-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11621#issuecomment-206039464 **[Test build #55055 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55055/consoleFull)** for PR 11621 at commit

[GitHub] spark pull request: [SPARK-14418] [PYSPARK] fix unpersist of Broad...

2016-04-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12189#issuecomment-206039488 **[Test build #55053 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55053/consoleFull)** for PR 12189 at commit

[GitHub] spark pull request: [SPARK-13792][SQL] Limit logging of bad record...

2016-04-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12173#issuecomment-206039487 **[Test build #55054 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55054/consoleFull)** for PR 12173 at commit

[GitHub] spark pull request: [SPARK-14418] [PYSPARK] fix unpersist of Broad...

2016-04-05 Thread davies
GitHub user davies opened a pull request: https://github.com/apache/spark/pull/12189 [SPARK-14418] [PYSPARK] fix unpersist of Broadcast in Python ## What changes were proposed in this pull request? Currently, Broaccast.unpersist() will remove the file of broadcast, which

[GitHub] spark pull request: [SPARK-14418] [PYSPARK] fix unpersist of Broad...

2016-04-05 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/12189#issuecomment-206039178 cc @yhuai --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-13792][SQL] Limit logging of bad record...

2016-04-05 Thread maropu
Github user maropu commented on the pull request: https://github.com/apache/spark/pull/12173#issuecomment-206038985 okay and fixed. Please re-check again? cc: @falaki --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: [SPARK-14416][Core]Add thread-safe comments fo...

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12188#issuecomment-206038892 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14416][Core]Add thread-safe comments fo...

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12188#issuecomment-206038895 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14416][Core]Add thread-safe comments fo...

2016-04-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12188#issuecomment-206038874 **[Test build #55047 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55047/consoleFull)** for PR 12188 at commit

[GitHub] spark pull request: [SPARK-13929] Use Scala reflection for UDTs

2016-04-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12149#issuecomment-206038608 **[Test build #55052 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55052/consoleFull)** for PR 12149 at commit

[GitHub] spark pull request: [SPARK-13929] Use Scala reflection for UDTs

2016-04-05 Thread joan38
Github user joan38 commented on the pull request: https://github.com/apache/spark/pull/12149#issuecomment-206038639 The upcoming test *UserDefinedTypeSuite.UDTs with JSON and Dataset* is going to fail. Can you confirm that this is due to the lack of support of UDTs in Datasets or

[GitHub] spark pull request: [SPARK-13792][SQL] Limit logging of bad record...

2016-04-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12173#issuecomment-206038586 **[Test build #55051 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55051/consoleFull)** for PR 12173 at commit

[GitHub] spark pull request: [SPARK-529] [core] [yarn] Add type-safe config...

2016-04-05 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/10205#issuecomment-206038435 > In what case do we need overloading? This was part of a previous conversation in this thread. One of the features in the new API that wasn't present in the

[GitHub] spark pull request: [SPARK-14362] [SPARK-14406] [SQL] [WIP] DDL Na...

2016-04-05 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/12146#discussion_r58632900 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/HiveSqlParser.scala --- @@ -113,7 +113,10 @@ class HiveSqlAstBuilder extends

[GitHub] spark pull request: [SPARK-13929] Use Scala reflection for UDTs

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12149#issuecomment-206038039 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13929] Use Scala reflection for UDTs

2016-04-05 Thread joan38
Github user joan38 commented on the pull request: https://github.com/apache/spark/pull/12149#issuecomment-206038019 The upcoming test *UserDefinedTypeSuite.UDTs with JSON and Dataset* is going to fail. Can you confirm that this is due to the lack of support of UDTs in Datasets or

[GitHub] spark pull request: [SPARK-13929] Use Scala reflection for UDTs

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12149#issuecomment-206038043 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14362] [SPARK-14406] [SQL] [WIP] DDL Na...

2016-04-05 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/12146#discussion_r58632748 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/commands.scala --- @@ -47,18 +47,38 @@ case class AnalyzeTable(tableName: String)

[GitHub] spark pull request: [SPARK-13929] Use Scala reflection for UDTs

2016-04-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12149#issuecomment-206038036 **[Test build #55050 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55050/consoleFull)** for PR 12149 at commit

[GitHub] spark pull request: [SPARK-13929] Use Scala reflection for UDTs

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12149#issuecomment-206037774 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14396] [SQL] Throw Exceptions for DDLs ...

2016-04-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12169#issuecomment-206037747 **[Test build #55049 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55049/consoleFull)** for PR 12169 at commit

[GitHub] spark pull request: [SPARK-13929] Use Scala reflection for UDTs

2016-04-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12149#issuecomment-206037758 **[Test build #55050 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55050/consoleFull)** for PR 12149 at commit

[GitHub] spark pull request: [SPARK-13929] Use Scala reflection for UDTs

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12149#issuecomment-206037771 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14396] [SQL] Throw Exceptions for DDLs ...

2016-04-05 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/12169#discussion_r58632645 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/HiveSqlParser.scala --- @@ -215,11 +215,20 @@ class HiveSqlAstBuilder extends

[GitHub] spark pull request: [SPARK-14128][SQL] Alter table DDL followup

2016-04-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12186#issuecomment-206037768 **[Test build #55048 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55048/consoleFull)** for PR 12186 at commit

[GitHub] spark pull request: [SPARK-14394][SQL] Generate AggregateHashMap c...

2016-04-05 Thread sameeragarwal
Github user sameeragarwal commented on the pull request: https://github.com/apache/spark/pull/12161#issuecomment-206037766 cc @nongli --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-14396] [SQL] Throw Exceptions for DDLs ...

2016-04-05 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/12169#issuecomment-206037824 LGTM we just need to make tests pass now --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13929] Use Scala reflection for UDTs

2016-04-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12149#issuecomment-206037762 **[Test build #55046 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55046/consoleFull)** for PR 12149 at commit

[GitHub] spark pull request: [SPARK-14416][Core]Add thread-safe comments fo...

2016-04-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12188#issuecomment-206037739 **[Test build #55047 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55047/consoleFull)** for PR 12188 at commit

[GitHub] spark pull request: [SPARK-14396] [SQL] Throw Exceptions for DDLs ...

2016-04-05 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/12169#issuecomment-206037592 Build is broken I think. retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14372] [SQL] : Dataset.randomSplit() ne...

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12184#issuecomment-206037177 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14372] [SQL] : Dataset.randomSplit() ne...

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12184#issuecomment-206037180 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: use https while downloading binaries

2016-04-05 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/12182#issuecomment-206037026 @infynyxx I think this one is on the borderline. I would just create one so everyone is happy. --- If your project is set up for it, you can reply to this email

[GitHub] spark pull request: [SPARK-14416][Core]Add thread-safe comments fo...

2016-04-05 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/12188#issuecomment-206036235 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-14416][Core]Add thread-safe comments fo...

2016-04-05 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/12188#discussion_r58632211 --- Diff: yarn/src/main/scala/org/apache/spark/scheduler/cluster/YarnSchedulerBackend.scala --- @@ -39,9 +39,12 @@ private[spark] abstract class

[GitHub] spark pull request: [SPARK-14416][Core]Add thread-safe comments fo...

2016-04-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12188#issuecomment-206035976 **[Test build #55044 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55044/consoleFull)** for PR 12188 at commit

[GitHub] spark pull request: [SPARK-14416][Core]Add thread-safe comments fo...

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12188#issuecomment-206035998 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14372] [SQL] : Dataset.randomSplit() ne...

2016-04-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12184#issuecomment-206036164 **[Test build #55029 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55029/consoleFull)** for PR 12184 at commit

[GitHub] spark pull request: [SPARK-14416][Core]Add thread-safe comments fo...

2016-04-05 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/12188#issuecomment-206036081 Thanks, I love this patch! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-14416][Core]Add thread-safe comments fo...

2016-04-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12188#issuecomment-206035994 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14416][Core]Add thread-safe comments fo...

2016-04-05 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/12188#discussion_r58632162 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala --- @@ -43,24 +44,30 @@ class

[GitHub] spark pull request: [SPARK-13929] Use Scala reflection for UDTs

2016-04-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12149#issuecomment-206035246 **[Test build #55046 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55046/consoleFull)** for PR 12149 at commit

[GitHub] spark pull request: [SPARK-14128][SQL] Alter table DDL followup

2016-04-05 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/12186#issuecomment-206035348 what... retest this please? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-13211] [STREAMING] StreamingContext thr...

2016-04-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12174#issuecomment-206035185 **[Test build #55045 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55045/consoleFull)** for PR 12174 at commit

<    1   2   3   4   5   6   7   8   9   10   >