[GitHub] spark pull request: [SPARK-14562] [SQL] improve constraints propag...

2016-04-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12328#issuecomment-209039805 **[Test build #55617 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55617/consoleFull)** for PR 12328 at commit [`ac45ea3`](https://g

[GitHub] spark pull request: [SPARK-14154][MLlib] remove stale comment for ...

2016-04-12 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/12325#issuecomment-209032920 @hhbyyh Sorry that I just saw #11954. Please see my comments on the JIRA. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request: [SPARK-14388][SQL] Implement CREATE TABLE

2016-04-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12271#issuecomment-209032675 **[Test build #55628 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55628/consoleFull)** for PR 12271 at commit [`250f402`](https://gi

[GitHub] spark pull request: [SPARK-14363] Fix executor OOM due to memory l...

2016-04-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12285#issuecomment-209027266 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14388][SQL] Implement CREATE TABLE

2016-04-12 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/12271#issuecomment-209031556 Thanks for the reviews. Latest commit should pass tests. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as we

[GitHub] spark pull request: [SPARK-14388][SQL] Implement CREATE TABLE

2016-04-12 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/12271#discussion_r59423143 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/HiveSqlParser.scala --- @@ -121,84 +123,114 @@ class HiveSqlAstBuilder extends Spar

[GitHub] spark pull request: [SPARK-13734][SPARKR] Added histogram function

2016-04-12 Thread olarayej
Github user olarayej commented on the pull request: https://github.com/apache/spark/pull/11569#issuecomment-209030552 @felixcheung @shivaram This is done. Shall we merge? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: [SPARK-14388][SQL] Implement CREATE TABLE

2016-04-12 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/12271#issuecomment-209030454 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled an

[GitHub] spark pull request: [SPARK-9325][SPARK-R] collect() head() and sho...

2016-04-12 Thread olarayej
Github user olarayej commented on the pull request: https://github.com/apache/spark/pull/11336#issuecomment-209030229 @shivaram @falaki @felixcheung @rxin @sun-rui Any thoughts on this? --- If your project is set up for it, you can reply to this email and have your reply appear on Git

[GitHub] spark pull request: [SPARK-14562] [SQL] improve constraints propag...

2016-04-12 Thread sameeragarwal
Github user sameeragarwal commented on the pull request: https://github.com/apache/spark/pull/12328#issuecomment-209029684 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature en

[GitHub] spark pull request: [SPARK-14513][CORE] Fix threads left behind af...

2016-04-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12318#issuecomment-209029211 **[Test build #2779 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2779/consoleFull)** for PR 12318 at commit [`0232a7a`](https://g

[GitHub] spark pull request: [SPARK-14388][SQL] Implement CREATE TABLE

2016-04-12 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/12271#discussion_r59421983 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/HiveSqlParser.scala --- @@ -121,84 +123,114 @@ class HiveSqlAstBuilder extends SparkSqlA

[GitHub] spark pull request: [SPARK-14388][SQL] Implement CREATE TABLE

2016-04-12 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/12271#discussion_r59421753 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala --- @@ -218,14 +219,35 @@ case class CatalogTable( tableT

[GitHub] spark pull request: [SPARK-14563] [ML] use a random table name ins...

2016-04-12 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/12330#issuecomment-209024847 lgtm --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled an

[GitHub] spark pull request: [SPARK-14474][SQL]Move FileSource offset log i...

2016-04-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/12247 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request: [SPARK-14363] Fix executor OOM due to memory l...

2016-04-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12285#issuecomment-209027762 **[Test build #55627 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55627/consoleFull)** for PR 12285 at commit [`b102c25`](https://gi

[GitHub] spark pull request: [SPARK-14363] Fix executor OOM due to memory l...

2016-04-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12285#issuecomment-209027227 **[Test build #55626 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55626/consoleFull)** for PR 12285 at commit [`75a44f9`](https://g

[GitHub] spark pull request: [SPARK-14474][SQL]Move FileSource offset log i...

2016-04-12 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/12247#issuecomment-209024772 Thanks, merging to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not hav

[GitHub] spark pull request: [SPARK-14288][SQL] Memory Sink for streaming

2016-04-12 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/12119#discussion_r59420081 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala --- @@ -275,23 +277,64 @@ final class DataFrameWriter private[sql](df: DataFra

[GitHub] spark pull request: [STREAMING] SPARK-2009 Key not found exception...

2016-04-12 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/961#issuecomment-209024020 @ouyangshourui this is not at all the same issue. Please file a JIRA with your stack trace and mark the affected version as 2.0 --- If your project is set up for it,

[GitHub] spark pull request: [SPARK-12566] [SPARK-14324] [ML] [WIP] GLM mod...

2016-04-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/12294 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request: [SPARK-12566] [SPARK-14324] [ML] [WIP] GLM mod...

2016-04-12 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/12294#issuecomment-209027601 LGTM. Merged into master. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does no

[GitHub] spark pull request: [SPARK-14363] Fix executor OOM due to memory l...

2016-04-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12285#issuecomment-209027268 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14363] Fix executor OOM due to memory l...

2016-04-12 Thread sitalkedia
Github user sitalkedia commented on the pull request: https://github.com/apache/spark/pull/12285#issuecomment-209026557 @davies - Thanks for the review. I have addressed all the comments, please let me know how it looks. --- If your project is set up for it, you can reply to this em

[GitHub] spark pull request: [SPARK-14388][SQL] Implement CREATE TABLE

2016-04-12 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/12271#discussion_r59421647 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/HiveSqlParser.scala --- @@ -121,84 +123,114 @@ class HiveSqlAstBuilder extends SparkSqlA

[GitHub] spark pull request: [SPARK-14388][SQL] Implement CREATE TABLE

2016-04-12 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/12271#discussion_r59421840 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/HiveSqlParser.scala --- @@ -121,84 +123,114 @@ class HiveSqlAstBuilder extends SparkSqlA

[GitHub] spark pull request: [SPARK-14388][SQL] Implement CREATE TABLE

2016-04-12 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/12271#discussion_r59421524 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala --- @@ -218,14 +219,35 @@ case class CatalogTable( tableT

[GitHub] spark pull request: [SPARK-14547] Avoid DNS resolution for reusing...

2016-04-12 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/12315#issuecomment-209023299 OK updated. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature ena

[GitHub] spark pull request: [SPARK-14547] Avoid DNS resolution for reusing...

2016-04-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12315#issuecomment-209023741 **[Test build #55625 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55625/consoleFull)** for PR 12315 at commit [`886ab09`](https://gi

[GitHub] spark pull request: [SPARK-14563] [ML] use a random table name ins...

2016-04-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12330#issuecomment-209023739 **[Test build #55624 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55624/consoleFull)** for PR 12330 at commit [`8869132`](https://gi

[GitHub] spark pull request: [SPARK-14363] Fix executor OOM due to memory l...

2016-04-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12285#issuecomment-209023737 **[Test build #55626 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55626/consoleFull)** for PR 12285 at commit [`75a44f9`](https://gi

[GitHub] spark pull request: [SPARK-14563] [ML] use a random table name ins...

2016-04-12 Thread mengxr
GitHub user mengxr opened a pull request: https://github.com/apache/spark/pull/12330 [SPARK-14563] [ML] use a random table name instead of __THIS__ in SQLTransformer ## What changes were proposed in this pull request? Use a random table name instead of `__THIS__` in SQLTran

[GitHub] spark pull request: [SPARK-14474][SQL]Move FileSource offset log i...

2016-04-12 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/12247#discussion_r59419309 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/sources/interfaces.scala --- @@ -129,8 +129,17 @@ trait SchemaRelationProvider { * Implemented b

[GitHub] spark pull request: [SPARK-14483][WEBUI] Display user name for eac...

2016-04-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12257#issuecomment-209021861 **[Test build #55623 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55623/consoleFull)** for PR 12257 at commit [`9146977`](https://gi

[GitHub] spark pull request: [SPARK-14555] First cut of Python API for Stru...

2016-04-12 Thread zsxwing
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/12320#issuecomment-209020867 The Python APIs looks great. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[GitHub] spark pull request: [SPARK-14544] [SQL] improve performance of SQL...

2016-04-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12311#issuecomment-209018239 **[Test build #55622 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55622/consoleFull)** for PR 12311 at commit [`a8f209a`](https://gi

[GitHub] spark pull request: [SPARK-14554][SQL] disable whole stage codegen...

2016-04-12 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/12322#discussion_r59417359 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala --- @@ -620,6 +620,12 @@ class DatasetSuite extends QueryTest with SharedSQLConte

[GitHub] spark pull request: [MINOR][SQL] Re-enable `explode()` and `json_t...

2016-04-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12329#issuecomment-209015488 **[Test build #55621 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55621/consoleFull)** for PR 12329 at commit [`510b513`](https://gi

[GitHub] spark pull request: [MINOR][SQL] Re-enable `explode()` and `json_t...

2016-04-12 Thread dongjoon-hyun
GitHub user dongjoon-hyun opened a pull request: https://github.com/apache/spark/pull/12329 [MINOR][SQL] Re-enable `explode()` and `json_tuple()` testcases in ExpressionToSQLSuite ## What changes were proposed in this pull request? Since [SPARK-12719: SQL Generation support

[GitHub] spark pull request: [SPARK-14555] First cut of Python API for Stru...

2016-04-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12320#issuecomment-209013483 **[Test build #55619 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55619/consoleFull)** for PR 12320 at commit [`96ac9f9`](https://gi

[GitHub] spark pull request: [SPARK-14124] [SQL] [FOLLOWUP] Implement Datab...

2016-04-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12081#issuecomment-209013478 **[Test build #55620 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55620/consoleFull)** for PR 12081 at commit [`3353a39`](https://gi

[GitHub] spark pull request: [SPARK-14547] Avoid DNS resolution for reusing...

2016-04-12 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/12315#discussion_r59414515 --- Diff: common/network-common/src/main/java/org/apache/spark/network/client/TransportClientFactory.java --- @@ -149,25 +148,31 @@ public TransportClient c

[GitHub] spark pull request: [SPARK-14555] First cut of Python API for Stru...

2016-04-12 Thread brkyvz
Github user brkyvz commented on the pull request: https://github.com/apache/spark/pull/12320#issuecomment-209011972 cc @zsxwing --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark pull request: [SPARK-14545][SQL] Improve `LikeSimplification...

2016-04-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12312#issuecomment-209011789 **[Test build #55618 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55618/consoleFull)** for PR 12312 at commit [`16ab6c8`](https://gi

[GitHub] spark pull request: [SPARK-14545][SQL] Improve `LikeSimplification...

2016-04-12 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/12312#issuecomment-209011439 Hi, @rxin . Sorry for late response. I added comments and changed the testcase name according to your comments. Thank you for review! --- If your project

[GitHub] spark pull request: [SPARK-3724][ML] RandomForest: More options fo...

2016-04-12 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/11989#issuecomment-209008233 @yongtang Sorry that I just found this was merged. I think it might be better to use `Int.parseInt` and `parseDouble` instead of regexes, which is less robust. For examp

[GitHub] spark pull request: [SPARK-14545][SQL] Improve `LikeSimplification...

2016-04-12 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/12312#discussion_r59412120 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/LikeSimplificationSuite.scala --- @@ -61,6 +61,20 @@ class LikeSimplific

[GitHub] spark pull request: [SPARK-14545][SQL] Improve `LikeSimplification...

2016-04-12 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/12312#discussion_r59412030 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -529,6 +530,9 @@ object LikeSimplification extend

[GitHub] spark pull request: [SPARK-14508][BUILD] Add a new ScalaStyle Rule...

2016-04-12 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/12280#issuecomment-209004510 Thank you, @rxin and @srowen ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project doe

[GitHub] spark pull request: [SPARK-14562] [SQL] improve constraints propag...

2016-04-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12328#issuecomment-209004049 **[Test build #55617 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55617/consoleFull)** for PR 12328 at commit [`ac45ea3`](https://gi

[GitHub] spark pull request: [SPARK-14562] [SQL] improve constraints propag...

2016-04-12 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/12328#issuecomment-209003253 cc @sameeragarwal --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fea

[GitHub] spark pull request: [SPARK-14562] [SQL] improve constraints propag...

2016-04-12 Thread davies
GitHub user davies opened a pull request: https://github.com/apache/spark/pull/12328 [SPARK-14562] [SQL] improve constraints propagation in Union ## What changes were proposed in this pull request? Currently, Union only takes intersect of the constraints from it's children,

[GitHub] spark pull request: [SPARK-14558][CORE] In ClosureCleaner, clean t...

2016-04-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12327#issuecomment-209000936 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14558][CORE] In ClosureCleaner, clean t...

2016-04-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12327#issuecomment-209000940 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14558][CORE] In ClosureCleaner, clean t...

2016-04-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12327#issuecomment-209000141 **[Test build #55614 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55614/consoleFull)** for PR 12327 at commit [`b78b2ce`](https://g

[GitHub] spark pull request: [SPARK-14543] [SQL] Fix InsertIntoTable column...

2016-04-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12313#issuecomment-208998937 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14543] [SQL] Fix InsertIntoTable column...

2016-04-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12313#issuecomment-208998941 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14547] Avoid DNS resolution for reusing...

2016-04-12 Thread nongli
Github user nongli commented on a diff in the pull request: https://github.com/apache/spark/pull/12315#discussion_r59409060 --- Diff: common/network-common/src/main/java/org/apache/spark/network/client/TransportClientFactory.java --- @@ -149,25 +148,31 @@ public TransportClient cr

[GitHub] spark pull request: [SPARK-14547] Avoid DNS resolution for reusing...

2016-04-12 Thread nongli
Github user nongli commented on the pull request: https://github.com/apache/spark/pull/12315#issuecomment-208998610 lgtm --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled a

[GitHub] spark pull request: [SPARK-14543] [SQL] Fix InsertIntoTable column...

2016-04-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12313#issuecomment-208998364 **[Test build #55616 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55616/consoleFull)** for PR 12313 at commit [`f2186e5`](https://g

[GitHub] spark pull request: [SPARK-11353][IO] Update jets3t version to 0.9...

2016-04-12 Thread Kinghack
Github user Kinghack commented on the pull request: https://github.com/apache/spark/pull/9306#issuecomment-208981407 since latest version of jets3t does not build into latest spark. Is it possible for now that I could access s3 file from regions that supports AWS4-HMAC-SHA256 only?

[GitHub] spark pull request: [SPARK-14238][ML][MLLIB][PYSPARK] Add binary t...

2016-04-12 Thread holdenk
Github user holdenk commented on the pull request: https://github.com/apache/spark/pull/12079#issuecomment-208974760 @BryanCutler / @yongtang That sounds reasonable :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If yo

[GitHub] spark pull request: [SPARK-14238][ML][MLLIB][PYSPARK] Add binary t...

2016-04-12 Thread BryanCutler
Github user BryanCutler commented on the pull request: https://github.com/apache/spark/pull/12079#issuecomment-208970035 > @holdenk @BryanCutler we could merge this and #12308, and then update the param to be shared (if we can do the different doc thing?). I think that will be

[GitHub] spark pull request: [SPARK-14543] [SQL] Fix InsertIntoTable column...

2016-04-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12313#issuecomment-208968933 **[Test build #55616 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55616/consoleFull)** for PR 12313 at commit [`f2186e5`](https://gi

[GitHub] spark pull request: [SPARK-12469][CORE][WIP/RFC] Consistent accumu...

2016-04-12 Thread holdenk
Github user holdenk commented on the pull request: https://github.com/apache/spark/pull/11105#issuecomment-208963389 @viirya - I think having consistent accumulators only be consistent inside some of the Spark operations might be a little confusing, although that's also where I starte

[GitHub] spark pull request: [SPARK-13681][SPARK-14458][SQL] Add back once ...

2016-04-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12179#issuecomment-208960059 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-13681][SPARK-14458][SQL] Add back once ...

2016-04-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12179#issuecomment-208960057 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-13681][SPARK-14458][SQL] Add back once ...

2016-04-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12179#issuecomment-208959991 **[Test build #55615 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55615/consoleFull)** for PR 12179 at commit [`8073b3b`](https://g

[GitHub] spark pull request: [SPARK-12469][CORE][WIP/RFC] Consistent accumu...

2016-04-12 Thread viirya
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/11105#issuecomment-208955837 I am thinking that if we can support the semantics that the accumulator updates in anyone RDD will not be recounted. Is it already enough? So we don't need to complicate

[GitHub] spark pull request: [Minor] [MLlib] remove stale comment

2016-04-12 Thread hhbyyh
Github user hhbyyh commented on the pull request: https://github.com/apache/spark/pull/12325#issuecomment-208952622 Good idea. Thanks. I'll update the title. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [Minor] [MLlib] remove stale comment

2016-04-12 Thread MLnick
Github user MLnick commented on the pull request: https://github.com/apache/spark/pull/12325#issuecomment-208950544 Not strictly necessary to have a JIRA, but is this essentially a follow up to [SPARK-14154] (https://issues.apache.org/jira/browse/SPARK-14154)? In which case maybe just

[GitHub] spark pull request: [SPARK-14479] [ML] GLM supports output link pr...

2016-04-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12287#issuecomment-208948492 **[Test build #55613 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55613/consoleFull)** for PR 12287 at commit [`e5aea09`](https://g

[GitHub] spark pull request: [SPARK-14479] [ML] GLM supports output link pr...

2016-04-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12287#issuecomment-208948692 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14479] [ML] GLM supports output link pr...

2016-04-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12287#issuecomment-208948690 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-3724][ML] RandomForest: More options fo...

2016-04-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/11989 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request: [SPARK-3724][ML] RandomForest: More options fo...

2016-04-12 Thread MLnick
Github user MLnick commented on the pull request: https://github.com/apache/spark/pull/11989#issuecomment-208947738 LGTM. Merged to master. Thanks @yongtang and also @sethah for reviewing! --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request: [SPARK-14147] [ML] [SparkR] SparkR predict sho...

2016-04-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11958#issuecomment-208943132 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14147] [ML] [SparkR] SparkR predict sho...

2016-04-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11958#issuecomment-208942808 **[Test build #55610 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55610/consoleFull)** for PR 11958 at commit [`0d18ccd`](https://g

[GitHub] spark pull request: [SPARK-13681][SPARK-14458][SQL] Add back once ...

2016-04-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12179#issuecomment-208946259 **[Test build #55615 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55615/consoleFull)** for PR 12179 at commit [`8073b3b`](https://gi

[GitHub] spark pull request: [SPARK-14147] [ML] [SparkR] SparkR predict sho...

2016-04-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11958#issuecomment-208943139 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14558][CORE] In ClosureCleaner, clean t...

2016-04-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12327#issuecomment-208940317 **[Test build #55614 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55614/consoleFull)** for PR 12327 at commit [`b78b2ce`](https://gi

[GitHub] spark pull request: [SPARK-12469][CORE][WIP/RFC] Consistent accumu...

2016-04-12 Thread squito
Github user squito commented on the pull request: https://github.com/apache/spark/pull/11105#issuecomment-208941190 +1 on "data property" instead of consistent --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proje

[GitHub] spark pull request: [SPARK-14558][CORE] In ClosureCleaner, clean t...

2016-04-12 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/12327#issuecomment-208939061 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enable

[GitHub] spark pull request: [SPARK-13568] [ML] Create feature transformer ...

2016-04-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11601#issuecomment-208932139 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14558][CORE] In ClosureCleaner, clean t...

2016-04-12 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/12327#issuecomment-208939090 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-14488][SPARK-14493][SQL] "CREATE TEMPOR...

2016-04-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/12303 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request: [SPARK-13568] [ML] Create feature transformer ...

2016-04-12 Thread hash-X
Github user hash-X commented on the pull request: https://github.com/apache/spark/pull/11601#issuecomment-208934749 @hhbyyh WOW, I have been finding how to impute missing values in spark project lately. LGTM. Thank you. --- If your project is set up for it, you can reply to this

[GitHub] spark pull request: [SPARK-14558][CORE] In ClosureCleaner, clean t...

2016-04-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12327#issuecomment-208930676 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14488][SPARK-14493][SQL] "CREATE TEMPOR...

2016-04-12 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/12303#issuecomment-208930853 Thanks for the review! Merging to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proj

[GitHub] spark pull request: [SPARK-13568] [ML] Create feature transformer ...

2016-04-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11601#issuecomment-208932133 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-3724][ML] RandomForest: More options fo...

2016-04-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11989#issuecomment-208928721 **[Test build #55606 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55606/consoleFull)** for PR 11989 at commit [`8a4c298`](https://g

[GitHub] spark pull request: [SPARK-13568] [ML] Create feature transformer ...

2016-04-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11601#issuecomment-208928621 **[Test build #55612 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55612/consoleFull)** for PR 11601 at commit [`4bdf595`](https://gi

[GitHub] spark pull request: [SPARK-13568] [ML] Create feature transformer ...

2016-04-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11601#issuecomment-208932083 **[Test build #55612 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55612/consoleFull)** for PR 11601 at commit [`4bdf595`](https://g

[GitHub] spark pull request: [SPARK-14479] [ML] GLM supports output link pr...

2016-04-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12287#issuecomment-208931037 **[Test build #55613 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55613/consoleFull)** for PR 12287 at commit [`e5aea09`](https://gi

[GitHub] spark pull request: [SPARK-14558][CORE] In ClosureCleaner, clean t...

2016-04-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12327#issuecomment-208930686 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-12492] Using spark-sql commond to run q...

2016-04-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10900#issuecomment-208926178 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14479] [ML] GLM supports output link pr...

2016-04-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12287#issuecomment-208926466 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-12492] Using spark-sql commond to run q...

2016-04-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10900#issuecomment-208926182 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-12492] Using spark-sql commond to run q...

2016-04-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10900#issuecomment-208926170 **[Test build #55611 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55611/consoleFull)** for PR 10900 at commit [`64080c7`](https://g

[GitHub] spark pull request: [SPARK-14479] [ML] GLM supports output link pr...

2016-04-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12287#issuecomment-208926470 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

<    1   2   3   4   5   6   7   8   >