[GitHub] spark pull request: [HOTFIX][SQL] sparkSession can't be private.

2016-04-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12684#issuecomment-214611841 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [HOTFIX][SQL] sparkSession can't be private.

2016-04-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12684#issuecomment-214611632 **[Test build #56960 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56960/consoleFull)** for PR 12684 at commit [`1c8b246`](https://g

[GitHub] spark pull request: [SPARK-14889][Spark Core] scala.MatchError: NO...

2016-04-25 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/12666#issuecomment-214611155 LGTM pending Jenkins. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this f

[GitHub] spark pull request: [SPARK-14889][Spark Core] scala.MatchError: NO...

2016-04-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12666#issuecomment-214611080 **[Test build #2883 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2883/consoleFull)** for PR 12666 at commit [`4658936`](https://g

[GitHub] spark pull request: [SPARK-14445][SQL] Support native execution of...

2016-04-25 Thread dilipbiswal
Github user dilipbiswal commented on a diff in the pull request: https://github.com/apache/spark/pull/1#discussion_r61027608 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveCommandSuite.scala --- @@ -122,4 +134,105 @@ class HiveCommandSuite extends Qu

[GitHub] spark pull request: [SPARK-14853] [SQL] Support LeftSemi/LeftAnti ...

2016-04-25 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/12668#issuecomment-214610321 @hvanhovell want to review? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-14480][SQL] Simplify CSV parsing proces...

2016-04-25 Thread HyukjinKwon
Github user HyukjinKwon commented on the pull request: https://github.com/apache/spark/pull/12268#issuecomment-214609981 This was due to https://github.com/apache/spark/commit/d2614eaadb93a48fba27fe7de64aff942e345f8e --- If your project is set up for it, you can reply to this email a

[GitHub] spark pull request: [SPARK-14483][WEBUI] Display user name for eac...

2016-04-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12257#issuecomment-214609281 **[Test build #56962 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56962/consoleFull)** for PR 12257 at commit [`b8a0a7d`](https://gi

[GitHub] spark pull request: [SPARK-14480][SQL] Simplify CSV parsing proces...

2016-04-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12268#issuecomment-214609252 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14874][SQL][Streaming] Remove the obsol...

2016-04-25 Thread lw-lin
Github user lw-lin commented on the pull request: https://github.com/apache/spark/pull/12638#issuecomment-214609215 some build issues unrelated to this PR. Jenkins retest this please --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request: [SPARK-14480][SQL] Simplify CSV parsing proces...

2016-04-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12268#issuecomment-214609239 **[Test build #56961 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56961/consoleFull)** for PR 12268 at commit [`d59c7e9`](https://g

[GitHub] spark pull request: [SPARK-14480][SQL] Simplify CSV parsing proces...

2016-04-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12268#issuecomment-214609249 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14806] [SQL] Alias original Hive option...

2016-04-25 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/12607#issuecomment-214609204 Hi @bomeng - thanks for doing this. I thought about it more and actually think maybe it's not worth it to support these aliases, because it is going to be confusing when

[GitHub] spark pull request: [HOTFIX][SQL] sparkSession can't be private.

2016-04-25 Thread dongjoon-hyun
Github user dongjoon-hyun closed the pull request at: https://github.com/apache/spark/pull/12684 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark pull request: [HOTFIX][SQL] sparkSession can't be private.

2016-04-25 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/12684#issuecomment-214609078 Sure! Thank for quick fix. I found that when I rebase my PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHu

[GitHub] spark pull request: [HOTFIX][SQL] sparkSession can't be private.

2016-04-25 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/12684#issuecomment-214608932 Thanks - actually I pushed directly to master just now. Can you close this? --- If your project is set up for it, you can reply to this email and have your reply appear o

[GitHub] spark pull request: [HOTFIX][SQL] sparkSession can't be private.

2016-04-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12684#issuecomment-214608733 **[Test build #56960 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56960/consoleFull)** for PR 12684 at commit [`1c8b246`](https://gi

[GitHub] spark pull request: [SPARK-14480][SQL] Simplify CSV parsing proces...

2016-04-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12268#issuecomment-214608734 **[Test build #56961 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56961/consoleFull)** for PR 12268 at commit [`d59c7e9`](https://gi

[GitHub] spark pull request: [SPARK-14480][SQL] Simplify CSV parsing proces...

2016-04-25 Thread HyukjinKwon
Github user HyukjinKwon commented on the pull request: https://github.com/apache/spark/pull/12268#issuecomment-214608678 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have thi

[GitHub] spark pull request: [HOTFIX][SQL] sparkSession can't be private.

2016-04-25 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/12684#issuecomment-214608530 cc @rxin . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fea

[GitHub] spark pull request: [HOTFIX][SQL] sparkSession can't be private.

2016-04-25 Thread dongjoon-hyun
GitHub user dongjoon-hyun opened a pull request: https://github.com/apache/spark/pull/12684 [HOTFIX][SQL] sparkSession can't be private. ## What changes were proposed in this pull request? This fixes the following errors. ``` -@transient private val sparkSession:

[GitHub] spark pull request: [SPARK-14480][SQL] Simplify CSV parsing proces...

2016-04-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12268#issuecomment-214608176 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14480][SQL] Simplify CSV parsing proces...

2016-04-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12268#issuecomment-214608175 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14480][SQL] Simplify CSV parsing proces...

2016-04-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12268#issuecomment-214608169 **[Test build #56959 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56959/consoleFull)** for PR 12268 at commit [`d59c7e9`](https://g

[GitHub] spark pull request: [Spark-14314][SparkR] Add model persistence to...

2016-04-25 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/12680#discussion_r61026788 --- Diff: mllib/src/main/scala/org/apache/spark/ml/r/KMeansWrapper.scala --- @@ -17,14 +17,21 @@ package org.apache.spark.ml.r +impor

[GitHub] spark pull request: [SPARK-14729][Scheduler] Refactored YARN sched...

2016-04-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12641#issuecomment-214607771 **[Test build #56956 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56956/consoleFull)** for PR 12641 at commit [`8117184`](https://g

[GitHub] spark pull request: [SPARK-14729][Scheduler] Refactored YARN sched...

2016-04-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12641#issuecomment-214607778 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14729][Scheduler] Refactored YARN sched...

2016-04-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12641#issuecomment-21460 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14483][WEBUI] Display user name for eac...

2016-04-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12257#issuecomment-214607350 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14483][WEBUI] Display user name for eac...

2016-04-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12257#issuecomment-214607351 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14483][WEBUI] Display user name for eac...

2016-04-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12257#issuecomment-214607346 **[Test build #56958 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56958/consoleFull)** for PR 12257 at commit [`256b812`](https://g

[GitHub] spark pull request: [SPARK-14874][SQL][Streaming] Remove the obsol...

2016-04-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12638#issuecomment-214607395 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14874][SQL][Streaming] Remove the obsol...

2016-04-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12638#issuecomment-214607393 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14480][SQL] Simplify CSV parsing proces...

2016-04-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12268#issuecomment-214607369 **[Test build #56959 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56959/consoleFull)** for PR 12268 at commit [`d59c7e9`](https://gi

[GitHub] spark pull request: [SPARK-14315][SparkR]Add model persistence to ...

2016-04-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12683#issuecomment-214607333 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your p

[GitHub] spark pull request: [SPARK-14874][SQL][Streaming] Remove the obsol...

2016-04-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12638#issuecomment-214607377 **[Test build #56957 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56957/consoleFull)** for PR 12638 at commit [`14e6900`](https://g

[GitHub] spark pull request: [SPARK-14910] [SQL] Native DDL Command Support...

2016-04-25 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/12679#issuecomment-214607013 @hvanhovell @yhuai Could you review the changes? Thank you! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: [SPARK-14874][SQL][Streaming] Remove the obsol...

2016-04-25 Thread lw-lin
Github user lw-lin commented on the pull request: https://github.com/apache/spark/pull/12638#issuecomment-214606875 @marmbrus thanks for the patient reminder! Since I've reverted the renaming, and I've checked there's no other completely unused class under `o.a.s.sql.execution

[GitHub] spark pull request: [SPARK-14315][SparkR]Add model persistence to ...

2016-04-25 Thread GayathriMurali
GitHub user GayathriMurali opened a pull request: https://github.com/apache/spark/pull/12683 [SPARK-14315][SparkR]Add model persistence to GLMs ## What changes were proposed in this pull request? Add model persistence to GLMs in SparkR Unit tests added Y

[GitHub] spark pull request: [SPARK-14729][Scheduler] Refactored YARN sched...

2016-04-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12641#issuecomment-214606828 **[Test build #56956 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56956/consoleFull)** for PR 12641 at commit [`8117184`](https://gi

[GitHub] spark pull request: [SPARK-14874][SQL][Streaming] Remove the obsol...

2016-04-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12638#issuecomment-214606829 **[Test build #56957 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56957/consoleFull)** for PR 12638 at commit [`14e6900`](https://gi

[GitHub] spark pull request: [SPARK-14483][WEBUI] Display user name for eac...

2016-04-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12257#issuecomment-214606825 **[Test build #56958 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56958/consoleFull)** for PR 12257 at commit [`256b812`](https://gi

[GitHub] spark pull request: [SPARK-14874][SQL][Streaming] Remove the obsol...

2016-04-25 Thread lw-lin
GitHub user lw-lin reopened a pull request: https://github.com/apache/spark/pull/12638 [SPARK-14874][SQL][Streaming] Remove the obsolete Batch representation ## What changes were proposed in this pull request? The `Batch` class, which had been used to indicate progress in a

[GitHub] spark pull request: [SPARK-14483][WEBUI] Display user name for eac...

2016-04-25 Thread sarutak
Github user sarutak commented on the pull request: https://github.com/apache/spark/pull/12257#issuecomment-214606536 ping @tgravescs --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featu

[GitHub] spark pull request: [MINOR][BUILD] Enable RAT checking on `LZ4Bloc...

2016-04-25 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/12677#issuecomment-214606445 Hi, @davies and @srowen . This PR just removes `LZ4BlockInputStream.java` from `dev/.rat-exclude` and passed the RAT test. Could you merge this PR? --- I

[GitHub] spark pull request: [SPARK-14729][Scheduler] Refactored YARN sched...

2016-04-25 Thread hbhanawat
Github user hbhanawat commented on the pull request: https://github.com/apache/spark/pull/12641#issuecomment-214606466 @vanzin @rxin Thanks for commenting. Incorporated review comments apart from the masterURL comment. Regarding the masterURL being part of API, I think the sc

[GitHub] spark pull request: [Spark-14314][SparkR] Add model persistence to...

2016-04-25 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/12680#discussion_r61025886 --- Diff: mllib/src/main/scala/org/apache/spark/ml/r/KMeansWrapper.scala --- @@ -17,14 +17,21 @@ package org.apache.spark.ml.r +impor

[GitHub] spark pull request: [SPARK-14861][SQL] Replace internal usages of ...

2016-04-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12625#issuecomment-214605915 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14861][SQL] Replace internal usages of ...

2016-04-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12625#issuecomment-214605913 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14861][SQL] Replace internal usages of ...

2016-04-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12625#issuecomment-214605820 **[Test build #56950 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56950/consoleFull)** for PR 12625 at commit [`e47fbf0`](https://g

[GitHub] spark pull request: [SPARK-14480][SQL] Simplify CSV parsing proces...

2016-04-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12268#issuecomment-214605811 **[Test build #56955 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56955/consoleFull)** for PR 12268 at commit [`ad21b8e`](https://gi

[GitHub] spark pull request: [SPARK-14907][MLLIB] Use repartition in GLMReg...

2016-04-25 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/12676#issuecomment-214605818 Hi, @jkbradley . Could you review this PR when you have some time? --- If your project is set up for it, you can reply to this email and have your reply appea

[GitHub] spark pull request: [SPARK-14861][SQL] Replace internal usages of ...

2016-04-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/12625 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request: [SPARK-14904][SQL] Put removed HiveContext in ...

2016-04-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/12672 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request: [SPARK-14904][SQL] Put removed HiveContext in ...

2016-04-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/12682 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request: [SPARK-14911][Core] Fix a potential data race ...

2016-04-25 Thread lw-lin
Github user lw-lin commented on the pull request: https://github.com/apache/spark/pull/12681#issuecomment-214605511 @davies (who made the first change) might want to take a look? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: [SPARK-14861][SQL] Replace internal usages of ...

2016-04-25 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/12625#issuecomment-214605459 Merging in master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

[GitHub] spark pull request: [SPARK-14904][SQL] Put removed HiveContext in ...

2016-04-25 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/12682#issuecomment-214604567 Merging - I fixed the test and verified locally. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your p

[GitHub] spark pull request: [SPARK-13432][SQL] add the source file name an...

2016-04-25 Thread kiszk
Github user kiszk commented on the pull request: https://github.com/apache/spark/pull/11301#issuecomment-214604863 No problem, it seemed to be some conflicts in this PR last week. I will continue to resolve conflicts as soon as possible. --- If your project is set up for it, you can

[GitHub] spark pull request: [SPARK-14800][SQL] Dealing with null as a valu...

2016-04-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12629#issuecomment-214604317 **[Test build #56954 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56954/consoleFull)** for PR 12629 at commit [`2fa4a12`](https://gi

[GitHub] spark pull request: [SPARK-14904][SQL] Put removed HiveContext in ...

2016-04-25 Thread rxin
GitHub user rxin opened a pull request: https://github.com/apache/spark/pull/12682 [SPARK-14904][SQL] Put removed HiveContext in compatibility module ## What changes were proposed in this pull request? This is for users who can't upgrade and need to continue to use HiveContext.

[GitHub] spark pull request: [SPARK-14861][SQL] Replace internal usages of ...

2016-04-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12625#issuecomment-214602181 **[Test build #2880 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2880/consoleFull)** for PR 12625 at commit [`e47fbf0`](https://

[GitHub] spark pull request: [SPARK-14911][Core] Fix a potential data race ...

2016-04-25 Thread lw-lin
Github user lw-lin commented on the pull request: https://github.com/apache/spark/pull/12681#issuecomment-214601397 Actually this wouldn't cause any problem and wouldn't fail any test suits **_for now_**, because the read of `acquiredButNotUsed` is guaranteed to see most recent value

[GitHub] spark pull request: [SPARK-13432][SQL] add the source file name an...

2016-04-25 Thread sarutak
Github user sarutak commented on the pull request: https://github.com/apache/spark/pull/11301#issuecomment-214600906 @kiszk Sorry I was going to review last week but I didn't have enough time. I might make time this weekend. --- If your project is set up for it, you can reply to th

[GitHub] spark pull request: [SPARK-14861][SQL] Replace internal usages of ...

2016-04-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12625#issuecomment-214600667 **[Test build #2882 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2882/consoleFull)** for PR 12625 at commit [`e47fbf0`](https://

[GitHub] spark pull request: [SPARK-14911][Core] Fix a potential data race ...

2016-04-25 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/12681#issuecomment-214598957 cc @andrewor14 and @JoshRosen --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not hav

[GitHub] spark pull request: [SPARK-14874][SQL][Streaming] Remove the obsol...

2016-04-25 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/12638#issuecomment-214597468 To be clear, if there's a completely unused class, I think it's worth the time to delete it (dead code is confusing for people trying to learn the code base).

[GitHub] spark pull request: [SPARK-14904][SQL] Put removed HiveContext in ...

2016-04-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12672#issuecomment-214596991 **[Test build #2878 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2878/consoleFull)** for PR 12672 at commit [`4d3f745`](https://

[GitHub] spark pull request: [SPARK-14910] [SQL] Native DDL Command Support...

2016-04-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12679#issuecomment-214596879 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14910] [SQL] Native DDL Command Support...

2016-04-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12679#issuecomment-214596881 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14910] [SQL] Native DDL Command Support...

2016-04-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12679#issuecomment-214596748 **[Test build #56951 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56951/consoleFull)** for PR 12679 at commit [`d0f203b`](https://g

[GitHub] spark pull request: [SPARK-14911][Core] Fix a potential data race ...

2016-04-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12681#issuecomment-214596791 **[Test build #56953 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56953/consoleFull)** for PR 12681 at commit [`6b72b96`](https://gi

[GitHub] spark pull request: [SPARK-14911][Core] Fix a potential data race ...

2016-04-25 Thread lw-lin
GitHub user lw-lin opened a pull request: https://github.com/apache/spark/pull/12681 [SPARK-14911][Core] Fix a potential data race in TaskMemoryManager ## What changes were proposed in this pull request? [[SPARK-13210][SQL] catch OOM when allocate memory and expand array](h

[GitHub] spark pull request: [SPARK-14904][SQL] Put removed HiveContext in ...

2016-04-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12672#issuecomment-214596283 **[Test build #2879 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2879/consoleFull)** for PR 12672 at commit [`4d3f745`](https://

[GitHub] spark pull request: [SPARK-14409][ML] Adding a RankingEvaluator to...

2016-04-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12461#issuecomment-214595882 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14861][SQL] Replace internal usages of ...

2016-04-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12625#issuecomment-214595976 **[Test build #2881 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2881/consoleFull)** for PR 12625 at commit [`e47fbf0`](https://

[GitHub] spark pull request: [SPARK-14409][ML] Adding a RankingEvaluator to...

2016-04-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12461#issuecomment-214595886 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14409][ML] Adding a RankingEvaluator to...

2016-04-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12461#issuecomment-214595732 **[Test build #56952 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56952/consoleFull)** for PR 12461 at commit [`a35d961`](https://g

[GitHub] spark pull request: [Spark-14314][SparkR] Add model persistence to...

2016-04-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12680#issuecomment-214593821 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your p

[GitHub] spark pull request: [SPARK-14098][SQL] Generate Java code that get...

2016-04-25 Thread kiszk
Github user kiszk commented on the pull request: https://github.com/apache/spark/pull/11956#issuecomment-214593726 @rxin, would it be possible to review this PR, too? Especially, for decompression part that you originally wrote. --- If your project is set up for it, you can reply to

[GitHub] spark pull request: [Spark-14314][SparkR] Add model persistence to...

2016-04-25 Thread GayathriMurali
GitHub user GayathriMurali opened a pull request: https://github.com/apache/spark/pull/12680 [Spark-14314][SparkR] Add model persistence to KMeans ## What changes were proposed in this pull request? Add model persistence to KMeans SparkR ## How was this patch t

[GitHub] spark pull request: [SPARK-14904][SQL] Put removed HiveContext in ...

2016-04-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12672#issuecomment-214593441 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14904][SQL] Put removed HiveContext in ...

2016-04-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12672#issuecomment-214593440 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14904][SQL] Put removed HiveContext in ...

2016-04-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12672#issuecomment-214593367 **[Test build #56949 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56949/consoleFull)** for PR 12672 at commit [`4d3f745`](https://g

[GitHub] spark pull request: [SPARK-14849][CORE]Always set an address for t...

2016-04-25 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/12613#discussion_r61022118 --- Diff: core/src/main/scala/org/apache/spark/rpc/netty/NettyRpcEnv.scala --- @@ -122,7 +122,7 @@ private[netty] class NettyRpcEnv( @Nullable

[GitHub] spark pull request: [SPARK-14849][CORE]Always set an address for t...

2016-04-25 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/12613#discussion_r61022100 --- Diff: core/src/main/scala/org/apache/spark/rpc/netty/NettyRpcEnv.scala --- @@ -122,7 +122,7 @@ private[netty] class NettyRpcEnv( @Nullable

[GitHub] spark pull request: [SPARK-14849][CORE]Always set an address for t...

2016-04-25 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/12613#issuecomment-214591914 I think there are also some code in SparkEnv that deals with this? ``` if (isDriver) { conf.set("spark.driver.port", rpcEnv.address.port.toString)

[GitHub] spark pull request: [SPARK-14409][ML] Adding a RankingEvaluator to...

2016-04-25 Thread yongtang
Github user yongtang commented on the pull request: https://github.com/apache/spark/pull/12461#issuecomment-214591768 @MLnick @srowen I just updated the pull request to wrap the RankingEvaluator into calling RankingMetrics. Was finally able to fix the exception issue I previously enco

[GitHub] spark pull request: [SPARK-14409][ML] Adding a RankingEvaluator to...

2016-04-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12461#issuecomment-214591542 **[Test build #56952 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56952/consoleFull)** for PR 12461 at commit [`a35d961`](https://gi

[GitHub] spark pull request: [SPARK-14904][SQL] Put removed HiveContext in ...

2016-04-25 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/12672#issuecomment-214591014 LGTM. Let's fix the test and get it in. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project do

[GitHub] spark pull request: [SPARK-14904][SQL] Put removed HiveContext in ...

2016-04-25 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/12672#discussion_r61021153 --- Diff: sql/hivecontext-compatibility/src/test/scala/org/apache/spark/sql/hive/HiveContextCompatibilitySuite.scala --- @@ -0,0 +1,100 @@ +/* +*

[GitHub] spark pull request: [SPARK-14904][SQL] Put removed HiveContext in ...

2016-04-25 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/12672#issuecomment-214588696 ``` [info] HiveContextCompatibilitySuite: [info] - basic operations (11 seconds, 60 milliseconds) [info] - basic DDLs *** FAILED *** (1 second, 754 millisec

[GitHub] spark pull request: [MINOR][BUILD] Enable RAT checking on `LZ4Bloc...

2016-04-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12677#issuecomment-214588007 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [MINOR][BUILD] Enable RAT checking on `LZ4Bloc...

2016-04-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12677#issuecomment-214588009 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [MINOR][BUILD] Enable RAT checking on `LZ4Bloc...

2016-04-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12677#issuecomment-214587875 **[Test build #56948 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56948/consoleFull)** for PR 12677 at commit [`5279cd8`](https://g

[GitHub] spark pull request: [SPARK-14874][SQL][Streaming] Remove the obsol...

2016-04-25 Thread lw-lin
Github user lw-lin commented on the pull request: https://github.com/apache/spark/pull/12638#issuecomment-214586964 Sure, so I'm closing this PR since the removal itself is not worthy for committers to process. @marmbrus thanks for the review! --- If your project is set up for it

[GitHub] spark pull request: [SPARK-14874][SQL][Streaming] Remove the obsol...

2016-04-25 Thread lw-lin
Github user lw-lin closed the pull request at: https://github.com/apache/spark/pull/12638 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request: [SPARK-14889][Spark Core] scala.MatchError: NO...

2016-04-25 Thread sbcd90
Github user sbcd90 commented on the pull request: https://github.com/apache/spark/pull/12666#issuecomment-214586830 Hi @srowen , changed to `IllegalArgumentException`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as we

[GitHub] spark pull request: [SPARK-12919][SPARKR] Implement dapply() on Da...

2016-04-25 Thread sun-rui
Github user sun-rui commented on the pull request: https://github.com/apache/spark/pull/12493#issuecomment-214585898 @shivaram, it may be related to the workaround for SPARK-14803, let me check it --- If your project is set up for it, you can reply to this email and have your reply a

[GitHub] spark pull request: [SPARK-14910] [SQL] Native DDL Command Support...

2016-04-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12679#issuecomment-214585606 **[Test build #56951 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56951/consoleFull)** for PR 12679 at commit [`d0f203b`](https://gi

<    1   2   3   4   5   6   7   8   >