[GitHub] spark pull request: [SPARK-14483][WEBUI] Display user name for eac...

2016-04-25 Thread sarutak
Github user sarutak commented on the pull request: https://github.com/apache/spark/pull/12257#issuecomment-214606536 ping @tgravescs --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [MINOR][BUILD] Enable RAT checking on `LZ4Bloc...

2016-04-25 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/12677#issuecomment-214606445 Hi, @davies and @srowen . This PR just removes `LZ4BlockInputStream.java` from `dev/.rat-exclude` and passed the RAT test. Could you merge this PR? ---

[GitHub] spark pull request: [SPARK-14729][Scheduler] Refactored YARN sched...

2016-04-25 Thread hbhanawat
Github user hbhanawat commented on the pull request: https://github.com/apache/spark/pull/12641#issuecomment-214606466 @vanzin @rxin Thanks for commenting. Incorporated review comments apart from the masterURL comment. Regarding the masterURL being part of API, I think the

[GitHub] spark pull request: [Spark-14314][SparkR] Add model persistence to...

2016-04-25 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/12680#discussion_r61025886 --- Diff: mllib/src/main/scala/org/apache/spark/ml/r/KMeansWrapper.scala --- @@ -17,14 +17,21 @@ package org.apache.spark.ml.r

[GitHub] spark pull request: [SPARK-14861][SQL] Replace internal usages of ...

2016-04-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12625#issuecomment-214605915 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14861][SQL] Replace internal usages of ...

2016-04-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12625#issuecomment-214605913 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14861][SQL] Replace internal usages of ...

2016-04-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12625#issuecomment-214605820 **[Test build #56950 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56950/consoleFull)** for PR 12625 at commit

[GitHub] spark pull request: [SPARK-14480][SQL] Simplify CSV parsing proces...

2016-04-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12268#issuecomment-214605811 **[Test build #56955 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56955/consoleFull)** for PR 12268 at commit

[GitHub] spark pull request: [SPARK-14907][MLLIB] Use repartition in GLMReg...

2016-04-25 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/12676#issuecomment-214605818 Hi, @jkbradley . Could you review this PR when you have some time? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: [SPARK-14861][SQL] Replace internal usages of ...

2016-04-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/12625 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-14904][SQL] Put removed HiveContext in ...

2016-04-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/12672 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-14904][SQL] Put removed HiveContext in ...

2016-04-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/12682 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-14911][Core] Fix a potential data race ...

2016-04-25 Thread lw-lin
Github user lw-lin commented on the pull request: https://github.com/apache/spark/pull/12681#issuecomment-214605511 @davies (who made the first change) might want to take a look? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: [SPARK-14861][SQL] Replace internal usages of ...

2016-04-25 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/12625#issuecomment-214605459 Merging in master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-14904][SQL] Put removed HiveContext in ...

2016-04-25 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/12682#issuecomment-214604567 Merging - I fixed the test and verified locally. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13432][SQL] add the source file name an...

2016-04-25 Thread kiszk
Github user kiszk commented on the pull request: https://github.com/apache/spark/pull/11301#issuecomment-214604863 No problem, it seemed to be some conflicts in this PR last week. I will continue to resolve conflicts as soon as possible. --- If your project is set up for it, you can

[GitHub] spark pull request: [SPARK-14800][SQL] Dealing with null as a valu...

2016-04-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12629#issuecomment-214604317 **[Test build #56954 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56954/consoleFull)** for PR 12629 at commit

[GitHub] spark pull request: [SPARK-14904][SQL] Put removed HiveContext in ...

2016-04-25 Thread rxin
GitHub user rxin opened a pull request: https://github.com/apache/spark/pull/12682 [SPARK-14904][SQL] Put removed HiveContext in compatibility module ## What changes were proposed in this pull request? This is for users who can't upgrade and need to continue to use HiveContext.

[GitHub] spark pull request: [SPARK-14861][SQL] Replace internal usages of ...

2016-04-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12625#issuecomment-214602181 **[Test build #2880 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2880/consoleFull)** for PR 12625 at commit

[GitHub] spark pull request: [SPARK-14911][Core] Fix a potential data race ...

2016-04-25 Thread lw-lin
Github user lw-lin commented on the pull request: https://github.com/apache/spark/pull/12681#issuecomment-214601397 Actually this wouldn't cause any problem and wouldn't fail any test suits **_for now_**, because the read of `acquiredButNotUsed` is guaranteed to see most recent value

[GitHub] spark pull request: [SPARK-13432][SQL] add the source file name an...

2016-04-25 Thread sarutak
Github user sarutak commented on the pull request: https://github.com/apache/spark/pull/11301#issuecomment-214600906 @kiszk Sorry I was going to review last week but I didn't have enough time. I might make time this weekend. --- If your project is set up for it, you can reply to

[GitHub] spark pull request: [SPARK-14861][SQL] Replace internal usages of ...

2016-04-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12625#issuecomment-214600667 **[Test build #2882 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2882/consoleFull)** for PR 12625 at commit

[GitHub] spark pull request: [SPARK-14911][Core] Fix a potential data race ...

2016-04-25 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/12681#issuecomment-214598957 cc @andrewor14 and @JoshRosen --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-14874][SQL][Streaming] Remove the obsol...

2016-04-25 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/12638#issuecomment-214597468 To be clear, if there's a completely unused class, I think it's worth the time to delete it (dead code is confusing for people trying to learn the code base).

[GitHub] spark pull request: [SPARK-14904][SQL] Put removed HiveContext in ...

2016-04-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12672#issuecomment-214596991 **[Test build #2878 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2878/consoleFull)** for PR 12672 at commit

[GitHub] spark pull request: [SPARK-14910] [SQL] Native DDL Command Support...

2016-04-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12679#issuecomment-214596879 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14910] [SQL] Native DDL Command Support...

2016-04-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12679#issuecomment-214596881 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14910] [SQL] Native DDL Command Support...

2016-04-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12679#issuecomment-214596748 **[Test build #56951 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56951/consoleFull)** for PR 12679 at commit

[GitHub] spark pull request: [SPARK-14911][Core] Fix a potential data race ...

2016-04-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12681#issuecomment-214596791 **[Test build #56953 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56953/consoleFull)** for PR 12681 at commit

[GitHub] spark pull request: [SPARK-14911][Core] Fix a potential data race ...

2016-04-25 Thread lw-lin
GitHub user lw-lin opened a pull request: https://github.com/apache/spark/pull/12681 [SPARK-14911][Core] Fix a potential data race in TaskMemoryManager ## What changes were proposed in this pull request? [[SPARK-13210][SQL] catch OOM when allocate memory and expand

[GitHub] spark pull request: [SPARK-14904][SQL] Put removed HiveContext in ...

2016-04-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12672#issuecomment-214596283 **[Test build #2879 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2879/consoleFull)** for PR 12672 at commit

[GitHub] spark pull request: [SPARK-14409][ML] Adding a RankingEvaluator to...

2016-04-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12461#issuecomment-214595882 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14861][SQL] Replace internal usages of ...

2016-04-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12625#issuecomment-214595976 **[Test build #2881 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2881/consoleFull)** for PR 12625 at commit

[GitHub] spark pull request: [SPARK-14409][ML] Adding a RankingEvaluator to...

2016-04-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12461#issuecomment-214595886 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14409][ML] Adding a RankingEvaluator to...

2016-04-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12461#issuecomment-214595732 **[Test build #56952 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56952/consoleFull)** for PR 12461 at commit

[GitHub] spark pull request: [Spark-14314][SparkR] Add model persistence to...

2016-04-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12680#issuecomment-214593821 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14098][SQL] Generate Java code that get...

2016-04-25 Thread kiszk
Github user kiszk commented on the pull request: https://github.com/apache/spark/pull/11956#issuecomment-214593726 @rxin, would it be possible to review this PR, too? Especially, for decompression part that you originally wrote. --- If your project is set up for it, you can reply to

[GitHub] spark pull request: [Spark-14314][SparkR] Add model persistence to...

2016-04-25 Thread GayathriMurali
GitHub user GayathriMurali opened a pull request: https://github.com/apache/spark/pull/12680 [Spark-14314][SparkR] Add model persistence to KMeans ## What changes were proposed in this pull request? Add model persistence to KMeans SparkR ## How was this patch

[GitHub] spark pull request: [SPARK-14904][SQL] Put removed HiveContext in ...

2016-04-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12672#issuecomment-214593441 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14904][SQL] Put removed HiveContext in ...

2016-04-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12672#issuecomment-214593440 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14904][SQL] Put removed HiveContext in ...

2016-04-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12672#issuecomment-214593367 **[Test build #56949 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56949/consoleFull)** for PR 12672 at commit

[GitHub] spark pull request: [SPARK-14849][CORE]Always set an address for t...

2016-04-25 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/12613#discussion_r61022118 --- Diff: core/src/main/scala/org/apache/spark/rpc/netty/NettyRpcEnv.scala --- @@ -122,7 +122,7 @@ private[netty] class NettyRpcEnv( @Nullable

[GitHub] spark pull request: [SPARK-14849][CORE]Always set an address for t...

2016-04-25 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/12613#discussion_r61022100 --- Diff: core/src/main/scala/org/apache/spark/rpc/netty/NettyRpcEnv.scala --- @@ -122,7 +122,7 @@ private[netty] class NettyRpcEnv( @Nullable

[GitHub] spark pull request: [SPARK-14849][CORE]Always set an address for t...

2016-04-25 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/12613#issuecomment-214591914 I think there are also some code in SparkEnv that deals with this? ``` if (isDriver) { conf.set("spark.driver.port", rpcEnv.address.port.toString)

[GitHub] spark pull request: [SPARK-14409][ML] Adding a RankingEvaluator to...

2016-04-25 Thread yongtang
Github user yongtang commented on the pull request: https://github.com/apache/spark/pull/12461#issuecomment-214591768 @MLnick @srowen I just updated the pull request to wrap the RankingEvaluator into calling RankingMetrics. Was finally able to fix the exception issue I previously

[GitHub] spark pull request: [SPARK-14409][ML] Adding a RankingEvaluator to...

2016-04-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12461#issuecomment-214591542 **[Test build #56952 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56952/consoleFull)** for PR 12461 at commit

[GitHub] spark pull request: [SPARK-14904][SQL] Put removed HiveContext in ...

2016-04-25 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/12672#issuecomment-214591014 LGTM. Let's fix the test and get it in. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-14904][SQL] Put removed HiveContext in ...

2016-04-25 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/12672#discussion_r61021153 --- Diff: sql/hivecontext-compatibility/src/test/scala/org/apache/spark/sql/hive/HiveContextCompatibilitySuite.scala --- @@ -0,0 +1,100 @@ +/* +*

[GitHub] spark pull request: [SPARK-14904][SQL] Put removed HiveContext in ...

2016-04-25 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/12672#issuecomment-214588696 ``` [info] HiveContextCompatibilitySuite: [info] - basic operations (11 seconds, 60 milliseconds) [info] - basic DDLs *** FAILED *** (1 second, 754

[GitHub] spark pull request: [MINOR][BUILD] Enable RAT checking on `LZ4Bloc...

2016-04-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12677#issuecomment-214588007 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [MINOR][BUILD] Enable RAT checking on `LZ4Bloc...

2016-04-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12677#issuecomment-214588009 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [MINOR][BUILD] Enable RAT checking on `LZ4Bloc...

2016-04-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12677#issuecomment-214587875 **[Test build #56948 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56948/consoleFull)** for PR 12677 at commit

[GitHub] spark pull request: [SPARK-14874][SQL][Streaming] Remove the obsol...

2016-04-25 Thread lw-lin
Github user lw-lin commented on the pull request: https://github.com/apache/spark/pull/12638#issuecomment-214586964 Sure, so I'm closing this PR since the removal itself is not worthy for committers to process. @marmbrus thanks for the review! --- If your project is set up for

[GitHub] spark pull request: [SPARK-14874][SQL][Streaming] Remove the obsol...

2016-04-25 Thread lw-lin
Github user lw-lin closed the pull request at: https://github.com/apache/spark/pull/12638 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-14889][Spark Core] scala.MatchError: NO...

2016-04-25 Thread sbcd90
Github user sbcd90 commented on the pull request: https://github.com/apache/spark/pull/12666#issuecomment-214586830 Hi @srowen , changed to `IllegalArgumentException`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: [SPARK-12919][SPARKR] Implement dapply() on Da...

2016-04-25 Thread sun-rui
Github user sun-rui commented on the pull request: https://github.com/apache/spark/pull/12493#issuecomment-214585898 @shivaram, it may be related to the workaround for SPARK-14803, let me check it --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: [SPARK-14910] [SQL] Native DDL Command Support...

2016-04-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12679#issuecomment-214585606 **[Test build #56951 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56951/consoleFull)** for PR 12679 at commit

[GitHub] spark pull request: [SPARK-14803][SQL][Optimizer] A bug in Elimina...

2016-04-25 Thread sun-rui
Github user sun-rui commented on the pull request: https://github.com/apache/spark/pull/12575#issuecomment-214585552 OK. I will study optimizer and try to have a better fix. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: [SPARK-14747][SQL] Add assertStreaming/assertN...

2016-04-25 Thread lw-lin
Github user lw-lin commented on the pull request: https://github.com/apache/spark/pull/12521#issuecomment-214585357 Updates: thanks to [[SPARK-14473][SQL] Define analysis rules to catch operations not supported in

[GitHub] spark pull request: [SPARK-14910] [SQL] Native DDL Command Support...

2016-04-25 Thread gatorsmile
GitHub user gatorsmile opened a pull request: https://github.com/apache/spark/pull/12679 [SPARK-14910] [SQL] Native DDL Command Support for Describe Function in Non-identifier Format What changes were proposed in this pull request? The existing `Describe Function` only

[GitHub] spark pull request: [SPARK-14828][SQL] Start SparkSession in REPL ...

2016-04-25 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/12589#issuecomment-214584300 it'll be there later --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-10780][ML][WIP] Add initial model to km...

2016-04-25 Thread dbtsai
Github user dbtsai commented on a diff in the pull request: https://github.com/apache/spark/pull/9#discussion_r61018699 --- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/KMeans.scala --- @@ -274,6 +339,12 @@ class KMeans @Since("1.5.0") (

[GitHub] spark pull request: [SPARK-14861][SQL] Replace internal usages of ...

2016-04-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12625#issuecomment-214583679 **[Test build #56950 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56950/consoleFull)** for PR 12625 at commit

[GitHub] spark pull request: [SPARK-10780][ML][WIP] Add initial model to km...

2016-04-25 Thread dbtsai
Github user dbtsai commented on a diff in the pull request: https://github.com/apache/spark/pull/9#discussion_r61018493 --- Diff: mllib/src/main/scala/org/apache/spark/ml/param/shared/sharedGeneralTypeParams.scala --- @@ -0,0 +1,34 @@ +/* --- End diff -- I

[GitHub] spark pull request: [SPARK-14861][SQL] Replace internal usages of ...

2016-04-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12625#issuecomment-214583172 **[Test build #2881 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2881/consoleFull)** for PR 12625 at commit

[GitHub] spark pull request: [SPARK-14861][SQL] Replace internal usages of ...

2016-04-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12625#issuecomment-214583192 **[Test build #2882 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2882/consoleFull)** for PR 12625 at commit

[GitHub] spark pull request: [SPARK-14861][SQL] Replace internal usages of ...

2016-04-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12625#issuecomment-214583158 **[Test build #2880 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2880/consoleFull)** for PR 12625 at commit

[GitHub] spark pull request: [SPARK-14904][SQL] Put removed HiveContext in ...

2016-04-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12672#issuecomment-214583134 **[Test build #2879 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2879/consoleFull)** for PR 12672 at commit

[GitHub] spark pull request: [SPARK-14904][SQL] Put removed HiveContext in ...

2016-04-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12672#issuecomment-214583108 **[Test build #2878 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2878/consoleFull)** for PR 12672 at commit

[GitHub] spark pull request: [SPARK-14487][SQL] User Defined Type registrat...

2016-04-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12259#issuecomment-214582968 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14487][SQL] User Defined Type registrat...

2016-04-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12259#issuecomment-214582969 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14487][SQL] User Defined Type registrat...

2016-04-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12259#issuecomment-214582825 **[Test build #56946 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56946/consoleFull)** for PR 12259 at commit

[GitHub] spark pull request: [SPARK-10780][ML][WIP] Add initial model to km...

2016-04-25 Thread dbtsai
Github user dbtsai commented on a diff in the pull request: https://github.com/apache/spark/pull/9#discussion_r61018069 --- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/KMeans.scala --- @@ -258,6 +290,27 @@ class KMeans @Since("1.5.0") ( @Since("1.5.0")

[GitHub] spark pull request: [SPARK-10780][ML][WIP] Add initial model to km...

2016-04-25 Thread dbtsai
Github user dbtsai commented on a diff in the pull request: https://github.com/apache/spark/pull/9#discussion_r61017723 --- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/KMeans.scala --- @@ -198,6 +231,17 @@ object KMeansModel extends MLReadable[KMeansModel] {

[GitHub] spark pull request: [SPARK-10780][ML][WIP] Add initial model to km...

2016-04-25 Thread dbtsai
Github user dbtsai commented on a diff in the pull request: https://github.com/apache/spark/pull/9#discussion_r61017539 --- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/KMeans.scala --- @@ -171,12 +192,23 @@ object KMeansModel extends MLReadable[KMeansModel] {

[GitHub] spark pull request: [SPARK-10780][ML][WIP] Add initial model to km...

2016-04-25 Thread dbtsai
Github user dbtsai commented on a diff in the pull request: https://github.com/apache/spark/pull/9#discussion_r61017075 --- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/KMeans.scala --- @@ -137,6 +138,17 @@ class KMeansModel private[ml] ( @Since("1.6.0")

[GitHub] spark pull request: [SPARK-14904][SQL] Put removed HiveContext in ...

2016-04-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12672#issuecomment-214580247 **[Test build #56949 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56949/consoleFull)** for PR 12672 at commit

[GitHub] spark pull request: [SPARK-14908] [YARN] Provide support HDFS-loca...

2016-04-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12678#issuecomment-214580205 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14706][ML][PySpark] Python ML persisten...

2016-04-25 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/12604#discussion_r61016865 --- Diff: python/pyspark/ml/tuning.py --- @@ -141,6 +144,71 @@ def getEvaluator(self): """ return

[GitHub] spark pull request: [SPARK-14706][ML][PySpark] Python ML persisten...

2016-04-25 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/12604#issuecomment-214580036 I added some comments. I think the tuning.py changes could be simplified somewhat, but I'll need to return to this later. --- If your project is set up for it, you

[GitHub] spark pull request: [SPARK-14908] [YARN] Provide support HDFS-loca...

2016-04-25 Thread mikhaildubkov
GitHub user mikhaildubkov opened a pull request: https://github.com/apache/spark/pull/12678 [SPARK-14908] [YARN] Provide support HDFS-located resources for spark… The main goal behind these changes are provide support to use HDFS resources for "spark.executor.extraClassPath",

[GitHub] spark pull request: [SPARK-14706][ML][PySpark] Python ML persisten...

2016-04-25 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/12604#discussion_r61016852 --- Diff: python/pyspark/ml/tests.py --- @@ -684,6 +689,52 @@ def _compare_pipelines(self, m1, m2): self.assertEqual(len(m1.stages),

[GitHub] spark pull request: [SPARK-14706][ML][PySpark] Python ML persisten...

2016-04-25 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/12604#discussion_r61016862 --- Diff: python/pyspark/ml/tuning.py --- @@ -26,10 +27,10 @@ from pyspark.ml.util import JavaMLWriter, JavaMLReader, MLReadable, MLWritable

[GitHub] spark pull request: [SPARK-14706][ML][PySpark] Python ML persisten...

2016-04-25 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/12604#discussion_r61016854 --- Diff: python/pyspark/ml/tests.py --- @@ -746,6 +797,70 @@ def test_nested_pipeline_persistence(self): except OSError:

[GitHub] spark pull request: [SPARK-14706][ML][PySpark] Python ML persisten...

2016-04-25 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/12604#discussion_r61016847 --- Diff: python/pyspark/ml/tests.py --- @@ -674,8 +676,11 @@ def _compare_pipelines(self, m1, m2): if isinstance(m1, JavaParams):

[GitHub] spark pull request: [SPARK-14870][SQL][FOLLOW-UP] Move decimalData...

2016-04-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/12674 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-14870][SQL][FOLLOW-UP] Move decimalData...

2016-04-25 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/12674#issuecomment-214579476 Merging in master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-14861][SQL] Replace internal usages of ...

2016-04-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12625#issuecomment-214577259 **[Test build #2875 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2875/consoleFull)** for PR 12625 at commit

[GitHub] spark pull request: [SPARK-14907][MLLIB] Use repartition in GLMReg...

2016-04-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12676#issuecomment-214576212 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14907][MLLIB] Use repartition in GLMReg...

2016-04-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12676#issuecomment-214576210 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14907][MLLIB] Use repartition in GLMReg...

2016-04-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12676#issuecomment-214576138 **[Test build #56947 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56947/consoleFull)** for PR 12676 at commit

[GitHub] spark pull request: [SPARK-14870][SQL][FOLLOW-UP] Move decimalData...

2016-04-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12674#issuecomment-214575750 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14870][SQL][FOLLOW-UP] Move decimalData...

2016-04-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12674#issuecomment-214575751 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14870][SQL][FOLLOW-UP] Move decimalData...

2016-04-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12674#issuecomment-214575594 **[Test build #56942 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56942/consoleFull)** for PR 12674 at commit

[GitHub] spark pull request: [SPARK-14902][SQL] Expose RuntimeConfig in Spa...

2016-04-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/12669 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-14902][SQL] Expose RuntimeConfig in Spa...

2016-04-25 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/12669#issuecomment-214575022 LGTM - merging in master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-14571][ML]Log instrumentation in ALS

2016-04-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12560#issuecomment-214574485 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14654][CORE][WIP] New accumulator API

2016-04-25 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/12612#discussion_r61014595 --- Diff: core/src/main/scala/org/apache/spark/NewAccumulator.scala --- @@ -0,0 +1,356 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] spark pull request: [SPARK-14904][SQL] Put removed HiveContext in ...

2016-04-25 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/12672#issuecomment-214574532 Some of my own libraries were able to compile against this, so +1 from me. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: [SPARK-14571][ML]Log instrumentation in ALS

2016-04-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12560#issuecomment-214574484 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

<    1   2   3   4   5   6   7   8   >