[GitHub] spark pull request: [SPARK-15160][SQL] support data source table i...

2016-05-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/12935 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request: [SPARK-15171][SQL]Deprecate registerTempTable ...

2016-05-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12945#issuecomment-218675438 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14891][ML] Add schema validation for AL...

2016-05-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12762#issuecomment-218675488 **[Test build #58455 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58455/consoleFull)** for PR 12762 at commit [`150321f`](https://gi

[GitHub] spark pull request: [SPARK-15171][SQL]Deprecate registerTempTable ...

2016-05-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12945#issuecomment-218675439 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-15171][SQL]Deprecate registerTempTable ...

2016-05-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12945#issuecomment-218675297 **[Test build #58449 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58449/consoleFull)** for PR 12945 at commit [`a9bdd5b`](https://g

[GitHub] spark pull request: [SPARK-15160][SQL] support data source table i...

2016-05-11 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/12935#issuecomment-218675018 Thanks. Merging to master and branch 2.0. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-15094][SPARK-14803][SQL] Remove extra P...

2016-05-11 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/12926#discussion_r62972085 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala --- @@ -659,6 +659,16 @@ class DatasetSuite extends QueryTest with SharedSQLCont

[GitHub] spark pull request: [SPARK-15094][SPARK-14803][SQL] Remove extra P...

2016-05-11 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/12926#discussion_r62971980 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala --- @@ -659,6 +659,16 @@ class DatasetSuite extends QueryTest with SharedSQLCont

[GitHub] spark pull request: [SPARK-14613][ML] Add @Since into the matrix a...

2016-05-11 Thread pravingadakh
Github user pravingadakh commented on the pull request: https://github.com/apache/spark/pull/12416#issuecomment-218674561 @srowen Yes, please go ahead. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proje

[GitHub] spark pull request: [SPARK-15094][SPARK-14803][SQL] Remove extra P...

2016-05-11 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/12926#discussion_r62971803 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -156,22 +157,60 @@ object SamplePushDown extends Rule

[GitHub] spark pull request: [SPARK-15094][SPARK-14803][SQL] Remove extra P...

2016-05-11 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/12926#discussion_r62971440 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -156,22 +157,60 @@ object SamplePushDown extends Rule

[GitHub] spark pull request: [SPARK-14978][PySpark] PySpark TrainValidation...

2016-05-11 Thread MLnick
Github user MLnick commented on a diff in the pull request: https://github.com/apache/spark/pull/12767#discussion_r62971439 --- Diff: python/pyspark/ml/tests.py --- @@ -590,10 +590,14 @@ def test_fit_minimize_metric(self): tvsModel = tvs.fit(dataset) bestMo

[GitHub] spark pull request: [SPARK-15192][SQL] null check for SparkSession...

2016-05-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13008#issuecomment-218672986 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-15171][SQL]Deprecate registerTempTable ...

2016-05-11 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/12945#issuecomment-218673040 The PR description is inconsistent with changes made in the PR now. Please update. --- If your project is set up for it, you can reply to this email and have your re

[GitHub] spark pull request: [SPARK-15192][SQL] null check for SparkSession...

2016-05-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13008#issuecomment-218672864 **[Test build #58451 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58451/consoleFull)** for PR 13008 at commit [`0915a71`](https://g

[GitHub] spark pull request: [SPARK-15192][SQL] null check for SparkSession...

2016-05-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13008#issuecomment-218672983 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-15288] [Mesos] Mesos dispatcher should ...

2016-05-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13072#issuecomment-218672432 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your p

[GitHub] spark pull request: [SPARK-14615][ML] Use the new ML Vector and Ma...

2016-05-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12627#issuecomment-218672415 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14615][ML] Use the new ML Vector and Ma...

2016-05-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12627#issuecomment-218672417 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-14615][ML] Use the new ML Vector and Ma...

2016-05-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12627#issuecomment-218672316 **[Test build #58448 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58448/consoleFull)** for PR 12627 at commit [`1b04840`](https://g

[GitHub] spark pull request: [SPARK-14978][PySpark] PySpark TrainValidation...

2016-05-11 Thread MLnick
Github user MLnick commented on a diff in the pull request: https://github.com/apache/spark/pull/12767#discussion_r62970587 --- Diff: python/pyspark/ml/tests.py --- @@ -645,6 +651,37 @@ def test_save_load(self): self.assertEqual(loadedLrModel.intercept, lrModel.intercep

[GitHub] spark pull request: [SPARK-15168][PySpark][ML] Add missing params ...

2016-05-11 Thread MLnick
Github user MLnick commented on a diff in the pull request: https://github.com/apache/spark/pull/12943#discussion_r62970487 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/MultilayerPerceptronClassifier.scala --- @@ -75,8 +75,8 @@ private[ml] trait MultilayerPerc

[GitHub] spark pull request: [SPARK-10530] [CORE] Kill other task attempts ...

2016-05-11 Thread devaraj-kavali
Github user devaraj-kavali commented on the pull request: https://github.com/apache/spark/pull/11996#issuecomment-218671842 @kayousterhout, @markhamstra any comments plz? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: [SPARK-15288] [Mesos] Mesos dispatcher should ...

2016-05-11 Thread devaraj-kavali
GitHub user devaraj-kavali opened a pull request: https://github.com/apache/spark/pull/13072 [SPARK-15288] [Mesos] Mesos dispatcher should handle gracefully when any thread gets UncaughtException ## What changes were proposed in this pull request? Adding the default Uncaugh

[GitHub] spark pull request: [SPARK-15168][PySpark][ML] Add missing params ...

2016-05-11 Thread MLnick
Github user MLnick commented on a diff in the pull request: https://github.com/apache/spark/pull/12943#discussion_r62970263 --- Diff: python/pyspark/ml/classification.py --- @@ -1117,6 +1137,56 @@ def getBlockSize(self): """ return self.getOrDefault(self.bl

[GitHub] spark pull request: [SPARK-14615][ML] Use the new ML Vector and Ma...

2016-05-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12627#issuecomment-218671105 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-14615][ML] Use the new ML Vector and Ma...

2016-05-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12627#issuecomment-218671001 **[Test build #58445 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58445/consoleFull)** for PR 12627 at commit [`1b04840`](https://g

[GitHub] spark pull request: [SPARK-14615][ML] Use the new ML Vector and Ma...

2016-05-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12627#issuecomment-218671106 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-15214][SQL] Code-generation for Generat...

2016-05-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13065#issuecomment-218671053 **[Test build #58454 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58454/consoleFull)** for PR 13065 at commit [`5d068b5`](https://gi

[GitHub] spark pull request: [SPARK-15094][SQL] Avoid extra Project when De...

2016-05-11 Thread viirya
Github user viirya closed the pull request at: https://github.com/apache/spark/pull/12898 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request: [SPARK-15094][SPARK-14803][SQL] Remove extra P...

2016-05-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12926#issuecomment-218670776 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-15094][SPARK-14803][SQL] Remove extra P...

2016-05-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12926#issuecomment-218670777 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-15192][SQL] null check for SparkSession...

2016-05-11 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/13008#issuecomment-218670622 Oh actually we did document it in the java doc of `Row`, and says users should use `Seq` for array type. see https://github.com/apache/spark/blob/master/sql/catalyst/

[GitHub] spark pull request: [SPARK-15094][SPARK-14803][SQL] Remove extra P...

2016-05-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12926#issuecomment-218670633 **[Test build #58447 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58447/consoleFull)** for PR 12926 at commit [`c3748ba`](https://g

[GitHub] spark pull request: [SPARK-15279][SQL] Catch conflicting SerDe whe...

2016-05-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13068#issuecomment-218670419 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-15279][SQL] Catch conflicting SerDe whe...

2016-05-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13068#issuecomment-218670421 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-15279][SQL] Catch conflicting SerDe whe...

2016-05-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13068#issuecomment-218670295 **[Test build #58444 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58444/consoleFull)** for PR 13068 at commit [`7e02a0a`](https://g

[GitHub] spark pull request: [SPARK-15192][SQL] null check for SparkSession...

2016-05-11 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/13008#issuecomment-218670057 looks like we haven't documented what kind of field object types is allowed in a `Row`, let me find a place to document it. --- If your project is set up for it, you

[GitHub] spark pull request: [SPARK-15281][PySpark][ML][TRIVIAL] Add impuri...

2016-05-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13071#issuecomment-218669750 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-15281][PySpark][ML][TRIVIAL] Add impuri...

2016-05-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13071#issuecomment-218669753 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-15281][PySpark][ML][TRIVIAL] Add impuri...

2016-05-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13071#issuecomment-218669684 **[Test build #58453 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58453/consoleFull)** for PR 13071 at commit [`274400d`](https://g

[GitHub] spark pull request: [SPARK-15171][SQL]Deprecate registerTempTable ...

2016-05-11 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/12945#discussion_r62969319 --- Diff: python/pyspark/sql/session.py --- @@ -255,6 +255,19 @@ def range(self, start, end=None, step=1, numPartitions=None): return Da

[GitHub] spark pull request: [SPARK-15160][SQL] support data source table i...

2016-05-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12935#issuecomment-218669520 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-15160][SQL] support data source table i...

2016-05-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12935#issuecomment-218669521 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-15160][SQL] support data source table i...

2016-05-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12935#issuecomment-218669394 **[Test build #58443 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58443/consoleFull)** for PR 12935 at commit [`ef6399a`](https://g

[GitHub] spark pull request: [SPARK-15171][SQL]Deprecate registerTempTable ...

2016-05-11 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/12945#discussion_r62969204 --- Diff: python/pyspark/sql/context.py --- @@ -302,7 +302,7 @@ def registerDataFrameAsTable(self, df, tableName): >>> sqlContext.registe

[GitHub] spark pull request: [SPARK-15192][SQL] null check for SparkSession...

2016-05-11 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/13008#issuecomment-218669218 I see. Seems like a API change that at least we need to document. Is there any performance implication? also cc @mengxr --- If your project is set up

[GitHub] spark pull request: [SPARK-15192][SQL] null check for SparkSession...

2016-05-11 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/13008#issuecomment-218668967 Unlike `CatalystConverter`, `RowEncoder` is stricter about the input external type, e.g. users must use `Seq` for `ArrayType`, but `CatalystConvert` also allows `Arra

[GitHub] spark pull request: [SPARK-15214][SQL] Code-generation for Generat...

2016-05-11 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/13065#issuecomment-218668485 Looks like a good start. Once you flush this out more, can you print the generated code ("explain codegen ..."), and do some microbenchmarks similar to the ones done in th

[GitHub] spark pull request: [SPARK-15281][PySpark][ML][TRIVIAL] Add impuri...

2016-05-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13071#issuecomment-218668299 **[Test build #58453 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58453/consoleFull)** for PR 13071 at commit [`274400d`](https://gi

[GitHub] spark pull request: [SPARK-15281][PySpark][ML][TRIVIAL] Add impuri...

2016-05-11 Thread holdenk
GitHub user holdenk opened a pull request: https://github.com/apache/spark/pull/13071 [SPARK-15281][PySpark][ML][TRIVIAL] Add impurity param to GBTRegressor ## What changes were proposed in this pull request? Add impurity param to GBTRegressor and mark the of the models &

[GitHub] spark pull request: [SPARK-14897] [SQL] upgrade to jetty 9.2.16

2016-05-11 Thread bomeng
Github user bomeng commented on the pull request: https://github.com/apache/spark/pull/12916#issuecomment-218668164 @srowen sorry for the late reply, I did not notice it. I have run the mvn dependency:tree and only javax.servlet-api 3.1.0 is listed, so it should be fine. --- If your

[GitHub] spark pull request: [SPARK-14897] [SQL] upgrade to jetty 9.2.16

2016-05-11 Thread bomeng
Github user bomeng commented on a diff in the pull request: https://github.com/apache/spark/pull/12916#discussion_r62968602 --- Diff: core/pom.xml --- @@ -125,12 +125,17 @@ jetty-servlet compile + + org.eclipse.jetty + jetty-

[GitHub] spark pull request: [SPARK-15114][SQL] Column name generated by ty...

2016-05-11 Thread dilipbiswal
Github user dilipbiswal commented on a diff in the pull request: https://github.com/apache/spark/pull/13045#discussion_r62968394 --- Diff: python/pyspark/sql/dataframe.py --- @@ -861,11 +861,11 @@ def groupBy(self, *cols): Each element should be a column name (strin

[GitHub] spark pull request: [SPARK-15168][PySpark][ML] Add missing params ...

2016-05-11 Thread holdenk
Github user holdenk commented on a diff in the pull request: https://github.com/apache/spark/pull/12943#discussion_r62968274 --- Diff: python/pyspark/ml/classification.py --- @@ -1117,6 +1137,56 @@ def getBlockSize(self): """ return self.getOrDefault(self.b

[GitHub] spark pull request: [SPARK-15286] [SQL] Make the output readable f...

2016-05-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13070#issuecomment-218666897 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-15286] [SQL] Make the output readable f...

2016-05-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13070#issuecomment-218666896 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-15286] [SQL] Make the output readable f...

2016-05-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13070#issuecomment-218666803 **[Test build #58442 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58442/consoleFull)** for PR 13070 at commit [`5f83dbd`](https://g

[GitHub] spark pull request: [SPARK-15031][SPARK-15134][EXAMPLE][DOC] Use S...

2016-05-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/13050 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request: [SPARK-15192][SQL] null check for SparkSession...

2016-05-11 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/13008#issuecomment-218665830 what is the cause of those failed tests? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project d

[GitHub] spark pull request: [SPARK-15031][SPARK-15134][EXAMPLE][DOC] Use S...

2016-05-11 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/13050#issuecomment-218665542 Merging into master 2.0. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not hav

[GitHub] spark pull request: [SPARK-15192][SQL] null check for SparkSession...

2016-05-11 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/13008#issuecomment-21866 yea, the new commit should fixed it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project d

[GitHub] spark pull request: [SPARK-15192][SQL] null check for SparkSession...

2016-05-11 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/13008#issuecomment-218665223 legitimate issue? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

[GitHub] spark pull request: [SPARK-15114][SQL] Column name generated by ty...

2016-05-11 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/13045#discussion_r62967194 --- Diff: python/pyspark/sql/dataframe.py --- @@ -861,11 +861,11 @@ def groupBy(self, *cols): Each element should be a column name (string)

[GitHub] spark pull request: [SPARK-14894][PySpark] Add result summary api ...

2016-05-11 Thread GayathriMurali
Github user GayathriMurali commented on the pull request: https://github.com/apache/spark/pull/12675#issuecomment-218664815 @holdenk I checked the ScalaDoc and removed the evaluate method. Thanks for pointing it out. Can you please help review --- If your project is set up for it, y

[GitHub] spark pull request: [SPARK-15192][SQL] null check for SparkSession...

2016-05-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13008#issuecomment-218664669 **[Test build #58450 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58450/consoleFull)** for PR 13008 at commit [`7419a52`](https://g

[GitHub] spark pull request: [SPARK-15192][SQL] null check for SparkSession...

2016-05-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13008#issuecomment-218664688 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-15192][SQL] null check for SparkSession...

2016-05-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13008#issuecomment-218664687 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-15114][SQL] Column name generated by ty...

2016-05-11 Thread dilipbiswal
Github user dilipbiswal commented on a diff in the pull request: https://github.com/apache/spark/pull/13045#discussion_r62966720 --- Diff: python/pyspark/sql/dataframe.py --- @@ -861,11 +861,11 @@ def groupBy(self, *cols): Each element should be a column name (strin

[GitHub] spark pull request: [SPARK-13902][SCHEDULER] Make DAGScheduler not...

2016-05-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12655#issuecomment-218663500 **[Test build #58452 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58452/consoleFull)** for PR 12655 at commit [`3ceb4d5`](https://gi

[GitHub] spark pull request: [SPARK-13902][SCHEDULER] Make DAGScheduler not...

2016-05-11 Thread ueshin
Github user ueshin commented on the pull request: https://github.com/apache/spark/pull/12655#issuecomment-218663123 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not hav

[GitHub] spark pull request: [SPARK-15168][PySpark][ML] Add missing params ...

2016-05-11 Thread MLnick
Github user MLnick commented on a diff in the pull request: https://github.com/apache/spark/pull/12943#discussion_r62966384 --- Diff: python/pyspark/ml/classification.py --- @@ -1117,6 +1137,56 @@ def getBlockSize(self): """ return self.getOrDefault(self.bl

[GitHub] spark pull request: [SPARK-15114][SQL] Column name generated by ty...

2016-05-11 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/13045#discussion_r62966223 --- Diff: python/pyspark/sql/dataframe.py --- @@ -861,11 +861,11 @@ def groupBy(self, *cols): Each element should be a column name (string)

[GitHub] spark pull request: [SPARK-15114][SQL] Column name generated by ty...

2016-05-11 Thread dilipbiswal
Github user dilipbiswal commented on the pull request: https://github.com/apache/spark/pull/13045#issuecomment-218662623 @yhuai @cloud-fan Sure. I will change it only for typed aggregation. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request: [SPARK-15192][SQL] null check for SparkSession...

2016-05-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13008#issuecomment-218662389 **[Test build #58451 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58451/consoleFull)** for PR 13008 at commit [`0915a71`](https://gi

[GitHub] spark pull request: [SPARK-15286] [SQL] Make the output readable f...

2016-05-11 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/13070#issuecomment-218662174 Sure, will do. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] spark pull request: [SPARK-15286] [SQL] Make the output readable f...

2016-05-11 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/13070#issuecomment-218661961 Other examples include: 1. Just say "created", and not "created time". same thing with "last access" vs "last access time". 2. schema string can probably be a

[GitHub] spark pull request: [SPARK-15114][SQL] Column name generated by ty...

2016-05-11 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/13045#issuecomment-218661443 How about we just improve the column name of fields generated by typed aggregation. Seems we are also changing other cases? --- If your project is set up for it, you can

[GitHub] spark pull request: [SPARK-15286] [SQL] Make the output readable f...

2016-05-11 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/13070#issuecomment-218661395 True. We can exclude all the variables with undefined values. It could be much shorter. : ) --- If your project is set up for it, you can reply to this email and ha

[GitHub] spark pull request: [SPARK-15192][SQL] null check for SparkSession...

2016-05-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13008#issuecomment-218661393 **[Test build #58450 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58450/consoleFull)** for PR 13008 at commit [`7419a52`](https://gi

[GitHub] spark pull request: [SPARK-15031][SPARK-15134][EXAMPLE][DOC] Use S...

2016-05-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13050#issuecomment-218661259 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-15031][SPARK-15134][EXAMPLE][DOC] Use S...

2016-05-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13050#issuecomment-218661260 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-15031][SPARK-15134][EXAMPLE][DOC] Use S...

2016-05-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13050#issuecomment-218661211 **[Test build #58446 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58446/consoleFull)** for PR 13050 at commit [`f8d51b9`](https://g

[GitHub] spark pull request: [SPARK-15192][SQL] null check for SparkSession...

2016-05-11 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/13008#issuecomment-218661098 test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featur

[GitHub] spark pull request: [SPARK-15192][SQL] null check for SparkSession...

2016-05-11 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/13008#issuecomment-218661110 LGTM pending jenkins --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] spark pull request: [SPARK-15192][SQL] null check for SparkSession...

2016-05-11 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/13008#discussion_r62965499 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala --- @@ -505,7 +505,7 @@ class DatasetSuite extends QueryTest with SharedSQLContext {

[GitHub] spark pull request: [SPARK-15286] [SQL] Make the output readable f...

2016-05-11 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/13070#issuecomment-218660960 This seems way too verbose for end users. Can't we make something more readable in the plan? --- If your project is set up for it, you can reply to this email and have y

[GitHub] spark pull request: [SPARK-15171][SQL]Deprecate registerTempTable ...

2016-05-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12945#issuecomment-218660928 **[Test build #58449 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58449/consoleFull)** for PR 12945 at commit [`a9bdd5b`](https://gi

[GitHub] spark pull request: [SPARK-15114][SQL] Column name generated by ty...

2016-05-11 Thread dilipbiswal
Github user dilipbiswal commented on a diff in the pull request: https://github.com/apache/spark/pull/13045#discussion_r62965291 --- Diff: python/pyspark/sql/dataframe.py --- @@ -861,11 +861,11 @@ def groupBy(self, *cols): Each element should be a column name (strin

[GitHub] spark pull request: [SPARK-14615][ML] Use the new ML Vector and Ma...

2016-05-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12627#issuecomment-218660437 **[Test build #58448 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58448/consoleFull)** for PR 12627 at commit [`1b04840`](https://gi

[GitHub] spark pull request: [SPARK-15094][SPARK-14803][SQL] Remove extra P...

2016-05-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12926#issuecomment-218660446 **[Test build #58447 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58447/consoleFull)** for PR 12926 at commit [`c3748ba`](https://gi

[GitHub] spark pull request: [SPARK-15031][SPARK-15134][EXAMPLE][DOC] Use S...

2016-05-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13050#issuecomment-218660436 **[Test build #58446 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58446/consoleFull)** for PR 13050 at commit [`f8d51b9`](https://gi

[GitHub] spark pull request: [SPARK-15094][SPARK-14803][SQL] Remove extra P...

2016-05-11 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/12926#issuecomment-218660355 test this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this f

[GitHub] spark pull request: [SPARK-13902][SCHEDULER] Make DAGScheduler not...

2016-05-11 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/12655#issuecomment-218660336 Sorry there was a build break in master. retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request: [SPARK-14857] [SQL] Table/Database Name Valida...

2016-05-11 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/12618#issuecomment-218660290 @hvanhovell Could you check if the latest changes resolve all your comments? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: [SPARK-15192][SQL] null check for SparkSession...

2016-05-11 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/13008#discussion_r62965137 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala --- @@ -505,7 +505,7 @@ class DatasetSuite extends QueryTest with SharedSQLConte

[GitHub] spark pull request: [SPARK-15031][SPARK-15134][EXAMPLE][DOC] Use S...

2016-05-11 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/13050#issuecomment-218660156 LGTM, but let's retest this please just in case. There have been a lot of build breaks related to changes like these lately. --- If your project is set up for it, y

[GitHub] spark pull request: [SPARK-14684] [SPARK-15277] [SQL] Partition Sp...

2016-05-11 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/12801#issuecomment-218660173 @andrewor14 @cloud-fan @yhuai This is ready for review. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHu

[GitHub] spark pull request: [SPARK-15072][SQL][PYSPARK][HOT-FIX] Remove Sp...

2016-05-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13069#issuecomment-218660020 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-15072][SQL][PYSPARK][HOT-FIX] Remove Sp...

2016-05-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13069#issuecomment-218659977 **[Test build #58441 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58441/consoleFull)** for PR 13069 at commit [`f0a1fd1`](https://g

  1   2   3   4   5   6   7   8   9   10   >