[GitHub] spark pull request: [SPARK-15312] [SQL] Detect Duplicate Key in Pa...

2016-05-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/13095 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request: [SPARK-15312] [SQL] Detect Duplicate Key in Pa...

2016-05-21 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/13095#issuecomment-220817564 thanks, merging to master and 2.0! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project doe

[GitHub] spark pull request: [SPARK-15459][SQL] Make Range logical and phys...

2016-05-21 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/13239#discussion_r64145088 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala --- @@ -420,8 +420,11 @@ case class Range(

[GitHub] spark pull request: [SPARK-15459][SQL] Make Range logical and phys...

2016-05-21 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/13239#issuecomment-220817493 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enable

[GitHub] spark pull request: [SPARK-15459][SQL] Make Range logical and phys...

2016-05-21 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/13239#discussion_r64145080 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala --- @@ -359,8 +359,8 @@ private[sql] abstract class SparkStrategies

[GitHub] spark pull request: [SPARK-15459][SQL] Make Range logical and phys...

2016-05-21 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/13239#discussion_r64145075 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala --- @@ -420,8 +420,11 @@ case class Range(

[GitHub] spark pull request: [SPARK-15471][SQL] ScalaReflection cleanup

2016-05-21 Thread cloud-fan
GitHub user cloud-fan opened a pull request: https://github.com/apache/spark/pull/13250 [SPARK-15471][SQL] ScalaReflection cleanup ## What changes were proposed in this pull request? 1. simplify the logic of deserializing option type. 2. simplify the logic of serializing

[GitHub] spark pull request: [SPARK-15471][SQL] ScalaReflection cleanup

2016-05-21 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/13250#issuecomment-220817334 cc @marmbrus @liancheng @yhuai --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does n

[GitHub] spark pull request: [SPARK-15464][ML][MLlib][SQL][Tests] Replace S...

2016-05-21 Thread techaddict
Github user techaddict commented on a diff in the pull request: https://github.com/apache/spark/pull/13242#discussion_r64144856 --- Diff: python/pyspark/ml/clustering.py --- @@ -933,21 +933,20 @@ def getKeepLastCheckpoint(self): if __name__ == "__main__": import doctes

[GitHub] spark pull request: [SPARK-15470] [SQL] Unify the Configuration In...

2016-05-21 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/13247#issuecomment-220816722 I see. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] spark pull request: [SPARK-10903] [SPARKR] R - Simplify SQLContext...

2016-05-21 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/9192#issuecomment-220816684 I think maintaining backward compatibility would be useful. Do you have time to bring this up to date this week so we get it in for 2.0? It's pretty late for a change of th

[GitHub] spark pull request: [MINOR] More than 100 chars in line.

2016-05-21 Thread techaddict
GitHub user techaddict opened a pull request: https://github.com/apache/spark/pull/13249 [MINOR] More than 100 chars in line. ## What changes were proposed in this pull request? More than 100 chars in line. ## How was this patch tested? You can merge this pull request

[GitHub] spark pull request: [SPARK-15312] [SQL] Detect Duplicate Key in Pa...

2016-05-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13095#issuecomment-220816499 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-15312] [SQL] Detect Duplicate Key in Pa...

2016-05-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13095#issuecomment-220816498 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-15470] [SQL] Unify the Configuration In...

2016-05-21 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/13247#issuecomment-220816493 In this case I guess it is ok though. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-15470] [SQL] Unify the Configuration In...

2016-05-21 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/13247#issuecomment-220816467 I'd like to avoid contaminating RuntimeConfig with private[sql] methods if possible. Those visibility modifiers have no effect in Java. --- If your project is set up for

[GitHub] spark pull request: [SPARK-15312] [SQL] Detect Duplicate Key in Pa...

2016-05-21 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13095#issuecomment-220816465 **[Test build #59089 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59089/consoleFull)** for PR 13095 at commit [`d7c2420`](https://g

[GitHub] spark pull request: [SPARK-15396] [SQL] [DOC] It can't connect hiv...

2016-05-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/13225 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request: [SPARK-15470] [SQL] Unify the Configuration In...

2016-05-21 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/13247#issuecomment-220816386 You are right. Let me add `protected[sql]` before `def set[T](entry: ConfigEntry[T], value: T): Unit` https://github.com/gatorsmile/spark/blob/d972e8d8832c5a04d

[GitHub] spark pull request: [SPARK-15396] [SQL] [DOC] It can't connect hiv...

2016-05-21 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/13225#issuecomment-220816364 LGTM - merging in master/2.0. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-15425][SQL] Disallow cross joins by def...

2016-05-21 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/13209#issuecomment-220816332 LGTM (although you have a few test cases you need to fix). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] spark pull request: [SPARK-15425][SQL] Disallow cross joins by def...

2016-05-21 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/13209#discussion_r64144707 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastNestedLoopJoinExec.scala --- @@ -337,6 +341,15 @@ case class BroadcastNestedLoo

[GitHub] spark pull request: [SPARK-15470] [SQL] Unify the Configuration In...

2016-05-21 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/13247#issuecomment-220816173 I don't get it. ConfigEntry is internal to Spark. Why are we exposing that? --- If your project is set up for it, you can reply to this email and have your reply appear o

[GitHub] spark pull request: [SPARK-15415][SQL] Fix BroadcastHint when auto...

2016-05-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/13244 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request: [SPARK-15459][SQL] Make Range logical and phys...

2016-05-21 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/13239#issuecomment-220816092 cc @cloud-fan --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark pull request: [SPARK-15415][SQL] Fix BroadcastHint when auto...

2016-05-21 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/13244#issuecomment-220816049 This looks good. There are couple minor issues. I will resolve those when I merge. Merging in master/2.0. --- If your project is set up for it, you can reply t

[GitHub] spark pull request: [SPARK-15415][SQL] Fix BroadcastHint when auto...

2016-05-21 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/13244#discussion_r64144657 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/joins/BroadcastJoinSuite.scala --- @@ -56,30 +61,100 @@ class BroadcastJoinSuite extends Query

[GitHub] spark pull request: [SPARK-15415][SQL] Fix BroadcastHint when auto...

2016-05-21 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/13244#discussion_r64144623 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/Statistics.scala --- @@ -32,4 +32,4 @@ package org.apache.spark.sql.catalyst.

[GitHub] spark pull request: [SPARK-15470] [SQL] Unify the Configuration In...

2016-05-21 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/13247#issuecomment-220815712 @cloud-fan Based on my understanding, runtime conf (`class RuntimeConfig`) is designed as the public/external interface for users to access the internal conf. If use

[GitHub] spark pull request: [SPARK-15194] [ML] Add Python ML API for Multi...

2016-05-21 Thread praveendareddy21
GitHub user praveendareddy21 opened a pull request: https://github.com/apache/spark/pull/13248 [SPARK-15194] [ML] Add Python ML API for MultivariateGaussian ## What changes were proposed in this pull request? Added MultivariateGaussian in pyspark ML to match scala's ML API

[GitHub] spark pull request: [SPARK-15194] [ML] Add Python ML API for Multi...

2016-05-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13248#issuecomment-220815663 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your p

[GitHub] spark pull request: [SPARK-15285][SQL] Generated SpecificSafeProje...

2016-05-21 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/13243#issuecomment-220815424 The fallback approach doesn't look that simple and clean, can you try split the generated code like we did in `CreateExternalRow`? --- If your project is set up for

[GitHub] spark pull request: [SPARK-15470] [SQL] Unify the Configuration In...

2016-05-21 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/13247#issuecomment-220815210 What's the difference between runtime conf and normal conf? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: [SPARK-15466][SQL] Make `SparkSession` as the ...

2016-05-21 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/13245#issuecomment-220814644 Unfortunately, `Dataset` (or `Dataframe`) seems not suitable to achieve the goal on Python. ```python >>> spark.parallelize(range(1, 10)).toDS() ...

[GitHub] spark pull request: [SPARK-15470] [SQL] Unify the Configuration In...

2016-05-21 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13247#issuecomment-220814526 **[Test build #59090 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59090/consoleFull)** for PR 13247 at commit [`f443064`](https://g

[GitHub] spark pull request: [SPARK-15470] [SQL] Unify the Configuration In...

2016-05-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13247#issuecomment-220814528 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-15470] [SQL] Unify the Configuration In...

2016-05-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13247#issuecomment-220814527 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-15396] [SQL] [DOC] It can't connect hiv...

2016-05-21 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/13225#issuecomment-220814492 @rxin @jameszhouyi Do you think the document changes in this PR are clear? Please let me know if anything is missing or inappropriate. Thanks! Also CC all th

[GitHub] spark pull request: [SPARK-15470] [SQL] Unify the Configuration In...

2016-05-21 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13247#issuecomment-220814370 **[Test build #59090 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59090/consoleFull)** for PR 13247 at commit [`f443064`](https://gi

[GitHub] spark pull request: [SPARK-15312] [SQL] Detect Duplicate Key in Pa...

2016-05-21 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/13095#issuecomment-220814326 Thank you, @cloud-fan ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-15470] [SQL] Unify the Configuration In...

2016-05-21 Thread gatorsmile
GitHub user gatorsmile opened a pull request: https://github.com/apache/spark/pull/13247 [SPARK-15470] [SQL] Unify the Configuration Interface in SQLContext What changes were proposed in this pull request? We introduced `RuntimeConfig` in `SQLContext` in the PR https://gith

[GitHub] spark pull request: [SPARK-15206][SQL] add testcases for distinct ...

2016-05-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/12984 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request: [SPARK-15312] [SQL] Detect Duplicate Key in Pa...

2016-05-21 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13095#issuecomment-220814047 **[Test build #59089 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59089/consoleFull)** for PR 13095 at commit [`d7c2420`](https://gi

[GitHub] spark pull request: [SPARK-15434][SQL] improve EmbedSerializerInFi...

2016-05-21 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13216#issuecomment-220814048 **[Test build #59088 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59088/consoleFull)** for PR 13216 at commit [`d677105`](https://gi

[GitHub] spark pull request: [SPARK-15206][SQL] add testcases for distinct ...

2016-05-21 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/12984#issuecomment-220814026 thanks, merging to master and 2.0! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project doe

[GitHub] spark pull request: [SPARK-15415][SQL] Fix BroadcastHint when auto...

2016-05-21 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13244#issuecomment-220813993 **[Test build #3009 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3009/consoleFull)** for PR 13244 at commit [`8b9bf51`](https://

[GitHub] spark pull request: [SPARK-15379][SQL] check special invalid date

2016-05-21 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/13169#discussion_r64143999 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/DateTimeUtilsSuite.scala --- @@ -353,6 +353,20 @@ class DateTimeUtilsSuite extend

[GitHub] spark pull request: [SPARK-15312] [SQL] Detect Duplicate Key in Pa...

2016-05-21 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/13095#issuecomment-220813962 LGTM, pending jenkins --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have th

[GitHub] spark pull request: [SPARK-15312] [SQL] Detect Duplicate Key in Pa...

2016-05-21 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/13095#issuecomment-220813959 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-15428][SQL] Disable multiple streaming ...

2016-05-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13210#issuecomment-220813852 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-15428][SQL] Disable multiple streaming ...

2016-05-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13210#issuecomment-220813851 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-15428][SQL] Disable multiple streaming ...

2016-05-21 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13210#issuecomment-220813817 **[Test build #59087 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59087/consoleFull)** for PR 13210 at commit [`abc12a5`](https://g

[GitHub] spark pull request: [SPARK-15466][SQL] Make `SparkSession` as the ...

2016-05-21 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/13245#issuecomment-220813421 I see. Thank you! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have th

[GitHub] spark pull request: [SPARK-15464][ML][MLlib][SQL][Tests] Replace S...

2016-05-21 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/13242#issuecomment-220812010 cc @andrewor14 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-15415][SQL] Fix BroadcastHint when auto...

2016-05-21 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13244#issuecomment-220811992 **[Test build #3009 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3009/consoleFull)** for PR 13244 at commit [`8b9bf51`](https://g

[GitHub] spark pull request: [SPARK-15415][SQL] Fix BroadcastHint when auto...

2016-05-21 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/13244#issuecomment-220811981 Looks good at high level. Will take a closer look later! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. I

[GitHub] spark pull request: [SPARK-15466][SQL] Make `SparkSession` as the ...

2016-05-21 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/13245#issuecomment-220811972 hm we are trying to avoid returning rdds in the new apis. one thing we can do is to introduce a parallelize api that returns dataset? --- If your project is set up for i

[GitHub] spark pull request: [SPARK-15330] [SQL] Implement Reset Command

2016-05-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/13121 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request: [SPARK-15428][SQL] Disable multiple streaming ...

2016-05-21 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13210#issuecomment-220811819 **[Test build #59087 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59087/consoleFull)** for PR 13210 at commit [`abc12a5`](https://gi

[GitHub] spark pull request: [SPARK-15330] [SQL] Implement Reset Command

2016-05-21 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/13121#issuecomment-220811816 Merging in master/2.0. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[GitHub] spark pull request: [SPARK-15468] [SQL] some some typos

2016-05-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13246#issuecomment-220810589 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-15468] [SQL] some some typos

2016-05-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13246#issuecomment-220810588 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-15468] [SQL] some some typos

2016-05-21 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13246#issuecomment-220810568 **[Test build #59086 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59086/consoleFull)** for PR 13246 at commit [`3a57975`](https://g

[GitHub] spark pull request: [SPARK-11696] [ML, MLlib] Optimization: Extend...

2016-05-21 Thread NarineK
Github user NarineK closed the pull request at: https://github.com/apache/spark/pull/9667 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request: [SPARK-15466][SQL] Make `SparkSession` as the ...

2016-05-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13245#issuecomment-220809759 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-15466][SQL] Make `SparkSession` as the ...

2016-05-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13245#issuecomment-220809758 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-15466][SQL] Make `SparkSession` as the ...

2016-05-21 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13245#issuecomment-220809739 **[Test build #59082 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59082/consoleFull)** for PR 13245 at commit [`65f9746`](https://g

[GitHub] spark pull request: [SPARK-15466][SQL] Make `SparkSession` as the ...

2016-05-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13245#issuecomment-220809417 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-15466][SQL] Make `SparkSession` as the ...

2016-05-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13245#issuecomment-220809418 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-15466][SQL] Make `SparkSession` as the ...

2016-05-21 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13245#issuecomment-220809398 **[Test build #59085 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59085/consoleFull)** for PR 13245 at commit [`4f6a69e`](https://g

[GitHub] spark pull request: [SPARK-15468] [SQL] some some typos

2016-05-21 Thread bomeng
Github user bomeng commented on a diff in the pull request: https://github.com/apache/spark/pull/13246#discussion_r64142270 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/planning/patterns.scala --- @@ -227,8 +227,8 @@ object IntegerIndex { * - Unnamed

[GitHub] spark pull request: [SPARK-15468] [SQL] some some typos

2016-05-21 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13246#issuecomment-220807733 **[Test build #59086 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59086/consoleFull)** for PR 13246 at commit [`3a57975`](https://gi

[GitHub] spark pull request: [SPARK-15468] [SQL] some some typos

2016-05-21 Thread bomeng
GitHub user bomeng opened a pull request: https://github.com/apache/spark/pull/13246 [SPARK-15468] [SQL] some some typos ## What changes were proposed in this pull request? Fix some typos while browsing the codes. ## How was this patch tested? None and obvi

[GitHub] spark pull request: [SPARK-15434][SQL] improve EmbedSerializerInFi...

2016-05-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13216#issuecomment-220807530 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-15434][SQL] improve EmbedSerializerInFi...

2016-05-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13216#issuecomment-220807531 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-15434][SQL] improve EmbedSerializerInFi...

2016-05-21 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13216#issuecomment-220807510 **[Test build #59084 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59084/consoleFull)** for PR 13216 at commit [`c29acae`](https://g

[GitHub] spark pull request: [SPARK-15430][SQL] Fix potential ConcurrentMod...

2016-05-21 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/13211#discussion_r64142098 --- Diff: core/src/main/scala/org/apache/spark/util/AccumulatorV2.scala --- @@ -437,7 +438,9 @@ class ListAccumulator[T] extends AccumulatorV2[T, java.util.Li

[GitHub] spark pull request: [SPARK-15330] [SQL] Implement Reset Command

2016-05-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13121#issuecomment-220806369 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-15466][SQL] Make `SparkSession` as the ...

2016-05-21 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13245#issuecomment-220806446 **[Test build #59085 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59085/consoleFull)** for PR 13245 at commit [`4f6a69e`](https://gi

[GitHub] spark pull request: [SPARK-15330] [SQL] Implement Reset Command

2016-05-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13121#issuecomment-220806368 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-15330] [SQL] Implement Reset Command

2016-05-21 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13121#issuecomment-220806334 **[Test build #59083 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59083/consoleFull)** for PR 13121 at commit [`5b759da`](https://g

[GitHub] spark pull request: [SPARK-15466][SQL] Make `SparkSession` as the ...

2016-05-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13245#issuecomment-220805756 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-15466][SQL] Make `SparkSession` as the ...

2016-05-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13245#issuecomment-220805754 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-15466][SQL] Make `SparkSession` as the ...

2016-05-21 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13245#issuecomment-220805723 **[Test build #59081 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59081/consoleFull)** for PR 13245 at commit [`810f08a`](https://g

[GitHub] spark pull request: [SPARK-15434][SQL] improve EmbedSerializerInFi...

2016-05-21 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13216#issuecomment-220805471 **[Test build #59084 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59084/consoleFull)** for PR 13216 at commit [`c29acae`](https://gi

[GitHub] spark pull request: [SPARK-15280] [Input/Output] Refactored OrcOut...

2016-05-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/13066 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request: [SPARK-15280] [Input/Output] Refactored OrcOut...

2016-05-21 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/13066#issuecomment-220805144 Merging to master and branch 2.0. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-15330] [SQL] Implement Reset Command

2016-05-21 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/13121#issuecomment-220804464 LGTM pending tests. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fea

[GitHub] spark pull request: [SPARK-14554][SQL] disable whole stage codegen...

2016-05-21 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/12322#discussion_r64141139 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala --- @@ -620,6 +620,12 @@ class DatasetSuite extends QueryTest with SharedSQLCon

[GitHub] spark pull request: [SPARK-15330] [SQL] Implement Reset Command

2016-05-21 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13121#issuecomment-220803288 **[Test build #59083 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59083/consoleFull)** for PR 13121 at commit [`5b759da`](https://gi

[GitHub] spark pull request: [SPARK-15330] [SQL] Implement Reset Command

2016-05-21 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/13121#issuecomment-220803118 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-15466][SQL] Make `SparkSession` as the ...

2016-05-21 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13245#issuecomment-220802722 **[Test build #59082 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59082/consoleFull)** for PR 13245 at commit [`65f9746`](https://gi

[GitHub] spark pull request: [SPARK-15466][SQL] Make `SparkSession` as the ...

2016-05-21 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13245#issuecomment-220801908 **[Test build #59081 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59081/consoleFull)** for PR 13245 at commit [`810f08a`](https://gi

[GitHub] spark pull request: [SPARK-15466][SQL] Make `SparkSession` as the ...

2016-05-21 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/13245#issuecomment-220801877 Hi, @rxin . I'm wondering your opinion about this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark pull request: [SPARK-15466][SQL] Make `SparkSession` as the ...

2016-05-21 Thread dongjoon-hyun
GitHub user dongjoon-hyun opened a pull request: https://github.com/apache/spark/pull/13245 [SPARK-15466][SQL] Make `SparkSession` as the entry point to programming with RDD too ## What changes were proposed in this pull request? `SparkSession` greatly reduces the number of

[GitHub] spark pull request: [SPARK-15330] [SQL] Implement Reset Command

2016-05-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13121#issuecomment-220801790 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-15330] [SQL] Implement Reset Command

2016-05-21 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13121#issuecomment-220801786 **[Test build #59080 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59080/consoleFull)** for PR 13121 at commit [`5b759da`](https://g

[GitHub] spark pull request: [SPARK-15330] [SQL] Implement Reset Command

2016-05-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13121#issuecomment-220801791 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-15330] [SQL] Implement Reset Command

2016-05-21 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13121#issuecomment-220801477 **[Test build #59080 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59080/consoleFull)** for PR 13121 at commit [`5b759da`](https://gi

[GitHub] spark pull request: [SPARK-15330] [SQL] Implement Reset Command

2016-05-21 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/13121#discussion_r64140446 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/internal/SQLConfSuite.scala --- @@ -107,6 +107,53 @@ class SQLConfSuite extends QueryTest with Sha

  1   2   >