GitHub user Sherry302 opened a pull request:
https://github.com/apache/spark/pull/14577
[SPARK-16986][WEB UI] Make 'Started' time, 'Completed' time and 'Lastâ¦
## What changes were proposed in this pull request?
In historypage.js, format 'Started' time, 'Completed' time and 'Las
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14577
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feat
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14472#discussion_r74189204
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala ---
@@ -0,0 +1,214 @@
+/*
+ * Licensed to the Apache Software Founda
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14576
**[Test build #63505 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63505/consoleFull)**
for PR 14576 at commit
[`19b00f5`](https://github.com/apache/spark/commit/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14576
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63505/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14576
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/14577
So this change can be really annoying in debugging, when we try to
correlate time shown on the UI with time in logs.
---
If your project is set up for it, you can reply to this email and have your
re
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/14569
Merging in master/2.0. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wi
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14472#discussion_r74189403
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala ---
@@ -0,0 +1,214 @@
+/*
+ * Licensed to the Apache Software Founda
Github user petermaxlee commented on a diff in the pull request:
https://github.com/apache/spark/pull/14472#discussion_r74189487
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala ---
@@ -0,0 +1,214 @@
+/*
+ * Licensed to the Apache Software Foun
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13886#discussion_r74189648
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/rules.scala
---
@@ -273,6 +273,24 @@ case class PreprocessTableInsertion(conf
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/14569
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user petermaxlee commented on a diff in the pull request:
https://github.com/apache/spark/pull/14472#discussion_r74189661
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala ---
@@ -0,0 +1,214 @@
+/*
+ * Licensed to the Apache Software Foun
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13886#discussion_r74189672
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/rules.scala
---
@@ -273,6 +273,24 @@ case class PreprocessTableInsertion(conf
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13886#discussion_r74189783
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/internal/SessionState.scala ---
@@ -117,7 +117,9 @@ private[sql] class SessionState(sparkSession:
S
Github user petermaxlee commented on a diff in the pull request:
https://github.com/apache/spark/pull/14472#discussion_r74189795
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala ---
@@ -0,0 +1,214 @@
+/*
+ * Licensed to the Apache Software Foun
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14574
**[Test build #63497 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63497/consoleFull)**
for PR 14574 at commit
[`a385a2a`](https://github.com/apache/spark/commit/
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13886#discussion_r74189891
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
---
@@ -1578,6 +1578,34 @@ class DDLSuite extends QueryTest with
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14472
**[Test build #63506 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63506/consoleFull)**
for PR 14472 at commit
[`7497742`](https://github.com/apache/spark/commit/7
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14574
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/13886
Can you update the PR description? I think it should throw exception in
planner before your PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on Git
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13775
**[Test build #63498 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63498/consoleFull)**
for PR 13775 at commit
[`b067658`](https://github.com/apache/spark/commit/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14574
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63497/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13775
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13775
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63498/
Test PASSed.
---
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14472#discussion_r74190305
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala ---
@@ -0,0 +1,212 @@
+/*
+ * Licensed to the Apache Software Founda
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14472#discussion_r74190732
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala ---
@@ -0,0 +1,212 @@
+/*
+ * Licensed to the Apache Software Founda
Github user petermaxlee commented on a diff in the pull request:
https://github.com/apache/spark/pull/14472#discussion_r74190929
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala ---
@@ -0,0 +1,212 @@
+/*
+ * Licensed to the Apache Software Foun
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14155
**[Test build #63501 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63501/consoleFull)**
for PR 14155 at commit
[`9b08cca`](https://github.com/apache/spark/commit/
Github user petermaxlee commented on a diff in the pull request:
https://github.com/apache/spark/pull/14472#discussion_r74190946
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala ---
@@ -0,0 +1,212 @@
+/*
+ * Licensed to the Apache Software Foun
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14472#discussion_r74190989
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala ---
@@ -0,0 +1,211 @@
+/*
+ * Licensed to the Apache Software Founda
Github user petermaxlee commented on a diff in the pull request:
https://github.com/apache/spark/pull/14472#discussion_r74190988
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala ---
@@ -0,0 +1,186 @@
+/*
+ * Licensed to the Apache Software Foun
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14155
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14155
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63501/
Test PASSed.
---
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/14472
mostly LGTM, can you try some error cases and put the error message in PR
description? Then we can have a better understanding about how this framework
report errors. Thanks!
---
If your project
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14472
**[Test build #63507 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63507/consoleFull)**
for PR 14472 at commit
[`14f4959`](https://github.com/apache/spark/commit/1
Github user petermaxlee commented on a diff in the pull request:
https://github.com/apache/spark/pull/14472#discussion_r74191334
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala ---
@@ -0,0 +1,211 @@
+/*
+ * Licensed to the Apache Software Foun
Github user petermaxlee commented on the issue:
https://github.com/apache/spark/pull/14472
Updated the description. I think it might make sense to switch over to the
same way HiveCompatibilitySuite reports mismatches, but I think we should do
that after porting a few tests that have l
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14102#discussion_r74191412
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala
---
@@ -1360,7 +1363,8 @@ class JsonSuite extends QueryT
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14550
**[Test build #63508 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63508/consoleFull)**
for PR 14550 at commit
[`e575700`](https://github.com/apache/spark/commit/e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14547
**[Test build #63500 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63500/consoleFull)**
for PR 14547 at commit
[`233c6cc`](https://github.com/apache/spark/commit/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14547
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63500/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14547
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/14559#discussion_r74192492
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala ---
@@ -447,7 +447,11 @@ final class DataFrameWriter[T] private[sql](ds:
Da
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/13886
Sure, let me fix them now. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabl
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14571
**[Test build #63502 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63502/consoleFull)**
for PR 14571 at commit
[`0858a13`](https://github.com/apache/spark/commit/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14571
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14102#discussion_r74192533
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/JacksonParser.scala
---
@@ -35,184 +34,337 @@ import org.apache.spark.ut
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14571
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63502/
Test PASSed.
---
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14571
Hi, @rxin .
It's ready for review again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14527
**[Test build #63509 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63509/consoleFull)**
for PR 14527 at commit
[`e8348dd`](https://github.com/apache/spark/commit/e
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/14571#discussion_r74192723
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala
---
@@ -675,6 +675,7 @@ case class DenseRank(children:
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/14559#discussion_r74192910
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala ---
@@ -447,7 +447,11 @@ final class DataFrameWriter[T] private[sql](ds:
Da
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/14571#discussion_r74192984
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala
---
@@ -675,6 +675,7 @@ case class DenseRank(c
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14102#discussion_r74193001
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/JacksonParser.scala
---
@@ -35,184 +34,337 @@ import org.apache.spark.ut
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/14571#discussion_r74193132
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala
---
@@ -675,6 +675,7 @@ case class DenseRank(c
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14102#discussion_r74193172
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/JacksonParser.scala
---
@@ -35,184 +34,337 @@ import org.apache.spark.ut
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/14472
`number-format.sql *** FAILED *** (2 seconds, 405 milliseconds)`
do you have any idea why the test is so slow?
---
If your project is set up for it, you can reply to this email and have y
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14550#discussion_r74193561
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
---
@@ -413,7 +413,8 @@ private[hive] class HiveClientImpl(
Github user petermaxlee commented on the issue:
https://github.com/apache/spark/pull/14472
It was the first time any query was run, so JIT hasn't really kicked in yet.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If y
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13886
**[Test build #63510 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63510/consoleFull)**
for PR 13886 at commit
[`037388a`](https://github.com/apache/spark/commit/0
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13701
**[Test build #63503 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63503/consoleFull)**
for PR 13701 at commit
[`a2ba343`](https://github.com/apache/spark/commit/
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/13886
LGTM, pending jenkins, thanks for working on it!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/14102#discussion_r74193768
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/JacksonParser.scala
---
@@ -35,184 +34,337 @@ import org.apache.spark.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13701
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13701
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63503/
Test FAILed.
---
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14472#discussion_r74194064
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala ---
@@ -0,0 +1,211 @@
+/*
+ * Licensed to the Apache Software Founda
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14550#discussion_r74194235
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
---
@@ -413,7 +413,8 @@ private[hive] class HiveClientImpl(
701 - 768 of 768 matches
Mail list logo
