[GitHub] spark issue #14520: [SPARK-16934][ML][MLLib]Update LogisticCostAggregator se...

2016-08-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14520 **[Test build #63778 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63778/consoleFull)** for PR 14520 at commit [`e7ff240`](https://github.com/apache/spark/commit/e

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-15 Thread junyangq
Github user junyangq commented on a diff in the pull request: https://github.com/apache/spark/pull/14558#discussion_r74729028 --- Diff: R/pkg/R/generics.R --- @@ -1251,10 +1311,57 @@ setGeneric("year", function(x) { standardGeneric("year") }) #' @export setGeneric("spark.

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-15 Thread junyangq
Github user junyangq commented on a diff in the pull request: https://github.com/apache/spark/pull/14558#discussion_r74728822 --- Diff: R/pkg/R/generics.R --- @@ -1277,8 +1384,11 @@ setGeneric("spark.naiveBayes", function(data, formula, ...) { standardGeneric("s #' @rdna

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-15 Thread junyangq
Github user junyangq commented on a diff in the pull request: https://github.com/apache/spark/pull/14558#discussion_r74728351 --- Diff: R/pkg/R/mllib.R --- @@ -142,15 +143,6 @@ setMethod("spark.glm", signature(data = "SparkDataFrame", formula = "formula"), #' Generalized Linea

[GitHub] spark issue #14642: [SPARK-17056][Core] Fix a wrong assert regarding unroll ...

2016-08-15 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/14642 Actually I think it might be able to remove this assert... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not hav

[GitHub] spark issue #14642: [SPARK-17056][Core] Fix a wrong assert regarding unroll ...

2016-08-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14642 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63773/ Test PASSed. ---

[GitHub] spark issue #14642: [SPARK-17056][Core] Fix a wrong assert regarding unroll ...

2016-08-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14642 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #14642: [SPARK-17056][Core] Fix a wrong assert regarding unroll ...

2016-08-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14642 **[Test build #63773 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63773/consoleFull)** for PR 14642 at commit [`cf4387a`](https://github.com/apache/spark/commit/

[GitHub] spark pull request #14558: [SPARK-16508][SparkR] Fix warnings on undocumente...

2016-08-15 Thread junyangq
Github user junyangq commented on a diff in the pull request: https://github.com/apache/spark/pull/14558#discussion_r74727208 --- Diff: R/pkg/R/mllib.R --- @@ -602,14 +599,14 @@ setMethod("spark.survreg", signature(data = "SparkDataFrame", formula = "formula # Returns a summar

[GitHub] spark pull request #13796: [SPARK-7159][ML] Add multiclass logistic regressi...

2016-08-15 Thread dbtsai
Github user dbtsai commented on a diff in the pull request: https://github.com/apache/spark/pull/13796#discussion_r74726485 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala --- @@ -930,10 +942,8 @@ class BinaryLogisticRegressionSummary pr

[GitHub] spark issue #14645: [MINOR] [DOC] Correct code snippet results in quick star...

2016-08-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14645 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

[GitHub] spark issue #14520: [SPARK-16934][ML][MLLib] Improve LogisticCostFun to avoi...

2016-08-15 Thread MLnick
Github user MLnick commented on the issue: https://github.com/apache/spark/pull/14520 @WeichenXu123 would you mind updating the title of the JIRA and PR, as well as the description, to reflect the fact that this is not actually affecting serialization, but more to update the approach

[GitHub] spark pull request #14520: [SPARK-16934][ML][MLLib] Improve LogisticCostFun ...

2016-08-15 Thread dbtsai
Github user dbtsai commented on a diff in the pull request: https://github.com/apache/spark/pull/14520#discussion_r74726107 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala --- @@ -1071,24 +1074,23 @@ private class LogisticCostFun(

[GitHub] spark pull request #14620: [SPARK-17032][SQL] Add test cases for methods in ...

2016-08-15 Thread jiangxb1987
Github user jiangxb1987 commented on a diff in the pull request: https://github.com/apache/spark/pull/14620#discussion_r74725943 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/ParserUtilsSuite.scala --- @@ -61,5 +88,39 @@ class ParserUtilsSuite extends

<    1   2   3   4   5   6