Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14747
**[Test build #64188 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64188/consoleFull)**
for PR 14747 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14688
**[Test build #64194 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64194/consoleFull)**
for PR 14688 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14747
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64196/
Test PASSed.
---
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/14524
+ @yanboliang for R `spark.gaussianMixture`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14747
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14747
**[Test build #64196 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64196/consoleFull)**
for PR 14747 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14747
**[Test build #64197 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64197/consoleFull)**
for PR 14747 at commit
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/14744
Could you open a JIRA on this and add more info on why this is needed and
can't use `SPARKR_DRIVER_R`?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/14744#discussion_r75664285
--- Diff: docs/configuration.md ---
@@ -1752,6 +1752,13 @@ showDF(properties, numRows = 200, truncate = FALSE)
Executable for executing R
Github user MLnick commented on the issue:
https://github.com/apache/spark/pull/14663
Ah right, good point. Actually I realised that the doc in
`ml.feature.StandardScaler` needs updating for `withMean`:
```
/**
* Whether to center the data with mean before
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/14735#discussion_r75664196
--- Diff: R/pkg/R/mllib.R ---
@@ -1027,7 +1009,7 @@ setMethod("spark.gaussianMixture", signature(data =
"SparkDataFrame", formula =
#' @export
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/14743
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/14734
@shivaram any more thought? I'll merge since we should have this to be
ready for CRAN.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/14735#discussion_r75661739
--- Diff: R/pkg/R/mllib.R ---
@@ -499,11 +505,11 @@ setMethod("predict", signature(object =
"IsotonicRegressionModel"),
#' @export
#' @note
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/14735#discussion_r75661714
--- Diff: R/pkg/R/mllib.R ---
@@ -1027,7 +1009,7 @@ setMethod("spark.gaussianMixture", signature(data =
"SparkDataFrame", formula =
#' @export
Github user mpjlu commented on a diff in the pull request:
https://github.com/apache/spark/pull/14597#discussion_r75661562
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/ChiSqSelector.scala ---
@@ -189,11 +227,20 @@ class ChiSqSelector @Since("1.3.0") (
*/
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14531#discussion_r75660683
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ---
@@ -75,18 +81,52 @@ case class CreateTableLikeCommand(
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/14537
why do we infer schema for tables? Table schema should be persisted to
metastore when it was created.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user GraceH commented on the issue:
https://github.com/apache/spark/pull/7927
@sprite331. According to my understanding, this patch tries to catch
certain exceptions when the user introducing dynamic allocation. One quick
solution is to disable dynamic allocation if possible,
Github user GraceH commented on the issue:
https://github.com/apache/spark/pull/14683
Thanks @srowen
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14744
**[Test build #64191 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64191/consoleFull)**
for PR 14744 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14688
**[Test build #64194 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64194/consoleFull)**
for PR 14688 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14747
**[Test build #64196 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64196/consoleFull)**
for PR 14747 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14688
**[Test build #64192 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64192/consoleFull)**
for PR 14688 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14567
**[Test build #64190 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64190/consoleFull)**
for PR 14567 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14749
**[Test build #64195 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64195/consoleFull)**
for PR 14749 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14524
**[Test build #64193 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64193/consoleFull)**
for PR 14524 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14747
**[Test build #64188 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64188/consoleFull)**
for PR 14747 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14567
**[Test build #64189 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64189/consoleFull)**
for PR 14567 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14748
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14748
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64187/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14748
**[Test build #64187 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64187/consoleFull)**
for PR 14748 at commit
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/9183
@MLnick I think this is an important feature to make ML pipeline handle
large datasets elegantly. I will update/send a new PR soon and looking forward
that you can help to review. Thanks!
---
GitHub user liancheng opened a pull request:
https://github.com/apache/spark/pull/14749
[SPARK-17182][SQL] Mark Collect as non-deterministic
## What changes were proposed in this pull request?
This PR marks the abstract class `Collect` as non-deterministic since the
Github user MLnick commented on the issue:
https://github.com/apache/spark/pull/9183
@yanboliang will you be reviving this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/12889
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user MLnick commented on the issue:
https://github.com/apache/spark/pull/12889
Merged to master. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/10896#discussion_r75649753
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/AggUtils.scala
---
@@ -27,26 +27,87 @@ import
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/14688
Jenkins retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/14688
OK I was going to say we would also have to fix the instance @sethah notes
above, but looks like that was already fixed or was fixed before committing it.
OK this looks fine; I'll verify the
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/10896#discussion_r75649105
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/EnsureRequirements.scala
---
@@ -151,18 +152,39 @@ case class
Github user jagadeesanas2 commented on the issue:
https://github.com/apache/spark/pull/14688
@srowen I do not find any other instances. Perhaps I send some fixes for
Latex string.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/14743
Yup, it seems this fix is correct.
```r
> Sys.getenv("LOCALAPPDATA", unset = NA)
[1] "C:\\..."
> Sys.getenv("%LOCALAPPDATA%", unset = NA)
[1] NA
```
---
If your
Github user zjffdu commented on a diff in the pull request:
https://github.com/apache/spark/pull/14744#discussion_r75647107
--- Diff: docs/configuration.md ---
@@ -1752,6 +1752,15 @@ showDF(properties, numRows = 200, truncate = FALSE)
Executable for executing R scripts in
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14747
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64186/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14747
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14747
**[Test build #64186 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64186/consoleFull)**
for PR 14747 at commit
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14747#discussion_r75643772
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/QuantileDiscretizer.scala ---
@@ -114,7 +114,11 @@ final class QuantileDiscretizer @Since("1.6.0")
Github user Stibbons commented on the issue:
https://github.com/apache/spark/pull/14567
Reworked according to your review. Please keep in mind this is just the
first part of a two part pull request, the second will contain a selected part
of [this
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/14729
@gatorsmile yeah, we should fix this issue for `2.0.1`.
@viirya we do not need to support all kinds of temporary tables. However,
you are allowed to create a temporary read only table
Github user rajeshbalamohan commented on the issue:
https://github.com/apache/spark/pull/14537
Thanks @rxin . Incorporated review comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user Stibbons commented on a diff in the pull request:
https://github.com/apache/spark/pull/14567#discussion_r75642520
--- Diff: python/pyspark/cloudpickle.py ---
@@ -280,7 +279,7 @@ def extract_code_globals(co):
# see if nested function have any global refs
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/12889
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/12889
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64185/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/12889
**[Test build #64185 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64185/consoleFull)**
for PR 12889 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14747
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64184/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14747
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14747
**[Test build #64184 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64184/consoleFull)**
for PR 14747 at commit
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/14723#discussion_r75641493
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/SortBasedAggregationIterator.scala
---
@@ -90,6 +98,21 @@ class
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14537
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14537
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64183/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14537
**[Test build #64183 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64183/consoleFull)**
for PR 14537 at commit
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/11956
I'm not qualified to comment as I tend to ignore SQL unless it's a simple
and easy to evaluate change.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14748
**[Test build #64187 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64187/consoleFull)**
for PR 14748 at commit
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/14663
Warning seems reasonable. I think you'd have to put in a flag to remember
if the user has been warned in order to avoid spewing millions of them. Worth
it, you think?
---
If your project is set up
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14746
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64182/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14746
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/14748
CC @holdenk @davies for a look
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14746
**[Test build #64182 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64182/consoleFull)**
for PR 14746 at commit
GitHub user srowen opened a pull request:
https://github.com/apache/spark/pull/14748
[SPARK-16781] [PYSPARK] java launched by PySpark as gateway may not be the
same java used in the spark environment
## What changes were proposed in this pull request?
Update to py4j 0.10.3
Github user MLnick commented on the issue:
https://github.com/apache/spark/pull/14663
As mentioned on the JIRA discussion, I'm neutral on this, though I tend to
lean towards allowing the user to do what they want even if it might be
"dangerous". I guess +0?
Though perhaps we
Github user a-roberts commented on the issue:
https://github.com/apache/spark/pull/11956
@hvanhovell @marmbrus @srowen I see this PR has been open since the 25th of
March and provides substantial performance improvements as mentioned above
without introducing functional regressions,
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/14735#discussion_r75638333
--- Diff: R/pkg/R/mllib.R ---
@@ -499,11 +505,11 @@ setMethod("predict", signature(object =
"IsotonicRegressionModel"),
#' @export
#' @note
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/14735#discussion_r75636716
--- Diff: R/pkg/R/mllib.R ---
@@ -1027,7 +1009,7 @@ setMethod("spark.gaussianMixture", signature(data =
"SparkDataFrame", formula =
#' @export
Github user mpjlu commented on a diff in the pull request:
https://github.com/apache/spark/pull/14597#discussion_r75636510
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/ChiSqSelector.scala ---
@@ -189,11 +227,20 @@ class ChiSqSelector @Since("1.3.0") (
*/
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14747#discussion_r75636483
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/QuantileDiscretizer.scala ---
@@ -114,7 +114,7 @@ final class QuantileDiscretizer @Since("1.6.0")
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/14663
going once, going twice. This would simply let an operation proceed where
it errored before, at the cost of giving a user a little more rope to hang
him/herself. I think it unblocks a legitimate and
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/14747#discussion_r75636343
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/QuantileDiscretizer.scala ---
@@ -114,7 +114,7 @@ final class QuantileDiscretizer
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/14715
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/14688
@jagadeesanas2 can you follow up on this to address other instances,
including the one you opened the other PR for?
---
If your project is set up for it, you can reply to this email and have your
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/14715
Merged to master/2.0
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14747
**[Test build #64186 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64186/consoleFull)**
for PR 14747 at commit
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14747#discussion_r75635220
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/QuantileDiscretizerSuite.scala
---
@@ -52,6 +52,25 @@ class QuantileDiscretizerSuite
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/14747
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14597#discussion_r75635056
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/ChiSqSelector.scala ---
@@ -189,11 +227,20 @@ class ChiSqSelector @Since("1.3.0") (
*/
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/14738
It's better to update the PR title as ```[SPARK-17090][FOLLOW-UP][ML] ...
```.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14597#discussion_r75634988
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/ChiSqSelector.scala ---
@@ -189,11 +227,20 @@ class ChiSqSelector @Since("1.3.0") (
*/
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14597#discussion_r75635041
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/ChiSqSelector.scala ---
@@ -189,11 +227,20 @@ class ChiSqSelector @Since("1.3.0") (
*/
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14597#discussion_r75634953
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/ChiSqSelector.scala ---
@@ -189,11 +227,20 @@ class ChiSqSelector @Since("1.3.0") (
*/
Github user VinceShieh commented on the issue:
https://github.com/apache/spark/pull/14747
it seems Array.distinct will not break the sequence of the elements. But,
you are right, we need guarantee the array is sorted.
---
If your project is set up for it, you can reply to this
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14597#discussion_r75634791
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/ChiSqSelector.scala ---
@@ -91,8 +130,16 @@ final class ChiSqSelector @Since("1.6.0")
Github user mpjlu commented on a diff in the pull request:
https://github.com/apache/spark/pull/14597#discussion_r75634659
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/ChiSqSelector.scala ---
@@ -54,6 +54,29 @@ private[feature] trait ChiSqSelectorParams extends
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14597#discussion_r75634631
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/ChiSqSelector.scala ---
@@ -32,17 +32,21 @@ import org.apache.spark.rdd.RDD
import
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14597#discussion_r75634441
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/ChiSqSelector.scala ---
@@ -69,21 +73,22 @@ class ChiSqSelectorModel @Since("1.3.0") (
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14597#discussion_r75634305
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/ChiSqSelector.scala ---
@@ -54,6 +55,29 @@ private[feature] trait ChiSqSelectorParams extends
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14597#discussion_r75634371
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/ChiSqSelector.scala ---
@@ -91,8 +130,16 @@ final class ChiSqSelector @Since("1.6.0")
Github user hqzizania commented on a diff in the pull request:
https://github.com/apache/spark/pull/14738#discussion_r75634235
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/param/shared/SharedParamsCodeGen.scala
---
@@ -167,11 +173,11 @@ private[shared] object
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/14692
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14597#discussion_r75634212
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/ChiSqSelector.scala ---
@@ -54,6 +54,29 @@ private[feature] trait ChiSqSelectorParams extends
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/12889
**[Test build #64185 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64185/consoleFull)**
for PR 12889 at commit
601 - 700 of 761 matches
Mail list logo
