[GitHub] spark issue #14866: [SPARK-17298][SQL] Require explicit CROSS join for carte...

2016-09-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14866 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64868/ Test FAILed. ---

[GitHub] spark issue #14940: [SPARK-17383][GRAPHX]LabelPropagation

2016-09-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14940 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

[GitHub] spark issue #14866: [SPARK-17298][SQL] Require explicit CROSS join for carte...

2016-09-02 Thread srinathshankar
Github user srinathshankar commented on the issue: https://github.com/apache/spark/pull/14866 I'll update the python and R APIs in a follow up. Right now in python and R a cross join is done if no join exprs/columns and join types are specified. It would be good to require explicit cr

[GitHub] spark pull request #14940: [SPARK-17383][GRAPHX]LabelPropagation

2016-09-02 Thread bookling
GitHub user bookling opened a pull request: https://github.com/apache/spark/pull/14940 [SPARK-17383][GRAPHX]LabelPropagation In the labelPropagation of graphx lib, node is initialized with a unique label and at every step each node adopts the label that most of its neighbors cur

[GitHub] spark issue #14931: [SPARK-17370] Shuffle service files not invalidated when...

2016-09-02 Thread ericl
Github user ericl commented on the issue: https://github.com/apache/spark/pull/14931 What if we added a flag to SlaveLost indicating if we think the entire host is lost? In many cases that should be true, if the event originated from worker loss or Mesos slave loss events. --- If yo

[GitHub] spark issue #14938: [SPARK-17335][SQL] Fix ArrayType and MapType CatalogStri...

2016-09-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14938 **[Test build #64867 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64867/consoleFull)** for PR 14938 at commit [`b57bbb6`](https://github.com/apache/spark/commit/b

[GitHub] spark issue #14931: [SPARK-17370] Shuffle service files not invalidated when...

2016-09-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14931 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64862/ Test FAILed. ---

[GitHub] spark issue #14931: [SPARK-17370] Shuffle service files not invalidated when...

2016-09-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14931 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #14931: [SPARK-17370] Shuffle service files not invalidated when...

2016-09-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14931 **[Test build #64862 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64862/consoleFull)** for PR 14931 at commit [`2430b69`](https://github.com/apache/spark/commit/

[GitHub] spark pull request #14797: [SPARK-17230] [SQL] Should not pass optimized que...

2016-09-02 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/14797#discussion_r77394975 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala --- @@ -479,13 +480,23 @@ case class DataSource(

[GitHub] spark issue #14939: [SPARK-17376][SPARKR] followup - change since version

2016-09-02 Thread shivaram
Github user shivaram commented on the issue: https://github.com/apache/spark/pull/14939 Ah thanks - I didn't notice this while merging the earlier PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does n

[GitHub] spark issue #14854: [SPARK-17283][Core] Cancel job in RDD.take() as soon as ...

2016-09-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14854 **[Test build #64866 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64866/consoleFull)** for PR 14854 at commit [`32c3959`](https://github.com/apache/spark/commit/3

[GitHub] spark issue #14881: [SPARK-17315][SparkR] Kolmogorov-Smirnov test SparkR wra...

2016-09-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14881 **[Test build #64865 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64865/consoleFull)** for PR 14881 at commit [`caeb91e`](https://github.com/apache/spark/commit/c

[GitHub] spark issue #14828: [SPARK-17258][SQL] Parse scientific decimal literals as ...

2016-09-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14828 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #14828: [SPARK-17258][SQL] Parse scientific decimal literals as ...

2016-09-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14828 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64861/ Test PASSed. ---

[GitHub] spark issue #14828: [SPARK-17258][SQL] Parse scientific decimal literals as ...

2016-09-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14828 **[Test build #64861 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64861/consoleFull)** for PR 14828 at commit [`302f55f`](https://github.com/apache/spark/commit/

[GitHub] spark pull request #14939: [SPARK-17376][SPARKR] followup - change since ver...

2016-09-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/14939 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark issue #14939: [SPARK-17376][SPARKR] followup - change since version

2016-09-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14939 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark pull request #14881: [SPARK-17315][SparkR] Kolmogorov-Smirnov test Spa...

2016-09-02 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14881#discussion_r77388738 --- Diff: R/pkg/R/mllib.R --- @@ -1308,3 +1315,104 @@ setMethod("write.ml", signature(object = "ALSModel", path = "character"), function(o

[GitHub] spark issue #14939: [SPARK-17376][SPARKR] followup - change since version

2016-09-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14939 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64864/ Test PASSed. ---

[GitHub] spark issue #14939: [SPARK-17376][SPARKR] followup - change since version

2016-09-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14939 **[Test build #64864 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64864/consoleFull)** for PR 14939 at commit [`6a19a5d`](https://github.com/apache/spark/commit/

[GitHub] spark issue #14573: [SPARK-16984][SQL] don't try whole dataset immediately w...

2016-09-02 Thread robert3005
Github user robert3005 commented on the issue: https://github.com/apache/spark/pull/14573 Agree it would be subsumed and it looks pretty cool. I didn't know you can make it asynchronous also you want to avoid spinning too many tasks since these consume resources and block other jobs.

[GitHub] spark issue #10970: [SPARK-13067][SQL] workaround for a weird scala reflecti...

2016-09-02 Thread atronchi
Github user atronchi commented on the issue: https://github.com/apache/spark/pull/10970 How can we workaround this problem when using 1.6.1? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have th

[GitHub] spark pull request #14718: [SPARK-16711] YarnShuffleService doesn't re-init ...

2016-09-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/14718 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark issue #14718: [SPARK-16711] YarnShuffleService doesn't re-init properl...

2016-09-02 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/14718 I thought you were going to merge it yourself, but since you didn't... merging to master / 2.0. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark issue #14718: [SPARK-16711] YarnShuffleService doesn't re-init properl...

2016-09-02 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/14718 No luck merging to 2.0. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes s

[GitHub] spark issue #14573: [SPARK-16984][SQL] don't try whole dataset immediately w...

2016-09-02 Thread JoshRosen
Github user JoshRosen commented on the issue: https://github.com/apache/spark/pull/14573 Nice change, but I think that at least some of the benefit of this will be subsumed by #14854, my patch which allows `take()` to cancel the running job as soon as enough output is produced. ---

[GitHub] spark issue #14866: [SPARK-17298][SQL] Require explicit CROSS join for carte...

2016-09-02 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/14866 LGTM - pending jenkins. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wish

[GitHub] spark pull request #14907: [SPARK-17351] Refactor JDBCRDD to expose ResultSe...

2016-09-02 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/14907#discussion_r77384493 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala --- @@ -154,6 +163,297 @@ object JdbcUtils extends Loggi

[GitHub] spark pull request #14881: [SPARK-17315][SparkR] Kolmogorov-Smirnov test Spa...

2016-09-02 Thread junyangq
Github user junyangq commented on a diff in the pull request: https://github.com/apache/spark/pull/14881#discussion_r77384344 --- Diff: R/pkg/R/mllib.R --- @@ -1308,3 +1315,104 @@ setMethod("write.ml", signature(object = "ALSModel", path = "character"), function(obje

[GitHub] spark pull request #14907: [SPARK-17351] Refactor JDBCRDD to expose ResultSe...

2016-09-02 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/14907#discussion_r77384218 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala --- @@ -546,33 +281,33 @@ private[jdbc] class JDBCRDD(

[GitHub] spark pull request #14887: [SPARK-17321][YARN] YARN shuffle service should u...

2016-09-02 Thread zhaoyunjiong
Github user zhaoyunjiong commented on a diff in the pull request: https://github.com/apache/spark/pull/14887#discussion_r77383971 --- Diff: common/network-yarn/src/main/java/org/apache/spark/network/yarn/YarnShuffleService.java --- @@ -25,6 +25,8 @@ import com.google.common.c

[GitHub] spark pull request #14912: [SPARK-17357][SQL] Simplified predicates should b...

2016-09-02 Thread srinathshankar
Github user srinathshankar commented on a diff in the pull request: https://github.com/apache/spark/pull/14912#discussion_r77383932 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/FilterPushdownSuite.scala --- @@ -171,6 +172,27 @@ class FilterPushdown

[GitHub] spark pull request #14866: [SPARK-17298][SQL] Require explicit CROSS join fo...

2016-09-02 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14866#discussion_r77383666 --- Diff: R/pkg/R/DataFrame.R --- @@ -2265,7 +2265,7 @@ setMethod("join", signature(x = "SparkDataFrame", y = "SparkDataFrame"),

[GitHub] spark issue #14939: [SPARK-17376][SPARKR] followup - change since version

2016-09-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14939 **[Test build #64864 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64864/consoleFull)** for PR 14939 at commit [`6a19a5d`](https://github.com/apache/spark/commit/6

[GitHub] spark pull request #14934: [SPARKR][DOC] regexp_extract should doc that it r...

2016-09-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/14934 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request #14939: [SPARK-17376][SPARKR] followup - change since ver...

2016-09-02 Thread felixcheung
GitHub user felixcheung opened a pull request: https://github.com/apache/spark/pull/14939 [SPARK-17376][SPARKR] followup - change since version ## What changes were proposed in this pull request? change since version in doc ## How was this patch tested?

[GitHub] spark issue #14938: [SPARK-17335][SQL] Fix ArrayType and MapType CatalogStri...

2016-09-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14938 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #14938: [SPARK-17335][SQL] Fix ArrayType and MapType CatalogStri...

2016-09-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14938 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64859/ Test PASSed. ---

[GitHub] spark issue #14938: [SPARK-17335][SQL] Fix ArrayType and MapType CatalogStri...

2016-09-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14938 **[Test build #64859 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64859/consoleFull)** for PR 14938 at commit [`7ab9de0`](https://github.com/apache/spark/commit/

[GitHub] spark issue #14934: [SPARKR][DOC] regexp_extract should doc that it returns ...

2016-09-02 Thread shivaram
Github user shivaram commented on the issue: https://github.com/apache/spark/pull/14934 LGTM. Merging into master, branch-2.0 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enab

[GitHub] spark pull request #14934: [SPARKR][DOC] regexp_extract should doc that it r...

2016-09-02 Thread shivaram
Github user shivaram commented on a diff in the pull request: https://github.com/apache/spark/pull/14934#discussion_r77381083 --- Diff: R/pkg/R/functions.R --- @@ -2876,7 +2876,8 @@ setMethod("randn", signature(seed = "numeric"), #' regexp_extract #' -#' Extract

[GitHub] spark pull request #14934: [SPARKR][DOC] regexp_extract should doc that it r...

2016-09-02 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14934#discussion_r77380815 --- Diff: R/pkg/R/functions.R --- @@ -2876,7 +2876,8 @@ setMethod("randn", signature(seed = "numeric"), #' regexp_extract #' -#' Extra

[GitHub] spark pull request #14935: [SPARK-17376][SPARKR] Spark version should be ava...

2016-09-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/14935 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark issue #14935: [SPARK-17376][SPARKR] Spark version should be available ...

2016-09-02 Thread shivaram
Github user shivaram commented on the issue: https://github.com/apache/spark/pull/14935 Merged into master, branch-2.0 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #14866: [SPARK-17298][SQL] Require explicit CROSS join for carte...

2016-09-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14866 **[Test build #64863 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64863/consoleFull)** for PR 14866 at commit [`7f3d67f`](https://github.com/apache/spark/commit/7

[GitHub] spark pull request #14866: [SPARK-17298][SQL] Require explicit CROSS join fo...

2016-09-02 Thread srinathshankar
Github user srinathshankar commented on a diff in the pull request: https://github.com/apache/spark/pull/14866#discussion_r77380304 --- Diff: R/pkg/R/DataFrame.R --- @@ -2265,7 +2265,7 @@ setMethod("join", signature(x = "SparkDataFrame", y = "SparkDataFrame"),

[GitHub] spark pull request #14857: [SPARK-17261][PYSPARK] Using HiveContext after re...

2016-09-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/14857 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark issue #14857: [SPARK-17261][PYSPARK] Using HiveContext after re-creati...

2016-09-02 Thread davies
Github user davies commented on the issue: https://github.com/apache/spark/pull/14857 Merging into master and 2.0 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wish

[GitHub] spark issue #14857: [SPARK-17261][PYSPARK] Using HiveContext after re-creati...

2016-09-02 Thread davies
Github user davies commented on the issue: https://github.com/apache/spark/pull/14857 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] spark issue #14931: [SPARK-17370] Shuffle service files not invalidated when...

2016-09-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14931 **[Test build #64862 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64862/consoleFull)** for PR 14931 at commit [`2430b69`](https://github.com/apache/spark/commit/2

[GitHub] spark pull request #14931: [SPARK-17370] Shuffle service files not invalidat...

2016-09-02 Thread ericl
Github user ericl commented on a diff in the pull request: https://github.com/apache/spark/pull/14931#discussion_r77378981 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala --- @@ -346,15 +346,16 @@ private[spark] class TaskSchedulerImpl(

[GitHub] spark issue #14867: [SPARK-17296][SQL] Simplify parser join processing.

2016-09-02 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/14867 cc @srinathshankar --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] spark pull request #14907: [SPARK-17351] Refactor JDBCRDD to expose ResultSe...

2016-09-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/14907 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark issue #14712: [SPARK-17072] [SQL] support table-level statistics gener...

2016-09-02 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/14712 Below is a test case for a table with empty column. Could you also add it here? ```Scala test("statistics collection of a table with zero column") { val table_no_cols = "ta

[GitHub] spark issue #14712: [SPARK-17072] [SQL] support table-level statistics gener...

2016-09-02 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/14712 LGTM except two minor comments about test cases. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #14907: [SPARK-17351] Refactor JDBCRDD to expose ResultSet -> Se...

2016-09-02 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/14907 LGTM. Merging to master. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark pull request #14907: [SPARK-17351] Refactor JDBCRDD to expose ResultSe...

2016-09-02 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/14907#discussion_r77377425 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala --- @@ -154,6 +163,297 @@ object JdbcUtils extends Logg

[GitHub] spark pull request #14907: [SPARK-17351] Refactor JDBCRDD to expose ResultSe...

2016-09-02 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/14907#discussion_r77377079 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala --- @@ -154,6 +163,288 @@ object JdbcUtils extends Logg

[GitHub] spark pull request #14907: [SPARK-17351] Refactor JDBCRDD to expose ResultSe...

2016-09-02 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/14907#discussion_r77375713 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala --- @@ -546,33 +281,33 @@ private[jdbc] class JDBCRDD(

[GitHub] spark issue #14927: [SPARK-16922] [SPARK-17211] [SQL] make the address of va...

2016-09-02 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/14927 @davies are we making this assumption anywhere else in our unsafe code? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pro

[GitHub] spark pull request #14934: [SPARKR][DOC] regexp_extract should doc that it r...

2016-09-02 Thread shivaram
Github user shivaram commented on a diff in the pull request: https://github.com/apache/spark/pull/14934#discussion_r77375452 --- Diff: R/pkg/R/functions.R --- @@ -2876,7 +2876,8 @@ setMethod("randn", signature(seed = "numeric"), #' regexp_extract #' -#' Extract

[GitHub] spark issue #14433: [SPARK-16829][SparkR]:sparkR sc.setLogLevel doesn't work

2016-09-02 Thread shivaram
Github user shivaram commented on the issue: https://github.com/apache/spark/pull/14433 LGTM. Thanks @wangmiao1981 -- I'll keep this open for a bit to see if there are any more comments. --- If your project is set up for it, you can reply to this email and have your reply appear on G

[GitHub] spark issue #14935: [SPARK-17376][SPARKR] Spark version should be available ...

2016-09-02 Thread shivaram
Github user shivaram commented on the issue: https://github.com/apache/spark/pull/14935 LGTM. I actually think this might also be useful in 2.0.1 ? cc @junyangq --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request #14712: [SPARK-17072] [SQL] support table-level statistic...

2016-09-02 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/14712#discussion_r77373066 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/StatisticsSuite.scala --- @@ -168,6 +170,137 @@ class StatisticsSuite extends QueryTest with

[GitHub] spark issue #14924: [SPARK-17299] TRIM/LTRIM/RTRIM should not strips charact...

2016-09-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14924 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64856/ Test PASSed. ---

[GitHub] spark issue #14924: [SPARK-17299] TRIM/LTRIM/RTRIM should not strips charact...

2016-09-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14924 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark pull request #14842: [SPARK-10747][SQL] Support NULLS FIRST|LAST claus...

2016-09-02 Thread xwu0226
Github user xwu0226 commented on a diff in the pull request: https://github.com/apache/spark/pull/14842#discussion_r77372825 --- Diff: core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeInMemorySorter.java --- @@ -333,11 +333,12 @@ public UnsafeSorterIterator ge

[GitHub] spark issue #14924: [SPARK-17299] TRIM/LTRIM/RTRIM should not strips charact...

2016-09-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14924 **[Test build #64856 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64856/consoleFull)** for PR 14924 at commit [`7583070`](https://github.com/apache/spark/commit/

[GitHub] spark issue #14923: [SPARK-17363][ML][MLLib] fix MultivariantOnlineSummerize...

2016-09-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14923 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #14923: [SPARK-17363][ML][MLLib] fix MultivariantOnlineSummerize...

2016-09-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14923 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64858/ Test PASSed. ---

[GitHub] spark issue #14923: [SPARK-17363][ML][MLLib] fix MultivariantOnlineSummerize...

2016-09-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14923 **[Test build #64858 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64858/consoleFull)** for PR 14923 at commit [`cea5cdf`](https://github.com/apache/spark/commit/

[GitHub] spark issue #14921: [SPARK-17361][SQL] file-based external table without pat...

2016-09-02 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/14921 LGTM again : ) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] spark issue #14931: [SPARK-17370] Shuffle service files not invalidated when...

2016-09-02 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/14931 Hmm... as far as I understand, `SlaveLost` does not mean "remote machine has died", it means "remote executor has died", which does not mean that the shuffle files were lost. Unless you actually try

[GitHub] spark issue #14828: [SPARK-17258][SQL] Parse scientific decimal literals as ...

2016-09-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14828 **[Test build #64861 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64861/consoleFull)** for PR 14828 at commit [`302f55f`](https://github.com/apache/spark/commit/3

[GitHub] spark issue #14828: [SPARK-17258][SQL] Parse scientific decimal literals as ...

2016-09-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14828 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #14828: [SPARK-17258][SQL] Parse scientific decimal literals as ...

2016-09-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14828 **[Test build #64860 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64860/consoleFull)** for PR 14828 at commit [`59b359c`](https://github.com/apache/spark/commit/

[GitHub] spark issue #14828: [SPARK-17258][SQL] Parse scientific decimal literals as ...

2016-09-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14828 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64860/ Test FAILed. ---

[GitHub] spark issue #14828: [SPARK-17258][SQL] Parse scientific decimal literals as ...

2016-09-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14828 **[Test build #64860 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64860/consoleFull)** for PR 14828 at commit [`59b359c`](https://github.com/apache/spark/commit/5

[GitHub] spark issue #14938: [SPARK-17335][SQL] Fix ArrayType and MapType CatalogStri...

2016-09-02 Thread ericl
Github user ericl commented on the issue: https://github.com/apache/spark/pull/14938 Lgtm. I wonder if it's also useful to set the truncation threshold lower in test? Though maybe that's a nuisance --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request #14573: [SPARK-16984][SQL] don't try whole dataset immedi...

2016-09-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/14573 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark issue #14933: [SPARK-16533][CORE] - backport driver deadlock fix to 2....

2016-09-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14933 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64855/ Test PASSed. ---

[GitHub] spark issue #14933: [SPARK-16533][CORE] - backport driver deadlock fix to 2....

2016-09-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14933 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #14573: [SPARK-16984][SQL] don't try whole dataset immediately w...

2016-09-02 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/14573 LGTM - merging to master. Thanks for working on this! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark issue #14933: [SPARK-16533][CORE] - backport driver deadlock fix to 2....

2016-09-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14933 **[Test build #64855 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64855/consoleFull)** for PR 14933 at commit [`de488ce`](https://github.com/apache/spark/commit/

[GitHub] spark issue #14938: Fix ArrayType and MapType CatalogString.

2016-09-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14938 **[Test build #64859 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64859/consoleFull)** for PR 14938 at commit [`7ab9de0`](https://github.com/apache/spark/commit/7

[GitHub] spark pull request #14938: Fix ArrayType and MapType CatalogString.

2016-09-02 Thread hvanhovell
GitHub user hvanhovell opened a pull request: https://github.com/apache/spark/pull/14938 Fix ArrayType and MapType CatalogString. ## What changes were proposed in this pull request? the `catalogString` for `ArrayType` and `MapType` currently calls the `simpleString` method on it

[GitHub] spark pull request #14922: [WIP][SPARK-17175][ML][MLLib] Add a expert formul...

2016-09-02 Thread WeichenXu123
Github user WeichenXu123 commented on a diff in the pull request: https://github.com/apache/spark/pull/14922#discussion_r77362198 --- Diff: mllib/src/main/scala/org/apache/spark/ml/param/shared/sharedParams.scala --- @@ -405,5 +405,9 @@ private[ml] trait HasAggregationDepth extends

[GitHub] spark issue #14923: [SPARK-17363][ML][MLLib] fix MultivariantOnlineSummerize...

2016-09-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14923 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #14923: [SPARK-17363][ML][MLLib] fix MultivariantOnlineSummerize...

2016-09-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14923 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64857/ Test PASSed. ---

[GitHub] spark issue #14923: [SPARK-17363][ML][MLLib] fix MultivariantOnlineSummerize...

2016-09-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14923 **[Test build #64857 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64857/consoleFull)** for PR 14923 at commit [`be59825`](https://github.com/apache/spark/commit/

[GitHub] spark issue #14923: [SPARK-17363][ML][MLLib] fix MultivariantOnlineSummerize...

2016-09-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14923 **[Test build #64858 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64858/consoleFull)** for PR 14923 at commit [`cea5cdf`](https://github.com/apache/spark/commit/c

[GitHub] spark pull request #14923: [SPARK-17363][ML][MLLib] fix MultivariantOnlineSu...

2016-09-02 Thread WeichenXu123
Github user WeichenXu123 commented on a diff in the pull request: https://github.com/apache/spark/pull/14923#discussion_r77361651 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/stat/MultivariateOnlineSummarizer.scala --- @@ -231,9 +231,9 @@ class MultivariateOnlineSummarize

[GitHub] spark pull request #14922: [WIP][SPARK-17175][ML][MLLib] Add a expert formul...

2016-09-02 Thread WeichenXu123
Github user WeichenXu123 commented on a diff in the pull request: https://github.com/apache/spark/pull/14922#discussion_r77358835 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala --- @@ -295,6 +295,13 @@ class LogisticRegression @Since("1.

[GitHub] spark issue #14521: [SPARK-16935] [SQL] Verification of Function-related Ext...

2016-09-02 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/14521 thanks, merging to master and 2.0! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enable

[GitHub] spark pull request #14923: [SPARK-17363][ML][MLLib] fix MultivariantOnlineSu...

2016-09-02 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/14923#discussion_r77357355 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/stat/MultivariateOnlineSummarizer.scala --- @@ -231,9 +231,9 @@ class MultivariateOnlineSummarizer exte

[GitHub] spark pull request #14922: [WIP][SPARK-17175][ML][MLLib] Add a expert formul...

2016-09-02 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/14922#discussion_r77357216 --- Diff: mllib/src/main/scala/org/apache/spark/ml/param/shared/sharedParams.scala --- @@ -405,5 +405,9 @@ private[ml] trait HasAggregationDepth extends Param

[GitHub] spark pull request #14922: [WIP][SPARK-17175][ML][MLLib] Add a expert formul...

2016-09-02 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/14922#discussion_r77357109 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala --- @@ -295,6 +295,13 @@ class LogisticRegression @Since("1.2.0")

[GitHub] spark pull request #14521: [SPARK-16935] [SQL] Verification of Function-rela...

2016-09-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/14521 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request #14922: [WIP][SPARK-17175][ML][MLLib] Add a expert formul...

2016-09-02 Thread WeichenXu123
Github user WeichenXu123 commented on a diff in the pull request: https://github.com/apache/spark/pull/14922#discussion_r77356253 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala --- @@ -295,6 +295,13 @@ class LogisticRegression @Since("1.

<    1   2   3   4   5   >