[GitHub] spark issue #15052: [SPARK-17500][PySpark]Make DiskBytesSpilled metric in Py...

2016-09-11 Thread djvulee
Github user djvulee commented on the issue: https://github.com/apache/spark/pull/15052 @srowen @davies mind taking a look? This PR is very simple. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark issue #11119: [SPARK-10780][ML] Add an initial model to kmeans

2016-09-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/9 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65237/ Test PASSed. ---

[GitHub] spark issue #11119: [SPARK-10780][ML] Add an initial model to kmeans

2016-09-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/9 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #11119: [SPARK-10780][ML] Add an initial model to kmeans

2016-09-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/9 **[Test build #65237 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65237/consoleFull)** for PR 9 at commit

[GitHub] spark issue #15045: [Spark Core][MINOR] fix "default partitioner cannot part...

2016-09-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15045 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15045: [Spark Core][MINOR] fix "default partitioner cannot part...

2016-09-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15045 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65236/ Test PASSed. ---

[GitHub] spark issue #15045: [Spark Core][MINOR] fix "default partitioner cannot part...

2016-09-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15045 **[Test build #65236 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65236/consoleFull)** for PR 15045 at commit

[GitHub] spark pull request #14834: [SPARK-17163][ML] Unified LogisticRegression inte...

2016-09-11 Thread dbtsai
Github user dbtsai commented on a diff in the pull request: https://github.com/apache/spark/pull/14834#discussion_r78316060 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala --- @@ -311,8 +350,28 @@ class LogisticRegression @Since("1.2.0")

[GitHub] spark issue #13758: [SPARK-16043][SQL] Prepare GenericArrayData implementati...

2016-09-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13758 **[Test build #65239 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65239/consoleFull)** for PR 13758 at commit

[GitHub] spark pull request #15051: [SPARK-17499][ML][MLLib] make the default params ...

2016-09-11 Thread WeichenXu123
Github user WeichenXu123 commented on a diff in the pull request: https://github.com/apache/spark/pull/15051#discussion_r78315909 --- Diff: R/pkg/R/mllib.R --- @@ -694,8 +694,8 @@ setMethod("predict", signature(object = "KMeansModel"), #' } #' @note spark.mlp since 2.1.0

[GitHub] spark pull request #15051: [SPARK-17499][ML][MLLib] make the default params ...

2016-09-11 Thread WeichenXu123
Github user WeichenXu123 commented on a diff in the pull request: https://github.com/apache/spark/pull/15051#discussion_r78315763 --- Diff: R/pkg/R/mllib.R --- @@ -694,8 +694,8 @@ setMethod("predict", signature(object = "KMeansModel"), #' } #' @note spark.mlp since 2.1.0

[GitHub] spark issue #13758: [SPARK-16043][SQL] Prepare GenericArrayData implementati...

2016-09-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13758 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65238/ Test FAILed. ---

[GitHub] spark issue #13758: [SPARK-16043][SQL] Prepare GenericArrayData implementati...

2016-09-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13758 **[Test build #65238 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65238/consoleFull)** for PR 13758 at commit

[GitHub] spark issue #13758: [SPARK-16043][SQL] Prepare GenericArrayData implementati...

2016-09-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13758 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #14834: [SPARK-17163][ML] Unified LogisticRegression inte...

2016-09-11 Thread dbtsai
Github user dbtsai commented on a diff in the pull request: https://github.com/apache/spark/pull/14834#discussion_r78315600 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala --- @@ -261,6 +299,7 @@ class LogisticRegression @Since("1.2.0")

[GitHub] spark issue #13758: [SPARK-16043][SQL] Prepare GenericArrayData implementati...

2016-09-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13758 **[Test build #65238 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65238/consoleFull)** for PR 13758 at commit

[GitHub] spark pull request #15038: [SPARK-17486] Remove unused TaskMetricsUIData.upd...

2016-09-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/15038 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #7266: [SPARK-8764][ML] string indexer should take option to han...

2016-09-11 Thread miro-balaz
Github user miro-balaz commented on the issue: https://github.com/apache/spark/pull/7266 thank you for directions On Monday, 12 September 2016, Holden Karau wrote: > @miro-balaz : This probably isn't the >

[GitHub] spark issue #11119: [SPARK-10780][ML] Add an initial model to kmeans

2016-09-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/9 **[Test build #65237 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65237/consoleFull)** for PR 9 at commit

[GitHub] spark issue #15038: [SPARK-17486] Remove unused TaskMetricsUIData.updatedBlo...

2016-09-11 Thread zsxwing
Github user zsxwing commented on the issue: https://github.com/apache/spark/pull/15038 LGTM. Merging to master and 2.0 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark issue #14452: [SPARK-16849][SQL] Improve subquery execution by dedupli...

2016-09-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14452 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65235/ Test PASSed. ---

[GitHub] spark issue #14452: [SPARK-16849][SQL] Improve subquery execution by dedupli...

2016-09-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14452 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14452: [SPARK-16849][SQL] Improve subquery execution by dedupli...

2016-09-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14452 **[Test build #65235 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65235/consoleFull)** for PR 14452 at commit

[GitHub] spark issue #14912: [SPARK-17357][SQL] Fix current predicate pushdown

2016-09-11 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/14912 To maintain the predicate sets may increase much complexity as I can think. I don't know how big the set could be. But once you change one of the predicates, you need to construct all equivalent

[GitHub] spark issue #15045: [Spark Core][MINOR] fix "default partitioner cannot part...

2016-09-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15045 **[Test build #65236 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65236/consoleFull)** for PR 15045 at commit

[GitHub] spark issue #15045: [Spark Core][MINOR] fix "default partitioner cannot part...

2016-09-11 Thread WeichenXu123
Github user WeichenXu123 commented on the issue: https://github.com/apache/spark/pull/15045 Jenkins, test this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark issue #14947: [SPARK-17388][SQL] Support for inferring type date/times...

2016-09-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14947 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65234/ Test PASSed. ---

[GitHub] spark issue #14947: [SPARK-17388][SQL] Support for inferring type date/times...

2016-09-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14947 **[Test build #65234 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65234/consoleFull)** for PR 14947 at commit

[GitHub] spark issue #14947: [SPARK-17388][SQL] Support for inferring type date/times...

2016-09-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14947 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #15051: [SPARK-17499][ML][MLLib] make the default params ...

2016-09-11 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/15051#discussion_r78310476 --- Diff: R/pkg/R/mllib.R --- @@ -694,8 +694,8 @@ setMethod("predict", signature(object = "KMeansModel"), #' } #' @note spark.mlp since 2.1.0

[GitHub] spark pull request #15051: [SPARK-17499][ML][MLLib] make the default params ...

2016-09-11 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/15051#discussion_r78310368 --- Diff: R/pkg/R/mllib.R --- @@ -694,8 +694,8 @@ setMethod("predict", signature(object = "KMeansModel"), #' } #' @note spark.mlp since 2.1.0

[GitHub] spark issue #14452: [SPARK-16849][SQL] Improve subquery execution by dedupli...

2016-09-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14452 **[Test build #65235 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65235/consoleFull)** for PR 14452 at commit

[GitHub] spark pull request #14988: [SPARK-17425][SQL] Override sameResult in HiveTab...

2016-09-11 Thread watermen
Github user watermen commented on a diff in the pull request: https://github.com/apache/spark/pull/14988#discussion_r78309372 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/HiveTableScanExec.scala --- @@ -164,4 +164,11 @@ case class HiveTableScanExec(

[GitHub] spark pull request #15051: [SPARK-17499][ML][MLLib] make the default params ...

2016-09-11 Thread WeichenXu123
Github user WeichenXu123 commented on a diff in the pull request: https://github.com/apache/spark/pull/15051#discussion_r78309230 --- Diff: R/pkg/R/mllib.R --- @@ -694,8 +694,8 @@ setMethod("predict", signature(object = "KMeansModel"), #' } #' @note spark.mlp since 2.1.0

[GitHub] spark issue #15048: [SPARK-17409] [SQL] Do Not Optimize Query in CTAS More T...

2016-09-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15048 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15048: [SPARK-17409] [SQL] Do Not Optimize Query in CTAS More T...

2016-09-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15048 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65233/ Test PASSed. ---

[GitHub] spark issue #15048: [SPARK-17409] [SQL] Do Not Optimize Query in CTAS More T...

2016-09-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15048 **[Test build #65233 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65233/consoleFull)** for PR 15048 at commit

[GitHub] spark pull request #15051: [SPARK-17499][ML][MLLib] make the default params ...

2016-09-11 Thread WeichenXu123
Github user WeichenXu123 commented on a diff in the pull request: https://github.com/apache/spark/pull/15051#discussion_r78308116 --- Diff: R/pkg/R/mllib.R --- @@ -694,8 +694,8 @@ setMethod("predict", signature(object = "KMeansModel"), #' } #' @note spark.mlp since 2.1.0

[GitHub] spark issue #14388: [SPARK-16362][SQL] Support ArrayType and StructType in v...

2016-09-11 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/14388 @mallman Not yet. I am working on another PR recently. I will return back when that is solved. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark pull request #15051: [SPARK-17499][ML][MLLib] make the default params ...

2016-09-11 Thread WeichenXu123
Github user WeichenXu123 commented on a diff in the pull request: https://github.com/apache/spark/pull/15051#discussion_r78307552 --- Diff: R/pkg/R/mllib.R --- @@ -694,8 +694,8 @@ setMethod("predict", signature(object = "KMeansModel"), #' } #' @note spark.mlp since 2.1.0

[GitHub] spark issue #14947: [SPARK-17388][SQL] Support for inferring type date/times...

2016-09-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14947 **[Test build #65234 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65234/consoleFull)** for PR 14947 at commit

[GitHub] spark pull request #14947: [SPARK-17388][SQL] Support for inferring type dat...

2016-09-11 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/14947#discussion_r78306768 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/PartitioningUtils.scala --- @@ -307,20 +308,34 @@ object PartitioningUtils

[GitHub] spark issue #7266: [SPARK-8764][ML] string indexer should take option to han...

2016-09-11 Thread holdenk
Github user holdenk commented on the issue: https://github.com/apache/spark/pull/7266 @miro-balaz : This probably isn't the best place for a new feature request - but if you head over to the ASF JIRA you can create a new ticket and cc the people who worked on this. --- If your

[GitHub] spark pull request #14971: [SPARK-17410] [SPARK-17284] Move Hive-generated S...

2016-09-11 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/14971#discussion_r78305536 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/StatisticsSuite.scala --- @@ -259,6 +259,156 @@ class StatisticsSuite extends QueryTest with

[GitHub] spark pull request #14971: [SPARK-17410] [SPARK-17284] Move Hive-generated S...

2016-09-11 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/14971#discussion_r78305513 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/StatisticsSuite.scala --- @@ -259,6 +259,156 @@ class StatisticsSuite extends QueryTest with

[GitHub] spark issue #15048: [SPARK-17409] [SQL] Do Not Optimize Query in CTAS More T...

2016-09-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15048 **[Test build #65233 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65233/consoleFull)** for PR 15048 at commit

[GitHub] spark issue #14971: [SPARK-17410] [SPARK-17284] Move Hive-generated Stats In...

2016-09-11 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/14971 cc @hvanhovell @cloud-fan Now, the code is ready for review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark issue #14971: [SPARK-17410] [SPARK-17284] Move Hive-generated Stats In...

2016-09-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14971 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14971: [SPARK-17410] [SPARK-17284] Move Hive-generated Stats In...

2016-09-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14971 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65232/ Test PASSed. ---

[GitHub] spark issue #14971: [SPARK-17410] [SPARK-17284] Move Hive-generated Stats In...

2016-09-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14971 **[Test build #65232 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65232/consoleFull)** for PR 14971 at commit

[GitHub] spark issue #15045: [Spark Core][MINOR] fix "default partitioner cannot part...

2016-09-11 Thread WeichenXu123
Github user WeichenXu123 commented on the issue: https://github.com/apache/spark/pull/15045 jenkins test please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #15028: [SPARK-17336][PYSPARK] Fix appending multiple times to P...

2016-09-11 Thread holdenk
Github user holdenk commented on the issue: https://github.com/apache/spark/pull/15028 Since the search order is defined the old behavior probably worked cross versions (albeit in an ugly fashion) - I'll follow up with some checks for spark-perf and fix there if necessary since I

[GitHub] spark pull request #14947: [WIP][SPARK-17388][SQL] Support for inferring typ...

2016-09-11 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/14947#discussion_r78304894 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/PartitioningUtils.scala --- @@ -307,20 +308,34 @@ object PartitioningUtils

[GitHub] spark issue #14828: [SPARK-17258][SQL] Parse scientific decimal literals as ...

2016-09-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14828 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65230/ Test PASSed. ---

[GitHub] spark issue #14828: [SPARK-17258][SQL] Parse scientific decimal literals as ...

2016-09-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14828 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14828: [SPARK-17258][SQL] Parse scientific decimal literals as ...

2016-09-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14828 **[Test build #65230 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65230/consoleFull)** for PR 14828 at commit

[GitHub] spark issue #14083: [SPARK-16406][SQL] Improve performance of LogicalPlan.re...

2016-09-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14083 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14083: [SPARK-16406][SQL] Improve performance of LogicalPlan.re...

2016-09-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14083 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65231/ Test PASSed. ---

[GitHub] spark issue #14083: [SPARK-16406][SQL] Improve performance of LogicalPlan.re...

2016-09-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14083 **[Test build #65231 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65231/consoleFull)** for PR 14083 at commit

[GitHub] spark issue #15048: [SPARK-17409] [SQL] Do Not Optimize Query in CTAS More T...

2016-09-11 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/15048 @hvanhovell Sure, will do it. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14971: [SPARK-17410] [SPARK-17284] Move Hive-generated Stats In...

2016-09-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14971 **[Test build #65232 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65232/consoleFull)** for PR 14971 at commit

[GitHub] spark issue #15048: [SPARK-17409] [SQL] Do Not Optimize Query in CTAS More T...

2016-09-11 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/15048 @gatorsmile so should we check all commands? It might also be an idea to have `Command` extend `LeafNode` (and make children `final`). I think @davies did something similar for

[GitHub] spark issue #15053: [Doc] improve python API docstrings

2016-09-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15053 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request #15053: [Doc] improve python API docstrings

2016-09-11 Thread mortada
GitHub user mortada opened a pull request: https://github.com/apache/spark/pull/15053 [Doc] improve python API docstrings ## What changes were proposed in this pull request? a lot of the python API functions show example usage that is incomplete. The docstring shows output

[GitHub] spark issue #14828: [SPARK-17258][SQL] Parse scientific decimal literals as ...

2016-09-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14828 **[Test build #65230 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65230/consoleFull)** for PR 14828 at commit

[GitHub] spark issue #14083: [SPARK-16406][SQL] Improve performance of LogicalPlan.re...

2016-09-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14083 **[Test build #65231 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65231/consoleFull)** for PR 14083 at commit

[GitHub] spark issue #14083: [SPARK-16406][SQL] Improve performance of LogicalPlan.re...

2016-09-11 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/14083 @JoshRosen I have moved the implementation into `AttributeSeq`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark issue #15045: [Spark Core][MINOR] fix "default partitioner cannot part...

2016-09-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15045 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65227/ Test FAILed. ---

[GitHub] spark issue #15045: [Spark Core][MINOR] fix "default partitioner cannot part...

2016-09-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15045 **[Test build #65227 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65227/consoleFull)** for PR 15045 at commit

[GitHub] spark issue #15045: [Spark Core][MINOR] fix "default partitioner cannot part...

2016-09-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15045 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15052: [SPARK-17500][PySpark]Make DiskBytesSpilled metric in Py...

2016-09-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15052 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request #15052: [SPARK-17500][PySpark]Make DiskBytesSpilled metri...

2016-09-11 Thread djvulee
GitHub user djvulee opened a pull request: https://github.com/apache/spark/pull/15052 [SPARK-17500][PySpark]Make DiskBytesSpilled metric in PySpark shuffle right ## What changes were proposed in this pull request? The origin way increases the DiskBytesSpilled metric with

[GitHub] spark issue #14980: [SPARK-17317][SparkR] Add SparkR vignette

2016-09-11 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/14980 I think having another PR on the branch-2.0 is a good idea. Also should we have forward looking statements like [this](https://github.com/apache/spark/pull/14980/files#r5442) in the

[GitHub] spark pull request #14980: [SPARK-17317][SparkR] Add SparkR vignette

2016-09-11 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14980#discussion_r78301288 --- Diff: R/pkg/vignettes/sparkr-vignettes.Rmd --- @@ -0,0 +1,853 @@ +--- +title: "SparkR - Practical Guide" +output: + html_document:

[GitHub] spark pull request #14980: [SPARK-17317][SparkR] Add SparkR vignette

2016-09-11 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14980#discussion_r78301238 --- Diff: R/pkg/vignettes/sparkr-vignettes.Rmd --- @@ -0,0 +1,853 @@ +--- +title: "SparkR - Practical Guide" +output: + html_document:

[GitHub] spark pull request #14980: [SPARK-17317][SparkR] Add SparkR vignette

2016-09-11 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14980#discussion_r78301233 --- Diff: R/pkg/vignettes/sparkr-vignettes.Rmd --- @@ -0,0 +1,853 @@ +--- +title: "SparkR - Practical Guide" +output: + html_document:

[GitHub] spark pull request #15051: [SPARK-17499][ML][MLLib] make the default params ...

2016-09-11 Thread shivaram
Github user shivaram commented on a diff in the pull request: https://github.com/apache/spark/pull/15051#discussion_r78301160 --- Diff: R/pkg/R/mllib.R --- @@ -694,8 +694,8 @@ setMethod("predict", signature(object = "KMeansModel"), #' } #' @note spark.mlp since 2.1.0

[GitHub] spark pull request #15051: [SPARK-17499][ML][MLLib] make the default params ...

2016-09-11 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/15051#discussion_r78301071 --- Diff: R/pkg/R/mllib.R --- @@ -694,8 +694,8 @@ setMethod("predict", signature(object = "KMeansModel"), #' } #' @note spark.mlp since 2.1.0

[GitHub] spark issue #15051: [SPARK-17499][ML][MLLib] make the default params in spar...

2016-09-11 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/15051 thanks - could you add some tests that use these default values? (esp. layers as NULL) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark pull request #15051: [SPARK-17499][ML][MLLib] make the default params ...

2016-09-11 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/15051#discussion_r78301008 --- Diff: R/pkg/R/mllib.R --- @@ -694,8 +694,8 @@ setMethod("predict", signature(object = "KMeansModel"), #' } #' @note spark.mlp since 2.1.0

[GitHub] spark issue #15045: [Spark Core][MINOR] fix "default partitioner cannot part...

2016-09-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15045 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15045: [Spark Core][MINOR] fix "default partitioner cannot part...

2016-09-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15045 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65229/ Test PASSed. ---

[GitHub] spark issue #15045: [Spark Core][MINOR] fix "default partitioner cannot part...

2016-09-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15045 **[Test build #65229 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65229/consoleFull)** for PR 15045 at commit

[GitHub] spark pull request #15047: [SPARK-17495] [SQL] Add Hash capability semantica...

2016-09-11 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/15047#discussion_r78299559 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveHash.scala --- @@ -0,0 +1,145 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #15048: [SPARK-17409] [SQL] Do Not Optimize Query in CTAS...

2016-09-11 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/15048#discussion_r78299463 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/ddl.scala --- @@ -37,7 +38,9 @@ case class CreateTable(tableDesc:

[GitHub] spark pull request #15047: [SPARK-17495] [SQL] Add Hash capability semantica...

2016-09-11 Thread tejasapatil
Github user tejasapatil commented on a diff in the pull request: https://github.com/apache/spark/pull/15047#discussion_r78299323 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveHash.scala --- @@ -0,0 +1,145 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #15047: [SPARK-17495] [SQL] Add Hash capability semantica...

2016-09-11 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/15047#discussion_r78299210 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveHash.scala --- @@ -0,0 +1,145 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #15047: [SPARK-17495] [SQL] Add Hash capability semantica...

2016-09-11 Thread tejasapatil
Github user tejasapatil commented on a diff in the pull request: https://github.com/apache/spark/pull/15047#discussion_r78299106 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveHash.scala --- @@ -0,0 +1,145 @@ +/* + * Licensed to the Apache Software

[GitHub] spark issue #15051: [SPARK-17499][ML][MLLib] make the default params in spar...

2016-09-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15051 **[Test build #65228 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65228/consoleFull)** for PR 15051 at commit

[GitHub] spark issue #15051: [SPARK-17499][ML][MLLib] make the default params in spar...

2016-09-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15051 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65228/ Test PASSed. ---

[GitHub] spark issue #15051: [SPARK-17499][ML][MLLib] make the default params in spar...

2016-09-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15051 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #14644: [MESOS] Enable GPU support with Mesos

2016-09-11 Thread klueska
Github user klueska commented on a diff in the pull request: https://github.com/apache/spark/pull/14644#discussion_r78298850 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackend.scala --- @@ -103,6 +103,7 @@ private[spark]

[GitHub] spark issue #15051: [SPARK-17499][ML][MLLib] make the default params in spar...

2016-09-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15051 **[Test build #65228 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65228/consoleFull)** for PR 15051 at commit

[GitHub] spark issue #15045: [Spark Core][MINOR] fix "default partitioner cannot part...

2016-09-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15045 **[Test build #65229 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65229/consoleFull)** for PR 15045 at commit

[GitHub] spark pull request #14644: [MESOS] Enable GPU support with Mesos

2016-09-11 Thread tnachen
Github user tnachen commented on a diff in the pull request: https://github.com/apache/spark/pull/14644#discussion_r78298417 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackend.scala --- @@ -103,6 +103,7 @@ private[spark]

[GitHub] spark issue #14980: [SPARK-17317][SparkR] Add SparkR vignette

2016-09-11 Thread shivaram
Github user shivaram commented on the issue: https://github.com/apache/spark/pull/14980 Yeah I think it'll be good to do a separate PR and make sure it can build corresponding to the Scala code in branch-2.0 etc. But lets do it after all the comments here are addressed and this is

[GitHub] spark pull request #15048: [SPARK-17409] [SQL] Do Not Optimize Query in CTAS...

2016-09-11 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/15048#discussion_r78298129 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/ddl.scala --- @@ -37,7 +38,9 @@ case class CreateTable(tableDesc:

[GitHub] spark issue #15047: [SPARK-17495] [SQL] Add Hash capability semantically equ...

2016-09-11 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/15047 @tejasapatil this looks pretty good overal. I left a few comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request #15047: [SPARK-17495] [SQL] Add Hash capability semantica...

2016-09-11 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/15047#discussion_r78297960 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveHash.scala --- @@ -0,0 +1,145 @@ +/* + * Licensed to the Apache Software

[GitHub] spark issue #14971: [SPARK-17410] [SPARK-17284] Move Hive-generated Stats In...

2016-09-11 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/14971 ... Very surprised about Hive... Any `ALTER TABLE SET/UNSET TBLPROPERTIES` statements can invalidate the Hive-generated statistics... ```Scala hiveClient.runSqlHive(s"ANALYZE TABLE

  1   2   >