[GitHub] spark issue #15432: [SPARK-17854][SQL] rand/randn allows null/long as input ...

2016-10-12 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/15432 @gatorsmile Yes (for https://github.com/apache/spark/pull/15432#issuecomment-253291901), it is and sure, I should add more tests. I actually intended to show how it looks like. --- If your pro

[GitHub] spark issue #15048: [SPARK-17409] [SQL] Do Not Optimize Query in CTAS More T...

2016-10-12 Thread yhuai
Github user yhuai commented on the issue: https://github.com/apache/spark/pull/15048 Also, can we add a test for hive tables? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enab

[GitHub] spark pull request #15429: [SPARK-17840] [DOCS] Add some pointers for wiki/C...

2016-10-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/15429 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark issue #15452: minor doc fix for Row.scala

2016-10-12 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/15452 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark issue #15429: [SPARK-17840] [DOCS] Add some pointers for wiki/CONTRIBU...

2016-10-12 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/15429 Thanks - merging in master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishe

[GitHub] spark issue #15404: Branch 2.0

2016-10-12 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/15404 @yintengfei please close this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled an

[GitHub] spark issue #15432: [SPARK-17854][SQL] rand/randn allows null/long as input ...

2016-10-12 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/15432 Since you are running mysql, the output of rand(0) is the same as rand(null)? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If y

[GitHub] spark issue #15432: [SPARK-17854][SQL] rand/randn allows null/long as input ...

2016-10-12 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/15432 Not sure whether you realize it. Since this PR changes the input parm of `Rand` and `Randn`, you also changes the external support. Now, users can do something like ```SQL select

[GitHub] spark issue #14690: [SPARK-16980][SQL] Load only catalog table partition met...

2016-10-12 Thread mallman
Github user mallman commented on the issue: https://github.com/apache/spark/pull/14690 I'm testing this patch on a couple of tables internally with on the order of 10k partitions. Performance is much slower than it should be. I'm investigating. --- If your project is set up for it,

[GitHub] spark issue #15048: [SPARK-17409] [SQL] Do Not Optimize Query in CTAS More T...

2016-10-12 Thread yhuai
Github user yhuai commented on the issue: https://github.com/apache/spark/pull/15048 Also, another good test for this is ``` val df = sql("select 0 as id") df.registerTempTable("foo") val df2 = sql("""select * from foo group by id""") df2.write.mode("overwrite").sav

[GitHub] spark issue #15048: [SPARK-17409] [SQL] Do Not Optimize Query in CTAS More T...

2016-10-12 Thread yhuai
Github user yhuai commented on the issue: https://github.com/apache/spark/pull/15048 Thanks! btw, does this patch cover hive tables? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featu

[GitHub] spark issue #15173: [SPARK-15698][SQL][Streaming][Follw-up]Fix FileStream so...

2016-10-12 Thread zsxwing
Github user zsxwing commented on the issue: https://github.com/apache/spark/pull/15173 @tdas this is is just following a cleanup PR #14678 which only exists in master. So I didn't merge it to 2.0. --- If your project is set up for it, you can reply to this email and have your reply a

[GitHub] spark issue #15048: [SPARK-17409] [SQL] Do Not Optimize Query in CTAS More T...

2016-10-12 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/15048 Yeah. We should backport it to 2.0 Yeah. It affects both data source tables and hive serde tables. To fix it in Spark 2.0, we need to rewrite the fix since Spark 2.0 does not have a unif

[GitHub] spark pull request #14963: [SPARK-16992][PYSPARK] Virtualenv for Pylint and ...

2016-10-12 Thread holdenk
Github user holdenk commented on a diff in the pull request: https://github.com/apache/spark/pull/14963#discussion_r83062446 --- Diff: dev/sphinx-report.txt --- @@ -0,0 +1,13 @@ +sphinx-build -b html -d _build/doctrees -a -W . _build/html --- End diff -- I don't be

[GitHub] spark issue #14963: [SPARK-16992][PYSPARK] Virtualenv for Pylint and pep8 in...

2016-10-12 Thread holdenk
Github user holdenk commented on the issue: https://github.com/apache/spark/pull/14963 Another minor question is running the lint script now produces a lot of output about the package versions - it might make sense to silence this output except on failures (as we do with the actually

[GitHub] spark issue #15048: [SPARK-17409] [SQL] Do Not Optimize Query in CTAS More T...

2016-10-12 Thread yhuai
Github user yhuai commented on the issue: https://github.com/apache/spark/pull/15048 @gatorsmile Also, does it affect `CTAS` for creating a hive serde table? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request #14690: [SPARK-16980][SQL] Load only catalog table partit...

2016-10-12 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/14690#discussion_r83061877 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/DataSourceScanExec.scala --- @@ -225,13 +225,19 @@ case class FileSourceScanExec( }

[GitHub] spark pull request #15307: [SPARK-17731][SQL][STREAMING] Metrics for structu...

2016-10-12 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/15307#discussion_r83060899 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StatefulAggregate.scala --- @@ -86,7 +93,13 @@ case class StateStoreSaveExec(

[GitHub] spark issue #14690: [SPARK-16980][SQL] Load only catalog table partition met...

2016-10-12 Thread davies
Github user davies commented on the issue: https://github.com/apache/spark/pull/14690 Workaround should be reasonable to unblock this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #15446: [SPARK-17882][SparkR] Fix swallowed exception in RBacken...

2016-10-12 Thread jrshust
Github user jrshust commented on the issue: https://github.com/apache/spark/pull/15446 Hey thanks all. This sounds good to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] spark issue #14963: [SPARK-16992][PYSPARK] Virtualenv for Pylint and pep8 in...

2016-10-12 Thread holdenk
Github user holdenk commented on the issue: https://github.com/apache/spark/pull/14963 So looking at https://github.com/ContinuumIO/anaconda-issues/issues/305 it seems like we might cause problems for Conda users (and I've setup Conda locally to verify that this is indeed the case wit

[GitHub] spark pull request #9766: [SPARK-11775][PYSPARK][SQL] Allow PySpark to regis...

2016-10-12 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/9766#discussion_r83057793 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/UDFRegistration.scala --- @@ -414,6 +418,84 @@ class UDFRegistration private[sql] (functionRegistry:

[GitHub] spark issue #15446: [SPARK-17882][SparkR] Fix swallowed exception in RBacken...

2016-10-12 Thread shivaram
Github user shivaram commented on the issue: https://github.com/apache/spark/pull/15446 @felixcheung Resolving the JIRA and assigning it to @jrshust sounds good to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request #9766: [SPARK-11775][PYSPARK][SQL] Allow PySpark to regis...

2016-10-12 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/9766#discussion_r83056944 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/UDFRegistration.scala --- @@ -414,6 +418,84 @@ class UDFRegistration private[sql] (functionRegistry:

[GitHub] spark pull request #9766: [SPARK-11775][PYSPARK][SQL] Allow PySpark to regis...

2016-10-12 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/9766#discussion_r83056792 --- Diff: sql/core/src/main/java/org/apache/spark/sql/test/JavaStringLength.java --- @@ -0,0 +1,30 @@ +/* + * Licensed to the Apache Software Foundat

[GitHub] spark pull request #9766: [SPARK-11775][PYSPARK][SQL] Allow PySpark to regis...

2016-10-12 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/9766#discussion_r83056607 --- Diff: python/pyspark/sql/context.py --- @@ -202,6 +202,32 @@ def registerFunction(self, name, f, returnType=StringType()): """

[GitHub] spark pull request #9766: [SPARK-11775][PYSPARK][SQL] Allow PySpark to regis...

2016-10-12 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/9766#discussion_r83057132 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/UDFRegistration.scala --- @@ -414,6 +418,84 @@ class UDFRegistration private[sql] (functionRegistry:

[GitHub] spark issue #15446: [SPARK-17882][SparkR] Fix swallowed exception in RBacken...

2016-10-12 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/15446 Hi @jrshust as mentioned above this fix is also included in the other earlier PR, which has just been merged. We appreciate your effort to fix this issue, and having a JIRA on this woul

[GitHub] spark issue #15432: [SPARK-17854][SQL] rand/randn allows null/long as input ...

2016-10-12 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/15432 FWIW, the cases below are fine in MySQL: ```sql mysql> SELECT RAND(CAST(2 AS UNSIGNED)); +---+ | RAND(CAST(2 AS UNSIGNED)) | +-

[GitHub] spark pull request #15375: [SPARK-17790][SPARKR] Support for parallelizing R...

2016-10-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/15375 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request #11336: [SPARK-9325][SPARK-R] collect() head() and show()...

2016-10-12 Thread olarayej
Github user olarayej commented on a diff in the pull request: https://github.com/apache/spark/pull/11336#discussion_r83057347 --- Diff: R/pkg/R/functions.R --- @@ -2836,7 +2845,11 @@ setMethod("lpad", signature(x = "Column", len = "numeric", pad = "character"), setMethod("rand

[GitHub] spark issue #11336: [SPARK-9325][SPARK-R] collect() head() and show() for Co...

2016-10-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/11336 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66832/ Test FAILed. ---

[GitHub] spark issue #11336: [SPARK-9325][SPARK-R] collect() head() and show() for Co...

2016-10-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/11336 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #11336: [SPARK-9325][SPARK-R] collect() head() and show() for Co...

2016-10-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/11336 **[Test build #66832 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66832/consoleFull)** for PR 11336 at commit [`20e53e8`](https://github.com/apache/spark/commit/

[GitHub] spark issue #11336: [SPARK-9325][SPARK-R] collect() head() and show() for Co...

2016-10-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/11336 **[Test build #66832 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66832/consoleFull)** for PR 11336 at commit [`20e53e8`](https://github.com/apache/spark/commit/2

[GitHub] spark issue #15375: [SPARK-17790][SPARKR] Support for parallelizing R data.f...

2016-10-12 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/15375 everything passed, I'm merging to this master and branch-2.0 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark issue #15445: [SPARK-17817][PySpark][FOLLOWUP] PySpark RDD Repartition...

2016-10-12 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/15445 Do you have benchmark on this change? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #15389: [SPARK-17817][PySpark] PySpark RDD Repartitioning Result...

2016-10-12 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/15389 @rxin sorry, it's me and I thought commit history and JIRA would show who did it - I'll be sure to add a note the next time. @davies sorry I'll make sure to ask to wait a bit longer for you t

[GitHub] spark pull request #15449: [SPARK-17884][SQL] To resolve Null pointer except...

2016-10-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/15449 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark issue #15452: minor doc fix for Row.scala

2016-10-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15452 **[Test build #3334 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3334/consoleFull)** for PR 15452 at commit [`5084746`](https://github.com/apache/spark/commit/

[GitHub] spark pull request #15409: [Spark-14761][SQL] Reject invalid join methods wh...

2016-10-12 Thread srinathshankar
Github user srinathshankar commented on a diff in the pull request: https://github.com/apache/spark/pull/15409#discussion_r83054921 --- Diff: python/pyspark/sql/dataframe.py --- @@ -640,25 +640,24 @@ def join(self, other, on=None, how=None): if on is not None and not is

[GitHub] spark issue #15451: [BUILD] Closing stale PRs

2016-10-12 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/15451 Merging in master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or i

[GitHub] spark issue #15452: minor doc fix for Row.scala

2016-10-12 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/15452 Jenkins, test this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #15048: [SPARK-17409] [SQL] Do Not Optimize Query in CTAS More T...

2016-10-12 Thread yhuai
Github user yhuai commented on the issue: https://github.com/apache/spark/pull/15048 @gatorsmile We should also backport this to branch 2.0, right? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark issue #15449: [SPARK-17884][SQL] To resolve Null pointer exception whe...

2016-10-12 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/15449 Thanks - merging in master/branch-2.0. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enable

[GitHub] spark pull request #15409: [Spark-14761][SQL] Reject invalid join methods wh...

2016-10-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/15409 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark issue #15400: [SPARK-11272] [Web UI] Add support for downloading event...

2016-10-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15400 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #15400: [SPARK-11272] [Web UI] Add support for downloading event...

2016-10-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15400 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66824/ Test PASSed. ---

[GitHub] spark issue #15400: [SPARK-11272] [Web UI] Add support for downloading event...

2016-10-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15400 **[Test build #66824 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66824/consoleFull)** for PR 15400 at commit [`b02e25d`](https://github.com/apache/spark/commit/

[GitHub] spark issue #15409: [Spark-14761][SQL] Reject invalid join methods when join...

2016-10-12 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/15409 @srinathshankar brought up a good point. Since it is a small change and doesnt' impact correctness, I'm going to merge this in master. @srinathshankar when you add the Python API for crossjoin,

[GitHub] spark issue #15452: minor doc fix for Row.scala

2016-10-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15452 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

[GitHub] spark issue #14690: [SPARK-16980][SQL] Load only catalog table partition met...

2016-10-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14690 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66828/ Test FAILed. ---

[GitHub] spark issue #14690: [SPARK-16980][SQL] Load only catalog table partition met...

2016-10-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14690 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #14690: [SPARK-16980][SQL] Load only catalog table partition met...

2016-10-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14690 **[Test build #66828 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66828/consoleFull)** for PR 14690 at commit [`2a696d7`](https://github.com/apache/spark/commit/

[GitHub] spark pull request #15409: [Spark-14761][SQL] Reject invalid join methods wh...

2016-10-12 Thread srinathshankar
Github user srinathshankar commented on a diff in the pull request: https://github.com/apache/spark/pull/15409#discussion_r83050677 --- Diff: python/pyspark/sql/dataframe.py --- @@ -640,25 +640,24 @@ def join(self, other, on=None, how=None): if on is not None and not is

[GitHub] spark pull request #15452: minor doc fix for Row.scala

2016-10-12 Thread david-weiluo-ren
GitHub user david-weiluo-ren opened a pull request: https://github.com/apache/spark/pull/15452 minor doc fix for Row.scala ## What changes were proposed in this pull request? minor doc fix for "getAnyValAs" in class Row ## How was this patch tested? None.

[GitHub] spark issue #15249: [SPARK-17675] [CORE] Expand Blacklist for TaskSets

2016-10-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15249 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66822/ Test PASSed. ---

[GitHub] spark issue #15249: [SPARK-17675] [CORE] Expand Blacklist for TaskSets

2016-10-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15249 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #15249: [SPARK-17675] [CORE] Expand Blacklist for TaskSets

2016-10-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15249 **[Test build #66822 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66822/consoleFull)** for PR 15249 at commit [`4501e6c`](https://github.com/apache/spark/commit/

[GitHub] spark issue #15436: [SPARK-17875] [BUILD] Remove unneeded direct dependence ...

2016-10-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15436 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66826/ Test FAILed. ---

[GitHub] spark issue #15436: [SPARK-17875] [BUILD] Remove unneeded direct dependence ...

2016-10-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15436 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #15436: [SPARK-17875] [BUILD] Remove unneeded direct dependence ...

2016-10-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15436 **[Test build #66826 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66826/consoleFull)** for PR 15436 at commit [`ecc241e`](https://github.com/apache/spark/commit/

[GitHub] spark issue #9973: [SPARK-11989][SQL] Only use commit in JDBC data source if...

2016-10-12 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/9973 You're right but lots of output semantics are per partition. I don't think we can do the update in one transaction no matter what. This improves the behavior in many cases so is worthwhile behavior bu

[GitHub] spark pull request #9973: [SPARK-11989][SQL] Only use commit in JDBC data so...

2016-10-12 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/9973#discussion_r83049327 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala --- @@ -175,14 +187,18 @@ object JdbcUtils extends Loggi

[GitHub] spark pull request #9973: [SPARK-11989][SQL] Only use commit in JDBC data so...

2016-10-12 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/9973#discussion_r83048584 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala --- @@ -175,14 +187,18 @@ object JdbcUtils extends Loggi

[GitHub] spark issue #15432: [SPARK-17854][SQL] rand/randn allows null/long as input ...

2016-10-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15432 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #15432: [SPARK-17854][SQL] rand/randn allows null/long as input ...

2016-10-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15432 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66821/ Test PASSed. ---

[GitHub] spark issue #15432: [SPARK-17854][SQL] rand/randn allows null/long as input ...

2016-10-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15432 **[Test build #66821 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66821/consoleFull)** for PR 15432 at commit [`a99f674`](https://github.com/apache/spark/commit/

[GitHub] spark issue #15448: [SPARK-17108][SQL]: Fix BIGINT and INT comparison failur...

2016-10-12 Thread weiqingy
Github user weiqingy commented on the issue: https://github.com/apache/spark/pull/15448 Hi, @hvanhovell Thanks for the quick feedback. Yes, I will update the PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pro

[GitHub] spark issue #15410: [SPARK-17843][Web UI] Indicate event logs pending for pr...

2016-10-12 Thread andrewor14
Github user andrewor14 commented on the issue: https://github.com/apache/spark/pull/15410 ok to test I think the idea is good, but it would be a better UX if we display the pending applications as rows in the existing table (or a new one) and indicate there that it's still be

[GitHub] spark pull request #15410: [SPARK-17843][Web UI] Indicate event logs pending...

2016-10-12 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/15410#discussion_r83044768 --- Diff: core/src/main/scala/org/apache/spark/deploy/history/HistoryPage.scala --- @@ -38,6 +39,13 @@ private[history] class HistoryPage(parent: History

[GitHub] spark issue #15446: [SPARK-17882][SparkR] Fix swallowed exception in RBacken...

2016-10-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15446 **[Test build #66831 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66831/consoleFull)** for PR 15446 at commit [`083f57a`](https://github.com/apache/spark/commit/0

[GitHub] spark issue #15172: [SPARK-13331] AES support for over-the-wire encryption

2016-10-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15172 **[Test build #66818 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66818/consoleFull)** for PR 15172 at commit [`64b8f33`](https://github.com/apache/spark/commit/

[GitHub] spark issue #15396: [SPARK-14804][Spark][Graphx] Fix checkpointing of Vertex...

2016-10-12 Thread andrewor14
Github user andrewor14 commented on the issue: https://github.com/apache/spark/pull/15396 Looks good. I left a suggestion that I think will make the code cleaner. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pr

[GitHub] spark issue #15446: [SPARK-17882][SparkR] Fix swallowed exception in RBacken...

2016-10-12 Thread shivaram
Github user shivaram commented on the issue: https://github.com/apache/spark/pull/15446 Jenkins, test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wish

[GitHub] spark pull request #15396: [SPARK-14804][Spark][Graphx] Fix checkpointing of...

2016-10-12 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/15396#discussion_r83043442 --- Diff: core/src/main/scala/org/apache/spark/rdd/RDD.scala --- @@ -1589,7 +1589,8 @@ abstract class RDD[T: ClassTag]( * This is introduced as an

[GitHub] spark pull request #15433: [SPARK-17822] Use weak reference in JVMObjectTrac...

2016-10-12 Thread shivaram
Github user shivaram commented on a diff in the pull request: https://github.com/apache/spark/pull/15433#discussion_r83043023 --- Diff: core/src/main/scala/org/apache/spark/api/r/RBackendHandler.scala --- @@ -263,18 +264,19 @@ private[r] object JVMObjectTracker { // TO

[GitHub] spark issue #14963: [SPARK-16992][PYSPARK] Virtualenv for Pylint and pep8 in...

2016-10-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14963 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66819/ Test PASSed. ---

[GitHub] spark issue #14963: [SPARK-16992][PYSPARK] Virtualenv for Pylint and pep8 in...

2016-10-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14963 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #15230: [SPARK-17657] [SQL] Disallow Users to Change Table Type

2016-10-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15230 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #15230: [SPARK-17657] [SQL] Disallow Users to Change Table Type

2016-10-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15230 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66823/ Test PASSed. ---

[GitHub] spark pull request #15396: [SPARK-14804][Spark][Graphx] Fix checkpointing of...

2016-10-12 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/15396#discussion_r83042522 --- Diff: core/src/main/scala/org/apache/spark/rdd/RDD.scala --- @@ -1589,7 +1589,8 @@ abstract class RDD[T: ClassTag]( * This is introduced as an

[GitHub] spark issue #14963: [SPARK-16992][PYSPARK] Virtualenv for Pylint and pep8 in...

2016-10-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14963 **[Test build #66819 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66819/consoleFull)** for PR 14963 at commit [`9e5d8d4`](https://github.com/apache/spark/commit/

[GitHub] spark issue #15230: [SPARK-17657] [SQL] Disallow Users to Change Table Type

2016-10-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15230 **[Test build #66823 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66823/consoleFull)** for PR 15230 at commit [`55a9976`](https://github.com/apache/spark/commit/

[GitHub] spark issue #15406: [Spark-17745][ml][PySpark] update NB python api - add we...

2016-10-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15406 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66829/ Test PASSed. ---

[GitHub] spark issue #15406: [Spark-17745][ml][PySpark] update NB python api - add we...

2016-10-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15406 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #15406: [Spark-17745][ml][PySpark] update NB python api - add we...

2016-10-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15406 **[Test build #66829 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66829/consoleFull)** for PR 15406 at commit [`186b2ea`](https://github.com/apache/spark/commit/

[GitHub] spark pull request #15408: [SPARK-17839][CORE] Use Nio's directbuffer instea...

2016-10-12 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/15408#discussion_r83040126 --- Diff: core/src/main/java/org/apache/spark/io/NioBufferedFileInputStream.java --- @@ -72,30 +74,35 @@ private boolean refill() throws IOException {

[GitHub] spark issue #15408: [SPARK-17839][CORE] Use Nio's directbuffer instead of Bu...

2016-10-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15408 **[Test build #66830 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66830/consoleFull)** for PR 15408 at commit [`439cead`](https://github.com/apache/spark/commit/4

[GitHub] spark issue #13194: [SPARK-15402] [ML] [PySpark] PySpark ml.evaluation shoul...

2016-10-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13194 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #13194: [SPARK-15402] [ML] [PySpark] PySpark ml.evaluation shoul...

2016-10-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13194 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/66827/ Test PASSed. ---

[GitHub] spark issue #13194: [SPARK-15402] [ML] [PySpark] PySpark ml.evaluation shoul...

2016-10-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13194 **[Test build #66827 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66827/consoleFull)** for PR 13194 at commit [`cc85a92`](https://github.com/apache/spark/commit/

[GitHub] spark pull request #15408: [SPARK-17839][CORE] Use Nio's directbuffer instea...

2016-10-12 Thread sitalkedia
Github user sitalkedia commented on a diff in the pull request: https://github.com/apache/spark/pull/15408#discussion_r83038562 --- Diff: core/src/main/java/org/apache/spark/io/NioBufferedFileInputStream.java --- @@ -0,0 +1,132 @@ +/* + * Licensed under the Apache License,

[GitHub] spark issue #15394: [SPARK-17749][ML] One pass solver for Weighted Least Squ...

2016-10-12 Thread sethah
Github user sethah commented on the issue: https://github.com/apache/spark/pull/15394 Thanks a lot @yanboliang for your review. I will get to these today. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project do

[GitHub] spark issue #15406: [Spark-17745][ml][PySpark] update NB python api - add we...

2016-10-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15406 **[Test build #66829 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66829/consoleFull)** for PR 15406 at commit [`186b2ea`](https://github.com/apache/spark/commit/1

[GitHub] spark pull request #14690: [SPARK-16980][SQL] Load only catalog table partit...

2016-10-12 Thread mallman
Github user mallman commented on a diff in the pull request: https://github.com/apache/spark/pull/14690#discussion_r83036315 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/PruneFileSourcePartitions.scala --- @@ -0,0 +1,72 @@ +/* + * Licensed t

[GitHub] spark issue #14690: [SPARK-16980][SQL] Load only catalog table partition met...

2016-10-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14690 **[Test build #66828 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/66828/consoleFull)** for PR 14690 at commit [`2a696d7`](https://github.com/apache/spark/commit/2

[GitHub] spark pull request #15406: [Spark-17745][ml][PySpark] update NB python api -...

2016-10-12 Thread WeichenXu123
Github user WeichenXu123 commented on a diff in the pull request: https://github.com/apache/spark/pull/15406#discussion_r83033809 --- Diff: python/pyspark/ml/classification.py --- @@ -1032,6 +1032,16 @@ class NaiveBayes(JavaEstimator, HasFeaturesCol, HasLabelCol, HasPredictionCol,

[GitHub] spark issue #14690: [SPARK-16980][SQL] Load only catalog table partition met...

2016-10-12 Thread mallman
Github user mallman commented on the issue: https://github.com/apache/spark/pull/14690 I updated the description of this PR to reflect the workaround for the Hive/Parquet case-sensitivity issue. Do we need a similar workaround for ORC? --- If your project is set up for it, y

[GitHub] spark pull request #15394: [SPARK-17749][ML] One pass solver for Weighted Le...

2016-10-12 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/15394#discussion_r82996998 --- Diff: mllib/src/test/scala/org/apache/spark/ml/optim/WeightedLeastSquaresSuite.scala --- @@ -132,24 +197,234 @@ class WeightedLeastSquaresSuite exten

<    1   2   3   4   5   6   7   >