[GitHub] spark issue #15764: [SPARK-18217] [SQL] Disallow creating permanent views ba...

2016-11-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15764 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #15764: [SPARK-18217] [SQL] Disallow creating permanent views ba...

2016-11-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15764 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68107/ Test PASSed. ---

[GitHub] spark issue #15764: [SPARK-18217] [SQL] Disallow creating permanent views ba...

2016-11-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15764 **[Test build #68107 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68107/consoleFull)** for PR 15764 at commit [`695110f`](https://github.com/apache/spark/commit/

[GitHub] spark issue #15693: [SPARK-18125][SQL] Fix a compilation error in codegen du...

2016-11-03 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/15693 @kiszk the part of generated codes are posted as follows. Before this patch: Notice that line 239 `funcResult3 = value4._2();`, `value4` cannot be accessed. /* 288 */

[GitHub] spark issue #15751: [SPARK-18246][SQL] Throws an exception before execution ...

2016-11-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15751 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #15751: [SPARK-18246][SQL] Throws an exception before execution ...

2016-11-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15751 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68105/ Test PASSed. ---

[GitHub] spark issue #15751: [SPARK-18246][SQL] Throws an exception before execution ...

2016-11-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15751 **[Test build #68105 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68105/consoleFull)** for PR 15751 at commit [`5e87b12`](https://github.com/apache/spark/commit/

[GitHub] spark issue #15410: [SPARK-17843][Web UI] Indicate event logs pending for pr...

2016-11-03 Thread vijoshi
Github user vijoshi commented on the issue: https://github.com/apache/spark/pull/15410 @tgravescs @andrewor14 - any outstanding concerns with this change, please let me know? Can this merge? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request #15432: [SPARK-17854][SQL] rand/randn allows null/long as...

2016-11-03 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/15432#discussion_r86495088 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala --- @@ -1728,4 +1728,29 @@ class DataFrameSuite extends QueryTest with Share

[GitHub] spark issue #15480: [SPARK-16845][SQL] `GeneratedClass$SpecificOrdering` gro...

2016-11-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15480 **[Test build #68113 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68113/consoleFull)** for PR 15480 at commit [`1ae9935`](https://github.com/apache/spark/commit/1

[GitHub] spark issue #15480: [SPARK-16845][SQL] `GeneratedClass$SpecificOrdering` gro...

2016-11-03 Thread lw-lin
Github user lw-lin commented on the issue: https://github.com/apache/spark/pull/15480 Jenkins retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishe

[GitHub] spark issue #15314: [SPARK-17747][ML] WeightCol support non-double numeric d...

2016-11-03 Thread zhengruifeng
Github user zhengruifeng commented on the issue: https://github.com/apache/spark/pull/15314 @sethah Updated. Thanks for reviewing! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featur

[GitHub] spark pull request #15480: [SPARK-16845][SQL] `GeneratedClass$SpecificOrderi...

2016-11-03 Thread lw-lin
Github user lw-lin commented on a diff in the pull request: https://github.com/apache/spark/pull/15480#discussion_r86494742 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala --- @@ -537,7 +537,6 @@ class CodegenContext {

[GitHub] spark issue #15671: [SPARK-18206][ML]Add instrumentation logs to ML training...

2016-11-03 Thread zhengruifeng
Github user zhengruifeng commented on the issue: https://github.com/apache/spark/pull/15671 @jkbradley Updated --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #11105: [SPARK-12469][CORE] Data Property accumulators for Spark

2016-11-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/11105 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #11105: [SPARK-12469][CORE] Data Property accumulators for Spark

2016-11-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/11105 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68110/ Test FAILed. ---

[GitHub] spark issue #11105: [SPARK-12469][CORE] Data Property accumulators for Spark

2016-11-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/11105 **[Test build #68110 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68110/consoleFull)** for PR 11105 at commit [`c41f502`](https://github.com/apache/spark/commit/

[GitHub] spark issue #15432: [SPARK-17854][SQL] rand/randn allows null/long as input ...

2016-11-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15432 **[Test build #68108 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68108/consoleFull)** for PR 15432 at commit [`a523302`](https://github.com/apache/spark/commit/

[GitHub] spark issue #15432: [SPARK-17854][SQL] rand/randn allows null/long as input ...

2016-11-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15432 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #15432: [SPARK-17854][SQL] rand/randn allows null/long as input ...

2016-11-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15432 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68108/ Test FAILed. ---

[GitHub] spark pull request #15764: [SPARK-18217] [SQL] Disallow creating permanent v...

2016-11-03 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/15764#discussion_r86494337 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala --- @@ -131,6 +131,26 @@ case class CreateViewCommand( s"speci

[GitHub] spark pull request #15764: [SPARK-18217] [SQL] Disallow creating permanent v...

2016-11-03 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/15764#discussion_r86493888 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala --- @@ -923,6 +923,24 @@ class SessionCatalog( }

[GitHub] spark pull request #11105: [SPARK-12469][CORE] Data Property accumulators fo...

2016-11-03 Thread holdenk
Github user holdenk commented on a diff in the pull request: https://github.com/apache/spark/pull/11105#discussion_r86493902 --- Diff: core/src/main/scala/org/apache/spark/util/AccumulatorV2.scala --- @@ -136,15 +181,92 @@ abstract class AccumulatorV2[IN, OUT] extends Serializable

[GitHub] spark pull request #15764: [SPARK-18217] [SQL] Disallow creating permanent v...

2016-11-03 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/15764#discussion_r86493863 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala --- @@ -923,6 +923,24 @@ class SessionCatalog( }

[GitHub] spark pull request #15764: [SPARK-18217] [SQL] Disallow creating permanent v...

2016-11-03 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/15764#discussion_r86493730 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala --- @@ -131,6 +131,26 @@ case class CreateViewCommand( s"speci

[GitHub] spark pull request #15764: [SPARK-18217] [SQL] Disallow creating permanent v...

2016-11-03 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/15764#discussion_r86493701 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala --- @@ -131,6 +131,26 @@ case class CreateViewCommand( s"speci

[GitHub] spark pull request #15764: [SPARK-18217] [SQL] Disallow creating permanent v...

2016-11-03 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/15764#discussion_r86493685 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala --- @@ -131,6 +131,26 @@ case class CreateViewCommand( s"speci

[GitHub] spark pull request #15754: [SPARK-18200][GRAPHX][FOLLOW-UP] Support zero as ...

2016-11-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/15754 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark issue #15764: [SPARK-18217] [SQL] Disallow creating permanent views ba...

2016-11-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15764 **[Test build #68112 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68112/consoleFull)** for PR 15764 at commit [`7100a8f`](https://github.com/apache/spark/commit/7

[GitHub] spark issue #15754: [SPARK-18200][GRAPHX][FOLLOW-UP] Support zero as an init...

2016-11-03 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/15754 Merging in master/2.1/2.0. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #15751: [SPARK-18246][SQL] Throws an exception before execution ...

2016-11-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15751 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68104/ Test PASSed. ---

[GitHub] spark issue #15751: [SPARK-18246][SQL] Throws an exception before execution ...

2016-11-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15751 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #15751: [SPARK-18246][SQL] Throws an exception before execution ...

2016-11-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15751 **[Test build #68111 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68111/consoleFull)** for PR 15751 at commit [`d75c11e`](https://github.com/apache/spark/commit/d

[GitHub] spark pull request #11105: [SPARK-12469][CORE] Data Property accumulators fo...

2016-11-03 Thread holdenk
Github user holdenk commented on a diff in the pull request: https://github.com/apache/spark/pull/11105#discussion_r86493318 --- Diff: core/src/main/scala/org/apache/spark/util/AccumulatorV2.scala --- @@ -136,15 +181,92 @@ abstract class AccumulatorV2[IN, OUT] extends Serializable

[GitHub] spark issue #15751: [SPARK-18246][SQL] Throws an exception before execution ...

2016-11-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15751 **[Test build #68104 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68104/consoleFull)** for PR 15751 at commit [`370aee0`](https://github.com/apache/spark/commit/

[GitHub] spark issue #11105: [SPARK-12469][CORE] Data Property accumulators for Spark

2016-11-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/11105 **[Test build #68110 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68110/consoleFull)** for PR 11105 at commit [`c41f502`](https://github.com/apache/spark/commit/c

[GitHub] spark pull request #11105: [SPARK-12469][CORE] Data Property accumulators fo...

2016-11-03 Thread holdenk
Github user holdenk commented on a diff in the pull request: https://github.com/apache/spark/pull/11105#discussion_r86492811 --- Diff: core/src/test/scala/org/apache/spark/DataPropertyAccumulatorSuite.scala --- @@ -0,0 +1,383 @@ +/* + * Licensed to the Apache Software Found

[GitHub] spark pull request #15432: [SPARK-17854][SQL] rand/randn allows null/long as...

2016-11-03 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/15432#discussion_r86492775 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala --- @@ -1728,4 +1728,29 @@ class DataFrameSuite extends QueryTest with SharedSQLCon

[GitHub] spark issue #14750: [SPARK-17183][SQL] put hive serde table schema to table ...

2016-11-03 Thread ericl
Github user ericl commented on the issue: https://github.com/apache/spark/pull/14750 Could you also verify that https://github.com/apache/spark/blob/90d3b91f4cb59d84fea7105d54ef8c87a7d5c6a2/sql/hive/src/test/scala/org/apache/spark/sql/hive/PartitionedTablePerfStatsSuite.scala#L108 wor

[GitHub] spark pull request #15764: [SPARK-18217] [SQL] Disallow creating permanent v...

2016-11-03 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/15764#discussion_r86491722 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala --- @@ -709,10 +709,13 @@ case class LocalL

[GitHub] spark pull request #11105: [SPARK-12469][CORE] Data Property accumulators fo...

2016-11-03 Thread holdenk
Github user holdenk commented on a diff in the pull request: https://github.com/apache/spark/pull/11105#discussion_r86491369 --- Diff: core/src/main/scala/org/apache/spark/util/AccumulatorV2.scala --- @@ -136,15 +181,92 @@ abstract class AccumulatorV2[IN, OUT] extends Serializable

[GitHub] spark issue #15432: [SPARK-17854][SQL] rand/randn allows null/long as input ...

2016-11-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15432 **[Test build #68109 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68109/consoleFull)** for PR 15432 at commit [`b432355`](https://github.com/apache/spark/commit/b

[GitHub] spark pull request #15764: [SPARK-18217] [SQL] Disallow creating permanent v...

2016-11-03 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/15764#discussion_r86491162 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala --- @@ -923,6 +923,24 @@ class SessionCatalog(

[GitHub] spark issue #15432: [SPARK-17854][SQL] rand/randn allows null/long as input ...

2016-11-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15432 **[Test build #68108 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68108/consoleFull)** for PR 15432 at commit [`a523302`](https://github.com/apache/spark/commit/a

[GitHub] spark pull request #15747: [SPARK-14393][SQL][DOC] update doc for python and...

2016-11-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/15747 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark issue #15747: [SPARK-14393][SQL][DOC] update doc for python and R

2016-11-03 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/15747 merged to master / branch-2.1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled a

[GitHub] spark pull request #11105: [SPARK-12469][CORE] Data Property accumulators fo...

2016-11-03 Thread holdenk
Github user holdenk commented on a diff in the pull request: https://github.com/apache/spark/pull/11105#discussion_r86490667 --- Diff: core/src/main/scala/org/apache/spark/util/AccumulatorV2.scala --- @@ -42,18 +60,45 @@ private[spark] case class AccumulatorMetadata( * `OUT` s

[GitHub] spark issue #15762: [SPARK-18235][ML] ml.ALSModel function parity: ALSModel ...

2016-11-03 Thread sethah
Github user sethah commented on the issue: https://github.com/apache/spark/pull/15762 Looks like a duplicate of https://github.com/apache/spark/pull/12574 ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request #11105: [SPARK-12469][CORE] Data Property accumulators fo...

2016-11-03 Thread holdenk
Github user holdenk commented on a diff in the pull request: https://github.com/apache/spark/pull/11105#discussion_r86490436 --- Diff: core/src/main/scala/org/apache/spark/util/AccumulatorV2.scala --- @@ -42,18 +60,45 @@ private[spark] case class AccumulatorMetadata( * `OUT` s

[GitHub] spark issue #15751: [SPARK-18246][SQL] Throws an exception before execution ...

2016-11-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15751 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68106/ Test FAILed. ---

[GitHub] spark issue #15751: [SPARK-18246][SQL] Throws an exception before execution ...

2016-11-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15751 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #15751: [SPARK-18246][SQL] Throws an exception before execution ...

2016-11-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15751 **[Test build #68106 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68106/consoleFull)** for PR 15751 at commit [`d247947`](https://github.com/apache/spark/commit/

[GitHub] spark pull request #11105: [SPARK-12469][CORE] Data Property accumulators fo...

2016-11-03 Thread holdenk
Github user holdenk commented on a diff in the pull request: https://github.com/apache/spark/pull/11105#discussion_r86490194 --- Diff: core/src/main/scala/org/apache/spark/util/AccumulatorV2.scala --- @@ -136,15 +181,92 @@ abstract class AccumulatorV2[IN, OUT] extends Serializable

[GitHub] spark pull request #15764: [SPARK-18217] [SQL] Disallow creating permanent v...

2016-11-03 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/15764#discussion_r86489677 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala --- @@ -923,6 +923,24 @@ class SessionCatalog( }

[GitHub] spark pull request #15760: [SPARK-18259][SQL]Do not capture Throwable in Que...

2016-11-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/15760 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request #15763: [SPARK-17348][SQL] Incorrect results from subquer...

2016-11-03 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/15763#discussion_r86489433 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -977,6 +977,13 @@ class Analyzer( localPredicat

[GitHub] spark pull request #11105: [SPARK-12469][CORE] Data Property accumulators fo...

2016-11-03 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/11105#discussion_r86489315 --- Diff: core/src/main/scala/org/apache/spark/util/AccumulatorV2.scala --- @@ -136,15 +181,92 @@ abstract class AccumulatorV2[IN, OUT] extends Serializable {

[GitHub] spark pull request #11105: [SPARK-12469][CORE] Data Property accumulators fo...

2016-11-03 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/11105#discussion_r86487454 --- Diff: core/src/main/scala/org/apache/spark/TaskContext.scala --- @@ -69,6 +69,20 @@ object TaskContext { } } +/** + * Identifies

[GitHub] spark pull request #11105: [SPARK-12469][CORE] Data Property accumulators fo...

2016-11-03 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/11105#discussion_r86486890 --- Diff: core/src/main/scala/org/apache/spark/util/AccumulatorV2.scala --- @@ -136,15 +181,92 @@ abstract class AccumulatorV2[IN, OUT] extends Serializable {

[GitHub] spark pull request #11105: [SPARK-12469][CORE] Data Property accumulators fo...

2016-11-03 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/11105#discussion_r86486267 --- Diff: core/src/main/scala/org/apache/spark/util/AccumulatorV2.scala --- @@ -136,15 +181,92 @@ abstract class AccumulatorV2[IN, OUT] extends Serializable {

[GitHub] spark issue #15760: [SPARK-18259][SQL]Do not capture Throwable in QueryExecu...

2016-11-03 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/15760 Merging in master/branch-2.1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wis

[GitHub] spark pull request #11105: [SPARK-12469][CORE] Data Property accumulators fo...

2016-11-03 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/11105#discussion_r86486502 --- Diff: core/src/main/scala/org/apache/spark/TaskContextImpl.scala --- @@ -126,4 +126,14 @@ private[spark] class TaskContextImpl( taskMetrics.regist

[GitHub] spark pull request #11105: [SPARK-12469][CORE] Data Property accumulators fo...

2016-11-03 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/11105#discussion_r86487664 --- Diff: core/src/main/scala/org/apache/spark/util/AccumulatorV2.scala --- @@ -136,15 +181,92 @@ abstract class AccumulatorV2[IN, OUT] extends Serializable {

[GitHub] spark pull request #11105: [SPARK-12469][CORE] Data Property accumulators fo...

2016-11-03 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/11105#discussion_r86486618 --- Diff: core/src/main/scala/org/apache/spark/util/AccumulatorV2.scala --- @@ -136,15 +181,92 @@ abstract class AccumulatorV2[IN, OUT] extends Serializable {

[GitHub] spark pull request #11105: [SPARK-12469][CORE] Data Property accumulators fo...

2016-11-03 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/11105#discussion_r86486669 --- Diff: core/src/main/scala/org/apache/spark/TaskContext.scala --- @@ -69,6 +69,20 @@ object TaskContext { } } +/** + * Identifies

[GitHub] spark pull request #11105: [SPARK-12469][CORE] Data Property accumulators fo...

2016-11-03 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/11105#discussion_r86486810 --- Diff: core/src/main/scala/org/apache/spark/util/AccumulatorV2.scala --- @@ -136,15 +181,92 @@ abstract class AccumulatorV2[IN, OUT] extends Serializable {

[GitHub] spark pull request #11105: [SPARK-12469][CORE] Data Property accumulators fo...

2016-11-03 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/11105#discussion_r86486722 --- Diff: core/src/main/scala/org/apache/spark/util/AccumulatorV2.scala --- @@ -136,15 +181,92 @@ abstract class AccumulatorV2[IN, OUT] extends Serializable {

[GitHub] spark pull request #11105: [SPARK-12469][CORE] Data Property accumulators fo...

2016-11-03 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/11105#discussion_r86488263 --- Diff: core/src/main/scala/org/apache/spark/util/AccumulatorV2.scala --- @@ -136,15 +181,92 @@ abstract class AccumulatorV2[IN, OUT] extends Serializable {

[GitHub] spark pull request #11105: [SPARK-12469][CORE] Data Property accumulators fo...

2016-11-03 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/11105#discussion_r86486359 --- Diff: core/src/main/scala/org/apache/spark/util/AccumulatorV2.scala --- @@ -42,18 +60,45 @@ private[spark] case class AccumulatorMetadata( * `OUT` sh

[GitHub] spark pull request #11105: [SPARK-12469][CORE] Data Property accumulators fo...

2016-11-03 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/11105#discussion_r86487826 --- Diff: core/src/main/scala/org/apache/spark/util/AccumulatorV2.scala --- @@ -136,15 +181,92 @@ abstract class AccumulatorV2[IN, OUT] extends Serializable {

[GitHub] spark pull request #11105: [SPARK-12469][CORE] Data Property accumulators fo...

2016-11-03 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/11105#discussion_r86487362 --- Diff: core/src/main/scala/org/apache/spark/util/AccumulatorV2.scala --- @@ -136,15 +181,92 @@ abstract class AccumulatorV2[IN, OUT] extends Serializable {

[GitHub] spark pull request #15044: [SQL][SPARK-17490] Optimize SerializeFromObject()...

2016-11-03 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/15044#discussion_r86489106 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/encoders/RowEncoder.scala --- @@ -119,18 +119,36 @@ object RowEncoder { "

[GitHub] spark issue #15726: [SPARK-18107][SQL][FOLLOW-UP] Insert overwrite statement...

2016-11-03 Thread ericl
Github user ericl commented on the issue: https://github.com/apache/spark/pull/15726 Hm, iirc the issue is not super hard to fix, but basically since the hive thrift client is not thread safe, only one client can use it at a time. We would need some sort of hive client pool to s

[GitHub] spark pull request #15044: [SQL][SPARK-17490] Optimize SerializeFromObject()...

2016-11-03 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/15044#discussion_r86488905 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala --- @@ -441,6 +441,28 @@ object ScalaReflection extends ScalaRef

[GitHub] spark issue #15764: [SPARK-18217] [SQL] Disallow creating permanent views ba...

2016-11-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15764 **[Test build #68107 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68107/consoleFull)** for PR 15764 at commit [`695110f`](https://github.com/apache/spark/commit/6

[GitHub] spark issue #15763: [SPARK-17348][SQL] Incorrect results from subquery trans...

2016-11-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15763 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

[GitHub] spark pull request #15764: [SPARK-18217] [SQL] Disallow creating permanent v...

2016-11-03 Thread gatorsmile
GitHub user gatorsmile opened a pull request: https://github.com/apache/spark/pull/15764 [SPARK-18217] [SQL] Disallow creating permanent views based on temporary views or UDFs ### What changes were proposed in this pull request? Based on the discussion in [SPARK-18209](https://

[GitHub] spark pull request #15763: [SPARK-17348][SQL] Incorrect results from subquer...

2016-11-03 Thread nsyca
GitHub user nsyca opened a pull request: https://github.com/apache/spark/pull/15763 [SPARK-17348][SQL] Incorrect results from subquery transformation ## What changes were proposed in this pull request? Return an Analysis exception when there is a correlated non-equality pre

[GitHub] spark issue #15751: [SPARK-18246][SQL] Throws an exception before execution ...

2016-11-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15751 **[Test build #68106 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68106/consoleFull)** for PR 15751 at commit [`d247947`](https://github.com/apache/spark/commit/d

[GitHub] spark pull request #15703: [SPARK-18186] Migrate HiveUDAFFunction to TypedIm...

2016-11-03 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/15703#discussion_r86487495 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/hiveUDFs.scala --- @@ -365,4 +382,66 @@ private[hive] case class HiveUDAFFunction( val

[GitHub] spark issue #15751: [SPARK-18246][SQL] Throws an exception before execution ...

2016-11-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15751 **[Test build #68105 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68105/consoleFull)** for PR 15751 at commit [`5e87b12`](https://github.com/apache/spark/commit/5

[GitHub] spark pull request #15703: [SPARK-18186] Migrate HiveUDAFFunction to TypedIm...

2016-11-03 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/15703#discussion_r86487127 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/hiveUDFs.scala --- @@ -289,73 +302,77 @@ private[hive] case class HiveUDAFFunction(

[GitHub] spark issue #15726: [SPARK-18107][SQL][FOLLOW-UP] Insert overwrite statement...

2016-11-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15726 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68102/ Test PASSed. ---

[GitHub] spark issue #15751: [SPARK-18246][SQL] Throws an exception before execution ...

2016-11-03 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/15751 cc @rxin and @marmbrus, actual change is only adding `JacksonUtils.verifySchema(schema)`, `CSVRelation.verifySchema(schema)` and `TextFileFormat.verifySchema(schema)` and the others are only tes

[GitHub] spark issue #15726: [SPARK-18107][SQL][FOLLOW-UP] Insert overwrite statement...

2016-11-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15726 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #15726: [SPARK-18107][SQL][FOLLOW-UP] Insert overwrite statement...

2016-11-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15726 **[Test build #68102 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68102/consoleFull)** for PR 15726 at commit [`4624f1a`](https://github.com/apache/spark/commit/

[GitHub] spark issue #15751: [WIP][SPARK-18246][SQL] Throws an exception before execu...

2016-11-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15751 **[Test build #68104 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68104/consoleFull)** for PR 15751 at commit [`370aee0`](https://github.com/apache/spark/commit/3

[GitHub] spark pull request #11105: [SPARK-12469][CORE] Data Property accumulators fo...

2016-11-03 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/11105#discussion_r86484995 --- Diff: core/src/main/scala/org/apache/spark/rdd/ShuffledRDD.scala --- @@ -104,10 +105,26 @@ class ShuffledRDD[K: ClassTag, V: ClassTag, C: ClassTag](

[GitHub] spark issue #15314: [SPARK-17747][ML] WeightCol support non-double numeric d...

2016-11-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15314 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #15314: [SPARK-17747][ML] WeightCol support non-double numeric d...

2016-11-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15314 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68103/ Test PASSed. ---

[GitHub] spark issue #15314: [SPARK-17747][ML] WeightCol support non-double numeric d...

2016-11-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15314 **[Test build #68103 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68103/consoleFull)** for PR 15314 at commit [`57c952e`](https://github.com/apache/spark/commit/

[GitHub] spark pull request #11105: [SPARK-12469][CORE] Data Property accumulators fo...

2016-11-03 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/11105#discussion_r86484498 --- Diff: core/src/test/scala/org/apache/spark/DataPropertyAccumulatorSuite.scala --- @@ -0,0 +1,383 @@ +/* + * Licensed to the Apache Software Founda

[GitHub] spark pull request #11105: [SPARK-12469][CORE] Data Property accumulators fo...

2016-11-03 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/11105#discussion_r86483290 --- Diff: core/src/main/scala/org/apache/spark/util/AccumulatorV2.scala --- @@ -306,18 +428,19 @@ class LongAccumulator extends AccumulatorV2[jl.Long, jl.Long

[GitHub] spark issue #15363: [SPARK-17791][SQL] Join reordering using star schema det...

2016-11-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15363 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #15363: [SPARK-17791][SQL] Join reordering using star schema det...

2016-11-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15363 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68099/ Test PASSed. ---

[GitHub] spark issue #15363: [SPARK-17791][SQL] Join reordering using star schema det...

2016-11-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15363 **[Test build #68099 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68099/consoleFull)** for PR 15363 at commit [`cca4b9f`](https://github.com/apache/spark/commit/

[GitHub] spark issue #15659: [SPARK-1267][SPARK-18129] Allow PySpark to be pip instal...

2016-11-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15659 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68096/ Test PASSed. ---

[GitHub] spark issue #15659: [SPARK-1267][SPARK-18129] Allow PySpark to be pip instal...

2016-11-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15659 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #15659: [SPARK-1267][SPARK-18129] Allow PySpark to be pip instal...

2016-11-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15659 **[Test build #68096 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68096/consoleFull)** for PR 15659 at commit [`99940ee`](https://github.com/apache/spark/commit/

[GitHub] spark issue #15671: [SPARK-18206][ML]Add instrumentation logs to ML training...

2016-11-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15671 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

  1   2   3   4   5   6   >