[GitHub] spark issue #16422: [SPARK-17642] [SQL] support DESC EXTENDED/FORMATTED tabl...

2016-12-29 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/16422 What is the behavior of DESC COLUMN for the complex/nested type (map, struct, array)? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request #16422: [SPARK-17642] [SQL] support DESC EXTENDED/FORMATT...

2016-12-29 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16422#discussion_r94208490 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala --- @@ -300,10 +300,21 @@ class SparkSqlAstBuilder(conf: SQLConf)

[GitHub] spark pull request #16422: [SPARK-17642] [SQL] support DESC EXTENDED/FORMATT...

2016-12-29 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16422#discussion_r94208116 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala --- @@ -300,10 +300,21 @@ class SparkSqlAstBuilder(conf: SQLConf)

[GitHub] spark pull request #15664: [SPARK-18123][SQL] Use db column names instead of...

2016-12-29 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/15664#discussion_r94207926 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala --- @@ -108,14 +108,32 @@ object JdbcUtils extends

[GitHub] spark pull request #15664: [SPARK-18123][SQL] Use db column names instead of...

2016-12-29 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/15664#discussion_r94207873 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcRelationProvider.scala --- @@ -57,26 +57,28 @@ class

[GitHub] spark issue #16423: Update known_translations for contributor names and also...

2016-12-29 Thread lw-lin
Github user lw-lin commented on the issue: https://github.com/apache/spark/pull/16423 hi @yhuai, could you also: add: ``` lw-lin - Liwei Lin ``` update: ``` sharkdtu - Xiaogang Tu cenyuhai - Yuhai Ceng ``` --- If your project is set up

[GitHub] spark issue #15819: [SPARK-18372][SQL][Branch-1.6].Staging directory fail to...

2016-12-29 Thread merlintang
Github user merlintang commented on the issue: https://github.com/apache/spark/pull/15819 yes, let me backport the test cases for checking the staging file. On Thu, Dec 29, 2016 at 10:11 PM, Xiao Li wrote: > Is that possible to backport the

[GitHub] spark issue #16405: [SPARK-19002][BUILD][PYTHON] Check pep8 against all Pyth...

2016-12-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16405 **[Test build #70737 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70737/testReport)** for PR 16405 at commit

[GitHub] spark issue #16405: [SPARK-19002][BUILD][PYTHON] Check pep8 against all Pyth...

2016-12-29 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/16405 retest yhis please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark pull request #13077: [SPARK-10748] [Mesos] Log error instead of crashi...

2016-12-29 Thread devaraj-kavali
Github user devaraj-kavali commented on a diff in the pull request: https://github.com/apache/spark/pull/13077#discussion_r94205390 --- Diff: resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterScheduler.scala --- @@ -559,15 +560,29 @@

[GitHub] spark issue #16433: [SPARK-19022][TESTS] Fix tests dependent on OS due to di...

2016-12-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16433 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70735/ Test PASSed. ---

[GitHub] spark issue #16433: [SPARK-19022][TESTS] Fix tests dependent on OS due to di...

2016-12-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16433 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16433: [SPARK-19022][TESTS] Fix tests dependent on OS due to di...

2016-12-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16433 **[Test build #70735 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70735/testReport)** for PR 16433 at commit

[GitHub] spark issue #15819: [SPARK-18372][SQL][Branch-1.6].Staging directory fail to...

2016-12-29 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/15819 Is that possible to backport the test cases in https://github.com/apache/spark/pull/16399? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark issue #16405: [SPARK-19002][BUILD][PYTHON] Check pep8 against all Pyth...

2016-12-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16405 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16405: [SPARK-19002][BUILD][PYTHON] Check pep8 against all Pyth...

2016-12-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16405 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70734/ Test FAILed. ---

[GitHub] spark issue #16405: [SPARK-19002][BUILD][PYTHON] Check pep8 against all Pyth...

2016-12-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16405 **[Test build #70734 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70734/testReport)** for PR 16405 at commit

[GitHub] spark pull request #15819: [SPARK-18372][SQL][Branch-1.6].Staging directory ...

2016-12-29 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/15819#discussion_r94204568 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/InsertIntoHiveTableSuite.scala --- @@ -76,6 +76,8 @@ class InsertIntoHiveTableSuite extends

[GitHub] spark issue #16296: [SPARK-18885][SQL] unify CREATE TABLE syntax for data so...

2016-12-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16296 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16296: [SPARK-18885][SQL] unify CREATE TABLE syntax for data so...

2016-12-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16296 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70736/ Test FAILed. ---

[GitHub] spark issue #16296: [SPARK-18885][SQL] unify CREATE TABLE syntax for data so...

2016-12-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16296 **[Test build #70736 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70736/testReport)** for PR 16296 at commit

[GitHub] spark issue #16233: [SPARK-18801][SQL] Support resolve a nested view

2016-12-29 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/16233 Generally, the solution also looks ok to me. I think the test case coverage needs to be improved. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark issue #16233: [SPARK-18801][SQL] Support resolve a nested view

2016-12-29 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/16233 Could you also add a test case for verifying the error behaviors? For example, in the definition of a nested view, how Analyzer behaves when the dependent databases, views, or views are

[GitHub] spark issue #16371: [SPARK-18932][SQL] Support partial aggregation for colle...

2016-12-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16371 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16371: [SPARK-18932][SQL] Support partial aggregation for colle...

2016-12-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16371 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70733/ Test PASSed. ---

[GitHub] spark issue #16371: [SPARK-18932][SQL] Support partial aggregation for colle...

2016-12-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16371 **[Test build #70733 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70733/testReport)** for PR 16371 at commit

[GitHub] spark pull request #16233: [SPARK-18801][SQL] Support resolve a nested view

2016-12-29 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16233#discussion_r94202865 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalogSuite.scala --- @@ -465,6 +465,35 @@ class SessionCatalogSuite

[GitHub] spark pull request #16233: [SPARK-18801][SQL] Support resolve a nested view

2016-12-29 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16233#discussion_r94202897 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalogSuite.scala --- @@ -465,6 +465,35 @@ class SessionCatalogSuite

[GitHub] spark pull request #16233: [SPARK-18801][SQL] Support resolve a nested view

2016-12-29 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16233#discussion_r94202769 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -658,6 +719,21 @@ class Analyzer(

[GitHub] spark pull request #16233: [SPARK-18801][SQL] Support resolve a nested view

2016-12-29 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16233#discussion_r94202754 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -2224,6 +2316,16 @@ object EliminateSubqueryAliases

[GitHub] spark pull request #16422: [SPARK-17642] [SQL] support DESC EXTENDED/FORMATT...

2016-12-29 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/16422#discussion_r94202748 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala --- @@ -586,6 +587,100 @@ case class DescribeTableCommand( }

[GitHub] spark pull request #16422: [SPARK-17642] [SQL] support DESC EXTENDED/FORMATT...

2016-12-29 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/16422#discussion_r94202675 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala --- @@ -300,10 +300,21 @@ class SparkSqlAstBuilder(conf: SQLConf)

[GitHub] spark pull request #16233: [SPARK-18801][SQL] Support resolve a nested view

2016-12-29 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16233#discussion_r94202502 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -658,6 +719,21 @@ class Analyzer(

[GitHub] spark pull request #16233: [SPARK-18801][SQL] Support resolve a nested view

2016-12-29 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16233#discussion_r94202491 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -2224,6 +2316,16 @@ object EliminateSubqueryAliases

[GitHub] spark pull request #16233: [SPARK-18801][SQL] Support resolve a nested view

2016-12-29 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16233#discussion_r94202380 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala --- @@ -377,6 +378,39 @@ case class

[GitHub] spark pull request #16233: [SPARK-18801][SQL] Support resolve a nested view

2016-12-29 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16233#discussion_r94202164 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala --- @@ -845,6 +846,7 @@ private[hive] class HiveClientImpl(

[GitHub] spark issue #16296: [SPARK-18885][SQL] unify CREATE TABLE syntax for data so...

2016-12-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16296 **[Test build #70736 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70736/testReport)** for PR 16296 at commit

[GitHub] spark pull request #16429: [SPARK-19019][PYTHON] Fix hijacked `collections.n...

2016-12-29 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/16429#discussion_r94201674 --- Diff: python/pyspark/serializers.py --- @@ -382,18 +382,30 @@ def _hijack_namedtuple(): return global _old_namedtuple #

[GitHub] spark issue #16433: [SPARK-19022][TESTS] Fix tests dependent on OS due to di...

2016-12-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16433 **[Test build #70735 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70735/testReport)** for PR 16433 at commit

[GitHub] spark issue #16433: [SPARK-19022][TESTS] Fix tests dependent on OS due to di...

2016-12-29 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/16433 Build started: [TESTS] `org.apache.spark.sql.streaming.StreamingQueryStatusAndProgressSuite`

[GitHub] spark issue #16405: [SPARK-19002][BUILD][PYTHON] Check pep8 against all Pyth...

2016-12-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16405 **[Test build #70734 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70734/testReport)** for PR 16405 at commit

[GitHub] spark issue #16405: [SPARK-19002][BUILD][PYTHON] Check pep8 against all Pyth...

2016-12-29 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/16405 I just manually ran `./dev/create-release/translate-contributors.py` which had a conflict for sure. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request #16435: [SPARK-19027][SQL] estimate size of object buffer...

2016-12-29 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/16435#discussion_r94201244 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/ObjectAggregationIterator.scala --- @@ -154,21 +200,19 @@ class

[GitHub] spark issue #16397: [SPARK-18922][TESTS] Fix more path-related test failures...

2016-12-29 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/16397 @srowen, thank you Sean. I think it is okay for now. To be honest, I found some more same instances but I haven't fixed, tested and verified them yet. Maybe, I need one more go to deal with

[GitHub] spark issue #16433: [SPARK-19022][TESTS] Fix tests dependent on OS due to di...

2016-12-29 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/16433 In most cases, it seems they explicitly write `\n` (e.g. writing CSV and JSON). _Apparently_, these seem only tests being failed due to this problem --- If your project is set up for it, you

[GitHub] spark pull request #16433: [SPARK-19022][TESTS] Fix tests dependent on OS du...

2016-12-29 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/16433#discussion_r94200602 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamingQueryStatusAndProgressSuite.scala --- @@ -30,10 +30,16 @@ import

[GitHub] spark issue #16439: [SPARK-19026]SPARK_LOCAL_DIRS(multiple directories on di...

2016-12-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16439 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request #16439: [SPARK-19026]SPARK_LOCAL_DIRS(multiple directorie...

2016-12-29 Thread zuotingbing
GitHub user zuotingbing opened a pull request: https://github.com/apache/spark/pull/16439 [SPARK-19026]SPARK_LOCAL_DIRS(multiple directories on different disks) cannot be deleted JIRA Issue: https://issues.apache.org/jira/browse/SPARK-19026 SPARK_LOCAL_DIRS (Standalone)

[GitHub] spark issue #16371: [SPARK-18932][SQL] Support partial aggregation for colle...

2016-12-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16371 **[Test build #70733 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70733/testReport)** for PR 16371 at commit

[GitHub] spark pull request #16422: [SPARK-17642] [SQL] support DESC EXTENDED/FORMATT...

2016-12-29 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/16422#discussion_r94199600 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala --- @@ -586,6 +587,100 @@ case class DescribeTableCommand( }

[GitHub] spark pull request #16422: [SPARK-17642] [SQL] support DESC EXTENDED/FORMATT...

2016-12-29 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/16422#discussion_r94199552 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala --- @@ -300,10 +300,21 @@ class SparkSqlAstBuilder(conf: SQLConf)

[GitHub] spark issue #16415: [SPARK-19007]Speedup and optimize the GradientBoostedTre...

2016-12-29 Thread zdh2292390
Github user zdh2292390 commented on the issue: https://github.com/apache/spark/pull/16415 @jkbradley Yes,changing the storageLevel in predErrorCheckpointer can fix the problem. Can you please merge my latest commit which just changed the storageLevel in

[GitHub] spark issue #16414: [SPARK-19009][DOC] Add streaming rest api doc

2016-12-29 Thread uncleGen
Github user uncleGen commented on the issue: https://github.com/apache/spark/pull/16414 cc @srowen --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] spark issue #15664: [SPARK-18123][SQL] Use db column names instead of RDD co...

2016-12-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15664 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15664: [SPARK-18123][SQL] Use db column names instead of RDD co...

2016-12-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15664 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70731/ Test PASSed. ---

[GitHub] spark issue #15664: [SPARK-18123][SQL] Use db column names instead of RDD co...

2016-12-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15664 **[Test build #70731 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70731/testReport)** for PR 15664 at commit

[GitHub] spark issue #16386: [SPARK-18352][SQL] Support parsing multiline json files

2016-12-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16386 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16386: [SPARK-18352][SQL] Support parsing multiline json files

2016-12-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16386 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70730/ Test FAILed. ---

[GitHub] spark issue #16386: [SPARK-18352][SQL] Support parsing multiline json files

2016-12-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16386 **[Test build #70730 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70730/testReport)** for PR 16386 at commit

[GitHub] spark issue #16438: [SPARK-19029] [SQL] Remove databaseName from SimpleCatal...

2016-12-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16438 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70727/ Test PASSed. ---

[GitHub] spark issue #16438: [SPARK-19029] [SQL] Remove databaseName from SimpleCatal...

2016-12-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16438 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16438: [SPARK-19029] [SQL] Remove databaseName from SimpleCatal...

2016-12-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16438 **[Test build #70727 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70727/testReport)** for PR 16438 at commit

[GitHub] spark issue #16424: [SPARK-19016][SQL][DOC] Document scalable partition hand...

2016-12-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16424 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70732/ Test PASSed. ---

[GitHub] spark issue #16424: [SPARK-19016][SQL][DOC] Document scalable partition hand...

2016-12-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16424 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16424: [SPARK-19016][SQL][DOC] Document scalable partition hand...

2016-12-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16424 **[Test build #70732 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70732/testReport)** for PR 16424 at commit

[GitHub] spark issue #16386: [SPARK-18352][SQL] Support parsing multiline json files

2016-12-29 Thread NathanHowell
Github user NathanHowell commented on the issue: https://github.com/apache/spark/pull/16386 @HyukjinKwon I just pushed a change that makes the corrupt record handling consistent: if a corrupt record column is defined it will always get the json text for failed records. If `wholeFile`

[GitHub] spark pull request #16397: [SPARK-18922][TESTS] Fix more path-related test f...

2016-12-29 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/16397#discussion_r94190092 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveExternalCatalogBackwardCompatibilitySuite.scala --- @@ -185,8 +191,8 @@ class

[GitHub] spark issue #16424: [SPARK-19016][SQL][DOC] Document scalable partition hand...

2016-12-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16424 **[Test build #70732 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70732/testReport)** for PR 16424 at commit

[GitHub] spark issue #16355: [SPARK-16473][MLLIB] Fix BisectingKMeans Algorithm faili...

2016-12-29 Thread imatiach-msft
Github user imatiach-msft commented on the issue: https://github.com/apache/spark/pull/16355 the only problem I see is that with this code we generate k-1 clusters instead of k, but it states in the algorithm documentation that it is not guaranteed to generate k clusters, it could be

[GitHub] spark issue #15664: [SPARK-18123][SQL] Use db column names instead of RDD co...

2016-12-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15664 **[Test build #70731 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70731/testReport)** for PR 15664 at commit

[GitHub] spark issue #15664: [SPARK-18123][SQL] Use db column names instead of RDD co...

2016-12-29 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/15664 Retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #15664: [SPARK-18123][SQL] Use db column names instead of RDD co...

2016-12-29 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/15664 The only failure is irrelevant to this PR. ``` [info] StreamSuite: [info] - fatal errors from a source should be sent to the user *** FAILED *** (101 milliseconds) [info]

[GitHub] spark issue #15664: [SPARK-18123][SQL] Use db column names instead of RDD co...

2016-12-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15664 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15664: [SPARK-18123][SQL] Use db column names instead of RDD co...

2016-12-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15664 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70726/ Test FAILed. ---

[GitHub] spark issue #15664: [SPARK-18123][SQL] Use db column names instead of RDD co...

2016-12-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15664 **[Test build #70726 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70726/testReport)** for PR 15664 at commit

[GitHub] spark pull request #16424: [SPARK-19016][SQL][DOC] Document scalable partiti...

2016-12-29 Thread ericl
Github user ericl commented on a diff in the pull request: https://github.com/apache/spark/pull/16424#discussion_r94187848 --- Diff: docs/sql-programming-guide.md --- @@ -526,11 +526,18 @@ By default `saveAsTable` will create a "managed table", meaning that the locatio be

[GitHub] spark issue #16424: [SPARK-19016][SQL][DOC] Document scalable partition hand...

2016-12-29 Thread ericl
Github user ericl commented on the issue: https://github.com/apache/spark/pull/16424 LGTM, just one comment --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #16426: [MINOR][TEST] Add `finally` clause for `sc.stop()`

2016-12-29 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/16426 It looks OK to me. Do you have a moment to grep for other instances in the tests (at least Java ones) where a new SparkContext is created in the test, to see if any other contexts need to be

[GitHub] spark issue #16433: [SPARK-19022][TESTS] Fix tests dependent on OS due to di...

2016-12-29 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/16433 Maybe a dumb question but why is this only a problem in this test and not for many other test suites? i'd sort of imagine the newline difference affects a lot of comparisons. --- If your project

[GitHub] spark pull request #16417: [SPARK-19014][SQL] support complex aggregate buff...

2016-12-29 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/16417#discussion_r94187427 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala --- @@ -310,6 +310,31 @@ class

[GitHub] spark issue #16355: [SPARK-16473][MLLIB] Fix BisectingKMeans Algorithm faili...

2016-12-29 Thread jkbradley
Github user jkbradley commented on the issue: https://github.com/apache/spark/pull/16355 @yu-iskw Pinging on this since you wrote bisecting k-means originally. Do you have time to take a look? Thanks! --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark issue #16415: [SPARK-19007]Speedup and optimize the GradientBoostedTre...

2016-12-29 Thread jkbradley
Github user jkbradley commented on the issue: https://github.com/apache/spark/pull/16415 Thanks for checking! Does changing the storageLevel in predErrorCheckpointer fix the problem? "other use cases": Well, I remember thinking about this a lot when adding the

[GitHub] spark pull request #16423: Update known_translations for contributor names a...

2016-12-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/16423 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #16386: [SPARK-18352][SQL] Support parsing multiline json files

2016-12-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16386 **[Test build #70730 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70730/testReport)** for PR 16386 at commit

[GitHub] spark issue #16423: Update known_translations for contributor names and also...

2016-12-29 Thread yhuai
Github user yhuai commented on the issue: https://github.com/apache/spark/pull/16423 Thanks. Merging to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark pull request #13077: [SPARK-10748] [Mesos] Log error instead of crashi...

2016-12-29 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/13077#discussion_r94185533 --- Diff: resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterScheduler.scala --- @@ -559,15 +560,29 @@

[GitHub] spark pull request #16408: [SPARK-19003][DOCS] Add Java example in Spark Str...

2016-12-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/16408 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #16408: [SPARK-19003][DOCS] Add Java example in Spark Streaming ...

2016-12-29 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/16408 Merged to master/2.1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] spark issue #16424: [SPARK-19016][SQL][DOC] Document scalable partition hand...

2016-12-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16424 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16424: [SPARK-19016][SQL][DOC] Document scalable partition hand...

2016-12-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16424 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70729/ Test PASSed. ---

[GitHub] spark issue #16424: [SPARK-19016][SQL][DOC] Document scalable partition hand...

2016-12-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16424 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16424: [SPARK-19016][SQL][DOC] Document scalable partition hand...

2016-12-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16424 **[Test build #70729 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70729/testReport)** for PR 16424 at commit

[GitHub] spark issue #16424: [SPARK-19016][SQL][DOC] Document scalable partition hand...

2016-12-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16424 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70728/ Test PASSed. ---

[GitHub] spark issue #16424: [SPARK-19016][SQL][DOC] Document scalable partition hand...

2016-12-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16424 **[Test build #70728 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70728/testReport)** for PR 16424 at commit

[GitHub] spark pull request #16436: [SPARK-18698][ML] Adding public constructor that ...

2016-12-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/16436 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #16424: [SPARK-19016][SQL][DOC] Document scalable partition hand...

2016-12-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16424 **[Test build #70729 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70729/testReport)** for PR 16424 at commit

[GitHub] spark issue #16436: [SPARK-18698][ML] Adding public constructor that takes u...

2016-12-29 Thread jkbradley
Github user jkbradley commented on the issue: https://github.com/apache/spark/pull/16436 LGTM Merging with master Thanks @imatiach-msft ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark issue #16424: [SPARK-19016][SQL][DOC] Document scalable partition hand...

2016-12-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16424 **[Test build #70728 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70728/testReport)** for PR 16424 at commit

[GitHub] spark issue #16424: [SPARK-19016][SQL][DOC] Document scalable partition hand...

2016-12-29 Thread liancheng
Github user liancheng commented on the issue: https://github.com/apache/spark/pull/16424 @ericl @CodingCat Thanks for the review! Fixed per your comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request #16424: [SPARK-19016][SQL][DOC] Document scalable partiti...

2016-12-29 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/16424#discussion_r94181109 --- Diff: docs/sql-programming-guide.md --- @@ -526,11 +526,18 @@ By default `saveAsTable` will create a "managed table", meaning that the locatio be

  1   2   3   >