[GitHub] spark pull request #16844: [SPARK-19500] [SQL] Fix off-by-one bug in BytesTo...

2017-02-09 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/16844#discussion_r100383151 --- Diff: core/src/main/java/org/apache/spark/unsafe/map/BytesToBytesMap.java --- @@ -741,14 +741,6 @@ public boolean append(Object kbase, long koff, int kl

[GitHub] spark issue #16744: [SPARK-19405][STREAMING] Support for cross-account Kines...

2017-02-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16744 **[Test build #72656 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72656/testReport)** for PR 16744 at commit [`67a4acb`](https://github.com/apache/spark/commit/67

[GitHub] spark pull request #16650: [SPARK-16554][CORE] Automatically Kill Executors ...

2017-02-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/16650 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark issue #16630: [SPARK-19270][ML] Add summary table to GLM summary

2017-02-09 Thread imatiach-msft
Github user imatiach-msft commented on the issue: https://github.com/apache/spark/pull/16630 @actuaryzhang sorry I'm at Spark Summit East, will take a look soon. For the feature name or "lazy val featureName: Array[String]", I recall there is a sparse (eg output by HashingTF) and den

[GitHub] spark pull request #16864: [SPARK-19527][Core] Approximate Size of Intersect...

2017-02-09 Thread Bcpoole
Github user Bcpoole commented on a diff in the pull request: https://github.com/apache/spark/pull/16864#discussion_r100381372 --- Diff: common/sketch/src/main/java/org/apache/spark/util/sketch/IncompatibleUnionException.java --- @@ -0,0 +1,24 @@ +/* + * Licensed to the Apa

[GitHub] spark pull request #16844: [SPARK-19500] [SQL] Fix off-by-one bug in BytesTo...

2017-02-09 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/16844#discussion_r100381544 --- Diff: core/src/main/java/org/apache/spark/unsafe/map/BytesToBytesMap.java --- @@ -695,11 +690,16 @@ public boolean append(Object kbase, long koff, int k

[GitHub] spark issue #16650: [SPARK-16554][CORE] Automatically Kill Executors and Nod...

2017-02-09 Thread squito
Github user squito commented on the issue: https://github.com/apache/spark/pull/16650 merged to master, thanks @jsoltren --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark issue #16744: [SPARK-19405][STREAMING] Support for cross-account Kines...

2017-02-09 Thread brkyvz
Github user brkyvz commented on the issue: https://github.com/apache/spark/pull/16744 @budde You should be whitelisted now. you may use "retest this please" to trigger tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] spark issue #16864: [SPARK-19527][Core] Approximate Size of Intersection of ...

2017-02-09 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/16864 I meant just union, but createUnion ... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabl

[GitHub] spark issue #16744: [SPARK-19405][STREAMING] Support for cross-account Kines...

2017-02-09 Thread budde
Github user budde commented on the issue: https://github.com/apache/spark/pull/16744 Pinging @brkyvz and @srowen once more for a final look and to get Jenkins to retest the latest update (not sure if this still requires Jenkins admin rights). --- If your project is set up for it, yo

[GitHub] spark issue #16797: [SPARK-19455][SQL] Add option for case-insensitive Parqu...

2017-02-09 Thread budde
Github user budde commented on the issue: https://github.com/apache/spark/pull/16797 @cloud-fan: > Spark does support mixed-case-schema tables, and it has always been. It's because we write table schema to metastore case-preserving, via table properties. Spark prior

[GitHub] spark pull request #16844: [SPARK-19500] [SQL] Fix off-by-one bug in BytesTo...

2017-02-09 Thread mridulm
Github user mridulm commented on a diff in the pull request: https://github.com/apache/spark/pull/16844#discussion_r100378935 --- Diff: core/src/main/java/org/apache/spark/unsafe/map/BytesToBytesMap.java --- @@ -695,11 +690,16 @@ public boolean append(Object kbase, long koff, int

[GitHub] spark issue #14461: [SPARK-16856] [WEBUI] [CORE] Link the application's exec...

2017-02-09 Thread nblintao
Github user nblintao commented on the issue: https://github.com/apache/spark/pull/14461 @HyukjinKwon Thanks for reminding. I will have a look asap. Too many things to recently. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as w

[GitHub] spark pull request #16869: [SPARK-19025][SQL] Remove SQL builder for operato...

2017-02-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/16869 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark issue #16869: [SPARK-19025][SQL] Remove SQL builder for operators

2017-02-09 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/16869 I had an offline discussion with @rxin about this, and we have decided to merge this one. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub a

[GitHub] spark pull request #16852: [SPARK-19512][SQL] codegen for compare structs fa...

2017-02-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/16852 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark issue #16859: [SPARK-17714][Core][test-maven][test-hadoop2.6]Avoid usi...

2017-02-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16859 **[Test build #72655 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72655/testReport)** for PR 16859 at commit [`1c88474`](https://github.com/apache/spark/commit/1c

[GitHub] spark issue #16852: [SPARK-19512][SQL] codegen for compare structs fails

2017-02-09 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/16852 @bogdanrdc can you create a backport for branch-2.1? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark issue #16852: [SPARK-19512][SQL] codegen for compare structs fails

2017-02-09 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/16852 LGTM - merging to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wi

[GitHub] spark issue #16859: [SPARK-17714][Core][test-maven][test-hadoop2.6]Avoid usi...

2017-02-09 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/16859 Retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #16804: [SPARK-19459][SQL] Add Hive datatype (char/varchar) to S...

2017-02-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16804 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #16804: [SPARK-19459][SQL] Add Hive datatype (char/varchar) to S...

2017-02-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16804 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72648/ Test PASSed. ---

[GitHub] spark issue #8785: [Spark-10625] [SQL] Spark SQL JDBC read/write is unable t...

2017-02-09 Thread tribbloid
Github user tribbloid commented on the issue: https://github.com/apache/spark/pull/8785 yeah, just need to rebase on 2.2-SNAPSHOT+ are you going to merge immediately after rebase + syntax validation? --- If your project is set up for it, you can reply to this email and have your r

[GitHub] spark pull request #16872: [SPARK-19514] Making range interruptible.

2017-02-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/16872 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark issue #16804: [SPARK-19459][SQL] Add Hive datatype (char/varchar) to S...

2017-02-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16804 **[Test build #72648 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72648/testReport)** for PR 16804 at commit [`21be4ca`](https://github.com/apache/spark/commit/2

[GitHub] spark issue #16872: [SPARK-19514] Making range interruptible.

2017-02-09 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/16872 I'm going to merge this in master. If we find a way to optimize the test we can do a follow-up pr. --- If your project is set up for it, you can reply to this email and have your reply appear on GitH

[GitHub] spark issue #16787: [SPARK-19448][SQL]optimize some duplication functions be...

2017-02-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16787 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #16787: [SPARK-19448][SQL]optimize some duplication functions be...

2017-02-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16787 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72649/ Test PASSed. ---

[GitHub] spark issue #7266: [SPARK-8764][ML] string indexer should take option to han...

2017-02-09 Thread grabblies
Github user grabblies commented on the issue: https://github.com/apache/spark/pull/7266 When "skip" is chosen as the way to handle Unseen labels, is there a way to know which rows were skipped? --- If your project is set up for it, you can reply to this email and have your reply app

[GitHub] spark issue #16787: [SPARK-19448][SQL]optimize some duplication functions be...

2017-02-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16787 **[Test build #72649 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72649/testReport)** for PR 16787 at commit [`2a55c45`](https://github.com/apache/spark/commit/2

[GitHub] spark issue #16872: [SPARK-19514] Making range interruptible.

2017-02-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16872 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #16872: [SPARK-19514] Making range interruptible.

2017-02-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16872 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72647/ Test PASSed. ---

[GitHub] spark issue #16872: [SPARK-19514] Making range interruptible.

2017-02-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16872 **[Test build #72647 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72647/testReport)** for PR 16872 at commit [`bb5a1da`](https://github.com/apache/spark/commit/b

[GitHub] spark issue #16862: [SPARK-19520][streaming] Do not encrypt data written to ...

2017-02-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16862 **[Test build #72654 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72654/testReport)** for PR 16862 at commit [`bdbe267`](https://github.com/apache/spark/commit/bd

[GitHub] spark issue #16862: [SPARK-19520][streaming] Do not encrypt data written to ...

2017-02-09 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/16862 Kafka test error (hopefully unrelated?). Retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[GitHub] spark issue #11692: [SPARK-13852][YARN]handle the InterruptedException cause...

2017-02-09 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/11692 Either close or make the right fix. As it is, the PR is not doing the right thing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request #10262: [SPARK-12270][SQL]remove empty space after getStr...

2017-02-09 Thread huaxingao
Github user huaxingao closed the pull request at: https://github.com/apache/spark/pull/10262 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #16846: [SPARK-19506][ML][PYTHON] Import warnings in pyspark.ml....

2017-02-09 Thread zero323
Github user zero323 commented on the issue: https://github.com/apache/spark/pull/16846 @holdenk Sadly this part of the API is not tested directly and we depend on the indirect coverage. Maybe this is a sign should be tested. --- If your project is set up for it, you can reply to thi

[GitHub] spark pull request #16610: [SPARK-19254][SQL] Support Seq, Map, and Struct i...

2017-02-09 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/16610#discussion_r100366614 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/literals.scala --- @@ -153,6 +154,12 @@ object Literal { Literal(Ca

[GitHub] spark pull request #16664: [SPARK-18120 ][SQL] Call QueryExecutionListener c...

2017-02-09 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/16664#discussion_r100366124 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala --- @@ -218,7 +247,14 @@ final class DataFrameWriter[T] private[sql](ds: Datase

[GitHub] spark issue #16775: [SPARK-19433][ML] Periodic checkout datasets for long ml...

2017-02-09 Thread mallman
Github user mallman commented on the issue: https://github.com/apache/spark/pull/16775 @viirya I believe this PR meshes with the refactoring and application to pregel GraphX algorithms in #15125. Basically, it moves the periodic checkpointing code from mllib into core and uses it in G

[GitHub] spark pull request #16610: [SPARK-19254][SQL] Support Seq, Map, and Struct i...

2017-02-09 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/16610#discussion_r100365381 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala --- @@ -102,6 +102,27 @@ object functions { Column(literalExpr) }

[GitHub] spark pull request #16800: [SPARK-19456][SparkR]:Add LinearSVC R API

2017-02-09 Thread wangmiao1981
Github user wangmiao1981 closed the pull request at: https://github.com/apache/spark/pull/16800 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark pull request #16800: [SPARK-19456][SparkR]:Add LinearSVC R API

2017-02-09 Thread wangmiao1981
GitHub user wangmiao1981 reopened a pull request: https://github.com/apache/spark/pull/16800 [SPARK-19456][SparkR]:Add LinearSVC R API ## What changes were proposed in this pull request? Linear SVM classifier is newly added into ML and python API has been added. This JIRA i

[GitHub] spark issue #16800: [SPARK-19456][SparkR]:Add LinearSVC R API

2017-02-09 Thread wangmiao1981
Github user wangmiao1981 commented on the issue: https://github.com/apache/spark/pull/16800 Open to trigger --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] spark issue #16800: [SPARK-19456][SparkR]:Add LinearSVC R API

2017-02-09 Thread wangmiao1981
Github user wangmiao1981 commented on the issue: https://github.com/apache/spark/pull/16800 close to trigger windows test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark pull request #16785: [SPARK-19443][SQL] The function to generate const...

2017-02-09 Thread mallman
Github user mallman commented on a diff in the pull request: https://github.com/apache/spark/pull/16785#discussion_r100364260 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LogicalPlan.scala --- @@ -314,19 +322,29 @@ abstract class UnaryNode exte

[GitHub] spark issue #16873: [SPARK-19509][SQL] Grouping Sets do not respect nullable...

2017-02-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16873 **[Test build #72653 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72653/testReport)** for PR 16873 at commit [`d85aed7`](https://github.com/apache/spark/commit/d8

[GitHub] spark issue #12675: [SPARK-14894][PySpark] Add result summary api to Gaussia...

2017-02-09 Thread wangmiao1981
Github user wangmiao1981 commented on the issue: https://github.com/apache/spark/pull/12675 @GayathriMurali If you are not able to proceed, I can take over. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request #16610: [SPARK-19254][SQL] Support Seq, Map, and Struct i...

2017-02-09 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/16610#discussion_r100360787 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/literals.scala --- @@ -153,6 +154,12 @@ object Literal { Litera

[GitHub] spark pull request #16610: [SPARK-19254][SQL] Support Seq, Map, and Struct i...

2017-02-09 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/16610#discussion_r100360526 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala --- @@ -102,6 +102,27 @@ object functions { Column(literalExpr) }

[GitHub] spark pull request #16578: [SPARK-4502][SQL] Parquet nested column pruning

2017-02-09 Thread mallman
Github user mallman commented on a diff in the pull request: https://github.com/apache/spark/pull/16578#discussion_r100360523 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/planning/GetStructField2.scala --- @@ -0,0 +1,33 @@ +/* + * Licensed to the Apa

[GitHub] spark issue #16610: [SPARK-19254][SQL] Support Seq, Map, and Struct in funct...

2017-02-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16610 **[Test build #72652 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72652/testReport)** for PR 16610 at commit [`ca2e07f`](https://github.com/apache/spark/commit/ca

[GitHub] spark pull request #16873: [SPARK-19509][SQL] Grouping Sets do not respect n...

2017-02-09 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/16873#discussion_r100357789 --- Diff: sql/core/src/test/resources/sql-tests/inputs/grouping_set.sql --- @@ -13,5 +18,8 @@ SELECT a, b, c, count(d) FROM grouping GROUP BY a, b, c GRO

[GitHub] spark pull request #16855: [SPARK-13931] Stage can hang if an executor fails...

2017-02-09 Thread GavinGavinNo1
Github user GavinGavinNo1 commented on a diff in the pull request: https://github.com/apache/spark/pull/16855#discussion_r100356980 --- Diff: core/src/test/scala/org/apache/spark/scheduler/TaskSetManagerSuite.scala --- @@ -664,6 +665,55 @@ class TaskSetManagerSuite extends SparkFun

[GitHub] spark issue #15505: [SPARK-18890][CORE] Move task serialization from the Tas...

2017-02-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15505 **[Test build #72651 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72651/testReport)** for PR 15505 at commit [`b7866de`](https://github.com/apache/spark/commit/b7

[GitHub] spark issue #13467: [SPARK-15642][SQL][WIP] Metadata gets lost when selectin...

2017-02-09 Thread zommerfelds
Github user zommerfelds commented on the issue: https://github.com/apache/spark/pull/13467 Hi @HyukjinKwon, I never worked on the fix, because I never got confirmation if this is actually a bug or not. This PR demonstrates the bug I posted on Jira. If you want I can try to find ou

[GitHub] spark issue #15666: [SPARK-11421] [Core][Python][R] Added ability for addJar...

2017-02-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15666 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72650/ Test FAILed. ---

[GitHub] spark issue #15666: [SPARK-11421] [Core][Python][R] Added ability for addJar...

2017-02-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15666 **[Test build #72650 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72650/testReport)** for PR 15666 at commit [`21643b5`](https://github.com/apache/spark/commit/2

[GitHub] spark issue #15666: [SPARK-11421] [Core][Python][R] Added ability for addJar...

2017-02-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15666 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #15666: [SPARK-11421] [Core][Python][R] Added ability for addJar...

2017-02-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15666 **[Test build #72650 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72650/testReport)** for PR 15666 at commit [`21643b5`](https://github.com/apache/spark/commit/21

[GitHub] spark pull request #16872: [SPARK-19514] Making range interruptible.

2017-02-09 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/16872#discussion_r100350259 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameRangeSuite.scala --- @@ -127,4 +133,28 @@ class DataFrameRangeSuite extends QueryTest wit

[GitHub] spark issue #16872: [SPARK-19514] Making range interruptible.

2017-02-09 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/16872 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark issue #16873: [SPARK-19509][SQL] Grouping Sets do not respect nullable...

2017-02-09 Thread jiangxb1987
Github user jiangxb1987 commented on the issue: https://github.com/apache/spark/pull/16873 Thank you for ccing me @hvanhovell ! This PR looks good to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project doe

[GitHub] spark pull request #16873: [SPARK-19509][SQL] Grouping Sets do not respect n...

2017-02-09 Thread jiangxb1987
Github user jiangxb1987 commented on a diff in the pull request: https://github.com/apache/spark/pull/16873#discussion_r100348823 --- Diff: sql/core/src/test/resources/sql-tests/inputs/grouping_set.sql --- @@ -13,5 +18,8 @@ SELECT a, b, c, count(d) FROM grouping GROUP BY a, b, c GR

[GitHub] spark pull request #16872: [SPARK-19514] Making range interruptible.

2017-02-09 Thread ala
Github user ala commented on a diff in the pull request: https://github.com/apache/spark/pull/16872#discussion_r100347811 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameRangeSuite.scala --- @@ -127,4 +133,28 @@ class DataFrameRangeSuite extends QueryTest with Shar

[GitHub] spark pull request #16787: [SPARK-19448][SQL]optimize some duplication funct...

2017-02-09 Thread windpiger
Github user windpiger commented on a diff in the pull request: https://github.com/apache/spark/pull/16787#discussion_r100345819 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala --- @@ -845,10 +855,10 @@ private[hive] class HiveClientImpl(

[GitHub] spark pull request #16855: [SPARK-13931] Stage can hang if an executor fails...

2017-02-09 Thread GavinGavinNo1
Github user GavinGavinNo1 commented on a diff in the pull request: https://github.com/apache/spark/pull/16855#discussion_r100346247 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala --- @@ -874,7 +874,8 @@ private[spark] class TaskSetManager( //

[GitHub] spark issue #16575: [SPARK-19213] DatasourceScanExec uses runtime sparksessi...

2017-02-09 Thread robert3005
Github user robert3005 commented on the issue: https://github.com/apache/spark/pull/16575 Removed the caching logic. It was there since I wasn't sure how often we call inputRDDs and how many times the resulting rdd would get created overall since it's a def now --- If your project i

[GitHub] spark issue #16199: [SPARK-18772][SQL] NaN/Infinite float parsing in JSON is...

2017-02-09 Thread NathanHowell
Github user NathanHowell commented on the issue: https://github.com/apache/spark/pull/16199 @HyukjinKwon Good idea, I'll take another stab and try to revive the original pull request. --- If your project is set up for it, you can reply to this email and have your reply appear on GitH

[GitHub] spark pull request #16386: [SPARK-18352][SQL] Support parsing multiline json...

2017-02-09 Thread NathanHowell
Github user NathanHowell commented on a diff in the pull request: https://github.com/apache/spark/pull/16386#discussion_r100344879 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonParser.scala --- @@ -48,69 +47,102 @@ class JacksonParser(

[GitHub] spark pull request #16386: [SPARK-18352][SQL] Support parsing multiline json...

2017-02-09 Thread NathanHowell
Github user NathanHowell commented on a diff in the pull request: https://github.com/apache/spark/pull/16386#discussion_r100344282 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonParser.scala --- @@ -48,69 +47,102 @@ class JacksonParser(

[GitHub] spark issue #16787: [SPARK-19448][SQL]optimize some duplication functions be...

2017-02-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16787 **[Test build #72649 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72649/testReport)** for PR 16787 at commit [`2a55c45`](https://github.com/apache/spark/commit/2a

[GitHub] spark pull request #16787: [SPARK-19448][SQL]optimize some duplication funct...

2017-02-09 Thread windpiger
Github user windpiger commented on a diff in the pull request: https://github.com/apache/spark/pull/16787#discussion_r100343323 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala --- @@ -845,10 +855,10 @@ private[hive] class HiveClientImpl(

[GitHub] spark issue #16873: [SPARK-19509][SQL] Grouping Sets do not respect nullable...

2017-02-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16873 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #16873: [SPARK-19509][SQL] Grouping Sets do not respect nullable...

2017-02-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16873 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72645/ Test PASSed. ---

[GitHub] spark issue #16873: [SPARK-19509][SQL] Grouping Sets do not respect nullable...

2017-02-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16873 **[Test build #72645 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72645/testReport)** for PR 16873 at commit [`b54ef73`](https://github.com/apache/spark/commit/b

[GitHub] spark issue #16870: [SPARK-19496][SQL]to_date udf to return null when input ...

2017-02-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16870 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72646/ Test FAILed. ---

[GitHub] spark issue #16870: [SPARK-19496][SQL]to_date udf to return null when input ...

2017-02-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16870 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #16870: [SPARK-19496][SQL]to_date udf to return null when input ...

2017-02-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16870 **[Test build #72646 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72646/testReport)** for PR 16870 at commit [`de28fd4`](https://github.com/apache/spark/commit/d

[GitHub] spark issue #16872: [SPARK-19514] Making range interruptible.

2017-02-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16872 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72643/ Test PASSed. ---

[GitHub] spark issue #16872: [SPARK-19514] Making range interruptible.

2017-02-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16872 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #16872: [SPARK-19514] Making range interruptible.

2017-02-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16872 **[Test build #72643 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72643/testReport)** for PR 16872 at commit [`7d1c014`](https://github.com/apache/spark/commit/7

[GitHub] spark pull request #16386: [SPARK-18352][SQL] Support parsing multiline json...

2017-02-09 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/16386#discussion_r100332529 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonParser.scala --- @@ -298,22 +312,22 @@ class JacksonParser(

[GitHub] spark issue #16804: [SPARK-19459][SQL] Add Hive datatype (char/varchar) to S...

2017-02-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16804 **[Test build #72648 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72648/testReport)** for PR 16804 at commit [`21be4ca`](https://github.com/apache/spark/commit/21

[GitHub] spark issue #16872: [SPARK-19514] Making range interruptible.

2017-02-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16872 **[Test build #72647 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72647/testReport)** for PR 16872 at commit [`bb5a1da`](https://github.com/apache/spark/commit/bb

[GitHub] spark pull request #16787: [SPARK-19448][SQL]optimize some duplication funct...

2017-02-09 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16787#discussion_r100329892 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala --- @@ -845,10 +855,10 @@ private[hive] class HiveClientImpl(

[GitHub] spark issue #16228: [SPARK-17076] [SQL] Cardinality estimation for join base...

2017-02-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16228 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72642/ Test PASSed. ---

[GitHub] spark issue #16228: [SPARK-17076] [SQL] Cardinality estimation for join base...

2017-02-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16228 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #16228: [SPARK-17076] [SQL] Cardinality estimation for join base...

2017-02-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16228 **[Test build #72642 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72642/testReport)** for PR 16228 at commit [`7e52a83`](https://github.com/apache/spark/commit/7

[GitHub] spark pull request #15009: [SPARK-17443][SPARK-11035] Stop Spark Application...

2017-02-09 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/15009#discussion_r100320712 --- Diff: resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala --- @@ -1149,13 +1179,23 @@ private object Client extends Loggi

[GitHub] spark pull request #15009: [SPARK-17443][SPARK-11035] Stop Spark Application...

2017-02-09 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/15009#discussion_r100313659 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala --- @@ -719,7 +719,20 @@ object SparkSubmit extends CommandLineUtils { p

[GitHub] spark pull request #15009: [SPARK-17443][SPARK-11035] Stop Spark Application...

2017-02-09 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/15009#discussion_r100312242 --- Diff: core/src/main/scala/org/apache/spark/SparkApp.scala --- @@ -0,0 +1,40 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

[GitHub] spark pull request #15009: [SPARK-17443][SPARK-11035] Stop Spark Application...

2017-02-09 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/15009#discussion_r100318015 --- Diff: launcher/src/main/java/org/apache/spark/launcher/package-info.java --- @@ -49,6 +49,38 @@ * * * + * Currently, for curre

[GitHub] spark pull request #15009: [SPARK-17443][SPARK-11035] Stop Spark Application...

2017-02-09 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/15009#discussion_r100318779 --- Diff: launcher/src/main/java/org/apache/spark/launcher/package-info.java --- @@ -49,6 +49,38 @@ * * * + * Currently, for curre

[GitHub] spark pull request #15009: [SPARK-17443][SPARK-11035] Stop Spark Application...

2017-02-09 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/15009#discussion_r100312144 --- Diff: core/src/main/scala/org/apache/spark/SparkApp.scala --- @@ -0,0 +1,40 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

[GitHub] spark pull request #15009: [SPARK-17443][SPARK-11035] Stop Spark Application...

2017-02-09 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/15009#discussion_r100313512 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala --- @@ -719,7 +719,20 @@ object SparkSubmit extends CommandLineUtils { p

[GitHub] spark pull request #15009: [SPARK-17443][SPARK-11035] Stop Spark Application...

2017-02-09 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/15009#discussion_r100318547 --- Diff: launcher/src/main/java/org/apache/spark/launcher/package-info.java --- @@ -49,6 +49,38 @@ * * * + * Currently, for curre

[GitHub] spark pull request #15009: [SPARK-17443][SPARK-11035] Stop Spark Application...

2017-02-09 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/15009#discussion_r100316402 --- Diff: launcher/src/main/java/org/apache/spark/launcher/SparkLauncher.java --- @@ -94,6 +103,13 @@ static final Map launcherConfig = new H

[GitHub] spark pull request #15009: [SPARK-17443][SPARK-11035] Stop Spark Application...

2017-02-09 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/15009#discussion_r100316424 --- Diff: launcher/src/main/java/org/apache/spark/launcher/SparkLauncher.java --- @@ -94,6 +103,13 @@ static final Map launcherConfig = new H

<    1   2   3   4   5   6   >