[GitHub] spark pull request #16750: [SPARK-18937][SQL] Timezone support in CSV/JSON p...

2017-02-12 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/16750#discussion_r100729875 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/csv/CSVSuite.scala --- @@ -859,6 +859,48 @@ class CSVSuite extends QueryTest wi

[GitHub] spark pull request #16750: [SPARK-18937][SQL] Timezone support in CSV/JSON p...

2017-02-12 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/16750#discussion_r100729866 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JSONOptions.scala --- @@ -58,13 +59,15 @@ private[sql] class JSONOptions( pr

[GitHub] spark issue #16776: [SPARK-19436][SQL] Add missing tests for approxQuantile

2017-02-12 Thread zhengruifeng
Github user zhengruifeng commented on the issue: https://github.com/apache/spark/pull/16776 https://issues.apache.org/jira/browse/SPARK-19573 is created to track the issue on non-consistent na-droping. --- If your project is set up for it, you can reply to this email and have your re

[GitHub] spark issue #16750: [SPARK-18937][SQL] Timezone support in CSV/JSON parsing

2017-02-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16750 **[Test build #72803 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72803/testReport)** for PR 16750 at commit [`a455f4f`](https://github.com/apache/spark/commit/a4

[GitHub] spark pull request #16777: [SPARK-19435][SQL] Type coercion between ArrayTyp...

2017-02-12 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/16777#discussion_r100730262 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala --- @@ -116,48 +114,66 @@ object TypeCoercion {

[GitHub] spark issue #16672: [SPARK-19329][SQL]Reading from or writing to a datasourc...

2017-02-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16672 **[Test build #72804 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72804/testReport)** for PR 16672 at commit [`334e89f`](https://github.com/apache/spark/commit/33

[GitHub] spark pull request #16789: [SPARK-19444][ML][Documentation] Fix imports not ...

2017-02-12 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16789#discussion_r100733678 --- Diff: examples/src/main/java/org/apache/spark/examples/ml/JavaTokenizerExample.java --- @@ -35,13 +35,11 @@ import org.apache.spark.sql.types.M

[GitHub] spark issue #16902: [SPARK-19564][SPARK-19559][SS][KAFKA] KafkaOffsetReader'...

2017-02-12 Thread zsxwing
Github user zsxwing commented on the issue: https://github.com/apache/spark/pull/16902 Good catch. LGTM. Thanks! Merging to master and 2.1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request #16902: [SPARK-19564][SPARK-19559][SS][KAFKA] KafkaOffset...

2017-02-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/16902 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request #16908: [SPARK-19574][ML][Documentation] Fix Liquid Excep...

2017-02-12 Thread gatorsmile
GitHub user gatorsmile opened a pull request: https://github.com/apache/spark/pull/16908 [SPARK-19574][ML][Documentation] Fix Liquid Exception: Start indices amount is not equal to end indices amount ### What changes were proposed in this pull request? ``` Liquid Exception:

[GitHub] spark issue #16908: [SPARK-19574][ML][Documentation] Fix Liquid Exception: S...

2017-02-12 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/16908 cc @srowen @anshbansal --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wish

[GitHub] spark issue #16908: [SPARK-19574][ML][Documentation] Fix Liquid Exception: S...

2017-02-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16908 **[Test build #72805 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72805/testReport)** for PR 16908 at commit [`b97b49b`](https://github.com/apache/spark/commit/b9

[GitHub] spark pull request #16672: [SPARK-19329][SQL]Reading from or writing to a da...

2017-02-12 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16672#discussion_r100734735 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala --- @@ -1431,4 +1432,133 @@ class HiveDDLSuite }

[GitHub] spark pull request #16909: [SPARK-13450] Introduce UnsafeRowExternalArray. C...

2017-02-12 Thread tejasapatil
GitHub user tejasapatil opened a pull request: https://github.com/apache/spark/pull/16909 [SPARK-13450] Introduce UnsafeRowExternalArray. Change SortMergeJoin and WindowExec to use it ## What issue does this PR address ? Jira: https://issues.apache.org/jira/browse/SPARK-134

[GitHub] spark issue #16909: [SPARK-13450] Introduce UnsafeRowExternalArray. Change S...

2017-02-12 Thread tejasapatil
Github user tejasapatil commented on the issue: https://github.com/apache/spark/pull/16909 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] spark pull request #16672: [SPARK-19329][SQL]Reading from or writing to a da...

2017-02-12 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16672#discussion_r100735007 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala --- @@ -1431,4 +1432,133 @@ class HiveDDLSuite }

[GitHub] spark issue #16909: [SPARK-13450] Introduce UnsafeRowExternalArray. Change S...

2017-02-12 Thread tejasapatil
Github user tejasapatil commented on the issue: https://github.com/apache/spark/pull/16909 @rxin : can you please recommend someone who could review this PR ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request #16672: [SPARK-19329][SQL]Reading from or writing to a da...

2017-02-12 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16672#discussion_r100735110 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala --- @@ -1431,4 +1432,133 @@ class HiveDDLSuite }

[GitHub] spark issue #16909: [SPARK-13450] Introduce ExternalAppendOnlyUnsafeRowArray...

2017-02-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16909 **[Test build #72806 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72806/testReport)** for PR 16909 at commit [`e9cdd30`](https://github.com/apache/spark/commit/e9

[GitHub] spark issue #16689: [SPARK-19342][SPARKR] bug fixed in collect method for co...

2017-02-12 Thread titicaca
Github user titicaca commented on the issue: https://github.com/apache/spark/pull/16689 Yes. The JIRA id is SPARK-19342. Thank you for the help and advices :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark issue #16672: [SPARK-19329][SQL]Reading from or writing to a datasourc...

2017-02-12 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/16672 Could you move the test cases to `DDLSuite.scala`? This is not for Hive specific. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub a

[GitHub] spark issue #16868: [SPARK-19115] [SQL] Supporting Create External Table Lik...

2017-02-12 Thread ouyangxiaochen
Github user ouyangxiaochen commented on the issue: https://github.com/apache/spark/pull/16868 Very serious consideration. Thanks for your explanation and suggestion! what do you think? @gatorsmile @cloud-fan --- If your project is set up for it, you can reply to this email and have

[GitHub] spark issue #16908: [SPARK-19574][ML][Documentation] Fix Liquid Exception: S...

2017-02-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16908 **[Test build #72805 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72805/testReport)** for PR 16908 at commit [`b97b49b`](https://github.com/apache/spark/commit/b

[GitHub] spark issue #16908: [SPARK-19574][ML][Documentation] Fix Liquid Exception: S...

2017-02-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16908 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72805/ Test PASSed. ---

[GitHub] spark issue #16908: [SPARK-19574][ML][Documentation] Fix Liquid Exception: S...

2017-02-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16908 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark pull request #16891: [SPARK-19318][SQL] Fix to treat JDBC connection p...

2017-02-12 Thread sureshthalamati
Github user sureshthalamati commented on a diff in the pull request: https://github.com/apache/spark/pull/16891#discussion_r100737351 --- Diff: external/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/OracleIntegrationSuite.scala --- @@ -62,6 +62,12 @@ class Orac

[GitHub] spark pull request #16891: [SPARK-19318][SQL] Fix to treat JDBC connection p...

2017-02-12 Thread sureshthalamati
Github user sureshthalamati commented on a diff in the pull request: https://github.com/apache/spark/pull/16891#discussion_r100737390 --- Diff: external/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/OracleIntegrationSuite.scala --- @@ -149,4 +155,29 @@ class Or

[GitHub] spark pull request #16891: [SPARK-19318][SQL] Fix to treat JDBC connection p...

2017-02-12 Thread sureshthalamati
Github user sureshthalamati commented on a diff in the pull request: https://github.com/apache/spark/pull/16891#discussion_r100737377 --- Diff: external/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/OracleIntegrationSuite.scala --- @@ -149,4 +155,29 @@ class Or

[GitHub] spark pull request #16891: [SPARK-19318][SQL] Fix to treat JDBC connection p...

2017-02-12 Thread sureshthalamati
Github user sureshthalamati commented on a diff in the pull request: https://github.com/apache/spark/pull/16891#discussion_r100737505 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/CaseInsensitiveMap.scala --- @@ -23,16 +23,30 @@ package org.apache.spark.

[GitHub] spark pull request #16891: [SPARK-19318][SQL] Fix to treat JDBC connection p...

2017-02-12 Thread sureshthalamati
Github user sureshthalamati commented on a diff in the pull request: https://github.com/apache/spark/pull/16891#discussion_r100737587 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCWriteSuite.scala --- @@ -75,7 +75,7 @@ class JDBCWriteSuite extends SharedSQLContext

[GitHub] spark issue #16891: [SPARK-19318][SQL] Fix to treat JDBC connection properti...

2017-02-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16891 **[Test build #72807 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72807/testReport)** for PR 16891 at commit [`a156074`](https://github.com/apache/spark/commit/a1

[GitHub] spark issue #16870: [SPARK-19496][SQL]to_date udf to return null when input ...

2017-02-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16870 **[Test build #72798 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72798/testReport)** for PR 16870 at commit [`7238e94`](https://github.com/apache/spark/commit/7

[GitHub] spark issue #16870: [SPARK-19496][SQL]to_date udf to return null when input ...

2017-02-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16870 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72798/ Test PASSed. ---

[GitHub] spark issue #16870: [SPARK-19496][SQL]to_date udf to return null when input ...

2017-02-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16870 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #16868: [SPARK-19115] [SQL] Supporting Create External Table Lik...

2017-02-12 Thread ouyangxiaochen
Github user ouyangxiaochen commented on the issue: https://github.com/apache/spark/pull/16868 Very thoughtful consideration. Thanks for your explanation and suggestion! @tejasapatil what do you think? @gatorsmile @cloud-fan --- If your project is set up for it, you can reply to this

[GitHub] spark issue #16891: [SPARK-19318][SQL] Fix to treat JDBC connection properti...

2017-02-12 Thread sureshthalamati
Github user sureshthalamati commented on the issue: https://github.com/apache/spark/pull/16891 Thank you for reviewing the PR @cloud-fan. Addressed the review comments, please let me know if it requires any further changes. --- If your project is set up for it, you can reply to this

[GitHub] spark issue #16870: [SPARK-19496][SQL]to_date udf to return null when input ...

2017-02-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16870 **[Test build #72799 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72799/testReport)** for PR 16870 at commit [`3b1cfd4`](https://github.com/apache/spark/commit/3

[GitHub] spark pull request #16910: [SPARK-19575][SQL]Reading from or writing to a hi...

2017-02-12 Thread windpiger
GitHub user windpiger opened a pull request: https://github.com/apache/spark/pull/16910 [SPARK-19575][SQL]Reading from or writing to a hive serde table with a non pre-existing location should succeed ## What changes were proposed in this pull request? This PR is a folllowup

[GitHub] spark issue #16870: [SPARK-19496][SQL]to_date udf to return null when input ...

2017-02-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16870 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72799/ Test PASSed. ---

[GitHub] spark issue #16870: [SPARK-19496][SQL]to_date udf to return null when input ...

2017-02-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16870 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #16910: [SPARK-19575][SQL]Reading from or writing to a hive serd...

2017-02-12 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16910 **[Test build #72808 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72808/testReport)** for PR 16910 at commit [`cb98375`](https://github.com/apache/spark/commit/cb

<    1   2   3   4