Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/16898
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/16750
thanks, merging to master!
please address some remaining comments in your next PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16750#discussion_r101386663
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/sources/ResolvedDataSourceSuite.scala
---
@@ -19,11 +19,15 @@ package
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/16672
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16534
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16534
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72951/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16534
**[Test build #72951 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72951/testReport)**
for PR 16534 at commit
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16672
Thanks! Merging to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16672
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/16512
@shivaram No need to revert this, but why was this merged into 2.1? It's a
new API, and we generally don't backport new APIs.
---
If your project is set up for it, you can reply to this email
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16841
test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16537
**[Test build #72953 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72953/testReport)**
for PR 16537 at commit
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/16943#discussion_r101383754
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/SQLExecutionSuite.scala
---
@@ -129,6 +129,8 @@ class SQLExecutionSuite extends
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16943#discussion_r101383173
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/SQLExecutionSuite.scala
---
@@ -129,6 +129,8 @@ class SQLExecutionSuite extends
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/16943#discussion_r101382836
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/SQLExecutionSuite.scala
---
@@ -129,6 +129,8 @@ class SQLExecutionSuite extends
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/16943
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16915
**[Test build #72952 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72952/testReport)**
for PR 16915 at commit
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/16943
Merging in master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/16943#discussion_r101381101
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/SQLExecutionSuite.scala
---
@@ -129,6 +129,8 @@ class SQLExecutionSuite extends
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16841
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16915
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/16940
Hi, @rxin and @ala .
This seems to cause a test failures.
Could you review the hotfix #16943 ?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16943
**[Test build #72950 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72950/testReport)**
for PR 16943 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16534
**[Test build #72951 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72951/testReport)**
for PR 16534 at commit
GitHub user dongjoon-hyun opened a pull request:
https://github.com/apache/spark/pull/16943
[SPARK-19607][HOTFIX] Finding QueryExecution that matches provided
executionId
## What changes were proposed in this pull request?
#16940 adds a test case which does not stop the
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16534
**[Test build #72949 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72949/testReport)**
for PR 16534 at commit
Github user zero323 commented on the issue:
https://github.com/apache/spark/pull/16533
Thanks @holdenk
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user nsyca commented on the issue:
https://github.com/apache/spark/pull/16915
It's larger than typical test PRs we submitted for the subquery JIRA but
since it's the last test PR, we think we wanted to avoid an additional round of
administrative work.
---
If your project is
Github user nsyca commented on a diff in the pull request:
https://github.com/apache/spark/pull/16915#discussion_r101375513
--- Diff:
sql/core/src/test/resources/sql-tests/results/subquery/in-subquery/not-in-joins.sql.out
---
@@ -0,0 +1,229 @@
+-- Automatically generated by
Github user nsyca commented on a diff in the pull request:
https://github.com/apache/spark/pull/16915#discussion_r101374593
--- Diff:
sql/core/src/test/resources/sql-tests/results/subquery/in-subquery/in-set-operations.sql.out
---
@@ -0,0 +1,595 @@
+-- Automatically generated
Github user nsyca commented on a diff in the pull request:
https://github.com/apache/spark/pull/16915#discussion_r101375044
--- Diff:
sql/core/src/test/resources/sql-tests/results/subquery/in-subquery/in-with-cte.sql.out
---
@@ -0,0 +1,364 @@
+-- Automatically generated by
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/16915
@kevinyu98 @nsyca @dilipbiswal could someone confirm that these results
match DB2?
I also think that this PR is almost too large.
---
If your project is set up for it, you can reply to
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16898
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72945/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16898
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16898
**[Test build #72945 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72945/testReport)**
for PR 16898 at commit
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/16901
Jenkins this is OK to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user tejasapatil commented on the issue:
https://github.com/apache/spark/pull/16938
From what I understand, this change is applicable for EXTERNAL tables only.
There are two main uses of EXTERNAL tables I am aware of (repost from
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/16387
@samkum if you can't get back to us with the information we asked for, I'll
just assume that the problem is on your side and push this change. It's been
sitting here already reviewed for long
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/16901
After looking at my other test cleanup PR I realized the "map stage
submission with executor failure late map task completions" test already tests
this functionality, only for map stages that
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16892
**[Test build #72948 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72948/testReport)**
for PR 16892 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14804
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14804
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72944/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14804
**[Test build #72944 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72944/testReport)**
for PR 14804 at commit
Github user budde commented on a diff in the pull request:
https://github.com/apache/spark/pull/16942#discussion_r101366583
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -296,6 +296,17 @@ object SQLConf {
.longConf
Github user budde commented on a diff in the pull request:
https://github.com/apache/spark/pull/16942#discussion_r101366441
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -296,6 +296,17 @@ object SQLConf {
.longConf
Github user budde commented on a diff in the pull request:
https://github.com/apache/spark/pull/16942#discussion_r101366307
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveSchemaInferenceSuite.scala
---
@@ -0,0 +1,162 @@
+/*
+ * Licensed to the Apache
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/16892
Ok I added back the other test but improved the commenting there.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16750#discussion_r101365748
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/csv/CSVSuite.scala
---
@@ -859,6 +859,48 @@ class CSVSuite extends
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/16857#discussion_r101353274
--- Diff:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaSource.scala
---
@@ -97,16 +97,27 @@ private[kafka010] class
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/16857#discussion_r101360629
--- Diff:
external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaSourceSuite.scala
---
@@ -141,6 +142,118 @@ class KafkaSourceSuite
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/16857#discussion_r101359070
--- Diff:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaSource.scala
---
@@ -97,16 +97,27 @@ private[kafka010] class
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/16857#discussion_r101362919
--- Diff:
external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaSourceSuite.scala
---
@@ -141,6 +142,118 @@ class KafkaSourceSuite
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/16857#discussion_r101359300
--- Diff:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaSource.scala
---
@@ -97,16 +97,27 @@ private[kafka010] class
Github user budde commented on the issue:
https://github.com/apache/spark/pull/16942
Pinging participants from #16797: @gatorsmile, @viirya, @ericl, @mallman
and @cloud-fan
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16942
**[Test build #72947 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72947/testReport)**
for PR 16942 at commit
GitHub user budde opened a pull request:
https://github.com/apache/spark/pull/16942
[SPARK-19611][SQL] Introduce configurable table schema inference
Replaces #16797. See the discussion in this PR for more
details/justification for this change.
## Summary of changes
Github user imatiach-msft commented on a diff in the pull request:
https://github.com/apache/spark/pull/16630#discussion_r101362237
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/GeneralizedLinearRegressionSuite.scala
---
@@ -1104,6 +1103,83 @@ class
Github user imatiach-msft commented on a diff in the pull request:
https://github.com/apache/spark/pull/16630#discussion_r101362084
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/GeneralizedLinearRegressionSuite.scala
---
@@ -1104,6 +1103,83 @@ class
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16844
**[Test build #72946 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72946/testReport)**
for PR 16844 at commit
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/16844#discussion_r101360777
--- Diff:
core/src/main/java/org/apache/spark/unsafe/map/BytesToBytesMap.java ---
@@ -742,7 +742,7 @@ public boolean append(Object kbase, long koff, int
Github user budde commented on the issue:
https://github.com/apache/spark/pull/16797
Thanks for all the feedback on this PR, folks. I'm going to close this
PR/JIRA and open new ones for enabling configurable schema inference as a
fallback. I'll ping each of you who has been active in
Github user imatiach-msft commented on the issue:
https://github.com/apache/spark/pull/16630
Thanks for the updates, the changes look good to me. One question, out of
scope of the specific changes in this review: are there any other summary
statistics that we could add in the
Github user budde closed the pull request at:
https://github.com/apache/spark/pull/16797
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16750#discussion_r101357512
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/csv/CSVSuite.scala
---
@@ -859,6 +859,48 @@ class CSVSuite extends
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/16802
@hvanhovell Thank you very much Herman !!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/16811
@srowen could you please kick Jenkins to test this PR? :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user imatiach-msft commented on a diff in the pull request:
https://github.com/apache/spark/pull/16630#discussion_r101357001
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -915,6 +919,23 @@ class
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16674
A late LGTM : )
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16938
We need to define a consistent rule in Catalog how to handle the scenario
when the to-be-created directory already exists. So far, in most DDL scenarios,
when trying to create a directory but it
Github user imatiach-msft commented on a diff in the pull request:
https://github.com/apache/spark/pull/16630#discussion_r101356475
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -1152,4 +1173,33 @@ class
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/16395
Hi @ron8hu , the join PR has been merged and the `Range` stuff is in, can
you update this PR? thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user imatiach-msft commented on a diff in the pull request:
https://github.com/apache/spark/pull/16630#discussion_r101356243
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/GeneralizedLinearRegressionSuite.scala
---
@@ -1104,6 +1103,83 @@ class
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/16739
merged to master and branch-2.1
@gatorsmile thanks - please feel free to update or remove unneeded test
cases.
---
If your project is set up for it, you can reply to this email and have
Github user imatiach-msft commented on a diff in the pull request:
https://github.com/apache/spark/pull/16722#discussion_r101354732
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/DecisionTreeClassifierSuite.scala
---
@@ -351,6 +370,36 @@ class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16674#discussion_r101352242
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -617,13 +617,18 @@ class Analyzer(
private
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/16674
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/16739
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/16674
thanks, merging to master!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/16933#discussion_r101351110
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/CollapseRepartitionSuite.scala
---
@@ -32,6 +32,18 @@ class
Github user imatiach-msft commented on a diff in the pull request:
https://github.com/apache/spark/pull/16722#discussion_r101351063
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tree/impl/BaggedPoint.scala ---
@@ -82,16 +92,16 @@ private[spark] object BaggedPoint {
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/16933#discussion_r101350801
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -563,23 +563,27 @@ object CollapseProject extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16674#discussion_r101350313
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -617,13 +617,18 @@ class Analyzer(
private
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/16722#discussion_r101349655
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/DecisionTreeClassifierSuite.scala
---
@@ -351,6 +370,36 @@ class
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16898
**[Test build #72945 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72945/testReport)**
for PR 16898 at commit
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16933#discussion_r101346606
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/CollapseRepartitionSuite.scala
---
@@ -43,15 +55,44 @@ class
Github user imatiach-msft commented on a diff in the pull request:
https://github.com/apache/spark/pull/16722#discussion_r101346522
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tree/impl/BaggedPoint.scala ---
@@ -60,12 +68,14 @@ private[spark] object BaggedPoint {
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/16533
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/15821#discussion_r101345064
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -2729,6 +2749,18 @@ class Dataset[T] private[sql](
}
}
Github user holdenk commented on the issue:
https://github.com/apache/spark/pull/16533
Thanks for working on this @zero323, merged to master :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15415
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15415
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72943/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15415
**[Test build #72943 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72943/testReport)**
for PR 15415 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/16938
I don't think we should treat it as a bug just because hive supports it, we
should think more. Does it make sense to specify an existing directory in CTAS?
---
If your project is set up for it,
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/16922
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user holdenk commented on the issue:
https://github.com/apache/spark/pull/16922
Thanks for doing the follow up Python work, merged to master :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user imatiach-msft commented on the issue:
https://github.com/apache/spark/pull/16722
the code looks good to me, maybe a contributor can comment? This is a
great feature, nice work!
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user imatiach-msft commented on a diff in the pull request:
https://github.com/apache/spark/pull/16722#discussion_r101342791
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/DecisionTreeClassifierSuite.scala
---
@@ -351,6 +370,36 @@ class
Github user imatiach-msft commented on a diff in the pull request:
https://github.com/apache/spark/pull/16722#discussion_r101342186
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tree/impl/DecisionTreeMetadata.scala
---
@@ -115,7 +122,10 @@ private[spark] object
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16933#discussion_r101342124
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/CollapseRepartitionSuite.scala
---
@@ -32,6 +32,18 @@ class
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16898
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
301 - 400 of 587 matches
Mail list logo
