Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/17043#discussion_r103056297
--- Diff:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaWriter.scala
---
@@ -0,0 +1,106 @@
+/*
+ * Licensed to the Apache
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/14412
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/14412
thanks, merging to master!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wi
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/17043#discussion_r103056078
--- Diff:
external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaSinkSuite.scala
---
@@ -0,0 +1,413 @@
+/*
+ * Licensed to the Apac
Github user datumbox commented on a diff in the pull request:
https://github.com/apache/spark/pull/17059#discussion_r103055703
--- Diff: mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala
---
@@ -82,12 +82,20 @@ private[recommendation] trait ALSModelParams extends
P
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/17043#discussion_r103043531
--- Diff:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaSourceProvider.scala
---
@@ -152,6 +157,56 @@ private[kafka010] class Kafk
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/17043#discussion_r103039701
--- Diff:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaSink.scala
---
@@ -0,0 +1,41 @@
+/*
+ * Licensed to the Apache Sof
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/17043#discussion_r103043927
--- Diff:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaWriter.scala
---
@@ -0,0 +1,106 @@
+/*
+ * Licensed to the Apache
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/17043#discussion_r103033329
--- Diff:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaSource.scala
---
@@ -346,5 +346,5 @@ private[kafka010] object KafkaSource
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/17043#discussion_r103045028
--- Diff:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaWriter.scala
---
@@ -0,0 +1,106 @@
+/*
+ * Licensed to the Apache
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/17043#discussion_r103044512
--- Diff:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaWriter.scala
---
@@ -0,0 +1,106 @@
+/*
+ * Licensed to the Apache
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/17043#discussion_r103044371
--- Diff:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaWriter.scala
---
@@ -0,0 +1,106 @@
+/*
+ * Licensed to the Apache
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/17043#discussion_r103053838
--- Diff:
external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaSinkSuite.scala
---
@@ -0,0 +1,413 @@
+/*
+ * Licensed to the Apac
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/17043#discussion_r103044757
--- Diff:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaWriter.scala
---
@@ -0,0 +1,106 @@
+/*
+ * Licensed to the Apache
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/17043#discussion_r103052449
--- Diff:
external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaSinkSuite.scala
---
@@ -0,0 +1,413 @@
+/*
+ * Licensed to the Apac
Github user holdenk commented on the issue:
https://github.com/apache/spark/pull/15666
Do you have a chance to update this to master @mariusvniekerk? In the
meantime maybe @rxin or @brkyvz want to take a look as well?
---
If your project is set up for it, you can reply to this email
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/17043#discussion_r103053432
--- Diff:
external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaSinkSuite.scala
---
@@ -0,0 +1,413 @@
+/*
+ * Licensed to the Apac
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/17043#discussion_r103043738
--- Diff:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaSourceProvider.scala
---
@@ -377,10 +432,11 @@ private[kafka010] class Kaf
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/17043#discussion_r103039931
--- Diff:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaSourceProvider.scala
---
@@ -152,6 +157,56 @@ private[kafka010] class Kafk
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/17043#discussion_r103043568
--- Diff:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaSourceProvider.scala
---
@@ -152,6 +157,56 @@ private[kafka010] class Kafk
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/17043#discussion_r103046651
--- Diff:
external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaSinkSuite.scala
---
@@ -0,0 +1,413 @@
+/*
+ * Licensed to the Apac
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/17043#discussion_r103033150
--- Diff:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaSink.scala
---
@@ -0,0 +1,41 @@
+/*
+ * Licensed to the Apache Sof
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/17043#discussion_r103053768
--- Diff:
external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaSinkSuite.scala
---
@@ -0,0 +1,413 @@
+/*
+ * Licensed to the Apac
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/17043#discussion_r103033292
--- Diff:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaSink.scala
---
@@ -0,0 +1,41 @@
+/*
+ * Licensed to the Apache Sof
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/17043#discussion_r103039812
--- Diff:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaSink.scala
---
@@ -0,0 +1,41 @@
+/*
+ * Licensed to the Apache Sof
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/17043#discussion_r103053627
--- Diff:
external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaSinkSuite.scala
---
@@ -0,0 +1,413 @@
+/*
+ * Licensed to the Apac
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16944#discussion_r103055530
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -510,8 +510,13 @@ private[spark] class HiveExternalCatalog(co
Github user ash211 commented on the issue:
https://github.com/apache/spark/pull/16959
@vanzin are you right person to review this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17059
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feat
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/16845#discussion_r103054615
--- Diff: python/pyspark/util.py ---
@@ -0,0 +1,45 @@
+# -*- coding: utf-8 -*-
+#
+# Licensed to the Apache Software Foundation (ASF) under one o
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/17043#discussion_r103054126
--- Diff:
external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaSinkSuite.scala
---
@@ -0,0 +1,413 @@
+/*
+ * Licensed to the A
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/17043#discussion_r103047334
--- Diff:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaSourceProvider.scala
---
@@ -152,6 +157,56 @@ private[kafka010] class K
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/17043#discussion_r103053743
--- Diff:
external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaSinkSuite.scala
---
@@ -0,0 +1,413 @@
+/*
+ * Licensed to the A
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/17043#discussion_r103049620
--- Diff:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaWriteTask.scala
---
@@ -0,0 +1,119 @@
+/*
+ * Licensed to the A
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/17043#discussion_r103049550
--- Diff:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaWriteTask.scala
---
@@ -0,0 +1,119 @@
+/*
+ * Licensed to the A
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/17043#discussion_r103050112
--- Diff:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaWriteTask.scala
---
@@ -0,0 +1,119 @@
+/*
+ * Licensed to the A
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/16845#discussion_r101346487
--- Diff: python/pyspark/broadcast.py ---
@@ -82,7 +83,8 @@ def dump(self, value, f):
except pickle.PickleError:
raise
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/17043#discussion_r103044313
--- Diff:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaSink.scala
---
@@ -0,0 +1,41 @@
+/*
+ * Licensed to the Apache
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/17043#discussion_r103049353
--- Diff:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaWriteTask.scala
---
@@ -0,0 +1,119 @@
+/*
+ * Licensed to the A
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/17043#discussion_r103053544
--- Diff:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaSourceProvider.scala
---
@@ -152,6 +157,56 @@ private[kafka010] class K
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/17043#discussion_r103045768
--- Diff:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaSourceProvider.scala
---
@@ -377,10 +432,11 @@ private[kafka010] class
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/17043#discussion_r103050085
--- Diff:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaWriteTask.scala
---
@@ -0,0 +1,119 @@
+/*
+ * Licensed to the A
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/17043#discussion_r103052166
--- Diff:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaWriter.scala
---
@@ -0,0 +1,106 @@
+/*
+ * Licensed to the Apac
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/17043#discussion_r103053368
--- Diff:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaWriter.scala
---
@@ -0,0 +1,106 @@
+/*
+ * Licensed to the Apac
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/17043#discussion_r103048542
--- Diff:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaWriteTask.scala
---
@@ -0,0 +1,119 @@
+/*
+ * Licensed to the A
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/17043#discussion_r103054866
--- Diff:
external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaSinkSuite.scala
---
@@ -0,0 +1,413 @@
+/*
+ * Licensed to the A
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/17043#discussion_r103044379
--- Diff:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaSink.scala
---
@@ -0,0 +1,41 @@
+/*
+ * Licensed to the Apache
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/17043#discussion_r103053285
--- Diff:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaWriter.scala
---
@@ -0,0 +1,106 @@
+/*
+ * Licensed to the Apac
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/17043#discussion_r103054142
--- Diff:
external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaSinkSuite.scala
---
@@ -0,0 +1,413 @@
+/*
+ * Licensed to the A
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/17043#discussion_r103054319
--- Diff:
external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaSinkSuite.scala
---
@@ -0,0 +1,413 @@
+/*
+ * Licensed to the A
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/17043#discussion_r103053352
--- Diff:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaWriter.scala
---
@@ -0,0 +1,106 @@
+/*
+ * Licensed to the Apac
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/17043#discussion_r103048422
--- Diff:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaWriteTask.scala
---
@@ -0,0 +1,119 @@
+/*
+ * Licensed to the A
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/17043#discussion_r103050143
--- Diff:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaWriteTask.scala
---
@@ -0,0 +1,119 @@
+/*
+ * Licensed to the A
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/17043#discussion_r103047462
--- Diff:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaSourceProvider.scala
---
@@ -152,6 +157,56 @@ private[kafka010] class K
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/17043#discussion_r103046697
--- Diff:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaSourceProvider.scala
---
@@ -152,6 +157,56 @@ private[kafka010] class K
GitHub user datumbox opened a pull request:
https://github.com/apache/spark/pull/17059
Removed unnecessary castings and refactored checked casts in ALS.
## What changes were proposed in this pull request?
The original ALS was performing unnecessary casting to the user and it
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/15821#discussion_r103052418
--- Diff: python/pyspark/sql/dataframe.py ---
@@ -1610,8 +1623,14 @@ def toPandas(self):
02 Alice
15Bob
"
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/15821#discussion_r103052508
--- Diff: python/pyspark/sql/dataframe.py ---
@@ -1597,11 +1607,14 @@ def toDF(self, *cols):
return DataFrame(jdf, self.sql_ctx)
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/15821#discussion_r103047241
--- Diff: python/pyspark/sql/dataframe.py ---
@@ -391,6 +392,15 @@ def collect(self):
return list(_load_from_socket(port,
BatchedSerializer(Pic
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/15821#discussion_r103047178
--- Diff: python/pyspark/serializers.py ---
@@ -182,6 +182,23 @@ def loads(self, obj):
raise NotImplementedError
+class ArrowSer
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/15821#discussion_r103052601
--- Diff: python/pyspark/sql/dataframe.py ---
@@ -391,6 +392,15 @@ def collect(self):
return list(_load_from_socket(port,
BatchedSerializer(Pic
Github user holdenk commented on the issue:
https://github.com/apache/spark/pull/11211
thanks @zjffdu , merged to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16845
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16845
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73446/
Test PASSed.
---
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/11211
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16845
**[Test build #73446 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73446/testReport)**
for PR 16845 at commit
[`7b8ace4`](https://github.com/apache/spark/commit/7
Github user holdenk commented on the issue:
https://github.com/apache/spark/pull/14963
That's a reasonable question, I'll try and look at this some next week but
if you've got a chance to look at/address the current comments on it that would
be great.
---
If your project is set up f
Github user holdenk commented on the issue:
https://github.com/apache/spark/pull/10307
Gentle ping @zjffdu :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes s
Github user hejix commented on the issue:
https://github.com/apache/spark/pull/17012
@zsxwing Is it possible for you to give some approximate timeframe for when
this might be accepted? A week or month? Since we are blocked in our spark
streaming adoption (this HDFS error happens not o
Github user budde commented on a diff in the pull request:
https://github.com/apache/spark/pull/16944#discussion_r103051801
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala ---
@@ -226,6 +258,41 @@ private[hive] class HiveMetastoreCatalog(spark
Github user Yunni commented on the issue:
https://github.com/apache/spark/pull/16965
@merlintang
(1) `hashDistance` is only used for multi-probe NN Search. The term
`numHashTables`, `numHashFunctions` is very hard to interpret in OR-AND cases.
(2) For similarity join, we
Github user budde commented on a diff in the pull request:
https://github.com/apache/spark/pull/16944#discussion_r103051158
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala ---
@@ -226,6 +258,41 @@ private[hive] class HiveMetastoreCatalog(spark
Github user budde commented on a diff in the pull request:
https://github.com/apache/spark/pull/16944#discussion_r103050652
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -510,8 +510,13 @@ private[spark] class HiveExternalCatalog(conf:
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/17027
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fea
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17027#discussion_r103050359
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/QueryExecution.scala ---
@@ -125,8 +125,6 @@ class QueryExecution(val sparkSession: Spark
Github user steveloughran commented on the issue:
https://github.com/apache/spark/pull/16927
I'm worrying about this now: have my attempts to fix the messages gone
horribly wrong. Admittedly, it was sitting in a Budapest airport with a
post-ApacheCon hangover, but @afs was giving real
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17027#discussion_r103050183
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -175,19 +175,14 @@ class Dataset[T] private[sql](
}
@transi
Github user budde commented on a diff in the pull request:
https://github.com/apache/spark/pull/16944#discussion_r103050192
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala ---
@@ -226,6 +258,41 @@ private[hive] class HiveMetastoreCatalog(spark
Github user budde commented on a diff in the pull request:
https://github.com/apache/spark/pull/16944#discussion_r103050080
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala ---
@@ -161,22 +164,51 @@ private[hive] class
HiveMetastoreCatalog(spa
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16944#discussion_r103050028
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala ---
@@ -226,6 +258,41 @@ private[hive] class HiveMetastoreCatalog(s
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16944#discussion_r103049915
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala ---
@@ -226,6 +258,41 @@ private[hive] class HiveMetastoreCatalog(s
Github user budde commented on a diff in the pull request:
https://github.com/apache/spark/pull/16944#discussion_r103049838
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -296,6 +296,25 @@ object SQLConf {
.longConf
.creat
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16944#discussion_r103049597
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala ---
@@ -161,22 +164,51 @@ private[hive] class
HiveMetastoreCatalog
Github user budde commented on a diff in the pull request:
https://github.com/apache/spark/pull/16944#discussion_r103049381
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -296,6 +296,25 @@ object SQLConf {
.longConf
.creat
Github user budde commented on a diff in the pull request:
https://github.com/apache/spark/pull/16944#discussion_r103049359
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/internal/SQLConfSuite.scala ---
@@ -21,6 +21,7 @@ import org.apache.hadoop.fs.Path
import or
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16944#discussion_r103049318
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -296,6 +296,25 @@ object SQLConf {
.longConf
.c
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/16929
Sure, let me take a look and try.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabl
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14830
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73445/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14830
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14830
**[Test build #73445 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73445/testReport)**
for PR 14830 at commit
[`582c822`](https://github.com/apache/spark/commit/5
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16845
**[Test build #73446 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73446/testReport)**
for PR 16845 at commit
[`7b8ace4`](https://github.com/apache/spark/commit/7b
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16944#discussion_r103048200
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -510,8 +510,13 @@ private[spark] class HiveExternalCatalog(co
Github user holdenk commented on the issue:
https://github.com/apache/spark/pull/16845
Ok in theory I've been added, so lets see Jenkins test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project do
Github user holdenk commented on the issue:
https://github.com/apache/spark/pull/14579
Do you have time to update this @MLnick or maybe would it be OK if someone
else made an updated PR based on this? It would be a nice feature to have for
2.2 :)
---
If your project is set up for it
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16944#discussion_r103047268
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/internal/SQLConfSuite.scala ---
@@ -21,6 +21,7 @@ import org.apache.hadoop.fs.Path
impor
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16944#discussion_r103046982
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -296,6 +296,25 @@ object SQLConf {
.longConf
.c
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16944
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73444/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16944
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16944
**[Test build #73444 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73444/testReport)**
for PR 16944 at commit
[`e1ca7c8`](https://github.com/apache/spark/commit/e
Github user BryanCutler commented on the issue:
https://github.com/apache/spark/pull/16774
Hi @thunterdb , thanks for the review and all of the details you provided!
I agree that a configurable execution service would be needed for running under
a shared environment instead of simply
201 - 300 of 569 matches
Mail list logo
