[GitHub] spark issue #17062: [SPARK-17495] [SQL] Support date, timestamp and interval...

2017-03-04 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/17062 It sounds like no test case covers nanosecond for INTERVAL --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does no

[GitHub] spark issue #17159: [SPARK-19818][SparkR] union should check for name consis...

2017-03-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17159 **[Test build #73895 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73895/testReport)** for PR 17159 at commit [`293dc35`](https://github.com/apache/spark/commit/29

[GitHub] spark pull request #17062: [SPARK-17495] [SQL] Support date, timestamp and i...

2017-03-04 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17062#discussion_r104282934 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/hash.scala --- @@ -732,6 +741,38 @@ object HiveHashFunction extends Int

[GitHub] spark pull request #17116: [SPARK-18890][CORE](try 2) Move task serializatio...

2017-03-04 Thread witgo
Github user witgo closed the pull request at: https://github.com/apache/spark/pull/17116 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark issue #17159: [SPARK-19818][SparkR] union should check for name consis...

2017-03-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17159 **[Test build #73895 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73895/testReport)** for PR 17159 at commit [`293dc35`](https://github.com/apache/spark/commit/2

[GitHub] spark issue #17159: [SPARK-19818][SparkR] union should check for name consis...

2017-03-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17159 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73895/ Test FAILed. ---

[GitHub] spark issue #17159: [SPARK-19818][SparkR] union should check for name consis...

2017-03-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17159 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark pull request #17161: [SPARK-19819][SparkR] Use concrete data in SparkR...

2017-03-04 Thread actuaryzhang
GitHub user actuaryzhang opened a pull request: https://github.com/apache/spark/pull/17161 [SPARK-19819][SparkR] Use concrete data in SparkR DataFrame examples ## What changes were proposed in this pull request? Many examples in SparkDataFrame methods uses: ``` path <- "p

[GitHub] spark issue #17161: [SPARK-19819][SparkR] Use concrete data in SparkR DataFr...

2017-03-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17161 **[Test build #73896 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73896/testReport)** for PR 17161 at commit [`c4c14ad`](https://github.com/apache/spark/commit/c4

[GitHub] spark pull request #17161: [SPARK-19819][SparkR] Use concrete data in SparkR...

2017-03-04 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/17161#discussion_r104283930 --- Diff: R/pkg/R/DataFrame.R --- @@ -92,8 +92,7 @@ dataFrame <- function(sdf, isCached = FALSE) { #' @examples #'\dontrun{ #' sparkR.sess

[GitHub] spark issue #17161: [SPARK-19819][SparkR] Use concrete data in SparkR DataFr...

2017-03-04 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/17161 This rings a bell to me. I opened a PR https://github.com/apache/spark/pull/16824 to make the examples in Python API doc as self-contained ones but closed as it seems not having much interests

[GitHub] spark issue #17159: [SPARK-19818][SparkR] union should check for name consis...

2017-03-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17159 **[Test build #73897 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73897/testReport)** for PR 17159 at commit [`ef84501`](https://github.com/apache/spark/commit/ef

[GitHub] spark issue #17160: [SPARK-19701][SQL][PYTHON] Throws a correct exception fo...

2017-03-04 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/17160 **without `__contains__`, `__nonzero__` and `__bool__`** ```python class Column(object): pass >>> 1 in Column() Traceback (most recent call last): File "", line 1,

[GitHub] spark issue #17160: [SPARK-19701][SQL][PYTHON] Throws a correct exception fo...

2017-03-04 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/17160 So.. it seems ```python TypeError: argument of type 'int' is not iterable ``` vs ```python ValueError: Cannot apply 'in' operator against a column: please u

[GitHub] spark issue #17161: [SPARK-19819][SparkR] Use concrete data in SparkR DataFr...

2017-03-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17161 **[Test build #73896 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73896/testReport)** for PR 17161 at commit [`c4c14ad`](https://github.com/apache/spark/commit/c

[GitHub] spark issue #17161: [SPARK-19819][SparkR] Use concrete data in SparkR DataFr...

2017-03-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17161 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73896/ Test PASSed. ---

[GitHub] spark issue #17161: [SPARK-19819][SparkR] Use concrete data in SparkR DataFr...

2017-03-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17161 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #17132: [SPARK-19792][webui]In the Master Page,the column named ...

2017-03-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17132 **[Test build #3594 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3594/testReport)** for PR 17132 at commit [`6794b6b`](https://github.com/apache/spark/commit/6

[GitHub] spark issue #17159: [SPARK-19818][SparkR] union should check for name consis...

2017-03-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17159 **[Test build #73897 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73897/testReport)** for PR 17159 at commit [`ef84501`](https://github.com/apache/spark/commit/e

[GitHub] spark issue #17159: [SPARK-19818][SparkR] union should check for name consis...

2017-03-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17159 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #17159: [SPARK-19818][SparkR] union should check for name consis...

2017-03-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17159 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73897/ Test PASSed. ---

[GitHub] spark pull request #17125: [SPARK-19211][SQL] Explicitly prevent Insert into...

2017-03-04 Thread jiangxb1987
Github user jiangxb1987 commented on a diff in the pull request: https://github.com/apache/spark/pull/17125#discussion_r104284763 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala --- @@ -1329,6 +1329,15 @@ class SparkSqlAstBuilder(conf: SQLConf)

[GitHub] spark pull request #17125: [SPARK-19211][SQL] Explicitly prevent Insert into...

2017-03-04 Thread jiangxb1987
Github user jiangxb1987 commented on a diff in the pull request: https://github.com/apache/spark/pull/17125#discussion_r104284787 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -604,7 +604,7 @@ class Analyzer( def

[GitHub] spark issue #17031: [SPARK-19702][MESOS] Increase default refuse_seconds tim...

2017-03-04 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/17031 Compared to the title, this looks like a significant change, still. Is the intent something different from the JIRA? this doens't just increase a default. I don't have any opinion on the changes, jus

[GitHub] spark pull request #17161: [SPARK-19819][SparkR] Use concrete data in SparkR...

2017-03-04 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/17161#discussion_r104284980 --- Diff: R/pkg/R/DataFrame.R --- @@ -92,8 +92,7 @@ dataFrame <- function(sdf, isCached = FALSE) { #' @examples #'\dontrun{ #' sparkR.session()

[GitHub] spark pull request #16910: [SPARK-19575][SQL]Reading from or writing to a hi...

2017-03-04 Thread windpiger
Github user windpiger commented on a diff in the pull request: https://github.com/apache/spark/pull/16910#discussion_r104285450 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala --- @@ -1588,6 +1590,153 @@ class HiveDDLSuite }

[GitHub] spark pull request #17122: [SPARK-19786][SQL] Facilitate loop optimizations ...

2017-03-04 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/17122#discussion_r104285537 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala --- @@ -206,6 +206,21 @@ trait CodegenSupport extends SparkPlan

[GitHub] spark issue #17122: [SPARK-19786][SQL] Facilitate loop optimizations in a JI...

2017-03-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17122 **[Test build #73898 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73898/testReport)** for PR 17122 at commit [`e6740a5`](https://github.com/apache/spark/commit/e6

[GitHub] spark pull request #17138: [SPARK-17080] [SQL] join reorder

2017-03-04 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/17138#discussion_r104285885 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/CostBasedJoinReorder.scala --- @@ -0,0 +1,274 @@ +/* + * Licensed to th

[GitHub] spark pull request #17138: [SPARK-17080] [SQL] join reorder

2017-03-04 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/17138#discussion_r104285948 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/CostBasedJoinReorder.scala --- @@ -0,0 +1,274 @@ +/* + * Licensed to th

[GitHub] spark issue #17031: [SPARK-19702][MESOS] Increase default refuse_seconds tim...

2017-03-04 Thread skonto
Github user skonto commented on the issue: https://github.com/apache/spark/pull/17031 @mgummelt do we wan to keep the suppress/revive technique? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not hav

[GitHub] spark pull request #17120: [SPARK-19715][Structured Streaming] Option to Str...

2017-03-04 Thread steveloughran
Github user steveloughran commented on a diff in the pull request: https://github.com/apache/spark/pull/17120#discussion_r104286483 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/streaming/FileStreamSourceSuite.scala --- @@ -1253,8 +1253,26 @@ class FileStreamSourceSuite e

[GitHub] spark issue #17132: [SPARK-19792][webui]In the Master Page,the column named ...

2017-03-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17132 **[Test build #3594 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3594/testReport)** for PR 17132 at commit [`6794b6b`](https://github.com/apache/spark/commit/

[GitHub] spark issue #17150: [SPARK-19810][WIP][BUILD][CORE] Remove support for Scala...

2017-03-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17150 **[Test build #73899 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73899/testReport)** for PR 17150 at commit [`1d12539`](https://github.com/apache/spark/commit/1d

[GitHub] spark issue #17150: [SPARK-19810][WIP][BUILD][CORE] Remove support for Scala...

2017-03-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17150 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73899/ Test FAILed. ---

[GitHub] spark issue #17150: [SPARK-19810][WIP][BUILD][CORE] Remove support for Scala...

2017-03-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17150 **[Test build #73899 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73899/testReport)** for PR 17150 at commit [`1d12539`](https://github.com/apache/spark/commit/1

[GitHub] spark issue #17150: [SPARK-19810][WIP][BUILD][CORE] Remove support for Scala...

2017-03-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17150 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #12004: [SPARK-7481] [build] Add spark-cloud module to pull in o...

2017-03-04 Thread steveloughran
Github user steveloughran commented on the issue: https://github.com/apache/spark/pull/12004 comments? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or i

[GitHub] spark pull request #17138: [SPARK-17080] [SQL] join reorder

2017-03-04 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/17138#discussion_r104287073 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/CostBasedJoinReorder.scala --- @@ -0,0 +1,274 @@ +/* + * Licensed

[GitHub] spark issue #17122: [SPARK-19786][SQL] Facilitate loop optimizations in a JI...

2017-03-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17122 **[Test build #73898 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73898/testReport)** for PR 17122 at commit [`e6740a5`](https://github.com/apache/spark/commit/e

[GitHub] spark issue #17122: [SPARK-19786][SQL] Facilitate loop optimizations in a JI...

2017-03-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17122 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #17122: [SPARK-19786][SQL] Facilitate loop optimizations in a JI...

2017-03-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17122 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73898/ Test PASSed. ---

[GitHub] spark pull request #17138: [SPARK-17080] [SQL] join reorder

2017-03-04 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/17138#discussion_r104287124 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala --- @@ -288,6 +288,9 @@ case class Join(

[GitHub] spark pull request #12004: [SPARK-7481] [build] Add spark-cloud module to pu...

2017-03-04 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/12004#discussion_r104287128 --- Diff: pom.xml --- @@ -2586,6 +2591,100 @@ 3.4.6 2.6.0 + + + +

[GitHub] spark pull request #12004: [SPARK-7481] [build] Add spark-cloud module to pu...

2017-03-04 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/12004#discussion_r104287049 --- Diff: cloud/pom.xml --- @@ -0,0 +1,158 @@ + + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; xs

[GitHub] spark pull request #12004: [SPARK-7481] [build] Add spark-cloud module to pu...

2017-03-04 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/12004#discussion_r104287097 --- Diff: cloud/pom.xml --- @@ -0,0 +1,158 @@ + + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; xs

[GitHub] spark pull request #12004: [SPARK-7481] [build] Add spark-cloud module to pu...

2017-03-04 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/12004#discussion_r104287112 --- Diff: docs/storage-openstack-swift.md --- @@ -19,41 +20,32 @@ Although not mandatory, it is recommended to configure the proxy server of Swift

[GitHub] spark pull request #12004: [SPARK-7481] [build] Add spark-cloud module to pu...

2017-03-04 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/12004#discussion_r104287086 --- Diff: cloud/pom.xml --- @@ -0,0 +1,158 @@ + + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; xs

[GitHub] spark pull request #12004: [SPARK-7481] [build] Add spark-cloud module to pu...

2017-03-04 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/12004#discussion_r104287069 --- Diff: cloud/pom.xml --- @@ -0,0 +1,158 @@ + + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; xs

[GitHub] spark pull request #12004: [SPARK-7481] [build] Add spark-cloud module to pu...

2017-03-04 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/12004#discussion_r104287105 --- Diff: cloud/pom.xml --- @@ -0,0 +1,158 @@ + + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; xs

[GitHub] spark pull request #17138: [SPARK-17080] [SQL] join reorder

2017-03-04 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/17138#discussion_r104287137 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/CostBasedJoinReorder.scala --- @@ -0,0 +1,274 @@ +/* + * Licensed

[GitHub] spark pull request #17138: [SPARK-17080] [SQL] join reorder

2017-03-04 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/17138#discussion_r104287149 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/CostBasedJoinReorder.scala --- @@ -0,0 +1,274 @@ +/* + * Licensed

[GitHub] spark pull request #16954: [SPARK-18874][SQL] First phase: Deferring the cor...

2017-03-04 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/16954#discussion_r104287344 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala --- @@ -109,6 +109,26 @@ object TypeCoercion { }

[GitHub] spark pull request #17120: [SPARK-19715][Structured Streaming] Option to Str...

2017-03-04 Thread lw-lin
Github user lw-lin commented on a diff in the pull request: https://github.com/apache/spark/pull/17120#discussion_r104287612 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/streaming/FileStreamSourceSuite.scala --- @@ -1253,8 +1253,26 @@ class FileStreamSourceSuite extends

[GitHub] spark issue #17120: [SPARK-19715][Structured Streaming] Option to Strip Path...

2017-03-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17120 **[Test build #73900 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73900/testReport)** for PR 17120 at commit [`f9e525e`](https://github.com/apache/spark/commit/f9

[GitHub] spark pull request #17162: [SPARK-19550][SparkR][DOCS] Update R document to ...

2017-03-04 Thread wangyum
GitHub user wangyum opened a pull request: https://github.com/apache/spark/pull/17162 [SPARK-19550][SparkR][DOCS] Update R document to use JDK8 ## What changes were proposed in this pull request? Update R document to use JDK8. ## How was this patch tested?

[GitHub] spark issue #17162: [SPARK-19550][SparkR][DOCS] Update R document to use JDK...

2017-03-04 Thread wangyum
Github user wangyum commented on the issue: https://github.com/apache/spark/pull/17162 cc @srowen --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark pull request #17075: [SPARK-19727][SQL] Fix for round function that mo...

2017-03-04 Thread wojtek-szymanski
Github user wojtek-szymanski commented on a diff in the pull request: https://github.com/apache/spark/pull/17075#discussion_r104287923 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/MathFunctionsSuite.scala --- @@ -233,6 +233,18 @@ class MathFunctionsSuite extends QueryTest

[GitHub] spark issue #17162: [SPARK-19550][SparkR][DOCS] Update R document to use JDK...

2017-03-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17162 **[Test build #73901 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73901/testReport)** for PR 17162 at commit [`212c829`](https://github.com/apache/spark/commit/21

[GitHub] spark pull request #17075: [SPARK-19727][SQL] Fix for round function that mo...

2017-03-04 Thread wojtek-szymanski
Github user wojtek-szymanski commented on a diff in the pull request: https://github.com/apache/spark/pull/17075#discussion_r104288067 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/types/Decimal.scala --- @@ -223,6 +224,18 @@ final class Decimal extends Ordered[Decimal

[GitHub] spark pull request #17075: [SPARK-19727][SQL] Fix for round function that mo...

2017-03-04 Thread wojtek-szymanski
Github user wojtek-szymanski commented on a diff in the pull request: https://github.com/apache/spark/pull/17075#discussion_r104288088 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/MathFunctionsSuite.scala --- @@ -233,6 +233,18 @@ class MathFunctionsSuite extends QueryTest

[GitHub] spark issue #17068: [SPARK-19709][SQL] Read empty file with CSV data source

2017-03-04 Thread wojtek-szymanski
Github user wojtek-szymanski commented on the issue: https://github.com/apache/spark/pull/17068 @HyukjinKwon can somebody allow to test this PR as there are no more comments? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as wel

[GitHub] spark pull request #17138: [SPARK-17080] [SQL] join reorder

2017-03-04 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/17138#discussion_r104288256 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/CostBasedJoinReorder.scala --- @@ -0,0 +1,274 @@ +/* + * Licensed to th

[GitHub] spark issue #17162: [SPARK-19550][SparkR][DOCS] Update R document to use JDK...

2017-03-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17162 **[Test build #73901 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73901/testReport)** for PR 17162 at commit [`212c829`](https://github.com/apache/spark/commit/2

[GitHub] spark issue #17162: [SPARK-19550][SparkR][DOCS] Update R document to use JDK...

2017-03-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17162 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73901/ Test PASSed. ---

[GitHub] spark issue #17162: [SPARK-19550][SparkR][DOCS] Update R document to use JDK...

2017-03-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17162 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark pull request #17068: [SPARK-19709][SQL] Read empty file with CSV data ...

2017-03-04 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/17068#discussion_r104288502 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVDataSource.scala --- @@ -133,8 +133,19 @@ object TextInputCSVDataSo

[GitHub] spark pull request #17068: [SPARK-19709][SQL] Read empty file with CSV data ...

2017-03-04 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/17068#discussion_r104288543 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/csv/CSVSuite.scala --- @@ -305,13 +305,21 @@ class CSVSuite extends QueryT

[GitHub] spark issue #17068: [SPARK-19709][SQL] Read empty file with CSV data source

2017-03-04 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/17068 Hi @wojtek-szymanski, these are all from me. Let me cc @cloud-fan as my PRs related with this were reviewed by him and I guess I can't trigger the test. --- If your project is set up for it, yo

[GitHub] spark issue #17120: [SPARK-19715][Structured Streaming] Option to Strip Path...

2017-03-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17120 **[Test build #73900 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73900/testReport)** for PR 17120 at commit [`f9e525e`](https://github.com/apache/spark/commit/f

[GitHub] spark issue #17120: [SPARK-19715][Structured Streaming] Option to Strip Path...

2017-03-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17120 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #17120: [SPARK-19715][Structured Streaming] Option to Strip Path...

2017-03-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17120 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73900/ Test PASSed. ---

[GitHub] spark issue #16854: [WIP][SPARK-15463][SQL] Add an API to load DataFrame fro...

2017-03-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16854 **[Test build #73902 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73902/testReport)** for PR 16854 at commit [`859113a`](https://github.com/apache/spark/commit/85

[GitHub] spark issue #16854: [WIP][SPARK-15463][SQL] Add an API to load DataFrame fro...

2017-03-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16854 **[Test build #73903 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73903/testReport)** for PR 16854 at commit [`b806698`](https://github.com/apache/spark/commit/b8

[GitHub] spark pull request #16854: [WIP][SPARK-15463][SQL] Add an API to load DataFr...

2017-03-04 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/16854#discussion_r104289988 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala --- @@ -399,6 +395,52 @@ class DataFrameReader private[sql](sparkSession:

[GitHub] spark pull request #16854: [WIP][SPARK-15463][SQL] Add an API to load DataFr...

2017-03-04 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/16854#discussion_r104290005 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala --- @@ -399,6 +395,52 @@ class DataFrameReader private[sql](sparkSession:

[GitHub] spark pull request #16854: [WIP][SPARK-15463][SQL] Add an API to load DataFr...

2017-03-04 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/16854#discussion_r104289951 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala --- @@ -604,6 +646,22 @@ class DataFrameReader private[sql](sparkSession:

[GitHub] spark issue #16854: [WIP][SPARK-15463][SQL] Add an API to load DataFrame fro...

2017-03-04 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/16854 Let me double check before getting rid of `[WIP]` tomorrow. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does n

[GitHub] spark pull request #16854: [WIP][SPARK-15463][SQL] Add an API to load DataFr...

2017-03-04 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/16854#discussion_r104290082 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala --- @@ -604,6 +646,22 @@ class DataFrameReader private[sql](sparkSession:

[GitHub] spark issue #16854: [WIP][SPARK-15463][SQL] Add an API to load DataFrame fro...

2017-03-04 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/16854 Let me double check before getting rid of `[WIP]` tomorrow. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does n

[GitHub] spark pull request #17148: [SPARK-17075][SQL][followup] fix filter estimatio...

2017-03-04 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/17148#discussion_r104290248 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/statsEstimation/FilterEstimation.scala --- @@ -101,21 +101,23 @@ case class

[GitHub] spark issue #17122: [SPARK-19786][SQL] Facilitate loop optimizations in a JI...

2017-03-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17122 **[Test build #73904 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73904/testReport)** for PR 17122 at commit [`c2f7939`](https://github.com/apache/spark/commit/c2

[GitHub] spark issue #16611: [SPARK-17967][SPARK-17878][SQL][PYTHON] Support for arra...

2017-03-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16611 **[Test build #73905 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73905/testReport)** for PR 16611 at commit [`9f7e679`](https://github.com/apache/spark/commit/9f

[GitHub] spark issue #16981: [SPARK-19637][SQL] Add to_json in FunctionRegistry

2017-03-04 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/16981 LGTM cc @marmbrus @brkyvz Is this impl what you expect? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project d

[GitHub] spark issue #16954: [SPARK-18874][SQL] First phase: Deferring the correlated...

2017-03-04 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/16954 See the comment https://github.com/apache/spark/pull/16954#discussion_r104287344 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. I

[GitHub] spark pull request #17163: [SPARK-16617][BUILD][CORE] Upgrade to Avro 1.8.x

2017-03-04 Thread srowen
GitHub user srowen opened a pull request: https://github.com/apache/spark/pull/17163 [SPARK-16617][BUILD][CORE] Upgrade to Avro 1.8.x ## What changes were proposed in this pull request? Update to Avro 1.8.x to match Parquet 1.8 dependency. ## How was this patch test

[GitHub] spark issue #17163: [SPARK-16617][BUILD][CORE] Upgrade to Avro 1.8.x

2017-03-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17163 **[Test build #73906 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73906/testReport)** for PR 17163 at commit [`9461741`](https://github.com/apache/spark/commit/94

[GitHub] spark issue #17162: [SPARK-19550][SparkR][DOCS] Update R document to use JDK...

2017-03-04 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/17162 Merged to master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or i

[GitHub] spark pull request #17162: [SPARK-19550][SparkR][DOCS] Update R document to ...

2017-03-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/17162 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request #17164: [SPARK-16844][SQL] Support codegen for sort-based...

2017-03-04 Thread maropu
GitHub user maropu opened a pull request: https://github.com/apache/spark/pull/17164 [SPARK-16844][SQL] Support codegen for sort-based aggreagate ## What changes were proposed in this pull request? This is the rework of #14481. ## How was this patch tested? Checked t

[GitHub] spark issue #17164: [SPARK-16844][SQL] Support codegen for sort-based aggrea...

2017-03-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17164 **[Test build #73907 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73907/testReport)** for PR 17164 at commit [`f2ccc65`](https://github.com/apache/spark/commit/f2

[GitHub] spark issue #17164: [SPARK-16844][SQL] Support codegen for sort-based aggrea...

2017-03-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17164 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #17164: [SPARK-16844][SQL] Support codegen for sort-based aggrea...

2017-03-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17164 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73907/ Test FAILed. ---

[GitHub] spark issue #17164: [SPARK-16844][SQL] Support codegen for sort-based aggrea...

2017-03-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17164 **[Test build #73907 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73907/testReport)** for PR 17164 at commit [`f2ccc65`](https://github.com/apache/spark/commit/f

[GitHub] spark issue #17164: [SPARK-16844][SQL] Support codegen for sort-based aggrea...

2017-03-04 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/17164 A benchmark result: https://github.com/apache/spark/pull/17164/files#diff-b7bf86a20a79d572f81093300568db6eR44 ``` /* range/limit/sum: Best/Avg Time(ms)Rate(M/s

[GitHub] spark issue #17164: [SPARK-16844][SQL][WIP] Support codegen for sort-based a...

2017-03-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17164 **[Test build #73908 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73908/testReport)** for PR 17164 at commit [`9a26a0a`](https://github.com/apache/spark/commit/9a

[GitHub] spark issue #17164: [SPARK-16844][SQL][WIP] Support codegen for sort-based a...

2017-03-04 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/17164 ``` import org.apache.spark.sql.execution.debug._ spark.conf.set("spark.sql.aggregate.preferSortAggregate", "true") val df = spark.range(10).selectExpr("id % 2 AS key", "rand() AS value")

[GitHub] spark issue #17164: [SPARK-16844][SQL][WIP] Support codegen for sort-based a...

2017-03-04 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/17164 ``` import org.apache.spark.sql.execution.debug._ spark.conf.set("spark.sql.aggregate.preferSortAggregate", "true") val df = spark.range(10).selectExpr("id % 2 AS key", "rand() AS value")

[GitHub] spark issue #17164: [SPARK-16844][SQL][WIP] Support codegen for sort-based a...

2017-03-04 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/17164 @hvanhovell I reworked #14481 though, I'm not sure it is still worth trying this codegen. Could you give me insight first? Thanks! --- If your project is set up for it, you can reply to this email a

[GitHub] spark issue #16854: [WIP][SPARK-15463][SQL] Add an API to load DataFrame fro...

2017-03-04 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16854 **[Test build #73902 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73902/testReport)** for PR 16854 at commit [`859113a`](https://github.com/apache/spark/commit/8

  1   2   3   >