[GitHub] spark pull request #17149: [SPARK-19257][SQL]location for table/partition/da...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17149#discussion_r104358658 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala --- @@ -21,6 +21,7 @@ import scala.collection.JavaConverters._

[GitHub] spark pull request #17149: [SPARK-19257][SQL]location for table/partition/da...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17149#discussion_r104358620 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalogSuite.scala --- @@ -883,7 +885,7 @@ abstract class CatalogTest

[GitHub] spark issue #16867: [SPARK-16929] Improve performance when check speculatabl...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16867 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73968/ Test PASSed. ---

[GitHub] spark issue #16867: [SPARK-16929] Improve performance when check speculatabl...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16867 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark pull request #17149: [SPARK-19257][SQL]location for table/partition/da...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17149#discussion_r104358453 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalogSuite.scala --- @@ -553,7 +555,7 @@ abstract class ExternalCat

[GitHub] spark issue #16867: [SPARK-16929] Improve performance when check speculatabl...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16867 **[Test build #73968 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73968/testReport)** for PR 16867 at commit [`f30ef46`](https://github.com/apache/spark/commit/f

[GitHub] spark pull request #15666: [SPARK-11421] [Core][Python][R] Added ability for...

Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/15666#discussion_r104358500 --- Diff: core/src/main/scala/org/apache/spark/TestUtils.scala --- @@ -168,6 +168,27 @@ private[spark] object TestUtils { createCompiledClass(cl

[GitHub] spark pull request #17149: [SPARK-19257][SQL]location for table/partition/da...

Github user windpiger commented on a diff in the pull request: https://github.com/apache/spark/pull/17149#discussion_r104358279 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalogSuite.scala --- @@ -883,7 +885,7 @@ abstract class CatalogTest

[GitHub] spark pull request #17149: [SPARK-19257][SQL]location for table/partition/da...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17149#discussion_r104358192 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala --- @@ -131,7 +132,7 @@ class SessionCatalog( *

[GitHub] spark pull request #15666: [SPARK-11421] [Core][Python][R] Added ability for...

Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/15666#discussion_r104357841 --- Diff: R/pkg/R/context.R --- @@ -319,6 +319,34 @@ spark.addFile <- function(path, recursive = FALSE) { invisible(callJMethod(sc, "addFile", su

[GitHub] spark pull request #15666: [SPARK-11421] [Core][Python][R] Added ability for...

Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/15666#discussion_r104358056 --- Diff: core/src/main/scala/org/apache/spark/TestUtils.scala --- @@ -168,6 +168,27 @@ private[spark] object TestUtils { createCompiledClass(cl

[GitHub] spark pull request #17149: [SPARK-19257][SQL]location for table/partition/da...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17149#discussion_r104357644 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalogUtils.scala --- @@ -162,6 +164,28 @@ object CatalogUtils {

[GitHub] spark issue #17149: [SPARK-19257][SQL]location for table/partition/database ...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17149 **[Test build #73979 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73979/testReport)** for PR 17149 at commit [`b6bc466`](https://github.com/apache/spark/commit/b6

[GitHub] spark pull request #17068: [SPARK-19709][SQL] Read empty file with CSV data ...

Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/17068#discussion_r104357269 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVDataSource.scala --- @@ -190,28 +194,28 @@ object WholeFileCSVDataS

[GitHub] spark pull request #17149: [SPARK-19257][SQL]location for table/partition/da...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17149#discussion_r104357082 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalogUtils.scala --- @@ -162,6 +164,28 @@ object CatalogUtils {

[GitHub] spark issue #16867: [SPARK-16929] Improve performance when check speculatabl...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16867 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #16867: [SPARK-16929] Improve performance when check speculatabl...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16867 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73967/ Test PASSed. ---

[GitHub] spark issue #16867: [SPARK-16929] Improve performance when check speculatabl...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16867 **[Test build #73967 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73967/testReport)** for PR 16867 at commit [`712e06e`](https://github.com/apache/spark/commit/7

[GitHub] spark pull request #17068: [SPARK-19709][SQL] Read empty file with CSV data ...

Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/17068#discussion_r104356921 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVDataSource.scala --- @@ -190,28 +194,28 @@ object WholeFileCSVDataS

[GitHub] spark pull request #17068: [SPARK-19709][SQL] Read empty file with CSV data ...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17068#discussion_r104356866 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVDataSource.scala --- @@ -190,28 +194,28 @@ object WholeFileCSVDataSou

[GitHub] spark issue #17174: [SPARK-19145][SQL] Timestamp to String casting is slowin...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17174 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

[GitHub] spark pull request #17174: [SPARK-19145][SQL] Timestamp to String casting is...

GitHub user tanejagagan opened a pull request: https://github.com/apache/spark/pull/17174 [SPARK-19145][SQL] Timestamp to String casting is slowing the query s… …ignificantly If BinaryComparison has expression with timestamp and string datatype then cast string to times

[GitHub] spark pull request #17136: [SPARK-19783][SQL] Treat longer lengths of tokens...

Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/17136#discussion_r104356333 --- Diff: R/pkg/inst/tests/testthat/test_sparkSQL.R --- @@ -246,8 +246,8 @@ test_that("read/write csv as DataFrame", { mockLinesCsv <- c("year,make,mod

[GitHub] spark pull request #17171: [SPARK-19830] [SQL] Add parseTableSchema API to P...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17171#discussion_r104356142 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/TableSchemaParserSuite.scala --- @@ -0,0 +1,85 @@ +/* +* Licensed to t

[GitHub] spark issue #17149: [SPARK-19257][SQL]location for table/partition/database ...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17149 **[Test build #73977 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73977/testReport)** for PR 17149 at commit [`dc0a37b`](https://github.com/apache/spark/commit/dc

[GitHub] spark issue #17125: [SPARK-19211][SQL] Explicitly prevent Insert into View o...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17125 **[Test build #73978 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73978/testReport)** for PR 17125 at commit [`8d4be05`](https://github.com/apache/spark/commit/8d

[GitHub] spark issue #15666: [SPARK-11421] [Core][Python][R] Added ability for addJar...

Github user holdenk commented on the issue: https://github.com/apache/spark/pull/15666 So the R appveyor tests failed, since these are only triggered in R changes maybe @felixcheung has some ideas? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request #16933: [SPARK-19601] [SQL] Fix CollapseRepartition rule ...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/16933#discussion_r104355455 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -562,27 +562,43 @@ object CollapseProject extends Ru

[GitHub] spark issue #17149: [SPARK-19257][SQL]location for table/partition/database ...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17149 **[Test build #73976 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73976/testReport)** for PR 17149 at commit [`109e2b5`](https://github.com/apache/spark/commit/10

[GitHub] spark pull request #16933: [SPARK-19601] [SQL] Fix CollapseRepartition rule ...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/16933#discussion_r104355337 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -562,27 +562,43 @@ object CollapseProject extends Ru

[GitHub] spark pull request #17075: [SPARK-19727][SQL] Fix for round function that mo...

Github user wojtek-szymanski commented on a diff in the pull request: https://github.com/apache/spark/pull/17075#discussion_r104354415 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/types/Decimal.scala --- @@ -223,6 +224,19 @@ final class Decimal extends Ordered[Decimal

[GitHub] spark issue #16592: [SPARK-19235] [SQL] [TESTS] Enable Test Cases in DDLSuit...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16592 **[Test build #73975 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73975/testReport)** for PR 16592 at commit [`b186dcd`](https://github.com/apache/spark/commit/b1

[GitHub] spark issue #17164: [SPARK-16844][SQL][WIP] Support codegen for sort-based a...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17164 **[Test build #73974 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73974/testReport)** for PR 17164 at commit [`d5cc0f0`](https://github.com/apache/spark/commit/d5

[GitHub] spark issue #16290: [SPARK-18817] [SPARKR] [SQL] Set default warehouse dir t...

Github user shivaram commented on the issue: https://github.com/apache/spark/pull/16290 @gatorsmile @cloud-fan @felixcheung I looked at the SharedState code more closely and it looks like the only time the warehousePath can be set is when the initialization of shared state happens. So

[GitHub] spark pull request #17068: [SPARK-19709][SQL] Read empty file with CSV data ...

Github user wojtek-szymanski commented on a diff in the pull request: https://github.com/apache/spark/pull/17068#discussion_r104353760 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVDataSource.scala --- @@ -190,28 +194,28 @@ object WholeFileCSV

[GitHub] spark pull request #17075: [SPARK-19727][SQL] Fix for round function that mo...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17075#discussion_r104353273 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/types/Decimal.scala --- @@ -223,6 +224,19 @@ final class Decimal extends Ordered[Decimal] with

[GitHub] spark issue #17173: [SPARK-19832][SQL]DynamicPartitionWriteTask get partitio...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17173 **[Test build #73972 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73972/testReport)** for PR 17173 at commit [`9800a7d`](https://github.com/apache/spark/commit/98

[GitHub] spark issue #16290: [SPARK-18817] [SPARKR] [SQL] Set default warehouse dir t...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16290 **[Test build #73973 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73973/testReport)** for PR 16290 at commit [`b14c302`](https://github.com/apache/spark/commit/b1

[GitHub] spark issue #16867: [SPARK-16929] Improve performance when check speculatabl...

Github user mridulm commented on the issue: https://github.com/apache/spark/pull/16867 The cost for median heap could be higher than TreeMap imo - for example, the additional dequeue + enqueue when rebalance is required ? If the cost is high enough, we might want to relook at the P

[GitHub] spark pull request #17173: [SPARK-19832][SQL]DynamicPartitionWriteTask get p...

GitHub user windpiger opened a pull request: https://github.com/apache/spark/pull/17173 [SPARK-19832][SQL]DynamicPartitionWriteTask get partitionPath should escape the partition name ## What changes were proposed in this pull request? Currently in DynamicPartitionWriteTask,

[GitHub] spark pull request #16867: [SPARK-16929] Improve performance when check spec...

Github user mridulm commented on a diff in the pull request: https://github.com/apache/spark/pull/16867#discussion_r104352100 --- Diff: core/src/main/scala/org/apache/spark/util/collection/MedianHeap.scala --- @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache Software Foundat

[GitHub] spark pull request #16867: [SPARK-16929] Improve performance when check spec...

Github user mridulm commented on a diff in the pull request: https://github.com/apache/spark/pull/16867#discussion_r104352237 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala --- @@ -754,7 +743,6 @@ private[spark] class TaskSetManager( }

[GitHub] spark pull request #16867: [SPARK-16929] Improve performance when check spec...

Github user mridulm commented on a diff in the pull request: https://github.com/apache/spark/pull/16867#discussion_r104351990 --- Diff: core/src/test/scala/org/apache/spark/util/collection/MedianHeapSuite.scala --- @@ -0,0 +1,78 @@ +/* + * Licensed to the Apache Software Fo

[GitHub] spark pull request #17075: [SPARK-19727][SQL] Fix for round function that mo...

Github user wojtek-szymanski commented on a diff in the pull request: https://github.com/apache/spark/pull/17075#discussion_r104351913 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/MathFunctionsSuite.scala --- @@ -422,3 +434,4 @@ class MathFunctionsSuite extends QueryTest

[GitHub] spark pull request #17075: [SPARK-19727][SQL] Fix for round function that mo...

Github user wojtek-szymanski commented on a diff in the pull request: https://github.com/apache/spark/pull/17075#discussion_r104351867 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/types/Decimal.scala --- @@ -223,6 +224,19 @@ final class Decimal extends Ordered[Decimal

[GitHub] spark issue #17087: [SPARK-19372][SQL] Fix throwing a Java exception at df.f...

Github user kiszk commented on the issue: https://github.com/apache/spark/pull/17087 @davies, could you please review this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enable

[GitHub] spark issue #17172: [SPARK-19008][SQL] Improve performance of Dataset.map by...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17172 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73971/ Test FAILed. ---

[GitHub] spark issue #17172: [SPARK-19008][SQL] Improve performance of Dataset.map by...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17172 **[Test build #73971 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73971/testReport)** for PR 17172 at commit [`d8b5f8d`](https://github.com/apache/spark/commit/d

[GitHub] spark issue #17172: [SPARK-19008][SQL] Improve performance of Dataset.map by...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17172 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #17172: [SPARK-19008][SQL] Improve performance of Dataset.map by...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17172 **[Test build #73971 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73971/testReport)** for PR 17172 at commit [`d8b5f8d`](https://github.com/apache/spark/commit/d8

[GitHub] spark pull request #17172: [SPARK-19008][SQL] Improve performance of Dataset...

GitHub user kiszk opened a pull request: https://github.com/apache/spark/pull/17172 [SPARK-19008][SQL] Improve performance of Dataset.map by eliminating boxing/unboxing ## What changes were proposed in this pull request? This PR improve performance of Dataset.map() for prim

[GitHub] spark pull request #16726: [SPARK-19390][SQL] Replace the unnecessary usages...

Github user gatorsmile closed the pull request at: https://github.com/apache/spark/pull/16726 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #16933: [SPARK-19601] [SQL] Fix CollapseRepartition rule to pres...

Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/16933 cc @cloud-fan @hvanhovell --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and w

[GitHub] spark issue #17171: [SPARK-19830] [SQL] Add parseTableSchema API to ParserIn...

Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/17171 cc @hvanhovell @cloud-fan --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and w

[GitHub] spark pull request #17055: [SPARK-19723][SQL]create datasource table with an...

Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17055#discussion_r104351251 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala --- @@ -1588,8 +1588,102 @@ class HiveDDLSuite }

[GitHub] spark pull request #17055: [SPARK-19723][SQL]create datasource table with an...

Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17055#discussion_r104351051 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala --- @@ -1950,8 +1950,53 @@ class DDLSuite extends QueryTest with

[GitHub] spark pull request #17055: [SPARK-19723][SQL]create datasource table with an...

Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17055#discussion_r104351006 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala --- @@ -1950,8 +1950,53 @@ class DDLSuite extends QueryTest with

[GitHub] spark pull request #17055: [SPARK-19723][SQL]create datasource table with an...

Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17055#discussion_r104350967 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala --- @@ -1950,8 +1950,53 @@ class DDLSuite extends QueryTest with

[GitHub] spark issue #17171: [SPARK-19830] [SQL] Add parseTableSchema API to ParserIn...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17171 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73965/ Test PASSed. ---

[GitHub] spark issue #17171: [SPARK-19830] [SQL] Add parseTableSchema API to ParserIn...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17171 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #17171: [SPARK-19830] [SQL] Add parseTableSchema API to ParserIn...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17171 **[Test build #73965 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73965/testReport)** for PR 17171 at commit [`50f74d2`](https://github.com/apache/spark/commit/5

[GitHub] spark pull request #17068: [SPARK-19709][SQL] Read empty file with CSV data ...

Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/17068#discussion_r104350586 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVDataSource.scala --- @@ -190,28 +194,28 @@ object WholeFileCSVDataS

[GitHub] spark issue #17068: [SPARK-19709][SQL] Read empty file with CSV data source

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17068 **[Test build #73970 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73970/testReport)** for PR 17068 at commit [`e7faa80`](https://github.com/apache/spark/commit/e7

[GitHub] spark issue #16782: [SPARK-19348][PYTHON] PySpark keyword_only decorator is ...

Github user BryanCutler commented on the issue: https://github.com/apache/spark/pull/16782 Sure, I can do a backport @jkbradley, will ping you when ready On Mar 3, 2017 4:46 PM, "asfgit" wrote: > Closed #16782 via 44281ca

[GitHub] spark pull request #17097: [SPARK-19765][SQL] UNCACHE TABLE should un-cache ...

Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17097#discussion_r104347576 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/InsertIntoDataSourceCommand.scala --- @@ -42,8 +42,9 @@ case class InsertIn

[GitHub] spark issue #16729: [SPARK-19391][SparkR][ML] Tweedie GLM API for SparkR

Github user actuaryzhang commented on the issue: https://github.com/apache/spark/pull/16729 @felixcheung Sorry for taking so long for this update. I think your first suggestion makes most sense, i.e., we do not expose the internal `tweedie`. When `statmod` is loaded, user

[GitHub] spark issue #17110: [SPARK-19635][ML] DataFrame-based API for chi square tes...

Github user imatiach-msft commented on the issue: https://github.com/apache/spark/pull/17110 cool, I'll hold off on reviewing this for now then --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark issue #17170: [SPARK-19825][WIP][R][ML] spark.ml R API for FPGrowth

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17170 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73966/ Test FAILed. ---

[GitHub] spark issue #17170: [SPARK-19825][WIP][R][ML] spark.ml R API for FPGrowth

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17170 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #17170: [SPARK-19825][WIP][R][ML] spark.ml R API for FPGrowth

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17170 **[Test build #73966 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73966/testReport)** for PR 17170 at commit [`6554384`](https://github.com/apache/spark/commit/6

[GitHub] spark issue #16867: [SPARK-16929] Improve performance when check speculatabl...

Github user jinxing64 commented on the issue: https://github.com/apache/spark/pull/16867 @mridulm Thanks a lot for your comments. I did a test with `TreeSet` previously with 100k tasks. I calculate the time spent on insertion. The results are: 372ms, 362ms, 458ms, 429ms, 363ms,

[GitHub] spark pull request #17138: [SPARK-17080] [SQL] join reorder

Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/17138#discussion_r104346324 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/CostBasedJoinReorder.scala --- @@ -0,0 +1,274 @@ +/* + * Licensed to th

[GitHub] spark issue #16826: [SPARK-19540][SQL] Add ability to clone SparkSession whe...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16826 **[Test build #73969 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73969/testReport)** for PR 16826 at commit [`3ee271f`](https://github.com/apache/spark/commit/3

[GitHub] spark issue #16826: [SPARK-19540][SQL] Add ability to clone SparkSession whe...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16826 Build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark issue #16826: [SPARK-19540][SQL] Add ability to clone SparkSession whe...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16826 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73969/ Test FAILed. ---

[GitHub] spark issue #16826: [SPARK-19540][SQL] Add ability to clone SparkSession whe...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16826 **[Test build #73969 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73969/testReport)** for PR 16826 at commit [`3ee271f`](https://github.com/apache/spark/commit/3e

[GitHub] spark issue #16867: [SPARK-16929] Improve performance when check speculatabl...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16867 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73955/ Test PASSed. ---

[GitHub] spark pull request #17138: [SPARK-17080] [SQL] join reorder

Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/17138#discussion_r104346049 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/CostBasedJoinReorder.scala --- @@ -0,0 +1,274 @@ +/* + * Licensed to th

[GitHub] spark issue #16867: [SPARK-16929] Improve performance when check speculatabl...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16867 **[Test build #73955 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73955/testReport)** for PR 16867 at commit [`1fac678`](https://github.com/apache/spark/commit/1

[GitHub] spark issue #16867: [SPARK-16929] Improve performance when check speculatabl...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16867 **[Test build #73968 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73968/testReport)** for PR 16867 at commit [`f30ef46`](https://github.com/apache/spark/commit/f3

[GitHub] spark issue #16729: [SPARK-19391][SparkR][ML] Tweedie GLM API for SparkR

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16729 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #16729: [SPARK-19391][SparkR][ML] Tweedie GLM API for SparkR

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16729 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73964/ Test PASSed. ---

[GitHub] spark issue #16729: [SPARK-19391][SparkR][ML] Tweedie GLM API for SparkR

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16729 **[Test build #73964 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73964/testReport)** for PR 16729 at commit [`ef65adc`](https://github.com/apache/spark/commit/e

[GitHub] spark pull request #17125: [SPARK-19211][SQL] Explicitly prevent Insert into...

Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17125#discussion_r104345660 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -604,7 +604,13 @@ class Analyzer( def

[GitHub] spark pull request #17125: [SPARK-19211][SQL] Explicitly prevent Insert into...

Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/17125#discussion_r104345227 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -604,7 +604,13 @@ class Analyzer( def

[GitHub] spark issue #17152: [SPARK-18389][SQL] Disallow cyclic view reference

Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/17152 Yeah. The temporary view does not have such an issue, because we did not change it. My typo. What I mean is `CREATE OR REPLACE VIEW`. `AlterViewAsCommand` does not cover that code path.

[GitHub] spark issue #16867: [SPARK-16929] Improve performance when check speculatabl...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16867 **[Test build #73967 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73967/testReport)** for PR 16867 at commit [`712e06e`](https://github.com/apache/spark/commit/71

[GitHub] spark issue #16696: [SPARK-19350] [SQL] Cardinality estimation of Limit and ...

Github user wzhfy commented on the issue: https://github.com/apache/spark/pull/16696 @cloud-fan Does this look good to you now? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature en

[GitHub] spark issue #17125: [SPARK-19211][SQL] Explicitly prevent Insert into View o...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17125 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #17125: [SPARK-19211][SQL] Explicitly prevent Insert into View o...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17125 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73958/ Test PASSed. ---

[GitHub] spark issue #17125: [SPARK-19211][SQL] Explicitly prevent Insert into View o...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17125 **[Test build #73958 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73958/testReport)** for PR 17125 at commit [`9af2d7e`](https://github.com/apache/spark/commit/9

[GitHub] spark pull request #16867: [SPARK-16929] Improve performance when check spec...

Github user jinxing64 commented on a diff in the pull request: https://github.com/apache/spark/pull/16867#discussion_r104344524 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala --- @@ -754,7 +743,6 @@ private[spark] class TaskSetManager( }

[GitHub] spark pull request #16867: [SPARK-16929] Improve performance when check spec...

Github user jinxing64 commented on a diff in the pull request: https://github.com/apache/spark/pull/16867#discussion_r104344529 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala --- @@ -754,7 +743,6 @@ private[spark] class TaskSetManager( }

[GitHub] spark pull request #16867: [SPARK-16929] Improve performance when check spec...

Github user jinxing64 commented on a diff in the pull request: https://github.com/apache/spark/pull/16867#discussion_r104344274 --- Diff: core/src/main/scala/org/apache/spark/util/collection/MedianHeap.scala --- @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache Software Found

[GitHub] spark pull request #16867: [SPARK-16929] Improve performance when check spec...

Github user jinxing64 commented on a diff in the pull request: https://github.com/apache/spark/pull/16867#discussion_r104344072 --- Diff: core/src/test/scala/org/apache/spark/util/collection/MedianHeapSuite.scala --- @@ -0,0 +1,78 @@ +/* + * Licensed to the Apache Software

[GitHub] spark issue #17170: [SPARK-19825][WIP][R][ML] spark.ml R API for FPGrowth

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17170 **[Test build #73966 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73966/testReport)** for PR 17170 at commit [`6554384`](https://github.com/apache/spark/commit/65

[GitHub] spark issue #16997: Updated the Spark SQL Programming guide with Custom obje...

Github user HarshSharma8 commented on the issue: https://github.com/apache/spark/pull/16997 Sure, and thanks for kind attention to this pull request. Thank You Best Regards | *Harsh Sharma* Sr. Software Consultant Knoldus Software LLP FB

[GitHub] spark issue #17171: [SPARK-19830] [SQL] Add parseTableSchema API to ParserIn...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17171 **[Test build #73965 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73965/testReport)** for PR 17171 at commit [`50f74d2`](https://github.com/apache/spark/commit/50

[GitHub] spark pull request #17171: [SPARK-19830] [SQL] Add parseTableSchema API to P...

GitHub user gatorsmile opened a pull request: https://github.com/apache/spark/pull/17171 [SPARK-19830] [SQL] Add parseTableSchema API to ParserInterface ### What changes were proposed in this pull request? Specifying the table schema in DDL formats is needed for different s

[GitHub] spark issue #16729: [SPARK-19391][SparkR][ML] Tweedie GLM API for SparkR

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16729 **[Test build #73964 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73964/testReport)** for PR 16729 at commit [`ef65adc`](https://github.com/apache/spark/commit/ef

  1   2   3   4   >