[GitHub] spark pull request #17308: [SPARK-19968][SPARK-20737][SS] Use a cached insta...

2017-05-23 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/17308#discussion_r118175283 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/CachedKafkaProducer.scala --- @@ -0,0 +1,174 @@ +/* + * Licensed to t

[GitHub] spark pull request #17891: [SPARK-20631][PYTHON][ML] LogisticRegression._che...

2017-05-23 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/17891#discussion_r118175057 --- Diff: python/pyspark/ml/tests.py --- @@ -807,6 +807,18 @@ def test_logistic_regression(self): except OSError: pass

[GitHub] spark issue #12646: [SPARK-14878][SQL] Trim characters string function suppo...

2017-05-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/12646 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77288/ Test PASSed. ---

[GitHub] spark issue #12646: [SPARK-14878][SQL] Trim characters string function suppo...

2017-05-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/12646 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #12646: [SPARK-14878][SQL] Trim characters string function suppo...

2017-05-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/12646 **[Test build #77288 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77288/testReport)** for PR 12646 at commit [`1a5747b`](https://github.com/apache/spark/commit/1

[GitHub] spark issue #18081: [SPARK-20862][MLLIB][PYTHON] Avoid passing float to ndar...

2017-05-23 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/18081 @MrBago Yeah, after a quick scan, seems other `reshape` usage in MLlib are ok. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark issue #18081: [SPARK-20862][MLLIB][PYTHON] Avoid passing float to ndar...

2017-05-23 Thread MrBago
Github user MrBago commented on the issue: https://github.com/apache/spark/pull/18081 @viirya I was running python tests for pyspark-ml and pyspark-mllib and this was the only place where the python3/numpy interaction caused a test failure. There might be other places where floor int

[GitHub] spark issue #17150: [SPARK-19810][BUILD][CORE] Remove support for Scala 2.10

2017-05-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17150 **[Test build #3752 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3752/testReport)** for PR 17150 at commit [`7a30de4`](https://github.com/apache/spark/commit/7

[GitHub] spark issue #18081: [SPARK-20862][MLLIB][PYTHON] Avoid passing float to ndar...

2017-05-23 Thread MrBago
Github user MrBago commented on the issue: https://github.com/apache/spark/pull/18081 @srowen floor divide has been in python since 2.2, https://www.python.org/download/releases/2.2/. --- If your project is set up for it, you can reply to this email and have your reply appear on GitH

[GitHub] spark issue #18081: [SPARK-20862][MLLIB][PYTHON] BugFix - avoid passing floa...

2017-05-23 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/18081 Nit: usually we won't specially tag it is a BugFix in the title. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does n

[GitHub] spark issue #18081: [SPARK-20862][MLLIB][PYTHON] BugFix - avoid passing floa...

2017-05-23 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/18081 I think so. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark issue #18081: [SPARK-20862][MLLIB][PYTHON] BugFix - avoid passing floa...

2017-05-23 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/18081 To test it in jenkins might need a specified numpy version, but the code change looks ok. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as we

[GitHub] spark issue #18081: [SPARK-20862][MLLIB][PYTHON] BugFix - avoid passing floa...

2017-05-23 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/18081 Dumb question but this still works in Python 2.6+ right? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark issue #18081: [SPARK-20862][MLLIB][PYTHON] BugFix - avoid passing floa...

2017-05-23 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/18081 LGTM Do we have similar cases in MLlib? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fea

[GitHub] spark issue #17770: [SPARK-20392][SQL] Set barrier to prevent re-entering a ...

2017-05-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17770 **[Test build #77294 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77294/testReport)** for PR 17770 at commit [`cba784b`](https://github.com/apache/spark/commit/cb

[GitHub] spark issue #17308: [SPARK-19968][SPARK-20737][SS] Use a cached instance of ...

2017-05-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17308 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77293/ Test PASSed. ---

[GitHub] spark issue #17308: [SPARK-19968][SPARK-20737][SS] Use a cached instance of ...

2017-05-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17308 **[Test build #77293 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77293/testReport)** for PR 17308 at commit [`039d063`](https://github.com/apache/spark/commit/0

[GitHub] spark issue #17308: [SPARK-19968][SPARK-20737][SS] Use a cached instance of ...

2017-05-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17308 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #18080: [Spark-20771][SQL] Make weekofyear more intuitive

2017-05-23 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/18080 I don't think you can just change the behavior. It would possibly break apps and I presume no longer matches Hive. If it already implements a standard too, it sounds like it is correct. A second met

[GitHub] spark issue #16989: [SPARK-19659] Fetch big blocks to disk when shuffle-read...

2017-05-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16989 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77285/ Test PASSed. ---

[GitHub] spark issue #16989: [SPARK-19659] Fetch big blocks to disk when shuffle-read...

2017-05-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16989 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #16989: [SPARK-19659] Fetch big blocks to disk when shuffle-read...

2017-05-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16989 **[Test build #77285 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77285/testReport)** for PR 16989 at commit [`222680c`](https://github.com/apache/spark/commit/2

[GitHub] spark pull request #18075: [SPARK-18016][SQL][CATALYST] Code Generation: Con...

2017-05-23 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/18075#discussion_r118168255 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala --- @@ -233,10 +223,129 @@ class CodegenContext {

[GitHub] spark pull request #18075: [SPARK-18016][SQL][CATALYST] Code Generation: Con...

2017-05-23 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/18075#discussion_r118168228 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala --- @@ -233,10 +223,129 @@ class CodegenContext {

[GitHub] spark issue #17308: [SPARK-19968][SPARK-20737][SS] Use a cached instance of ...

2017-05-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17308 **[Test build #77293 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77293/testReport)** for PR 17308 at commit [`039d063`](https://github.com/apache/spark/commit/03

[GitHub] spark issue #17455: [Spark-20044][Web UI] Support Spark UI behind front-end ...

2017-05-23 Thread ajbozarth
Github user ajbozarth commented on the issue: https://github.com/apache/spark/pull/17455 Usually new features aren't added to branches after they've been cut, and almost never after an rc has been cut. So given branch-2.2 was cut over a month ago and we're about to cut rc3, I'm pretty

[GitHub] spark issue #17770: [SPARK-20392][SQL] Set barrier to prevent re-entering a ...

2017-05-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17770 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77292/ Test FAILed. ---

[GitHub] spark issue #17770: [SPARK-20392][SQL] Set barrier to prevent re-entering a ...

2017-05-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17770 **[Test build #77292 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77292/testReport)** for PR 17770 at commit [`eb0598e`](https://github.com/apache/spark/commit/e

[GitHub] spark issue #17770: [SPARK-20392][SQL] Set barrier to prevent re-entering a ...

2017-05-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17770 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #17770: [SPARK-20392][SQL] Set barrier to prevent re-entering a ...

2017-05-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17770 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #17770: [SPARK-20392][SQL] Set barrier to prevent re-entering a ...

2017-05-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17770 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77291/ Test FAILed. ---

[GitHub] spark issue #17770: [SPARK-20392][SQL] Set barrier to prevent re-entering a ...

2017-05-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17770 **[Test build #77291 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77291/testReport)** for PR 17770 at commit [`1c1cc9d`](https://github.com/apache/spark/commit/1

[GitHub] spark issue #17770: [SPARK-20392][SQL] Set barrier to prevent re-entering a ...

2017-05-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17770 **[Test build #77292 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77292/testReport)** for PR 17770 at commit [`eb0598e`](https://github.com/apache/spark/commit/eb

[GitHub] spark issue #17770: [SPARK-20392][SQL] Set barrier to prevent re-entering a ...

2017-05-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17770 Build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark issue #17770: [SPARK-20392][SQL] Set barrier to prevent re-entering a ...

2017-05-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17770 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77290/ Test FAILed. ---

[GitHub] spark issue #17770: [SPARK-20392][SQL] Set barrier to prevent re-entering a ...

2017-05-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17770 **[Test build #77290 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77290/testReport)** for PR 17770 at commit [`2bf0590`](https://github.com/apache/spark/commit/2

[GitHub] spark issue #18075: [SPARK-18016][SQL][CATALYST] Code Generation: Constant P...

2017-05-23 Thread kiszk
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/18075 Thank you. Absolutely, it is easier to review this change. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark issue #17770: [SPARK-20392][SQL] Set barrier to prevent re-entering a ...

2017-05-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17770 **[Test build #77291 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77291/testReport)** for PR 17770 at commit [`1c1cc9d`](https://github.com/apache/spark/commit/1c

[GitHub] spark pull request #18075: [SPARK-18016][SQL][CATALYST] Code Generation: Con...

2017-05-23 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/18075#discussion_r118165399 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala --- @@ -792,7 +887,18 @@ class CodegenContext {

[GitHub] spark pull request #17770: [SPARK-20392][SQL] Set barrier to prevent re-ente...

2017-05-23 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/17770#discussion_r118165051 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -174,17 +174,19 @@ class Dataset[T] private[sql]( this(sqlContext.sparkSe

[GitHub] spark issue #17770: [SPARK-20392][SQL] Set barrier to prevent re-entering a ...

2017-05-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17770 **[Test build #77290 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77290/testReport)** for PR 17770 at commit [`2bf0590`](https://github.com/apache/spark/commit/2b

[GitHub] spark issue #17455: [Spark-20044][Web UI] Support Spark UI behind front-end ...

2017-05-23 Thread agsimeonov
Github user agsimeonov commented on the issue: https://github.com/apache/spark/pull/17455 Any chance this can get into v2.2.0? I am using Spark in Docker with nginx reverse proxy and this would help immensely. --- If your project is set up for it, you can reply to this email and hav

[GitHub] spark issue #18076: [SPARK-18406][CORE] Race between end-of-task and complet...

2017-05-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18076 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #18076: [SPARK-18406][CORE] Race between end-of-task and complet...

2017-05-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18076 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77278/ Test PASSed. ---

[GitHub] spark issue #18076: [SPARK-18406][CORE] Race between end-of-task and complet...

2017-05-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18076 **[Test build #77278 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77278/testReport)** for PR 18076 at commit [`bc66ec5`](https://github.com/apache/spark/commit/b

[GitHub] spark issue #18079: [SPARK-20841][SQL] Support column aliases for catalog ta...

2017-05-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18079 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77280/ Test PASSed. ---

[GitHub] spark issue #18079: [SPARK-20841][SQL] Support column aliases for catalog ta...

2017-05-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18079 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #18079: [SPARK-20841][SQL] Support column aliases for catalog ta...

2017-05-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18079 **[Test build #77280 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77280/testReport)** for PR 18079 at commit [`902d2a3`](https://github.com/apache/spark/commit/9

[GitHub] spark issue #18083: [SPARK-20863] Add metrics/instrumentation to LiveListene...

2017-05-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18083 **[Test build #77289 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77289/testReport)** for PR 18083 at commit [`a46c247`](https://github.com/apache/spark/commit/a4

[GitHub] spark issue #16225: [SPARK-14932][SQL] Allow DataFrame.replace() to replace ...

2017-05-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16225 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77282/ Test PASSed. ---

[GitHub] spark issue #16225: [SPARK-14932][SQL] Allow DataFrame.replace() to replace ...

2017-05-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16225 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #16225: [SPARK-14932][SQL] Allow DataFrame.replace() to replace ...

2017-05-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16225 **[Test build #77282 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77282/testReport)** for PR 16225 at commit [`b5424d9`](https://github.com/apache/spark/commit/b

[GitHub] spark pull request #18075: [SPARK-18016][SQL][CATALYST] Code Generation: Con...

2017-05-23 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/18075#discussion_r118162963 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala --- @@ -629,7 +736,9 @@ class CodegenContext {

[GitHub] spark issue #17770: [SPARK-20392][SQL] Set barrier to prevent re-entering a ...

2017-05-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17770 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77286/ Test FAILed. ---

[GitHub] spark issue #18076: [SPARK-18406][CORE] Race between end-of-task and complet...

2017-05-23 Thread JoshRosen
Github user JoshRosen commented on the issue: https://github.com/apache/spark/pull/18076 LGTM as well. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or i

[GitHub] spark issue #17770: [SPARK-20392][SQL] Set barrier to prevent re-entering a ...

2017-05-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17770 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #17770: [SPARK-20392][SQL] Set barrier to prevent re-entering a ...

2017-05-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17770 **[Test build #77286 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77286/testReport)** for PR 17770 at commit [`c0bee01`](https://github.com/apache/spark/commit/c

[GitHub] spark issue #17770: [SPARK-20392][SQL] Set barrier to prevent re-entering a ...

2017-05-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17770 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77284/ Test FAILed. ---

[GitHub] spark issue #17770: [SPARK-20392][SQL] Set barrier to prevent re-entering a ...

2017-05-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17770 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #17770: [SPARK-20392][SQL] Set barrier to prevent re-entering a ...

2017-05-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17770 **[Test build #77284 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77284/testReport)** for PR 17770 at commit [`f3e4208`](https://github.com/apache/spark/commit/f

[GitHub] spark issue #18073: [SPARK-20848][SQL] Shutdown the pool after reading parqu...

2017-05-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18073 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77279/ Test PASSed. ---

[GitHub] spark issue #18073: [SPARK-20848][SQL] Shutdown the pool after reading parqu...

2017-05-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18073 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #18073: [SPARK-20848][SQL] Shutdown the pool after reading parqu...

2017-05-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18073 **[Test build #77279 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77279/testReport)** for PR 18073 at commit [`14e09aa`](https://github.com/apache/spark/commit/1

[GitHub] spark issue #17770: [SPARK-20392][SQL] Set barrier to prevent re-entering a ...

2017-05-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17770 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #17770: [SPARK-20392][SQL] Set barrier to prevent re-entering a ...

2017-05-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17770 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77283/ Test FAILed. ---

[GitHub] spark issue #17770: [SPARK-20392][SQL] Set barrier to prevent re-entering a ...

2017-05-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17770 **[Test build #77283 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77283/testReport)** for PR 17770 at commit [`5c53f0f`](https://github.com/apache/spark/commit/5

[GitHub] spark issue #18023: [SPARK-12139] [SQL] REGEX Column Specification

2017-05-23 Thread janewangfb
Github user janewangfb commented on the issue: https://github.com/apache/spark/pull/18023 @cloud-fan, there are difference between `xyz` and xyz. we always need to extract xyz part from `xyz`, so we will need to pattern match. if we do not get pattern matched, we know it is not regex,

[GitHub] spark issue #11974: [SPARK-14174][ML] Accelerate KMeans via Mini-Batch EM

2017-05-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/11974 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77287/ Test PASSed. ---

[GitHub] spark issue #11974: [SPARK-14174][ML] Accelerate KMeans via Mini-Batch EM

2017-05-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/11974 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #11974: [SPARK-14174][ML] Accelerate KMeans via Mini-Batch EM

2017-05-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/11974 **[Test build #77287 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77287/testReport)** for PR 11974 at commit [`46d9c7b`](https://github.com/apache/spark/commit/4

[GitHub] spark pull request #18023: [SPARK-12139] [SQL] REGEX Column Specification

2017-05-23 Thread janewangfb
Github user janewangfb commented on a diff in the pull request: https://github.com/apache/spark/pull/18023#discussion_r118160405 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala --- @@ -1230,25 +1230,37 @@ class AstBuilder(conf: SQLConf)

[GitHub] spark issue #17770: [SPARK-20392][SQL] Set barrier to prevent re-entering a ...

2017-05-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17770 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #17770: [SPARK-20392][SQL] Set barrier to prevent re-entering a ...

2017-05-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17770 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77281/ Test FAILed. ---

[GitHub] spark issue #17770: [SPARK-20392][SQL] Set barrier to prevent re-entering a ...

2017-05-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17770 **[Test build #77281 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77281/testReport)** for PR 17770 at commit [`f5f0524`](https://github.com/apache/spark/commit/f

[GitHub] spark pull request #18023: [SPARK-12139] [SQL] REGEX Column Specification

2017-05-23 Thread janewangfb
Github user janewangfb commented on a diff in the pull request: https://github.com/apache/spark/pull/18023#discussion_r118159701 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/ParserUtils.scala --- @@ -177,6 +177,12 @@ object ParserUtils { sb.t

[GitHub] spark issue #18059: [SPARK-20834][SQL]TypeCoercion:loss of precision when wi...

2017-05-23 Thread 10110346
Github user 10110346 commented on the issue: https://github.com/apache/spark/pull/18059 @cloud-fan The current behavior always using `float` , but using `double` can reduce loss of precision,so ,I think using `double` will be better --- If your project is set up for it, you can r

[GitHub] spark issue #17310: [SPARK-18579][SQL] Use ignoreLeadingWhiteSpace and ignor...

2017-05-23 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/17310 This is an API change which we generally don't backport to a patch release. Can you elaborate on why you need it? --- If your project is set up for it, you can reply to this email and hav

[GitHub] spark issue #18059: [SPARK-20834][SQL]TypeCoercion:loss of precision when wi...

2017-05-23 Thread 10110346
Github user 10110346 commented on the issue: https://github.com/apache/spark/pull/18059 I have tested in MYSQL, the result datatype seems to be `decimalType`: mysql> desc test; ++-+--+-+-+---+ | Field | Type| Null | Key | Def

[GitHub] spark pull request #18073: [SPARK-20848][SQL] Shutdown the pool after readin...

2017-05-23 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/18073#discussion_r118158352 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFileFormatSuite.scala --- @@ -26,6 +26,22 @@ import org.apache.s

[GitHub] spark pull request #18077: [SPARK-20861][ML][PYTHON] Delegate looping over p...

2017-05-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/18077 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark issue #18077: [SPARK-20861][ML][PYTHON] Delegate looping over paramMap...

2017-05-23 Thread jkbradley
Github user jkbradley commented on the issue: https://github.com/apache/spark/pull/18077 Merging with master and branch-2.2 which means this will get into 2.2.0 Thanks for the quick fix! --- If your project is set up for it, you can reply to this email and have your reply appear o

[GitHub] spark issue #12646: [SPARK-14878][SQL] Trim characters string function suppo...

2017-05-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/12646 **[Test build #77288 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77288/testReport)** for PR 12646 at commit [`1a5747b`](https://github.com/apache/spark/commit/1a

[GitHub] spark issue #18076: [SPARK-18406][CORE] Race between end-of-task and complet...

2017-05-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18076 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77274/ Test PASSed. ---

[GitHub] spark issue #18076: [SPARK-18406][CORE] Race between end-of-task and complet...

2017-05-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18076 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #18076: [SPARK-18406][CORE] Race between end-of-task and complet...

2017-05-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18076 **[Test build #77274 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77274/testReport)** for PR 18076 at commit [`72cee6e`](https://github.com/apache/spark/commit/7

[GitHub] spark issue #18064: [SPARK-20213][SQL] Fix DataFrameWriter operations in SQL...

2017-05-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18064 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77276/ Test PASSed. ---

[GitHub] spark issue #18064: [SPARK-20213][SQL] Fix DataFrameWriter operations in SQL...

2017-05-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18064 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #18064: [SPARK-20213][SQL] Fix DataFrameWriter operations in SQL...

2017-05-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18064 **[Test build #77276 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77276/testReport)** for PR 18064 at commit [`984bab7`](https://github.com/apache/spark/commit/9

[GitHub] spark issue #18077: [SPARK-20861] Delegate looping over paramMaps to estimat...

2017-05-23 Thread jkbradley
Github user jkbradley commented on the issue: https://github.com/apache/spark/pull/18077 Other than the tags, this LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled an

[GitHub] spark issue #18077: [SPARK-20861] Delegate looping over paramMaps to estimat...

2017-05-23 Thread jkbradley
Github user jkbradley commented on the issue: https://github.com/apache/spark/pull/18077 @MrBago Can you please add the tags "[ML][PYTHON]" to the title? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project doe

[GitHub] spark issue #11974: [SPARK-14174][ML] Accelerate KMeans via Mini-Batch EM

2017-05-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/11974 **[Test build #77287 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77287/testReport)** for PR 11974 at commit [`46d9c7b`](https://github.com/apache/spark/commit/46

[GitHub] spark issue #17770: [SPARK-20392][SQL] Set barrier to prevent re-entering a ...

2017-05-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17770 **[Test build #77286 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77286/testReport)** for PR 17770 at commit [`c0bee01`](https://github.com/apache/spark/commit/c0

[GitHub] spark issue #16989: [SPARK-19659] Fetch big blocks to disk when shuffle-read...

2017-05-23 Thread jinxing64
Github user jinxing64 commented on the issue: https://github.com/apache/spark/pull/16989 In current change: 1) remove the partial written file when failing 2) remove all shuffle files when `cleanup()`(this is registered as a task completion callback) --- If your project is se

[GitHub] spark issue #18082: [SPARK-20665][SQL][FOLLOW-UP]Move test case to SQLQueryT...

2017-05-23 Thread 10110346
Github user 10110346 commented on the issue: https://github.com/apache/spark/pull/18082 Done. Should i delete the unit test case from `MathFunctionsSuite.scala`? @gatorsmile --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request #17770: [SPARK-20392][SQL] Set barrier to prevent re-ente...

2017-05-23 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/17770#discussion_r118155011 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala --- @@ -912,3 +913,17 @@ case class Deduplicat

[GitHub] spark issue #16989: [SPARK-19659] Fetch big blocks to disk when shuffle-read...

2017-05-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16989 **[Test build #77285 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77285/testReport)** for PR 16989 at commit [`222680c`](https://github.com/apache/spark/commit/22

[GitHub] spark issue #16820: [SPARK-19471] AggregationIterator does not initialize th...

2017-05-23 Thread yangw1234
Github user yangw1234 commented on the issue: https://github.com/apache/spark/pull/16820 @gatorsmile Sorry, I totally forget this pr. I will try to address the comment this week (need a little time to re-familiarize the context). --- If your project is set up for it, you can reply t

[GitHub] spark issue #17770: [SPARK-20392][SQL] Set barrier to prevent re-entering a ...

2017-05-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17770 **[Test build #77284 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77284/testReport)** for PR 17770 at commit [`f3e4208`](https://github.com/apache/spark/commit/f3

[GitHub] spark issue #18078: [SPARK-10643] Make spark-submit download remote files to...

2017-05-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18078 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77271/ Test PASSed. ---

[GitHub] spark issue #18078: [SPARK-10643] Make spark-submit download remote files to...

2017-05-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18078 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

  1   2   3   4   5   >