[GitHub] spark issue #18141: [SPARK-20916][SQL] Improve error message for unaliased s...

2017-05-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18141 **[Test build #77521 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77521/testReport)** for PR 18141 at commit

[GitHub] spark issue #18141: [SPARK-20916][SQL] Improve error message for unaliased s...

2017-05-29 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/18141 @maropu Sure. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark pull request #18107: [SPARK-20883][SPARK-20376][SS] Refactored StateSt...

2017-05-29 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/18107#discussion_r118608662 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -828,6 +837,8 @@ class SQLConf extends Serializable with Logging {

[GitHub] spark pull request #18107: [SPARK-20883][SPARK-20376][SS] Refactored StateSt...

2017-05-29 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/18107#discussion_r119014976 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/statefulOperators.scala --- @@ -273,27 +333,34 @@ case class

[GitHub] spark pull request #18107: [SPARK-20883][SPARK-20376][SS] Refactored StateSt...

2017-05-29 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/18107#discussion_r119016141 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/statefulOperators.scala --- @@ -165,54 +189,88 @@ case class

[GitHub] spark pull request #18107: [SPARK-20883][SPARK-20376][SS] Refactored StateSt...

2017-05-29 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/18107#discussion_r118802674 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -552,6 +552,15 @@ object SQLConf { .booleanConf

[GitHub] spark pull request #18107: [SPARK-20883][SPARK-20376][SS] Refactored StateSt...

2017-05-29 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/18107#discussion_r119014965 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/statefulOperators.scala --- @@ -253,6 +311,8 @@ case class StateStoreSaveExec(

[GitHub] spark pull request #18107: [SPARK-20883][SPARK-20376][SS] Refactored StateSt...

2017-05-29 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/18107#discussion_r119014982 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/statefulOperators.scala --- @@ -304,8 +371,9 @@ case class

[GitHub] spark pull request #18107: [SPARK-20883][SPARK-20376][SS] Refactored StateSt...

2017-05-29 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/18107#discussion_r118804254 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamSuite.scala --- @@ -719,3 +745,23 @@ object ThrowingInterruptedIOException {

[GitHub] spark pull request #18107: [SPARK-20883][SPARK-20376][SS] Refactored StateSt...

2017-05-29 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/18107#discussion_r119014511 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/StateStore.scala --- @@ -47,50 +44,54 @@ trait StateStore { /**

[GitHub] spark pull request #18107: [SPARK-20883][SPARK-20376][SS] Refactored StateSt...

2017-05-29 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/18107#discussion_r118615627 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/statefulOperators.scala --- @@ -61,11 +60,24 @@ trait StateStoreReader extends

[GitHub] spark pull request #18107: [SPARK-20883][SPARK-20376][SS] Refactored StateSt...

2017-05-29 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/18107#discussion_r119014924 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/statefulOperators.scala --- @@ -165,54 +189,88 @@ case class

[GitHub] spark pull request #18107: [SPARK-20883][SPARK-20376][SS] Refactored StateSt...

2017-05-29 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/18107#discussion_r119014948 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/statefulOperators.scala --- @@ -165,54 +189,88 @@ case class

[GitHub] spark pull request #18107: [SPARK-20883][SPARK-20376][SS] Refactored StateSt...

2017-05-29 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/18107#discussion_r119013976 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/StateStore.scala --- @@ -102,28 +103,100 @@ trait StateStore { }

[GitHub] spark pull request #18107: [SPARK-20883][SPARK-20376][SS] Refactored StateSt...

2017-05-29 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/18107#discussion_r119014486 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/StateStore.scala --- @@ -47,50 +44,54 @@ trait StateStore { /**

[GitHub] spark issue #18142: [SPARK-20918] [SQL] Use FunctionIdentifier as function i...

2017-05-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18142 **[Test build #77520 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77520/testReport)** for PR 18142 at commit

[GitHub] spark pull request #18142: [SPARK-20918] [SQL] Use FunctionIdentifier as fun...

2017-05-29 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18142#discussion_r119014081 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala --- @@ -17,51 +17,74 @@ package

[GitHub] spark pull request #18142: [SPARK-20918] [SQL] Use FunctionIdentifier as fun...

2017-05-29 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18142#discussion_r119013261 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala --- @@ -1205,8 +1204,8 @@ class SessionCatalog(

[GitHub] spark pull request #18142: [SPARK-20918] [SQL] Use FunctionIdentifier as fun...

2017-05-29 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18142#discussion_r119013093 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala --- @@ -1116,8 +1115,8 @@ class SessionCatalog(

[GitHub] spark issue #18142: [SPARK-20918] [SQL] Use FunctionIdentifier as function i...

2017-05-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18142 **[Test build #77519 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77519/testReport)** for PR 18142 at commit

[GitHub] spark issue #18134: [SPARK-20909][SQL] Add build-int SQL function - DAYOFWEE...

2017-05-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18134 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77515/ Test PASSed. ---

[GitHub] spark issue #18134: [SPARK-20909][SQL] Add build-int SQL function - DAYOFWEE...

2017-05-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18134 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #18142: [SPARK-20918] [SQL] Use FunctionIdentifier as fun...

2017-05-29 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18142#discussion_r119012967 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala --- @@ -72,39 +89,53 @@ trait FunctionRegistry {

[GitHub] spark issue #18134: [SPARK-20909][SQL] Add build-int SQL function - DAYOFWEE...

2017-05-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18134 **[Test build #77515 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77515/testReport)** for PR 18134 at commit

[GitHub] spark pull request #18142: [SPARK-20918] [SQL] Use FunctionIdentifier as fun...

2017-05-29 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18142#discussion_r119012802 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala --- @@ -72,39 +89,53 @@ trait FunctionRegistry {

[GitHub] spark issue #18141: [SPARK-20916][SQL] Improve error message for unaliased s...

2017-05-29 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/18141 Better to add tests in `SQLQueryTestSuite`? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #18142: [SPARK-20918] [SQL] Use FunctionIdentifier as fun...

2017-05-29 Thread gatorsmile
GitHub user gatorsmile opened a pull request: https://github.com/apache/spark/pull/18142 [SPARK-20918] [SQL] Use FunctionIdentifier as function identifiers in FunctionRegistry ### What changes were proposed in this pull request? Currently, the unquoted string of a function

[GitHub] spark issue #18134: [SPARK-20909][SQL] Add build-int SQL function - DAYOFWEE...

2017-05-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18134 Build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark issue #18134: [SPARK-20909][SQL] Add build-int SQL function - DAYOFWEE...

2017-05-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18134 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77513/ Test PASSed. ---

[GitHub] spark issue #18134: [SPARK-20909][SQL] Add build-int SQL function - DAYOFWEE...

2017-05-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18134 **[Test build #77513 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77513/testReport)** for PR 18134 at commit

[GitHub] spark issue #18138: [SPARK-20915][SQL] Make lpad/rpad with empty pad string ...

2017-05-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18138 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77512/ Test PASSed. ---

[GitHub] spark issue #18138: [SPARK-20915][SQL] Make lpad/rpad with empty pad string ...

2017-05-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18138 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18138: [SPARK-20915][SQL] Make lpad/rpad with empty pad string ...

2017-05-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18138 **[Test build #77512 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77512/testReport)** for PR 18138 at commit

[GitHub] spark issue #14158: [SPARK-13547] [SQL] [WEBUI] Add SQL query in web UI's SQ...

2017-05-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14158 **[Test build #77518 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77518/testReport)** for PR 14158 at commit

[GitHub] spark issue #14158: [SPARK-13547] [SQL] [WEBUI] Add SQL query in web UI's SQ...

2017-05-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14158 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77518/ Test FAILed. ---

[GitHub] spark issue #14158: [SPARK-13547] [SQL] [WEBUI] Add SQL query in web UI's SQ...

2017-05-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14158 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14158: [SPARK-13547] [SQL] [WEBUI] Add SQL query in web UI's SQ...

2017-05-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14158 **[Test build #77518 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77518/testReport)** for PR 14158 at commit

[GitHub] spark issue #18134: [SPARK-20909][SQL] Add build-int SQL function - DAYOFWEE...

2017-05-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18134 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18134: [SPARK-20909][SQL] Add build-int SQL function - DAYOFWEE...

2017-05-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18134 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77514/ Test PASSed. ---

[GitHub] spark issue #18134: [SPARK-20909][SQL] Add build-int SQL function - DAYOFWEE...

2017-05-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18134 **[Test build #77514 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77514/testReport)** for PR 18134 at commit

[GitHub] spark pull request #17750: [SPARK-4899][MESOS] Support for Checkpointing on ...

2017-05-29 Thread lins05
Github user lins05 commented on a diff in the pull request: https://github.com/apache/spark/pull/17750#discussion_r119009317 --- Diff: docs/running-on-mesos.md --- @@ -516,6 +516,16 @@ See the [configuration page](configuration.html) for information on Spark config

[GitHub] spark issue #18140: [SPARK-20917][ML][SparkR] SparkR supports string encodin...

2017-05-29 Thread actuaryzhang
Github user actuaryzhang commented on the issue: https://github.com/apache/spark/pull/18140 @felixcheung Please take a look. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #18141: [SPARK-20916][SQL] Improve error message for unaliased s...

2017-05-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18141 **[Test build #77517 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77517/testReport)** for PR 18141 at commit

[GitHub] spark issue #18141: [SPARK-20916][SQL] Improve error message for unaliased s...

2017-05-29 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/18141 cc @JoshRosen @cloud-fan @hvanhovell @gatorsmile --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request #18141: [SPARK-20916][SQL] Improve error message for unal...

2017-05-29 Thread viirya
GitHub user viirya opened a pull request: https://github.com/apache/spark/pull/18141 [SPARK-20916][SQL] Improve error message for unaliased subqueries in FROM clause ## What changes were proposed in this pull request? We changed the parser to reject unaliased subqueries in

[GitHub] spark issue #14158: [SPARK-13547] [SQL] [WEBUI] Add SQL query in web UI's SQ...

2017-05-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14158 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14158: [SPARK-13547] [SQL] [WEBUI] Add SQL query in web UI's SQ...

2017-05-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14158 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77510/ Test PASSed. ---

[GitHub] spark issue #14158: [SPARK-13547] [SQL] [WEBUI] Add SQL query in web UI's SQ...

2017-05-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14158 **[Test build #77510 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77510/testReport)** for PR 14158 at commit

[GitHub] spark issue #18140: [SPARK-20917][ML][SparkR] SparkR supports string encodin...

2017-05-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18140 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18140: [SPARK-20917][ML][SparkR] SparkR supports string encodin...

2017-05-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18140 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77516/ Test PASSed. ---

[GitHub] spark pull request #14158: [SPARK-13547] [SQL] [WEBUI] Add SQL query in web ...

2017-05-29 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/14158#discussion_r119008402 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/ParseDriver.scala --- @@ -65,13 +65,29 @@ abstract class AbstractSqlParser

[GitHub] spark issue #18140: [SPARK-20917][ML][SparkR] SparkR supports string encodin...

2017-05-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18140 **[Test build #77516 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77516/testReport)** for PR 18140 at commit

[GitHub] spark pull request #14158: [SPARK-13547] [SQL] [WEBUI] Add SQL query in web ...

2017-05-29 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/14158#discussion_r119007096 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LogicalPlan.scala --- @@ -258,6 +258,9 @@ abstract class LogicalPlan

[GitHub] spark issue #18140: [SPARK-20917][ML][SparkR] SparkR supports string encodin...

2017-05-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18140 **[Test build #77516 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77516/testReport)** for PR 18140 at commit

[GitHub] spark issue #18134: [SPARK-20909][SQL] Add build-int SQL function - DAYOFWEE...

2017-05-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18134 **[Test build #77515 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77515/testReport)** for PR 18134 at commit

[GitHub] spark issue #18140: [SPARK-20917][ML][SparkR] SparkR supports string encodin...

2017-05-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18140 **[Test build #77511 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77511/testReport)** for PR 18140 at commit

[GitHub] spark issue #18140: [SPARK-20917][ML][SparkR] SparkR supports string encodin...

2017-05-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18140 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77511/ Test FAILed. ---

[GitHub] spark issue #18140: [SPARK-20917][ML][SparkR] SparkR supports string encodin...

2017-05-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18140 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18134: [SPARK-20909][SQL] Add build-int SQL function - DAYOFWEE...

2017-05-29 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/18134 LGTM except for one comment about the function description. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request #18134: [SPARK-20909][SQL] Add build-int SQL function - D...

2017-05-29 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/18134#discussion_r119002317 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala --- @@ -404,6 +404,44 @@ case class

[GitHub] spark issue #18122: [SPARK-20899][PySpark] PySpark supports stringIndexerOrd...

2017-05-29 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/18122 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark issue #18134: [SPARK-20909][SQL] Add build-int SQL function - DAYOFWEE...

2017-05-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18134 **[Test build #77514 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77514/testReport)** for PR 18134 at commit

[GitHub] spark issue #18122: [SPARK-20899][PySpark] PySpark supports stringIndexerOrd...

2017-05-29 Thread actuaryzhang
Github user actuaryzhang commented on the issue: https://github.com/apache/spark/pull/18122 @yanboliang I have moved the tests to the test file. Please let me know if there is anything else needed. Thanks. --- If your project is set up for it, you can reply to this email and have

[GitHub] spark issue #18118: SPARK-20199 : Provided featureSubsetStrategy to GBTClass...

2017-05-29 Thread pralabhkumar
Github user pralabhkumar commented on the issue: https://github.com/apache/spark/pull/18118 16ccbdf is successful . Please review the pull request . @MLnick @sethah @mpjlu @srowen --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request #18134: [SPARK-20909][SQL] Add build-int SQL function - D...

2017-05-29 Thread wangyum
Github user wangyum commented on a diff in the pull request: https://github.com/apache/spark/pull/18134#discussion_r119000601 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala --- @@ -402,6 +402,44 @@ case class

[GitHub] spark issue #18134: [SPARK-20909][SQL] Add build-int SQL function - DAYOFWEE...

2017-05-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18134 **[Test build #77513 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77513/testReport)** for PR 18134 at commit

[GitHub] spark issue #18138: [SPARK-20915][SQL] Make lpad/rpad with empty pad string ...

2017-05-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18138 **[Test build #77512 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77512/testReport)** for PR 18138 at commit

[GitHub] spark issue #18140: [ML][SparkR] SparkR supports string encoding consistent ...

2017-05-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18140 **[Test build #77511 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77511/testReport)** for PR 18140 at commit

[GitHub] spark pull request #18140: Spark r formula

2017-05-29 Thread actuaryzhang
GitHub user actuaryzhang opened a pull request: https://github.com/apache/spark/pull/18140 Spark r formula ## What changes were proposed in this pull request? Add `stringIndexerOrderType` to `spark.glm` and `spark.survreg` to support string encoding that is consistent with

[GitHub] spark issue #18122: [SPARK-20899][PySpark] PySpark supports stringIndexerOrd...

2017-05-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18122 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18122: [SPARK-20899][PySpark] PySpark supports stringIndexerOrd...

2017-05-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18122 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77509/ Test PASSed. ---

[GitHub] spark issue #18122: [SPARK-20899][PySpark] PySpark supports stringIndexerOrd...

2017-05-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18122 **[Test build #77509 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77509/testReport)** for PR 18122 at commit

[GitHub] spark pull request #14158: [SPARK-13547] [SQL] [WEBUI] Add SQL query in web ...

2017-05-29 Thread nblintao
Github user nblintao commented on a diff in the pull request: https://github.com/apache/spark/pull/14158#discussion_r11899 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/ParseDriver.scala --- @@ -50,13 +50,29 @@ abstract class AbstractSqlParser

[GitHub] spark pull request #14158: [SPARK-13547] [SQL] [WEBUI] Add SQL query in web ...

2017-05-29 Thread nblintao
Github user nblintao commented on a diff in the pull request: https://github.com/apache/spark/pull/14158#discussion_r118998724 --- Diff: core/src/main/scala/org/apache/spark/ui/UIUtils.scala --- @@ -326,7 +336,16 @@ private[spark] object UIUtils extends Logging { val

[GitHub] spark issue #14158: [SPARK-13547] [SQL] [WEBUI] Add SQL query in web UI's SQ...

2017-05-29 Thread nblintao
Github user nblintao commented on the issue: https://github.com/apache/spark/pull/14158 I have just rebased. @ajbozarth @HyukjinKwon @gatorsmile @srowen @vanzin --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark issue #14158: [SPARK-13547] [SQL] [WEBUI] Add SQL query in web UI's SQ...

2017-05-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14158 **[Test build #77510 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77510/testReport)** for PR 14158 at commit

[GitHub] spark pull request #17308: [SPARK-19968][SS] Use a cached instance of `Kafka...

2017-05-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/17308 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #17935: [SPARK-20690][SQL] Subqueries in FROM should have alias ...

2017-05-29 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/17935 @JoshRosen Thanks for filing this issue. I'll look into it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark issue #18122: [SPARK-20899][PySpark] PySpark supports stringIndexerOrd...

2017-05-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18122 **[Test build #77509 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77509/testReport)** for PR 18122 at commit

[GitHub] spark issue #17308: [SPARK-19968][SS] Use a cached instance of `KafkaProduce...

2017-05-29 Thread zsxwing
Github user zsxwing commented on the issue: https://github.com/apache/spark/pull/17308 LGTM. Merging to master and 2.2. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17935: [SPARK-20690][SQL] Subqueries in FROM should have alias ...

2017-05-29 Thread JoshRosen
Github user JoshRosen commented on the issue: https://github.com/apache/spark/pull/17935 I was trying to run a test case from another database which _does_ support unaliased subqueries in the `FROM` clause and hit a confusing parser error due to this patch's behavior change. While I

[GitHub] spark pull request #18132: [SPARK-8184][SQL] Add additional function descrip...

2017-05-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/18132 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #18132: [SPARK-8184][SQL] Add additional function description fo...

2017-05-29 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/18132 Thanks - merging in master/branch-2.2. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #13706: [SPARK-15988] [SQL] Implement DDL commands: Creat...

2017-05-29 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/13706#discussion_r118989451 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala --- @@ -1090,6 +1090,24 @@ class SessionCatalog(

[GitHub] spark pull request #13706: [SPARK-15988] [SQL] Implement DDL commands: Creat...

2017-05-29 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/13706#discussion_r118989143 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala --- @@ -1090,6 +1090,24 @@ class SessionCatalog(

[GitHub] spark pull request #13706: [SPARK-15988] [SQL] Implement DDL commands: Creat...

2017-05-29 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/13706#discussion_r118987906 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/NoSuchItemException.scala --- @@ -52,3 +52,6 @@ class

[GitHub] spark issue #17880: [SPARK-20620][TEST]Improve some unit tests for NullExpre...

2017-05-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17880 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77507/ Test PASSed. ---

[GitHub] spark issue #17880: [SPARK-20620][TEST]Improve some unit tests for NullExpre...

2017-05-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17880 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17880: [SPARK-20620][TEST]Improve some unit tests for NullExpre...

2017-05-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17880 **[Test build #77507 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77507/testReport)** for PR 17880 at commit

[GitHub] spark issue #18122: [SPARK-20899][PySpark] PySpark supports stringIndexerOrd...

2017-05-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18122 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18122: [SPARK-20899][PySpark] PySpark supports stringIndexerOrd...

2017-05-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18122 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77508/ Test FAILed. ---

[GitHub] spark issue #18122: [SPARK-20899][PySpark] PySpark supports stringIndexerOrd...

2017-05-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18122 **[Test build #77508 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77508/testReport)** for PR 18122 at commit

[GitHub] spark issue #18122: [SPARK-20899][PySpark] PySpark supports stringIndexerOrd...

2017-05-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18122 **[Test build #77508 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77508/testReport)** for PR 18122 at commit

[GitHub] spark issue #18139: Spark 20787 invalid years

2017-05-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18139 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request #18139: Spark 20787 invalid years

2017-05-29 Thread rberenguel
GitHub user rberenguel opened a pull request: https://github.com/apache/spark/pull/18139 Spark 20787 invalid years `time.mktime` can't handle dates from 1899-100, according to the documentation by design. `calendar.timegm` is equivalent in shared cases, but can handle those years.

[GitHub] spark pull request #18135: [SPARK-20907][test] Use testQuietly for test suit...

2017-05-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/18135 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #18135: [SPARK-20907][test] Use testQuietly for test suites that...

2017-05-29 Thread zsxwing
Github user zsxwing commented on the issue: https://github.com/apache/spark/pull/18135 LGTM. Merging to master and 2.2. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18138: [SPARK-20915][SQL] Make lpad/rpad with empty pad string ...

2017-05-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18138 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77505/ Test FAILed. ---

[GitHub] spark issue #18138: [SPARK-20915][SQL] Make lpad/rpad with empty pad string ...

2017-05-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18138 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18138: [SPARK-20915][SQL] Make lpad/rpad with empty pad string ...

2017-05-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18138 **[Test build #77505 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77505/testReport)** for PR 18138 at commit

  1   2   >