[GitHub] spark issue #18183: [SPARK-20961][SQL] generalize the dictionary in ColumnVe...

2017-06-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18183 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #18183: [SPARK-20961][SQL] generalize the dictionary in ColumnVe...

2017-06-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18183 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77667/ Test PASSed. ---

[GitHub] spark issue #18183: [SPARK-20961][SQL] generalize the dictionary in ColumnVe...

2017-06-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18183 **[Test build #77667 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77667/testReport)** for PR 18183 at commit [`b9c1a06`](https://github.com/apache/spark/commit/b

[GitHub] spark issue #18185: [SPARK-20962][SQL] Support subquery column aliases in FR...

2017-06-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18185 **[Test build #77671 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77671/testReport)** for PR 18185 at commit [`7d9d4ca`](https://github.com/apache/spark/commit/7d

[GitHub] spark pull request #18185: [SPARK-20962][SQL] Support subquery column aliase...

2017-06-01 Thread maropu
GitHub user maropu opened a pull request: https://github.com/apache/spark/pull/18185 [SPARK-20962][SQL] Support subquery column aliases in FROM clause ## What changes were proposed in this pull request? This pr added parsing rules to support subquery column aliases in FROM claus

[GitHub] spark issue #18184: [MINOR] [SQL] Update the description of spark.sql.files....

2017-06-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18184 **[Test build #77670 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77670/testReport)** for PR 18184 at commit [`5bde17e`](https://github.com/apache/spark/commit/5b

[GitHub] spark issue #18174: [SPARK-20950][CORE]Improve Serializerbuffersize configur...

2017-06-01 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/18174 I don't think that addresses my question? when would you set this separately? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark issue #18181: [SPARK-20958][SQL] Roll back parquet-mr 1.8.2 to 1.8.1

2017-06-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18181 **[Test build #77669 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77669/testReport)** for PR 18181 at commit [`c956201`](https://github.com/apache/spark/commit/c9

[GitHub] spark issue #18184: [MINOR] [SQL] Update the description of spark.sql.files....

2017-06-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18184 **[Test build #77668 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77668/testReport)** for PR 18184 at commit [`fc37005`](https://github.com/apache/spark/commit/fc

[GitHub] spark issue #18184: [MINOR] [SQL] Update the description of spark.sql.files....

2017-06-01 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/18184 cc @cloud-fan @sameeragarwal @ueshin --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature en

[GitHub] spark issue #18070: [SPARK-20713][Spark Core] Convert CommitDenied to TaskKi...

2017-06-01 Thread liyichao
Github user liyichao commented on the issue: https://github.com/apache/spark/pull/18070 How about Letting TaskCommitDenied and TaskKilled extend a same trait (for example, TaskKilledReason)? This way when accounting metrics, TaskCommitDenied and TaskKilled are all contributing to task

[GitHub] spark pull request #18184: [MINOR] [SQL] Update the description of spark.sql...

2017-06-01 Thread gatorsmile
GitHub user gatorsmile opened a pull request: https://github.com/apache/spark/pull/18184 [MINOR] [SQL] Update the description of spark.sql.files.ignoreCorruptFiles ### What changes were proposed in this pull request? When the file does not exist, we will issue the error message.

[GitHub] spark issue #18181: [SPARK-20958][SQL] Roll back parquet-mr 1.8.2 to 1.8.1

2017-06-01 Thread liancheng
Github user liancheng commented on the issue: https://github.com/apache/spark/pull/18181 @viirya Thanks for reminding! I'm reverting that one. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark issue #18181: [SPARK-20958][SQL] Roll back parquet-mr 1.8.2 to 1.8.1

2017-06-01 Thread liancheng
Github user liancheng commented on the issue: https://github.com/apache/spark/pull/18181 @dongjoon-hyun I already reverted PR #16751 manually but forgot to mention it in the PR description. --- If your project is set up for it, you can reply to this email and have your reply appear o

[GitHub] spark pull request #18128: [SPARK-20906][SparkR]:Constrained Logistic Regres...

2017-06-01 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/18128#discussion_r119788377 --- Diff: R/pkg/inst/tests/testthat/test_mllib_classification.R --- @@ -225,6 +225,32 @@ test_that("spark.logit", { model2 <- spark.logit(df2, labe

[GitHub] spark pull request #18128: [SPARK-20906][SparkR]:Constrained Logistic Regres...

2017-06-01 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/18128#discussion_r119787497 --- Diff: R/pkg/R/mllib_classification.R --- @@ -239,21 +253,57 @@ function(object, path, overwrite = FALSE) { setMethod("spark.logit", signature(dat

[GitHub] spark pull request #18128: [SPARK-20906][SparkR]:Constrained Logistic Regres...

2017-06-01 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/18128#discussion_r119788169 --- Diff: mllib/src/main/scala/org/apache/spark/ml/r/LogisticRegressionWrapper.scala --- @@ -97,7 +97,15 @@ private[r] object LogisticRegressionWrapper

[GitHub] spark issue #18148: [SPARK-20926][SQL] Removing exposures to guava library c...

2017-06-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18148 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #18148: [SPARK-20926][SQL] Removing exposures to guava library c...

2017-06-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18148 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77666/ Test PASSed. ---

[GitHub] spark issue #18148: [SPARK-20926][SQL] Removing exposures to guava library c...

2017-06-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18148 **[Test build #77666 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77666/testReport)** for PR 18148 at commit [`9421372`](https://github.com/apache/spark/commit/9

[GitHub] spark issue #18118: SPARK-20199 : Provided featureSubsetStrategy to GBTClass...

2017-06-01 Thread pralabhkumar
Github user pralabhkumar commented on the issue: https://github.com/apache/spark/pull/18118 12d83aa is successful . Please review the pull request . @MLnick @sethah @mpjlu @srowen --- If your project is set up for it, you can reply to this email and have your reply appear on GitH

[GitHub] spark issue #14783: SPARK-16785 R dapply doesn't return array or raw columns

2017-06-01 Thread catlain
Github user catlain commented on the issue: https://github.com/apache/spark/pull/14783 still have this issue when input data is a array column with different length each vector, like: ``` test1 key value 1 4dda7d68a202e9e3

[GitHub] spark issue #18108: [SPARK-20884] Spark' masters will be both standby due to...

2017-06-01 Thread liu-zhaokun
Github user liu-zhaokun commented on the issue: https://github.com/apache/spark/pull/18108 @srowen Hello,I have run "./test-dependencies.sh --replace-manifest" to update deps/* files,please review the new PR. --- If your project is set up for it, you can reply to this email and

[GitHub] spark issue #18172: [SPARK-20946][SQL] simplify the config setting logic in ...

2017-06-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18172 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77665/ Test PASSed. ---

[GitHub] spark issue #18172: [SPARK-20946][SQL] simplify the config setting logic in ...

2017-06-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18172 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #18172: [SPARK-20946][SQL] simplify the config setting logic in ...

2017-06-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18172 **[Test build #77665 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77665/testReport)** for PR 18172 at commit [`a8fe8b0`](https://github.com/apache/spark/commit/a

[GitHub] spark issue #17941: [SPARK-20684][R] Expose create[OrReplace]GlobalTempView ...

2017-06-01 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/17941 @cloud-fan thank you for chiming in. I have been looking for some feedback and I'm hoping we could get something more definitive. I'm sure there is a need to share context between differ

[GitHub] spark issue #18183: [SPARK-20961][SQL] generalize the dictionary in ColumnVe...

2017-06-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18183 **[Test build #77667 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77667/testReport)** for PR 18183 at commit [`b9c1a06`](https://github.com/apache/spark/commit/b9

[GitHub] spark issue #18183: [SPARK-20961][SQL] generalize the dictionary in ColumnVe...

2017-06-01 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/18183 cc @sameeragarwal @ueshin @gatorsmile --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature en

[GitHub] spark pull request #18183: [SPARK-20961][SQL] generalize the dictionary in C...

2017-06-01 Thread cloud-fan
GitHub user cloud-fan opened a pull request: https://github.com/apache/spark/pull/18183 [SPARK-20961][SQL] generalize the dictionary in ColumnVector ## What changes were proposed in this pull request? As the first step of https://issues.apache.org/jira/browse/SPARK-20960 , t

[GitHub] spark pull request #17723: [SPARK-20434][YARN][CORE] Move kerberos delegatio...

2017-06-01 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/17723#discussion_r119778509 --- Diff: core/pom.xml --- @@ -357,6 +357,34 @@ org.apache.commons commons-crypto + + + + ${hive.

[GitHub] spark issue #18148: [SPARK-20926][SQL] Removing exposures to guava library c...

2017-06-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18148 **[Test build #77666 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77666/testReport)** for PR 18148 at commit [`9421372`](https://github.com/apache/spark/commit/94

[GitHub] spark issue #18172: [SPARK-20946][SQL] simplify the config setting logic in ...

2017-06-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18172 **[Test build #77665 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77665/testReport)** for PR 18172 at commit [`a8fe8b0`](https://github.com/apache/spark/commit/a8

[GitHub] spark pull request #18172: [SPARK-20946][SQL] simplify the config setting lo...

2017-06-01 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18172#discussion_r119775018 --- Diff: mllib/src/test/scala/org/apache/spark/ml/tree/impl/TreeTests.scala --- @@ -43,7 +43,6 @@ private[ml] object TreeTests extends SparkFunSuite {

[GitHub] spark issue #18082: [SPARK-20665][SQL][FOLLOW-UP]Move test case to MathExpre...

2017-06-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18082 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77663/ Test PASSed. ---

[GitHub] spark issue #18082: [SPARK-20665][SQL][FOLLOW-UP]Move test case to MathExpre...

2017-06-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18082 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #18082: [SPARK-20665][SQL][FOLLOW-UP]Move test case to MathExpre...

2017-06-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18082 **[Test build #77663 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77663/testReport)** for PR 18082 at commit [`d9d245a`](https://github.com/apache/spark/commit/d

[GitHub] spark issue #18181: [SPARK-20958][SQL] Roll back parquet-mr 1.8.2 to 1.8.1

2017-06-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18181 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77662/ Test FAILed. ---

[GitHub] spark issue #18181: [SPARK-20958][SQL] Roll back parquet-mr 1.8.2 to 1.8.1

2017-06-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18181 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #18174: [SPARK-20950][CORE]Improve Serializerbuffersize configur...

2017-06-01 Thread heary-cao
Github user heary-cao commented on the issue: https://github.com/apache/spark/pull/18174 @srowen sorry, the description of pr would be wrong. so I modify to this PR. `spark.shuffle.file.buffer` is already configurable, in addition to other PR#18182 to describe it. `spar

[GitHub] spark issue #18181: [SPARK-20958][SQL] Roll back parquet-mr 1.8.2 to 1.8.1

2017-06-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18181 **[Test build #77662 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77662/testReport)** for PR 18181 at commit [`cf461d0`](https://github.com/apache/spark/commit/c

[GitHub] spark issue #18182: [SPARK-20950][CORE]Add a parameter to UnsafeExternalSort...

2017-06-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18182 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

[GitHub] spark pull request #18182: Add a parameter to UnsafeExternalSorter to config...

2017-06-01 Thread heary-cao
GitHub user heary-cao opened a pull request: https://github.com/apache/spark/pull/18182 Add a parameter to UnsafeExternalSorter to configure filebuffersize ## What changes were proposed in this pull request? This PR Improvement with `spark.shuffle.file.buffer` configure fil

[GitHub] spark issue #18180: [SPARK-20957][SS][Tests]Fix o.a.s.sql.streaming.Streamin...

2017-06-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18180 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #18180: [SPARK-20957][SS][Tests]Fix o.a.s.sql.streaming.Streamin...

2017-06-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18180 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77661/ Test PASSed. ---

[GitHub] spark issue #18180: [SPARK-20957][SS][Tests]Fix o.a.s.sql.streaming.Streamin...

2017-06-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18180 **[Test build #77661 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77661/testReport)** for PR 18180 at commit [`c3acd6d`](https://github.com/apache/spark/commit/c

[GitHub] spark pull request #18152: [SPARK-20930][ML] Destroy broadcasted centers aft...

2017-06-01 Thread zhengruifeng
Github user zhengruifeng commented on a diff in the pull request: https://github.com/apache/spark/pull/18152#discussion_r119767978 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/LDAModel.scala --- @@ -320,6 +320,7 @@ class LocalLDAModel private[spark] (

[GitHub] spark issue #18179: [SPARK-20894][SS] Resolve the checkpoint location in dri...

2017-06-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18179 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77660/ Test PASSed. ---

[GitHub] spark issue #17402: [SPARK-7200] Check that memory is not leaked in TaskMemo...

2017-06-01 Thread jsoltren
Github user jsoltren commented on the issue: https://github.com/apache/spark/pull/17402 Yes, I'll post an updated change once I wrap up a couple of other things... > Seems like the scope of the bug was a little larger than you thought. @vanzin The scope of the bug (spe

[GitHub] spark issue #18179: [SPARK-20894][SS] Resolve the checkpoint location in dri...

2017-06-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18179 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #18179: [SPARK-20894][SS] Resolve the checkpoint location in dri...

2017-06-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18179 **[Test build #77660 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77660/testReport)** for PR 18179 at commit [`a611c47`](https://github.com/apache/spark/commit/a

[GitHub] spark issue #18178: [SPARK-20922][core][hotfix] Don't use Java 8 lambdas in ...

2017-06-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18178 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #18178: [SPARK-20922][core][hotfix] Don't use Java 8 lambdas in ...

2017-06-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18178 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77658/ Test PASSed. ---

[GitHub] spark issue #18178: [SPARK-20922][core][hotfix] Don't use Java 8 lambdas in ...

2017-06-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18178 **[Test build #77658 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77658/testReport)** for PR 18178 at commit [`1deac9e`](https://github.com/apache/spark/commit/1

[GitHub] spark issue #18148: [SPARK-20926][SQL] Removing exposures to guava library c...

2017-06-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18148 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #18148: [SPARK-20926][SQL] Removing exposures to guava library c...

2017-06-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18148 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77664/ Test FAILed. ---

[GitHub] spark issue #18148: [SPARK-20926][SQL] Removing exposures to guava library c...

2017-06-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18148 **[Test build #77664 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77664/testReport)** for PR 18148 at commit [`9821ea1`](https://github.com/apache/spark/commit/9

[GitHub] spark issue #18148: [SPARK-20926][SQL] Removing exposures to guava library c...

2017-06-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18148 **[Test build #77664 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77664/testReport)** for PR 18148 at commit [`9821ea1`](https://github.com/apache/spark/commit/98

[GitHub] spark issue #12646: [SPARK-14878][SQL] Trim characters string function suppo...

2017-06-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/12646 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #12646: [SPARK-14878][SQL] Trim characters string function suppo...

2017-06-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/12646 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77656/ Test PASSed. ---

[GitHub] spark issue #12646: [SPARK-14878][SQL] Trim characters string function suppo...

2017-06-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/12646 **[Test build #77656 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77656/testReport)** for PR 12646 at commit [`0840a10`](https://github.com/apache/spark/commit/0

[GitHub] spark issue #17894: [WIP][SPARK-17134][ML] Use level 2 BLAS operations in Lo...

2017-06-01 Thread VinceShieh
Github user VinceShieh commented on the issue: https://github.com/apache/spark/pull/17894 @sethah yes, we only take 100 samples and trained with 3 iterations, numClasss is 20 of our test dataset for single node testing. Yeah, I also believe it'd have a better result if it's possibl

[GitHub] spark pull request #17723: [SPARK-20434][YARN][CORE] Move kerberos delegatio...

2017-06-01 Thread mgummelt
Github user mgummelt commented on a diff in the pull request: https://github.com/apache/spark/pull/17723#discussion_r119764880 --- Diff: core/pom.xml --- @@ -357,6 +357,34 @@ org.apache.commons commons-crypto + + + + ${hiv

[GitHub] spark issue #18177: [SPARK-20955][Core]Intern "executorId" to reduce the mem...

2017-06-01 Thread JoshRosen
Github user JoshRosen commented on the issue: https://github.com/apache/spark/pull/18177 LGTM. This seems like an easy win based on our empirical observations of high memory usage. I'm sure that we'll continue to find and fix others as we profile and heap dump more. --- If your proj

[GitHub] spark issue #18181: [SPARK-20958][SQL] Roll back parquet-mr 1.8.2 to 1.8.1

2017-06-01 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/18181 @liancheng After upgrading to Parquet 1.8.2, #16756 is another PR merged to remove a workaround for old Parquet issue. We should revert it too if rolling back parquet-mr 1.8.1. --- If your project

[GitHub] spark pull request #18171: [SPARK-20945] Fix TID key not found in TaskSchedu...

2017-06-01 Thread liupc
Github user liupc commented on a diff in the pull request: https://github.com/apache/spark/pull/18171#discussion_r119763935 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala --- @@ -240,8 +240,10 @@ private[spark] class TaskSchedulerImpl private[sche

[GitHub] spark issue #18160: [SPARK-20938][SQL] Keep/print the string representation ...

2017-06-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18160 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #18160: [SPARK-20938][SQL] Keep/print the string representation ...

2017-06-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18160 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77657/ Test PASSed. ---

[GitHub] spark issue #18160: [SPARK-20938][SQL] Keep/print the string representation ...

2017-06-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18160 **[Test build #77657 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77657/testReport)** for PR 18160 at commit [`5e8860e`](https://github.com/apache/spark/commit/5

[GitHub] spark issue #18181: [SPARK-20958][SQL] Roll back parquet-mr 1.8.2 to 1.8.1

2017-06-01 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/18181 Oh, it's already there in the code. Please just update the PR description. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If yo

[GitHub] spark issue #18181: [SPARK-20958][SQL] Roll back parquet-mr 1.8.2 to 1.8.1

2017-06-01 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/18181 Sorry for this trouble. @liancheng . Could you revert https://github.com/apache/spark/pull/16751 , too? --- If your project is set up for it, you can reply to this email and have your repl

[GitHub] spark pull request #18172: [SPARK-20946][SQL] simplify the config setting lo...

2017-06-01 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18172#discussion_r119762504 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala --- @@ -899,22 +899,14 @@ object SparkSession { // No active

[GitHub] spark pull request #18086: [SPARK-20854][SQL] Extend hint syntax to support ...

2017-06-01 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18086#discussion_r119762455 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/PlanParserSuite.scala --- @@ -527,47 +527,117 @@ class PlanParserSuite extends

[GitHub] spark issue #18082: [SPARK-20665][SQL][FOLLOW-UP]Move test case to MathExpre...

2017-06-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18082 **[Test build #77663 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77663/testReport)** for PR 18082 at commit [`d9d245a`](https://github.com/apache/spark/commit/d9

[GitHub] spark issue #18181: [SPARK-20958][SQL] Roll back parquet-mr 1.8.2 to 1.8.1

2017-06-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18181 **[Test build #77662 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77662/testReport)** for PR 18181 at commit [`cf461d0`](https://github.com/apache/spark/commit/cf

[GitHub] spark pull request #18181: [SPARK-20958][SQL] Roll back parquet-mr 1.8.2 to ...

2017-06-01 Thread liancheng
GitHub user liancheng opened a pull request: https://github.com/apache/spark/pull/18181 [SPARK-20958][SQL] Roll back parquet-mr 1.8.2 to 1.8.1 ## What changes were proposed in this pull request? This PR reverts PR #16791, #16817, and part of #16795 to roll back parquet-mr 1

[GitHub] spark issue #18172: [SPARK-20946][SQL] simplify the config setting logic in ...

2017-06-01 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/18172 LGTM except for one comment regarding the behavior change. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not hav

[GitHub] spark pull request #18172: [SPARK-20946][SQL] simplify the config setting lo...

2017-06-01 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/18172#discussion_r119761860 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala --- @@ -899,22 +899,14 @@ object SparkSession { // No active nor

[GitHub] spark issue #17714: [SPARK-20428][Core]REST interface about 'v1/submissions/...

2017-06-01 Thread tnachen
Github user tnachen commented on the issue: https://github.com/apache/spark/pull/17714 Unfortunately I'm not a committer, so need to loop in someone who is to help merge it though. @srowen do you know who's responsible for the general deploy package? --- If your project is set up fo

[GitHub] spark issue #18180: [SPARK-20957][SS][Tests]Fix o.a.s.sql.streaming.Streamin...

2017-06-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18180 **[Test build #77661 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77661/testReport)** for PR 18180 at commit [`c3acd6d`](https://github.com/apache/spark/commit/c3

[GitHub] spark issue #17714: [SPARK-20428][Core]REST interface about 'v1/submissions/...

2017-06-01 Thread guoxiaolongzte
Github user guoxiaolongzte commented on the issue: https://github.com/apache/spark/pull/17714 Hello, This PR has been created for some time now. please help to review the code,thanks. @tnachen --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request #18180: [SPARK-20957][SS][Tests]Fix o.a.s.sql.streaming.S...

2017-06-01 Thread zsxwing
GitHub user zsxwing opened a pull request: https://github.com/apache/spark/pull/18180 [SPARK-20957][SS][Tests]Fix o.a.s.sql.streaming.StreamingQueryManagerSuite listing ## What changes were proposed in this pull request? When stopping StreamingQuery, StreamExecution will se

[GitHub] spark pull request #18172: [SPARK-20946][SQL] simplify the config setting lo...

2017-06-01 Thread jiangxb1987
Github user jiangxb1987 commented on a diff in the pull request: https://github.com/apache/spark/pull/18172#discussion_r119757139 --- Diff: mllib/src/test/scala/org/apache/spark/ml/tree/impl/TreeTests.scala --- @@ -43,7 +43,6 @@ private[ml] object TreeTests extends SparkFunSuite {

[GitHub] spark pull request #18086: [SPARK-20854][SQL] Extend hint syntax to support ...

2017-06-01 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/18086#discussion_r119755764 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/PlanParserSuite.scala --- @@ -527,47 +527,117 @@ class PlanParserSuite extends Pla

[GitHub] spark issue #18148: [SPARK-20926][SQL] Removing exposures to guava library c...

2017-06-01 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/18148 Ah, yes. I read 'filter' instead of 'filterNot' in SparkBuild.scala where it sets `mimaProjects`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitH

[GitHub] spark pull request #18178: [SPARK-20922][core][hotfix] Don't use Java 8 lamb...

2017-06-01 Thread vanzin
Github user vanzin closed the pull request at: https://github.com/apache/spark/pull/18178 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark issue #18178: [SPARK-20922][core][hotfix] Don't use Java 8 lambdas in ...

2017-06-01 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/18178 The unit tests are way past the original failure now, so I'll push this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark issue #18148: [SPARK-20926][SQL] Removing exposures to guava library c...

2017-06-01 Thread zsxwing
Github user zsxwing commented on the issue: https://github.com/apache/spark/pull/18148 @vanzin the whole catalyst project is private. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have thi

[GitHub] spark issue #18177: [SPARK-20955][Core]Intern "executorId" to reduce the mem...

2017-06-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18177 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #18177: [SPARK-20955][Core]Intern "executorId" to reduce the mem...

2017-06-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18177 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77654/ Test PASSed. ---

[GitHub] spark issue #18177: [SPARK-20955][Core]Intern "executorId" to reduce the mem...

2017-06-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18177 **[Test build #77654 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77654/testReport)** for PR 18177 at commit [`38a4e31`](https://github.com/apache/spark/commit/3

[GitHub] spark issue #17402: [SPARK-7200] Check that memory is not leaked in TaskMemo...

2017-06-01 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/17402 @jsoltren do you plan to follow up on Josh's comments? Seems like the scope of the bug was a little larger than you thought. --- If your project is set up for it, you can reply to this email and hav

[GitHub] spark issue #18172: [SPARK-20946][SQL] simplify the config setting logic in ...

2017-06-01 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/18172 CC @liancheng --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or i

[GitHub] spark issue #18177: [SPARK-20955][Core]Intern "executorId" to reduce the mem...

2017-06-01 Thread zsxwing
Github user zsxwing commented on the issue: https://github.com/apache/spark/pull/18177 @srowen Considering Spark keeps 1000 stages in UI, if each stage has 1 tasks, the duplicated strings will be a lot. I observed this, about 150MB in a heap dump. Of cause, it's not significantly

[GitHub] spark pull request #18148: [SPARK-20926][SQL] Removing exposures to guava li...

2017-06-01 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/18148#discussion_r119753432 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala --- @@ -126,14 +127,56 @@ class SessionCatalog( }

[GitHub] spark pull request #17723: [SPARK-20434][YARN][CORE] Move kerberos delegatio...

2017-06-01 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/17723#discussion_r119753169 --- Diff: resource-managers/yarn/src/test/scala/org/apache/spark/deploy/yarn/security/YARNConfigurableCredentialManagerSuite.scala --- @@ -0,0 +1,61 @@

[GitHub] spark pull request #17723: [SPARK-20434][YARN][CORE] Move kerberos delegatio...

2017-06-01 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/17723#discussion_r119752861 --- Diff: resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/security/YARNConfigurableCredentialManager.scala --- @@ -0,0 +1,87 @@ +/*

[GitHub] spark pull request #17723: [SPARK-20434][YARN][CORE] Move kerberos delegatio...

2017-06-01 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/17723#discussion_r119751440 --- Diff: core/src/main/scala/org/apache/spark/deploy/security/ConfigurableCredentialManager.scala --- @@ -0,0 +1,120 @@ +/* + * Licensed to the Apa

[GitHub] spark pull request #17723: [SPARK-20434][YARN][CORE] Move kerberos delegatio...

2017-06-01 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/17723#discussion_r119751752 --- Diff: core/src/main/scala/org/apache/spark/deploy/security/HadoopFSCredentialProvider.scala --- @@ -0,0 +1,125 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request #17723: [SPARK-20434][YARN][CORE] Move kerberos delegatio...

2017-06-01 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/17723#discussion_r119750406 --- Diff: core/src/main/scala/org/apache/spark/deploy/security/ConfigurableCredentialManager.scala --- @@ -0,0 +1,120 @@ +/* + * Licensed to the Apa

  1   2   3   4   >