[GitHub] spark issue #18023: [SPARK-12139] [SQL] REGEX Column Specification

2017-06-30 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/18023 Let me post a confusing error message. ```Scala withSQLConf(SQLConf.SUPPORT_QUOTED_REGEX_COLUMN_NAME.key -> "true") { Seq((1, 1)).toDF("key",

[GitHub] spark pull request #18023: [SPARK-12139] [SQL] REGEX Column Specification

2017-06-30 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18023#discussion_r125155245 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -847,6 +847,12 @@ object SQLConf { .intConf

[GitHub] spark issue #17758: [SPARK-20460][SPARK-21144][SQL] Make it more consistent ...

2017-06-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17758 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79011/ Test FAILed. ---

[GitHub] spark issue #17758: [SPARK-20460][SPARK-21144][SQL] Make it more consistent ...

2017-06-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17758 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17758: [SPARK-20460][SPARK-21144][SQL] Make it more consistent ...

2017-06-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17758 **[Test build #79011 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79011/testReport)** for PR 17758 at commit

[GitHub] spark issue #18496: [SparkR][SPARK-20307]:SparkR: pass on setHandleInvalid t...

2017-06-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18496 **[Test build #79012 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79012/testReport)** for PR 18496 at commit

[GitHub] spark pull request #16028: [SPARK-18518][ML] HasSolver supports override

2017-06-30 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/16028#discussion_r125155063 --- Diff: mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala --- @@ -53,7 +53,23 @@ import org.apache.spark.storage.StorageLevel

[GitHub] spark pull request #16028: [SPARK-18518][ML] HasSolver supports override

2017-06-30 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/16028#discussion_r125155049 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/MultilayerPerceptronClassifier.scala --- @@ -75,17 +78,13 @@ private[classification]

[GitHub] spark issue #18496: [SparkR][SPARK-20307]:SparkR: pass on setHandleInvalid t...

2017-06-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18496 **[Test build #79009 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79009/testReport)** for PR 18496 at commit

[GitHub] spark issue #18496: [SparkR][SPARK-20307]:SparkR: pass on setHandleInvalid t...

2017-06-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18496 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79009/ Test FAILed. ---

[GitHub] spark issue #18496: [SparkR][SPARK-20307]:SparkR: pass on setHandleInvalid t...

2017-06-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18496 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #18496: [SparkR][SPARK-20307]:SparkR: pass on setHandleIn...

2017-06-30 Thread wangmiao1981
Github user wangmiao1981 commented on a diff in the pull request: https://github.com/apache/spark/pull/18496#discussion_r125154756 --- Diff: R/pkg/R/mllib_tree.R --- @@ -409,7 +413,7 @@ setMethod("spark.randomForest", signature(data = "SparkDataFrame", formula = "fo

[GitHub] spark pull request #18496: [SparkR][SPARK-20307]:SparkR: pass on setHandleIn...

2017-06-30 Thread wangmiao1981
Github user wangmiao1981 commented on a diff in the pull request: https://github.com/apache/spark/pull/18496#discussion_r125154735 --- Diff: R/pkg/R/mllib_tree.R --- @@ -374,6 +374,10 @@ setMethod("write.ml", signature(object = "GBTClassificationModel", path = "chara #'

[GitHub] spark pull request #18481: [SPARK-20889][SparkR] Grouped documentation for W...

2017-06-30 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/18481#discussion_r125154492 --- Diff: R/pkg/R/functions.R --- @@ -2871,10 +2874,10 @@ setMethod("ifelse", #' @details #' \code{cume_dist}: Returns the cumulative

[GitHub] spark pull request #18481: [SPARK-20889][SparkR] Grouped documentation for W...

2017-06-30 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/18481#discussion_r125154702 --- Diff: R/pkg/R/functions.R --- @@ -2844,27 +2872,16 @@ setMethod("ifelse", ## Window functions##

[GitHub] spark pull request #18485: [SPARK-21267][SS][DOCS] Update Structured Streami...

2017-06-30 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/18485#discussion_r125154655 --- Diff: docs/structured-streaming-programming-guide.md --- @@ -758,6 +763,16 @@ count(groupBy(df, "deviceType")) +You can also

[GitHub] spark pull request #18496: [SparkR][SPARK-20307]:SparkR: pass on setHandleIn...

2017-06-30 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/18496#discussion_r125154606 --- Diff: R/pkg/R/mllib_tree.R --- @@ -374,6 +374,10 @@ setMethod("write.ml", signature(object = "GBTClassificationModel", path = "chara #'

[GitHub] spark pull request #18496: [SparkR][SPARK-20307]:SparkR: pass on setHandleIn...

2017-06-30 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/18496#discussion_r125154616 --- Diff: R/pkg/R/mllib_tree.R --- @@ -409,7 +413,7 @@ setMethod("spark.randomForest", signature(data = "SparkDataFrame", formula = "fo

[GitHub] spark issue #18462: [Docs] Removed invalid joinTypes from javadoc of Dataset...

2017-06-30 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/18462 how about checking if we have tests for these two types (as not supported)? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark issue #18307: [SPARK-21100][SQL] describe should give quartiles simila...

2017-06-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18307 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18307: [SPARK-21100][SQL] describe should give quartiles simila...

2017-06-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18307 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79007/ Test PASSed. ---

[GitHub] spark issue #18307: [SPARK-21100][SQL] describe should give quartiles simila...

2017-06-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18307 **[Test build #79007 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79007/testReport)** for PR 18307 at commit

[GitHub] spark pull request #17280: [SPARK-19939] [ML] Add support for association ru...

2017-06-30 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/17280#discussion_r125154331 --- Diff: python/pyspark/ml/fpm.py --- @@ -186,29 +186,29 @@ class FPGrowth(JavaEstimator, HasItemsCol, HasPredictionCol, |[z]

[GitHub] spark pull request #17280: [SPARK-19939] [ML] Add support for association ru...

2017-06-30 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/17280#discussion_r125154338 --- Diff: python/pyspark/ml/fpm.py --- @@ -186,29 +186,29 @@ class FPGrowth(JavaEstimator, HasItemsCol, HasPredictionCol, |[z]

[GitHub] spark issue #14431: [SPARK-16258][SparkR] Automatically append the grouping ...

2017-06-30 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/14431 btw, if the key is the very first column, that sounds like prefix and not append? perhaps `return.data.frame.key.column` = `FALSE`? and about your comment, do you mean `key` in

[GitHub] spark issue #18444: [SPARK-16542][SQL][PYSPARK] Fix bugs about types that re...

2017-06-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18444 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18444: [SPARK-16542][SQL][PYSPARK] Fix bugs about types that re...

2017-06-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18444 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79008/ Test FAILed. ---

[GitHub] spark pull request #18334: [SPARK-21127] [SQL] Update statistics after data ...

2017-06-30 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18334#discussion_r125154201 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/CommandUtils.scala --- @@ -97,6 +106,10 @@ object CommandUtils extends Logging

[GitHub] spark issue #18444: [SPARK-16542][SQL][PYSPARK] Fix bugs about types that re...

2017-06-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18444 **[Test build #79008 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79008/testReport)** for PR 18444 at commit

[GitHub] spark pull request #18479: [SPARK-21273][SQL] Propagate logical plan stats u...

2017-06-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/18479 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #17640: [SPARK-17608][SPARKR]:Long type has incorrect serializat...

2017-06-30 Thread wangmiao1981
Github user wangmiao1981 commented on the issue: https://github.com/apache/spark/pull/17640 @jiangxb1987 The original PR has some issues that are not correctly handled. I will open a new PR when I figure out the right fix. I intended to close this PR. Thanks for closing it. --- If

[GitHub] spark issue #18479: [SPARK-21273][SQL] Propagate logical plan stats using vi...

2017-06-30 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/18479 Merging to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #18479: [SPARK-21273][SQL] Propagate logical plan stats using vi...

2017-06-30 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/18479 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark issue #18444: [SPARK-16542][SQL][PYSPARK] Fix bugs about types that re...

2017-06-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18444 **[Test build #79010 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79010/testReport)** for PR 18444 at commit

[GitHub] spark issue #18444: [SPARK-16542][SQL][PYSPARK] Fix bugs about types that re...

2017-06-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18444 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79010/ Test FAILed. ---

[GitHub] spark issue #18444: [SPARK-16542][SQL][PYSPARK] Fix bugs about types that re...

2017-06-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18444 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18465: [SPARK-21093][R] Terminate R's worker processes in the p...

2017-06-30 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/18465 I see, quite possibly it is bubbled up more because of that change. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request #18479: [SPARK-21273][SQL] Propagate logical plan stats u...

2017-06-30 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18479#discussion_r125154131 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/statsEstimation/BasicStatsEstimationSuite.scala --- @@ -77,37 +77,6 @@ class

[GitHub] spark issue #18444: [SPARK-16542][SQL][PYSPARK] Fix bugs about types that re...

2017-06-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18444 **[Test build #79010 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79010/testReport)** for PR 18444 at commit

[GitHub] spark issue #18496: [SparkR][SPARK-20307]:SparkR: pass on setHandleInvalid t...

2017-06-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18496 **[Test build #79009 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79009/testReport)** for PR 18496 at commit

[GitHub] spark issue #17758: [SPARK-20460][SPARK-21144][SQL] Make it more consistent ...

2017-06-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17758 **[Test build #79011 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79011/testReport)** for PR 17758 at commit

[GitHub] spark pull request #18496: [SparkR][SPARK-20307]:SparkR: pass on setHandleIn...

2017-06-30 Thread wangmiao1981
GitHub user wangmiao1981 opened a pull request: https://github.com/apache/spark/pull/18496 [SparkR][SPARK-20307]:SparkR: pass on setHandleInvalid to spark.mllib functions that use StringIndexer ## What changes were proposed in this pull request? For randomForest

[GitHub] spark pull request #17451: [SPARK-19866][ML][PySpark] Add local version of W...

2017-06-30 Thread holdenk
Github user holdenk commented on a diff in the pull request: https://github.com/apache/spark/pull/17451#discussion_r125154011 --- Diff: python/pyspark/ml/feature.py --- @@ -2869,6 +2871,20 @@ def findSynonyms(self, word, num): word = _convert_to_vector(word)

[GitHub] spark pull request #17451: [SPARK-19866][ML][PySpark] Add local version of W...

2017-06-30 Thread holdenk
Github user holdenk commented on a diff in the pull request: https://github.com/apache/spark/pull/17451#discussion_r125154035 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Word2Vec.scala --- @@ -274,6 +274,29 @@ class Word2VecModel private[ml] (

[GitHub] spark pull request #17451: [SPARK-19866][ML][PySpark] Add local version of W...

2017-06-30 Thread holdenk
Github user holdenk commented on a diff in the pull request: https://github.com/apache/spark/pull/17451#discussion_r125154018 --- Diff: python/pyspark/ml/feature.py --- @@ -2869,6 +2871,20 @@ def findSynonyms(self, word, num): word = _convert_to_vector(word)

[GitHub] spark pull request #18479: [SPARK-21273][SQL] Propagate logical plan stats u...

2017-06-30 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18479#discussion_r125153313 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LogicalPlanVisitor.scala --- @@ -0,0 +1,87 @@ +/* + *

[GitHub] spark pull request #18479: [SPARK-21273][SQL] Propagate logical plan stats u...

2017-06-30 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18479#discussion_r125153296 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LogicalPlanVisitor.scala --- @@ -0,0 +1,87 @@ +/* + *

[GitHub] spark issue #18388: [SPARK-21175] Reject OpenBlocks when memory shortage on ...

2017-06-30 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/18388 cc @zsxwing how strictly we require for shuffle service compatibility? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark issue #18388: [SPARK-21175] Reject OpenBlocks when memory shortage on ...

2017-06-30 Thread jinxing64
Github user jinxing64 commented on the issue: https://github.com/apache/spark/pull/18388 Yes, there is a change. Server side may return `OpenBlocksFailed` for the "open blocks" request, which means that old client is not compatible with new server. Is it acceptable ? --- If your

[GitHub] spark issue #18482: [SPARK-21262] Stop sending 'stream request' when shuffle...

2017-06-30 Thread jinxing64
Github user jinxing64 commented on the issue: https://github.com/apache/spark/pull/18482 In current change, it i fetching big chunk in memory and then writing to disk and then release the memory. I made this change for below reasons: 1. The client shouldn't break old shuffle

[GitHub] spark issue #18444: [SPARK-16542][SQL][PYSPARK] Fix bugs about types that re...

2017-06-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18444 **[Test build #79008 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79008/testReport)** for PR 18444 at commit

[GitHub] spark issue #18301: [SPARK-21052][SQL] Add hash map metrics to join

2017-06-30 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/18301 https://github.com/apache/spark/blob/fd1325522549937232f37215db53d6478f48644c/core/src/main/java/org/apache/spark/unsafe/map/BytesToBytesMap.java#L473 In the a probe at L473, if the slot

[GitHub] spark issue #18444: [SPARK-16542][SQL][PYSPARK] Fix bugs about types that re...

2017-06-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18444 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18444: [SPARK-16542][SQL][PYSPARK] Fix bugs about types that re...

2017-06-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18444 **[Test build #79006 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79006/testReport)** for PR 18444 at commit

[GitHub] spark issue #18444: [SPARK-16542][SQL][PYSPARK] Fix bugs about types that re...

2017-06-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18444 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79006/ Test FAILed. ---

[GitHub] spark issue #18444: [SPARK-16542][SQL][PYSPARK] Fix bugs about types that re...

2017-06-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18444 **[Test build #79006 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79006/testReport)** for PR 18444 at commit

[GitHub] spark issue #18307: [SPARK-21100][SQL] describe should give quartiles simila...

2017-06-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18307 **[Test build #79007 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79007/testReport)** for PR 18307 at commit

[GitHub] spark issue #18023: [SPARK-12139] [SQL] REGEX Column Specification

2017-06-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18023 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18023: [SPARK-12139] [SQL] REGEX Column Specification

2017-06-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18023 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79004/ Test FAILed. ---

[GitHub] spark issue #18023: [SPARK-12139] [SQL] REGEX Column Specification

2017-06-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18023 **[Test build #79004 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79004/testReport)** for PR 18023 at commit

[GitHub] spark pull request #18334: [SPARK-21127] [SQL] Update statistics after data ...

2017-06-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/18334 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #18334: [SPARK-21127] [SQL] Update statistics after data changin...

2017-06-30 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/18334 thanks, merging to master! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark pull request #18159: [SPARK-20703][SQL] Associate metrics with data wr...

2017-06-30 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18159#discussion_r125151880 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala --- @@ -19,24 +19,65 @@ package

[GitHub] spark pull request #18159: [SPARK-20703][SQL] Associate metrics with data wr...

2017-06-30 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18159#discussion_r125151815 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala --- @@ -19,24 +19,65 @@ package

[GitHub] spark pull request #18483: [SPARK-17528][SQL] data should be copied properly...

2017-06-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/18483 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #18483: [SPARK-17528][SQL] data should be copied properly before...

2017-06-30 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/18483 thanks for the review, merging to master! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #18388: [SPARK-21175] Reject OpenBlocks when memory shortage on ...

2017-06-30 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/18388 does this patch require server side change? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #18495: [SPARK-21275][ML] Update GLM test to use supportedFamily...

2017-06-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18495 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18495: [SPARK-21275][ML] Update GLM test to use supportedFamily...

2017-06-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18495 **[Test build #79005 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79005/testReport)** for PR 18495 at commit

[GitHub] spark issue #18495: [SPARK-21275][ML] Update GLM test to use supportedFamily...

2017-06-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18495 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79005/ Test PASSed. ---

[GitHub] spark issue #18482: [SPARK-21262] Stop sending 'stream request' when shuffle...

2017-06-30 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/18482 does this mean we have to fetch big chunks in memory and then writing to disk? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark issue #18480: [SPARK-21052][SQL][Follow-up] Add hash map metrics to jo...

2017-06-30 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/18480 Thanks @gatorsmile. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] spark issue #18476: [SPARK-20858][DOC][MINOR] Document ListenerBus event que...

2017-06-30 Thread sadikovi
Github user sadikovi commented on the issue: https://github.com/apache/spark/pull/18476 @JoshRosen Thank you for the comment! I updated config option name to reflect changes in master branch. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark issue #18023: [SPARK-12139] [SQL] REGEX Column Specification

2017-06-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18023 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18023: [SPARK-12139] [SQL] REGEX Column Specification

2017-06-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18023 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79003/ Test PASSed. ---

[GitHub] spark issue #18023: [SPARK-12139] [SQL] REGEX Column Specification

2017-06-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18023 **[Test build #79003 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79003/testReport)** for PR 18023 at commit

[GitHub] spark issue #18436: [SPARK-20073][SQL] Prints an explicit warning message in...

2017-06-30 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/18436 ok, done --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark issue #18465: [SPARK-21093][R] Terminate R's worker processes in the p...

2017-06-30 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/18465 FWIW, I don't know but I guess it happens randomly in the middle of any tests. My wild guess is it is related with triggering many tests (or maybe rebasing a lot to trigger the build). I saw it

[GitHub] spark issue #18495: [SPARK-21275][ML] Update GLM test to use supportedFamily...

2017-06-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18495 **[Test build #79005 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79005/testReport)** for PR 18495 at commit

[GitHub] spark pull request #18476: [SPARK-20858][DOC][MINOR] Document ListenerBus ev...

2017-06-30 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/18476#discussion_r125149417 --- Diff: docs/configuration.md --- @@ -1398,6 +1398,15 @@ Apart from these, the following properties are also available, and may be useful

[GitHub] spark pull request #18495: [SPARK-21275][ML] Update GLM test to use supporte...

2017-06-30 Thread actuaryzhang
GitHub user actuaryzhang opened a pull request: https://github.com/apache/spark/pull/18495 [SPARK-21275][ML] Update GLM test to use supportedFamilyNames ## What changes were proposed in this pull request? Update GLM test to use supportedFamilyNames as suggested here:

[GitHub] spark issue #18495: [SPARK-21275][ML] Update GLM test to use supportedFamily...

2017-06-30 Thread actuaryzhang
Github user actuaryzhang commented on the issue: https://github.com/apache/spark/pull/18495 @yanboliang --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] spark issue #11106: [SPARK-13225] [SQL] Support Intersect All/Distinct [WIP]

2017-06-30 Thread Tagar
Github user Tagar commented on the issue: https://github.com/apache/spark/pull/11106 another possible way to implement INTERSECT ALL https://issues.apache.org/jira/browse/SPARK-21274 --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark issue #18459: [SPARK-13534][PYSPARK] Using Apache Arrow to increase pe...

2017-06-30 Thread BryanCutler
Github user BryanCutler commented on the issue: https://github.com/apache/spark/pull/18459 Great, thanks @shaneknapp! Just let me know what I can do to help On Jun 30, 2017 4:52 PM, "shane" wrote: > i won't have time to think about and do

[GitHub] spark issue #18023: [SPARK-12139] [SQL] REGEX Column Specification

2017-06-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18023 **[Test build #79004 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79004/testReport)** for PR 18023 at commit

[GitHub] spark issue #18459: [SPARK-13534][PYSPARK] Using Apache Arrow to increase pe...

2017-06-30 Thread shaneknapp
Github user shaneknapp commented on the issue: https://github.com/apache/spark/pull/18459 i won't have time to think about and do something until monday... but i have some ideas. On Fri, Jun 30, 2017 at 4:29 PM, Bryan Cutler wrote:

[GitHub] spark issue #14431: [SPARK-16258][SparkR] Automatically append the grouping ...

2017-06-30 Thread NarineK
Github user NarineK commented on the issue: https://github.com/apache/spark/pull/14431 I think @falaki's approach is good, only I find the key which is passed as an argument together with x as an input of function is a little superfluous. --- If your project is set up for it, you

[GitHub] spark pull request #18023: [SPARK-12139] [SQL] REGEX Column Specification

2017-06-30 Thread janewangfb
Github user janewangfb commented on a diff in the pull request: https://github.com/apache/spark/pull/18023#discussion_r125147853 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -847,6 +847,11 @@ object SQLConf { .intConf

[GitHub] spark issue #18465: [SPARK-21093][R] Terminate R's worker processes in the p...

2017-06-30 Thread shivaram
Github user shivaram commented on the issue: https://github.com/apache/spark/pull/18465 @felixcheung are these failures happening from the gapply tests ? Also do we have a way to map the error code to an error reason ? --- If your project is set up for it, you can reply to this

[GitHub] spark issue #18459: [SPARK-13534][PYSPARK] Using Apache Arrow to increase pe...

2017-06-30 Thread BryanCutler
Github user BryanCutler commented on the issue: https://github.com/apache/spark/pull/18459 Thanks for checking on that Wes! @shaneknapp and @holdenk I definitely don't want you to go through dependency hell... :-1: I'm not too sure how to resolve this since I have no access to

[GitHub] spark issue #16158: [SPARK-18724][ML] Add TuningSummary for TrainValidationS...

2017-06-30 Thread hhbyyh
Github user hhbyyh commented on the issue: https://github.com/apache/spark/pull/16158 @MLnick Thanks for your attention. I'm not sure if SPARK-19053 is still active and maybe it's not a blocking issue for this change. If you don't mind, I'll extend the jira/PR scope to involve

[GitHub] spark pull request #18307: [SPARK-21100][SQL] describe should give quartiles...

2017-06-30 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/18307#discussion_r125146093 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -2205,37 +2205,151 @@ class Dataset[T] private[sql]( * // max 92.0

[GitHub] spark pull request #18307: [SPARK-21100][SQL] describe should give quartiles...

2017-06-30 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/18307#discussion_r125146112 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -2205,37 +2205,151 @@ class Dataset[T] private[sql]( * // max 92.0

[GitHub] spark pull request #18307: [SPARK-21100][SQL] describe should give quartiles...

2017-06-30 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/18307#discussion_r125146063 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -2205,37 +2205,151 @@ class Dataset[T] private[sql]( * // max 92.0

[GitHub] spark issue #17862: [SPARK-20602] [ML]Adding LBFGS optimizer and Squared_hin...

2017-06-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17862 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79002/ Test PASSed. ---

[GitHub] spark issue #17862: [SPARK-20602] [ML]Adding LBFGS optimizer and Squared_hin...

2017-06-30 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17862 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #17862: [SPARK-20602] [ML]Adding LBFGS optimizer and Squared_hin...

2017-06-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17862 **[Test build #79002 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79002/testReport)** for PR 17862 at commit

[GitHub] spark pull request #18023: [SPARK-12139] [SQL] REGEX Column Specification

2017-06-30 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18023#discussion_r125144859 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -847,6 +847,11 @@ object SQLConf { .intConf

[GitHub] spark issue #18384: [SPARK-21170] [CORE] Utils.tryWithSafeFinallyAndFailureC...

2017-06-30 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18384 **[Test build #3822 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3822/testReport)** for PR 18384 at commit

[GitHub] spark issue #14431: [SPARK-16258][SparkR] Automatically append the grouping ...

2017-06-30 Thread shivaram
Github user shivaram commented on the issue: https://github.com/apache/spark/pull/14431 Compared to introducing a new API, I think @falaki 's idea of adding a non-default option is better --- If your project is set up for it, you can reply to this email and have your reply appear on

  1   2   3   4   5   6   >