[GitHub] spark issue #16422: [SPARK-17642] [SQL] support DESC EXTENDED/FORMATTED tabl...

2017-09-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16422 **[Test build #81599 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81599/testReport)** for PR 16422 at commit

[GitHub] spark issue #16422: [SPARK-17642] [SQL] support DESC EXTENDED/FORMATTED tabl...

2017-09-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16422 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81598/ Test FAILed. ---

[GitHub] spark issue #16422: [SPARK-17642] [SQL] support DESC EXTENDED/FORMATTED tabl...

2017-09-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16422 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #16422: [SPARK-17642] [SQL] support DESC EXTENDED/FORMATTED tabl...

2017-09-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16422 **[Test build #81598 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81598/testReport)** for PR 16422 at commit

[GitHub] spark issue #19177: [BUILD][TEST][SPARKR] better file list regex to kick off...

2017-09-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19177 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19177: [BUILD][TEST][SPARKR] better file list regex to kick off...

2017-09-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19177 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81596/ Test PASSed. ---

[GitHub] spark issue #19177: [BUILD][TEST][SPARKR] better file list regex to kick off...

2017-09-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19177 **[Test build #81596 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81596/testReport)** for PR 19177 at commit

[GitHub] spark issue #16422: [SPARK-17642] [SQL] support DESC EXTENDED/FORMATTED tabl...

2017-09-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16422 **[Test build #81598 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81598/testReport)** for PR 16422 at commit

[GitHub] spark issue #18953: [SPARK-20682][SQL] Update ORC data source based on Apach...

2017-09-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18953 **[Test build #81597 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81597/testReport)** for PR 18953 at commit

[GitHub] spark issue #18953: [SPARK-20682][SQL] Update ORC data source based on Apach...

2017-09-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18953 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81597/ Test PASSed. ---

[GitHub] spark issue #18953: [SPARK-20682][SQL] Update ORC data source based on Apach...

2017-09-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18953 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19165: [SPARKR][BACKPORT-2.1] backporting package and test chan...

2017-09-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19165 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19165: [SPARKR][BACKPORT-2.1] backporting package and test chan...

2017-09-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19165 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81595/ Test FAILed. ---

[GitHub] spark issue #19165: [SPARKR][BACKPORT-2.1] backporting package and test chan...

2017-09-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19165 **[Test build #81595 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81595/testReport)** for PR 19165 at commit

[GitHub] spark issue #19004: [SPARK-21791][SQL] ORC should support column names with ...

2017-09-09 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/19004 Also, this PR is included into https://github.com/apache/spark/pull/17980, too. --- - To unsubscribe, e-mail:

[GitHub] spark issue #18953: [SPARK-20682][SQL] Update ORC data source based on Apach...

2017-09-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18953 **[Test build #81597 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81597/testReport)** for PR 18953 at commit

[GitHub] spark issue #19060: [WIP][SQL] Add DataSourceSuite validating data sources l...

2017-09-09 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/19060 Today, I've re-considered this PR from the bottom and from the beginning. To sum up, I realized that I've been wasting committer's review time. Especially, sorry for your effort,

[GitHub] spark pull request #19060: [WIP][SQL] Add DataSourceSuite validating data so...

2017-09-09 Thread dongjoon-hyun
Github user dongjoon-hyun closed the pull request at: https://github.com/apache/spark/pull/19060 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19177: [BUILD][TEST][SPARKR] better file list regex to kick off...

2017-09-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19177 **[Test build #81596 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81596/testReport)** for PR 19177 at commit

[GitHub] spark pull request #19004: [SPARK-21791][SQL] ORC should support column name...

2017-09-09 Thread dongjoon-hyun
Github user dongjoon-hyun closed the pull request at: https://github.com/apache/spark/pull/19004 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19004: [SPARK-21791][SQL] ORC should support column names with ...

2017-09-09 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/19004 Since this is a test case only PR to confirm that, I'll include this into https://github.com/apache/spark/pull/18953 to save committer's review efforts. ---

[GitHub] spark pull request #19177: [BUILD][SPARKR] better file list regex to kick of...

2017-09-09 Thread felixcheung
GitHub user felixcheung opened a pull request: https://github.com/apache/spark/pull/19177 [BUILD][SPARKR] better file list regex to kick off tests ## What changes were proposed in this pull request? more file regex ## How was this patch tested? Jenkins,

[GitHub] spark issue #18887: [SPARK-20642][core] Store FsHistoryProvider listing data...

2017-09-09 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/18887 I have the same concern, as @squito said above https://github.com/apache/spark/pull/18887#pullrequestreview-56700674. Refactoring the old codes does not seem pointless to me. To

[GitHub] spark issue #19165: [SPARKR][BACKPORT-2.1] backporting package and test chan...

2017-09-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19165 **[Test build #81595 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81595/testReport)** for PR 19165 at commit

[GitHub] spark issue #19176: [SPARK-21965] [SparkR] Add createOrReplaceGlobalTempView...

2017-09-09 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/19176 Ya. I was there, too. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #18975: [SPARK-4131] Support "Writing data into the filesystem f...

2017-09-09 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/18975 Thanks! Merged to master. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

2017-09-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/18975 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #18975: [SPARK-4131] Support "Writing data into the filesystem f...

2017-09-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18975 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #18975: [SPARK-4131] Support "Writing data into the filesystem f...

2017-09-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18975 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81594/ Test PASSed. ---

[GitHub] spark issue #18975: [SPARK-4131] Support "Writing data into the filesystem f...

2017-09-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18975 **[Test build #81594 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81594/testReport)** for PR 18975 at commit

[GitHub] spark issue #18975: [SPARK-4131] Support "Writing data into the filesystem f...

2017-09-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18975 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #18975: [SPARK-4131] Support "Writing data into the filesystem f...

2017-09-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18975 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81593/ Test PASSed. ---

[GitHub] spark issue #18975: [SPARK-4131] Support "Writing data into the filesystem f...

2017-09-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18975 **[Test build #81593 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81593/testReport)** for PR 18975 at commit

[GitHub] spark issue #18865: [SPARK-21610][SQL] Corrupt records are not handled prope...

2017-09-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18865 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #18865: [SPARK-21610][SQL] Corrupt records are not handled prope...

2017-09-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18865 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81591/ Test PASSed. ---

[GitHub] spark issue #18865: [SPARK-21610][SQL] Corrupt records are not handled prope...

2017-09-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18865 **[Test build #81591 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81591/testReport)** for PR 18865 at commit

[GitHub] spark issue #19176: [SPARK-21965] [SparkR] Add createOrReplaceGlobalTempView...

2017-09-09 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/19176 Ah yes thanks. I couldn't find it. I think we should leave the JIRA open and explain we should consider multiple session support (could be a big change) or some workaround for a

[GitHub] spark issue #19176: [SPARK-21965] [SparkR] Add createOrReplaceGlobalTempView...

2017-09-09 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/19176 I think it should be https://github.com/apache/spark/pull/17941. I was there too. --- - To unsubscribe, e-mail:

[GitHub] spark issue #19176: [SPARK-21965] [SparkR] Add createOrReplaceGlobalTempView...

2017-09-09 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/19176 Wait. We had this in PR earlier? And my suggestion is not to have this without having a method to control global session. As of now there isn't a way to keep a global session in R -

[GitHub] spark issue #19176: [SPARK-21965] [SparkR] Add createOrReplaceGlobalTempView...

2017-09-09 Thread yanboliang
Github user yanboliang commented on the issue: https://github.com/apache/spark/pull/19176 cc @felixcheung --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #18975: [SPARK-4131] Support "Writing data into the filesystem f...

2017-09-09 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/18975 LGTM pending Jenkins Thanks again! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #18865: [SPARK-21610][SQL] Corrupt records are not handle...

2017-09-09 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18865#discussion_r137930149 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/JsonFileFormat.scala --- @@ -113,6 +113,21 @@ class JsonFileFormat

[GitHub] spark pull request #18865: [SPARK-21610][SQL] Corrupt records are not handle...

2017-09-09 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18865#discussion_r137930066 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala --- @@ -2034,4 +2034,34 @@ class JsonSuite extends

[GitHub] spark pull request #18865: [SPARK-21610][SQL] Corrupt records are not handle...

2017-09-09 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18865#discussion_r137930045 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala --- @@ -2034,4 +2034,34 @@ class JsonSuite extends

[GitHub] spark pull request #18865: [SPARK-21610][SQL] Corrupt records are not handle...

2017-09-09 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18865#discussion_r137930040 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala --- @@ -2034,4 +2034,34 @@ class JsonSuite extends

[GitHub] spark issue #19176: [SPARK-21965] [SparkR] Add createOrReplaceGlobalTempView...

2017-09-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19176 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81592/ Test PASSed. ---

[GitHub] spark issue #19176: [SPARK-21965] [SparkR] Add createOrReplaceGlobalTempView...

2017-09-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19176 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19176: [SPARK-21965] [SparkR] Add createOrReplaceGlobalTempView...

2017-09-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19176 **[Test build #81592 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81592/testReport)** for PR 19176 at commit

[GitHub] spark pull request #19173: [Minor] [SQL] Correct DataFrame doc.

2017-09-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/19173 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19173: [Minor] [SQL] Correct DataFrame doc.

2017-09-09 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/19173 Thanks! Merged to master. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #19174: [SPARK-21963][CORE][TEST]Create temp file should be dele...

2017-09-09 Thread kiszk
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/19174 How about other test cases that use `File.createTempFile`? Did they clean the temp file correctly? --- - To unsubscribe, e-mail:

[GitHub] spark pull request #19169: [SPARK-21957][SQL] Add current_user function

2017-09-09 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19169#discussion_r137929831 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/CurrentUser.scala --- @@ -0,0 +1,47 @@ +/* + * Licensed to the

[GitHub] spark issue #19174: [SPARK-21963][CORE][TEST]Create temp file should be dele...

2017-09-09 Thread kiszk
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/19174 Is it better to use ` DELETE_ON_CLOSE`? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #18975: [SPARK-4131] Support "Writing data into the filesystem f...

2017-09-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18975 **[Test build #81594 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81594/testReport)** for PR 18975 at commit

[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

2017-09-09 Thread janewangfb
Github user janewangfb commented on a diff in the pull request: https://github.com/apache/spark/pull/18975#discussion_r137929328 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/InsertIntoHiveDirCommand.scala --- @@ -0,0 +1,131 @@ +/* + * Licensed to

[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

2017-09-09 Thread janewangfb
Github user janewangfb commented on a diff in the pull request: https://github.com/apache/spark/pull/18975#discussion_r137929284 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala --- @@ -1512,4 +1512,81 @@ class SparkSqlAstBuilder(conf: SQLConf)

[GitHub] spark issue #18975: [SPARK-4131] Support "Writing data into the filesystem f...

2017-09-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18975 **[Test build #81593 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81593/testReport)** for PR 18975 at commit

[GitHub] spark pull request #19172: [SPARK-21856] Add probability and rawPrediction t...

2017-09-09 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/19172#discussion_r137929197 --- Diff: python/pyspark/ml/tests.py --- @@ -1655,6 +1655,25 @@ def test_multinomial_logistic_regression_with_bound(self):

[GitHub] spark pull request #19172: [SPARK-21856] Add probability and rawPrediction t...

2017-09-09 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/19172#discussion_r137929052 --- Diff: python/pyspark/ml/classification.py --- @@ -1425,11 +1425,13 @@ class MultilayerPerceptronClassifier(JavaEstimator, HasFeaturesCol,

[GitHub] spark pull request #19172: [SPARK-21856] Add probability and rawPrediction t...

2017-09-09 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/19172#discussion_r137929080 --- Diff: python/pyspark/ml/classification.py --- @@ -1442,11 +1444,13 @@ def __init__(self, featuresCol="features", labelCol="label",

[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

2017-09-09 Thread janewangfb
Github user janewangfb commented on a diff in the pull request: https://github.com/apache/spark/pull/18975#discussion_r137929108 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/InsertIntoDataSourceDirCommand.scala --- @@ -0,0 +1,82 @@ +/* + *

[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

2017-09-09 Thread janewangfb
Github user janewangfb commented on a diff in the pull request: https://github.com/apache/spark/pull/18975#discussion_r137929091 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala --- @@ -1512,4 +1512,81 @@ class SparkSqlAstBuilder(conf: SQLConf)

[GitHub] spark issue #19176: [SPARK-21965] [SparkR] Add createOrReplaceGlobalTempView...

2017-09-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19176 **[Test build #81592 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81592/testReport)** for PR 19176 at commit

[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

2017-09-09 Thread janewangfb
Github user janewangfb commented on a diff in the pull request: https://github.com/apache/spark/pull/18975#discussion_r137929053 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala --- @@ -360,6 +360,31 @@ case class

[GitHub] spark pull request #19147: [WIP][SPARK-21190][SQL][PYTHON] Vectorized UDFs i...

2017-09-09 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/19147#discussion_r137929007 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/python/VectorizedPythonRunner.scala --- @@ -0,0 +1,329 @@ +/* + * Licensed to the

[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

2017-09-09 Thread janewangfb
Github user janewangfb commented on a diff in the pull request: https://github.com/apache/spark/pull/18975#discussion_r137929022 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala --- @@ -192,12 +245,23 @@ class AstBuilder(conf: SQLConf)

[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

2017-09-09 Thread janewangfb
Github user janewangfb commented on a diff in the pull request: https://github.com/apache/spark/pull/18975#discussion_r137929025 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala --- @@ -192,12 +245,23 @@ class AstBuilder(conf: SQLConf)

[GitHub] spark pull request #18975: [SPARK-4131] Support "Writing data into the files...

2017-09-09 Thread janewangfb
Github user janewangfb commented on a diff in the pull request: https://github.com/apache/spark/pull/18975#discussion_r137929001 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala --- @@ -192,12 +245,23 @@ class AstBuilder(conf: SQLConf)

[GitHub] spark pull request #19176: [SPARK-21965] [SparkR] Add createOrReplaceGlobalT...

2017-09-09 Thread yanboliang
GitHub user yanboliang opened a pull request: https://github.com/apache/spark/pull/19176 [SPARK-21965] [SparkR] Add createOrReplaceGlobalTempView and dropGlobalTempView for SparkR ## What changes were proposed in this pull request? Add ```createOrReplaceGlobalTempView``` and

[GitHub] spark issue #18875: [SPARK-21513][SQL] Allow UDF to_json support converting ...

2017-09-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18875 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81590/ Test FAILed. ---

[GitHub] spark issue #18875: [SPARK-21513][SQL] Allow UDF to_json support converting ...

2017-09-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18875 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #18875: [SPARK-21513][SQL] Allow UDF to_json support converting ...

2017-09-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18875 **[Test build #81590 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81590/testReport)** for PR 18875 at commit

[GitHub] spark issue #18865: [SPARK-21610][SQL] Corrupt records are not handled prope...

2017-09-09 Thread jmchung
Github user jmchung commented on the issue: https://github.com/apache/spark/pull/18865 @gatorsmile those negative cases are already added in `JsonSuite`. --- - To unsubscribe, e-mail:

[GitHub] spark issue #18865: [SPARK-21610][SQL] Corrupt records are not handled prope...

2017-09-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18865 **[Test build #81591 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81591/testReport)** for PR 18865 at commit

[GitHub] spark pull request #18865: [SPARK-21610][SQL] Corrupt records are not handle...

2017-09-09 Thread jmchung
Github user jmchung commented on a diff in the pull request: https://github.com/apache/spark/pull/18865#discussion_r137928316 --- Diff: docs/sql-programming-guide.md --- @@ -1542,6 +1542,10 @@ options. # Migration Guide +## Upgrading From Spark SQL 2.2 to 2.3

[GitHub] spark issue #18875: [SPARK-21513][SQL] Allow UDF to_json support converting ...

2017-09-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18875 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #18875: [SPARK-21513][SQL] Allow UDF to_json support converting ...

2017-09-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18875 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81589/ Test PASSed. ---

[GitHub] spark issue #18875: [SPARK-21513][SQL] Allow UDF to_json support converting ...

2017-09-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18875 **[Test build #81589 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81589/testReport)** for PR 18875 at commit

[GitHub] spark issue #18875: [SPARK-21513][SQL] Allow UDF to_json support converting ...

2017-09-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18875 Build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #18875: [SPARK-21513][SQL] Allow UDF to_json support converting ...

2017-09-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18875 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81588/ Test PASSed. ---

[GitHub] spark issue #18875: [SPARK-21513][SQL] Allow UDF to_json support converting ...

2017-09-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18875 **[Test build #81588 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81588/testReport)** for PR 18875 at commit

[GitHub] spark issue #19175: [SPARK-21964][SQL]Enable splitting the Aggregate (on Exp...

2017-09-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19175 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #19175: [SPARK-21964][SQL]Enable splitting the Aggregate ...

2017-09-09 Thread DonnyZone
GitHub user DonnyZone opened a pull request: https://github.com/apache/spark/pull/19175 [SPARK-21964][SQL]Enable splitting the Aggregate (on Expand) into a number of Aggregates for grouing analytics ## What changes were proposed in this pull request?

[GitHub] spark issue #18317: [SPARK-21113][CORE] Read ahead input stream to amortize ...

2017-09-09 Thread sitalkedia
Github user sitalkedia commented on the issue: https://github.com/apache/spark/pull/18317 Hi @zsxwing, could you find some time to take a look at this PR. --- - To unsubscribe, e-mail:

[GitHub] spark issue #18875: [SPARK-21513][SQL] Allow UDF to_json support converting ...

2017-09-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18875 **[Test build #81590 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81590/testReport)** for PR 18875 at commit

[GitHub] spark pull request #18029: [SPARK-20168] [DStream] Add changes to use kinesi...

2017-09-09 Thread yssharma
Github user yssharma commented on a diff in the pull request: https://github.com/apache/spark/pull/18029#discussion_r137926490 --- Diff: external/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/InitialPosition.scala --- @@ -0,0 +1,104 @@ +/* + * Licensed to

[GitHub] spark issue #19173: [Minor] [SQL] Correct DataFrame doc.

2017-09-09 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/19173 LGTM --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19134: [SPARK-21893][BUILD][STREAMING][WIP] Put Kafka 0.8 behin...

2017-09-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19134 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81586/ Test PASSed. ---

[GitHub] spark issue #19134: [SPARK-21893][BUILD][STREAMING][WIP] Put Kafka 0.8 behin...

2017-09-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19134 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19134: [SPARK-21893][BUILD][STREAMING][WIP] Put Kafka 0.8 behin...

2017-09-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19134 **[Test build #81586 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81586/testReport)** for PR 19134 at commit

[GitHub] spark issue #19167: [SPARK-21954][SQL] JacksonUtils should verify MapType's ...

2017-09-09 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/19167 Thanks @HyukjinKwon --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19173: [Minor] [SQL] Correct DataFrame doc.

2017-09-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19173 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19173: [Minor] [SQL] Correct DataFrame doc.

2017-09-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19173 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81587/ Test PASSed. ---

[GitHub] spark issue #19173: [Minor] [SQL] Correct DataFrame doc.

2017-09-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19173 **[Test build #81587 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81587/testReport)** for PR 19173 at commit

[GitHub] spark issue #19110: [SPARK-21027][ML][PYTHON] Added tunable parallelism to o...

2017-09-09 Thread WeichenXu123
Github user WeichenXu123 commented on the issue: https://github.com/apache/spark/pull/19110 Thanks @MLnick @BryanCutler . Would you mind helping review another similar PR #19122 ? We need some other features but blocking on that PR. Thanks! ---

[GitHub] spark pull request #18865: [SPARK-21610][SQL] Corrupt records are not handle...

2017-09-09 Thread jmchung
Github user jmchung commented on a diff in the pull request: https://github.com/apache/spark/pull/18865#discussion_r137924841 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala --- @@ -2034,4 +2034,25 @@ class JsonSuite extends

[GitHub] spark issue #18875: [SPARK-21513][SQL] Allow UDF to_json support converting ...

2017-09-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18875 **[Test build #81589 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81589/testReport)** for PR 18875 at commit

[GitHub] spark issue #18875: [SPARK-21513][SQL] Allow UDF to_json support converting ...

2017-09-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18875 **[Test build #81588 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81588/testReport)** for PR 18875 at commit

[GitHub] spark issue #19174: [SPARK-21963][CORE][TEST]Create temp file should be dele...

2017-09-09 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/19174 This is too trivial to bother with. The JVM cleans this on shutdown anyway. --- - To unsubscribe, e-mail:

[GitHub] spark issue #19174: [SPARK-21963][CORE][TEST]Create temp file should be dele...

2017-09-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19174 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

  1   2   >