Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19082
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82498/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19442
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82497/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19442
**[Test build #82496 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82496/testReport)**
for PR 19442 at commit
[`3d27852`](https://github.com/apache/spark/commit/3
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19442
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82496/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19082
**[Test build #82498 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82498/testReport)**
for PR 19082 at commit
[`a95816c`](https://github.com/apache/spark/commit/a
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19442
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19082
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19442
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19442
**[Test build #82497 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82497/testReport)**
for PR 19442 at commit
[`de0aa76`](https://github.com/apache/spark/commit/d
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/19082
retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h.
Github user krishna-pandey commented on the issue:
https://github.com/apache/spark/pull/19419
@dongjoon-hyun Made the changes as suggested.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For addit
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/19442
retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19082
**[Test build #82499 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82499/testReport)**
for PR 19082 at commit
[`a95816c`](https://github.com/apache/spark/commit/a9
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19250#discussion_r143122317
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
---
@@ -1213,6 +1213,71 @@ case class ToUTCTimestamp
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19442
**[Test build #82500 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82500/testReport)**
for PR 19442 at commit
[`de0aa76`](https://github.com/apache/spark/commit/de
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19250#discussion_r143122396
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
---
@@ -1015,6 +1020,10 @@ object DateTimeUtils {
guess
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19250#discussion_r143122503
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala ---
@@ -266,6 +267,10 @@ final class DataFrameWriter[T] private[sql](ds:
Dataset[
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19250#discussion_r143122657
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -230,6 +230,13 @@ case class AlterTableSetPropertiesCommand(
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19250#discussion_r143122895
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/TimestampTableTimeZone.scala
---
@@ -0,0 +1,213 @@
+/*
+ * Licensed to th
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/19340
kindly remind to @srowen and @yanboliang if you can take a look at it when
you have time, thanks.
---
-
To unsubscribe, e-mail:
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/19340
I'm kind of neutral given the complexity of adding this, but maybe it's the
least complexity you can get away with. @hhbyyh was adding something related:
https://issues.apache.org/jira/browse/SPARK-2
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19442
**[Test build #82500 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82500/testReport)**
for PR 19442 at commit
[`de0aa76`](https://github.com/apache/spark/commit/d
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19442
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82500/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19442
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/19082
I checked `q66` has two warnings on the current
master(83488cc3180ca18f829516f550766efb3095881e);
```
17/10/06 07:32:26 INFO WholeStageCodegenExec: Found too long generated
codes and JIT opti
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/18732
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: review
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18732
**[Test build #82501 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82501/testReport)**
for PR 18732 at commit
[`20fb1fe`](https://github.com/apache/spark/commit/20
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19082
**[Test build #82499 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82499/testReport)**
for PR 19082 at commit
[`a95816c`](https://github.com/apache/spark/commit/a
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19082
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19082
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82499/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19082
**[Test build #82502 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82502/testReport)**
for PR 19082 at commit
[`1880dfd`](https://github.com/apache/spark/commit/18
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/19442
retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19294
**[Test build #82504 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82504/testReport)**
for PR 19294 at commit
[`e41abc6`](https://github.com/apache/spark/commit/e4
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19442
**[Test build #82503 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82503/testReport)**
for PR 19442 at commit
[`de0aa76`](https://github.com/apache/spark/commit/de
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/19340
thanks for your replt @srowen. I saw it. My feeling is that so far there is
no distance metric definition on `Vectors`. If we add the cosine distance, than
we should add the Euclidean too there. Do
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/18460
Thank you for review, @gatorsmile . The following is a result from Hive
1.2.2.
```sql
hive> CREATE TABLE T AS SELECT named_struct('a',1);
hive> CREATE TABLE S AS SELECT named_struct
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19442
**[Test build #82503 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82503/testReport)**
for PR 19442 at commit
[`de0aa76`](https://github.com/apache/spark/commit/d
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19442
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19442
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82503/
Test PASSed.
---
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/18460
@gatorsmile . I updated the previous comment with more examples.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.ap
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18924
**[Test build #82505 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82505/testReport)**
for PR 18924 at commit
[`f181496`](https://github.com/apache/spark/commit/f1
Github user akopich commented on a diff in the pull request:
https://github.com/apache/spark/pull/18924#discussion_r143159334
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/clustering/LDAOptimizer.scala ---
@@ -462,31 +463,60 @@ final class OnlineLDAOptimizer extends LDAOpti
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18924
**[Test build #82506 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82506/testReport)**
for PR 18924 at commit
[`a81dae5`](https://github.com/apache/spark/commit/a8
Github user akopich commented on the issue:
https://github.com/apache/spark/pull/18924
So shall we ping @jkbradley, shan't we?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional command
GitHub user jsnowacki opened a pull request:
https://github.com/apache/spark/pull/19443
[SPARK-22212][SQL][PySpark] Some SQL functions in Python fail with string
column name
## What changes were proposed in this pull request?
The issue in JIRA:
[SPARK-22212](https://issues
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19443
**[Test build #82507 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82507/testReport)**
for PR 19443 at commit
[`9e52c63`](https://github.com/apache/spark/commit/9e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19443
**[Test build #82507 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82507/testReport)**
for PR 19443 at commit
[`9e52c63`](https://github.com/apache/spark/commit/9
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19443
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82507/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19443
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user jsnowacki commented on the issue:
https://github.com/apache/spark/pull/19370
I've added `- bin/*.cmd` to the AppVeyor file. Please let me know if this
is sufficient.
---
-
To unsubscribe, e-mail: reviews
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19370
**[Test build #82508 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82508/testReport)**
for PR 19370 at commit
[`5f52c79`](https://github.com/apache/spark/commit/5f
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18732
**[Test build #82501 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82501/testReport)**
for PR 18732 at commit
[`20fb1fe`](https://github.com/apache/spark/commit/2
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18732
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18732
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82501/
Test PASSed.
---
GitHub user jiangxb1987 opened a pull request:
https://github.com/apache/spark/pull/19444
[SPARK-22214][SQL] Refactor the list hive partitions code
## What changes were proposed in this pull request?
In this PR we make a few changes to the list hive partitions code, to make
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19444
**[Test build #82509 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82509/testReport)**
for PR 19444 at commit
[`8f50c7c`](https://github.com/apache/spark/commit/8f
GitHub user sohum2002 opened a pull request:
https://github.com/apache/spark/pull/19445
Dataset select all columns
The proposed two new additional functions is to help select all the columns
in a Dataset except for given columns.
You can merge this pull request into a Git repositor
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19444#discussion_r143168926
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
---
@@ -638,12 +638,14 @@ private[hive] class HiveClientImpl(
Github user sohum2002 closed the pull request at:
https://github.com/apache/spark/pull/19445
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
GitHub user sohum2002 opened a pull request:
https://github.com/apache/spark/pull/19446
Dataset optimization
The proposed two new additional functions is to help select all the columns
in a Dataset except for given columns.
You can merge this pull request into a Git repository by
Github user sohum2002 closed the pull request at:
https://github.com/apache/spark/pull/19446
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18924
**[Test build #82505 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82505/testReport)**
for PR 18924 at commit
[`f181496`](https://github.com/apache/spark/commit/f
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18924
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82505/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18924
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19370
@jsnowacki, would you mind if I ask squash those commits into single one so
that we can check if the squashed commit, having the changes in `appveyor.yml`
and `*.cmd`, actually triggers AppVeyor
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19370
Otherwise, looks good to me.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-ma
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19090
Build started:
[](https://ci.appveyor.com/project/spark-test/s
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18924
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18924
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82506/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18924
**[Test build #82506 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82506/testReport)**
for PR 18924 at commit
[`a81dae5`](https://github.com/apache/spark/commit/a
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19082
**[Test build #82502 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82502/testReport)**
for PR 19082 at commit
[`1880dfd`](https://github.com/apache/spark/commit/1
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19082
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82502/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19082
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user jsnowacki commented on the issue:
https://github.com/apache/spark/pull/19370
@HyukjinKwon Commit squashed to one as you've requested.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19370
**[Test build #82510 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82510/testReport)**
for PR 19370 at commit
[`aec49a0`](https://github.com/apache/spark/commit/ae
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19370
Yup, it looks triggering fine -
https://ci.appveyor.com/project/ApacheSoftwareFoundation/spark/build/1822-master
although I wonder why check mark does not appear. I think it is not specific
to
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19443
This might look okay within Python side because the fix looks minimised and
does not actually increase complexity much; however, I think we focus on API
consistency between other languages in ge
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19294
**[Test build #82504 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82504/testReport)**
for PR 19294 at commit
[`e41abc6`](https://github.com/apache/spark/commit/e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19294
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82504/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19294
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user szhem commented on the issue:
https://github.com/apache/spark/pull/19294
@mridulm sql-related tests were removed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands
Github user icexelloss commented on the issue:
https://github.com/apache/spark/pull/18664
Thanks @gatorsmile for the constructive feedback!
I don't want to make this more complicated but I also want to make sure we
are aware that there is also difference between Arrow/non-Arro
Github user icexelloss commented on the issue:
https://github.com/apache/spark/pull/18664
cc @ueshin
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@sp
Github user jsnowacki commented on the issue:
https://github.com/apache/spark/pull/19443
@HyukjinKwon Thanks for pointing that out. I think the argument about
consistency here is valid, though, I agree with @jaceklaskowski that changes
should go one way or the other, i.e. allow string
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19370
**[Test build #82508 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82508/testReport)**
for PR 19370 at commit
[`5f52c79`](https://github.com/apache/spark/commit/5
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19370
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19370
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82508/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19442
**[Test build #82511 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82511/testReport)**
for PR 19442 at commit
[`d828cf3`](https://github.com/apache/spark/commit/d8
Github user icexelloss commented on a diff in the pull request:
https://github.com/apache/spark/pull/18732#discussion_r143198047
--- Diff: python/pyspark/sql/group.py ---
@@ -192,7 +193,69 @@ def pivot(self, pivot_col, values=None):
jgd = self._jgd.pivot(pivot_col)
GitHub user mgaido91 opened a pull request:
https://github.com/apache/spark/pull/19447
[SPARK-22215][SQL] Add configuration to set the threshold for generated
class
## What changes were proposed in this pull request?
SPARK-18016 introduced an arbitrary threshold for the siz
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19447
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19443
> I think the argument about consistency here is valid, though, I agree
with @jaceklaskowski that changes should go one way or the other, i.e. allow
string column names or remove this option com
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/19412
Merged to master
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/19412
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19443
I think it's okay to wait for a few days more and for other committers who
might support or like this idea before closing this. I won't stay against.
Providing more compelling reasons sh
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19444
**[Test build #82509 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82509/testReport)**
for PR 19444 at commit
[`8f50c7c`](https://github.com/apache/spark/commit/8
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19444
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19444
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82509/
Test PASSed.
---
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/19447#discussion_r143202186
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -279,11 +279,13 @@ class CodegenContext {
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/19438#discussion_r143202515
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/ApproximatePercentileQuerySuite.scala
---
@@ -129,7 +144,7 @@ class ApproximatePercentileQuerySuite ex
1 - 100 of 357 matches
Mail list logo
