Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19778
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19778
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84060/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19778
**[Test build #84060 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84060/testReport)**
for PR 19778 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19389
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19389
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84059/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19389
**[Test build #84059 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84059/testReport)**
for PR 19389 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19779
**[Test build #84065 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84065/testReport)**
for PR 19779 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19621
**[Test build #84066 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84066/testReport)**
for PR 19621 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19790
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84057/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19607
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84062/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19790
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19607
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19607
**[Test build #84062 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84062/testReport)**
for PR 19607 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19790
**[Test build #84057 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84057/testReport)**
for PR 19790 at commit
Github user holdenk commented on the issue:
https://github.com/apache/spark/pull/19753
I can take a look tomorrow, been traveling but just got back.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19468#discussion_r152204337
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/constants.scala
---
@@ -0,0 +1,49 @@
+/*
+ * Licensed to the
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19468#discussion_r152219315
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/KubernetesClusterSchedulerBackend.scala
---
@@ -0,0
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19468#discussion_r152219175
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/KubernetesClusterSchedulerBackend.scala
---
@@ -0,0
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19468#discussion_r152217750
--- Diff:
resource-managers/kubernetes/core/src/test/scala/org/apache/spark/scheduler/cluster/k8s/KubernetesClusterSchedulerBackendSuite.scala
---
@@ -0,0
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19468#discussion_r152204683
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodFactory.scala
---
@@ -0,0 +1,229 @@
+/*
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19468#discussion_r152211914
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodFactory.scala
---
@@ -0,0 +1,229 @@
+/*
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19468#discussion_r152217789
--- Diff:
resource-managers/kubernetes/core/src/test/scala/org/apache/spark/scheduler/cluster/k8s/KubernetesClusterSchedulerBackendSuite.scala
---
@@ -0,0
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19468#discussion_r152219574
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/KubernetesClusterSchedulerBackend.scala
---
@@ -0,0
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19468#discussion_r152217994
--- Diff:
resource-managers/kubernetes/core/src/test/scala/org/apache/spark/scheduler/cluster/k8s/KubernetesClusterSchedulerBackendSuite.scala
---
@@ -0,0
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19468#discussion_r152214967
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/KubernetesClusterSchedulerBackend.scala
---
@@ -0,0
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19468#discussion_r152218513
--- Diff:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocator.scala
---
@@ -22,15 +22,14 @@ import java.util.concurrent._
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19468#discussion_r152200362
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/SparkKubernetesClientFactory.scala
---
@@ -0,0 +1,103 @@
+/*
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19730#discussion_r15498
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CastSuite.scala
---
@@ -827,4 +827,49 @@ class CastSuite extends
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19730
**[Test build #84064 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84064/testReport)**
for PR 19730 at commit
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/19787
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19776#discussion_r152206765
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategySuite.scala
---
@@ -0,0 +1,307 @@
+/*
+ *
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19787
thanks, merging to master!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19787
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84058/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19787
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19776
**[Test build #84063 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84063/testReport)**
for PR 19776 at commit
Github user jliwork commented on the issue:
https://github.com/apache/spark/pull/19776
@cloud-fan Thank you for your comments! I have updated the test cases as
you suggested.
---
-
To unsubscribe, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19607
**[Test build #84062 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84062/testReport)**
for PR 19607 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19737
**[Test build #84061 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84061/testReport)**
for PR 19737 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19778
**[Test build #84060 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84060/testReport)**
for PR 19778 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19755
can you give a simple example to convince people that un-reused subqueries
should be displayed separately? the TPC-DS example is really hard to read.
---
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19607#discussion_r152201452
--- Diff: python/pyspark/sql/types.py ---
@@ -1678,37 +1678,105 @@ def from_arrow_schema(arrow_schema):
for field in arrow_schema])
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19787
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19790
**[Test build #84057 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84057/testReport)**
for PR 19790 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19737
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19787
**[Test build #84058 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84058/testReport)**
for PR 19787 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19389
**[Test build #84059 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84059/testReport)**
for PR 19389 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19389
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19787
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19778
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19776
LGTM except a few minor comments
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19790#discussion_r152200760
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -205,27 +209,32 @@ case class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19776#discussion_r152200656
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala
---
@@ -296,8 +296,33 @@ class JDBCSuite extends SparkFunSuite
//
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19389
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19607
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84048/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19776
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84055/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19389
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84051/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19746
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84046/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19607
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19389
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19778
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19746
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19389
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84049/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19737
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84054/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19778
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84050/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19776
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19776
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19776
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84047/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19787
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19778
**[Test build #84052 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84052/testReport)**
for PR 19778 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19787
**[Test build #84056 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84056/testReport)**
for PR 19787 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19776
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19389
**[Test build #84051 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84051/testReport)**
for PR 19389 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19778
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19778
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84052/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19787
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84056/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19776
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84053/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19737
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19776
**[Test build #84053 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84053/testReport)**
for PR 19776 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19778
**[Test build #84050 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84050/testReport)**
for PR 19778 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19746
**[Test build #84046 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84046/testReport)**
for PR 19746 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19776
**[Test build #84047 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84047/testReport)**
for PR 19776 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19389
**[Test build #84049 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84049/testReport)**
for PR 19389 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19737
**[Test build #84054 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84054/testReport)**
for PR 19737 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19607
**[Test build #84048 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84048/testReport)**
for PR 19607 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19776
**[Test build #84055 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84055/testReport)**
for PR 19776 at commit
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19776#discussion_r152200310
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategySuite.scala
---
@@ -0,0 +1,302 @@
+/*
+ *
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19776#discussion_r152200223
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategySuite.scala
---
@@ -0,0 +1,302 @@
+/*
+ *
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19776#discussion_r152200130
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategySuite.scala
---
@@ -0,0 +1,302 @@
+/*
+ *
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19776#discussion_r152200166
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategySuite.scala
---
@@ -0,0 +1,302 @@
+/*
+ *
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19776#discussion_r152200090
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategySuite.scala
---
@@ -0,0 +1,302 @@
+/*
+ *
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19776#discussion_r152200107
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategySuite.scala
---
@@ -0,0 +1,302 @@
+/*
+ *
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19787
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19607#discussion_r152199700
--- Diff: python/pyspark/sql/types.py ---
@@ -1678,37 +1678,105 @@ def from_arrow_schema(arrow_schema):
for field in arrow_schema])
301 - 393 of 393 matches
Mail list logo
